- 30 Oct, 2018 40 commits
-
-
Jonathan Backer authored
crrev.com/c/1284435 introduced a bug where if we flushed due to deadline but had potentially evictable resources for the future, we would not ScheduleEvictExpiredResourcesIn Also added a micro-optimization where if we evict all resources OnMemoryPressure, we also flush to reclaim it immediately. Added unittests to cover flushing logic. Dependency injected fake clock to make test robust. Bug: 899002 Change-Id: I50ca934170ebe76e7f48326e53e60df14c32c078 Reviewed-on: https://chromium-review.googlesource.com/c/1299601 Commit-Queue: Jonathan Backer <backer@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#603921}
-
Nate Fischer authored
No change to production logic. This adds tests for AwContentsStatics.setCheckClearTextPermitted(). This changes AwContentsStaticsTest to not start the browser process by default, because the cleartext tests need to call setCheckClearTextPermitted() before AwURLRequestContextGetter is initialized. This modifies testClearClientCertPreferences() only to restore the previous behavior of that test. R=torne@chromium.org Bug: 899012 Test: run_webview_instrumentation_test_apk --gtest_filter=AwContentsStaticsTest#* Change-Id: I2142ac56370edc4912ec5344ec3ddac86d214b2d Reviewed-on: https://chromium-review.googlesource.com/c/1299148Reviewed-by:
Paul Jensen <pauljensen@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Commit-Queue: Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#603920}
-
Ioana Pandele authored
TBR=sahel@chromium.org Bug: 899222 Change-Id: I10f5ecb0fe5d2408ba9c4f96257aafccf1bf3ce7 Reviewed-on: https://chromium-review.googlesource.com/c/1307441Reviewed-by:
Ioana Pandele <ioanap@chromium.org> Commit-Queue: Ioana Pandele <ioanap@chromium.org> Cr-Commit-Position: refs/heads/master@{#603919}
-
Koji Ishii authored
Following recent failures are from r603783 (CL:1304180) that changed the base expectations. fast/forms/access-key.html fast/forms/focus-selection-input.html fast/forms/focus-selection-textarea.html Taken from build 11225> TBR=eae@chromium.org, mstensho@chromium.org NOTRY=true Bug: 591099 Change-Id: I57acf3fbd593886dc197e6b57c5f70d545b91be9 Reviewed-on: https://chromium-review.googlesource.com/c/1307953Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#603918}
-
Becca Hughes authored
C++ bindings have a kMinValue and kMaxValue in mojo enums. This adds the same to the Java bindings. BUG=899802 Change-Id: Ic3dd6ca5b665c6ed6adbd5ffcc80e93573dc51c6 Reviewed-on: https://chromium-review.googlesource.com/c/1305193Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#603917}
-
Olivier Robin authored
Per HTML specification https://html.spec.whatwg.org/multipage/form-control-infrastructure.html#form-submission-algorithm step 6 the event event is only triggered if the form is not submitted using the submit() method (-> submitted by an inside element). This means that some form submissions are missed by autofill and we miss some profile save and some metrics. Hook HTMLFormElement.submit so we can trigger the form submission handler in that case. Bug: 857436 Change-Id: I53a831412b62197ef96d1f08d5943ff861815edf Reviewed-on: https://chromium-review.googlesource.com/c/1298210Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#603916}
-
David Bokan authored
PendingOffsetToScroll was previously used to store where the layout box was being scrolled to. There was a pre-RLS fixup to this value but it's no longer set to anything other than its initial value so this CL removes the entire value. Bug: 823365,741830 Change-Id: I4d4090b629ad614bf691ea6360240fea7d43982d Reviewed-on: https://chromium-review.googlesource.com/c/1305818Reviewed-by:
Sandra Sun <sunyunjia@chromium.org> Commit-Queue: David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#603915}
-
Koji Ishii authored
Following bot results are included. 11147 11195 11202 11211 11215 11217 11221 11224 11225 28 lines were removed and 2 lines were deflaked by consecutive results since 11135. TBR=eae@chromium.org, mstensho@chromium.org NOTRY=true Bug: 591099 Change-Id: I673ac19ec57bfdf5bd14ec6f220b7d3dff8f7818 Reviewed-on: https://chromium-review.googlesource.com/c/1304040 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
-
Scott Violet authored
This updates the call to event injection so that it does not go through rewriters. BUG=876043 TEST=covered by tests Change-Id: Ib4f0190fa26ed66c6004fdde7c66134b4b49bdcd Reviewed-on: https://chromium-review.googlesource.com/c/1306693Reviewed-by:
David Tseng <dtseng@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#603913}
-
Charlie Harrison authored
URL rules have two vectors of domains: domains to exclude matching on, and domains to include matching on (i.e. only match on those domains). Many URL rules share vectors, so we can compress the data by only writing domain vectors once, and referencing existing vectors when we hit a duplicate. This should slow down indexing, but cut down on memory and disk usage. No meaningful behavior should change. Extensions code is not modified, so their ruleset version is not incremented, which would trigger an unnecessary re-indexing. Bug: 899790 Change-Id: Ic5763f8e65185441c1df9774961b9e004f777f31 Reviewed-on: https://chromium-review.googlesource.com/c/1305497 Commit-Queue: Charlie Harrison <csharrison@chromium.org> Reviewed-by:
Josh Karlin <jkarlin@chromium.org> Cr-Commit-Position: refs/heads/master@{#603912}
-
Andrew Grieve authored
Change-Id: Ic07f2fbdd112b96cd8960e0282eaafdddf52b4db Reviewed-on: https://chromium-review.googlesource.com/c/1306789Reviewed-by:
Mohamed Heikal <mheikal@chromium.org> Commit-Queue: Mohamed Heikal <mheikal@chromium.org> Cr-Commit-Position: refs/heads/master@{#603911}
-
Geoff Lang authored
Offset the scissor and viewports based on the current surface's draw offset. This is needed for small direct composition surfaces. BUG=898001 Change-Id: I9869a5513ff728f77c70b35aba8757c969b53adc Reviewed-on: https://chromium-review.googlesource.com/c/1301955 Commit-Queue: Geoff Lang <geofflang@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Cr-Commit-Position: refs/heads/master@{#603910}
-
Vaclav Brozek authored
The PasswordToSave function inside NewPasswordFormManager is used to extract the password to be saved from a filled password form. This can either be the form's new-password or current-password (the latter only if there is no new-password). Currently, the PasswordToSave function returns the current-password if, in particular, the new-password field has an empty name. This breaks for sites which choose to assign no name to the new-password field. Therefore this CL changes that behaviour to only check for field values and ignore their names. Note: The old parser created dummy "anonymous*" names for unnamed fields, so while the old PasswordFormManager::PasswordToSave function has the same property as the new one, it was not an issue there. Bug: 899687 Change-Id: I31a67533f470ba62b7a3a835d1dd3d9e9ce5bab4 Reviewed-on: https://chromium-review.googlesource.com/c/1307438Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Commit-Queue: Vaclav Brozek <vabr@chromium.org> Cr-Commit-Position: refs/heads/master@{#603909}
-
chrome://histogramsAlexei Svitkine authored
Bug: 899870 Change-Id: I3be5d81e2b8dc1bdb14c1dc19a0d4efbd34015fb Reviewed-on: https://chromium-review.googlesource.com/c/1305823Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#603908}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/2966c3c1332b..dfe69cae695e git log 2966c3c1332b..dfe69cae695e --date=short --no-merges --format='%ad %ae %s' 2018-10-30 lalitm@google.com trace_processor: add support for python synthesised e2e tests 2018-10-30 lalitm@google.com Merge "trace_processor: fix bug with span join" Created with: gclient setdep -r src/third_party/perfetto@dfe69cae695e The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:117596113 TBR=perfetto-bugs@google.com Change-Id: I3a5f4645df147b1c073de0cb2031eaa18759eda8 Reviewed-on: https://chromium-review.googlesource.com/c/1306771Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#603907}
-
Alex Clarke authored
Add benchmarks for UI and IO message loops. TBR=altimin@chromium.org Bug: 897751 Change-Id: I617f329afae84107df3c10c9262139946a6037b9 Reviewed-on: https://chromium-review.googlesource.com/c/1307507Reviewed-by:
Alex Clarke <alexclarke@chromium.org> Commit-Queue: Alex Clarke <alexclarke@chromium.org> Cr-Commit-Position: refs/heads/master@{#603906}
-
Tibor Goldschwendt authored
This is a reland of 0a8ce562 with a fix for x86 crashes (see crbug/899732 for more details). Original change's description: > Reland "[vr] On-demand install VR dynamic feature module" > > This is a reland of 0275d360 with a fix > for x86 builders, which have VR disabled. > > Original change's description: > > [vr] On-demand install VR dynamic feature module > > > > With this CL we initate the module install once the user enters VR on a > > WebXR/VR page. In more detail this CL > > > > - Introduces native VrModuleDelegate used to request VR module from > > native, > > > > - Refactors GvrDevice to request the VR module as part of its > > initialization flow, > > > > - Adds native side of the VrModuleProvider for Java-native > > communication. > > > > Bug: 862689 > > Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel > > Change-Id: I960d2bdd4d2c64a19fa6069e457d44f77ab0e73b > > Reviewed-on: https://chromium-review.googlesource.com/c/1241458 > > Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> > > Reviewed-by: Ted Choc <tedchoc@chromium.org> > > Reviewed-by: Bill Orr <billorr@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#602922} > > TBR=tedchoc@chromium.org,billorr@chromium.org > > Bug: 862689 > Change-Id: I7a0f383534b622e0e4acb5acb2a1c28e547d0970 > Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel > Reviewed-on: https://chromium-review.googlesource.com/c/1301568 > Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org> > Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> > Cr-Commit-Position: refs/heads/master@{#603100} TBR=tedchoc@chromium.org,billorr@chromium.org Bug: 862689,899732 Change-Id: I944f97d82d04f3dc64f44a3379551f09ca1326f3 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Reviewed-on: https://chromium-review.googlesource.com/c/1305816Reviewed-by:
agrieve <agrieve@chromium.org> Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#603905}
-
Vaclav Brozek authored
The FormData -> PasswordForm parser has a special "saving" mode, in which it optimizes for saving filled-in forms. This means that the parser ignores fields with empty values, because from those nothing can be saved. That has been true for using structural heuristics. But when the form contained autocomplete attributes or there were server hints for it, the parser would trust those even if they hinted at fields with empty values. There seems to be no reason to try to save empty-valued fields, under any circumstances, so this CL filters fields with empty values out before the parser does any kind of analysis. Bug: 899687 Change-Id: Ia5e2ff885c9f15917765c5cb70ab5501ecc40118 Reviewed-on: https://chromium-review.googlesource.com/c/1307401Reviewed-by:
-
Vaclav Brozek authored
The unittest for the FormData -> PasswordForm parser takes a description of a form and of the parsing result, synthesises the form, parses it and compares to the expected result. To keep the descriptions short, many unimportant things are generated, such as unique values of fields. Then, when a test fails, the error messages refer to the generated values, saying things like: "expected the current password to be html_304 but it is actually html_511". This makes little sense when one cannot see the form synthesised from the description. So this CL adds logging to describe the form when test failures are encoutered. Bug: 899687 Change-Id: Ic0ffdc348a490c8f1fcb3e2f193ac10a348f2494 Reviewed-on: https://chromium-review.googlesource.com/c/1307398Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/5785405afa1b..52a715455181 git log 5785405afa1b..52a715455181 --date=short --no-merges --format='%ad %ae %s' 2018-10-30 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader e83048e2bbfa..70942e2e8566 (1 commits) 2018-10-30 mtklein@chromium.org replace SkNVRefCnt with SkRefCnt 2018-10-30 mtklein@google.com use from/to_srgb only when known to be in [0,1] 2018-10-30 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader d0a4800e1487..e83048e2bbfa (1 commits) 2018-10-30 reed@google.com declare SkFont SK_API Created with: gclient setdep -r src/third_party/skia@52a715455181 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel TBR=herb@chromium.org Change-Id: I8868620d874da56190edbd02728bffae79845895 Reviewed-on: https://chromium-review.googlesource.com/c/1307553Reviewed-by:
-
Vaclav Brozek authored
The structure used to record expectations in the unittest for FormData -> PasswordForm parser allows to specify the "role" of a field -- whether that field should end up marked as the username or one of the passwords. It currently allows marking a field with a role specific for the "filling" or the "saving" mode of the parser. But it does not allow one field to have different roles in different modes. This has not been an issue, but will be in the coming CLs, where some fields will be "current password" in one mode and "new password" in the other. Therefore, this CL adds separate roles in the expectation struct to capture potentially different roles in different modes. The CL keeps the original role data member, overriding the two specialised new ones, to keep this change and the tests themselves less verbose. As a side effect, the role-describing enum is now shrinked to about a third of its original size (due to the previous need to have explicit values saying "role X for filling", "role X for saving", "role X for both"). Bug: 899687 Change-Id: Ia8c3bf433a0fc1b003b6b38a11e43ddaffb3387e Reviewed-on: https://chromium-review.googlesource.com/c/1307493Reviewed-by:
-
Aiden Benner authored
'Proxy' native methods are declared in an @JniStaticNatives interface without a native qualifier and indicate that the JNI annotation processor should generate code to link between the equivalent native method as if it were declare statically. Under the hood the annotation processor generates the actual native method declaration in another another class (org.chromium.base.natives.GEN_JNI) but generates wrapper code so it can be called through the declaring class. This CL adds support to the python header generator to generate header files and registration header files for native methods declared in an @JniStaticNatives annotated interface which uses the JNI annotation processor. Change-Id: I7a1c10f67d6b7c7dad3423634bdb995e76e751a4 Bug: 898261 Reviewed-on: https://chromium-review.googlesource.com/c/1297184 Commit-Queue: Aiden Benner <abenner@google.com> Reviewed-by:
Eric Stevenson <estevenson@chromium.org> Cr-Commit-Position: refs/heads/master@{#603900}
-
Xiaocheng Hu authored
This patch changes tests in the following directories to use Element.innerText for text dump: fast/encoding fast/events Most of this patch is mechanical rebaseline, except that some LayoutNG-specific baselines become redundant and are removed Bug: 887148 Change-Id: I057efbdbaa17a03c3f87cfec30e293a5ddd9a57f Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Reviewed-on: https://chromium-review.googlesource.com/c/1297488Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#603899}
-
Paul Wankadia authored
https://chromium.googlesource.com/external/github.com/google/re2.git/+log/89528a380a7e..22caec62055a $ git log 89528a380..22caec620 --date=short --no-merges --format='%ad %ae %s' 2018-10-29 junyer Don't waste time fuzzing programs with large substrings. Created with: roll-dep src/third_party/re2/src R=mmoroz@chromium.org Bug: 899899 Change-Id: I156d3208d36b212ec8d1e676dde8d676eb86946b Reviewed-on: https://chromium-review.googlesource.com/c/1307234Reviewed-by:
Max Moroz <mmoroz@chromium.org> Commit-Queue: Max Moroz <mmoroz@chromium.org> Cr-Commit-Position: refs/heads/master@{#603898}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/1e86cbac5c24..a3993dd6c128 Created with: gclient setdep -r src-internal@a3993dd6c128 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I50771f3a1af8c1eba2dddde6b521f68e1d39b5cf Reviewed-on: https://chromium-review.googlesource.com/c/1306772Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#603897}
-
Ehsan Chiniforooshan authored
The perf dashboard shows that we are not generating data for any of the thread_times.* benchmarks since early June. This CL deletes the unused benchmarks. Bug: 890757 Change-Id: I9101fbf59ded8d3b749ed95f5ac46c8c8ada3b73 Reviewed-on: https://chromium-review.googlesource.com/c/1306175 Commit-Queue: Ehsan Chiniforooshan <chiniforooshan@chromium.org> Reviewed-by:
enne <enne@chromium.org> Reviewed-by:
Emily Hanley <eyaich@chromium.org> Cr-Commit-Position: refs/heads/master@{#603896}
-
Ioana Pandele authored
This reverts commit 9a4121a6. Reason for revert: Compile failure on mac_dbg https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8931231951930679168/+/steps/compile/0/stdout Original change's description: > Benchmark various types of messageloop > > Add menchmarks for UI and IO message loops > > Bug: 897751 > Change-Id: I7b487055aecfb6a2f486c7d241aaddc8f472813f > Reviewed-on: https://chromium-review.googlesource.com/c/1304521 > Commit-Queue: Alex Clarke <alexclarke@chromium.org> > Reviewed-by: Alexander Timin <altimin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#603888} TBR=alexclarke@chromium.org,altimin@chromium.org Change-Id: Id3608cad30a14e68255227d9d51690ec66c86c97 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 897751 Reviewed-on: https://chromium-review.googlesource.com/c/1307506Reviewed-by:
-
Nicolas Ouellet-payeur authored
Bug: 898675 Change-Id: I30ade484ed47cb2254eba66cc7ac8fc69a26bb47 Reviewed-on: https://chromium-review.googlesource.com/c/1299273Reviewed-by:
Owen Min <zmin@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org> Cr-Commit-Position: refs/heads/master@{#603894}
-
Owen Min authored
Disable the following test: SessionHandlingTest.testGetSessions SessionHandlingTest.testQuitASessionMoreThanOnce SupportIPv4AndIPv6.testSupportIPv4AndIPv6 ZChromeStartRetryCountTest.testChromeStartRetryCount Bug: 899919 Change-Id: I4fdebcce8d0784f4a03d740fe75cad489e7cc2f1 Tbr: johnchen@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/1307594Reviewed-by:
-
Michael Lippautz authored
The tests execute GC from JS which is not sufficient for unifiedh heap. The fix adds proper GCs before asserting that the leak is not present. Bug: 843903 Change-Id: Ieecf14acdbec96ebb6f612523ca0fa12aba92ad2 Reviewed-on: https://chromium-review.googlesource.com/c/1307395Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#603892}
-
Richard Li authored
This CL de-couples typemapping between content::SWFetchRequest and blink::mojom::FetchAPIRequest. The target of this work is removing content::SWFetchRequest. Since content::SWFetchRequest is a widely used class. Removing it in one CL resulting in unacceptable large size of CL. In order to seperate the work into sereral steps. A converter was added to make convertion between two structures in this CL. In my plan, content::SWFetchRequest will be removed in a series of CLs gradually. The ultimate target of the whole work is moving fetch_api_request.mojom into third_party/blink/public/mojom/fetch/ folder. To accomplish the goal, the whole work is seperated into six parts. 1. Remove content::RequestContextType. Use blink.mojom.RequestContextType instead. --------- CL:1229704 2. Remove content::ServiceWorkerFetchRequest. Use blink.mojom.FetchAPIRequest instead. --------This CL. 3. Remove blink::WebURLRequest::RequestContext. Use blink.mojom.RequestContextType instead. --------- CL:1242301 4. Remove blink::WebServiceWorkerRequest. Use blink.mojom.FetchAPIRequest instead. 5. Remove blink::WebReferrerPolicy. Use blink::mojom::ReferrerPolicy instead. --------- CL:1212345 6. Remove content::Referrer, blink::Referrer Use blink::mojom::Referrer instead. Once all the above tasks get done, fetch_api_request.mojom can be moved into that folder. Change-Id: I2b299bd8b2830afffefe111716170c1a29e41098 Bug: 789854 Reviewed-on: https://chromium-review.googlesource.com/c/1288084 Commit-Queue: Richard Li <richard.li@intel.com> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#603891}
-
Keishi Hattori authored
Converts all HeapDeque allocations from new to MakeGarbageCollected. Allocations using new will be banned from now on. Bug: 757708 Change-Id: I42e1a4c551c04be4df8e1cb6b4fa1b6fa5908ebf Reviewed-on: https://chromium-review.googlesource.com/c/1306972Reviewed-by:
-
Jan Wilken Doerrie authored
This is a reland of bbe71c7f Original change's description: > [base] Harden base::JSONWriter::BuildJSONString > > This change simplifies and hardens base::JSONWriter::BuildJSONString(). > It replaces the old base::Value API with the new one, thus implicitly > replacing DCHECKs with CHECKs. > > Bug: 859477 > Change-Id: I5aa68cbc1e5e241d7b7061da2fe7078ac2904ec8 > Reviewed-on: https://chromium-review.googlesource.com/c/1304477 > Reviewed-by: Robert Sesek <rsesek@chromium.org> > Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> > Cr-Commit-Position: refs/heads/master@{#603508} Bug: 859477, 900041 Change-Id: I0111b5ac553736cdec5b7a163527bf3bb7cb9233 Reviewed-on: https://chromium-review.googlesource.com/c/1306356Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#603889}
-
Alex Clarke authored
Add menchmarks for UI and IO message loops Bug: 897751 Change-Id: I7b487055aecfb6a2f486c7d241aaddc8f472813f Reviewed-on: https://chromium-review.googlesource.com/c/1304521 Commit-Queue: Alex Clarke <alexclarke@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#603888}
-
Jérôme Lebel authored
+ Updating the sign-out button: https://drive.google.com/open?id=1duonnar2mkhKQIu45kXmE4vxNBzRxjHP + Updating the sign-out dialog when using a gmail account: https://drive.google.com/open?id=1SU5GiUsy0NF8jXqnw4n0eU2vLB0qfp78 + Updating the sign-out dialog when using a managed account: https://drive.google.com/open?id=1GsQibHJXDpC44yK5neKkqemDMjqrgbCI Bug: 883097, 899380 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I857bd5a17ae43d11846203cb8ce025b87fc4eff2 Reviewed-on: https://chromium-review.googlesource.com/c/1283034Reviewed-by:
Mark Cogan <marq@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Cr-Commit-Position: refs/heads/master@{#603887}
-
erikchen authored
This CL removes the --batch-size argument, which is rarely [or never] used. It changes --restart-shell-between-tests to be a tri-state, with options 'always', 'never' and 'on_retry'. The last is the default. Bug: 894527 Change-Id: Ib15497545aa4e55e7ab77e987db7989755d3c97b Reviewed-on: https://chromium-review.googlesource.com/c/1300236Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#603886}
-
Egor Pasko authored
I enabled systrace in http://crrev.com/598334 as an attempt to find out why the 2nd startup (out of 10) is sometimes slow. The systrace probably did not have a buffer large enough for 10 startups, so I've got the data for the last ~2 startups. Asking Telemetry to enable a larger buffer was not trivial to plumb. Without the 2nd startup the noise levels are quite low (10-40ms on N5). Further investigations down the rabbit hole are probably not worth it. Cleaning up: back to disabled systrace collection. Bug: 891797 Change-Id: If57e2ec5a9527add1e281087c734d1244345eb4f Reviewed-on: https://chromium-review.googlesource.com/c/1305553Reviewed-by:
Juan Antonio Navarro Pérez <perezju@chromium.org> Commit-Queue: Egor Pasko <pasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#603885}
-
Fergal Daly authored
Change the code to build an array of strings and then use join to avoid repeated appends. Bug: 898049 Change-Id: I194a9da3444d097dd30f4738a795391f44c6a22b Reviewed-on: https://chromium-review.googlesource.com/c/1306965Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Commit-Queue: Fergal Daly <fergal@chromium.org> Cr-Commit-Position: refs/heads/master@{#603884}
-
Koji Ishii authored
This patch fixes the left edge of inline boxes when its first child is an atomic inline that has left margin. Inline boxes without children are handled in the same way and that this patch fixes them too. NGInlineLayoutAlgorithm uses left margin when it computes the border box of children. However, when creating boxes that wrap such child, margin edge is needed. Bug: 895611, 636993 Change-Id: I4ffb67b5903a1f0ef90c1da741f1a3a33aa9c1af Reviewed-on: https://chromium-review.googlesource.com/c/1306968Reviewed-by:
Emil A Eklund <eae@chromium.org> Commit-Queue: Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#603883}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/9f49146eefcb..5785405afa1b git log 9f49146eefcb..5785405afa1b --date=short --no-merges --format='%ad %ae %s' 2018-10-30 recipe-roller@chromium.org Roll recipe dependencies (trivial). 2018-10-30 recipe-roller@chromium.org Roll recipe dependencies (trivial). 2018-10-30 skia-bookmaker@skia-swarming-bots.iam.gserviceaccount.com Update markdown files Created with: gclient setdep -r src/third_party/skia@5785405afa1b The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel TBR=herb@chromium.org Change-Id: I37eddcf4e6b61d894698b6850f86f282918b0c44 Reviewed-on: https://chromium-review.googlesource.com/c/1306767Reviewed-by:
-
