GitLab

BUG=NONE

Review URL: https://chromiumcodereview.appspot.com/14327004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195077 0039d316-1c4b-4281-b951-d872f2087c98

This fixes the line spacing of notification so it's 18px on all
platforms (instead of the previous 17px on Chrome OS and 15px on
Windows).

To do this, support for a line height property was added to the
BoundedLabel that NotificationView uses, to the Label that BoundedLabel
uses, and to the Canvas that Label uses.

BUG=225871
R=mukai@chromium.org,msw@chromium.org

Review URL: https://chromiumcodereview.appspot.com/14322007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195076 0039d316-1c4b-4281-b951-d872f2087c98

TouchEvent's radius on Pixel is reported in the touchscreen's
native resolution. When Pixel is connected to an external screen
and running in mirror mode, the radius value is too large for
the external screen's low display resolution. The radius value
needs to be scaled properly in this case.

BUG=229932
TEST=Switching to mirror mode when connecting Pixel to a low
resolution external display, following the test in the issue
and make sure the radius has a sensible value.

Review URL: https://chromiumcodereview.appspot.com/14279002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195075 0039d316-1c4b-4281-b951-d872f2087c98

This allows us to adjust the number of favicons clients will maintain
as we determine how well we handle them.

BUG=154886

Review URL: https://chromiumcodereview.appspot.com/14117004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195074 0039d316-1c4b-4281-b951-d872f2087c98

FileNotFoundErrors: make them all descriptive, and don't overcatch them.

NOTRY=true
BUG=226625

Review URL: https://codereview.chromium.org/13896007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195073 0039d316-1c4b-4281-b951-d872f2087c98

Special directories ("drive", "drive/root", and "drive/other") should not be
suggested from autocomplete.

Always exclude these directories in SearchMetadata() as it's unlikely for us
to want these directories in results from SearchMetadata(). We can make it an
option when neeed.

BUG=232281
TEST=Open Drive in Files.app. Type "drive", "root", "other" in the search box, and confirm the special directories are not suggested.

Review URL: https://codereview.chromium.org/14366010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195072 0039d316-1c4b-4281-b951-d872f2087c98

BUG=170401, 231029

Review URL: https://chromiumcodereview.appspot.com/14096009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195071 0039d316-1c4b-4281-b951-d872f2087c98

 Shelf widget's ownership is WIDGET_OWNS_NATIVE_WIDGET, and native view can be NULL when re-layouing due to activation change after deletion.

BUG=230869

Review URL: https://chromiumcodereview.appspot.com/14076009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195070 0039d316-1c4b-4281-b951-d872f2087c98

BUG=230068

Review URL: https://chromiumcodereview.appspot.com/14050005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195069 0039d316-1c4b-4281-b951-d872f2087c98

Pinch-zoom scrollbar animations are impl-only animations that
are added directly to an impl-side animation controller rather
than pushed during a commit. If no draw is triggered when they
are created, they can be left waiting indefinitely to get
started. This CL adds calls to SetNeedsRedraw when these
animations are created; once these animations are started,
LayerTreeHostImpl::AnimateLayers already takes care of 
triggering additional draws.

BUG=165842

Review URL: https://chromiumcodereview.appspot.com/14017008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195068 0039d316-1c4b-4281-b951-d872f2087c98

Implement new audio handler which talks to the new audio dbus apis, and adds a new AudioClientRestarted signal in CrasAudioClient.

BUG=160311,232032
TBR=sky
TBR=battre

Review URL: https://codereview.chromium.org/14314002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195067 0039d316-1c4b-4281-b951-d872f2087c98

suid_unsafe_environment_variables.h is included both in C and C++ and is
a little clunky. Clean things up a bit.

BUG=233330

Review URL: https://codereview.chromium.org/14328030

Patch from Julien Tinnes <jln@chromium.org>.

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195066 0039d316-1c4b-4281-b951-d872f2087c98

BUG=229710

Review URL: https://chromiumcodereview.appspot.com/14017003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195065 0039d316-1c4b-4281-b951-d872f2087c98

The cause is very likely that an event-handler is destroyed inside the
event-handling function (OnMouseEvent). Furthermore, this destruction
is not needed due to state variable "in_shutdown_". It was there for a 
very marginal efficiency gain. Removed the handler destruction.

BUG=230872
R=ben@chromium.org
TEST=manual

Review URL: https://chromiumcodereview.appspot.com/13932029

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195064 0039d316-1c4b-4281-b951-d872f2087c98

Changes the string and breaks it apart for the Android UI.

BUG=180962

Review URL: https://chromiumcodereview.appspot.com/13918004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195063 0039d316-1c4b-4281-b951-d872f2087c98

$('polling-interval-sec') no longer exists hence causes a JS error.
FWIW, the regression was introduced in crrev.com/194294

BUG=233446
TEST=open chrome:drive-internals; confirm that Delta Update Status section is shown properly.

Review URL: https://codereview.chromium.org/14366011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195062 0039d316-1c4b-4281-b951-d872f2087c98

Remove landing page from history when redirecting to NTP so that the back-button will work as expected.

BUG=180145

Review URL: https://chromiumcodereview.appspot.com/13896009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195061 0039d316-1c4b-4281-b951-d872f2087c98

BUG=233039

Review URL: https://chromiumcodereview.appspot.com/13896003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195060 0039d316-1c4b-4281-b951-d872f2087c98

When showning an audio indicator on multiple tabs, the CPU usage on
my machine is:
  1 tab: 1.5%
  2 tab: 2.5%
  3 tab: 3.2%

This CL uses a common animation container for all tabs in a window.
This changes the CPU usage to:
  1 tab: 1.5%
  2 tab: 1.5%
  3 tab: 1.5%

BUG=3541

Review URL: https://chromiumcodereview.appspot.com/13867007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195059 0039d316-1c4b-4281-b951-d872f2087c98

BUG=230997

Review URL: https://chromiumcodereview.appspot.com/13859011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195058 0039d316-1c4b-4281-b951-d872f2087c98

"and" and "xor" are alternate spellings of the "&&" and "^" operators,
and clang doesn't like it if you use them as identifiers.

Clang also doesn't like static_cast<> from void * to a function pointer,
but reinterpret_cast<> works.

R=alexeypa@chromium.org
BUG=82385

Review URL: https://chromiumcodereview.appspot.com/13852007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195057 0039d316-1c4b-4281-b951-d872f2087c98

ArchiveSomeOldHistory() takes an int as last parameter, but this code would
pass numeric_limits<size_t>::max(). Found by clang building in C++11 mode:

../../chrome/browser/history/expire_history_backend.cc:330:25: error: implicit conversion from 'unsigned long' to 'int' changes value from 18446744073709551615 to -1 [-Werror,-Wconstant-conversion]
                        std::numeric_limits<size_t>::max());
                        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 error generated.

BUG=233330

Review URL: https://codereview.chromium.org/14057019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195056 0039d316-1c4b-4281-b951-d872f2087c98

BUG=
TBR=cjhopman@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/13852021

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195044 0039d316-1c4b-4281-b951-d872f2087c98

Proposal: https://docs.google.com/a/google.com/document/d/1KxtQCk4SJdAZId8WxtnCxR3kS2KvhFDsU0SdAeP18Xc/edit

The logic of the API is implemented. Add prefernces and policies are added.
The underlying cryptohome_client will be implemented in another CL.

BUG=chromium:219963
TEST=unit_tests

Review URL: https://chromiumcodereview.appspot.com/13132004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195043 0039d316-1c4b-4281-b951-d872f2087c98

BUG=164227
TEST=No

Review URL: https://chromiumcodereview.appspot.com/14358006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195039 0039d316-1c4b-4281-b951-d872f2087c98

This seems to be equivalent to SetHoverColor and LabelButton doesn't have/implement
this concept. So to make the life easier just remove it.

BUG=155363
R=msw@chromium.org

Review URL: https://chromiumcodereview.appspot.com/14331002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195038 0039d316-1c4b-4281-b951-d872f2087c98

R=rch@chromium.org
BUG=232777

Review URL: https://chromiumcodereview.appspot.com/14328013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195037 0039d316-1c4b-4281-b951-d872f2087c98

Also enable two passed java tests.

BUG=
NOTRY=true

Review URL: https://chromiumcodereview.appspot.com/13870016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195036 0039d316-1c4b-4281-b951-d872f2087c98

BUG=233164
R=pliard@chromium.org

Review URL: https://chromiumcodereview.appspot.com/14315009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195035 0039d316-1c4b-4281-b951-d872f2087c98

PowerStatusView::GetRoundedBatteryPercentage() truncated
rather than rounding, resulting in Chrome frequently
displaying a slightly-lower battery percentage than what
powerd told it to display.

BUG=chromium:221746

Review URL: https://chromiumcodereview.appspot.com/14246015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195034 0039d316-1c4b-4281-b951-d872f2087c98

BUG=233243
R=msw@chromium.org
TBR=ben@chromium.org

Review URL: https://codereview.chromium.org/14267007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195033 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://chromiumcodereview.appspot.com/14232014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195032 0039d316-1c4b-4281-b951-d872f2087c98

BUG=

Review URL: https://codereview.chromium.org/14163006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195031 0039d316-1c4b-4281-b951-d872f2087c98

On Windows & Chrome OS, pressing Alt+Shift+A will bring focus to the first
control in the first infobar, if any are shown. No reason for 'A' - 'I' is
already taken on Chrome OS, but all other hotkeys to directly focus a given
pane are Alt+Shift+Letter shortcuts.

BUG=226334

Review URL: https://chromiumcodereview.appspot.com/14225016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195030 0039d316-1c4b-4281-b951-d872f2087c98

DuplicateHandle with DUPLICATE_CLOSE_SOURCE always closes the handle, right now on failure
we close it which means we are closing an invalid handle or closing some other handle in
the small race window.

Reported by Ashutosh Mehra from Adobe.

BUG=233251
TEST=none

Review URL: https://chromiumcodereview.appspot.com/13912024

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195029 0039d316-1c4b-4281-b951-d872f2087c98

Make View::RequestFocus non-virtual; replace override.
Also add mouse-press/release inhibiting of select-all.
(this prevents a flash of all text selected on click)

BUG=232290
TEST=No find bar focus-related behavior/appearance regressions; switching back to a tab that had the find bar focused (from a tab that didn't have the find bar focused) restores find bar focus and selects the entire text content; clicking the find bar doesn't flash all the text selected before placing the cursor or starting a drag.
R=ben@chromium.org

Review URL: https://chromiumcodereview.appspot.com/13852009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195028 0039d316-1c4b-4281-b951-d872f2087c98

Broke mouse dodge on Mac, and perhaps isn't correct for Win Aura anyhow.

BUG=233299

> push MouseMove through WebContents and back to delegate to fix status bubble avoid
> 
> This fixes the status bubble not "dodging" the mouse on Aura.
> 
> On non-Aura, the path to get to StatusBubbleViews::MouseMoved is:
> - RenderWidgetHostViewWin::OnMouseEvent
> - SendMessage to the parent window
> - WebContentsViewWin::OnMouseMove
> - Browser::ContentsMouseEvent
> - StatusBubbleViews::MouseMoved
> 
> On Aura, the path is:
> - HWNDMessageHandler
> - DesktkopRootWindowHostWin::HandleMouseEvent
> - RootWindow::OnHostMoustEvent
> - EventDispatcher, etc.
> - content::RenderWidgetHostViewAura::OnMouseEvent
> - RenderViewHostImpl::ForwardMouseEvent
> - WebContentsImpl::HandleMouseMove  // ***
> - Browser::ContentsMoveEvent
> - StatusBubbleViews::MouseMoved.
> 
> This patch implements HandleMouseMove in WebContentsImpl to delegate back to Browser for Aura at ***.
> 
> R=jam@chromium.org
> 
> Review URL: https://codereview.chromium.org/14234020

TBR=scottmg@chromium.org

Review URL: https://codereview.chromium.org/13893004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195027 0039d316-1c4b-4281-b951-d872f2087c98

The (harmless) warning was:

../../webkit/plugins/ppapi/message_channel.cc:286:69: error: comparison of constant 2305843009213693951 with expression of type 'unsigned int' is always false [-Werror,-Wtautological-constant-out-of-range-compare]
      if (std::numeric_limits<size_t>::max() / sizeof(NPIdentifier) <=
          ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^
1 error generated.

It's always false in 64bit mode, but it's arguably useful in 32bit mode.

BUG=233330

Review URL: https://codereview.chromium.org/14246019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195026 0039d316-1c4b-4281-b951-d872f2087c98

TBR=asargent@chromium.org
BUG=233404

Review URL: https://codereview.chromium.org/14192010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195025 0039d316-1c4b-4281-b951-d872f2087c98

With the fix all numbered address lines after line two are ignored (not just the third line); without the fix line four is classified as the start of a billing section and the form is 'split' in two address areas.

The problem can seen on site https://www.southwesttrains.co.uk/register.aspx

BUG=224601
TEST=Manual test; South West Trains site should fully autocomplete (including Post Code field). New unit test FormStructureTest.SurplusAddressLinesIgnored

Review URL: https://chromiumcodereview.appspot.com/13888008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195024 0039d316-1c4b-4281-b951-d872f2087c98