- 16 Mar, 2020 40 commits
-
-
Peter Kotwicz authored
This CL changes WebApkActivityTestRule to disable WebAPK updates. BUG=1054718 Change-Id: I193827f09fed1a6d9f7f93d78fc2a37f845df748 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2098769Reviewed-by:
Glenn Hartmann <hartmanng@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Cr-Commit-Position: refs/heads/master@{#750578}
-
Pâris Meuleman authored
This removes crash expectations that got fixed following the changes in https://crrev.com/c/2074482. Bug: 1040059 Change-Id: I91a9bfa3b49686ec204e5103e6bae369d351fb9f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2096587 Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Auto-Submit: Pâris Meuleman <pmeuleman@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#750577}
-
W. James MacLean authored
NavigationPredictorPreconnectClientBrowserTest .PreconnectNotSearchBackgroundForeground is flakey on mac, see bug for details. TBR=ryansturm@chromium.org Bug: 1061932 Change-Id: I23de7d1b8aec2cfa34ae9b2c2d2f6c855a961171 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2105418Reviewed-by:
James MacLean <wjmaclean@chromium.org> Commit-Queue: James MacLean <wjmaclean@chromium.org> Cr-Commit-Position: refs/heads/master@{#750576}
-
Michael Thiessen authored
This is just a readability improvement, no functional changes. It was confusing that shouldCloseTab appeared to only be used in some cases like actions that result in OVERRIDE_WITH_ASYNC_ACTION, when we were actually just recomputing shouldCloseTab under the assumption that it wouldn't change. Change-Id: I52b16cef1483c328bc595bc329f4a9098b3fc5ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2101311Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#750575}
-
arthursonzogni authored
Check the COOP/COEP headers defined in a response from the ServiceWorker are correctly taken into account. This test is fixed by: https://chromium-review.googlesource.com/c/chromium/src/+/2100790 Bug: 922191 Change-Id: I3cbb577edb5a0fa1527464a57dff2b4863a1bc2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2102577 Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Pâris Meuleman <pmeuleman@chromium.org> Cr-Commit-Position: refs/heads/master@{#750574}
-
Eric Willigers authored
Various includes of extensions headers from chrome/browser/ui/views are no longer required. Change-Id: I6edd33bcffa8c8b733292220239c70b1de0dc4b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2104708 Auto-Submit: Eric Willigers <ericwilligers@chromium.org> Commit-Queue: Allen Bauer <kylixrd@chromium.org> Reviewed-by:
Allen Bauer <kylixrd@chromium.org> Cr-Commit-Position: refs/heads/master@{#750573}
-
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-eve-compile-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-kevin-compile-chrome BUG=762641 TBR=chrome-os-gardeners@google.com Change-Id: I05bece4a4848cf084c65a206c76f8232f4cc7474 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2105416Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#750572}
-
Elly Fong-Jones authored
This document outlines the associated data pattern, and the two most commonly used implementations of it in Chromium: SupportsUserData and KeyedService. Bug: None Change-Id: I45ad8d2961221fd64022168982f454fe655340fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2102591 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#750571}
-
Peter Wen authored
Turbine: https://github.com/google/turbine Turbine is a library for generating java headers. Java headers are equivalent to interface jars generated by ijar. Basically a .jar file of .class files that have private methods and variables removed, and method bodies removed, so that only the minimal public/package/protected interface of the class are preserved. This allows library A that depends on library B to pass in library B's header in its classpath rather than the full .jar file generated by an invocation of javac. Since turbine runs much faster than javac (3-5x speedup), this allows the libraries to be compiled with javac in parallel more often. The implementation is in a subsequent CL for ease of revert/relands. Bug: 1056299 Change-Id: I515515b874c9897ed38fa68a96cd0cd0dbf5c270 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090726Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Martin Barbella <mbarbella@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Commit-Queue: Peter Wen <wnwen@chromium.org> Auto-Submit: Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#750570}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/18f1a2797005..71e412b29c10 Created with: gclient setdep -r src-internal@71e412b29c10 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: Ia4457b30689acc00e29b982ebfa1d567500193cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2105414Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#750569}
-
Roman Aleksandrov authored
Track review following setup box is checked. Change-Id: I99be8c503159194018e4af1b1f1be91237e5e8f3 Bug: 1056740 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095103 Commit-Queue: Roman Aleksandrov <raleksandrov@google.com> Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#750568}
-
Rayan Kanso authored
The test has been consistently failing. TBR=sahel@chromium.org Bug: 1061919 Change-Id: I41c50e7ed55bae4207791ac02b5ff362473945a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2105434Reviewed-by:
Rayan Kanso <rayankans@chromium.org> Commit-Queue: Rayan Kanso <rayankans@chromium.org> Cr-Commit-Position: refs/heads/master@{#750567}
-
John Budorick authored
This reverts commit 4154e5e3. Reason for revert: https://bugs.chromium.org/p/chromium/issues/detail?id=1061936 Original change's description: > Fix combining characters for c with acute accent > > The table had ´c map to ç instead of ć, imitating GTK from circa 2008. > This was overlooked in the conversion, and left no way for users to > type ć (used in Polish for example). > > I speculate that GTK was imitating the Windows ‘US International’ layout, > which has that mapping. We have a separate section of the combining table > for the Windows-like ‘US International PC’ that does map ´c map to ç, > but this should not still happen for other layouts. > > Bug: 1061753 > Change-Id: I113b3d6c3fda6b93f7f27296b1a30dae6aa0b668 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2102776 > Reviewed-by: Yuichiro Hanada <yhanada@chromium.org> > Commit-Queue: Kevin Schoedel <kpschoedel@chromium.org> > Cr-Commit-Position: refs/heads/master@{#750545} TBR=kpschoedel@chromium.org,yhanada@chromium.org Change-Id: I9c78d16522887c691e3e6e4cdd7d4979410c5845 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1061753 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2105419Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#750566}
-
Gabriel Charette authored
base::ThreadPool:: (API as a destination) is the new desired paradigm. worker_pool:: was already API-as-destination; can remove redundant ThreadPool() trait with new API. R=haraken@chromium.org Bug: 1026641 Change-Id: Ida08feab710143da2308ef1361550a9aced39d2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2105454 Commit-Queue: Gabriel Charette <gab@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#750565}
-
Andrew Grieve authored
See https://chromium.googlesource.com/chromium/src/+/master/styleguide/inclusive_code.md TBR=agrieve # Mechanical renames Change-Id: I1298f139e15919ec1597510ef3a556a67ee2acc9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2103040 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#750564}
-
Elly Fong-Jones authored
As part of the DialogDelegate close refactor I changed the default behavior of dialogs that have both cancel and accept callbacks to require opting in to receiving a callback on close as well. This dialog is one of the few that were both depending on this behavior and had no test coverage for that dependency. This change: 1) Opts that dialog into receiving a callback on close, using the pattern called "pattern 2" from r743269 2) Adds test coverage for the behavior here Bug: 1056116 Change-Id: I3b4a30c6015bf76534b6b083586a13fdc55bac2a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2100727Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Jenny Zhang <jennyz@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#750563}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/7bb74c4299b8..f94815068d75 git log 7bb74c4299b8..f94815068d75 --date=short --first-parent --format='%ad %ae %s' 2020-03-16 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 18daa81e3d3d..3a50a43df988 (14 commits) 2020-03-16 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update SKP version 2020-03-15 mtklein@google.com rearrange to emphasize most salient params 2020-03-15 reed@google.com add programs to compose, lerp and luma colorfilters 2020-03-15 reed@google.com colorfilter's program returns a color 2020-03-15 reed@google.com change onProgram to return its color, or an invalid-color if failed 2020-03-14 reed@google.com skvm for compose shaders 2020-03-13 djsollen@google.com Remove mips workarounds for Android. 2020-03-13 jvanverth@google.com Reland "Clear out atlases if they haven't been used in a while." 2020-03-13 sgilhuly@chromium.org SkiaDawn: Early out in recordProgramInfo 2020-03-13 fmalita@chromium.org [svgdevice] Handle text path effects 2020-03-13 jvanverth@google.com Revert "Clear out atlases if they haven't been used in a while." 2020-03-13 csmartdalton@google.com Remove instanced draws and simplify GrMesh 2020-03-13 reed@google.com remove legacy virtual from enforcer 2020-03-13 jvanverth@google.com Clear out atlases if they haven't been used in a while. 2020-03-13 bryct@amazon.com Implement support for path effects in SkSVGDevice backend. 2020-03-13 robertphillips@google.com Make AAFlatteningConvexPathOp surface its programInfos at record time 2020-03-13 reed@google.com hide getters so we can change the internals of SkVertices 2020-03-13 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 2e5bd9b1e658..6963f58c7678 (14 commits) 2020-03-13 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ../src 5309fd86..907b992f (527 commits) 2020-03-13 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 7e857092052e..18daa81e3d3d (9 commits) 2020-03-13 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update SKP version 2020-03-12 mtklein@google.com dot for JIT 2020-03-12 mtklein@google.com restore Op::round 2020-03-12 csmartdalton@google.com Migrate GrMeshTest to the new bind/draw API 2020-03-12 reed@google.com remove LerpRed shader 2020-03-12 reed@google.com add draw-via-serialize mode to viewer 2020-03-12 robertphillips@google.com More programInfo cleanup 2020-03-12 reed@google.com add gm for clipShader in a layer 2020-03-12 brianosman@google.com More GrDrawVerticesOp cleanup, to reduce redundant state 2020-03-12 robertphillips@google.com Update three GrMeshDrawOps to surface their programInfos at record time 2020-03-12 fmalita@chromium.org [skottie] Cleanup VectorValue use 2020-03-12 michaelludwig@google.com Remove drawBitmap et al. from SkDevice 2020-03-12 mtklein@google.com make switching skvm-on-llvm easier 2020-03-12 fmalita@chromium.org [skottie] Effects cleanup pass 2020-03-12 brianosman@google.com Remove (unused) shader caps from default GP factory functions 2020-03-12 brianosman@google.com Simplify and optimize GrDrawVerticesOp vertex writing loop 2020-03-12 robertphillips@google.com Clean up programInfo creation in GrMeshDrawOp-derived Ops 2020-03-12 borenet@google.com Update Skia milestone to 83 Created with: gclient setdep -r src/third_party/skia@f94815068d75 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC egdaniel@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1058905,chromium:1059890,chromium:1059939 Tbr: egdaniel@google.com Change-Id: I22963250cdbbec26d2c3740f05971dc59bd28e96 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2105413Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#750562}
-
kylechar authored
There were a few remaining references to OOP-D in the code that are no longer relevant since the feature is launched. Bug: 936425 Change-Id: I32930a85684007068303d1b8083a3b4a00227e02 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2101189Reviewed-by:
Jonathan Backer <backer@chromium.org> Commit-Queue: kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#750561}
-
Sylvain Defresne authored
Some targets want to copy files from $ios_sdk_platform_abs_path. Since those points to sub-directory of $root_build_dir when goma RBE is enabled, this causes failure at "gn gen" time since there are no target creating those files according to gn. To fix this, add a new target that pretends to create those files. Bug: 1061487, webrtc:11429 Change-Id: I9d2330c4c6e041e59f24c459e50fe787602abde6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2102544 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#750560}
-
Side Yilmaz authored
Profile#getLastUsedProfile| is deprecated and replaced with |Profile#getLastUsedRegularProfile|. This CL updates PaymentRequestHeader class. Note: This change is only code clean-up, does not change any behavior. Bug: 1041781 Change-Id: Icd95cb4f4b2af2faef88a4043a8f6e6153eff468 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2105153Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
Sahel Sharify <sahel@chromium.org> Commit-Queue: Side YILMAZ <sideyilmaz@chromium.org> Cr-Commit-Position: refs/heads/master@{#750559}
-
Omer Katz authored
Add tests designed to reveal more issues in Vectors and Deques. Bug: 986235 Change-Id: Ifd2808ba926d6cc6232f2762058fe0e8978756a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2102657 Commit-Queue: Omer Katz <omerkatz@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#750558}
-
Nohemi Fernandez authored
- Clarifies the difference between unified consent add account and reauth. Add account and reauthentication methods in identity differ in that one provides the user with a screen to enter their account details and the other automatically prefills these details. - Implements sign-in completion for reauth. Bug: 971989 Change-Id: I2b0d2d2cc830f7e989480d7444002144d26a38ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095118 Commit-Queue: Nohemi Fernandez <fernandex@chromium.org> Reviewed-by:
Jérôme Lebel <jlebel@chromium.org> Cr-Commit-Position: refs/heads/master@{#750557}
-
Andrew Grieve authored
And enable authentication of downstream trybot results. Bug: 1048299 Change-Id: Id24c9ee400171c709c87bfb0fd4c58112cfd154e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2103387 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Mohamed Heikal <mheikal@chromium.org> Cr-Commit-Position: refs/heads/master@{#750556}
-
Stephen McGruer authored
Tackling the set of calls that avoided the automated refactor (for various reasons). There are about 50 in total, split up into a few CLs to make reviewing it easier. Bug: 1051932 Change-Id: I3d51fe842f2858e9528b9012cb9da9d29e300c9e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083736Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Reviewed-by:
Dan Elphick <delphick@chromium.org> Reviewed-by:
Jens Widell <jl@opera.com> Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#750555}
-
Sean Gilhuly authored
Display output from SkiaRenderer Dawn is upside-down on Windows. Pass a SurfaceOrigin parameter when constructing SkiaOutputDeviceDawn so that the origin can be set per platform. Bug: 1021566 Change-Id: Ic8fbf30cc21bfab2f7c10c63118d4730216172e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2103265Reviewed-by:
Peng Huang <penghuang@chromium.org> Commit-Queue: Sean Gilhuly <sgilhuly@chromium.org> Cr-Commit-Position: refs/heads/master@{#750554}
-
Gyuyoung Kim authored
This CL replaces .mojom.h includes with .mojom-forward.h in some sub-directories of chrome/browser to reduce the pre-processed size of header files and shorter build time. The sub-directories are following, - chrome/browser/usb - chrome/browser/vr - chrome/browser/web_applications This CL has no behavior changes. Bug: 1001360 Change-Id: I05e70b987ed0a571aff1680704afeb03e1bab090 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2103827Reviewed-by:
Colin Blundell <blundell@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Cr-Commit-Position: refs/heads/master@{#750553}
-
Ben Joyce authored
Fixes webrtcerror: https://bugs.chromium.org/p/webrtc/issues/detail?id=11418 Bug: 1061741, webrtc:11418 Change-Id: Iff441bd878b74e50486b59f5753265eca38fcce8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2104096Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#750552}
-
Yutaka Hirano authored
Enable it on Android, disable it on WebView. Intent-to-Ship: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/XBKAGb2_7uAi. Bug: 1061841, 887967 Change-Id: Ie9f6392f8b3ec59165dbc3295eb196555e68e313 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2104739Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Auto-Submit: Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#750551}
-
Sorin Jianu authored
This should be a mechanical change in a unit test. I refactored some odd looking code due to unique_ptr<base::RunLoop>. This CL gets rid of unique_ptr and confusing ownership semantics. Change-Id: I90386d09ffed6de242acb47d35ba2156a43c0da9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2104451Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Commit-Queue: Sorin Jianu <sorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#750550}
-
Nico Weber authored
Bug: 346399 Change-Id: Iec2bb9ce58f3a5dcc2e0b5f2ba55ad6448b3203c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2104552 Commit-Queue: Nico Weber <thakis@chromium.org> Commit-Queue: Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Auto-Submit: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#750549}
-
Jonathan Metzman authored
Bug: 346399 Change-Id: I5ce7f48a5cab3785f8d8c44cbb3292d1a6eb59df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2103349Reviewed-by:
Max Moroz <mmoroz@chromium.org> Commit-Queue: Max Moroz <mmoroz@chromium.org> Auto-Submit: Jonathan Metzman <metzman@chromium.org> Cr-Commit-Position: refs/heads/master@{#750548}
-
Mohamed Heikal authored
Deployment script now uploads to firebase rather than google cloud storage. This also adds a README.md for instructions on how to deploy a new version. Bug: 1048299 Change-Id: I2ed0625b4d62aab3c192123941b343d1f948a39f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2092551 Commit-Queue: Mohamed Heikal <mheikal@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Samuel Huang <huangs@chromium.org> Cr-Commit-Position: refs/heads/master@{#750547}
-
Nico Weber authored
Bug: 346399 Change-Id: I6459029b5e103e90b7936eca47225b99c360f2fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2105274 Commit-Queue: Nico Weber <thakis@chromium.org> Commit-Queue: Hans Wennborg <hans@chromium.org> Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#750546}
-
Kevin Schoedel authored
The table had ´c map to ç instead of ć, imitating GTK from circa 2008. This was overlooked in the conversion, and left no way for users to type ć (used in Polish for example). I speculate that GTK was imitating the Windows ‘US International’ layout, which has that mapping. We have a separate section of the combining table for the Windows-like ‘US International PC’ that does map ´c map to ç, but this should not still happen for other layouts. Bug: 1061753 Change-Id: I113b3d6c3fda6b93f7f27296b1a30dae6aa0b668 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2102776Reviewed-by:
Yuichiro Hanada <yhanada@chromium.org> Commit-Queue: Kevin Schoedel <kpschoedel@chromium.org> Cr-Commit-Position: refs/heads/master@{#750545}
-
Sorin Jianu authored
This is a mechanical change over files in the update_client, component_updater, and the extension updater. Change-Id: I2a5b682299cbb04bdfa9f5691329dfa97e869d2c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2104396Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Commit-Queue: Sorin Jianu <sorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#750544}
-
Benoit Lize authored
Linker tests have been removed. Remove the build rules as well. Bug: 1059707 Change-Id: If5e4d004026c2a86f79036a8457577e8104eadc4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2104472Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Benoit L <lizeb@chromium.org> Cr-Commit-Position: refs/heads/master@{#750543}
-
ckitagawa authored
This CL implements the Java side integration for the TabService. Bug: 1058093 Change-Id: Iaa8f007a2a16ac10f87466eb7d5d49f05e112576 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090298 Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org> Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#750542}
-
Rouslan Solomakhin authored
Bug: 1005076 Change-Id: I16e45e91ee3d6ac3dcb92f6967ea786b1b0f7840 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2097301 Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
Danyao Wang <danyao@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#750541}
-
Elly Fong-Jones authored
This change: 1) Adds a new function, chrome::ShowDeviceChooserDialog, that displays a device chooser bypassing the BubbleUi framework 2) Has Browser use this new function rather than BubbleUi to show the bluetooth device choosers Note that ShowDeviceChooserDialog returns a OnceClosure, which the client can call to close the dialog. It does not return a pointer to the dialog since the dialog is self-owning. Previously, this code dealt with that by passing around BubbleReferences, which have weak pointer semantics; returning a OnceClosure (which internally has a WeakPtr to the UI) allows the client code to close the bubble when it wants to without adding new lifetime issues. Remaining uses of ChooserBubbleDelegate directly: * Web USB chooser * HID chooser * Serial chooser These use similar design patterns, and will be migrated in follow-up changes. Bug: 496955 Change-Id: I1b45c1cfdba6e0eaee57ef61d91da294832a0888 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2102947 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#750540}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/22594b8b0acd..496706c9672e git log 22594b8b0acd..496706c9672e --date=short --first-parent --format='%ad %ae %s' 2020-03-16 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. 2020-03-16 sigurds@chromium.org Only display 100 inline breakpoints 2020-03-16 szuend@chromium.org Initialize Linkifier link texts with 'zero width space' 2020-03-16 tvanderlippe@chromium.org Extract tsconfig.base.json to obtain VSCode compatible tsconfig.json 2020-03-16 jacktfranklin@chromium.org TypeScriptify `sdk/CookieParser` Created with: gclient setdep -r src/third_party/devtools-frontend/src@496706c9672e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1011811,chromium:1032016,chromium:1057021,chromium:1060105 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I79d993f3bdc484a7f69af59056b8535cfa57fa5d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2105193Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#750539}
-