- 23 Oct, 2018 40 commits
-
-
Nico Weber authored
Bug: 324079 Change-Id: I06c556660ab05975b5a0726cf7e3e72afa9ed070 Reviewed-on: https://chromium-review.googlesource.com/c/1296675Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#602057}
-
Stephen Chenney authored
R=rkaplow@chromium.org,holte@chromium.org Change-Id: I38032ef08548a443e09591dcf6f4f9e9523e6568 Reviewed-on: https://chromium-review.googlesource.com/c/1293793Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Robert Kaplow (sloooow) <rkaplow@chromium.org> Commit-Queue: Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#602056}
-
Shimi Zhang authored
P SDK is rolled to public, we can inline these two methods now. Bug: 850652 Change-Id: Ib2828752bdda8be5ba4f1e1d5fc84c7fd315db79 Reviewed-on: https://chromium-review.googlesource.com/c/1289434Reviewed-by:
Richard Coles <torne@chromium.org> Reviewed-by:
Paul Jensen <pauljensen@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Shimi Zhang <ctzsm@chromium.org> Cr-Commit-Position: refs/heads/master@{#602055}
-
Tom Anderson authored
This is to green up the Google Chrome Linux bot [1]. NaCl now has the same SIs as Chrome [2]. They are: WelsThreadPool.cpp atomicops_internals_x86.cc debugallocation_shim.cc iostream.cpp spinlock.cc [1] https://ci.chromium.org/buildbot/chromium.chrome/Google%20Chrome%20Linux%20x64/36988 [2] https://logs.chromium.org/logs/chromium/bb/chromium.chrome/Google_Chrome_Linux_x64/36988/+/recipes/steps/sizes/0/stdout BUG=896171 R=thakis Change-Id: Ibcb553b9790b08e46e46b6eb343183f4de60b888 Reviewed-on: https://chromium-review.googlesource.com/c/1296049 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#602054}
-
rbpotter authored
Print Preview's destination and capabilities update process works as follows: (1) The destination associated with the destination-list-item selected by the user is sent to the destination store. Call this item-destination. (2) destination store sets |selectedDestination_| to the destination in its destinations map that has a matching key to item-destination, and requests capabilities for item-destination. (3) When capabilities are returned from the handler, the store updates |selectedDestination_| if item-destination, the destination for which they were retrieved, matches |selectedDestination_|. (4) This update transitions the UI to a ready state. When the user signs in successfully, the destinations map is completely reset. The Save as PDF destination is recreated just after reset and the recreated Save as PDF printer is added to the map. However, this was not triggering an update to the destination associated with the destination-list-item displaying the Save as PDF printer, because the new Save as PDF destination has all the same properties as the old one. As a result, if this destination was selected, the capabilities were retrieved for the old Save as PDF destination, while the |selectedDestination_| was the new destination. This mismatch caused the destination update event to never be fired, so the UI was stuck in a non-ready state. This CL forces the destination list used by the destination-list-items to update when the destination store updates its map, which ensures the list item for the Save as PDF printer gets the updated Save as PDF destination from the destination store's map. Bug: 895769 Change-Id: I1052609eddb2c240ece4e3132b829fb6b10ef35c Reviewed-on: https://chromium-review.googlesource.com/c/1284708 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#602053}
-
Adrienne Walker authored
These were including cases where we have no mask layers at all, which throws off the numbers. Bug: 590373 Change-Id: If8d05478737416a2f073598210c8fbc549fafce7 Reviewed-on: https://chromium-review.googlesource.com/c/1295591 Commit-Queue: enne <enne@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#602052}
-
Dominic Mazzoni authored
Code to walk the layout tree for accessibility had a subtle bug when encountering continuations, resulting in strange corner cases where content could be completely missing from the accessibility tree. This patch switches to a new, simpler algorithm to walk the layout tree for accessibility. It's simpler to explain and requires less code. All existing tests pass, included are three new regression tests demonstrating cases that failed previously, plus another simple test illustrating the importance of handling continuations correctly. Bug: 834653 Change-Id: I0704e79c94332862065e2976b90de61697f7f83f Reviewed-on: https://chromium-review.googlesource.com/c/1292870 Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Alice Boxhall <aboxhall@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#602051}
-
Philip Rogers authored
This expectation recently changed: https://crrev.com/601414 - rebaseline SK_LEGACY_COMPLEX_XFERMODES There is a single-digit difference in color but this is a ref test and cannot be rebaselined so a failing expectation has been added. Change-Id: I81ae8dabfd97c6571b468dd2256a003211421fcd Reviewed-on: https://chromium-review.googlesource.com/c/1297071 Commit-Queue: Philip Rogers <pdr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#602050}
-
Michael Spang authored
This ioctl is used to synchronize zero copy GPU uploads. Non-Chrome OS builds are starting to be able to use this capability (wayland on linux desktop, non-CrOS DRM platform builds) so whitelist it more broadly. Bug: 898234, 864914 Test: chrome --enable-zero-copy --enable-native-gpu-memory-buffers on http://media.24ways.org/2009/15/space.html w/ fps counter Change-Id: I449d5deddd48abff65a7f7add9c3b990f8d208e3 Reviewed-on: https://chromium-review.googlesource.com/c/1297085Reviewed-by:
-
Adrienne Walker authored
Change-Id: Ib652cc3653bf278c2cb9267cad12d1ee93f63683 Reviewed-on: https://chromium-review.googlesource.com/c/1292725Reviewed-by:
danakj <danakj@chromium.org> Commit-Queue: enne <enne@chromium.org> Cr-Commit-Position: refs/heads/master@{#602048}
-
Michael Spang authored
Change-Id: Iab51c54f1950ff639a2a8733b0047051a9dd7492 Reviewed-on: https://chromium-review.googlesource.com/c/1297176Reviewed-by:
Michael Spang <spang@chromium.org> Reviewed-by:
Kevin Schoedel <kpschoedel@chromium.org> Commit-Queue: Michael Spang <spang@chromium.org> Cr-Commit-Position: refs/heads/master@{#602047}
-
rbpotter authored
Wrapping <style is="custom-style"> with <custom-style> per Polymer 2 migration guide. This also fixes a styling issue with the remove user button, which occurred when Polymer 2 was turned on by default. Bug: 896583, 739532 Change-Id: Ic7648996881b945cad2895e675c45afcb095daf0 Reviewed-on: https://chromium-review.googlesource.com/c/1294593Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
-
Nico Weber authored
Bug: 324079 Change-Id: I1bdfc388266af70ac540e2730ecaf590a422898a Reviewed-on: https://chromium-review.googlesource.com/c/1296623 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
-
Kevin Marshall authored
Bring MockFontProvider up to date by adding a missing method. The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia_arm64_cast_audio;luci.chromium.try:fuchsia_x64_cast_audio TBR=cr-fuchsia+bot@chromium.org,sergeyu@chromium.org Change-Id: I9caf4eb4557506aec41e7be289b322379aceef45 Reviewed-on: https://chromium-review.googlesource.com/c/1297229 Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#602044}
-
Dominic Mazzoni authored
BrowserAccessibilityCocoa still had some code that accessed table attributes directly, most notably in AXCellForColumnAndRow, which VoiceOver uses extensively when navigating a table. Switch the code to use the AXTableInfo-based computed table attributes instead, which is not only more correct but a lot more compact, too. This fixes a bug with a table that sets display:block on some table elements, which led the Blink table code to compute the wrong number of rows and columns for the table. This patch adds a new browser test for BrowserAccessibilityCocoa to cover this case and prevent future regressions. Based on: http://crrev.com/c/1145769 Bug: 892060,832289 Change-Id: Icc5b5c305a385a2cb5f24155bfc8bd28641c85da Reviewed-on: https://chromium-review.googlesource.com/c/1290518 Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#602043}
-
Tom Sepez authored
The new test case will trip an assert under debug builds prior to the patch: *cookie_ptr == kCookieValue[i] because a new cookie is not written, and the old location now is part of the space made available to the caller. Bug: 897585 Change-Id: I9cb0a0378bd692445580f7b8b796200154bc15c6 Reviewed-on: https://chromium-review.googlesource.com/c/1294724Reviewed-by:
Chris Palmer <palmer@chromium.org> Commit-Queue: Tom Sepez <tsepez@chromium.org> Cr-Commit-Position: refs/heads/master@{#602042}
-
Fabrice de Gans-Riberi authored
The sort function was not called with the proper arguments, missing the last element in the array. This changes the structure to a C++ std::array and changes the arguments passed to the sort function to be iterators rather than plain pointers. Bug: 893369 Change-Id: I0f8cb0b991055daf1a5d39284f72681238177f1d Tested: Locally, tests still pass. Reviewed-on: https://chromium-review.googlesource.com/c/1287200Reviewed-by:
Wez <wez@chromium.org> Reviewed-by:
Scott Graham <scottmg@chromium.org> Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org> Cr-Commit-Position: refs/heads/master@{#602041}
-
Renjie authored
No flag was flipped last week. Switch QuartcConnection to use GoogCC for congestion control. This cl changes QuartcConnection to use GoogCC for congestion control. It also changes settings and updates tests so that the tests pass when using GoogCC. Summary of changes required to make tests pass: - Enable the congestion window field trial, so that GoogCC actually adjusts the CWND - Remove a CHECK in the tracegraf analyzer that is only valid for BBR - Change Quartc to allow up to 1000 incoming streams, to avoid cascading QUIC_STREAM_REFUSED errors in quic_quality_test Unless the congestion window trial is enabled, GoogCC's output never includes adjustments to the cwnd. On any network where the cwnd should be higher than the initial cwnd (which is basically all of our tests) GoogCC is constantly cwnd-limited. The CHECK for max_bandwidth_bps() fails when any algorithm other than BBR is used, as max_bandwidth_bps() comes from BBR debug state. The quic_quality_test emulates audio/video send patterns with reliable data messages. When emulating video on a 500 kbps network, each video frame is larger than a single packet. This means that each stream may remain open for a non-zero duration (the time between the first stream frame and last stream frame for that video frame). GoogCC's probe bursts occasionally induce enough short-term queuing to open more than 100 streams at once. The receiver then begins resetting new streams with the QUIC_STREAM_REFUSED error code. Reliable data messages sent over streams that close this way are automatically re-sent on a new stream. This makes the problem worse, not better, as it prevents the number of open streams from decreasing while the test continues to generate new data. The situation gets worse and worse until the test stops generating new data. Then it slowly recovers (but takes so long the test times out). This pathology is unique to quic_quality_test and to the extra retransmission logic in QuicConnection's data messages. In real audio/video Quartc flows, buffer back-pressure and cancellation logic prevent the number of streams from growing without bound. Nonetheless, as Quartc tends to open many short-lived streams, it makes sense to boost the number of incoming streams allowed. Changing the maximum incoming dynamic streams to 1000 fixes quic_quality_test and gives Quartc significantly more headroom before the receiver starts rejecting incoming streams. n/a (Quartc only) Merge internal change: 217764390 https://chromium-review.googlesource.com/c/chromium/src/+/1295172 Add framer support for IETF QUIC RETIRE_CONNECTION_ID frame N/A all code paths flag protected. LOG_STORAGE_INCREASE(GB/week): 0 No increase in log storage is anticipated as this work is in anticipation of later development of IETF QUIC. HAS_STORAGE_INCREASE_INFO=YES LOW_RISK_CHECK=PASS SENSITIVE_ANNOTATION_CHECK=PASS STORAGE_INCREASE_CHECK=PASS Merge internal change: 217720094 https://chromium-review.googlesource.com/c/chromium/src/+/1294721 Increase QuicPacketReader's receive buffer size. Merge internal change: 217698473 https://chromium-review.googlesource.com/c/chromium/src/+/1294841 Add V99/IETF-QUIC Framer support for ACK_ECN frame This CL adds support to the framer for IETF-QUIC ACK_ECN frames. The framer can generate ACK_ECN frames for transmission and parse received ACK_ECN frames. The framer support is not wired in anyplace else; this work is in support of further developing IETF-QUIC support. N/A all code is version 99 only, which is flag protected. Merge internal change: 217539272 https://chromium-review.googlesource.com/c/chromium/src/+/1294710 Change fields of HEADERS frame and PUSH_PROMISE frame from SpdyHeadersBlock to QuicStringPiece, and implement serializations accordingly. n/a -unused code Merge internal change: 217430941 https://chromium-review.googlesource.com/c/chromium/src/+/1294831 Improve stability of QuicWallTime to QuicTime conversion in QuicClock, and use the feature in Quartc. Merge internal change: 217422182 https://chromium-review.googlesource.com/c/chromium/src/+/1294596 Change-Id: Ie7bb8f0d8e3af3d6ca2b8aaf83312458dd8ef124 Reviewed-on: https://chromium-review.googlesource.com/c/1295490Reviewed-by:
Ryan Hamilton <rch@chromium.org> Commit-Queue: Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#602040}
-
Casey Piper authored
Some security keys will respond with the length of the key handle as an error response instead of an ISO7816 error code. Handle these errors by treating them as an invalid length error so further key handles can still be evaluated. Bug: 898008 Change-Id: I9d604c2012b7eb452e6476e8ced38e51ebd316d4 Reviewed-on: https://chromium-review.googlesource.com/c/1296050 Commit-Queue: Casey Piper <piperc@chromium.org> Reviewed-by:
Kim Paulhamus <kpaulhamus@chromium.org> Cr-Commit-Position: refs/heads/master@{#602039}
-
Mitsuru Oshima authored
Overlay doesn't work if the window is clipped. This removes the clipping if the window is fullscreen/maximzied. This is short term fix for m71. I'll investigate if we can remove this in m73. Bug: b/117679678 Test: covered by unittest Change-Id: I39d79461a42d86e2e9e5f9f282b6c8f391daf3b4 Reviewed-on: https://chromium-review.googlesource.com/c/1297151 Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Malay Keshav <malaykeshav@chromium.org> Cr-Commit-Position: refs/heads/master@{#602038}
-
Andrey Kosyakov authored
The race between requestIntercepted and willSendRequest has become more pronounced since we started fetching cookies from the cookie manager in https://chromium-review.googlesource.com/c/1282443. Change-Id: I98653cfe2ffca92724a2edc28c949fa1a08907fd Reviewed-on: https://chromium-review.googlesource.com/c/1297130 Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#602037}
-
Xiaohan Wang authored
This removes the duplicate code to specify mime type for a given test file in multiple media tests. In this CL chrome/content encrypted_media_browsertest.cc are updated to use the new function. In the next CL, media_source_browsertest.cc and pipeline_integration_test.cc will be updated as well. Bug: 897767 Test: No functionality change. Change-Id: I2e408d125fcc339352ad7c18a56b951f179f736c Reviewed-on: https://chromium-review.googlesource.com/c/1295151Reviewed-by:
Chrome Cunningham <chcunningham@chromium.org> Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#602036}
-
David Bokan authored
Seems that this is no longer used as a main thread scrolling reason. Change-Id: I6edbb0e936a996f59ed586b8225ba42212ea355e Reviewed-on: https://chromium-review.googlesource.com/c/1296316Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#602035}
-
Justin Cohen authored
When an NTP is active with the kBrowserContainerContainsNTP feature, use the correct view for taking snapshots. Rather then the webState view, use the NTP view itself. Bug: 826369 Change-Id: I86406f6ccd1423e08b0ac4f896b5ebf2600a4e85 Reviewed-on: https://chromium-review.googlesource.com/c/1291596Reviewed-by:
Peter Lee <pkl@chromium.org> Reviewed-by:
edchin <edchin@chromium.org> Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#602034}
-
Bill Orr authored
OpenVR by default includes its own jsoncpp. However, we have one in third_party already, so we don't need OpenVR's copy. BUG=780987,790814,896087 Change-Id: Iac57998856ac72b36b6b731b3860ca67ae7c3f45 Reviewed-on: https://chromium-review.googlesource.com/c/1294669Reviewed-by:
Klaus Weidner <klausw@chromium.org> Commit-Queue: Bill Orr <billorr@chromium.org> Cr-Commit-Position: refs/heads/master@{#602033}
-
Joe DeBlasio authored
A number of characters from several Indian scripts are confusable, especially with numbers. This change maps these characters to their ASCII lookalike to allow fallback to punycode when displaying probable spoofing URLs. Bug: 849421 Bug: 892646 Bug: 896722 Change-Id: I6d463642f3541454dc39bf4b32b8291417697c52 Reviewed-on: https://chromium-review.googlesource.com/c/1295179Reviewed-by:
Tommy Li <tommycli@chromium.org> Commit-Queue: Joe DeBlasio <jdeblasio@chromium.org> Cr-Commit-Position: refs/heads/master@{#602032}
-
yozeke authored
Only fix comment typo. No behavior changes. Change-Id: Ie77c6614676be140551e0661474167c87b2d2646 Reviewed-on: https://chromium-review.googlesource.com/c/1292654Reviewed-by:
-
James Wallace-Lee authored
Sending an event requires an AXAuraObjWrapper, not an actual view, so dispatch events on current_tree_->GetRoot() by default. This fixes a crash in ChromeVox's mouse following where events are fired when there is no active window (as when all windows are minimized). Change-Id: I513d9b0547a5b31a7cf26a57648846c10bd86866 Reviewed-on: https://chromium-review.googlesource.com/c/1294517 Commit-Queue: James Wallace-Lee <jamwalla@chromium.org> Reviewed-by:
-
David Trainor authored
Add the metrics work to downloads home v2. This includes adding startup tracking for which downloads will be shown in the UI as well as various view interaction metrics. Note that this patch unifies metrics code where possible with the old downloads home, but doesn't do it everywhere. BUG=864354 WIP Change-Id: Iac096585456d9bd33b4ef3300a9fdbf0cba25610 Reviewed-on: https://chromium-review.googlesource.com/c/1285523 Commit-Queue: David Trainor <dtrainor@chromium.org> Reviewed-by:
Shakti Sahu <shaktisahu@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#602029}
-
Stephen McGruer authored
This CL pushes the start/end scroll offset information through to the compositor and updates the currentTime algorithm to make use of it. Updates to the start/end scroll offset are wired through blink::WorkletAnimation::UpdateOnCompositor, however the animation is not invalidated yet if the scroller properties would change (e.g. due to layout changing). This will be done in a follow-up CL. Bug: 885196 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I67da2c1ef26b66314af5891a2356920164fa0b0f Reviewed-on: https://chromium-review.googlesource.com/c/1271398 Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Reviewed-by:
Majid Valipour <majidvp@chromium.org> Cr-Commit-Position: refs/heads/master@{#602028}
-
Nico Weber authored
Also don't use -UTF8String in os_exchange_data_provider_mac.mm to pacify presubmit. Bug: 324079 Change-Id: I4357d1b94cb6fb18bb73d604292afa7241838cbe Reviewed-on: https://chromium-review.googlesource.com/c/1296671Reviewed-by:
-
David Trainor authored
We were loading a vector drawable using ApiCompatibilityUtils, which does not use AppCompatResources. Made the change to now load the drawable using AppCompatResources instead. BUG=897754 Change-Id: Ic3778f10a010e5b5dabac054c1a1cf9849ac3a22 Reviewed-on: https://chromium-review.googlesource.com/c/1294390Reviewed-by:
-
Josh Nohle authored
Make SmartLock work after clients (chromebooks) update but before legacy hosts (phones) update. The phone side flags and enrollment will be slower than the ChromeOS rollout. In order to avoid breaking SmartLock in the meantime, look for cases where: 1) There are no host devices reporting BETTER_TOGETHER_HOST support. 2) There is at least one host device reporting EASY_UNLOCK_HOST support. In that case, the legacy SmartLock settings will be available in chrome://settings/lockScreen, fully capable of enabling/disabling. Bug: 895585 Change-Id: Iff0ebb46fac2a43f6af32b09182a621ca43b54fa Reviewed-on: https://chromium-review.googlesource.com/c/1287045Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Reviewed-by:
James Hawkins <jhawkins@chromium.org> Commit-Queue: Josh Nohle <nohle@chromium.org> Cr-Commit-Position: refs/heads/master@{#602025}
-
Chase Phillips authored
Coming out of a review for an onion soup CL (https://crrev.com/c/1265900), mek@ suggested I use a UnionTraits declaration to handle IDBKey.data and its union type IDBKeyData. This CL implements that for the current Chromium variant of the IndexedDB struct traits. Bug: 717812 Change-Id: I8b599be0218f3542bbfa0fd59efeef1e319df6f6 Reviewed-on: https://chromium-review.googlesource.com/c/1284390 Commit-Queue: Chase Phillips <cmp@chromium.org> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#602024}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/62b3004439ca..c88cc779efdb git log 62b3004439ca..c88cc779efdb --date=short --no-merges --format='%ad %ae %s' 2018-10-23 reed@google.com remove (unused) vertical-text 2018-10-23 mtklein@google.com SkEdgeBuilder refactoring 2018-10-23 scroggo@google.com Fix an assert in SkBmpCodec::ReadHeader 2018-10-23 recipe-roller@chromium.org Roll recipe dependencies (trivial). 2018-10-23 caryclark@skia.org remove extra include Created with: gclient setdep -r src/third_party/skia@c88cc779efdb The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel BUG=chromium:897389 TBR=brianosman@chromium.org Change-Id: Ie5c66b5069f45001d9a9b9a68b50e89026e7b7b2 Reviewed-on: https://chromium-review.googlesource.com/c/1296852Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#602023}
-
Ted Choc authored
This makes the omnibox sizing part of the measure flow. The coordinator layout allows to specify anchor views which determines the layout ordering ensuring the anchor view is laid out prior to the suggestion view. This ensures that on rotation, the measured width of the anchor view is correct before measure is called on the list. BUG=843596 Change-Id: I030f09f82476c427c7ab1f966961a567ad72ecba Reviewed-on: https://chromium-review.googlesource.com/c/1289997 Commit-Queue: Ted Choc <tedchoc@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#602022}
-
Shakti Sahu authored
This CL fixes a crash for API 19 when inflating layout for in-progress items. We remove the selectableItemBackground attribute from the XML which fixes the issue. However, with this change, the pause/resume button doesn't provide user feedback on tap. We most likely have to implement our own selectable item background for this. Bug: 896808 Change-Id: I0156802c862fd11357d6a5179c42e8977896b847 Reviewed-on: https://chromium-review.googlesource.com/c/1294728Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Cr-Commit-Position: refs/heads/master@{#602021}
-
Lukasz Anforowicz authored
Bug: 891904, 891891 Change-Id: I1e05b2527ff7f2e2c452525fa3a460dedc96e9f5 Reviewed-on: https://chromium-review.googlesource.com/c/1263555 Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Raymes Khoury <raymes@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#602020}
-
Clark DuVall authored
These were enabled in http://crrev.com/c/1290142. TBR=jam@chromium.org Bug: 893563 Change-Id: I11ce3c5c283b28a4089bf8e10ae983a541c4bbcf Reviewed-on: https://chromium-review.googlesource.com/c/1297076Reviewed-by:
Clark DuVall <cduvall@chromium.org> Reviewed-by:
-
Fredrik Söderquist authored
Rather than using the value of the 'pointer-events' property (and indirectly, the 'visibility' property and potentially others not explicitly listed in the spec), pass 'fill' and 'stroke' respectively to better match spec [1]. Use AsPath() in isPointIn{Fill,Stroke} instead of going to the LayoutSVGShape, to hopefully allow the LayoutSVGShape to be stricter about invariants. [1] https://svgwg.org/svg2-draft/types.html#InterfaceSVGGeometryElement Bug: 896638 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I4f8ef5ae4e84d29187e68ca243e3344a9a27544c Reviewed-on: https://chromium-review.googlesource.com/c/1288574 Commit-Queue: Fredrik Söderquist <fs@opera.com> Reviewed-by:
-
