- 14 Nov, 2018 40 commits
-
-
Anders Hartvoll Ruud authored
According to css-variables-1, any custom property that participates in a cycle is invalid. This also applies to registered custom properties. In the current implementation, however, registered custom properties with an initial value can not become invalid; they compute to their initial value instead, as provided by registerProperty. A consequence of this, is that fallbacks (specified by var()-references) are never triggered if the referenced property is a registered property with an initial value defined. The value for any unregistered custom property, if no other value is specified, is the invalid initial value described by css-variables-1. This means we can just avoid storing the variable on ComputedStyle, to signify the invalid initial value. However, the value for any registered custom property, if no other value is specified, can be the initial value specified by registerProperty. When there is no value explicitly stored on ComputedStyle, we check StyleInitialData and fetch the initial value from there. Hence, we can not use the absence of a value to signify an invalid registered variable, as we already use this state to mean "initial value from registerProperty". This means that we must explicitly store a value for registered properties that participate in a cycle. This CL adds CSSInvalidVariableValue to do this. * When resolving a registered custom property, if a cycle is detected, set the registered value to CSSInvalidVariableValue. * When looking up a registered custom property, if we already have the value CSSInvalidVariableValue, return nullptr instead of initial data. This triggers fallbacks. * The code that set the cycle_detected flag was weird; a cycle could be marked as detected, even though ResolveTokenRange succeeded. This meant that any custom property which referenced a property in a cycle would also be treated as part of the cycle, which is wrong. Fixed by only setting the cycle_detected flag when we have cycle start points. * CSSInterpolationType did not initialize its cycle_detected variable, which led to undefined behavior. R=futhark@chromium.org Bug: 641877 Change-Id: I2c518b176de26f7b2f05b36b568041a228fcb0ea Reviewed-on: https://chromium-review.googlesource.com/c/1333758 Commit-Queue: Anders Ruud <andruud@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#608014}
-
Hugo Holgersson authored
Intent to Ship (approved November 6): https://groups.google.com/a/chromium.org/d/msg/blink-dev/Fku6784p0wI/3MyOMTk7BwAJ This CL mimics Firefox's behavior; all content in scroll containers are now keyboard-accessible, see the test reach-and-scroll-overflow-div-without-mouse.html. Without this fix, some scrollers' web content is not accessible at all without a mouse pointer. To be able to write compact and hopefully soon WPT-compatible tests, this CL generalizes spatial navigation's JS helpers so they also cover sequential navigation. If you suspect this change caused a regression, try disabling it: --disable-blink-features=KeyboardFocusableScrollers Follow-up: - This change is needed by spatial navigation (Issue 801162). Bug: 585413 Change-Id: I200cdfd1afd02b354ef23bafd119abe558491dd0 Reviewed-on: https://chromium-review.googlesource.com/c/1258331 Commit-Queue: Hugo Holgersson <hugoh@vewd.com> Reviewed-by:
Navid Zolghadr <nzolghadr@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#608013}
-
Camillo Bruni authored
This CL was created automatically with tools/perf/update_wpr script R=perezju@chromium.org Bug: 878390 Change-Id: I40efb621c05c77f0d032f8392991cb3b827cab1d Reviewed-on: https://chromium-review.googlesource.com/c/1329666 Commit-Queue: Camillo Bruni <cbruni@chromium.org> Reviewed-by:
Juan Antonio Navarro Pérez <perezju@chromium.org> Cr-Commit-Position: refs/heads/master@{#608012}
-
Adithya Srinivasan authored
MakeIsolatedRequest was renamed in https://crrev.com/c/753624. Change-Id: I1225ce04242adb398693ac0ff4612c9f672754df Reviewed-on: https://chromium-review.googlesource.com/c/1334663Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Adithya Srinivasan <adithyas@chromium.org> Cr-Commit-Position: refs/heads/master@{#608011}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/388a62c2..ebedb7eb Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Iadba57fbe09f1fe7ee15ff1a84b2c4141712783a Reviewed-on: https://chromium-review.googlesource.com/c/1335732Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#608010}
-
Mohamed Amir Yosef authored
Bug: 902349 Change-Id: Ic8f20ba353bf9805d79916f440fe10137a97aff7 Reviewed-on: https://chromium-review.googlesource.com/c/1325981 Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#608009}
-
Alex Clarke authored
We are no longer considering having anything other than a FIFO scheduler on the IO thread (which is why it was added in the first place). Split off from https://crrev.com/c/1320329. TBR=gab@chromium.org Bug: 863341, 891670 Change-Id: I6e7c4fdd2772ec85dfffcf4bad051b0785b0a050 Reviewed-on: https://chromium-review.googlesource.com/c/1335930 Commit-Queue: Alex Clarke <alexclarke@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
Alex Clarke <alexclarke@chromium.org> Cr-Commit-Position: refs/heads/master@{#608008}
-
Stephane Zermatten authored
This patch take out initialization and delayed shutdown from AutofillAssistantUiController: * initialization goes into a new class AutofillAssistantFacade, called from CustomTabActivity. * UiDelegateHolder becomes a toplevel class, responsible for delayed shutdown and UI pausing The following responsibilities remain in AutofillAssistantUiController: * bridging Java -> C++ and C++ -> Java * account management and authentication This patch also unifies the way the "give up" message is displayed in Java, removes the unnecessary C++ OnGiveUp method and always hides the overlay and the event filter when switching to graceful shutdown mode. Bug: 806868 Change-Id: Idef806520f5e6e8a6dda4fc843d61bf77c1eafb4 Reviewed-on: https://chromium-review.googlesource.com/c/1333652 Commit-Queue: Stephane Zermatten <szermatt@chromium.org> Reviewed-by:
Egor Pasko <pasko@chromium.org> Reviewed-by:
Mathias Carlen <mcarlen@chromium.org> Cr-Commit-Position: refs/heads/master@{#608007}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/2b1f6b373ca9..5beeee15c175 git log 2b1f6b373ca9..5beeee15c175 --date=short --no-merges --format='%ad %ae %s' 2018-11-14 zoddicus@users.noreply.github.com Add fuzzer for spvBinaryParser (#2045) Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@5beeee15c175 The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: If335b01039a4bc91001837fa5de5c3cad8b519cd Reviewed-on: https://chromium-review.googlesource.com/c/1335831Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#608006}
-
Alexei Svitkine authored
Combines the GetSwitchesFromFlags() and GetFeaturesFromFlags() calls to avoid GenerateFlagsToSwitchesMapping() being called twice, which we have evidence of being expensive. Bug: 904575 Change-Id: Ie89acad8175fdfe029a951074b9aa1f4f7678f95 Reviewed-on: https://chromium-review.googlesource.com/c/1333875 Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
ssid <ssid@chromium.org> Cr-Commit-Position: refs/heads/master@{#608005}
-
Ian Clelland authored
This change adds a "report-only" policy to each security context, which is local to that context (not replicated across processes) and is used to determine whether a report should be sent even if a feature is enabled, when the feature is used. Reports are now augmented with a "disposition" field, which is either "enforce", if the feature usage was actually blocked, or "report", if it was not. Feature policy directives are placed in the report-only policy if the feature name is suffixed with "-report-only", otherwise, they affect the regular (enforcing) policy. Explainer at https://github.com/WICG/feature-policy/blob/master/reporting.md Existing tests are updated, and new tests for report-only mode are added to ensure that reports are sent even when the feature is used successfully. Bug: 904878 Change-Id: I27bc42729c5ab5560160f3d993431e606a8a3a47 Reviewed-on: https://chromium-review.googlesource.com/c/1178811 Commit-Queue: Ian Clelland <iclelland@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#608004}
-
Jan Krcal authored
This CL adds more integration tests; it also fixes a bug that stopped local changes of billing address and local changes of has_converted to get propagated to sync. Bug: 894001 Change-Id: Idd91e6799afd3c936b76ac8b1a6851abc67b5ad7 Reviewed-on: https://chromium-review.googlesource.com/c/1333819Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Commit-Queue: Jan Krcal <jkrcal@chromium.org> Cr-Commit-Position: refs/heads/master@{#608003}
-
Sadrul Habib Chowdhury authored
Instead of sending the presentation-feedback over a separate IPC, include it with the begin-frame messages. The presentation feedback can be requested for each frame. So this can reduce an extra IPC per frame for each client. BUG=883592 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Iab52a29f406078eab79948a942124c8e13cb4332 Reviewed-on: https://chromium-review.googlesource.com/c/1175492Reviewed-by:
Robert Flack <flackr@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#608002}
-
Brian Osman authored
This enables a fast-path in Skia's AAConvexPathRenderer for paths that only have lines (no higher order curves). Change-Id: I0222d572f7679a270f6634bfc326a145dd6a7bed Reviewed-on: https://chromium-review.googlesource.com/c/1334230Reviewed-by:
Florin Malita <fmalita@chromium.org> Commit-Queue: Brian Osman <brianosman@google.com> Cr-Commit-Position: refs/heads/master@{#608001}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/4cda101d36dd..d7aa8b741012 git log 4cda101d36dd..d7aa8b741012 --date=short --no-merges --format='%ad %ae %s' 2018-11-14 hjd@google.com Merge "trace_processor: JSON importer coerces numbers" Created with: gclient setdep -r src/third_party/perfetto@d7aa8b741012 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: I6bb7e0224ea80be04506b7b1ff07176e67d040c6 Reviewed-on: https://chromium-review.googlesource.com/c/1335770Reviewed-by:
-
Jun Choi authored
Replace callbacks in FidoBleDevice bound to base::Unretained(this) to callbacks bound to weak pointers. When user navigates away from the site calling the WebAuthN API while request is being dispatched, callbacks in FidoBleDevice may be invoked after FidoBleDevice is destroyed. This is especially the case when the user navigates away during pairing process. In this case, FidoBleDevice::OnReadControlPointLength() will be called after FidoBleDevice is destroyed. Bug: 877344 Change-Id: I14ad94cfc9624c50eeee88feb1a12a6f8488c696 Reviewed-on: https://chromium-review.googlesource.com/c/1335727Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Commit-Queue: Jun Choi <hongjunchoi@chromium.org> Cr-Commit-Position: refs/heads/master@{#607999}
-
David Bokan authored
In https://crrev.com/c/1332769 we removed the vsync aligned feature flag. This caused the removal of much code in GestureEventQueue. Namely, it no longer attempts to coalesce and queue events. This CL cleans up the nomenclature and commentary in the class to better reflect its current duties. Bug: 625689 Change-Id: I295fec7923b8d251853b9522c54641edfcac076a Reviewed-on: https://chromium-review.googlesource.com/c/1334203Reviewed-by:
-
Xida Chen authored
There is no definition of this function. Bug: None Change-Id: I51f25306a794bfe55612ad90500f9538643a85c4 Reviewed-on: https://chromium-review.googlesource.com/c/1335829Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#607997}
-
Peter Boström authored
The load-progress animation is driven off a timer that starts in LoadingStateChanged and progresses without scheduling another update. This is a likely cause for performance regressions as all load progress updates (even ones without UI changes) will hammer this function. Bug: chromium:905189, chromium:903147, chromium:901751 Change-Id: I92828bbaee6f15fc497ae50ec0d4c3975e638a86 Reviewed-on: https://chromium-review.googlesource.com/c/1335948Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#607996}
-
Eric Seckler authored
So that we can access the process-wide client from other tracing agents. Bug: 900603 Change-Id: Ie157ecc6c5e59e449c8e8182d3a2b31ea8b1bd9e Reviewed-on: https://chromium-review.googlesource.com/c/1335588Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Reviewed-by:
oysteine <oysteine@chromium.org> Commit-Queue: Eric Seckler <eseckler@chromium.org> Cr-Commit-Position: refs/heads/master@{#607995}
-
Steve Anton authored
Bug: None Change-Id: I39361bdfe70f51804cdc01e54d474fe064e1b366 No-Try: True Reviewed-on: https://chromium-review.googlesource.com/c/1335888Reviewed-by:
Henrik Boström <hbos@chromium.org> Commit-Queue: Steve Anton <steveanton@chromium.org> Cr-Commit-Position: refs/heads/master@{#607994}
-
Vladislav Kaznacheev authored
Add AppDataRequestState.NOT_SIGNED_IN to support ag/5485166 Bug: b:118888407 Test: compile Change-Id: If708bbad7a400edacd8c0b144ba1903c448d9286 Reviewed-on: https://chromium-review.googlesource.com/c/1331952Reviewed-by:
Yury Khmel <khmel@chromium.org> Reviewed-by:
Mattias Nissler <mnissler@chromium.org> Commit-Queue: Vladislav Kaznacheev <kaznacheev@chromium.org> Cr-Commit-Position: refs/heads/master@{#607993}
-
Paul Jensen authored
WebView does not require this permissions so this check is necessary. Internal bug b/119516001. Change-Id: Icbc37b5f9ff24343d50a81a28d1ee0a58644e9bc Reviewed-on: https://chromium-review.googlesource.com/c/1335868Reviewed-by:
Misha Efimov <mef@chromium.org> Commit-Queue: Paul Jensen <pauljensen@chromium.org> Cr-Commit-Position: refs/heads/master@{#607992}
-
Philip Rogers authored
This patch re-enables PaintTouchActionRects after the following changes: crrev.com/606921 - Ensure PaintChunk::hit_test_data is updated in a cached subsequence crrev.com/607236 - Paint replaced hit test rects without background crrev.com/607238 - Paint hit test rects when acceleration skips bg These fixes address all known issues. Bug: 903480 Change-Id: I8ae56a1b97b5d9345508a8193a55097a9040bd89 Reviewed-on: https://chromium-review.googlesource.com/c/1334330Reviewed-by:
Xida Chen <xidachen@chromium.org> Reviewed-by:
Xianda Sun <sunxd@chromium.org> Commit-Queue: Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#607991}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/b45b53f01cf3..7f2b6fa66575 git log b45b53f01cf3..7f2b6fa66575 --date=short --no-merges --format='%ad %ae %s' 2018-11-14 caryclark@skia.org fix pathops fuzzes Created with: gclient setdep -r src/third_party/skia@7f2b6fa66575 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel TBR=rmistry@chromium.org Change-Id: Ia8902afcad2f62d7b681d99b04b89c761795add7 Reviewed-on: https://chromium-review.googlesource.com/c/1335771Reviewed-by:
-
Martin Robinson authored
ATK requires us to allow it to filter all key events. Add an AtkUtil mechanism to filter key events. Bug: 866334 Change-Id: I42383479ab78242325bda0714afb60b7dcf2fe65 Reviewed-on: https://chromium-review.googlesource.com/c/1319709 Commit-Queue: Martin Robinson <mrobinson@igalia.com> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
-
Mirko Bonadei authored
The fix has been upstreamed and it will be rolled as soon as Abseil rolls into //third_party/abseil-cpp. Bug: None Change-Id: Ifd5e17c30b021518f09d81ad60da919303d5e6ee Reviewed-on: https://chromium-review.googlesource.com/c/1335927 Commit-Queue: Mirko Bonadei <mbonadei@chromium.org> Reviewed-by:
Marina Ciocea <marinaciocea@chromium.org> Cr-Commit-Position: refs/heads/master@{#607988}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/c58c8a54224d..76f9954b17a4 git log c58c8a54224d..76f9954b17a4 --date=short --no-merges --format='%ad %ae %s' 2018-11-14 terelius@webrtc.org Remove the old RTC event log parser. 2018-11-14 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision db720b4a..fbed28d4 (606025:607938) 2018-11-14 yvesg@webrtc.org Less strict audio codec tests to accomodate opus switch to SSE. 2018-11-14 yvesg@webrtc.org Fix lint errors for android manifests. 2018-11-14 mbonadei@webrtc.org Rectify comment about 'build_with_chromium'. Created with: gclient setdep -r src/third_party/webrtc@76f9954b17a4 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng BUG=chromium:None,chromium:900912 TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I9b3cfb1fa144d2aaf6dcffc1c1968642403d327c Reviewed-on: https://chromium-review.googlesource.com/c/1335772Reviewed-by:
-
Mihai Sardarescu authored
The CL removes libgtk-3-0:i386 from install-build-deps.sh as it fails to be installed on the freshly installed Google glinux machine. For more info and the errors installing the package, see https://groups.google.com/a/chromium.org/forum/#!topic/chromium-dev/ODZ88EuoxK4 Change-Id: I4cf64ef3b98fd2a8a5299d4859da63c7a0c5f4f9 Reviewed-on: https://chromium-review.googlesource.com/c/1332207Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Commit-Queue: Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#607986}
-
Xianda Sun authored
With cc generated hit test data, viz hit test surface layer is capable of doing synchronous hit testing under some non-trivial cases. Despite that it still has to do slow path hit testing under some circumstances. This patch added a metric to record the reasons of slow path hit test. Bug: 901882 Change-Id: Icaff4c9ba01add4dfc4620b5d7e28fd85683dba9 Reviewed-on: https://chromium-review.googlesource.com/c/1318078Reviewed-by:
Ria Jiang <riajiang@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Reviewed-by:
-
Yuki Shiino authored
OnBeforeUnloadEventHandler's return type is DOMString?, so we need to handle the case that the return value is null. This patch fixes the behavior in case of null. Change-Id: I23e4b06174adb42111584f1e84f7ca1c9d04e56c Reviewed-on: https://chromium-review.googlesource.com/c/1335750Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#607984}
-
Takumi Fujimoto authored
This CL adds test API that will be used by integration and e2e browser tests to manipulate the Views Cast dialog. Bug: 900243 Change-Id: I0dc0c4ce08a3f9b78764459b6298502d4a8e0901 Reviewed-on: https://chromium-review.googlesource.com/c/1284211 Commit-Queue: Takumi Fujimoto <takumif@chromium.org> Reviewed-by:
mark a. foltz <mfoltz@chromium.org> Cr-Commit-Position: refs/heads/master@{#607983}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/db3e43bd9c5d..1680e702bb3f Created with: gclient setdep -r src-internal@1680e702bb3f The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Ic9b3206c365407f978d0306b19a51c022207168c Reviewed-on: https://chromium-review.googlesource.com/c/1335773Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#607982}
-
Antonio Gomes authored
BUG=904407 Change-Id: Ibfc219bb273a7ff8ee1d8693ca2f25994a038f5b Reviewed-on: https://chromium-review.googlesource.com/c/1335907Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/master@{#607981}
-
Ken Rockot authored
Fixes mojom JS lite serialization in cases where fields are intentionally packed out of order. This actually simplifies the serialization and deserialization logic significantly by leveraging precomputed byte/bit offset values from the bindings generator and preallocating the entire message buffer prior to serialization. It also is now correct instead of incorrect, which is nice. Bug: 904861 Change-Id: If08c301303004d164f4a0afcc3085dac86ca3089 Reviewed-on: https://chromium-review.googlesource.com/c/1335269Reviewed-by:
calamity <calamity@chromium.org> Commit-Queue: Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#607980}
-
Camillo Bruni authored
This CL was created automatically with tools/perf/update_wpr script R=perezju@chromium.org Bug: 878390 Change-Id: Ib1c39da9570be4bdebccc23e896663f0eeb3ddd5 Reviewed-on: https://chromium-review.googlesource.com/c/1329628 Commit-Queue: Camillo Bruni <cbruni@chromium.org> Reviewed-by:
-
Boris Sazonov authored
This CL checks that Intent received by SigninFragmentBase.onActivityResult isn't null before trying to get account name from it. The Intent can be null on older Android versions, leading to a crash. Also, after this CL AccountPickerDialogFragment won't be dismissed if onActivityResult can't get the account name from the Intent, letting the user to select the account manually. Bug: None Change-Id: I4740410da75023ee73fb90b6f7f9659982b96190 Reviewed-on: https://chromium-review.googlesource.com/c/1335577Reviewed-by:
-
Marc Treib authored
instead of syncer::FakeSyncService. TestSyncService already supports a good portion of the setters that are needed here, so this allows us to remove a bunch of boilerplate. Bug: 859874 Change-Id: I2520cfb526c81de566630dd7f956ddc45eabcee3 Reviewed-on: https://chromium-review.googlesource.com/c/1335593Reviewed-by:
Thomas Tangl <tangltom@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#607977}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/e7da3e75..388a62c2 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I456267006d8b70fe61c2d95ff3d3ab9d4c1d6333 Reviewed-on: https://chromium-review.googlesource.com/c/1335828Reviewed-by:
-
Alexandr Ilin authored
This CL allows to avoid the cost of calling GetCategoryGroupEnabled() in TRACE_EVENT macros for popular categories, in a way that doesn't require more macros, nor changing all the call sites. The idea is to put all popular categories into a static global array so an address of a category state may be determined at compile-time through a call to a constexpr function. This CL makes it impossible to use non constant expressions as a category name in the tracing macros. All the call sites that don't satisfy this requirement have to be converted. Hopefully, there aren't a lot of such callers. This change reduces the code size generated from each trace macro by ~16 bytes, check the full report here: https://docs.google.com/document/d/1piIq_yi2fsqOEKObx0tFHeunMyX7hp2ZdAGKK6t0k80/edit?usp=sharing. The total Android apk size savings are ~60 KiB. Bug: 702718, 708990 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I9f7b48fd4ee614996feaabda3e5495fd9b786c3a Reviewed-on: https://chromium-review.googlesource.com/c/1251361 Commit-Queue: Alexandr Ilin <alexilin@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Primiano Tucci <primiano@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
Frank Liberato <liberato@chromium.org> Reviewed-by:
vmpstr <vmpstr@chromium.org> Reviewed-by:
David Turner <digit@chromium.org> Cr-Commit-Position: refs/heads/master@{#607975}
-
