- 26 May, 2020 40 commits
-
-
Daniel Nicoara authored
The plane may not support the specific format for scanout. This is fine if the buffers have an opaque version (ie: XRGB and ARGB) and blending is disabled for scanout as the opaque version is used for scanout. BUG=1082545 TEST=Ran in cros VM Change-Id: I1a5caac796999d778eea272eed06dcbc261ac5e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212980 Commit-Queue: Daniel Nicoara <dnicoara@chromium.org> Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Cr-Commit-Position: refs/heads/master@{#771807}
-
Antonio Sartori authored
This fixes a bug introduced by https://crrev.com/770126. Also after CORS redirects we store the right initial URL in the ResourceTimingInfo. Bug: 1085332 Change-Id: I2e7b55967cc54c8bee87cd62920db76f1a25e517 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212280Reviewed-by:
Nicolás Peña Moreno <npm@chromium.org> Reviewed-by:
Yoav Weiss <yoavweiss@chromium.org> Commit-Queue: Antonio Sartori <antoniosartori@chromium.org> Cr-Commit-Position: refs/heads/master@{#771806}
-
Side Yilmaz authored
This CL fixes wrong usages of profile at PaymentRequestHeader by adding extra profile parameter to |setTitleAndOrigin| function, while PaymentRequestUI passes the profile to the function. Bug: 1041781, 1075562 Change-Id: I9c23f54332c956ac27ea54ae6ef80c836034fcb7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2215807Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Commit-Queue: Side YILMAZ <sideyilmaz@chromium.org> Cr-Commit-Position: refs/heads/master@{#771805}
-
Jan Wilken Dörrie authored
This change applies the current enabled clang-tidy checks [1] on //components/password_manager and //chrome/browser/password_manager and performs some manual clean-up. [1] https://source.chromium.org/chromium/chromium/src/+/master:.clang-tidy;drc=d4c5e82aef1c958951e8810a3de7d03dfa7ad7c1 Bug: 776257 Change-Id: I6254e3384f889bba6229882bba6849caacfde9f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2214547Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#771804}
-
Ian Kilpatrick authored
These tests were inadvertently testing our UA stylesheet for the audio element. In our UA stylesheet we have: audio { width: Xpx; height: Ypx; } which means that the intrinsic size tests are failing. This fixes the tests to change the width/height when appropriate to "auto". There is probably a discussion which needs to be had about the UA style for the audio element, but not today. Bug: 960385 Change-Id: I3c5e1362015dec9cc95b7f4683a552e4afcc7424 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212635 Commit-Queue: Koji Ishii <kojii@chromium.org> Auto-Submit: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#771803}
-
Greg Thompson authored
For base::ReplaceFile to succeed on Windows, both the source and target files must have no open handles. Since ImportantFileWriter writes to a temporary file, closes it, and then calls ReplaceFile with that temporary file as the source, it will only succeed if no other processes have an open handle on either file. On Windows, the very act of closing a file that has been modified broadcasts a message to filesystem observers that a change has happened in the directory holding the file. Certain software may then try to open the file that was just closed. This, of course, will block ReplaceFile. This CL boosts the priority of the thread hosting an ImportantFileWriter for the brief window containing the close and replace operations. With any luck, this will help Chrome win the race against other software so that ReplaceFile succeeds more often. BUG=1075917 R=gab@chromium.org Change-Id: I2dd286f63e8b269d209da7497167b53ea3a54ef6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2214624 Commit-Queue: Gabriel Charette <gab@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Auto-Submit: Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#771802}
-
Marina Ciocea authored
Test times out flakily on linux-chromeos-rel. Bug: 1085666 Change-Id: I5566b39e71ff5b321b5a1ec1cfae10fdca2fe503 TBR: dtseng@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2215812Reviewed-by:
Marina Ciocea <marinaciocea@chromium.org> Commit-Queue: Marina Ciocea <marinaciocea@chromium.org> Cr-Commit-Position: refs/heads/master@{#771801}
-
chromium-autoroll authored
Roll ChromeOS Silvermont AFDO profile from 85-4136.1-1589799307-benchmark-85.0.4150.0-r1 to 84-4136.1-1589799722-benchmark-84.0.4147.17-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-silvermont-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: I7224bc03cc627b84136b860de466ddd1a74a76d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216156Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#771800}
-
chromium-autoroll authored
Roll ChromeOS Broadwell AFDO profile from 85-4136.1-1589796762-benchmark-85.0.4150.0-r1 to 84-4136.1-1589797128-benchmark-84.0.4147.17-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-broadwell-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: I758899c5370cc84984d93d4c8611194516ab1ba9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216155Reviewed-by:
-
Fredrik Söderqvist authored
This test generates a lot of <text> elements that will never be made visible by the test as currently written. Reduce the number of <text> elements to only those that will potentially intersect the viewport of the scrollable container during the test. Bug: 571296 Change-Id: I048516e4084cb4101a4058ee89b973d2cca7f338 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2215849 Commit-Queue: Fredrik Söderquist <fs@opera.com> Commit-Queue: Philip Rogers <pdr@chromium.org> Auto-Submit: Fredrik Söderquist <fs@opera.com> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#771798}
-
Harald Alvestrand authored
This test has been disabled on various platforms because of flakiness since 2015. Attempts to discover why it was flaky have been fruitless. We now have other tests (external/wpt/webrtc/simulcast) for testing simulcast functionality, so the value of fixing this one seems low. Bug: chromium:452623 Change-Id: I664010899c2a81d64a01c32a067aa93c214d9f46 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2190672 Commit-Queue: Harald Alvestrand <hta@chromium.org> Reviewed-by:
Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#771797}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/de2049e85aec..31001a610da6 2020-05-26 tommi@webrtc.org Remove receive_crit_ from Call. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I0d20a386329c2283bdde63f3cacdcc194d36a718 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2215897Reviewed-by:
-
Michael van Ouwerkerk authored
Change-Id: Ic7bece7e93e79e75e44d5c594c52b3d6c834cdd4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2214539 Commit-Queue: Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Auto-Submit: Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#771795}
-
Caitlin Fischer authored
Also, deletes the corresponding Java test, which is now redundant. Bug: 1049736 Change-Id: Ib8fb2833128d88c6fc6189ab2e45bbb245a8d697 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208597Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
-
chromium-autoroll authored
Roll ChromeOS Airmont AFDO profile from 85-4136.1-1589798899-benchmark-85.0.4150.0-r1 to 84-4136.1-1589794882-benchmark-84.0.4147.17-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-airmont-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: I51001ab2fd33ca0ca3e1ca5339c6790ea0456af6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216157Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/50020926f80d..55e97987f5f2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC marinaciocea@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: marinaciocea@google.com Change-Id: Id1bdaf4bba039682eb0576d75d5ab2e059f67004 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2215893Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#771792}
-
chromium-autoroll authored
Roll ChromeOS Airmont AFDO profile from 84-4136.1-1589794882-benchmark-84.0.4147.17-r1 to 85-4136.1-1589798899-benchmark-85.0.4150.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-airmont-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: Id3d4a793c9de8039bb02cd8187d98aa9a963e9ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216196Reviewed-by:
-
Fergus Dall authored
Bug: None Change-Id: Iced536274befbab8d08bd46bbed3755ebc996882 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2206754 Auto-Submit: Fergus Dall <sidereal@google.com> Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Commit-Queue: Joshua Pawlicki <waffles@chromium.org> Cr-Commit-Position: refs/heads/master@{#771790}
-
Alex Ilin authored
This reverts commit 9d2c67b2. Reason for revert: the assertion fails in many tests on Android L First failed builds: - Lollipop Phone Tester (https://ci.chromium.org/p/chromium/builders/ci/Lollipop%20Phone%20Tester/25458) - Lollipop Tablet Tester (https://ci.chromium.org/p/chromium/builders/ci/Lollipop%20Tablet%20Tester/14622) Original change's description: > android: Add LifetimeAssert to WindowAndroid > > Bug: 1081250 > Change-Id: Id0924545fbdb1eb28ae3c8fe015559fd3e9c53d1 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2191785 > Commit-Queue: Bo <boliu@chromium.org> > Reviewed-by: Andrew Grieve <agrieve@chromium.org> > Cr-Commit-Position: refs/heads/master@{#771220} TBR=boliu@chromium.org,agrieve@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1081250 Change-Id: I5721ca7286cdae4a462b83fb90aed393afca7d45 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2213537Reviewed-by:
Alex Ilin <alexilin@chromium.org> Commit-Queue: Alex Ilin <alexilin@chromium.org> Cr-Commit-Position: refs/heads/master@{#771789}
-
chromium-autoroll authored
Roll ChromeOS Silvermont AFDO profile from 84-4136.1-1589799722-benchmark-84.0.4147.17-r1 to 85-4136.1-1589799307-benchmark-85.0.4150.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-silvermont-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: Ibe1e5dec8827a85520dd4989ed8d9f54c3dcb620 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216195Reviewed-by:
-
chromium-autoroll authored
Roll ChromeOS Broadwell AFDO profile from 84-4136.1-1589797128-benchmark-84.0.4147.17-r1 to 85-4136.1-1589796762-benchmark-85.0.4150.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-broadwell-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: Ifd4114c4c3ce9df3be2258f751adad456f78942e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216191Reviewed-by:
-
Igor authored
The histogram is still useful since it gives some input in addition to what we get from EnrolledPolicyHasDMToken histogram. And since there are some values in the later that show some possible problems, we want to keep this histogram active for a while. BUG=chromium:1066033 TEST=None Change-Id: I31a9e6ee4b158fa843f36d6a3d44b5d18fee567b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2214886 Commit-Queue: Igor <igorcov@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Igor <igorcov@chromium.org> Auto-Submit: Igor <igorcov@chromium.org> Cr-Commit-Position: refs/heads/master@{#771786}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/b5479f2a80cf..19ffa683a1c0 2020-05-26 bryct@amazon.com Add make-continuous-headless target (headless option) to Makefile. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC westont@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: westont@google.com Change-Id: I3452e577521df2677295741eab1393ea6e1231c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2215896Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/8ea04b09d5a4..4b342721d088 2020-05-26 tvanderlippe@chromium.org Use acorn-loose from front_end/third_party 2020-05-26 tvanderlippe@chromium.org Update http-proxy If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1011811 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ia22346907ba9eaa1d38c38358abfcc704ef59dd8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2215894Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1590479866-bd3b364dec503175394de5d27879ac865b50ea38.profdata to chrome-win32-master-1590494094-4933e9898781e7babab5bec8654610960e408cf7.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: I2827716810487cf98bf8d1354e65055d6eff85bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2215900Reviewed-by:
-
Mohamed Amir Yosef authored
This CL is making use of the recent modification to the combobox that now supports: 1- Showing icons in the dropdown menu. 2- Showing different text in the combobox from the dropdown menu. 3- Showing a secondary text (2nd line) in the dropdown menu. Mocks: https://screenshot.googleplex.com/12SDSKY7RUm Screenshot: Open: https://screenshot.googleplex.com/JQ886fwsNDs Account selected: https://screenshot.googleplex.com/rdi2vPbiPV7 Device selected: https://screenshot.googleplex.com/qvxGgLXfiz9 Bug: 1044038 Change-Id: I0a3dcc5df6f68771d338190a40f6d9a162c825a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2207223 Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#771782}
-
Finnur Thorarinsson authored
Ensure calls to MediaPlayer#seekTo are guarded by appropriate SDK level checks, to avoid lint errors. This slipped in while the linter was down due to an error somewhere. TBR: wnwen@chromium.org Bug: 1081243, 895776, 656015 Change-Id: I38143673afa986b310573595435dd2237d8a620b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2214947 Commit-Queue: Finnur Thorarinsson <finnur@chromium.org> Auto-Submit: Finnur Thorarinsson <finnur@chromium.org> Reviewed-by:
Peter Conn <peconn@chromium.org> Cr-Commit-Position: refs/heads/master@{#771781}
-
Jochen Eisinger authored
Bug: 873178, 927509 Change-Id: I3bdacf95a6c653a9eeabadafe0a7b11a525a6aa3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2215810Reviewed-by:
Martin Šrámek <msramek@chromium.org> Commit-Queue: Jochen Eisinger <jochen@chromium.org> Cr-Commit-Position: refs/heads/master@{#771780}
-
Andrei Salavei authored
Cancel component policy data update job when it was delayed (due to fetch error) and new fetch request with the same parameters come. Bug: 731109 Change-Id: Icc2f27cdcf475afec1369b787bfd56a9936c4356 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2214527 Commit-Queue: Andrei Salavei <solovey@google.com> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Cr-Commit-Position: refs/heads/master@{#771779}
-
Nicolás Peña Moreno authored
It looks like actions.send() does not wait for the events to get processed in order to resolve the promise, which means eventCounts may not be populated by the time we begin testing it. Hence, in this CL we perform a polling-based approach. Sample failure: https://isolateserver.appspot.com/browse?namespace=default-gzip&digest=8e7df6aa16ccbffabef2b11c5f2d9aaa02d396c1&as=layout-test-results%5Cexternal%5Cwpt%5Cevent-timing%5Cmouseover-actual.txt Bug: 1074048 Change-Id: I58629d66ad146fd435fc95fb875f21a96f5470a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212497Reviewed-by:
-
Alice Wang authored
This CL adds BookmarkTestRule and refactors bookmark signin promo tests with it. Prior to the CL, the bookmark manager is only opened but destroyed outside the test environment. The BookmarkTestRule helps to destroy the bookmark manager before the mock signin environment's teardown. Bug: 1080553 Change-Id: I940886577b9b330023c72b6ec2dbae81b1d726a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2193112 Commit-Queue: Alice Wang <aliceywang@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#771777}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1590479866-02719b24a518e7640038fc4f4eebb5b489becebf.profdata to chrome-mac-master-1590494094-23904e540b881376a708d1584e8efd523290bbdf.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: I92d36f9b33f5450d9680b70b169458958754d640 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2215899Reviewed-by:
-
nancylingwang@google.com authored
BUG=1068884 Change-Id: I7fd646bc3a714c6d06554d886c7a802771497559 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2203041 Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#771775}
-
Rune Lillesveen authored
Bug: 1085772 Change-Id: I00c14ac5b874d3cd3d4df41c6bd8be43c320b970 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2215843Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#771774}
-
Nicolás Peña Moreno authored
The WPT.FYI results [1] show that several tests which pass on our bots are actually timing out there. I dug into this and it seems to be due to improper usage of swap promises. In the testcase I looked, a mouseover event occurs, triggering the swap promise. Then a long mousedown occurs. While it is being processed, the GPU completes the frame and resolves the swap promise. However, the main thread is busy at the moment while its handling the mousedown, so it does not yet know about this. In the current logic, there is still a pending swap promise, hence no new swap promise is queued when mousedown handlers have finished executing. This means that both the mouseover and mousedown events use the same swap promise, one which had a paint timestamp which is way before the mousedown handlers have even finished. This means that the |duration| for the mousedown entry is also much less, and hence no entry is dispatched for this event and the tests timeout. The fix is to queue a swap promise when none are queued, or when a new paint lifecycle occurs. This way we queue at most one promise per frame when we're actively painting content, and have at most one queued promise when the renderer is not painting. This fixes the tests, at least per my manual running of /.wpt run, which reproduces the timeouts seen in wpt.fyi. [1 ]https://wpt.fyi/results/event-timing?label=experimental&label=master&aligned Bug: 543598 Change-Id: I298abb1e13adb0b17f1b2d493cb18b43c407c863 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2174880Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Steve Kobes <skobes@chromium.org> Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> Cr-Commit-Position: refs/heads/master@{#771773}
-
Robbie Gibson authored
When cookies are blocked, access to other storage methods should also be blocked Bug: 1075534 Change-Id: Id6487617b55735cace97fe0e3e9401f6f1007eca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2202802 Commit-Queue: Robbie Gibson <rkgibson@google.com> Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#771772}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/2bc8f192..2e7c4b66 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I9ec8e142448df791ab25a199d72a65d859fda201 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2215697Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#771771}
-
Maksim Sisov authored
That source file is platform agnostic and used by X11 and Ozone/X11/Wayland. Remove unneseccary includes. Test: compile test ozone/wayland only Change-Id: I9d314988f1dff2ae16043619c947a068229de9f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216073 Auto-Submit: Maksim Sisov <msisov@igalia.com> Commit-Queue: Martin Robinson <mrobinson@igalia.com> Reviewed-by:
Martin Robinson <mrobinson@igalia.com> Cr-Commit-Position: refs/heads/master@{#771770}
-
Wolfgang Beyer authored
Update test expectations to allow DevTools CL [1] to land. [2] updates the tests and restores the expectations. [1] https://crrev.com/c/2213439 [2] https://crrev.com/c/2213534 Bug: chromium:1011811 Change-Id: I392f6046f2381444825b3bd3152799bdc02f5e67 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2214952Reviewed-by:
Tim van der Lippe <tvanderlippe@chromium.org> Commit-Queue: Wolfgang Beyer <wolfi@chromium.org> Cr-Commit-Position: refs/heads/master@{#771769}
-
Eric Seckler authored
And add a bunch of missing includes elsewhere that were breaking the build afterwards. Change-Id: Ice45b155083b9b37281c7d28e6787a97dd4c5ea1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210981Reviewed-by:
Min Qin <qinmin@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Eric Seckler <eseckler@chromium.org> Cr-Commit-Position: refs/heads/master@{#771768}
-
