- 10 Aug, 2018 40 commits
-
-
sczs authored
Bug: 870150 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Idfed72db1f82009e002fb5ed1a6c76427eb0b697 Reviewed-on: https://chromium-review.googlesource.com/1170185Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Commit-Queue: Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#582194}
-
perfetto-chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/74182d1df594..c500e36711d5 git log 74182d1df594..c500e36711d5 --date=short --no-merges --format='%ad %ae %s' 2018-08-10 treehugger-gerrit@google.com Merge "Unify and bump kMaxCpus" 2018-08-10 treehugger-gerrit@google.com Merge "Fix Chromium build" 2018-08-10 primiano@google.com UI: several minor fixes (time and queries) 2018-08-10 primiano@google.com UI: Reduce queries and move height computation to the frontend 2018-08-10 primiano@google.com Add chrome slices track 2018-08-09 primiano@google.com Merge "perfetto-ui: Remove ui/src/panels" 2018-08-09 primiano@google.com Merge "perfetto-ui: Update deploy script to deploy test version by default" 2018-08-09 primiano@google.com Merge "perfetto-ui: Copying directories is right out" 2018-08-09 michaschwab@google.com Overview timeline vis shows load per process 2018-08-09 hjd@google.com Merge "perfetto-ui: Add permalinks" 2018-08-09 hjd@google.com Merge "TraceProcessor: expose string table" 2018-08-09 dproy@google.com [perfetto-ui] Add a fake flamegraph 2018-08-09 dproy@google.com Merge "Refactor Scrolling and Tracks using Panels" 2018-08-09 primiano@google.com Merge "perfetto-ui: Remove old CSS" 2018-08-09 hjd@google.com trace_processor: Add integration tests Created with: gclient setdep -r src/third_party/perfetto@c500e36711d5 The AutoRoll server is located here: https://perfetto-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: I79d9945012d989d5150c78e2487f08b3c065f427 Reviewed-on: https://chromium-review.googlesource.com/1169940Reviewed-by:
perfetto-chromium-autoroll <perfetto-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: perfetto-chromium-autoroll <perfetto-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#582193}
-
Peter Beverloo authored
We're not using this code in production. It's hardly tested, has an odd sequencing order and brings a lot of complication that we can remove for now. It's also the cause of a number of crashes. Bug: 850512 Change-Id: I33050f54dfbafa9192390d1ad5f3ed34cce91aca Reviewed-on: https://chromium-review.googlesource.com/1165554 Commit-Queue: Peter Beverloo <peter@chromium.org> Reviewed-by:
Rayan Kanso <rayankans@chromium.org> Reviewed-by:
Mugdha Lakhani <nator@chromium.org> Cr-Commit-Position: refs/heads/master@{#582192}
-
Becky Zhou authored
Bug: 687010 Change-Id: I304d68c8ade4e6cddb2017881b80b9300d0e512d Reviewed-on: https://chromium-review.googlesource.com/1170188Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Becky Zhou <huayinz@chromium.org> Cr-Commit-Position: refs/heads/master@{#582191}
-
John Abd-El-Malek authored
Bug: 769401 Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: Ie6dff50674507ec518d5c8043cba7e3202b6f2ff Reviewed-on: https://chromium-review.googlesource.com/1168736Reviewed-by:
Doug Turner <dougt@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#582190}
-
Peter Boström authored
This function is being removed and currently always returns true. Bug: chromium:867557 Change-Id: I6e683990e42a6ad9abb7fe5d9b8cce2f51867c37 Reviewed-on: https://chromium-review.googlesource.com/1166189Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#582189}
-
Matt Menke authored
Previously, they were initialized on first use, however, now that initialization sets up NetworkContexts when the network service is disabled, relying on the first use of the class through the ChromeURLRequestContextGetter API before setting up the NetworkContext could cause problems. Bug: 847555 Change-Id: I2aaac7e717e64fb41ba2fb9141506bb7512b73fa Reviewed-on: https://chromium-review.googlesource.com/1169319Reviewed-by:
Maks Orlovich <morlovich@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#582188}
-
Calder Kitagawa authored
Adds a Snackbar to disclose when an unbound WebAPK or TWA is running in Chrome. This is designed such that users see the disclosure under the following conditions: - The webapp is a TWA or WebAPK - If it is a WebAPK it was not installed from Chrome. Until the user presses "OK, got it" the snackbar will persist and remains during navigation. If a session is ended without pressing "OK, got it" then the message will appear the next time the app is opened or resumed. This appears once per app installation with the caveat that if a user clears their Chrome data the app will show this message again. This change is implemented to only start showing the disclosure when the storage is null. This happens only when an app is opened for the first time. As such all deployed and launched unbound WebAPKs will not see this message. To facilitate this we set a boolean flag to show the message when we launch with null storage. The reason this is necessary that the default value for a key is false so for existing unbound WebAPKs we would try to show the message regardless of state if we didn't use a set, check, clear approach. Known issues: It appears that there is a finch trial for chrome modern that isn't properly initialized if the WebAPK is launched cold (i.e. Chrome hasn't been started) and Chrome's data has been wiped. As a result, the old black snackbar is shown instead of the white one. This is remedied if the app is relaunched and won't occur if Chrome is launched before the WebAPK. Bug: 862401 Change-Id: Ieb09b7b628d5718908f8841b06b469c54ed59472 Reviewed-on: https://chromium-review.googlesource.com/1142224 Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org> Reviewed-by:
Peter Conn <peconn@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Xi Han <hanxi@chromium.org> Cr-Commit-Position: refs/heads/master@{#582187}
-
Melissa Galonsky authored
Per crbug.com/860229, removes the Android build number from the Android user agent, but creates a Finch experiment that allows the change to be re-enabled. Does not apply the change to Android Web View as mandated by the Android Compatibility Definition Document. Bug: 860229 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I57c24994958d840c80600356f12b2ce20c8a9f74 Reviewed-on: https://chromium-review.googlesource.com/1157225 Commit-Queue: Melissa Galonsky <mgalonsky@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Reviewed-by:
Nick Harper <nharper@chromium.org> Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Cr-Commit-Position: refs/heads/master@{#582186}
-
Matthew Jones authored
This patch reduces the padding above the logo on the NTP to reduce the unneeded whitespace and adds padding to the bottom so that the footer is not obscured by the bottom toolbar. Bug: 870748,869612 Change-Id: I9e003149d32d54b2652e20e1a45524724985abff Reviewed-on: https://chromium-review.googlesource.com/1169587Reviewed-by:
-
Ken Rockot authored
Changes this test to properly wait for the first synthetic click event to fire before proceeding with the rest of the test and validating its expectations. Bug: 872081 Change-Id: I0954ef7deff8415600effbc79cca7402a1b51583 Reviewed-on: https://chromium-review.googlesource.com/1170173 Commit-Queue: Ken Rockot <rockot@chromium.org> Reviewed-by:
Nicolás Peña Moreno <npm@chromium.org> Cr-Commit-Position: refs/heads/master@{#582184}
-
Sujie Zhu authored
[Autofill local card migration settings page] Add migration experimental flag api for settings page(#1). This is the start CL of triggering migration from settings page. We modify the original Boolean experimental flag to multi-state experimental flag in order to use one flag to control the normal submit form and settings page separately. The following CLs will be: 1. We will use loadTimeData to get the experimental flag in the JS code. We will use this flag to protect and isolate the new changes. 2. Add new attribute of CreditCardEntry to check the migration requirements. 3. Display the migration button to the user when requirements meet. 4. Trigger migration when user click on the button with new API call. Please refer to the design doc for more details: https://docs.google.com/document/d/1J7YyBeKZZaBhjAHnMEezvuBa5x1pk_XCh_yZvV_HMmc/edit#heading=h.1wm3blr98d8i Bug: 852904 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: I5fbf0acc32853b5d2d86cfcd24f109f04341dddd Reviewed-on: https://chromium-review.googlesource.com/1163067Reviewed-by:
Jared Saul <jsaul@google.com> Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Fabio Tirelo <ftirelo@chromium.org> Commit-Queue: Sujie Zhu <sujiezhu@google.com> Cr-Commit-Position: refs/heads/master@{#582183}
-
Ryan Daum authored
Does not discard the first tap event, but tries to issue a cancel for it instead. Had to do this because the replaying of the stashed events weren't making it through to later event rewriters in the chain (including side swipe detection, and the forthcoming fullscreen magnifier). Has the side-effect that many applications will still receive a touch press event. However touch latency also improves. Also adds tap slop detection to avoid accidental triple taps. Bug: internal b/110532452 Test: manual and unit test Change-Id: Icc9d3b558940348e98c88eb1c29697cd7d59065a Reviewed-on: https://chromium-review.googlesource.com/1170588Reviewed-by:
Alex Sakhartchouk <alexst@chromium.org> Commit-Queue: Ryan Daum <rdaum@chromium.org> Cr-Commit-Position: refs/heads/master@{#582182}
-
Michael Lippautz authored
Implement early write barrier bailout similar to incremental marking. This allows bailing out without looking up data structures in TLS or Isolate-specifics maps. Bug: chromium:843903 Change-Id: Iac5afa2ee375b5bb192ef91543f9aa9a54a70385 Reviewed-on: https://chromium-review.googlesource.com/1170834Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#582181}
-
Mirko Bonadei authored
This is a reland of 6f1c521d6e0587818817fa55981663ed7d0527ed Original change's description: > Fix gtest missing dependencies on absl. > > If GTEST_HAS_ABSL=1 gtest now also depends on: > * absl/debugging:failure_signal_handler > * absl/debugging:stacktrace > * absl/debugging:symbolize > > More info: https://cs.chromium.org/chromium/src/third_party/googletest/src/BUILD.bazel?l=106-113&rcl=82670da613af6b5a427e7cc9980ba8977afcab8a. > > Bug: None > Change-Id: If1a42dca4b97ea000eb10b178d1abc6a50a5f0e9 > Reviewed-on: https://chromium-review.googlesource.com/1169056 > Reviewed-by: Nico Weber <thakis@chromium.org> > Commit-Queue: Mirko Bonadei <mbonadei@chromium.org> Bug: None Change-Id: I9a225b9ad4d9d40b2f76b1f074234c190f4681c3 Reviewed-on: https://chromium-review.googlesource.com/1170602 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#582180}
-
Valeriya Sinevich authored
This will be used later inside GaiaCookieManagerService::SetAccountsInCookies(). Change-Id: I210fb940ce397c608e66bbc8067ff5e75164513b Reviewed-on: https://chromium-review.googlesource.com/1169176Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: Valeriya Sinevich <valeriyas@google.com> Cr-Commit-Position: refs/heads/master@{#582179}
-
Ramya Nagarajan authored
This is a reland of 94558b66 Original change's description: > [NTP] Adds an experiment for M69 NTP features. > > Only the first experiment entry gets covered by perf waterfall, so adding > this item ensures better test coverage. Also, the existing experiment, > NewTabPageAllBirthday_Enabled, could not be re-used since > go/revising-finch-configs recommends creating a new experiment when > changing size or behavior of existing groups. > > Bug: 831910 > Change-Id: I95ebc6f2768fe25d34993c05c71e35c22e2bdcc5 > Reviewed-on: https://chromium-review.googlesource.com/1160925 > Reviewed-by: Steven Holte <holte@chromium.org> > Commit-Queue: Ramya Nagarajan <ramyan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#580314} Bug: 831910 Change-Id: Ie8788f8ee24a146f9854fb9b4abb35cfb55664a2 Reviewed-on: https://chromium-review.googlesource.com/1167562Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Ramya Nagarajan <ramyan@chromium.org> Cr-Commit-Position: refs/heads/master@{#582178}
-
Matthew Cary authored
Uses the new WritableUnalignedMapping class, which changes the ownership semantics. See the bug for details on the overall plan. This is a reland of crrev.com/c/1117696, now that mojo is initialized for the unittests is fixed, and also removes a double-close for the shared memory handles. Bug: 849207 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Ib065caedfed8a33fd0f112ce22a72bda4b9bf99e Reviewed-on: https://chromium-review.googlesource.com/1158567Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Commit-Queue: Matthew Cary <mattcary@chromium.org> Cr-Commit-Position: refs/heads/master@{#582177}
-
Maks Orlovich authored
... Rather than relying on them to be sufficiently close to each other that there isn't much event loop activity. This is needed for upcoming port of GaiaOauthClient to Network Service (and hence mojo), which requires tests to spin the event loop in a lot more places than before to deliver fetch results, making it hard to ensure that HandleOnAccessTokenRequested and WaitForAccessTokenRequestIfNecessary get delivered in right order. Bug: 865018 Change-Id: I7acf6427be7be5b00c8e003dd687169c4b8a7577 Reviewed-on: https://chromium-review.googlesource.com/1167904Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Commit-Queue: Maks Orlovich <morlovich@chromium.org> Cr-Commit-Position: refs/heads/master@{#582176}
-
Sahel Sharify authored
Bug: 865755 Change-Id: Ic24c1405392ba42810f516f375a3d304a81a88ed Reviewed-on: https://chromium-review.googlesource.com/1169779 Commit-Queue: Sahel Sharify <sahel@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#582175}
-
Clark DuVall authored
Previously, subresource requests could not redirect to schemes other than http/https/data with the network service. Now they can redirect to all schemes, and have proper safety checks. This gets rid of the RedirectChecker class and instead just checks the redirect in WebRequestProxyingURLLoaderFactory if the request is being proxied. The checks farther downstream will be skipped if the request is proxied. This should be simpler, and avoids complicated logic with the RedirectChecker that would have been necessary for subresource redirects. The bypass_redirect_checks bit is set if the request is being proxied by WebRequestProxyingURLLoaderFactory. In that case, all redirect checks will happen in WebRequestProxyingURLLoaderFactory, because the webRequest API has special permissions for allowing redirects. For subresource requests, the bypass_redirect_checks bit is set on the URLLoaderFactoryBundleInfo that is sent to the renderer from RenderFrameHostImpl. This is used in ResourceDispatcher to ignore redirect checks if necessary. Bug: 868545 Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: Ib11bf81e5b4b1ec9fa1b8d9178467322df91b30c Reviewed-on: https://chromium-review.googlesource.com/1157549Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#582174}
-
webrtc-chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/5f0ce99c04eb..c97933fb82f8 git log 5f0ce99c04eb..c97933fb82f8 --date=short --no-merges --format='%ad %ae %s' 2018-08-10 minyue@webrtc.org Clean up code regarding jitter buffer plot in event log visualizer. 2018-08-10 buildbot@webrtc.org Roll chromium_revision 86f8273e..f7e49bb7 (581886:582110) 2018-08-10 ivoc@webrtc.org Add command-line flag to enable the bugfix to postpone decoding after expand. 2018-08-10 terelius@webrtc.org Print timestamp-to-UTC map when event_log starts. 2018-08-10 nisse@webrtc.org Delete unused method RtpReceiver::CSRCs. 2018-08-10 mbonadei@webrtc.org Change visibility of some build targets that are publicly used. 2018-08-10 buildbot@webrtc.org Roll chromium_revision b0784bef..86f8273e (581665:581886) 2018-08-10 nisse@webrtc.org Reland "Refactor RtpVideoStreamReceiver without RtpReceiver." 2018-08-09 peah@webrtc.org AEC3: Ensure that the shadow filter is adapted at each block 2018-08-09 sprang@webrtc.org Experimental improvements for simulcast screenshare 2018-08-09 alessiob@webrtc.org APM: render pre-processor moved before echo detector queuing. 2018-08-09 sakal@webrtc.org Add extended header containing frame ID to the generic packetizer. 2018-08-09 aleloi@webrtc.org Optionally disable digital gain control in ExperimentalAgc. 2018-08-09 magjed@webrtc.org Android: Allow YuvConverter to be reused 2018-08-09 oprypin@webrtc.org cq_name is no longer used and can and should be removed 2018-08-09 phoglund@webrtc.org Roll chromium_revision 474eca05..b0784bef (581204:581665) 2018-08-09 oprypin@webrtc.org Add compile-only bots (used for binary size) to commit queue 2018-08-09 oprypin@webrtc.org Add post-submit builders without dcheck_always_on 2018-08-09 philipel@webrtc.org Remove RTPVideoHeader::vp9() accessors. 2018-08-09 danilchap@webrtc.org Remove raw extensions accessors from rtp packet 2018-08-09 sprang@webrtc.org SimulcastEncoderAdapter should not update maxQp for screencast 2018-08-09 titovartem@webrtc.org Remove old base64 header 2018-08-09 nisse@webrtc.org Add test CallPerfTest.PlaysOutAudioAndVideoInSyncWithoutClockDrift 2018-08-09 nisse@webrtc.org Delete unused constants from rtp_rtcp_config.h 2018-08-09 mbonadei@webrtc.org Making rtc_base:ptr_util and rtc_base:refcount public. Created with: gclient setdep -r src/third_party/webrtc@c97933fb82f8 The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng BUG=chromium:None,chromium:None,chromium:None,chromium:None,chromium:872201,chromium:b/112386285,chromium:None,chromium:None,chromium:none,chromium:None,chromium:None,chromium:None,chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Ie0f047103689803c7eadfe059b10886153d22c2c Reviewed-on: https://chromium-review.googlesource.com/1169939Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#582173}
-
Jeremy Roman authored
Lack of this caused us to use a non-lazy attribute, which is much slower. Notably access to the "WebGLRenderingContext" global in Window regressed when it was conditionally exposed on Worker (for OffscreenCanvas). To avoid further code duplication, this CL moves this behavior into a bit on V8DOMConfiguration::AttributeConfiguration, and makes the bindings generator use that for attributes both lazy and not. Bug: 870959 Change-Id: If8d68ef452b384479202d79be9defe2ecac72993 Reviewed-on: https://chromium-review.googlesource.com/1167955Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
-
Sky Malice authored
Relanding after initial patch skipped CQ by accident https://chromium-review.googlesource.com/c/chromium/src/+/1169536 https://chromium-review.googlesource.com/c/chromium/src/+/1169786 Specifics: +585,064 bytes normalized apk size +3 zip entries file count +33,268 bytes main lib size +375,392 bytes main dex size InstallSize: +209,672 bytes APK size +1,726,255.68 bytes Estimated installed size InstallBreakdown (+1,726,927.68 bytes): +1,553 bytes Non-compiled Android resources size +33,268 bytes Native code size +181 bytes Package metadata size +1,677,401.68 bytes Java code size +14,524 bytes Compiled Android resources size Dex: +1,866 entries fields +2,565 entries methods +605 entries types +1,268 entries strings TBR=fgorski@chromiun.org Change-Id: Ie837ccdafdd545e765c43e5549e238504bfb7830 Reviewed-on: https://chromium-review.googlesource.com/1170225Reviewed-by:
Sky Malice <skym@chromium.org> Commit-Queue: Sky Malice <skym@chromium.org> Cr-Commit-Position: refs/heads/master@{#582171}
-
Ned Nguyen authored
TBR=ksakamoto@chromium.org NOTRY=true Bug: 676612 Change-Id: Ia70720a2d00c4c7560736db33d8bbe7b418a87e5 Reviewed-on: https://chromium-review.googlesource.com/1170593Reviewed-by:
Ned Nguyen <nednguyen@google.com> Commit-Queue: Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#582170}
-
Zach Helfinstein authored
Bug: 873016 Change-Id: If8ee78b9e739aaad0403964948534c3305b26580 Reviewed-on: https://chromium-review.googlesource.com/1170383Reviewed-by:
David Tseng <dtseng@chromium.org> Commit-Queue: Zach Helfinstein <zhelfins@chromium.org> Cr-Commit-Position: refs/heads/master@{#582169}
-
Vadym Doroshenko authored
There are 2 problems with function PasswordFormManager::UpdatePendingAndGetOldKey 1.It has pretty complicated and confusing logic in updating password_element, username_element and submit_element. Now these variables have no meaning for filling or saving. So it doesn't make sense to update password store records because of them (moreover username and password elements are part of the key). So this code may be removed. 2.This function is doing 2 independent actions, update *elements and finds which other elements needed to be updated. Now the time to throw away garbage, since this code will be copied to NewPasswordFormManager. This CL removes item 1 and because of 2, the function is renamed to FindOtherCredentialsToUpdate. Bug: 831123 Change-Id: Ided9f7fe3156fc5c7384cc4278d7d61b416a77a6 Reviewed-on: https://chromium-review.googlesource.com/1169164 Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#582168}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/5b5d84cc1f37..93ce79dba4d9 git log 5b5d84cc1f37..93ce79dba4d9 --date=short --no-merges --format='%ad %ae %s' 2018-08-10 mtklein@google.com drop SkTextBlob alignas(void*), align in Builder manually Created with: gclient setdep -r src/third_party/skia@93ce79dba4d9 The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=djsollen@chromium.org Change-Id: I22642fc86fb27a559620d0ff6cf5dd47ce4ee5b3 Reviewed-on: https://chromium-review.googlesource.com/1169941Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#582167}
-
Bence Béky authored
Use CompletionOnceCallback instead of CompletionCallback, and CancelableCompletionOnceCallback instead of CancelableCompletionCallback in //content/browser/appcache. I originally landed this CL at https://crrev.com/c/1163933. However, that was during Gerrit outage. The "submit to CQ" button had been replaced by a "submit" button. After I realized that I have inadvertently skipped the CQ, I manually reverted the change at https://crrev.com/c/1169442 and submitted that, again, skipping the CQ. As part of the remediation of the Gerrit outage, all the above CLs have been erased from git history. But before that, they were reverted in reverse order to trigger e-mails to CL authors: https://crrev.com/c/1169442 (revert of original CL) got reverted (original CL relanded) at https://crrev.com/c/1169867; then https://crrev.com/c/1163933 (original CL) got reverted at https://crrev.com/c/1169867. Before that, still during the outage, I uploaded https://crrev.com/c/1169307 and enqueued it to the CQ. This landed after the tree was re-opened. Then it was thought that https://crrev.com/c/1169867, the revert, originally happened because there was a problem with the original CL, so they reverted its revert, https://crrev.com/c/1169867, which was a reland, at https://crrev.com/c/1169929. Now that the dust settled, the original CL is ready to be relanded again. Here is goes. TBR=kinuko@chromium.org Bug: 807724 Change-Id: Ie128adba22500c590cb04c5f5a6deed0e4b9cf6b Reviewed-on: https://chromium-review.googlesource.com/1170583Reviewed-by:
Bence Béky <bnc@chromium.org> Commit-Queue: Bence Béky <bnc@chromium.org> Cr-Commit-Position: refs/heads/master@{#582166}
-
Elodie Banel authored
After https://chromium-review.googlesource.com/c/chromium/src/+/1140674 the GetSecureVerboseText function doesn't return text anymore. This function is used for visual display. In order to continue getting data for accessibility purposes, duplicate the function with modifications to continue returning relevant info. Additionally, fix iOS omnibox accessibility to 1) use this new function and 2) update a11y when label (generally site url) changes even if security state does not. Bug: 869398 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ibf60a354d5f81b9a5d52aaec10d3ef5277be93bd Reviewed-on: https://chromium-review.googlesource.com/1161913 Commit-Queue: Elodie Banel <lod@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#582165}
-
Charlie Andrews authored
TBR=nednguyen@chromium.org Bug: 859514 Change-Id: I5aa3aa1ca04eb69ddf3d9d28713df353f4f68b10 Reviewed-on: https://chromium-review.googlesource.com/1169440 Commit-Queue: Charlie Andrews <charliea@chromium.org> Reviewed-by:
Charlie Andrews <charliea@chromium.org> Cr-Commit-Position: refs/heads/master@{#582164}
-
Matthew Cary authored
Bug: 869997 Change-Id: I867cb67d5fc3e4e4a7b3343053c6f38123c3e776 Reviewed-on: https://chromium-review.googlesource.com/1162154Reviewed-by:
Benoit L <lizeb@chromium.org> Commit-Queue: Matthew Cary <mattcary@chromium.org> Cr-Commit-Position: refs/heads/master@{#582163}
-
Elad Alon authored
This is a reland of 7dae0f63 The original CL caused flakiness because, in production code, WebRtcEventLogManager is torn down during Chrome shutdown, after all threads other the the UI thread have quit. For unit tests, this was not the case, and so the tests hit some use-after-destruction. This was fixed by making the tests stop the non-UI threads before tearing down WebRtcEventLogManager. Original change's description: > Support dynamic refresh of WebRtcEventLogCollectionAllowed policy > > Add suport for dynamic refresh of WebRtcEventLogCollectionAllowed: > 1. If the policy was disabled before, and becomes enabled, > subsequent calls to StartRemoteLogging() will succeed (barring > unrelated issues), even for peer connections created while the > policy was disabled. > 2. If the policy was enabled before, and becomes disabled: > a. Peer connections associated with the profile reject > calls to StartRemoteLogging(). > b. Active logs (associated with the profile) are stopped, > and those log files deleted. > c. Pending log files (associated with the profile) are deleted. > d. If a log file associated with the relevant profile is > currently being uploaded, the upload will be cancelled, > and the file deleted. > > Bug: 775415 > Change-Id: I70a02ff04eded2926e56fa8e368715ec1ff7c34f > Reviewed-on: https://chromium-review.googlesource.com/1162168 > Reviewed-by: Guido Urdaneta <guidou@chromium.org> > Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org> > Reviewed-by: Avi Drissman <avi@chromium.org> > Commit-Queue: Elad Alon <eladalon@chromium.org> > Cr-Commit-Position: refs/heads/master@{#581167} TBR=guidou@chromium.org Bug: 775415 Change-Id: Ie6070a8843012580c9a6c069f65c01b8d63525ff Reviewed-on: https://chromium-review.googlesource.com/1168962 Commit-Queue: Elad Alon <eladalon@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Cr-Commit-Position: refs/heads/master@{#582162}
-
jonross authored
Originally reviewed: https://chromium-review.googlesource.com/c/chromium/src/+/1168546 Reverted due to the great Gerrit tree closure of 2018: https://chromium-review.googlesource.com/c/chromium/src/+/1169793 TBR=thakis@chromium.org Update Linux Viz telemetry timeouts We occassionally see telemetry_unittests_viz and telemetry_perf_unittests_viz timeout on the FYI Linux Viz bot. The logs point to no specific test taking longer than on a normal run. Nor of any test hanging. The bot also reports 22/22 done on the shard, and browser teardown, but never compiles the final success tally. We would like to speculatively increase the timeouts here to see if that stabilizes the bot. TEST=telemetry_unittests_viz and telemetry_perf_unittests_viz Bug: 871751 Change-Id: I4a3da0e45e5006673a5a3967e9e33d602d38794e Reviewed-on: https://chromium-review.googlesource.com/1168546Reviewed-by:
Jonathan Ross <jonross@chromium.org> Commit-Queue: Jonathan Ross <jonross@chromium.org> Cr-Commit-Position: refs/heads/master@{#582161}
-
Kuo-Hsin Yang authored
Add tools/perf/contrib/cros_benchmarks/data/*.fetchts to .gitignore as well Change-Id: Iac45358363d3c5e9f7399a035f7ab315006175c0 Reviewed-on: https://chromium-review.googlesource.com/1170159 Commit-Queue: Vovo Yang <vovoy@chromium.org> Reviewed-by:
Cheng-Yu Lee <cylee@chromium.org> Cr-Commit-Position: refs/heads/master@{#582160}
-
Mustafa Çamurcu authored
UI::KeyEvent character event constructor defaulted to have DomCode as NONE which resulted in an empty DOM code. This cl makes DomCode an argument in the constructor and populates the DomCode when known. Bug: 870337 Change-Id: I8c87bb5ba451238dfe06f88d52c6f28912d61c46 Reviewed-on: https://chromium-review.googlesource.com/1162427Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
-
Roger McFarlane authored
This CL changes the uploaded autofilltype (i.e. vote) field to be repeating instead of a single required field per uploaded field. Background: The autofill upload proto has a repeated "Field" attribute that has a single required autofilltype field. Autofill can send multiple votes for a given field (if a field matches the users full address as well as address line 1, for example). Prior to this CL, clients would send multiple "Field" entries (repeating all attached metadata) in the event of multiple votes. Clients also send multiple "Field" entries if there are fields having the same signature (address line 1,2, sharing the same field name/id, for example, is not uncommon). The recipient of these votes is not able to tell these 2 cases apart (multiple votes for a single field vs votes for multiple fields with the same signature). With this CL, clients will upload exactly one "Field" entry per logical field in the form. In this way all type votes for a field will be consolsidated to a single Field entry. It will also consolidate (instead of repeating) any additional metadata send about the field into that single entry for the field. Bug: 850606 Change-Id: I73acea17f755b6ebe37f11c9e72e02f9bf1c5484 Reviewed-on: https://chromium-review.googlesource.com/1142485 Commit-Queue: Roger McFarlane <rogerm@chromium.org> Reviewed-by:
-
Fabio Tirelo authored
This reuses the idea applied to the Save Card bubble to override the title view with a custom view containing the Google Pay logo, the separator, and the label. To make it more reusable, this CL introduces a new views::View subclass to represent that title container. In the new dialog, it's common to get multiline titles, which was not properly handled by the custom implementation we had before. This CL fixes the issue by using a GridLayout. We also needed to replace DialogDelegateView with BubbleDialogDelegateView as a base class of CardUnmaskPromptViews, because the former doesn't expose the BubbleFrameView, needed to override the title view. Screenshots in the bug (see comment #1). Bug: 870451 Change-Id: I3cf33ff0fff4c34657d1febd1fd2eaf422ed4ccc Reviewed-on: https://chromium-review.googlesource.com/1170131 Commit-Queue: Fabio Tirelo <ftirelo@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Reviewed-by:
Mathieu Perreault <mathp@chromium.org> Cr-Commit-Position: refs/heads/master@{#582157}
-
Roger McFarlane authored
This CL updates the AutofillSmallFormSupport fieldtrial config to match the feature permutation planned to go the beta/stable for password manager small form support. Bug: 824834 Change-Id: Ic58ac339f5dc8004c0e6a3b7f7eedc6207db2736 Reviewed-on: https://chromium-review.googlesource.com/1169975Reviewed-by:
Robert Kaplow (slow) <rkaplow@chromium.org> Commit-Queue: Roger McFarlane <rogerm@chromium.org> Cr-Commit-Position: refs/heads/master@{#582156}
-
Sébastien Séguin-Gagnon authored
Bug: 869526 Change-Id: Iacf585f600d12461dbd62171f0936e50f78d6057 Reviewed-on: https://chromium-review.googlesource.com/1170097 Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org> Reviewed-by:
Jan Krcal <jkrcal@chromium.org> Cr-Commit-Position: refs/heads/master@{#582155}
-
