- 26 Feb, 2019 40 commits
-
-
Maksim Ivanov authored
Add pre-defined native messaging destination that allows whitelisted extensions to send messages to the diagnostics_processor daemon (via the diagnosticsd daemon) and receive the responses back. The extension should use either chrome.runtime.sendNativeMessage or chrome.runtime.connectNative with the 'com.google.wilco_dtc' application in order to use this message pipe. The hardcoded whitelist for accessing this message pipe is currently empty - it will have to be updated once we figure out extension IDs that we'll use. BUG=chromium:907932,b:123926112 TEST=manual Change-Id: I9083dd87346b490cb43ca8aabd2f7534245215e2 Reviewed-on: https://chromium-review.googlesource.com/c/1463442Reviewed-by:
Mattias Nissler <mnissler@chromium.org> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Polina Bondarenko <pbond@chromium.org> Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#635494}
-
Kush Sinha authored
Chrome OS Account Manager's clients relied on |AccountTrackerService| to map |AccountManager::AccountKey| to other representations (namely raw email and canonical email). Due to the relation between one such client, |ChromeOSOAuth2TokenServiceDelegate|, and |AccountTrackerService|, it was required that |AccountTrackerService| should be able to store account mappings for which a refresh token was not yet known. This usage model is no longer supported. See the attached bug for context. Fix this by adding a |raw_email| field in Chrome OS Account Manager's Account proto definition. Future patches will change clients to read this value. Bug: 925827 Test: chromeos_unittests --gtest_filter="*AccountManager*Test*" Test: unit_tests --gtest_filter="*CrOSOAuthDelegateTest*" Test: browser_tests --gtest_filter="*Arc*AuthService*Test*" Change-Id: I76ef741ec0a9ea38ae8757ff234c8be6dd7a3155 Reviewed-on: https://chromium-review.googlesource.com/c/1452003Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
Lutz Justen <ljusten@chromium.org> Commit-Queue: Kush Sinha <sinhak@chromium.org> Cr-Commit-Position: refs/heads/master@{#635493}
-
Henrique Ferreiro authored
identity_get_auth_token_function.cc uses a mix of C++ and Mojo code. This CL ports GetAccessToken() to C++. Bug: 913853 Change-Id: I71ffbc6944dff0a886d57a4d8b10cb0fa334390b Reviewed-on: https://chromium-review.googlesource.com/c/1458300 Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#635492}
-
Gyuyoung Kim authored
The OnionSoup effort has a goal of allocating all garbage-collectible Blink objects with Oilpan or PartitionAlloc. However, some classes of //blink/renderer/modules/webaudio have not yet been allocated with them so far. So their uses of non-garbage-collected objects should be restricted to cases where the garbage collector can discover their references. The macros of Allocator will be useful for the non-garbage-collected objects to avoid unintended allocations. After some analyzes, it was concluded that for the case of ProcessorCreationParams and SharedAudioBuffer classes, they make sense to use USING_FAST_MALLOC because they have been used as member variables with smart pointers. Bug: 919389 Change-Id: I415dc3360abcadff5d2b3ce25035d09d674c2720 Reviewed-on: https://chromium-review.googlesource.com/c/1488399Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Cr-Commit-Position: refs/heads/master@{#635491}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/3812fa949a49..e2da93130748 git log 3812fa949a49..e2da93130748 --date=short --no-merges --format='%ad %ae %s' 2019-02-26 kwiberg@webrtc.org Remove a leftover audio codec poison immutinty declaration 2019-02-26 asapersson@webrtc.org Add option to inject YuvConverter to SurfaceTextureHelper. 2019-02-26 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision a55c7bb9..15651144 (635189:635345) 2019-02-26 kwiberg@webrtc.org Ban absl::StrSplit and absl::StrJoin 2019-02-25 thakis@chromium.org Fix -Wextra-semi warnings in webrtc fuzzers. 2019-02-25 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 81fda909..a55c7bb9 (635067:635189) 2019-02-25 amithi@webrtc.org Wiring up RIDs from the video engine to the RTP Sender. 2019-02-25 shampson@webrtc.org Fixing webrtc::IceTransportState. 2019-02-25 sakal@webrtc.org Revert "Remove VCMEncoderDataBase and put remaining code into VideoStreamEncoder" 2019-02-25 eladalon@webrtc.org Connect LossNotificationController to RtpRtcp 2019-02-25 srte@webrtc.org Avoids PostTask to repost a repeated task. 2019-02-25 mbonadei@webrtc.org Adding possibility to save an RTCEventLog of the call. 2019-02-25 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 95a23eca..81fda909 (634895:635067) 2019-02-25 srte@webrtc.org Reland "Adds resource path support for video files in scenario tests." 2019-02-25 sprang@webrtc.org Remove VCMEncoderDataBase and put remaining code into VideoStreamEncoder 2019-02-25 srte@webrtc.org Adds CoDel implementation to network simulation. 2019-02-25 srte@webrtc.org Stop using special RTT value for DelayBasedBwe. 2019-02-25 kuddai@google.com Delay bug during audio receiver stream recreation. 2019-02-25 mbonadei@webrtc.org Fix -Wextra-semi warnings. Created with: gclient setdep -r src/third_party/webrtc@e2da93130748 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng BUG=chromium:none,chromium:None,chromium:none,chromium:935572,chromium:None,chromium:933802,chromium:None,chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Ie0a2dcd1ba6947c1ca8f49070855c2b9f8c45530 Reviewed-on: https://chromium-review.googlesource.com/c/1488504Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#635490}
-
Nick Diego Yamane authored
This CL is intended to make the Wayland data device initialization more robust, removing the assumption that data device manager global object is advertised before the wl_seat. Additionally this patch does a minor code cleanup in WaylandDataDeviceManager, removing the WaylandConnection setter, injecting connection instance via its constructor instead, as it is already being done in other classes, such as WaylandDataSource, for example. Bug: 578890 Change-Id: Ia700c164f18b2778b08047bfcb5ccf382e69328f Reviewed-on: https://chromium-review.googlesource.com/c/1487853Reviewed-by:
Maksim Sisov <msisov@igalia.com> Reviewed-by:
Antonio Gomes <tonikitoo@igalia.com> Commit-Queue: Nick Diego Yamane <nickdiego@igalia.com> Cr-Commit-Position: refs/heads/master@{#635489}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/565a6950b6fe..7fb544c58018 Created with: gclient setdep -r src-internal@7fb544c58018 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I41aa1b6383e5b7472b80f1c51b45f0b6d22a2c10 Reviewed-on: https://chromium-review.googlesource.com/c/1488413Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#635488}
-
Yi Su authored
The limitation of displaying at most 2 rows of MostVisistedCells in NTP ContentSuggestionsCollectionView should be removed to support Dynamic Type. Bug: 893523 Change-Id: Ie22bc59b9149e154053bbf05e63e68ba0b850e99 Reviewed-on: https://chromium-review.googlesource.com/c/1482978 Auto-Submit: Yi Su <mrsuyi@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#635487}
-
Colin Blundell authored
In identity_apitest.cc, there is a test that verifies that when the primary account is cleared, the chrome.identity.onSignInChanged event is fired. This event is fired when a refresh token is added/removed for a given account. However, when DICE is enabled, clearing the primary account does not result in its refresh token being removed (and hence does not cause this event to fire). This CL updates this test to short-circuit out if DICE is enabled. Note that a different existing test already verifies that an event is fired when the refresh token of the primary account is removed. This CL is concretely necessary to unblock the elimination of FakeSigninManager. When FakeSigninManager is eliminated, this test (and others) will use a SigninManager instance that has been configured with the account consistency mode passed by SigninManagerFactory, rather than the account consistency mode being hardcoded to disabled. Once the test is using SigninManager, we will update it to check that the event is *not* fired if DICE is enabled. It's not yet possible to do that as the test is still using FakeSigninManager. Bug: 796544 Change-Id: I8ec51b1c960ea068cb984c1781e2cc84c72ce0e4 Reviewed-on: https://chromium-review.googlesource.com/c/1488876Reviewed-by:
-
Colin Blundell authored
The SyncConfirmationHandler unittest inherits from BrowserWithTestWindowTest. It currently overrides the latter's CreateProfile() method to create and own a Profile instance via IdentityTestEnvironmentProfileAdaptor. However, this blocks the upcoming elimination of FakeSigninManager, via a subtle circular dependency that gets introduced: - SigninManagerFactory supplies |g_browser_process->local_state()| to SigninManager's Initialize() method. - In the testing context, the object thus supplied is actually owned by BrowserWithTestWindowTest's TestingProfileManager object. - Hence, the Profile of the question must be torn down before the TestingProfileManager to avoid a crash that otherwise occurs in SigninManager::Shutdown() when it accesses the PrefService pointer that it has cached. - However, it is not possible to move the teardown of the SyncConfirmationHandler unittest's |profile_| instance to be before the call to BrowserWithTestWindowTest::TearDown(), as that in turn causes a crash because other objects that BrowserWithTestWindowTest owns (namely, |browser_|) must be torn down *before* the Profile. This CL fixes the problem by simply eliminating SyncConfirmationHandler owning its own Profile instance. Instead, it just supplies the factories that IdentityTestEnvironmentProfileAdaptor requires directly to BrowserWithTestWindowTest via an override of GetTestingFactories(). This allows the natural teardown order in BrowserWithTestWindowTest::TearDown() to be preserved. Bug: 796544 Change-Id: I06528d564d836d83e1ac87a6cfc94c9ca12a033c Reviewed-on: https://chromium-review.googlesource.com/c/1488872Reviewed-by:
-
Mario Sanchez Prada authored
Migrate usage of base::Bind with repeating callbacks to base::BindRepeating. Bug: 755477 Change-Id: I8f68fde9a400e5216b2abe9efbb6ef8e2238b22d Reviewed-on: https://chromium-review.googlesource.com/c/1485931Reviewed-by:
Tsuyoshi Horo <horo@chromium.org> Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Cr-Commit-Position: refs/heads/master@{#635484}
-
Gauthier Ambard authored
Moves the tools menu button closer to the center of the toolbar to have the same spacing between the border of the screen and the first/last button. Bug: 912965 Change-Id: I2d4c9860c4eb9ffd9a821a90384b8d588a3bbe89 Reviewed-on: https://chromium-review.googlesource.com/c/1481314 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#635483}
-
Miyoung Shin authored
- unsigned short -> uint8_t / uint16_t. - Reference: https://google.github.io/styleguide/cppguide.html#Integer_Types Bug: 929986 Change-Id: I84145b2996032f6b9e0e80d30ff63776628ef7c7 Reviewed-on: https://chromium-review.googlesource.com/c/1485617 Commit-Queue: Miyoung Shin <myid.shin@chromium.org> Reviewed-by:
-
jdoerrie authored
This change moves the library features std::reference_wrapper, std::ref and std::cref from the to be discussed section to the allowed section, adds further documentation and links to the cxx@ discussion thread. Furthermore, it removes base::internal::ConstRefWrapper and modifies base::ConstRef to construct std::reference_wrappers instead. As a follow up to this change all usages of base::ConstRef should be replaced by std::cref, and base::ConstRef should be removed as well. Bug: 934808 Change-Id: Ie09884c38049a0f69bb3cb6442907c699e29da2e Reviewed-on: https://chromium-review.googlesource.com/c/1482958 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#635481}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/de280d758ae2..565a6950b6fe Created with: gclient setdep -r src-internal@565a6950b6fe The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: If5d7b720f26a76af1e5352bb6e76ed101025e28f Reviewed-on: https://chromium-review.googlesource.com/c/1488505Reviewed-by:
-
Kush Sinha authored
This reverts commit 39ced93a. This is a speculative revert to check the status of MSAN flakiness. TBR=khmel@chromium.org Bug: 934796 Change-Id: I3e6f3f4e211d802bb1968ff7cfd39526a0361b68 Reviewed-on: https://chromium-review.googlesource.com/c/1487032Reviewed-by:
Christos Froussios <cfroussios@chromium.org> Commit-Queue: Kush Sinha <sinhak@chromium.org> Cr-Commit-Position: refs/heads/master@{#635479}
-
Miyoung Shin authored
- unsigned short/unsigned -> uint16_t. - No logic changes. - Reference: https://google.github.io/styleguide/cppguide.html#Integer_Types Bug: 929986 Change-Id: I3de2acf4bae0290e636c284b91f100a1c2b4c955 Reviewed-on: https://chromium-review.googlesource.com/c/1488473Reviewed-by:
-
Sylvain Defresne authored
FindExtendedAccountInfoForAccount returns the extended information for an account using the CoreAccountInfo as a key. This will be used in preparation to converting GetPrimaryAccountInfo to return a CoreAccountInfo. Bug: 930126 Change-Id: Iabd3058cb4f5851dc753a45527c67135eb304a55 Reviewed-on: https://chromium-review.googlesource.com/c/1481332 Commit-Queue: David Roger <droger@chromium.org> Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
-
Henrique Ferreiro authored
identity_get_auth_token_function.cc uses a mix of C++ and Mojo code. This CL ports GetPrimaryAccountWhenAvailable() to C++. Bug: 913853 Change-Id: I86c669bdc2fd0adb73cb3302c62e8355f6a21325 Reviewed-on: https://chromium-review.googlesource.com/c/1458202 Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com> Reviewed-by:
-
Gauthier Ambard authored
This reverts commit ca06f630. Reason for revert: Breaking compilation on WebView Original change's description: > [iOS][web] Add logic to BrowsingDataRemover > > This CL adds the logic to clear the browsing data from the web > implementation of the BrowsingDataRemover. > > Bug: 619783 > Change-Id: Ia4771a61a8482adf296816eed54dafb5498de932 > Reviewed-on: https://chromium-review.googlesource.com/c/1477831 > Commit-Queue: Gauthier Ambard <gambard@chromium.org> > Reviewed-by: Eugene But <eugenebut@chromium.org> > Reviewed-by: Mohammad Refaat <mrefaat@chromium.org> > Cr-Commit-Position: refs/heads/master@{#635470} TBR=eugenebut@chromium.org,mrefaat@chromium.org,gambard@chromium.org Change-Id: I5539d07f8735a64465443d19c58de6456e03da71 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 619783 Reviewed-on: https://chromium-review.googlesource.com/c/1488919Reviewed-by:
-
Miyoung Shin authored
- unsigned short/int -> uint16_t. - No logic changes. - Reference: https://google.github.io/styleguide/cppguide.html#Integer_Types Bug: 929986 Change-Id: I82c389e5865267daef3bbf25c5098aa584e17c76 Reviewed-on: https://chromium-review.googlesource.com/c/1488481Reviewed-by:
-
Colin Blundell authored
This CL removes the last functionality that FakeSigninManager adds on to SigninManager: overriding OnSignoutDecisionReached(). Presumably at one time this corresponded to some simplification of the production code. However, at this time the only difference that the override adds is that it doesn't log metrics. Logging metrics in a test context is not problematic, as testing will not emit live metrics (confirmed with rkaplow@ from the metrics team). Bug: 796544 Change-Id: Ic703c0e01637d6adbc3a495cb58d715ec33d8e4c Reviewed-on: https://chromium-review.googlesource.com/c/1486532 Commit-Queue: Colin Blundell <blundell@chromium.org> Reviewed-by:
-
Jérôme Lebel authored
Don't show encryption error when sync is disabled. Bug: 914059 Change-Id: I719bf76ea87d670c8deda34532ed185a4d4d4685 Reviewed-on: https://chromium-review.googlesource.com/c/1487814Reviewed-by:
-
Alex Ilin authored
SharedPersistentMemoryAllocator is based on obsolete shared memory classes and is being replaced by {Writable,ReadOnly}SharedMemoryAllocator. SharedPersistentMemoryAllocator is still used in base/debug/activity_tracker.h and base/debug/activity_analyzer.h. This CL converts these last clients of the SharedPersistentMemoryAllocator to the new allocators and removes SharedPersistentMemoryAllocator. Bug: 920183 Change-Id: Ic789dc79a5798135a43bd59bbaaa4d2977c96cbf Reviewed-on: https://chromium-review.googlesource.com/c/1481297Reviewed-by:Brian White <bcwhite@chromium.org> Commit-Queue: Alex Ilin <alexilin@chromium.org> Cr-Commit-Position: refs/heads/master@{#635471}
-
Gauthier Ambard authored
This CL adds the logic to clear the browsing data from the web implementation of the BrowsingDataRemover. Bug: 619783 Change-Id: Ia4771a61a8482adf296816eed54dafb5498de932 Reviewed-on: https://chromium-review.googlesource.com/c/1477831 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Mohammad Refaat <mrefaat@chromium.org> Cr-Commit-Position: refs/heads/master@{#635470}
-
Nate Fischer authored
No change to docs information, this just utilizes Gitiles' feature for adding a site logo (https://github.com/google/gitiles/blob/master/Documentation/markdown.md#site-logo). This uploads a 45px tall Android System WebView logo (borrowed from internal CL http://cl/235462348, for consistency). Bug: 918221 Test: Upload to gerrit > open file > click "gitiles" Change-Id: I66dc613f0e1f681dc09b0a8c9d861ecdd5b0e904 Reviewed-on: https://chromium-review.googlesource.com/c/1488065 Auto-Submit: Nate Fischer <ntfschr@chromium.org> Commit-Queue: Tobias Sargeant <tobiasjs@chromium.org> Reviewed-by:
Tobias Sargeant <tobiasjs@chromium.org> Cr-Commit-Position: refs/heads/master@{#635469}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/7180cebfd347..83af02a24a8e git log 7180cebfd347..83af02a24a8e --date=short --no-merges --format='%ad %ae %s' 2019-02-26 perezju@chromium.org [Telemetry] Remove clear_sytem_cache_for_browser_and_profile_on_start Created with: gclient setdep -r src/third_party/catapult@83af02a24a8e The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:811244,chromium:902268 TBR=sullivan@chromium.org Change-Id: Id4787cb2f03cfd5630a5f08d2c358cf20aba4720 Reviewed-on: https://chromium-review.googlesource.com/c/1488502Reviewed-by:
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/9b8d2b0bbfad..d56f8d2e0501 git log 9b8d2b0bbfad..d56f8d2e0501 --date=short --no-merges --format='%ad %ae %s' 2019-02-26 cwallez@chromium.org Remove Chrome-specific configs for GLFW and GLM Created with: gclient setdep -r src/third_party/dawn@d56f8d2e0501 The AutoRoll server is located here: https://autoroll.skia.org/r/dawn-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:935641,chromium:935704 TBR=cwallez@chromium.org Change-Id: I74e3cf161943daca3161d0b176069b2a64a82974 Reviewed-on: https://chromium-review.googlesource.com/c/1488503Reviewed-by:
-
Colin Blundell authored
As part of the effort to eliminate this class, this CL eliminates its last public API. We port the callers to either use identity_test_utils.h or directly use SigninManager::OnExternalSigninCompleted() as appropriate given the context of the test. Bug: 796544 Change-Id: I3f32b3fbb2285925a65d35d0041750281cfc67c5 Reviewed-on: https://chromium-review.googlesource.com/c/1486531Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/0ba9f084228f..de280d758ae2 Created with: gclient setdep -r src-internal@de280d758ae2 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I97237198ba9e1b711d8fba82cf31b66814058235 Reviewed-on: https://chromium-review.googlesource.com/c/1488501Reviewed-by:
-
Gauthier Ambard authored
The file was used for downstream compatibility. Bug: none Change-Id: Idd6baf6fd2542c3e67b49f1bec169d021922d79d Reviewed-on: https://chromium-review.googlesource.com/c/1475407 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Eric Noyau <noyau@chromium.org> Cr-Commit-Position: refs/heads/master@{#635464}
-
Joel Hockey authored
Added https://github.com/webcomponents/html-imports/blob/master/src/html-imports.js Many polymer files are using html imports of URLs such as chrome://resources/html/polymer.html. When running in UI test mode, none of the chrome://resources URLs will load. Previously it was fine for these requests to fail, since polymer and other libraries were being loaded explicitly from //third_party/polymer/ sources in the main document. But with this polyfill, a failure to load is causing the whole page to fail. We will follow up to patch the html-imports.js polyfill to translate chrome://resource URLs to the correct location of the related script within //ui/webui/ or //third_party/polymer/ Bug: 924873 Change-Id: I289aa1448b06a1ced131c9a3c5faf8a6fb53898e Reviewed-on: https://chromium-review.googlesource.com/c/1488482Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Auto-Submit: Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#635463}
-
Jordan Demeulenaere authored
This CL replaces the cross button by a Cancel/Close button as shown in go/autobot-gallery-m74. We introduce back the hairline style as the Chrome ButtonCompat does not handle setting a custom background (e.g. the rounded border of hairline style). Ideally, we should add this functionality in ButtonCompat to inherit the button behavior (like ripple effect). When shown, the chips are now split into 2 carousels: - the suggestions carousel shows assistive chips. - the actions carousel shows (filled or hairline) buttons. The carousel now supports the CENTER alignment (valid only when it has a single chip/button to show) to center its child within the carousel. The "Go back" button on the details confirmation screen has been temporarily removed until the details screen is refactored to use the prompt action and that we can flag prompt choices as being a "Cancel" button. Animated transition of buttons will be added in a future CL. Screenshots: - https://screenshot.googleplex.com/q9M8Qx5yNZk.png - https://screenshot.googleplex.com/p54uTuZMmEh.png - https://screenshot.googleplex.com/HfgBqeOsMY5.png Bug: b/125283126 Change-Id: I4df01d97d2ef0b6682e9de9b225077043d15252f Reviewed-on: https://chromium-review.googlesource.com/c/1482896 Commit-Queue: Jordan Demeulenaere <jdemeulenaere@chromium.org> Reviewed-by:
Stephane Zermatten <szermatt@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#635462}
-
Gauthier Ambard authored
This CL changes the height of the cells, making sure that they have 48pt when they only have one line of text, 58 when they have two lines. It also unifies the different font for the subtitles to Footnote. Reland of:https://chromium-review.googlesource.com/c/1474755 Bug: 922511 Change-Id: I4396927bc73ef6ef90abd4f5a9d059082b4ea068 Reviewed-on: https://chromium-review.googlesource.com/c/1479959 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#635461}
-
Olya Kalitova authored
Adds images to the PluginVm launcher dialog: * Add logo image * Add FPO image * Add error image Renames a few of the images so the naming is consistent. Also replaces title with a big message label as logo image is supposed to be above it. Proper layout would be added in further CLs. Test: browser_tests --gtest_filter="PluginVm*" Bug: 931700 Change-Id: I6fb5e60909a6da50913d5cca96b725a4351748a1 Reviewed-on: https://chromium-review.googlesource.com/c/1477690Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Timothy Loh <timloh@chromium.org> Commit-Queue: Olya Kalitova <okalitova@chromium.org> Cr-Commit-Position: refs/heads/master@{#635460}
-
Fredrik Söderquist authored
Like in LocalFrameView::UpdateStyleAndLayoutIfNeededRecursive, explicitly update style (and attach the layout tree) before proceeding to layout. This ensures that the style update/layout tree attachment of the child document does not mark its frame owner as dirty after layout has already been performed for the top-level document. Bug: 933409 Change-Id: I6b2c864aededed7429c63cbd068ec45c58972ae0 Reviewed-on: https://chromium-review.googlesource.com/c/1481331Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#635459}
-
Andrew Moylan authored
This function is called by both TfNative and MlService codepaths, and ML Service code path was already logging success. Moved the logging out of the common function and made it explicit in each codepath. Bug: 935838 Test: no Change-Id: I8a9a5882f339866ffd309e7ffa87945adf455c7a Reviewed-on: https://chromium-review.googlesource.com/c/1488391 Auto-Submit: Andrew Moylan <amoylan@chromium.org> Reviewed-by:
Jia Meng <jiameng@chromium.org> Commit-Queue: Andrew Moylan <amoylan@chromium.org> Cr-Commit-Position: refs/heads/master@{#635458}
-
Marc Treib authored
If local Sync is enabled, then ProfileSyncService::OnEngineInitialized() used to call TryStart(). TryStart() kicks off the engine initialization, which is obviously redundant at this point. So this CL removes the unnecessary call. Bug: none Change-Id: Iac2a01ff013e8034db446ed6200131829299b2bf Reviewed-on: https://chromium-review.googlesource.com/c/1486355 Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Auto-Submit: Marc Treib <treib@chromium.org> Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#635457}
-
Nico Weber authored
Bug: 926235 Change-Id: I22f037731caaf8bcd693f2937195e8d5ddf8da91 Reviewed-on: https://chromium-review.googlesource.com/c/1487352Reviewed-by:
Lambros Lambrou <lambroslambrou@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Auto-Submit: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#635456}
-
Miyoung Shin authored
- unsigned short -> uint16_t. - No logic changes. - Reference: https://google.github.io/styleguide/cppguide.html#Integer_Types Bug: 929986 Change-Id: I5c1a0002afd82cfbcfc2e6fcc72576e266b9791d Reviewed-on: https://chromium-review.googlesource.com/c/1488472Reviewed-by:
-
