- 27 Jan, 2020 40 commits
-
-
Nico Weber authored
Ran `tools/clang/scripts/upload_revision.py efb130fc93059bdf02d3a83950ddabc5d119f9de`. This increases the clang version from 10 to 11. Bug: 1030664 Change-Id: I8b7ad7f85895abda80e45860ab7e0215e6740d13 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2020894 Commit-Queue: Hans Wennborg <hans@chromium.org> Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#735635}
-
Owen Min authored
Bug: 1022143 Change-Id: I0b381df87615afae66fa65e832eaa28f2796c452 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2023667 Commit-Queue: Owen Min <zmin@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#735634}
-
Vikas Soni authored
Refactor EndBatchReadAccess() to remove the entry for the current context correctly for all the cases even though there are no registered backings in the current context. Bug: 1045677,1045127,1045242 Change-Id: I1a8081193900ec5d7f8955bdbd00eff96ccef68e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2023289 Commit-Queue: vikas soni <vikassoni@chromium.org> Reviewed-by:
Eric Karl <ericrk@chromium.org> Cr-Commit-Position: refs/heads/master@{#735633}
-
John Lee authored
Dragging a tab group around acts the same as dragging a tab. The dragged tab group takes the index of the tab or group it is being dragged over. Bug: 1027373 Change-Id: Ie70883a16330e09732e1bad02e2112d2511cb51e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2018499 Commit-Queue: John Lee <johntlee@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#735632}
-
Scott Haseley authored
This change adds the origin_trial_feature_name entry and adds a test for the expected interfaces. Change-Id: Idd79b99fc61e9eee925732745be2bcd8c35afe92 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2019330Reviewed-by:
Nate Chapin <japhet@chromium.org> Commit-Queue: Scott Haseley <shaseley@chromium.org> Cr-Commit-Position: refs/heads/master@{#735631}
-
nancy authored
BUG=1038487 Change-Id: I86f44dac59451af54966304d55f827e6f23d9de8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2021790Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#735630}
-
behdad authored
Reporters should not be advanced to Active stage prior to Submit. Currently the reporter in BeginImpl and BeginMain will be move to Activate stage in case of ImplFinish and BeginMainAbort. This might result in losing the previous reporter in Active stage which might be needed for submit. Bug: none Change-Id: I90b7161f8daebb8884ce23b4fc4cc9d593dea09d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1993743Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Behdad Bakhshinategh <behdadb@chromium.org> Auto-Submit: Behdad Bakhshinategh <behdadb@chromium.org> Cr-Commit-Position: refs/heads/master@{#735629}
-
Rachel Carpenter authored
This is to avoid the spinner that shows while the Get Help app loads. See context in https://crbug.com/1026620#c48. Bug: b/145710734 Change-Id: Ifb24fdc6242ea9ac52ba6129ba14ffda641997f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2016523 Commit-Queue: Rachel Carpenter <carpenterr@google.com> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#735628}
-
Johannes Henkel authored
Bug: 1045980 Change-Id: I3eed762b79c3bdda55271a1b5716277a3ba32336 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2023675Reviewed-by:
Peter Kvitek <kvitekp@chromium.org> Commit-Queue: Johannes Henkel <johannes@chromium.org> Cr-Commit-Position: refs/heads/master@{#735627}
-
Peter Kasting authored
I verified on the Harmony stickersheet that these are intended to be supported styles. Losing them was a regression in r716332. Bug: 1042809 Change-Id: I3e1ab146fbfb6d4702afb77963a026316a1cce39 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2024107Reviewed-by:
Allen Bauer <kylixrd@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#735626}
-
Avery Musbach authored
For the workflow where you drag from one overview grid and drop into another, the present CL expands a unit test to explicitly check that the destination grid is arranged in MRU order, although if it were not then the stacking order would also be wrong and the test would fail anyway. Bug: None Change-Id: I15baba6a9812db409b1c8897155290cdf7cd3c4d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2023345Reviewed-by:
Sammie Quon <sammiequon@chromium.org> Commit-Queue: Avery Musbach <amusbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#735625}
-
Daniel Rubery authored
Clearing the BinaryUploadServices is missing from the associated Profile after the profile has been destroyed during shutdown. ServicesManagerDesktop: :ShutdownServices which can cause accesses to Change-Id: Id4c0862dcae5d0772cd44ca43c3ec71ede95a864 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2024030 Auto-Submit: Daniel Rubery <drubery@chromium.org> Commit-Queue: Xinghui Lu <xinghuilu@chromium.org> Reviewed-by:
Xinghui Lu <xinghuilu@chromium.org> Cr-Commit-Position: refs/heads/master@{#735624}
-
chromium-autoroll authored
Roll airmont AFDO profile from 81-4025.0-1579516880-benchmark-81.0.4019.0-r1 to 81-4028.0-1580123479-benchmark-81.0.4019.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-airmont-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: I915a2dd0760123e4f9ef6433fd2c7642b03eeaf4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2023238Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#735623}
-
Jimmy Gong authored
- We prefer to have no periods for UX single sentences Bug: 1015628 Change-Id: I6fc71162830b9a05349614d5ff84dabf6e4304f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2022900Reviewed-by:
Bailey Berro <baileyberro@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: jimmy gong <jimmyxgong@chromium.org> Cr-Commit-Position: refs/heads/master@{#735622}
-
Ted Choc authored
Addressed two deprecated methods in SuggestionDrawableState. Some polish around the switch to generics to ensure we don't lose generic types through the various call stacks. Some small javadoc/other cleanups too (to get rid of the underlying in my IDE). BUG=982818 Change-Id: I8bd90bd73a7fa826f2f2bf5dc2eb94dd2f5d0e3f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2023198Reviewed-by:
Ender <ender@google.com> Commit-Queue: Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#735621}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/f5d825ac1bb6..fc419895da6e git log f5d825ac1bb6..fc419895da6e --date=short --first-parent --format='%ad %ae %s' 2020-01-27 michael.liao@microsoft.com [Common - Overview Grid]: Fixing focus shift when right slider is focused Created with: gclient setdep -r src/third_party/devtools-frontend/src@fc419895da6e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:963183 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Icc94802f3eb06421d6d22457773289abe08c1568 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2023220Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#735620}
-
Rakib M. Hasan authored
CL crrev.com/c/1918294 requires that we add a lint that prevent users from adding leading spaces in test expectation lines. Landing this change will prevent large diffs in test expectation files during WPT imports. Because of the above CL, during WPT imports we will rewrite all expectation lines. We keep unmodified expectation lines in their original form, however we do not keep the leading spaces. The expectations will be re-added to the file without leading spaces. Bug: 986447 Change-Id: Id9f1e9bbbe263c19421ba2dc74ed9d340be66383 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2024029Reviewed-by:
Robert Ma <robertma@chromium.org> Commit-Queue: Rakib Hasan <rmhasan@google.com> Cr-Commit-Position: refs/heads/master@{#735619}
-
John Chen authored
This is a reland of 5b6e70af, without changes to fast/forms/calendar-picker/calendar-picker-appearance-zoom125-expected.png, to avoid crbug/1046092. Original change's description: > Rebaseline part of web tests for MacOS 10.14 > > Rebaseline of web tests in custom-elements, editing, and fast directories. > > Bug: 1028242 > Change-Id: Idab238ce374bb3fa01bdc0ac8535f74afe090ac1 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2022351 > Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> > Auto-Submit: John Chen <johnchen@chromium.org> > Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org> > Cr-Commit-Position: refs/heads/master@{#735450} TBR=wangxianzhu@chromium.org Bug: 1028242, 1046092 Change-Id: I34b2780c0454a57a1bae6429474176d8eb31f4e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2023673Reviewed-by:
Robert Ma <robertma@chromium.org> Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#735618}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/material-foundation/material-roboto-font-loader-ios/+log/4aa51e906e56..bc63eabbbd1e git log 4aa51e906e56..bc63eabbbd1e --date=short --first-parent --format='%ad %ae %s' 2019-04-10 rsmoore@google.com Revert "Remove unneeded fonts and unhint others. (#17)" (#19) 2019-04-10 rsmoore@google.com Revert "Remove extra `self = [super init]`. (#15)" (#18) 2019-04-10 dmaclach@gmail.com Remove unneeded fonts and unhint others. (#17) 2019-04-10 ccrazy88@users.noreply.github.com Remove extra `self = [super init]`. (#15) Created with: gclient setdep -r src/ios/third_party/material_roboto_font_loader_ios/src@bc63eabbbd1e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/material-roboto-font-loader-ios-chromium Please CC bling-p10-rolls@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:ios-internal-mdc Bug: None Tbr: bling-p10-rolls@google.com Change-Id: I746f1f75b355c3efdc8d37b49706b90b804ed835 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2023218Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#735617}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/material-foundation/material-font-disk-loader-ios/+log/93acc021e303..8e30188777b0 git log 93acc021e303..8e30188777b0 --date=short --first-parent --format='%ad %ae %s' 2017-02-17 willlarche@users.noreply.github.com [Docs] Clarity in README (#1) Created with: gclient setdep -r src/ios/third_party/material_font_disk_loader_ios/src@8e30188777b0 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/material-font-disk-loader-ios-chromium Please CC bling-p10-rolls@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:ios-internal-mdc Bug: None Tbr: bling-p10-rolls@google.com Change-Id: Ic4395b372aa0689f173edacc4db4afb9b6001da7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2023217Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#735616}
-
Joe Downing authored
TBR: johannes@chromium.org Bug: 1045980 Change-Id: Ifcc7052a788915d2a0638ba6572004e7b8ec13ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2023278Reviewed-by:
Joe Downing <joedow@chromium.org> Commit-Queue: Joe Downing <joedow@chromium.org> Cr-Commit-Position: refs/heads/master@{#735615}
-
Weiliang Chen authored
For Andorid Pre-SurfaceControl, overlay processor can send the overlay candidates directly. This is a reland. The original CL was reverted due to clusterfuzz bug and causing crash. The problem is the destruction order of objects owned by the display. The OverlayProcessor class needs to be destructed before the DisplayResourceProvider is destructed. The crash is at crbug.com/1045574. This is CL 6/? for sending the overlay candidates directly to gpu thread. R=rjkroege Bug: 979788 Change-Id: I8b7057977daa7900d415e3720e2a194efbcc0816 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2023188 Commit-Queue: weiliangc <weiliangc@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#735614}
-
Sean Topping authored
Previously, the typemap module path did not match the path in mojo/public/mojom/base/ref_counted_memory.mojom. Bug: None Test: CQ Change-Id: I23aa1f45176fbce97ce11a16e58b6983f8b46308 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2021317 Commit-Queue: Sean Topping <seantopping@chromium.org> Auto-Submit: Sean Topping <seantopping@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#735613}
-
Sam Bowen authored
Bug: 1044244 Change-Id: I7af8208b8c5a25f247b09cc0cbe55d44934f1d2d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2020604Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Sam Bowen <sgbowen@google.com> Cr-Commit-Position: refs/heads/master@{#735612}
-
Sujie Zhu authored
We will populate the checkbox enable_fido_auth value to UserProvidedUnmaskDetails when the checkbox is shown on Clank UI. Previously we don't set the enable_fido_auth in user_response which causes Clank unmask card request's opt_in_fido_auth field is always set to default false. Bug: 949269 Change-Id: Ide593c012dda8f09f5d219863174884c9f9da9a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2023516Reviewed-by:
Manas Verma <manasverma@google.com> Reviewed-by:
Jared Saul <jsaul@google.com> Commit-Queue: Sujie Zhu <sujiezhu@google.com> Cr-Commit-Position: refs/heads/master@{#735611}
-
Oystein Eftevaag authored
There's page sets that are flaky on Win7 GPU bots due to the current 200mb buffer size being hit. R=sullivan@chromium.org Bug: 1046081 Change-Id: Ib2beacfaa68f5b5cb47065f72cbfd0ab23a1d46d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2023200 Auto-Submit: oysteine <oysteine@chromium.org> Reviewed-by:
Annie Sullivan <sullivan@chromium.org> Commit-Queue: oysteine <oysteine@chromium.org> Cr-Commit-Position: refs/heads/master@{#735610}
-
Gabriel Charette authored
Design doc : https://docs.google.com/document/d/1tssusPykvx3g0gvbvU4HxGyn3MjJlIylnsH13-Tv6s4/edit BrowserThread counterpart to move away from post_task.h is @ https://chromium-review.googlesource.com/c/chromium/src/+/2014055 Bug: 1026641 Change-Id: I11c0633779cd2cfe75e29d3318b953c86e32bbec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1977964 Commit-Queue: Gabriel Charette <gab@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#735609}
-
Piotr Bialecki authored
We currently use 2 directories to include ARCore SDK: - the arcore-android-sdk/ contains the github checkout - we need it to get arcore header file - the arcore-android-sdk-client/ contains the SDK's .aar itself (included from CIPD) When changing anything in those 2 directories, we should make sure that android-pie-arm64-dbg builder is run. try.star was edited manually, the other changes are due to running `lucicfg generate "main.star"` in src/infra/config since presubmit was complaining. Change-Id: I9d23817407d2f5e82a50dc12f56d7a11e6c0d0a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2023514Reviewed-by:
Ben Pastene <bpastene@chromium.org> Commit-Queue: Piotr Bialecki <bialpio@chromium.org> Cr-Commit-Position: refs/heads/master@{#735608}
-
Jeremy Roman authored
This might be subject to concurrent modification by script. Contributed-by:
Sergei Glazunov <glazunov@google.com> Bug: 1045874 Change-Id: I27f75b8a4db924bb4fe471abca439cbbe7948c3c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2023354 Commit-Queue: Jeremy Roman <jbroman@chromium.org> Commit-Queue: Domenic Denicola <domenic@chromium.org> Auto-Submit: Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Domenic Denicola <domenic@chromium.org> Cr-Commit-Position: refs/heads/master@{#735607}
-
David Maunder authored
It is no longer used and can be removed Bug: 1045766 Change-Id: I6cabd73a87a178b7489e8b63e1c50baba5a0362c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2021859Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Commit-Queue: David Maunder <davidjm@chromium.org> Cr-Commit-Position: refs/heads/master@{#735606}
-
Chris Hamilton authored
This moves the recently created content::MessagePort concept to blink. This is required because some intended downstream clients of this class can not take a dependency on content, but already have a dependency on a blink. BUG=803242 Change-Id: I177bf5e3c53ca550783a0aa9f1f6207551d87e74 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2023470Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Chris Hamilton <chrisha@chromium.org> Cr-Commit-Position: refs/heads/master@{#735605}
-
Eugene Zemtsov authored
On devices struggling to keep up with the video playback, render interval might drift around its proper value. Adjusting cadence to small changes causes more harm than good, because it resets the cadence pattern. This change increases tolerance to such drifts. Bug: 1042111 Change-Id: I5fa8b7d35de65f9b77a81d4c6a2648b30210dd13 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2021406Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Eugene Zemtsov <eugene@chromium.org> Cr-Commit-Position: refs/heads/master@{#735604}
-
Jamie Walch authored
With pointer-lock active, the client hides the mouse cursor. While this is appropriate in some contexts (full-screen games or VMs, for example), it is not uncommon for a cursor to be required in others. In particular, a game might use a cursor while interacting with menus, and disable it while playing the game. Rather than requiring the user to toggle pointer-lock manually in this case, the host can composite the cursor image into the desktop. This will have no effect if the cursor is hidden, but allow applications to be used normally (albeit with noticeably higher perceived latency) if it is visible. Note that this CL doesn't work correctly without https://webrtc-review.googlesource.com/c/src/+/166545. Bug: 1043325 Change-Id: Ice84f4770ad32233177ea910d6f364c78998f8af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2013526 Commit-Queue: Jamie Walch <jamiewalch@chromium.org> Reviewed-by:
Joe Downing <joedow@chromium.org> Cr-Commit-Position: refs/heads/master@{#735603}
-
Alex Cooper authored
chrome/android/features/vr contains the bulk of the UI code for WebXr, changes to this directory can cause some of the WebXr Daydream-only tests to fail. chrome/android/javatests/... contains the tests that are actually run on this config (especially when scoped to Daydream only), that are currently otherwise untested. Change-Id: Ie9beebb0e677bc1be30d7c7d2fe7c822a1fbbe29 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2023866 Auto-Submit: Alexander Cooper <alcooper@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Alexander Cooper <alcooper@chromium.org> Cr-Commit-Position: refs/heads/master@{#735602}
-
Devlin Cronin authored
Add a browser test that exercises clicking on the three-dot menu in the Extensions Menu to trigger the context menu for that extension. This provides parity with the test coverage in the old UI (tested in ToolbarActionViewInteractiveUITest.TestContextMenuOnOverflowedAction). Bug: 984654 Change-Id: I49eb542c0abc393af481e869b2159e4457ce1e64 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2022976Reviewed-by:
Peter Boström <pbos@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#735601}
-
Rossana Monteriso authored
This CL: * adds 3 grid-item-alignment-with-orthogonal-flows tests to the WPT project, adapted from WebKit tests. The corresponding outdated tests are being removed from the fast/ folder. * adds the class .thirdRowFirstColumn to grid.css support file, and removes it from the single test's <style> section, where the class is used, to avoid duplicates. Change-Id: I390a50ccfd53065b808449d6e748b22d5f88aee5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2022793 Commit-Queue: Javier Fernandez <jfernandez@igalia.com> Reviewed-by:
Javier Fernandez <jfernandez@igalia.com> Cr-Commit-Position: refs/heads/master@{#735600}
-
James Cook authored
SplitSettingsSync will allow the user to opt-out of browser sync. However, IdentityManager::GetPrimaryAccount() assumes the user has consented to browser sync. Many call sites in Chrome OS use PrimaryAccountAccessTokenFetcher to get access tokens for APIs that are unrelated to sync. These sites will fail if the user does not consent to sync because the primary account will be empty. Add a mode to PrimaryAccountAccessTokenFetcher to work with the "unconsented" primary account, which exists whether or not the user has consented to sync. I initially tried to switch the call sites to directly use AccessTokenFetcher, but some of them (cloud policy) can start a fetch before the primary account is available. PAATF supports this use case. Migrate the following sites: * TokenHandlerFetcher - for login * UserCloudPolicyTokenForwarder - for policy fetch * CryptAuthClientImpl - for "Better Together" multidevice features TODO: Supervised users. Bug: 1042400 Test: updated existing unit_tests Test: login works with --use-unconsented-primary-account Test: enroll device, sign in, chrome://policy shows policies applied Change-Id: Ia5eec6442f371ce957e674f4b1f20961244b8e26 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2021824 Commit-Queue: James Cook <jamescook@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#735599}
-
Joe Downing authored
TBR: rdevlin.cronin@chromium.org Bug: 1042220 Change-Id: Ibbb2c19588c08a7001a6704064111cfc380a9bff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2023202Reviewed-by:
Joe Downing <joedow@chromium.org> Commit-Queue: Joe Downing <joedow@chromium.org> Cr-Commit-Position: refs/heads/master@{#735598}
-
Eric Stevenson authored
Bug: 901465 Change-Id: Icdf67d1c56eb675707eec256c5bfb5ffd6b9a875 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2023231Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Auto-Submit: (gone) Eric Stevenson <estevenson@chromium.org> Cr-Commit-Position: refs/heads/master@{#735597}
-
John Lee authored
Now that we are adding support for tab groups in the WebUI tab strip, there isn't a need to have 2 separate models for the tab context menu. Bug: 1027373 Change-Id: I41ede1f315c5fc7bbe70addc0f3d36e0db83f04f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2013652Reviewed-by:
Collin Baker <collinbaker@chromium.org> Commit-Queue: John Lee <johntlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#735596}
-