GitLab

Move Key/User context

BUG=387613
TBR=stevenjb@chromium.org
TBR=davemoore@chromium.org
TBR=darin@chromium.org

Review URL: https://codereview.chromium.org/378513005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282126 0039d316-1c4b-4281-b951-d872f2087c98

R=davemoore@chromium.org

Review URL: https://codereview.chromium.org/378383002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282125 0039d316-1c4b-4281-b951-d872f2087c98

TBR=dnicoara
NOTRY=true

Review URL: https://codereview.chromium.org/380503003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282124 0039d316-1c4b-4281-b951-d872f2087c98

Revert of Enabled chrome_proxy benchmarks on Android as we now have a TryBot. (https://codereview.chromium.org/367753003/)

Reason for revert:
chrome_proxy tests need live server access. Android chromium.perf bots don't have access to live servers and all tests under tools/perf are now part of chromium.perf. 

It seems chrome_proxy trybot for now can use flag --also-run-disabled-tests to explicitly run these tests.

Original issue's description:
> Enabled chrome_proxy benchmarks on Android as we now have a TryBot.
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=281182

TBR=tonyg@chromium.org,dtu@chromium.org
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/379233003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282123 0039d316-1c4b-4281-b951-d872f2087c98

BUG=391943
TBR=nduca@chromium.org

Review URL: https://codereview.chromium.org/376273002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282122 0039d316-1c4b-4281-b951-d872f2087c98

This is a pre-requisite for http server refactoring,
https://codereview.chromium.org/296053012/.

1) Introduce SocketLibevent for tcp and unix domain sockets.
2) TCPSocketLibevent utilizes SocketLibevent.
3) For backward compatibility, TCPSocketLibevent::AdoptConnectedSocket()
   allows the empty address.

BUG=371906

Review URL: https://codereview.chromium.org/348803003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282121 0039d316-1c4b-4281-b951-d872f2087c98

domain_reliability
favicon
history
url_fixer

R=jamesr@chromium.org

Review URL: https://codereview.chromium.org/377393002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282120 0039d316-1c4b-4281-b951-d872f2087c98

A race can exist where two build targets build the same libchrome.  It
can manifest as:
  .../arm-linux-androideabi-objcopy: error: the input file '.../libchrome.2085.0.so' is empty

Move the temporary directory used to transfer stripped files between the
strip and pack actions from <(SHARED_INTERMEDIATE_DIR) to <(intermediate_dir).
Also, remove nugatory inter-action dependency, and make actions previously
consuming <(strip_stamp) consume <(pack_arm_relocations_stamp) instead.

BUG=392417

Review URL: https://codereview.chromium.org/376193003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282118 0039d316-1c4b-4281-b951-d872f2087c98

Since scroll handlers do not block composited scrolling, the existing
input latency metric will only report the response time for the
compositor when scrolling a page with a handler. This is not accurate
for pages that implement scroll-synchronized effects, because the
scroll handler needs to be invoked so that the page contents are
updated with the new scroll offset.

This patch fixes the problem by forwarding latency information from the
impl to the main thread when we are scrolling a layer that has an active
scroll event handler.

In the case the scroll handler is no-op, the latency information will be
terminated as a failed commit.

Sample trace:
https://drive.google.com/file/d/0ByyxMXB38gLDRE40bkU5TVd0U00/edit?usp=sharing

BUG=347366

Review URL: https://codereview.chromium.org/365463003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282117 0039d316-1c4b-4281-b951-d872f2087c98

BUG=381866

Review URL: https://codereview.chromium.org/369353002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282116 0039d316-1c4b-4281-b951-d872f2087c98

BUG=390884

Review URL: https://codereview.chromium.org/379813003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282115 0039d316-1c4b-4281-b951-d872f2087c98

BUG=391943
TBR=nduca@chromium.org

Review URL: https://codereview.chromium.org/379233002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282113 0039d316-1c4b-4281-b951-d872f2087c98

GetNexeFd() in ppb_nacl_private_impl will change soon to be an internal method,
not one exposed through the PPB_NaCl_Private interface. From inside Chromium,
base::Callback is much easier to use than PP_CompletionCallback or
TrackedCallback.

This is one of a series of changes to refactor the pexe downloading logic in
the trusted plugin.

BUG=370556

Review URL: https://codereview.chromium.org/380773002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282112 0039d316-1c4b-4281-b951-d872f2087c98

Revert of Disable another WebView fullscreen video test until we land fullscreen IPC changes (https://codereview.chromium.org/371933003/)

Reason for revert:
revert this as all related CLs are committed

Original issue's description:
> Disable another WebView fullscreen video test until we land fullscreen IPC changes
> 
> there are 2 changes needs to be submitted before we reenable the tests:
> 1. https://codereview.chromium.org/290643005/ and
> 2. https://codereview.chromium.org/292573004/
> 
> the blink change will break all the tests, so we need to reenable the test after the chromium change lands
> 
> BUG=367346
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=281627

TBR=boliu@chromium.org
BUG=367346

Review URL: https://codereview.chromium.org/382583002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282111 0039d316-1c4b-4281-b951-d872f2087c98

Currently, AcceleratorController delivers accelerators to GlobalCommandsListenerChromeOS (which is an AcceleratorTarget). We respect the same conditions found within AcceleratorController to disallow shortcuts in specific instances (e.g. login screen locked screen, empty windows). AcceleratorController is owned by the ash::Shell and knows about existing keyboard shortcuts/actions.

BUG=336761
TEST=interactive_ui_tests --gtest_filter=GlobalCommandsApiTest.*

And, manually, on a desktop build of Chrome with GYP_DEFINES=chromeos=1...

with a component extension:

Verified that
- a global shortcut (ctrl+shift+0) works with focus in
1. web content
2. shelf
3. toolbars (omni box, View(s)).

Verified that processing does not occur in the following cases (similarly to most other ash accelerators) as expected:
- OOBE
- locked screen
- desktop with no windows open
- sign in screen (after logging out).

Review URL: https://codereview.chromium.org/350943003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282110 0039d316-1c4b-4281-b951-d872f2087c98

BUG=391861
R=asargent@chromium.org
TBR=jochen@chromium.org

Review URL: https://codereview.chromium.org/377833009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282109 0039d316-1c4b-4281-b951-d872f2087c98

Ports over more gyp logic for the icu target. Doesn't correctly account
for host toolchains yet, but it's closer.

All hail GN. oRZ

BUG=none

Review URL: https://codereview.chromium.org/377113002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282108 0039d316-1c4b-4281-b951-d872f2087c98

R=jamesr@chromium.org

Review URL: https://codereview.chromium.org/381643003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282107 0039d316-1c4b-4281-b951-d872f2087c98

BUG=391943
TBR=nduca@chromium.org

Review URL: https://codereview.chromium.org/380783003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282106 0039d316-1c4b-4281-b951-d872f2087c98

BUG=391943
TBR=nduca@chromium.org

Review URL: https://codereview.chromium.org/379843005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282105 0039d316-1c4b-4281-b951-d872f2087c98

Blink won't find carriage returns from Windows clipboards.
Strip those characters before calling WebContents::Find.

The newline character is displayed wrong in textfields.
Swap it out for the Unicode newline symbol: ␤ (0x2424).
(the glyph isn't available on Win Views for me now...)

See before/after pics at http://crbug.com/371450#c7

BUG=371450
TEST=Find-in-page works well for string containing line breaks.
R=pkasting@chromium.org
TBR=asvitkine@chromium.org

Review URL: https://codereview.chromium.org/374253002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282102 0039d316-1c4b-4281-b951-d872f2087c98

BUG=360311
NOTRY=true

Review URL: https://codereview.chromium.org/379923008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282100 0039d316-1c4b-4281-b951-d872f2087c98

Changed registration API to work for one network at once.
Fixed comments.
Replaced argument GCDDevice with just string id.

BUG=383167
R=alexsemenov@chromium.org, asargent@chromium.org, asvitkine@chromium.org, noamsml@chromium.org

Review URL: https://codereview.chromium.org/363883002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282099 0039d316-1c4b-4281-b951-d872f2087c98

implement it for mDNS (WiFi devices forthcoming)

BUG=383167

Review URL: https://codereview.chromium.org/356613002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282098 0039d316-1c4b-4281-b951-d872f2087c98

Note: this is a reland of https://codereview.chromium.org/373153002/
after plugging a memory leak.

BookmarkStorage isn't ref counted anymore since
https://codereview.chromium.org/370323002, and the LoadCallback() task
now gets a WeakPtr to the owning BookmarkStorage. However, it gets a
raw pointer to the BookmarkLoadDetails object, which is still owned
by BookmarkStorage and may have been destroyed when the background
task runs.

This happened on iOS tests after a recent merge.

TBR=sky@chromium.org
BUG=165760

Review URL: https://codereview.chromium.org/376203002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282097 0039d316-1c4b-4281-b951-d872f2087c98

Fix incorrect usage of ProfileInfoCache in GAIAInfoUpdateService: SetGAIANameOfProfileAtIndex may change the profile index.
Also add some warning comments in profile_info_cache.h.

BUG=372381

Review URL: https://codereview.chromium.org/373083002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282095 0039d316-1c4b-4281-b951-d872f2087c98

TBR=tonyg@chromium.org
BUG=

Review URL: https://codereview.chromium.org/378363002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282094 0039d316-1c4b-4281-b951-d872f2087c98

in Google Update settings.

Consequentially, the backed up client_id now keeps its dashes and crash_keys
strips them at runtime rather than when backing it up
(https://codereview.chromium.org/372473004/ will add support for stripped
client_id backups for some time).

Also rename a lot of methods involved in setting the client id; having all of
them named "SetClientID" makes this series of calls very hard to follow!

BUG=391338
TBR=thestig

Review URL: https://codereview.chromium.org/365133005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282093 0039d316-1c4b-4281-b951-d872f2087c98

BUG=391943
TBR=nduca@chromium.org

Review URL: https://codereview.chromium.org/376243003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282091 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None

Review URL: https://codereview.chromium.org/353093004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282090 0039d316-1c4b-4281-b951-d872f2087c98

BUG=chromedriver:843
TBR=stgao@chromium.org

Review URL: https://codereview.chromium.org/379803007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282089 0039d316-1c4b-4281-b951-d872f2087c98

BUG=391943

Review URL: https://codereview.chromium.org/376183005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282088 0039d316-1c4b-4281-b951-d872f2087c98

Apparently some desktop drivers do not generate an INVALID_OPERATION, so we
should enforce it in GPU command buffer.

BUG=391953
TEST=conformance_renderbuffers_framebuffer_object_attachment passing on all GPU bots
R=kbr@chromium.org,bajones@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/379623002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282085 0039d316-1c4b-4281-b951-d872f2087c98

BUG=386652
R=sadrul@chromium.org, oshima@chromium.org
TBR=kevers@chromium.org
TEST=manually

Review URL: https://codereview.chromium.org/356263003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282081 0039d316-1c4b-4281-b951-d872f2087c98

WebViewGuest is growing fairly large (~ 1600 lines). This CL aims to move all permission related code to a new helper class WebViewPermissionHelper:

- Rename PluginPermissionHelper to WebViewPermissionHelper;
- Move permission request code:
--- Include permissions: Download, PointerLock, Media, Geolocation, FileSystem, Plugin;
--- Not include: New Window API, Dialog API.

Review URL: https://codereview.chromium.org/347113002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282080 0039d316-1c4b-4281-b951-d872f2087c98

A BUILD.gn file was checked into the real location so this secondary-tree file is unused.

R=tfarina@chromium.org

Review URL: https://codereview.chromium.org/378633005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282078 0039d316-1c4b-4281-b951-d872f2087c98

This variable changed name to avoid ambiguity with dependencies.

R=noelallen@chromium.org

Review URL: https://codereview.chromium.org/374213002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282077 0039d316-1c4b-4281-b951-d872f2087c98

This variable changed name.

R=jamesr@chromium.org

Review URL: https://codereview.chromium.org/375873006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282076 0039d316-1c4b-4281-b951-d872f2087c98

The default was "iPhone", but that's not supported in Xcode 6, so use
"iPhone 5" in that case.

Also remove an unnecessary call to |connect| when printing supported
devices on Xcode 6. This call is not needed and just hangs for a few
seconds so remove it (all that's really needed is to load the
CoreSimulation framework.

BUG=390581
TEST=With Xcode 6 installed, build iossim then run iossim with no
optional paramters (e.g. out/Debug-iphonesimulator/iossim path/to/my.app
TBR=rohitrao@chromium.org

Review URL: https://codereview.chromium.org/379863002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282075 0039d316-1c4b-4281-b951-d872f2087c98

This CL brings SetGAIAGivenNameOfProfileAtIndex in line with SetGAIANameOfProfileAtIndex.

BUG=372381

Review URL: https://codereview.chromium.org/373093002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282074 0039d316-1c4b-4281-b951-d872f2087c98