- 13 Aug, 2020 40 commits
-
-
Kunihiko Sakamoto authored
Running loading benchmarks on Pinpoint with a valid configuration is a bit tricky, so this adds some guides for providing correct arguments for Pinpoint. Bug: 1114724 Change-Id: I64e3919b1e3d3e94b8c815e8a747f392f3da4854 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352291Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#797581}
-
Meera Srinivasan authored
The guidance is to not use Sha1 for obfuscation. There is no security concern for hostname since it is generally considered to be public info. Change-Id: If587d9e9480606ec9df0b164313026ed49a4a4ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2351453 Commit-Queue: Joe Downing <joedow@chromium.org> Reviewed-by:
Joe Downing <joedow@chromium.org> Cr-Commit-Position: refs/heads/master@{#797580}
-
Peter Kasting authored
Bug: none Change-Id: I48a4c36c96f3c92afa5e34cf43b9901af358d2d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2350133Reviewed-by:
Xing Liu <xingliu@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#797579}
-
Alexander Dunaev authored
The menus should show mnemonics if Alt is pressed. This did not work in Ozone because the platform didn't expose the current status of control keys (which is delivered with input events as so called modifiers). This CL introduces a new method that returns the current state of modifier keys from the platform, and allows the menu mnemonics for two Ozone platforms. In addition, one unit tests of the menu controller has been enabled for all platforms where Aura is available. Bug: 1085700, 1113086 Change-Id: Ie2857c763d325f85c7f464e69cc22a18bcbf6f61 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2333833Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Maksim Sisov (GMT+3) <msisov@igalia.com> Commit-Queue: Alexander Dunaev <adunaev@igalia.com> Cr-Commit-Position: refs/heads/master@{#797578}
-
Julie Jeongeun Kim authored
This CL moves printing::PrintHostMsg_DidPrintDocument_Params to print.mojom to pass it to Mojo interfaces. This is a precursor CL to mojofy PrintHostMsg_DidPrintDocument. Bug: 1008939 Change-Id: I953c8066e9acfc9e3802a7a28f491c44059ac171 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2341028 Commit-Queue: Julie Kim <jkim@igalia.com> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Eric Seckler <eseckler@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#797577}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/2b36c8eb3e1c..62f669be69c5 2020-08-13 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I584725f9be4beeaf1ff6738378b5cdfb5d0c5be2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353829Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#797576}
-
Rachel Carpenter authored
This is based on the feature HelpAppReleaseNotes. It will have a different launch URL and message than the Help App normally does. Has the same logic for when it displays as the Release Notes PWA. Bug: b/161755085 Change-Id: Ie3778178411001b8e9c99deffbae7231387b7ce8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2351480 Commit-Queue: Rachel Carpenter <carpenterr@chromium.org> Reviewed-by:
Nancy Wang <nancylingwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#797575}
-
Aleks Totic authored
Collapsed borders are computed by NGTableBorders::ComputeTableBorders NGTableBorders used to store table_writing_direction. This meant that cache would have to be invalidated when table_direction changes. This felt awkward, and table_writing_direction was available elsewhere, so I removed it from NGTableBorders LayoutNGTableSection/Row had a few methods that were left out of the initial row/section patch because they depended on data structures that were not landed yet. They are in this patch by accident, call me out on it, and I'll remove them. Bug: 958381 Change-Id: I254087934be120b0998886ce0ce2d35d7cc72204 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2347225 Commit-Queue: Aleks Totic <atotic@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#797574}
-
Yuki Shiino authored
Ports https://crrev.com/c/2351950 to the new bindings generator. Bug: 839389 Change-Id: Ia3bab7ba01b527acb550b40a7178563f70edd88d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352571Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#797573}
-
Alexander Dunaev authored
This CL pays a bit of technical debt in the clipboard implementation. First, it updates a test that verifies that putting text into clipboard registers the proper set of MIME types, as had been suggested in [1]. Second, it enables for Ozone the test that verifies selection buffers. Third, it de-duplicates some string constants. [1] https://chromium-review.googlesource.com/c/chromium/src/+/2306252 Change-Id: I6beb6b5b3827f0ec09cf19bc1868e7955141f680 Bug: 911992, 1105892 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346338Reviewed-by:
-
danielng authored
Implementing an installer for borealis, based on the install flow of Plugin VM and Crostini. Currently there is no way of accessing the installer (during testing I attached it to a dummy app entry I created). Whilst the install process is quite lean right now, I left in some structures, inspired by the other installers, that will be useful when the installation flow gets more complex and/or when tests are added. I haven't added any tests since things may be scrapped when proper UX is decided, the installer is only being used internally and it exists in a vacuum. For more context into the installer, and Borealis, please see the attached bug. Tests: Tested manually on my machine. Bug: b:161650651 Change-Id: I552c39f2ff4e0da86bc0f113bef6c4129e671a51 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2338275 Commit-Queue: Daniel Ng <danielng@google.com> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Nic Hollingum <hollingum@google.com> Reviewed-by:
Dana Fried <dfried@chromium.org> Cr-Commit-Position: refs/heads/master@{#797571}
-
Minggang Wang authored
This patch moves function GetDefaultNetReferrerPolicy() into Blink, so we could call it inside Blink directly. Meanwhile, NetToMojoReferrerPolicy() is moved to referrer_utils.h/cc, where is more suitable for it. Bug: 860403 Change-Id: I078abe32181cfe02e3594c3f1d33dde04a2da170 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2337894 Commit-Queue: Minggang Wang <minggang.wang@intel.com> Reviewed-by:
Dominic Farolino <dom@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#797570}
-
tby authored
There are three container views within the launcher search box: app tiles, results list, and answer card. Currently, the order of these containers in the UI is dynamic: it changes depending on the display scores of the results within each container. In practice though, we always want one ordering: app tiles, answer card, then results list. But the dependence on result scores is a source of bugs, because ML ranking can significantly change the UI. This CL fixes the container scores to prevent these kinds of bugs in future. Bug: 1028447 Change-Id: I2217fc9c1f8715b7073f1afd976e1a1b87343e04 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2345924Reviewed-by:
Jenny Zhang <jennyz@chromium.org> Reviewed-by:
-
Mike Wasserman authored
Check for permission on cross-screen window.open|moveTo|resizeTo|etc. Do not prompt users, fall back to the current screen on failure. Perform rough clamping for screen selection in WebContentsImpl. Perform fine clamping with known frame sizes in BrowserView. Plumb the window.open requesting RenderFrameHost into WebContentsImpl. (needed to make the appropriate origin-specific permission check) Extend popup window placement browser tests. TODO: Refine and clarify window placement patterns... TODO: Test cross-screen placements, app window/popup placements. TODO: Refine browser testing pattern, add/extend WPTs as possible. Bug: 1080690 Change-Id: I74ee149f6ae42c7ddcedd75ac832fee6d40dcc52 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2227190 Commit-Queue: Michael Wasserman <msw@chromium.org> Reviewed-by:
-
Charlie Hu authored
Previously we allow PolicyValue to always represent certain strictness, i.e. comparable. However, with the incoming introduction of enum type PolicyValue, this will no longer hold true. There is no logical ordering of strictness for some enums, e.g. Enum.RED > Enum.BLUE does not make sense. This CL adds the support for non-comparable PolicyValue. Change-Id: I1f260d6e357e5e09c4577d5cd08af87e2df5f21e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343606Reviewed-by:
Ian Clelland <iclelland@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Charlie Hu <chenleihu@google.com> Cr-Commit-Position: refs/heads/master@{#797567}
-
Chris Harrelson authored
This logic is controlled by the CompositingOptimizations feature. Bug: 1115577 Change-Id: Ia6f666ed9c78b0a9a2ad3a58229561889ac6b93c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353419Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#797566}
-
Brian Malcolm authored
This is intended to replace the NativePrintersBulkConfiguration policy. The old policy will still be used in the absence of the new one for at least a few releases of Chrome. BUG=chromium:1113366 Change-Id: If7fb1a53180874a5bd12f081129aed5ffadad443 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340741 Commit-Queue: Brian Malcolm <bmalcolm@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Sean Kau <skau@chromium.org> Reviewed-by:
Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#797565}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I63fa2aeb58b2488112ecc04f38b295a00676f50d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2351424Reviewed-by:
-
John Delaney authored
What: This CL adds an additional check in the restricted navigation ad tagging code that only deletes FrameDatas if the navigation successfully committed. Why: This prevents us from triggering Frame deletion when the frame and subframes still exist. There is a followup change: https://crrev.com/c/2324603 which intends to make these types of errors less problematic. Bug: 1108511 Change-Id: I6b35c65b325ea96ca8bb4de58f946306ae9cdaba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2341160 Commit-Queue: John Delaney <johnidel@chromium.org> Reviewed-by:
Josh Karlin <jkarlin@chromium.org> Cr-Commit-Position: refs/heads/master@{#797563}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll Please CC chonggu@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: chonggu@google.com Change-Id: Ic0498846a6d49139123b3fb515daffa8cb7d6d4c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352043Reviewed-by:
-
Melissa Zhang authored
Bug: 1097623 Change-Id: I773d2e6b88b580520da0265e0a6c9761f85fdf0e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352578Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Melissa Zhang <melzhang@chromium.org> Cr-Commit-Position: refs/heads/master@{#797561}
-
Rachel Wong authored
This is intended to allow selection to remain on the selected action if the launcher is updated with new results. Bug: 1114969 Change-Id: I25f7153da7cdf25d4f9ccdf70e0f3ac85036911e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2348244 Commit-Queue: Rachel Wong <wrong@chromium.org> Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#797560}
-
Matt Falkenhagen authored
This CL blocks prefetching to private IP addresses, so that CORS-RFC1918 is not bypassed. It adds a URLLoaderFactory option to accomplish this. We can't just use CORS-RFC1918 as-is because the security state of the client and in fact the client's URL is not known at prefetching time, as redirects can happen after this time. Bug: 1114064 Change-Id: I74bdbb078d3b3ed41e9fbbc809f68b43499b6040 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2351102 Commit-Queue: Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Camille Lamy <clamy@chromium.org> Reviewed-by:
Sophie Chang <sophiechang@chromium.org> Reviewed-by:
Eric Roman <eroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#797559}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/9f3ce85bab94..338597ba8c41 2020-08-13 wuwang@google.com Convert downloader to be lazy load. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC sadrul@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1060399 Tbr: sadrul@google.com Change-Id: Ifa3f7e6144ca13e5fda1208eaf183fb0bd8bdfc3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352042Reviewed-by:
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=srinivassista@chromium.org Change-Id: I3146065211d0d0d0dc8054e51cfca192c257308d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353582Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#797557}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/2088cdec6612..4a486be696b4 2020-08-12 enga@chromium.org Roll third_party/tint/ bc80805c4..5e7ef27ca (9 commits) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: I520e9a38c8ceede1ac3ff38abc7c50ab7c6dfaff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2351423Reviewed-by:
-
David Maunder authored
This supports the effort of moving fields to UserData objects so Tab doesn't become too big and unwieldy. Bug: 1112357 Change-Id: I6c484d9586ca8ad7d1866fbbc9dac4735ecf1470 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2337673 Commit-Queue: David Maunder <davidjm@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#797555}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/dfa133b7b48c..dbee93ac203d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-win-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I42a16049d070c2091ce1d26393dbd175184da34d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353695Reviewed-by:
-
Ted Meyer authored
out of the vaapi accelerator. Also add some todos for adding media log. Bug: 1103510 Change-Id: I23d790356ee29e40a152a398b6bbd3a760c9369d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2288472 Commit-Queue: Ted Meyer <tmathmeyer@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#797553}
-
Kunihiko Sakamoto authored
Display a console warning when web bundle cannot be parsed, or requested resource is not included in the bundle. Errors are reported through a callback passed to CreateWebBundleSubresourceLoaderFactory(). Bug: 1082020 Change-Id: I77414239d17140fb18a22d74454e02ba1036b8f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2342326Reviewed-by:
Tsuyoshi Horo <horo@chromium.org> Reviewed-by:
Hayato Ito <hayato@chromium.org> Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#797552}
-
Christopher Lam authored
This CL adds some semantic colors that have been specified by UX and moves the AshColorProvider implementation into cros_colors.json5. Bug: 1018654 Change-Id: I235af03f9f27816ec52c9f8305cf27a185847bdd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2335622 Commit-Queue: calamity <calamity@chromium.org> Reviewed-by:
Jiewei Qian <qjw@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#797551}
-
Yutaka Hirano authored
As specified in the method comments. Bug: 1112734 Change-Id: I0e16566014936d396f7f47d27fb0f17cfe2124d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2351929Reviewed-by:
Adam Rice <ricea@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#797550}
-
Christopher Lam authored
TBR=javierrobles@chromium.org Bug: 1115321, 1115282 Change-Id: I2684b189dc648fd738e9f6bb21acb7da46809587 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352255Reviewed-by:
calamity <calamity@chromium.org> Commit-Queue: calamity <calamity@chromium.org> Cr-Commit-Position: refs/heads/master@{#797549}
-
Ben Pastene authored
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-eve-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-kevin-chrome TBR=chrome-os-gardeners@google.com Change-Id: Ic74f39a1c42e9c463e8ad492f7aa0ea978e63dee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2351454Reviewed-by:
Ben Pastene <bpastene@chromium.org> Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: Jun Mukai <mukai@chromium.org> Cr-Commit-Position: refs/heads/master@{#797548}
-
Alexander Cooper authored
Now that it is impossible to enter the VR Browser, there is no need for android to provide mechanisms for entering text. All child "UI" classes allow for both the KeyboardDelegate and TextInputDelegates to be null, so the browser renderer factory can simply stop creating the classes. This is a speculative fix for the flaky tests described in the bug, and full cleanup of the classes/codepaths that are always null will be done at a future time. Bug: 1114265 Change-Id: I26977ac0faaf504702465369b4a33a2169181b5e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352519 Commit-Queue: Alexander Cooper <alcooper@chromium.org> Commit-Queue: Klaus Weidner <klausw@chromium.org> Auto-Submit: Alexander Cooper <alcooper@chromium.org> Reviewed-by:
Klaus Weidner <klausw@chromium.org> Cr-Commit-Position: refs/heads/master@{#797547}
-
nancylingwang authored
Add the new temporary metrics to check whether all Arc app icons are real adaptive icons with separate foreground and background files. The information could be helpful to collect information for the next phase, e.g. whether we should refactor or removing the non-adaptive icon code. BUG=183331 Change-Id: Id0e5f58972cfe1f04c14f13aa2cf18a908bbf23a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346092Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Long Cheng <lgcheng@google.com> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#797546}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/dfa133b7b48c..dbee93ac203d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I437f0c59866b2fcb7da57738fd7bc98cd16afcc0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353710Reviewed-by:
-
Brandon Mousseau authored
This change extends android_aar_prebuilt to support including any assets in the aar file in the output. Currently, if the source aar file contains any files in the assets subdirectory, the target must define the ignore_assets flag. This change now optionally allows the user to instead supply the extract_assets flag so that the assets will be copied to the output instead. If assets are included in the source aar, then either ignore_assets or extract_assets, but not both, must be set. Assets will be copied to the output target with the same directory structure as the input aar file. Bug: 643966 Change-Id: Ibf66543fd9e9dc8db7221234b82c1d860f7f2724 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2350340 Auto-Submit: Brandon Mousseau <bmoose@google.com> Commit-Queue: Brandon Mousseau <bmoose@google.com> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#797544}
-
Yue Li authored
Bug: b/152643590 Test: Manual Test Change-Id: Ifd67289fcd7e8d9e62816c4a318a7f78cfc268df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2351726 Commit-Queue: Yue Li <updowndota@chromium.org> Auto-Submit: Yue Li <updowndota@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#797543}
-
Lukasz Anforowicz authored
The CL modifies URLLoaderFactoryParamsHelper::CreateForRendererProcess so that it sets |request_initiator_site_lock| of the process-wide factory to an opaque origin. This change is based on https://crbug.com/1105794 which shows that there are indeed no cases in the wild where a process-wide factory is used with a non-opaque initiator origin. This intuitively makes sense - the process-wide factory should only be used in frames that have not yet committed any navigation and such frame should not (yet) have a non-opaque origin. Additionally, thanks to the change described above, there is no longer a need for site/eTLD+1 comparisons in VerifyRequestInitiatorLock nor for SiteInstanceImpl::GetRequestInitiatorSiteLock. Fixed: 1098938 Change-Id: I9e8b53139a2418636c84e783f86ea8d7be34eed9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2274591Reviewed-by:
-
