- 16 Apr, 2018 40 commits
-
-
https://chromium.googlesource.com/catapult.git/+log/0371983030f2..5d0c16d725ca $ git log 037198303..5d0c16d72 --date=short --no-merges --format='%ad %ae %s' 2018-04-12 crouleau [Telemetry] Explain when no browsers available for a device Created with: roll-dep src/third_party/catapult BUG=chromium:830834 The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=sullivan@chromium.org Change-Id: I89bb2ef6dda43a6c723fc7686e01f9278876c1d3 Reviewed-on: https://chromium-review.googlesource.com/1014276 Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#551139}
-
Yuqian Li authored
bug: chromium:821353 Change-Id: If1c7bb0daf8b9c295e7ec2d58145fabdee17bcff Reviewed-on: https://chromium-review.googlesource.com/1010511 Commit-Queue: Yuqian Li <liyuqian@chromium.org> Reviewed-by:
Florin Malita <fmalita@chromium.org> Cr-Commit-Position: refs/heads/master@{#551138}
-
Tommy C. Li authored
When Steady State Elisions is on, there's currently the following bug: When the user clicks the Omnibox (and selects everything), then Alt-Tabs out of the window, and Alt-Tabs back in, the selection changes from select-all to a cursor at the beginning of the Omnibox. This CL fixes the bug and adds a test to prevent regression. The bug was caused by some old code in OmniboxEditModel that should have been deleted a while ago. It also refactors the test a bit to make the focus and blur fake events more robust. It also updates the OmniboxViewViews::OnFocus method to be suitable for usage within tests (rather than overriding and defining a fake one). Bug: 797354 Change-Id: I4516455cf81e4097f27605f52a669f01f7c17f61 Reviewed-on: https://chromium-review.googlesource.com/1013209 Commit-Queue: Tommy Li <tommycli@chromium.org> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Cr-Commit-Position: refs/heads/master@{#551137}
-
Colin Blundell authored
Update comments in //services/identity/public/cpp to better reflect the current reality of IdentityManager. Change-Id: I20fef4d73aec6737927bdc0dc398dd366fccbd9a Reviewed-on: https://chromium-review.googlesource.com/1013479Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Commit-Queue: Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#551136}
-
Dmitry Gozman authored
These were exposed by leak detector change, dgozman@ is going to fix them. Bug: 833609 Change-Id: I068afd816b67158a0d1ee5aef515525685398069 Reviewed-on: https://chromium-review.googlesource.com/1014462 Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#551135}
-
Tom Anderson authored
BUG=833179 R=dpranke Change-Id: Ie9fa320c6d532844f85d34f5d6f8a1195a9eb107 Reviewed-on: https://chromium-review.googlesource.com/1014263 Commit-Queue: Dirk Pranke <dpranke@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#551134}
-
Andres Calderon Jaramillo authored
This CL corrects two erroneous byte positions during EDID parsing, namely for Green and White LSByte positions. Affected unit tests are fixed. Bug: 821393 Change-Id: Ica3c54258e0d58b55bd5c5779e9ef6b6f5e4a610 Reviewed-on: https://chromium-review.googlesource.com/1005534 Commit-Queue: Daniele Castagna <dcastagna@chromium.org> Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Reviewed-by:
Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#551133}
-
Jao-ke Chin-Lee authored
BUG=731502 Change-Id: I12565be7b445c34d2ac16a3b1fca7feb9c88a2b4 Reviewed-on: https://chromium-review.googlesource.com/1014403Reviewed-by:
Andrii Shyshkalov <tandrii@chromium.org> Commit-Queue: Jao-ke Chin-Lee <jchinlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#551132}
-
Charlie Harrison authored
Before, the JNI shim called into native code that was compiled into Chrome proper. Now, due to r517541 there is a better way to do this by including the JNI code in libchromefortest. Bug: None Change-Id: I9f34f5105366b927d6dd6676d97a9da6d2540385 Reviewed-on: https://chromium-review.googlesource.com/997877 Commit-Queue: Charlie Harrison <csharrison@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#551131}
-
Nathan Parker authored
Bug: 755418 Change-Id: I6265cc98f0f70d9387275cb1e346acdc1978f488 Reviewed-on: https://chromium-review.googlesource.com/994276 Commit-Queue: Nathan Parker <nparker@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#551130}
-
Avi Drissman authored
This migrates some usage of notifications. BUG=170921 Change-Id: I2c824659f50d3838d65842fc4bec5db9a4c1a7df Reviewed-on: https://chromium-review.googlesource.com/1011682 Commit-Queue: Avi Drissman <avi@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#551129}
-
Xiaohan Wang authored
- Clarify lifetime model. - Clarify thread model. - Remove GetClassIdentifier(). Moving foreard, we should add virtual methods to CdmContext to support platform-specific interfaces, instead of using static_cast. TBR=jrummell@chromium.org,rkuroiwa@chromium.org Bug: 821288 Test: No functionality change. Change-Id: I13e30ed2c508855727219edd3975abf5d67e6721 Reviewed-on: https://chromium-review.googlesource.com/1014284Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#551128}
-
Mohammad Refaat authored
Accessing cookies from WKHTTPCookieStore doesn't work correctly when there is not a WKWebView object alive. previously a work around was created, but it seems to not solve the problem. The problem always existed but to be able to WKHTTPCookieStore as the main cookieStore, it had to be addressed. Bug: 661630, 746947 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Ie5f67102a7cfb804a47b8aa5c1316c25be5d9609 Reviewed-on: https://chromium-review.googlesource.com/1011584Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Mohammad Refaat <mrefaat@chromium.org> Cr-Commit-Position: refs/heads/master@{#551127}
-
Fady Samuel authored
This reverts commit fc9d1583. Reason for revert: Now that we've branched for M68, I'm relanding this. Original change's description: > Revert "Surface synchronization: Add diagnostic CHECK" > > This reverts commit 3fb6e543. > > Reason for revert: This is blocking branch cut. We know we hit this case and we've collected some crash logs to sift through now. > > Original change's description: > > Surface synchronization: Add diagnostic CHECK > > > > Current evidence points to a race in cc that is causing surface invariants > > violations (No invariants violations detected in LayerTreeHost but detected > > in ClientLayerTreeFrameSink). > > > > My suspicion is viewport is updated out of sync with LocalSurfaceId and > > device scale factor. > > > > This CL adds a diagnostic CHECK between the pending and active LayerImpls to > > attempt to detect the race and produce a better stack trace. The invariant > > we want to test here is if active tree has an invalid viewport (viewport has > > changed), then the LocalSurfaceId MUST change. > > > > Bug: 672962 > > Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel > > Change-Id: I975c9dfb9c86c292d7aac052bac01510e6efb1c2 > > Reviewed-on: https://chromium-review.googlesource.com/989851 > > Reviewed-by: enne <enne@chromium.org> > > Commit-Queue: Fady Samuel <fsamuel@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#547457} > > TBR=enne@chromium.org,fsamuel@chromium.org > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: 672962 > Change-Id: Id1ad5997e12b7f966df5f7b034bd5a30baa5ae60 > Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel > Reviewed-on: https://chromium-review.googlesource.com/1008642 > Reviewed-by: Fady Samuel <fsamuel@chromium.org> > Commit-Queue: Fady Samuel <fsamuel@chromium.org> > Cr-Commit-Position: refs/heads/master@{#550175} TBR=enne@chromium.org,fsamuel@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 672962 Change-Id: I7e460b4177d7690cc324d0feadeed7aacbcb24ec Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Reviewed-on: https://chromium-review.googlesource.com/1012407Reviewed-by:
Fady Samuel <fsamuel@chromium.org> Commit-Queue: Fady Samuel <fsamuel@chromium.org> Cr-Commit-Position: refs/heads/master@{#551126}
-
Dan Sanders authored
This adds VdaVideoDecoder, an adapter that implements the media::VideoDecoder interface using a media::VideoDecodeAccelerator. VdaVideoDecoder expects to run in the GPU process, with access to a command buffer stub, as will be the case for decoders created by MojoVideoDecoder. VdaVideoDecoder runs on the (mojo) IO thread as much as possible, but the VDA interface is inherently tied to the GPU thread. Compared to the original landing (commit e192695d), this change casts kMaxPlanes to uint32_t before using it as a parameter to DCHECK_LE() in PictureBufferManager::CreatePictureBuffers(). Bug: 522298 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Ie3e1b346f9b88692bcb2be12434fb0b6b81ef025 Reviewed-on: https://chromium-review.googlesource.com/1012936 Commit-Queue: Dan Sanders <sandersd@chromium.org> Reviewed-by:
Frank Liberato <liberato@chromium.org> Cr-Commit-Position: refs/heads/master@{#551125}
-
Shenghua Zhang authored
The current .yaml files are wrapping duplicate directory names like 'public/tools', which cause downloaded packages as 'public/public/tools'. This cl fixed that issue by add the root directory info to yaml files. TBR=jbudorick@chromium.org Bug: 659808 Change-Id: I3be84d33cff2974c7bea481349aef04a45b9548f Reviewed-on: https://chromium-review.googlesource.com/1013389 Commit-Queue: Shenghua Zhang <shenghuazhang@chromium.org> Reviewed-by:
Shenghua Zhang <shenghuazhang@chromium.org> Cr-Commit-Position: refs/heads/master@{#551124}
-
Mike Klein authored
See https://skia-review.googlesource.com/c/skia/+/121582 Bug: skia:7810 Change-Id: Ibc32853736c539e76d84e135e3ef45201056026b Reviewed-on: https://chromium-review.googlesource.com/1014249Reviewed-by:
Florin Malita <fmalita@chromium.org> Commit-Queue: Mike Klein <mtklein@chromium.org> Cr-Commit-Position: refs/heads/master@{#551123}
-
Tetsui Ohkubo authored
Supervised user notification was generated in TraySupervisedUser, which is a SystemTrayItem. We're going to get rid of SystemTrayItems as UnifiedSystemTray will replace them, so we should generate the notification outside system tray. TEST=SupervisedNotificationControllerTest BUG=none Change-Id: Ifc774e83eb28e996f3f337040f31d736ab8e5f52 Reviewed-on: https://chromium-review.googlesource.com/1013117Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/heads/master@{#551122}
-
Erik Chen authored
This CL is a refactor with no intended behavior change. This CL also updates Browser::SwapTabContents() to return a scoped object, as this was a caller of TabStripModel::ReplaceWebContentsAt. The end goal is to update all instances of content::WebContents to have explicit ownership semantics, which will allow us to clean up the internal ownership semantics of TabStripModel. Bug: 832879 Change-Id: I3ff525f8a265eb7a2abb0ee3921ac74b6b7e4271 Reviewed-on: https://chromium-review.googlesource.com/1012574 Commit-Queue: Erik Chen <erikchen@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#551121}
-
Evan Stade authored
system tray still works Bug: 327885 Test: sign into one user, start signin to a second user, cancel; Change-Id: I9fa93bbd87a1f4a0087746e3a42ead07ee308710 Reviewed-on: https://chromium-review.googlesource.com/1008825 Commit-Queue: Evan Stade <estade@chromium.org> Reviewed-by:Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#551120}
-
Xiaocheng Hu authored
This patch implements the LayoutNG version of InSameLine() on top of ComputeNGCaretPosition(): 1. Use ComputeNGCaretPosition() to find the fragment for a position 2. Traverse up from the fragment to obtain line box 3. Compare line boxes to decide if positions are in the same line The implementation is simple in concept but inefficient, since ComputeNGCaretPosition() traverses the whole block flow. Follow up work will optimize ComputeNGCaretPosition() to reduce traversal. Bug: 830956 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: I34a7bc19953bd5995b70afa1b2890d15ef8da744 Reviewed-on: https://chromium-review.googlesource.com/1008631 Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by:
Yoichi Osato <yoichio@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#551119}
-
David Reveman authored
This UpdateCursorCompositingEnabled call is happening before the GPU process is properly initialized. Remove it as it's not needed here. UpdateCursorCompositingEnabled will be called later when preferences have been loaded and GPU process is properly initialized. Bug: 832979 Test: chrome --ash-enable-cursor-motion-blur on Eve Change-Id: I8603c007f1b0d201a046ffb7e84706af95c21097 Reviewed-on: https://chromium-review.googlesource.com/1013238Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: David Reveman <reveman@chromium.org> Cr-Commit-Position: refs/heads/master@{#551118}
-
James Hawkins authored
These are unnecessary and caused the cryptauth tests to be run twice when running all test binaries. R=hansberry@chromium.org Bug: none Test: none Change-Id: I006eaa35234a11bc4366a5020369d64d4f119f1c Reviewed-on: https://chromium-review.googlesource.com/1014401Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Commit-Queue: Ryan Hansberry <hansberry@chromium.org> Cr-Commit-Position: refs/heads/master@{#551117}
-
Wei Li authored
Mac sandbox version 1 warms up some system APIs before sandboxing the process. For pdf compositor service, it needs to use system text color for lcd text smoothing test. So text color API needs to be warmed up same as PPAPI process. We also allow accesses to system color profile for both pdf compositor service and PPAPI process in Mac sandbox version 2. This allows system color access, thus prevents bitmap context creation errors caused due to failed color access. BUG=822218 Change-Id: I2352588e76e9b8c82d0fa87b3b99b7c897973d6f Reviewed-on: https://chromium-review.googlesource.com/1014345Reviewed-by:
Greg Kerr <kerrnel@chromium.org> Commit-Queue: Wei Li <weili@chromium.org> Cr-Commit-Position: refs/heads/master@{#551116}
-
Weiliang Chen authored
Surface Aggregator uses render surface to apply opacity. This CL uses an epsilon value to determine when opacity is close enough to 1.f to be considered opaque. R=enne Bug: 831779 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Change-Id: Ic5f11429e4679c0990a9e441358701b8e3b5c7d2 Reviewed-on: https://chromium-review.googlesource.com/1008129Reviewed-by:
enne <enne@chromium.org> Commit-Queue: weiliangc <weiliangc@chromium.org> Cr-Commit-Position: refs/heads/master@{#551115}
-
Eric Karl authored
This change makes the ResizeDueToAutoResize messages for child frames transactional, with a begin/end. It also ensures that during a transaction we don't allocate new LocalSurfaceIds, instead waiting for the transaction to complete. Bug: 789259,805073 Change-Id: I585ac6d14b9978280847f49205d03bf49b9bb4f8 Reviewed-on: https://chromium-review.googlesource.com/960981 Commit-Queue: Eric Karl <ericrk@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
Chris Blume <cblume@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Cr-Commit-Position: refs/heads/master@{#551114}
-
Mike Wittman authored
When rbp was less than the offset, the check was underflowing and incorrectly passing. Add a check for rbp < offset to detect this situation. Bug: 831448 Change-Id: I4f780c1573782af3ca29b0f814e93ff2dca839f2 Reviewed-on: https://chromium-review.googlesource.com/1013213Reviewed-by:
Leonard Grey <lgrey@chromium.org> Commit-Queue: Mike Wittman <wittman@chromium.org> Cr-Commit-Position: refs/heads/master@{#551113}
-
Joone Hur authored
When the build flag enable_native_notifications = false, link errors happen. This CL adds ENABLE_NATIVE_NOTIFICATIONS guard to fix this problem. Bug: None Change-Id: I5bc5a3770a7d15b2f2f9de32c92722ec4fad0946 Reviewed-on: https://chromium-review.googlesource.com/1014182Reviewed-by:
Yoshiki Iguchi <yoshiki@chromium.org> Commit-Queue: Joone Hur <joone.hur@intel.com> Cr-Commit-Position: refs/heads/master@{#551112}
-
https://chromium.googlesource.com/angle/angle.git/+log/20fa8d5cfe9e..a4fa9c2782da $ git log 20fa8d5cf..a4fa9c278 --date=short --no-merges --format='%ad %ae %s' 2018-04-13 lucferron Vulkan: drawElements with GL_LINE_LOOP and an offset Created with: roll-dep src/third_party/angle The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jmadill@chromium.org Change-Id: I36c26e9275fe90c139ea6fafa36c611117dac2ef Reviewed-on: https://chromium-review.googlesource.com/1014199Reviewed-by:
angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#551111}
-
Jeremy Roman authored
This is now allowed across the Blink API, and also removes the need to write manual "delete this;" code. Change-Id: Iea4589d9ba5b826f6d7bd5d1dd08a1cf12228593 Reviewed-on: https://chromium-review.googlesource.com/1013063Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Commit-Queue: Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#551110}
-
Xiaocheng Hu authored
This patch refactors functions in ng_caret_rect.h/cc so that: 1. Functions stop passing around the containing NG inline formatting context. 2. Part of ComputeNGLocalCaretRect() is wrapped into a new overload of ComputeNGCaretPosition() taking PositionWithAffinity parameter. This is a preparation patch for implementing NG line-related functions in crrev.com/c/1008631 Bug: 822575 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: I9ee8d90b327fec9684c0bdbf52bee6dad6fafb7f Reviewed-on: https://chromium-review.googlesource.com/1011217 Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#551109}
-
Kai Ninomiya authored
WebGL (Blink) now delegates the validation of the stencil state to lower levels. This updates the command buffer to implement the new validation rules. ANGLE already implements the new validation rules, so the passthrough command buffer already passes. Patch started by kbr here: https://chromium-review.googlesource.com/c/chromium/src/+/890606 Test: conformance/misc/webgl-specific-stencil-settings.html Bug: 806557 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I1d2bc0fd346c5d3fa1d736638e39d97297915a91 Reviewed-on: https://chromium-review.googlesource.com/992862 Commit-Queue: Kai Ninomiya <kainino@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#551108}
-
Victor Costan authored
The test was disabled due to crashing on the Linux CFI bot. The test was using the following class hierarchy: * SimpleDerivedElement (SDE) - base class for our purposes * SimpleDerivedElementConstructMagicNumberOne (SDE1) - derived from SDE * SimpleDerivedElementConstructMagicNumberTwo (SDE2) - derived from SDE The test was doing the following steps: 1) Create a ListContainer<SDE1> and a ListContainer<SDE2> 2) Create an SDE1 instance in the ListContainer<SDE1> 3) Move the SDE1 instance in the ListContainer<SDE2> 4) Access the SDE2 instance via ListContainer<SDE2>::back() The CFI bot (correctly) crashed because step 4 is undefined behavior. SDE2 is not on SDE1's ancestor chain. ListContainer's templated definition is "ListContainer<BaseElementType>", suggesting that the list's templated type should be a base class for all elements. This CL fixes the undefined behavior by switching both ListContainers to ListContainer<SDE>, and verifies that both an SDE1 and an SDE2 instance are moved correctly between containers. Bug: 832726 Change-Id: Ic94acde5bd1a981d6bb763170a70a24f4306f409 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.chromium.win:win_chrome_official;master.tryserver.chromium.linux:linux_chromium_cfi_rel_ng Reviewed-on: https://chromium-review.googlesource.com/1013617 Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
enne <enne@chromium.org> Cr-Commit-Position: refs/heads/master@{#551107}
-
Hector Carmona authored
Bug: 812491 Change-Id: I54005b49e976eeffd98a1a3f5b258fc4f9efe8ce Reviewed-on: https://chromium-review.googlesource.com/1008623Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Hector Carmona <hcarmona@chromium.org> Cr-Commit-Position: refs/heads/master@{#551106}
-
Shenghua Zhang authored
chrome-release bot is facing with flatten_buildspec.gclient flatten exception which failed at running command 'cipd describe chromium/third_party/android_sdk/public/tools -version version:26.1.1-cr0'. It is suspected that double tags of the instance version causing the issue. This CL try to resolve the problem by updating the package of tools to a new version. Bug: 833123 Change-Id: Ibf23dfeb2dc5bb2008454d82bfaedb6b0603e97c Reviewed-on: https://chromium-review.googlesource.com/1013743Reviewed-by:
Michael Moss <mmoss@chromium.org> Cr-Commit-Position: refs/heads/master@{#551105}
-
Sergey Berezin authored
R=estaab@chromium.org Bug: 790168 Change-Id: I235165c89ed2d0e63bfce9676e9e4d66caaf713f Reviewed-on: https://chromium-review.googlesource.com/1011599Reviewed-by:
Vadim Shtayura <vadimsh@chromium.org> Commit-Queue: Sergey Berezin <sergeyberezin@chromium.org> Cr-Commit-Position: refs/heads/master@{#551104}
-
mark a. foltz authored
This continues the cleanup of the Presentation API typemaps by removing two more content:: types and replacing them with blink::mojo types defined in presentation.mojom. Some refactoring of code and tests was required as Mojo callbacks converted from base::Optional to blink::mojom::PresentationErrorPtr, which is move-only. Bug: 817903 Change-Id: I46136114a4afa4c14d989f2fbac341ccffe56740 Reviewed-on: https://chromium-review.googlesource.com/1012984Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Derek Cheng <imcheng@chromium.org> Commit-Queue: mark a. foltz <mfoltz@chromium.org> Cr-Commit-Position: refs/heads/master@{#551103}
-
Jamie Madill authored
Unblocks the Vulkan roll. Bug: angleproject:2482 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I9577f331977e9add28bb7875e70260d428ad0cd5 Tbr: kbr@chromium.org No-try: True Reviewed-on: https://chromium-review.googlesource.com/1014322Reviewed-by:
Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org> Cr-Commit-Position: refs/heads/master@{#551102}
-
Kai Ninomiya authored
TBR=zmo@chromium.org Bug: none Change-Id: Ib539beaf7662203c1a985a0ae707dc0761a45a03 Reviewed-on: https://chromium-review.googlesource.com/1013052Reviewed-by:
Kai Ninomiya <kainino@chromium.org> Commit-Queue: Kai Ninomiya <kainino@chromium.org> Cr-Commit-Position: refs/heads/master@{#551101}
-
Saman Sami authored
The behaviour changed in crrev.com/c/995915 and some headless tests are failing as a result. Bug: 815187 Change-Id: Iff689a1a8ef0d0b464cf13701034bcca94ef0cf2 Reviewed-on: https://chromium-review.googlesource.com/1014015Reviewed-by:
Antoine Labour <piman@chromium.org> Commit-Queue: Saman Sami <samans@chromium.org> Cr-Commit-Position: refs/heads/master@{#551100}
-