- 27 Mar, 2018 40 commits
-
-
Fredrik Hubinette authored
Instead of defaulting everything to BT709, we look at other fields to see if we can make a better guess. Bug: 754986 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Ie33df88aa50dd6629fa0721995aa33bcd1149d5e Reviewed-on: https://chromium-review.googlesource.com/909336 Commit-Queue: Fredrik Hubinette <hubbe@chromium.org> Reviewed-by:
ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#546192}
-
Jonathan Backer authored
Allow RasterDecoderImpl to use some texture copying code by adding methods to DecoderContext (common interface implemented by RasterDecoder and GLES2Decoder). Implement some of the NOTIMPLEMENTED() state restoration code by copying from GLES2DecoderImpl. BUG=789238 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Ic23665e8f1d63f20905334dedefdeb77e90c3c40 Reviewed-on: https://chromium-review.googlesource.com/981075 Commit-Queue: Jonathan Backer <backer@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#546191}
-
Fredrik Söderquist authored
The test in it's current form imposed too strict requirements on the time that had passed. We cannot guarantee a maximum elapsed time, only a minimum (and barely that...) Rewrite the test to not impose any restriction on the maximum elapsed time. Also convert it to use testharness while at it. Also rewrite/convert the sibling test with setCurrentTime. Bug: 824930 Change-Id: I79882b0189e44790e3096c8346c2a0bf47276dd8 Reviewed-on: https://chromium-review.googlesource.com/981145Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#546190}
-
Justin Novosad authored
This reverts commit 60f840e7. This re-land resolves rendering regression in AndroidWebView by restoring a context reset in ScopedGpuRaster, which was the cause of crbug.com/823232, and the reason for the revert. TBR=piman@chromium.org Bug: 807974, 810159 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I8112ab4e25c9dbf40aa386368815b986e7d4a9d9 Reviewed-on: https://chromium-review.googlesource.com/982098 Commit-Queue: Justin Novosad <junov@chromium.org> Reviewed-by:
Justin Novosad <junov@chromium.org> Cr-Commit-Position: refs/heads/master@{#546189}
-
Xi Cheng authored
Bug: 734095 Change-Id: I688b172764d97c6a759435d227fa8e030bfb82d5 Reviewed-on: https://chromium-review.googlesource.com/979118 Commit-Queue: Xi Cheng <chengx@chromium.org> Reviewed-by:
Finnur Thorarinsson <finnur@chromium.org> Cr-Commit-Position: refs/heads/master@{#546188}
-
Bernhard Bauer authored
The publisher URL is currently ignored. A followup CL will show it in the UI. Bug: 814365 Change-Id: Id22e423cf5ef756f28b0ab3f92a029267722244b Reviewed-on: https://chromium-review.googlesource.com/980553Reviewed-by:
Emily Stark <estark@chromium.org> Commit-Queue: Bernhard Bauer <bauerb@chromium.org> Cr-Commit-Position: refs/heads/master@{#546187}
-
Simeon Anfinrud authored
Renamed the transform() method into the terser map(), which is more in line with other reactive and functional programming frameworks and languages, and added a filter() method as well. Updated documentation with examples for each. Bug: NONE Test: cast_base_junit_tests, cast_shell_junit_tests Change-Id: I45797698500d829f175e1b350abe71185c03ff7f Reviewed-on: https://chromium-review.googlesource.com/956970 Commit-Queue: Simeon Anfinrud <sanfin@chromium.org> Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Cr-Commit-Position: refs/heads/master@{#546186}
-
Philip Rogers authored
This empty else block was added in [1] and is not used. [1] crrev.com/e6a9a5cd Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: Ibcb1a26f98ca7a641d069b8bdd612002569a6404 Reviewed-on: https://chromium-review.googlesource.com/982158Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#546185}
-
Charlie Harrison authored
The end goal is to get NavigationSimulator to a state where we can call: simulator->SetAutoAdvance(false); simulator->Start(); And have the simulator *not* spin the run loop in the background. This will help in writing more sophisticated NavigationThrottle tests which use multiple task runners to execute async tasks. This particular CL does a few things: 1. Removes base::RunLoop().RunUntilIdle call. This is not great practice to have in test infra, since it can cause strange interactions with tests and they may start relying on unintentional behavior. 2. Collects various after-throttle checks into closures, to be called when the throttle check complete closure is called (rather than relying on base::RunLoop to keep everything on the stack). This isn't so useful now, but it will if we stop *always* waiting. 3. Slightly modifies checks in various places that relied on some of the behavior that we've changed. Two things changed here: a. "Complete" code internal to the NavigationThrottle now runs directly after throttle checks are complete (when complete_callback_for_testing_ is called on the nav handle), rather than when the RunLoop quits. This caused us to remove one check checking that we've finished the navigation. b. Because we no longer RunUntilIdle() in WaitForThrottleChecksComplete, code that relies on the nav finishing after the post-task in NavigationRequest::OnStartChecksComplete will need to either wait or spin the run loop to see the end of the navigation. This is a pretty small edge case and it is pretty easy to either write a helper to make this explicit or use a WCO. The only test impacted by this change is a NavigationSimulator test, and a test which incidentally relied on this behavior for unrelated reasons. Bug: 822275 Change-Id: Ice6b215fa285a6a944fdf85108303515d109be77 Reviewed-on: https://chromium-review.googlesource.com/961819Reviewed-by:
oysteine <oysteine@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Commit-Queue: Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#546184}
-
Rob Percival authored
When memory pressure reaches critical, SingleTreeTracker clears the pending_entries_ map. However, if an inclusion check is in progress for one or more of those pending entries, LogDnsClient will have a pointer to a MerkleAuditProof held in that map. This results in it trying to access freed memory. The fix is to cancel all inclusion checks when this happens. This is done by changing LogDnsClient to provide a "resource handle" when it starts a query, which can be deleted in order to abort the query. Storing this in pending_entries_ assures that all inclusion checks will be aborted when pending_entries_ is cleared. Bug: 811566 Change-Id: I86b7ff880c050b790d219fa0cd50b42839bc0d3e Reviewed-on: https://chromium-review.googlesource.com/939627Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Reviewed-by:
Matt Mueller <mattm@chromium.org> Commit-Queue: Rob Percival <robpercival@chromium.org> Cr-Commit-Position: refs/heads/master@{#546183}
-
Daniele Castagna authored
This is a reland of 65ae686a The issue it caused when we originally landed it was fixed in crrev.com/c/981239 Original change's description: > viz: Make primary plane transparent > > This CL enables alpha blending at scanout for the primary plane. > In this way chromecast will be able to punch a hole in the primary > plane and show content underneath. > > Note that on platform using legacy pageflip we'll still be > scanning out without alpha blending (crrev.com/c/964984). > > Bug: 821944, b/74997524 > Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel > Change-Id: I654935dc630f7a9f6cb4717cd574a21a2749c442 > Reviewed-on: https://chromium-review.googlesource.com/976961 > Reviewed-by: Daniel Nicoara <dnicoara@chromium.org> > Commit-Queue: Daniele Castagna <dcastagna@chromium.org> > Cr-Commit-Position: refs/heads/master@{#545478} Bug: 821944, b/74997524 Change-Id: Icfff83119231cd9a1e486719dbb0a25786ea71f2 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Tbr: dnicoara@chromium.org Reviewed-on: https://chromium-review.googlesource.com/980956 Commit-Queue: Daniele Castagna <dcastagna@chromium.org> Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Cr-Commit-Position: refs/heads/master@{#546182}
-
Nick Harper authored
TBR=elawrence@chromium.org Change-Id: Ia25d5953c3d36d99df8be6da2f36a7dc49ae25e3 Reviewed-on: https://chromium-review.googlesource.com/981516Reviewed-by:
Nick Harper <nharper@chromium.org> Reviewed-by:
Eric Lawrence <elawrence@chromium.org> Commit-Queue: Nick Harper <nharper@chromium.org> Cr-Commit-Position: refs/heads/master@{#546181}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 8eb4dff9. With Chromium commits locally applied on WPT: 9236bee6 "[css-typed-om] Stub list-valued tests." Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/14785 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: jinho.bang@samsung.com, mathp@chromium.org, rouslan@chromium.org: external/wpt/payment-handler TBR=raphael.kubo.da.costa@intel.com No-Export: true Change-Id: Ia964bcec2c0ae28f843ce5ed3d9a676470a8149e Reviewed-on: https://chromium-review.googlesource.com/980678 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#546180}
-
Shimi Zhang authored
This CL 1) Removed an obsolete TODO. 2) Removed MenuDescriptor, we are not taking adavantage of it. Bug: 825381 Change-Id: Iba22809a0046150165ec4e1c265c00e77b567898 Reviewed-on: https://chromium-review.googlesource.com/978886Reviewed-by:
Pedro Amaral <amaralp@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Shimi Zhang <ctzsm@chromium.org> Cr-Commit-Position: refs/heads/master@{#546179}
-
Wei Li authored
Add one histogram enum for recording the PDF page or document composition status. And collect such status information in browser. This is used for monitoring the execution of PDF compositor service. BUG=824867 Change-Id: I2f6496195cd4ada40f0f03366997f8aa2c9f942a Reviewed-on: https://chromium-review.googlesource.com/980900Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Wei Li <weili@chromium.org> Cr-Commit-Position: refs/heads/master@{#546178}
-
Mohamed Heikal authored
This reverts commit 2cc853c1 and 9b4f3568 Reason for revert: Perf regression in webview start time Bug: 821425 TBR=mheikal@chromium.org Original change's description: > Android: Only rewrite resource ids that start with 0x7f > > Some resources listed in R.java start with a 0x01 prefix/package id. > These resources should not have their package id rewritten when in > webview mode. > > Change-Id: If3957c4bf2b5e34b5ceeb7589f7ca4e960cdd43f > Reviewed-on: https://chromium-review.googlesource.com/952097 > Reviewed-by: agrieve <agrieve@chromium.org> > Commit-Queue: Mohamed Heikal <mheikal@chromium.org> > Cr-Commit-Position: refs/heads/master@{#542152} Change-Id: I60902726262e14d5d7c08c7e2ebc8a7e85ed658f Reviewed-on: https://chromium-review.googlesource.com/978562 Commit-Queue: Mohamed Heikal <mheikal@chromium.org> Reviewed-by:
Mohamed Heikal <mheikal@chromium.org> Cr-Commit-Position: refs/heads/master@{#546177}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/2943c641..bea84ab8 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: I35970f44835269c3b99cd4c0c462eb59b2f29d2d Reviewed-on: https://chromium-review.googlesource.com/980675Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#546176}
-
Zhiqiang Zhang authored
This CL lies out the directory layout for CAF migration. The migrated code will reside in caf/, in parallel of cast/. The migrated code is guarded behind a feature flag. Bug: 711860 Change-Id: Iddfe9e3ce3103fae876c9c151c96aba2ef99354f Reviewed-on: https://chromium-review.googlesource.com/977232Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
Thomas Guilbert <tguilbert@chromium.org> Commit-Queue: Zhiqiang Zhang <zqzhang@chromium.org> Cr-Commit-Position: refs/heads/master@{#546175}
-
Finnur Thorarinsson authored
Notifications can be disabled for a number of reasons. This logs those reasons with UMA. Bug: 734095 Change-Id: I05e61b287312a42707d78415d2186909fae87fb7 Reviewed-on: https://chromium-review.googlesource.com/980559Reviewed-by:
Xi Cheng <chengx@chromium.org> Commit-Queue: Finnur Thorarinsson <finnur@chromium.org> Cr-Commit-Position: refs/heads/master@{#546174}
-
Zhiheng Vincent Li authored
Bug: b/76458625 Change-Id: I157d04a4b60fb7e206ee6f90d7f344801a7708af Reviewed-on: https://chromium-review.googlesource.com/982009Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Commit-Queue: Zhiheng(Vincent) Li <vincentli@google.com> Cr-Commit-Position: refs/heads/master@{#546173}
-
Stephen McGruer authored
Bug: 699244 Change-Id: Ia85a44be9d9f7b0d0db382892520f2755523f514 Reviewed-on: https://chromium-review.googlesource.com/980236Reviewed-by:
Robert Flack <flackr@chromium.org> Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#546172}
-
Reilly Grant authored
This test has additional failures when run with the NetworkService flag. Bug: 782958 Change-Id: Ia331cb3e2f92df49c1fac7a10bac4ddb859feeed Tbr: bashi@chromium.org No-Try: true Reviewed-on: https://chromium-review.googlesource.com/981402Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#546171}
-
John Budorick authored
Should fix webrtc's use of generate_jni after https://chromium-review.googlesource.com/c/chromium/src/+/979610 Bug: 799759 Change-Id: I838af362d81036afb8bc493a90c4faa3c4c9b467 Reviewed-on: https://chromium-review.googlesource.com/982010Reviewed-by:
agrieve <agrieve@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#546170}
-
John Budorick authored
Bug: 776495,776496,783000,783001 Change-Id: Ia69e1b225fc4ff6133316921e139ad60a8a92d6a Reviewed-on: https://chromium-review.googlesource.com/982247Reviewed-by:
Benjamin Pastene <bpastene@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#546169}
-
Brian Anderson authored
This adds the StreamAnalyzer class, which is responsible for calculating the mean, rms, smr, standard deviation, variance of roots, and threshold percentiles of a continuous stream of values. It owns a Histogram and a WindowedAnalyzer, which it uses to delegate percentile estimates and to track regions of time where metrics are worst. Bug: 807463 Change-Id: I718b06778582d0628b964747f61352ae291452f0 Reviewed-on: https://chromium-review.googlesource.com/972568 Commit-Queue: Brian Anderson <brianderson@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Timothy Dresser <tdresser@chromium.org> Cr-Commit-Position: refs/heads/master@{#546168}
-
Robert Flack authored
Both are in cc/OWNERS for animation but these often touch ui/compositor as well. Bug: None Change-Id: I7f22b0c27113c1a3ddada05bb69cbde19c8aa619 Reviewed-on: https://chromium-review.googlesource.com/982265Reviewed-by:
Ian Vollick <vollick@chromium.org> Commit-Queue: Robert Flack <flackr@chromium.org> Cr-Commit-Position: refs/heads/master@{#546167}
-
Josh Karlin authored
Requests served from memory cache don't have the is_ad bit in their newly minted ResourceRequests. The bit is needed by the AdTracker class that receives a probe on WillSendRequest. This CL copies the bit over to the new request and tests it. Bug: 807640 Change-Id: I9656446be52eb19159a84c26cbdf47905a0e1989 Reviewed-on: https://chromium-review.googlesource.com/980700Reviewed-by:
Nate Chapin <japhet@chromium.org> Commit-Queue: Josh Karlin <jkarlin@chromium.org> Cr-Commit-Position: refs/heads/master@{#546166}
-
Adithya Srinivasan authored
Most of the overloads could be directly converted to const. The only exception was HTMLEmbedElement that needed some refactoring in HTMLPluginElement in order to be const. Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I64ea48d7580977d394f927b0653b48f71f496521 Reviewed-on: https://chromium-review.googlesource.com/980591Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Adithya Srinivasan <adithyas@chromium.org> Cr-Commit-Position: refs/heads/master@{#546165}
-
Matthew Jones authored
This change removes the ability to directly change the bottom sheet's state from explore-on-content. The feature now requests that its content be shown through the BottomSheetController. Bug: 822949 Change-Id: Ib551c7fe391f7e62ea06a15eafd645e5cff3ab28 Reviewed-on: https://chromium-review.googlesource.com/981453 Commit-Queue: Matthew Jones <mdjones@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#546164}
-
Luna Lu authored
Bug: 818684 Change-Id: I6358926667c913988fab0ca4a39f25cbc4f04734 Reviewed-on: https://chromium-review.googlesource.com/969076 Commit-Queue: Luna Lu <loonybear@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#546163}
-
Daniel Park authored
> Creates flags for home page button > Logs preference changes in new histogram > Sets home page default as NTP if home page was displayed by flag Bug: 822469 Change-Id: I2c0a00f11de254f663e453f32aaab7d43ad7e761 Reviewed-on: https://chromium-review.googlesource.com/972461 Commit-Queue: Theresa <twellington@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#546162}
-
Samuel Huang authored
This CL modifies linker_map_filter.py to add a filter for object filenames. This enables Supersize to run for LTO (under LLD) without crashing -- although some data are missing (to be fixed in follow-ups). Bug: 723798 Change-Id: I90b7439368cca96921d688b0c9db95a599fa2bca Reviewed-on: https://chromium-review.googlesource.com/982254Reviewed-by:
agrieve <agrieve@chromium.org> Commit-Queue: agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#546161}
-
Tom Anderson authored
R=dpranke Change-Id: I9f93686d2bab2d3625363142bb05349817e1c5b5 Reviewed-on: https://chromium-review.googlesource.com/982250Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#546160}
-
Matt Wolenetz authored
Since FFmpeg decode of 0-byte audio and video buffers is now disallowed, and FFmpegDemuxer skips enqueuing such packets into its DemuxerStream, this change does similar for MSE: Any 0-byte |data| audio or video buffers are dropped during initial processing in FrameProcessor::ProcessFrames(). No 0-byte |data| text buffers are dropped, because: * We don't use FFmpeg to decode in-band MSE text, and * In-band MSE text buffers' |side_data| may contain meaningful information. (This assumption isn't asserted by this change). Note, this change takes the simpler route of dropping 0-byte AV buffers before they're buffered by the coded frame processing algorithm. A more complex alternative to skip them when reading from SourceBufferStream was rejected in hopes this simpler change is sufficient. Includes ability in ChunkDemuxerTest to vary |block_size_| instead of always using |kBlockSize|. While the product change is closer to FrameProcessor, FrameProcessorTests always encode the coded frame's timestamp as the coded frame contents to enable precise verification of processing results, so the test of this change is done via ChunkDemuxerTest instead. BUG=823375,663438 TEST=ChunkDemuxerTest.ZeroLengthFramesDropped Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Ie6a802ba64a576f0219ca7c400fc7dec3a45fbf6 Reviewed-on: https://chromium-review.googlesource.com/974427 Commit-Queue: Matthew Wolenetz <wolenetz@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#546159}
-
Bo Liu authored
Two reasons. One is that these callbacks should not happen if renderer process crashed. Looks like this (and a few others) are missed because they are synchronous and called from AwContentsClient instead of AwContentsClientCallbackHelper. Second reason which is relevant to the bug is that we should not callback to the app if webview is already destroyed. This can happen when a native->java jni call uses a jweak which can resurrect objects that are effectively destroyed already. Bug: 824156 Change-Id: I0a8d59e2f36070d7a4c53242ce077bda3c9bfe73 Reviewed-on: https://chromium-review.googlesource.com/981433Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Commit-Queue: Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#546158}
-
Devlin Cronin authored
The 'schemaUtils' and 'json_schema' JS bindings files are no longer needed with native bindings. Don't include them as resources in the dispatcher's source map. Bug: 810487 Change-Id: I7476069311b7ba7d0ffc0a2e37a01dcd43808c66 Reviewed-on: https://chromium-review.googlesource.com/981261Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#546157}
-
Adam Langley authored
git cl format reformats this file, causing superfluous changes in CLs. To avoid noise, this change makes clang-format happy. Change-Id: I9b7f0b310be18aadccec5b19870ad8c05df0af4d Reviewed-on: https://chromium-review.googlesource.com/974295Reviewed-by:
Steven Valdez <svaldez@chromium.org> Commit-Queue: Adam Langley <agl@chromium.org> Cr-Commit-Position: refs/heads/master@{#546156}
-
Jiaquan He authored
Cover more failing cases in ArcPlayStoreSearchProvider. Bug: 765757 Change-Id: Idb04ffc4a2b7fbeb40df183b6cefb0a00a0f2841 Reviewed-on: https://chromium-review.googlesource.com/736677 Commit-Queue: Jiaquan He <hejq@google.com> Reviewed-by:
Luis Hector Chavez <lhchavez@chromium.org> Reviewed-by:
Yury Khmel <khmel@chromium.org> Cr-Commit-Position: refs/heads/master@{#546155}
-
sczs authored
Bug: 822987 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I7aa275e08846b1ea9b067de343f6a631a56db566 Reviewed-on: https://chromium-review.googlesource.com/972163 Commit-Queue: Sergio Collazos <sczs@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#546154}
-
Gustav Sennton authored
android_webview/support_library/ contains 1. boundary interfaces (mirrored into the Android support library). 2 the support library glue (gluing the boundary interfaces together with the rest of chromium). Bug: 781754 Change-Id: I903c2165ece5192364ab2d257074304317692114 Reviewed-on: https://chromium-review.googlesource.com/980973Reviewed-by:
Richard Coles <torne@chromium.org> Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Commit-Queue: Gustav Sennton <gsennton@chromium.org> Cr-Commit-Position: refs/heads/master@{#546153}
-