GitLab

The ThreadSanitizer detected data races in the code and more work will be done
to make webrtc tracing work with Chromium.

TBR=niklase
BUG=103711
Review URL: http://codereview.chromium.org/8573002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110077 0039d316-1c4b-4281-b951-d872f2087c98

Using the initializer list construct = {0} allows the object to be linker initialized.
Modify the LazyInstance class design to make it a pod aggregate type that can be linker initialized this way. Also combines the instance and state members, in line with the Singleton<> class design.
Introduces a new LAZY_INSTANCE_INITIALIZER macro specifically for using to init all lazy instances + modify all existing callsites to use it. (Old code would no longer compile)

BUG=94925
TEST=existing tests pass. http://build.chromium.org/f/chromium/perf/linux-release/sizes/report.html?history=150&header=chrome-si&graph=chrome-si&rev=-1 should step downward.
TBR=jam@chromium.org,rvargas@chromium.org,darin@chromium.org,ben@chromium.org,apatrick@chromium.org,akalin@chromium.org

Review URL: http://codereview.chromium.org/8491043

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110076 0039d316-1c4b-4281-b951-d872f2087c98

BUG=chromium-os:20044,chromium-os:22552,chromium-os:22825
TEST=Manual: tab order on the Login dialog should be: user pods, Shutdown/Add User buttons, Remove user buttons, status area.

Review URL: http://codereview.chromium.org/8567006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110074 0039d316-1c4b-4281-b951-d872f2087c98

Previously, all lines were joined together into a single hard-to-read
block. Change expanded state to make white-space significant so
multi-line error messages are on separate lines and network
configuration renders nicely.

BUG=chromium:104138
TEST=Put network configuration policy in place and check about:policy.


Review URL: http://codereview.chromium.org/8555009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110070 0039d316-1c4b-4281-b951-d872f2087c98

R=stevenjb@chromium.org
BUG=chromium-os:21760
TEST=Change the network state with a11y turned on


Review URL: http://codereview.chromium.org/8503041

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110069 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=Compiles and passes tests.


Review URL: http://codereview.chromium.org/8555012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110068 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110063 0039d316-1c4b-4281-b951-d872f2087c98

Also, remove manually adjusting the vertical position of the subpage backdrop, as that's done via z-index now as well.

BUG=77791
TEST=no managed prefs banner ugliness


Review URL: http://codereview.chromium.org/8467029

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110060 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/8136027

TBR=thestig@chromium.org
Review URL: http://codereview.chromium.org/8564044

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110059 0039d316-1c4b-4281-b951-d872f2087c98

I've preferred using kTimeoutMultiplier only once to duplicating it for each timeout.
This however makes InitializeTimeout(0, 0, &value) non-unipotent.

BUG=103371
Review URL: http://codereview.chromium.org/8510053

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110058 0039d316-1c4b-4281-b951-d872f2087c98

This change widens the current suppression rule for bug 47949 and adds a new rule for it.

TBR=timurrrr,jhawkins
BUG=47949
TEST=make the "Webkit Mac (valgrind)" bot green.

Review URL: http://codereview.chromium.org/8564025

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110057 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/8136027

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110056 0039d316-1c4b-4281-b951-d872f2087c98

This is a reland of http://codereview.chromium.org/8351048/ with minor changes
to fix the compilation errors on the shared builders.

BUG=102446
TEST=See bug description.

Review URL: http://codereview.chromium.org/8528053

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110055 0039d316-1c4b-4281-b951-d872f2087c98

BUG=104265
TBR=jeremya@chromium.org

Review URL: http://codereview.chromium.org/8528055

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110054 0039d316-1c4b-4281-b951-d872f2087c98

R=estade@chromium.org
BUG=none
TEST=Starting to drag a tile on NTP4 works when bubble is showing (and hides the
bubble without issue).


Review URL: http://codereview.chromium.org/8565014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110053 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/8538002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110052 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=None


Review URL: http://codereview.chromium.org/8527018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110051 0039d316-1c4b-4281-b951-d872f2087c98

BUG=82857
TEST=manual

Review URL: http://codereview.chromium.org/8526017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110050 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/8463009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110049 0039d316-1c4b-4281-b951-d872f2087c98

Cleanup: Remove unneeded forward declarations from chrome/browser/ui/gtk and chrome/browser/ui/cocoa.

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/8536010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110048 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/8536004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110047 0039d316-1c4b-4281-b951-d872f2087c98

Task Manager:  Right click on the task manager list box when no item is selected should display column selection menu. But when any item is selected, the table context menu is displayed.

BUG=103649
TEST=None


Review URL: http://codereview.chromium.org/8510045

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110046 0039d316-1c4b-4281-b951-d872f2087c98

This patch is 1 of 3 splitted patches made from http://codereview.chromium.org/8386031
cros_disks_client.cc is made by mixing and refactoring chromeos_mount.cc of libcros and chrome/browser/chromeos/cros/mount_library.cc
Added code is still not used.

BUG=chromium-os:16556
TEST=build success


Review URL: http://codereview.chromium.org/8499007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110045 0039d316-1c4b-4281-b951-d872f2087c98

with the download manager.  This change should have no effect on
when the user sees a warning or not.

BUG=102540
TEST=No visible change yet.


Review URL: http://codereview.chromium.org/8536041

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110044 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=unittests


Review URL: http://codereview.chromium.org/8533028

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110043 0039d316-1c4b-4281-b951-d872f2087c98

Use correct definition introduced in http://codereview.chromium.org/8051010

BUG=None
TEST=None


Review URL: http://codereview.chromium.org/8566002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110042 0039d316-1c4b-4281-b951-d872f2087c98

Revert 109813 - Revert 109777 - Request power status update from power manager when power button view gets created.

Also, prepare PowerManagerDbusClient for change in power manager for bug chromium-os:21360

TEST=manual
BUG=chromium-os:20832

Review URL: http://codereview.chromium.org/8491054


It broke some ui_tests on linux chromeos

TBR=tbarzic@chromium.org
Review URL: http://codereview.chromium.org/8551005

ui_tests should be happy now

TBR=tbarzic@chromium.org
Review URL: http://codereview.chromium.org/8564041

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110041 0039d316-1c4b-4281-b951-d872f2087c98

This CL makes "Custom" margins sticky across different preview sessions but also within the same preview session.

Here is a summary of all changes.
- Within same preview session: So far selecting "Custom" was
  picking up from whatever the previous selected option was.
  Now, "Custom" remembers the specified margins. To test this
  select "Custom", do some dragging, then change to another
  option and back to "Custom".
- Across preview sessions: Select "Custom", do some dragging,
  then print. Open print preview again, the last used custom
  margins are remembered.
- There was a bunch of messages sent from JS to get various
  info/settings (initiator tab title, measurement system and
  number format, last used margin settings, default printer).
  I created a single message "getInitialSettings" to get all
  at once (they are needed before the 1st preview is is
  requested).

BUG=102446
TEST=See bug description.


Review URL: http://codereview.chromium.org/8351048

TBR=dpapad@chromium.org
Review URL: http://codereview.chromium.org/8564040

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110040 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110039 0039d316-1c4b-4281-b951-d872f2087c98

BUG=88782
TEST=trybots


Review URL: http://codereview.chromium.org/8532002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110038 0039d316-1c4b-4281-b951-d872f2087c98

change from

input
label

to

label
  input
  span
/label

This is better because there are no blank spaces that are unclickable (the offsetting start padding and margin was attempting to get around this). Also we need it to be consistent with settings so we can make css rules that apply to both equally well.

I removed aria-hidden attributes because those divs /should/ be using display:none when not visible. aria-hidden fixes it for screen readers but not for tab order.

BUG=103688
TEST=manual


Review URL: http://codereview.chromium.org/8566025

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110037 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=None

Review URL: http://codereview.chromium.org/8537020

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110036 0039d316-1c4b-4281-b951-d872f2087c98

This CL makes "Custom" margins sticky across different preview sessions but also within the same preview session.

Here is a summary of all changes.
- Within same preview session: So far selecting "Custom" was
  picking up from whatever the previous selected option was.
  Now, "Custom" remembers the specified margins. To test this
  select "Custom", do some dragging, then change to another
  option and back to "Custom".
- Across preview sessions: Select "Custom", do some dragging,
  then print. Open print preview again, the last used custom
  margins are remembered.
- There was a bunch of messages sent from JS to get various
  info/settings (initiator tab title, measurement system and
  number format, last used margin settings, default printer).
  I created a single message "getInitialSettings" to get all
  at once (they are needed before the 1st preview is is
  requested).

BUG=102446
TEST=See bug description.


Review URL: http://codereview.chromium.org/8351048

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110035 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none


Review URL: http://codereview.chromium.org/8555029

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110034 0039d316-1c4b-4281-b951-d872f2087c98

BUG=chromium-os:22051
TEST=Enable spoken feedback and focus on battery icon on the status area.  Press down arrow key twice and ensure that it speaks "Charging Battery full" or something like that.


Review URL: http://codereview.chromium.org/8511004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110033 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110032 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110029 0039d316-1c4b-4281-b951-d872f2087c98

The sync UMA logging logic that is in place first checks to see if the sync config has changed before logging a user's choices. This logic was broken by the implicitly enabled preferences that are currently behind a flag, resulting in more logging than necessary.

This patch changes the UMA logging logic to include only the datatypes that are explicitly listed on the preferences page. It also does the actual logging prior to applying the config via OnUserConfigured(), and adds extra checks that will remind anyone who adds a new datatype to also add UMA logging for the datatype.

BUG=96507
TEST=Change your sync config in a bunch of ways and look at about:histograms

Review URL: http://codereview.chromium.org/8566023

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110028 0039d316-1c4b-4281-b951-d872f2087c98

Allow JSONWriter and JSONValueSerializer to ignore binary values when instructed to do so.

Design discussion is available here: http://groups.google.com/a/chromium.org/group/chromium-dev/browse_thread/thread/967eb64325c24f9c

BUG=None
TEST=base_unittests


Review URL: http://codereview.chromium.org/8505033

TBR=ericdingle@chromium.org
Review URL: http://codereview.chromium.org/8528051

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110027 0039d316-1c4b-4281-b951-d872f2087c98

Actually, the interface is currently known as PPB_Flash_TCPSocket.

BUG=103993
TEST=ui_tests OutOfProcessPPAPITest.TCPSocketPrivate
TBR=dmichael@chromium.org

Review URL: http://codereview.chromium.org/8564034

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110026 0039d316-1c4b-4281-b951-d872f2087c98