GitLab

ever a naked const char* is passed in.

I hit this bug while doing a refactor, so ensuring it can't happen
again for this callsite seems prudent.

BUG=634443

Review-Url: https://codereview.chromium.org/2331323005
Cr-Commit-Position: refs/heads/master@{#418593}

The HostDiscardableSharedMemoryManager is destroyed when shutting down
and the dump provider is unregistered. But, the dump provider is
registered with no task runner which causes races in memory dumps. This
CL fixes it to register on right thread.

BUG=643438

Review-Url: https://codereview.chromium.org/2334343002
Cr-Commit-Position: refs/heads/master@{#418592}

This adds the output device color profile to display::Display, and
populates it correctly on Mac. We will want to do this for all
platforms.

The color profile is then plumbed through the same IPCs that take
the device scale factor, to get to the renderer process'
RenderWidgetCompositor.

Note that we are sending the full ICCProfile this far. This is
important, because the renderer process will be setting the ICCProfile
of its rasterized IOSurfaces, and there is a power impact of even slight
differences between the monitor profile and the IOSurface profile.

The ICCProfile is then sent as a gfx::ColorProfile (which internally
references the ICCProfile, for the above purpose) to the
RenderWidgetCompositor, from where it will be pushed to cc.

In the next step, we will (under a flag) specify the color space
for rasterization.

BUG=44872
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel

Committed: https://crrev.com/f1fef7489c29deeee2a29c41ce4851e9ad1bd67b
Review-Url: https://codereview.chromium.org/2325773003
Cr-Original-Commit-Position: refs/heads/master@{#418422}
Cr-Commit-Position: refs/heads/master@{#418591}

As on Android manual crash uploads can happen on cellular
connection it is important to display the size of the crash reports.

BUG=641628

Review-Url: https://codereview.chromium.org/2330573002
Cr-Commit-Position: refs/heads/master@{#418590}

BUG=644514
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel

Review-Url: https://codereview.chromium.org/2340663002
Cr-Commit-Position: refs/heads/master@{#418589}

PreviewsInfoBarTabHelper tracks whether a previews infobar
has been shown for a tab. If a previews infobar has already
been shown for a tab, it will not be shown again.

BUG=615566

Review-Url: https://codereview.chromium.org/2256383002
Cr-Commit-Position: refs/heads/master@{#418588}

In OfflinePageMetadataStore the following changes:
* AddOfflinePage (for single item) is added
* UpdateOfflinePages (for multiple items) is added
* AddOrUpdateOfflinePage is removed.

Resulting changes:
* OfflinePageMetadataStoreSQL and OfflinePageTestStore are updated
  accordingly.
* Tests are updated.
* OfflinePageModelImpl usage of above functions is updated.

BUG=645522

Review-Url: https://codereview.chromium.org/2339693002
Cr-Commit-Position: refs/heads/master@{#418587}

This just updates the interface and callers. Actually emitting errors
in the underlying implementation will be a different CL.

BUG=634443

Review-Url: https://codereview.chromium.org/2327973002
Cr-Commit-Position: refs/heads/master@{#418586}

BUG=644451

Review-Url: https://codereview.chromium.org/2339753002
Cr-Commit-Position: refs/heads/master@{#418585}

This hack is obsolete since the minimum supported Mac version is now 10.9.

This CL also removes the checked-in copy of libc++-static, and removes
it from DEPS.

BUG=

Review-Url: https://codereview.chromium.org/2314753002
Cr-Commit-Position: refs/heads/master@{#418584}

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/b9b708477f23..32dd31095913

$ git log b9b708477..32dd31095 --date=short --no-merges --format='%ad %ae %s'
2016-09-14 perezju Reland of "[telemetry] Wire TsProxy through telemetry's network stack." (patchset #1 id:1 of https://codereview.chromium.org/2342503002/ )

BUG=639632

TBR=catapult-sheriff@chromium.org

Review-Url: https://codereview.chromium.org/2344543002
Cr-Commit-Position: refs/heads/master@{#418583}

This implements:

- allows the content embedder to merge a manifest into the base ones provided by content, allowing it to add to the list of interfaces exposed to the renderer.
- adds such an overlay to chrome/browser

So.. from now on if you add an interface to either the browser/renderer, you'll need to list it in the manifest. I wonder how we should broadcast this. Also as a separate step we should require these manifests get security review.

R=rockot@chromium.org,tsepez@chromium.org

Committed: https://crrev.com/4ea17059bf78553528f3ffb4a9de84a447622fd3
Committed: https://crrev.com/807a926c9ca02ac8ae1b52e82537834ef78fb9ba
Review-Url: https://codereview.chromium.org/2259903002
Cr-Original-Original-Commit-Position: refs/heads/master@{#418282}
Cr-Original-Commit-Position: refs/heads/master@{#418398}
Cr-Commit-Position: refs/heads/master@{#418582}

Things within a component should have a namespace that matches its name.

BUG=646685

Review-Url: https://codereview.chromium.org/2335193006
Cr-Commit-Position: refs/heads/master@{#418581}

Revert of ImageCapture: Connect takePhoto() VideoCaptureDeviceTest (patchset #1 id:1 of https://codereview.chromium.org/2340573002/ )

Reason for revert:
Fails on Android L.

BUG=646840

Original issue's description:
> ImageCapture: Connect takePhoto() VideoCaptureDeviceTest
>
> This CL enables VideoCaptureDeviceTest.TakePhoto for
> Android. (Note that, due to other circumstances, it'll
> only be enabled for devices implementing the Camera2
> API in non-legacy mode).
>
> The only modification is that Android creates JPEGs
> with APP1 JFIF header, because it includes EXIF information.
>
> BUG=518807, 626857
>
> Committed: https://crrev.com/a8ae6bfb0e432ee220b641b0e8bb3f4800a7448a
> Cr-Commit-Position: refs/heads/master@{#418423}

TBR=emircan@chromium.org,chfremer@chromium.org,mcasas@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=518807, 626857

Review-Url: https://codereview.chromium.org/2344503003
Cr-Commit-Position: refs/heads/master@{#418580}

https://chromium.googlesource.com/skia.git/+log/6ef6999017fe..eed356d281ad

$ git log 6ef699901..eed356d28 --date=short --no-merges --format='%ad %ae %s'
2016-09-14 caryclark Rewriting path writer
2016-09-14 msarett Reduce overhead for linear color xforms
2016-09-14 jvanverth Switch default for SkGaussianBlurShader radius size.

BUG=5188

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
TBR=djsollen@google.com

Review-Url: https://codereview.chromium.org/2331223006
Cr-Commit-Position: refs/heads/master@{#418579}

BUG=631480

Review-Url: https://codereview.chromium.org/2226133005
Cr-Commit-Position: refs/heads/master@{#418578}

This is part of a cleanup before switching to a query interface.

BUG=622763

Review-Url: https://codereview.chromium.org/2336973005
Cr-Commit-Position: refs/heads/master@{#418577}

The purpose of the class is to mark a subtree as needing layout mainly for
multipass layout. We should just use LayoutObject->setNeedsLayout()

Review-Url: https://codereview.chromium.org/2341433003
Cr-Commit-Position: refs/heads/master@{#418576}

This CL adds GLX support to the Ozone X11 platform. Ozone X11 will
attempt to use GLX by default.

It reuses the existing GLX GLSurface and GLContext. Changes to
NativeViewSurfaceGLX are necessary as it handles Expose events from the
PlatformEventSource. The class is split into an abstract base class with
two small event handling implementations for USE_X11 and USE_OZONE.

BUG=361137,640613

Review-Url: https://codereview.chromium.org/1723303002
Cr-Commit-Position: refs/heads/master@{#418575}

Note that this bug was found while working on crbug.com/597479.
fast/dom/vertical-scrollbar-in-rtl.html was failing a DCHECK because we would try to adjust
when there was no animation.

This CL also exposes RunState via runStateForTesting.

BUG=597479

Review-Url: https://codereview.chromium.org/2336823003
Cr-Commit-Position: refs/heads/master@{#418574}

-4d3f7ca8cedbddad40b9e93a82926618e3fb4265
+c38be52bf8de3b1699d74932b849bf150265819e

BUG=chromium:646635

Review-Url: https://codereview.chromium.org/2340713003
Cr-Commit-Position: refs/heads/master@{#418573}

The Cloud Datastore API is being updated. Update server2 to match.
Release notes for the API:
https://cloud.google.com/datastore/release-notes

BUG=646877

Review-Url: https://codereview.chromium.org/2337753002
Cr-Commit-Position: refs/heads/master@{#418572}

Before this CL, WorkerThread checks whether forcible termination happened by
WorkerOrWorkletScriptController::isExecutionTerminating(). After this CL,
WorkerThread checks it by WorkerThread::isForciblyTerminated() instead. This
should be clearer than the previous way and enables to remove an access to
WorkerThread::m_globalScope from the main thread.

BUG=638877

Review-Url: https://codereview.chromium.org/2324693003
Cr-Commit-Position: refs/heads/master@{#418571}

https://pdfium.googlesource.com/pdfium.git/+log/89f8fa8694bb..79db609948b0

$ git log 89f8fa869..79db60994 --date=short --no-merges --format='%ad %ae %s'
2016-09-14 dsinclair Rename CPDFDoc_Environment to CPDFSDK_Environment
2016-09-14 dsinclair Split CPDFXFA_Document apart
2016-09-14 dsinclair Cleanup CPDFXFA_Document.

TBR=dsinclair@chromium.org

Review-Url: https://codereview.chromium.org/2338273003
Cr-Commit-Position: refs/heads/master@{#418570}

This is needed for other //chromeos/dbus refactoring for mus+ash.

* Rename stub to fake in DBusThreadManager and DBusClientBundle for consistency
with the Fake*Client implementations
* Extract DBusClientType into its own file
* Move --dbus-unstub-clients parsing into the same file so that the client name
strings are near the enum
* Add some simple unit tests for DBusThreadManager initialization

No functional changes.

BUG=644414
TEST=chromeos_unittests
TBR=peter@chromium.org

Review-Url: https://codereview.chromium.org/2338063002
Cr-Commit-Position: refs/heads/master@{#418569}

BUG=581865

Review-Url: https://codereview.chromium.org/2323993004
Cr-Commit-Position: refs/heads/master@{#418568}

This CL implements QuicHttpStream::GetLoadTimingInfo.

|dns_start| and |dns_end| are obtained in
QuicStreamFactory::Job::DoResolveHost and
DoResolveHostComplete. These two values are passed to
QuicChromiumClientSession's constructor.

|connect_start| and |connect_end| are obtained in
QuicChromiumClientSession::CrytoConnect() and when
handshake is confirmed.

|ssl_start| and |ssl_end| are the same as |connect_start|
and |connect_end| because QUIC always does encryption.

If a session is reused, the connect_timing fields should
all be null. This CL also sets
|socket_reused| field of LoadTimingInfo accordingly.

BUG=637051

Committed: https://crrev.com/5608fc1bd4f0a80b6d1996f3f4059f2efa0a0777
Review-Url: https://codereview.chromium.org/2324183002
Cr-Original-Commit-Position: refs/heads/master@{#417969}
Cr-Commit-Position: refs/heads/master@{#418567}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/567592da..c37ceeb3

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,littledan@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2339163002
Cr-Commit-Position: refs/heads/master@{#418566}

The test was considered flakey, but now it's always failing. Get
some new baselines to figure out if it's actually flakey.

TBR=senorblanco@chromium.org
BUG=627782

Review-Url: https://codereview.chromium.org/2332933002
Cr-Commit-Position: refs/heads/master@{#418565}

libFuzzer doesn't accept "\t", use "\x09" instead.

BUG=

TBR=ricea@chromium.org,eroman@chromium.org

Review-Url: https://codereview.chromium.org/2339913002
Cr-Commit-Position: refs/heads/master@{#418564}

This CL add null ptr checks in a few places that need them.

BUG=644644
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2335263002
Cr-Commit-Position: refs/heads/master@{#418563}

https://chromium.googlesource.com/skia.git/+log/53c02e015664..6ef6999017fe

$ git log 53c02e015..6ef699901 --date=short --no-merges --format='%ad %ae %s'
2016-09-14 mtklein GN: Android Vulkan support
2016-09-14 mtklein update derive_compile_bot_name() for GN_Android_Vulkan

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
TBR=djsollen@google.com

Review-Url: https://codereview.chromium.org/2339183002
Cr-Commit-Position: refs/heads/master@{#418562}

It has continued to fail:
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.10/builds/23657
http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=paint/invalidation/fixed-and-absolute-position-scrolled.html

BUG=636222
TBR=wangxianzhu@chromium.org
NOTRY=true

Review-Url: https://codereview.chromium.org/2341763002
Cr-Commit-Position: refs/heads/master@{#418561}

SequencedWorkerPool is being migrated to base/task_scheduler and there
is no equivalent to IsRunningSequenceOnCurrentThread() in
base/task_scheduler.

Developers should use SequenceChecker to verify that tasks run
sequentially. Unlike
SequencedWorkerPool::IsRunningSequenceOnCurrentThread(),
SequenceChecker works everywhere in Chrome (MessageLoop,
SequencedWorkerPool, base/task_scheduler...).

BUG=622400

Review-Url: https://codereview.chromium.org/2315303002
Cr-Commit-Position: refs/heads/master@{#418560}

https://pdfium.googlesource.com/pdfium.git/+log/2ca2da505ba7..89f8fa8694bb

$ git log 2ca2da505..89f8fa869 --date=short --no-merges --format='%ad %ae %s'
2016-09-14 dsinclair Remove unused code in CPDFXFA_Document

TBR=dsinclair@chromium.org

Review-Url: https://codereview.chromium.org/2338243002
Cr-Commit-Position: refs/heads/master@{#418559}

BUG=chromium:633253

Review-Url: https://codereview.chromium.org/2333123003
Cr-Commit-Position: refs/heads/master@{#418558}

When a text is wrapped during layout, the leading space of the
text can be collapsed and a line break is inserted instead of
the space. In this case, we need to restore the collapsed space
when we copy the text.

This CL handles the case that the below CL didn't cover:
https://codereview.chromium.org/2320533002/

In addition, while iterating through the DOM range, the below
case with the TextIteratorBehavior flag don't need to restore
the leading space.

* Running DumpRenderTree : TextIteratorForInnerText
* Searching text : TextIteratorDoesNotBreakAtReplacedElement
* Getting a plain text for copy & paste: TextIteratorEmitsImageAltText

BUG=318925
TEST=editing/pasteboard/restore-collapsed-space-for-copy.html

Review-Url: https://codereview.chromium.org/2325553002
Cr-Commit-Position: refs/heads/master@{#418557}

To achieve this we make a few changes:

1. We only register the next wakeup with the TimeDomain, rather than all
of them.
2. MoveReadyDelayedTasksToDelayedWorkQueue now registers the next
wakeup (if any).  Since it removes all canceled delayed tasks from the
front of the priority queue this has the effect of not scheduling
wakeups for cancelled tasks.
3. Tweaking the TaskQueueManager level delayed DoWork de-duplication
logic to only post a delayed DoWork if the task is meant to run before
any previously registered delayed DoWorks.

BUG=638542, 605718

Review-Url: https://codereview.chromium.org/2320403003
Cr-Commit-Position: refs/heads/master@{#418556}

Before this CL, setup.exe did not always persist histograms (e.g. when
launched with --rename-chrome-exe, when SetupSingleton acquisition
failed during an install or update).

With this CL, RAII is used to ensure that a setup.exe process always
persists histograms (except when the histogram storage directory does
not exist).

BUG=451546

Review-Url: https://codereview.chromium.org/2335313002
Cr-Commit-Position: refs/heads/master@{#418555}

SequencedWorkerPool is being migrated to base/task_scheduler and there
is no equivalent to IsRunningSequenceOnCurrentThread() in
base/task_scheduler.

Developers should use SequenceChecker to verify that tasks run
sequentially. Note: SequenceChecker::CalledOnValidSequence
is a no-op in non-DCHECK builds.

BUG=622400

Review-Url: https://codereview.chromium.org/2317253007
Cr-Commit-Position: refs/heads/master@{#418554}