GitLab

Review-Url: https://codereview.chromium.org/2545923005
Cr-Commit-Position: refs/heads/master@{#436184}

The wpt_github code imports libhttp2, which is not part of the
standard Python libraries (at least on Mac). Luckily, we have
a hermetic instance of it in depot_tools, so let's use that instead.

R=jeffcarp
BUG=

Review-Url: https://codereview.chromium.org/2548163002
Cr-Commit-Position: refs/heads/master@{#436183}

BUG=662644
TBR=zmo@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2550023002
Cr-Commit-Position: refs/heads/master@{#436182}

https://chromium.googlesource.com/external/khronosgroup/webgl.git/+log/4b93f82..3e235f7

BUG=
TEST=bots
TBR=kbr@chromium.org

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2541163008
Cr-Commit-Position: refs/heads/master@{#436181}

BUG=537054, 666061
TBR=zmo@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2548153002
Cr-Commit-Position: refs/heads/master@{#436180}

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/ca719be61d32..627b0d9726b5

$ git log ca719be61..627b0d972 --date=short --no-merges --format='%ad %ae %s'
2016-12-02 dtu Update Firefighter deployment scripts.
2016-12-02 aiolos Fix errors in chart_track and x_axis_track.
2016-12-02 eakuefner [Telemetry] Ensure that story display names are unique
2016-12-02 aiolos Revert of Make telemetry use the same chrome stable build as tracing/dashboard. (patchset #1 id:1 of https://codereview.chromium.org/2415683002/ )

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=catapult-sheriff@chromium.org

Review-Url: https://codereview.chromium.org/2546283002
Cr-Commit-Position: refs/heads/master@{#436179}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/6e549d18..cd7151a2

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,littledan@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2543423002
Cr-Commit-Position: refs/heads/master@{#436178}

By exposing several apis in input_device_settings.h and add new local pref for TouchScreenEnabled, we can disable touch screen events when backlights are forced off so that no screen UI events can be triggered and enable touch screen when stopping backlights forced off is called properly.

BUG=655388
BUG=633304
TEST=manual test on device, and add test coverage.
also test that this added behavior is compatible with toggle touchscreen shortcut
The shortcut induced in https://codereview.chromium.org/2467023004 is per user pref, backlights-forced-off related touch screen status is per device pref. The final hardware touchscreen status is determined by the rule: enabled_in_local_state && enabled_in_user_pref

Review-Url: https://codereview.chromium.org/2533373002
Cr-Commit-Position: refs/heads/master@{#436177}

Revert of Reland "Fix HTML5 video blurry" (patchset #3 id:40001 of https://codereview.chromium.org/2547683003/ )

Reason for revert:
I suspect this breaks https://build.chromium.org/p/chromium.gpu.fyi/builders/Win7%20Release%20%28AMD%29/builds/565
Error compiling shader: ERROR: 0:7: '[]' : Index expression must be constant

Original issue's description:
> Reland "Fix HTML5 video blurry"
>
> Original CL: https://codereview.chromium.org/2418173002/
>
> Revert CL: https://codereview.chromium.org/2463103002/
> https://codereview.chromium.org/2474073004
>
> Changes: Skip failed gpu pixel tests until baseline is created.
> Fix following failures in Win7 dbg
> RendererPixelTest/2.PremultipliedTextureWithBackground
> GLRendererPixelTest.TextureQuadBatching
> RendererPixelTest/0.PremultipliedTextureWithBackground
> GLRendererPixelTest.NonPremultipliedTextureWithBackground
> IntersectingQuadGLPixelTest/0.Y16VideoQuads
> VideoGLRendererPixelTest.TwoColorY16Rect
> IntersectingQuadGLPixelTest/1.Y16VideoQuads
>
> TBR=dalecurtis@chromium.org,ccameron@chromium.org,dpranke@chromium.org,junov@chromium.org
> BUG=615325
> CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
>
> Committed: https://crrev.com/60d375f8a6bd7b8c3e3abfd3771a228f3039bf62
> Cr-Commit-Position: refs/heads/master@{#436118}

TBR=ccameron@chromium.org,dalecurtis@chromium.org,dpranke@chromium.org,enne@chromium.org,junov@chromium.org,dongseong.hwang@chromium.org,dongseong.hwang@intel.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=615325

Review-Url: https://codereview.chromium.org/2544893006
Cr-Commit-Position: refs/heads/master@{#436176}

Without this fix, catapult roll is blocked (https://codereview.chromium.org/2547293002)
because CL https://codereview.chromium.org/2153513002/ changes story_set.stories
to be a property.

BUG=https://github.com/catapult-project/catapult/issues/2429
TBR=eakuefner@chromium.org

Review-Url: https://codereview.chromium.org/2552543002
Cr-Commit-Position: refs/heads/master@{#436175}

Revert of cc: Build Image to Region map during image meta-data generation. (patchset #6 id:100001 of https://codereview.chromium.org/2496283004/ )

Reason for revert:
Computing these image regions adds significant time to the critical path on image heavy content.  Let's re-land after addressing the performance.

BUG=670926

Original issue's description:
> cc: Build Image to Region map during image meta-data generation.
>
> During the discardable image meta-data generation phase, we build an
> Rtree to pull the set of images given a rect. This change adds a
> reverse lookup map to be built at the same time for querying the region
> for an image in a DisplayItemList.
>
> BUG=665266
> CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
>
> Committed: https://crrev.com/fc85c1aa0881047c4410cbedc1e4543bcf789a1f
> Cr-Commit-Position: refs/heads/master@{#432841}

TBR=vmpstr@chromium.org,khushalsagar@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=665266

Review-Url: https://codereview.chromium.org/2551583003
Cr-Commit-Position: refs/heads/master@{#436174}

This change allows tests to be created that exercise both
characteristic.readValue/writeValue and descriptor.readValue/writeValue.
script-tests's name determine what feature they are testing.  For example, a
test that wants to tests gatt operations on a descriptor can be named:

bluetooth/script-tests/descriptor/<>

then in bluetooth/descriptor/<>/ each of the gatt calls will be generated.

In addition and prep for this change, we are moving files around.  The
structure now is the following:

device
    gattserverdisconnected-event

service
   getCharacteristic
   getCharacteristics

server
    getPrimaryService
    getPrimaryServices
    connect
    disconnect

characterisitic
   startNotifications
   stopNotifications
   readValue
   writeValue
   getDescriptor
   getDescriptors
   notifications

BUG=668836
R=ortuno

Review-Url: https://codereview.chromium.org/2544513004
Cr-Commit-Position: refs/heads/master@{#436173}

Allow tests to override extension protocols so that tests can include
shared resources via chrome-extension://<id>/_test_resources/foo (which
maps to chrome/test/data/extensions/foo). This allows tests to include
utility files in a "#include" style fashion with e.g.
<script src="_test_resources/common_utility.js"></script>

This removes the need to duplicate a bunch of files between different
test extensions.  Looking longer term, this could also allow us to
remove a number of our chrome.test methods that are purely JS-based
(we could have them in a common "extension_test.js" file). This is
good for a number of reasons, outlined in the bug.

Set up the overrides and utilize it in the webnavigation API tests,
taking out the common framework.js file for a net savings of around
6k lines.

BUG=670741

Review-Url: https://codereview.chromium.org/2547523004
Cr-Commit-Position: refs/heads/master@{#436172}

R=ericrk@chromium.org
R=vmpstr@chromium.org
BUG=669214
BUG=628394
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2535153002
Cr-Commit-Position: refs/heads/master@{#436171}

Move standalone functions from note_taking_app_utils.* into
a singleton NoteTakingHelper class. The new class doesn't
store any state yet but will soon (specifically, it'll watch
for changes to the list of available apps).

BUG=633596

Review-Url: https://codereview.chromium.org/2526893003
Cr-Commit-Position: refs/heads/master@{#436170}

After crbug.com/620315 global_keyboard_shortcuts_mac.mm uses two different
shortcut tables: one for Cocoa and one for MacViews. Ensure that the test works
on both browser implementations.

BUG=620315

Review-Url: https://codereview.chromium.org/2535553002
Cr-Commit-Position: refs/heads/master@{#436169}

Remove useless class and struct forward declarations, and add
missing ones in blink header files. This is not the first time
such a cleanup is done for blink, but it should be the last as
we have now an up-and-running presubmit check.

BUG=662195
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2542203004
Cr-Commit-Position: refs/heads/master@{#436168}

Remove useless class and struct forward declarations, and add
missing ones in ppapi header files.

BUG=662195

Review-Url: https://codereview.chromium.org/2539033005
Cr-Commit-Position: refs/heads/master@{#436167}

This Cl:
1. Abstracts the calculation of intersection geometry from
IntersectionObserver. Calculating algorithms keep unchanged.
2. When a media is playing, periodically checks whether the
intersection with viewport has changed. If changed, notifies
WebMediaPlayerImpl.
3. Adds logic to start remoting when video consistently covers most
of the viewport for a certain time.

BUG=643964

Review-Url: https://codereview.chromium.org/2511143006
Cr-Commit-Position: refs/heads/master@{#436166}

gpu code shouldn't know about surfaces/display-compositor (except for
gpu-main which is responsible for setting everything up). And surfaces
should not know about gpu code. The ws (or any other parts of mus) should
know about either gpu or surfaces.

BUG=none
TBR=sky@ for services/ui/DEPS

Review-Url: https://codereview.chromium.org/2546123002
Cr-Commit-Position: refs/heads/master@{#436165}

This patch is for code health, it only modifies the JSDocs to add
template types to fromTarget calls on the SDKModels, so the developer
does not need to explicitly cast them.

R=lushnikov
BUG=None

Review-Url: https://codereview.chromium.org/2543633009
Cr-Commit-Position: refs/heads/master@{#436164}

Cr-Commit-Position: refs/heads/master@{#436163}

Refactor Content-Range response header parsing into http_util so that
it's easier for other components to depend on it without needing to go
through HttpResponseHeaders.

BUG=670913

Review-Url: https://codereview.chromium.org/2545213002
Cr-Commit-Position: refs/heads/master@{#436162}

BUG=643746

Review-Url: https://codereview.chromium.org/2537423004
Cr-Commit-Position: refs/heads/master@{#436161}

Merge internal change: 139517817
Merge internal change: 139517817

BUG=

Review-Url: https://codereview.chromium.org/2551603002
Cr-Commit-Position: refs/heads/master@{#436160}

Ruthlessly borrowed from https://codereview.chromium.org/2547273002/ by
Jacob Dufault <jdufault@chromium.org> and simplified :). From that CL's
description:

Locally, this brings first paint time from 1000ms to 500ms.

R=jdufault@chromium.org,xiaoyinh@chromium.org
BUG=670914
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2529293015
Cr-Commit-Position: refs/heads/master@{#436159}

BUG=none

Review-Url: https://codereview.chromium.org/2550563002
Cr-Commit-Position: refs/heads/master@{#436158}

We query the autohide taskbar state when a window is maximized to ensure
that we leave just enough space at the edge so that the taskbar shows up
when the mouse is moved there.

Once we find the taskbar via the SHAppBarMessage API we also check if the
taskbar is a topmost window. While this works in most cases, I found cases
where in the taskbar loses the topmost style before the window is resized
away from fullscreen. This can presumably happen if there are other
activation changes going on at the same time, or if the machine is slow.

I think it is safe to remove the topmost style check for the taskbar. In
any case we also check the monitor where the taskbar is showing up to
ensure that they are the same. Also this code only executes when a window
is maximized. From my testing this works correctly in all cases.

Added code to register for shell fullscreen notifications via SHAppBarMessage in hwnd_message_handler.cc.
We call SendFrameChanged() if we are in maximized window and a window switched away from fullscreen

BUG=152241

Review-Url: https://codereview.chromium.org/2542533002
Cr-Commit-Position: refs/heads/master@{#436157}

BUG=669256
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2540023002
Cr-Commit-Position: refs/heads/master@{#436156}

The "Just a sec" page looks redundant if we already show
"This may take up to a minute or so..." loading page,
from users' perspective.
Then, skip to show it.

BUG=670606
BUG=b/33163416
TEST=Ran bots.
TEST=Manually run opt-in flow.
     Accept ToS, and made sure no "Just a sec" page before "SIGN IN" page.
TEST=Manually run opt-in flow.
     Accept ToS. While "SIGN IN" is shown, log-out from ChromeOS account.
     Re-login. Then "Just a sec" is shown shortly just before "SIGN IN" page.
TEST=Manually run opt-in flow.
     Accept ToS. While "SIGN IN" is shown, disable network.
     Click "SIGN IN" and show error page. Re-establish the network.
     Click "TRY AGAIN" and made sure "Just a sec" is shown shortly just before
     "SIGN IN" page is re-shown.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2545793003
Cr-Commit-Position: refs/heads/master@{#436155}

This is a prereq to https://codereview.chromium.org/2464233002 which
will from now on reset BrowserThread globals associated with destroyed
BrowserThreadImpls and thus makes DCHECK_CURRENTLY_ON fail after it
was.

BUG=653916

Review-Url: https://codereview.chromium.org/2549623006
Cr-Commit-Position: refs/heads/master@{#436154}

[DevTools] Mark inspector/sources/debugger-pause/debugger-pause-in-internal.html as NeedsManualRebaseline.

BUG=109362

Review-Url: https://codereview.chromium.org/2548093002
Cr-Commit-Position: refs/heads/master@{#436153}

BUG=666732

Review-Url: https://codereview.chromium.org/2547943003
Cr-Commit-Position: refs/heads/master@{#436152}

Out-of-flow descendants need to know what their static position would
have been. This is because abspos spec defaults to static position if
TLBL are not specified.

Oof descendant's dimensions are not known during propagation, only
it's logical top/left offset. The offset is propagated as NGCorner,
which is a PhysicalOffset + vertex location (topLeft, bottomLeft, etc)

Next step will be positioning of oof descendants.

BUG=635619

Review-Url: https://codereview.chromium.org/2540653003
Cr-Commit-Position: refs/heads/master@{#436151}

The tasks aren't getting picked up because it defaults to 6 and the
swarming bots only have 1 available. (No clue why; I'll look at that later.)
This should at least get them running, albeit really slowly.

BUG=534815, 664190

Review-Url: https://codereview.chromium.org/2544223003
Cr-Commit-Position: refs/heads/master@{#436150}

When computing min-content and max-content of the content-sized tracks
we are using the marginIntrinsicLogicalWidthForChild function, which
uses the grid's writing-mode to determine wether to use the child's
margin width or height. This is not correct when the grid item is
orthogonal.

This patch changes how we compute the tracks width so we use always
the item's marginLogicalWidth, which depends only on its own writing
mode.

BUG=670642

Review-Url: https://codereview.chromium.org/2543193002
Cr-Commit-Position: refs/heads/master@{#436149}

We would like to have all Chrome clients use a single service-side
CompositorFrameSink implementation as an incremental step towards pulling the
display compositor into the gpu process. This CL extract non-mojo-specific
code from GpuCompositorFrameSink in services/ui to CompositorFrameSinkSupport
in a central place: cc/surfaces that can be used by Chrome today. Individual
clients can transition to mojo after we carefully measure the performance
impact of the transition.

BUG=668126, 657959
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2543373002
Cr-Commit-Position: refs/heads/master@{#436148}

Fetch requires [1] that "the value pairs to iterate over are the
return value of running sort and combine with the header list", which
is to say we don't simply iterate over the internal data of Headers
but make a sorted (and combined) copy [2]. This manifested in some
failing imported cache tests that were sensitive to the order.

This CL implements making a copy and sorting the list for iteration;
it does not implement combining[3]. So not perfect but an incremental
improvement.

[1] https://fetch.spec.whatwg.org/#headers-class
[2] https://fetch.spec.whatwg.org/#concept-header-list-sort-and-combine
[3] https://fetch.spec.whatwg.org/#concept-header-value-combined

BUG=667376,670439
R=yhirano@chromium.org

Review-Url: https://codereview.chromium.org/2542073005
Cr-Commit-Position: refs/heads/master@{#436147}

When the tab's RenderWidgetHostView is nullptr, we cannot and should not select any
RenderWidgetHosts for a drag destination. Therefore, in response to draggingEntered
we should return no operation.

This CL will fix that issue as well as making RenderWidgetHostInputEventRouter::GetRenderWidgetHostAtPoint()
handle nullptr |root_view| by returning nullptr.

BUG=670645

Review-Url: https://codereview.chromium.org/2547213002
Cr-Commit-Position: refs/heads/master@{#436146}

BUG=653350

Review-Url: https://codereview.chromium.org/2543403002
Cr-Commit-Position: refs/heads/master@{#436145}