GitLab

InputMethodBridge:
- Implements ui::TextInputClient interface, and receives IME results (e.g. composition text) from ui::InputMethod and forwards them to UI (e.g. a text field).
- Also receives a request like 'CancelComposition' from the UI and forwards it to ui::InputMethod.

Original review: http://codereview.chromium.org/8576005/ (PatchSet #1-8, Comment #1-24)

BUG=97261
TEST=see part 3 of 3.

Review URL: http://codereview.chromium.org/8687027

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113131 0039d316-1c4b-4281-b951-d872f2087c98

BUG=102576
TEST=None


Review URL: http://codereview.chromium.org/8741022

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113130 0039d316-1c4b-4281-b951-d872f2087c98

BUG=
TEST=No visible change.


Review URL: http://codereview.chromium.org/8790006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113129 0039d316-1c4b-4281-b951-d872f2087c98

Adding in metrics for GAIA photo info. Also, fixing avatar logging to only log when the user changes their photo. Currently it logs any time name OR avatar are updated. Now it should only do it for actual avatar changes.

BUG=93825,106134
TEST=none

Review URL: http://codereview.chromium.org/8790010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113128 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none


Review URL: http://codereview.chromium.org/8800026

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113127 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=On linux you should see a dangerous file type warning when downloading an exe.


Review URL: http://codereview.chromium.org/8806021

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113126 0039d316-1c4b-4281-b951-d872f2087c98

NSS implicitly before calling the NSS function
SSL_ClearSessionCache.

Remove the stale comment that
SSLClientSocketNSS::ClearSessionCache is only for tests.

R=mattm@chromium.org
BUG=105431
TEST=net_unittests --gtest_filter=SSLClientSocketNSSTest.ClearSessionCache

Review URL: http://codereview.chromium.org/8816002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113125 0039d316-1c4b-4281-b951-d872f2087c98

This is another stupid mistake of mine while moving spellchecker-related context-menu to the SpellingMenuObserver class. (As written in r111881 <http://crrev.com/111881>, the original code shows this separator only when |misspelled_word| is not empty.) This change shows this separator only when this |misspelled_word| is not empty.

BUG=105926
TEST=manual

Review URL: http://codereview.chromium.org/8806006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113124 0039d316-1c4b-4281-b951-d872f2087c98

R=sail@chromium.org,estade@chromium.org
BUG=98928
TEST=Focus starts on user name.  When you press shift tab you land on "Learn
more" link.  When you press enter on that link and press tab again, you're still
on the same link (that now reads "Hide").


Review URL: http://codereview.chromium.org/8502042

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113123 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/8742001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113122 0039d316-1c4b-4281-b951-d872f2087c98

BUG=98110


Review URL: http://codereview.chromium.org/8539045

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113121 0039d316-1c4b-4281-b951-d872f2087c98

Also simplifies some of the parsing code, adds type validation, brings
the WiFi security parsing up to spec, and improves the unit tests for
wifi so that they all verify the property_map_ fields (the only ones
actually used to configure the network).  Also fixed a general parser
problem where certificates wouldn't be parsed if network configs were.

BUG=chromium-os:23476 chromium-os:23477
TEST=manual import of ONC file with openvpn network, unit_tests

Review URL: http://codereview.chromium.org/8759014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113120 0039d316-1c4b-4281-b951-d872f2087c98

BUG=106060
TEST=none


Review URL: http://codereview.chromium.org/8779001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113119 0039d316-1c4b-4281-b951-d872f2087c98

Revert 113015 - speculative revert to see if this fixes the interactive test breakage
Remove OnMessageReceived that was using internal content IPCs in a chrome test. Dispatch the IPC in RenderViewHost instead of TabContents to solve this (it's only used by tests anyways). Remove test_utils methods that weren't being used.

BUG=98716
Review URL: http://codereview.chromium.org/8801002

TBR=jam@chromium.org
Review URL: http://codereview.chromium.org/8817007

TBR=sail@chromium.org
Review URL: http://codereview.chromium.org/8821005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113118 0039d316-1c4b-4281-b951-d872f2087c98

Revert 113112 - Revert 113103 - Changes the visibility of the 'mobile' node based on whether there is a node on the sync side.

BUG=102714
TEST=none

Review URL: http://codereview.chromium.org/8786006

TBR=sky@chromium.org
Review URL: http://codereview.chromium.org/8819008

TBR=sky@chromium.org
Review URL: http://codereview.chromium.org/8818004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113117 0039d316-1c4b-4281-b951-d872f2087c98

Recent large increases were webkit roll (crbug.com/106167) and sfntly
roll (crbug.com/106515)

BUG=106515,106167
TEST=none
TBR=cmp@chromium.org

Review URL: http://codereview.chromium.org/8817008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113116 0039d316-1c4b-4281-b951-d872f2087c98

green tree. TBRing since this is a revert.

R=sail@chromium.org, jwd@chromium.org
BUG=87658
TEST=none

Review URL: http://codereview.chromium.org/8815005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113115 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113114 0039d316-1c4b-4281-b951-d872f2087c98

This pulls in the following Native Client changes:

r7358: (mcgrathr) Disable dynamic_load_test on arm hw
r7359: (jvoung) Make the timestamps reading/writing match in download_toolchain.py.
r7360: (mseaborn) Tidy: Remove sel_ldr-inl.c and sel_util-inl.c
r7361: (pdox) Convert pnacl_abi.o into pnacl_abi.bc (a bitcode stub).
r7362: (mcgrathr) Need to excise -faddress-sanitizer now

BUG=none
TEST=nacl_integration

Review URL: http://codereview.chromium.org/8805032

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113113 0039d316-1c4b-4281-b951-d872f2087c98

Revert 113103 - Changes the visibility of the 'mobile' node based on whether there is a node on the sync side.

BUG=102714
TEST=none

Review URL: http://codereview.chromium.org/8786006

TBR=sky@chromium.org
Review URL: http://codereview.chromium.org/8819008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113112 0039d316-1c4b-4281-b951-d872f2087c98

This should only show up for apps which have the appNotifications permission
in their manifest.

BUG=106268
TEST=Install an app with the appNotifications permission - the icon on the
NTP should get a 'Disable Notifications' context menu entry which if checked
will keep the notification bubbles from appearing over the app's icon.

Review URL: http://codereview.chromium.org/8785016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113111 0039d316-1c4b-4281-b951-d872f2087c98

Remove OnMessageReceived that was using internal content IPCs in a chrome test. Dispatch the IPC in RenderViewHost instead of TabContents to solve this (it's only used by tests anyways). Remove test_utils methods that weren't being used.

BUG=98716
Review URL: http://codereview.chromium.org/8801002

TBR=jam@chromium.org
Review URL: http://codereview.chromium.org/8817007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113110 0039d316-1c4b-4281-b951-d872f2087c98

BUG=88782
TEST=none

Review URL: http://codereview.chromium.org/8771031

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113109 0039d316-1c4b-4281-b951-d872f2087c98

OriginBoundCertService::GetOriginBoundCert takes a vector of requested cert
types in order of preferrence and will return or generate one of an acceptable
type.

BUG=88782
TEST=net_unittests, unit_tests

Review URL: http://codereview.chromium.org/8662036

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113108 0039d316-1c4b-4281-b951-d872f2087c98

We initially went with a "disable notifications" menu item, but recently talked
about inverting this and having "enable notifications" or "allow notifications"
instead. I'm checking these in separately to make the translation deadline
so we have the option to change before the M17 release.

BUG=106268
TEST=none

TBR=finnur@chromium.org

Review URL: http://codereview.chromium.org/8801032

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113107 0039d316-1c4b-4281-b951-d872f2087c98

BUG=105440
TEST=manual

Review URL: http://codereview.chromium.org/8820002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113105 0039d316-1c4b-4281-b951-d872f2087c98

BUG=105110
TEST=Ensure that when Chrome on Windows creates a desktop icon for a new Profile, the icon image has the user avatar in it. Ensure that changing the Avatar changes the image in the icon.
TBR=rsesek
Review URL: http://codereview.chromium.org/8785006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113104 0039d316-1c4b-4281-b951-d872f2087c98

BUG=102714
TEST=none

Review URL: http://codereview.chromium.org/8786006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113103 0039d316-1c4b-4281-b951-d872f2087c98

Move CapturingNetLog out of net project, as it's no longer
used except in tests.

Review URL: http://codereview.chromium.org/8567011

TBR=mmenke@chromium.org
Review URL: http://codereview.chromium.org/8822002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113100 0039d316-1c4b-4281-b951-d872f2087c98

TBR=pfeldman
Review URL: http://codereview.chromium.org/8801036

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113098 0039d316-1c4b-4281-b951-d872f2087c98

Also moves a bunch of mask images off the theme provider alltogether, which are now shared across profiles via gfx::Image.

BUG=106060
TEST=none


Review URL: http://codereview.chromium.org/8786003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113097 0039d316-1c4b-4281-b951-d872f2087c98

Update pepper_16 to rev 1396 and pepper_17 to rev 112997

BUG=None
TEST=None


Review URL: http://codereview.chromium.org/8806024

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113096 0039d316-1c4b-4281-b951-d872f2087c98

ui::InputMethod: 
- An interface similar to views::InputMethod, but does not have Has neither Views nor Aura dependencies. 

ui::InputMethodIBus 
- Port of views::InputMethodIBus. Has neither Views nor Aura dependencies. 

Original review: http://codereview.chromium.org/8576005/ (PatchSet #1-8, Comment #1-24)

BUG=97261
TEST=see part 3 of 3.


Review URL: http://codereview.chromium.org/8659033

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113095 0039d316-1c4b-4281-b951-d872f2087c98

BUG=91241
TEST=

Review URL: http://codereview.chromium.org/8742008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113094 0039d316-1c4b-4281-b951-d872f2087c98

BUG=105129
TEST=PanelTest.PanelOpenLarge should no longer run on Aura + chromeos


Review URL: http://codereview.chromium.org/8632013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113093 0039d316-1c4b-4281-b951-d872f2087c98

BUG=104396
TEST=more tests passes in interactive_ui_tests passes on aura


Review URL: http://codereview.chromium.org/8808001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113092 0039d316-1c4b-4281-b951-d872f2087c98

xinput1_3.dll is a Microsoft DirectX redist file. Unfortunately it's shipped
without /NXCOMPAT and /DYNAMICBASE.

This DLL is only be loaded when the user interacts with a gamepad.

BUG=79050

Review URL: http://codereview.chromium.org/8806020

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113091 0039d316-1c4b-4281-b951-d872f2087c98

Add abstract GetGroupsToChange() method to ModelChangingSyncerCommand.
Use that to figure out which worker threads to post work on (instead of
posting on all of them).

Implement GetGroupsToChange() for each ModelChangingSyncerCommand.

Add GetEnabledGroups() and GetEnabledGroupsWithConflicts() functions to SyncSession.

Key unapplied updates index by type for ApplyUpdatesCommand.

Make the abstract methods of ModelChangingSyncerCommand protected.

Add HasCustomGroupsToChange() method to ModelChangingSyncerCommand and have all
commands default to returning false to track down the perf regression introduced
by the last couple of times this was landed (112178, 112815).

BUG=97832
TEST=

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=112178

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=112743

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=112815

Review URL: http://codereview.chromium.org/8637006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113090 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113089 0039d316-1c4b-4281-b951-d872f2087c98

1) Wait for extension popup to load
2) Wait for extensions hosts to load in WaitForAllViews
3) Allow more than one browser action to be visible in views.
4) Add explicit IsPageActionVisible method
BUG=93571
TEST=none

Review URL: http://codereview.chromium.org/8804011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113088 0039d316-1c4b-4281-b951-d872f2087c98