- 23 Jan, 2019 40 commits
-
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/828acb39df5f..5313c8a89964 git log 828acb39df5f..5313c8a89964 --date=short --no-merges --format='%ad %ae %s' 2019-01-23 syoussefi@chromium.org Implement EGL_KHR_fence_sync and EGL_KHR_wait_sync Created with: gclient setdep -r src/third_party/angle@5313c8a89964 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=syoussefi@chromium.org Change-Id: I546e9f622b185ca263aaf0d4b1d3b3c85aa0cffa Reviewed-on: https://chromium-review.googlesource.com/c/1429500Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#625106}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/0550ef03..2307cc4b Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I3b6e9cd8b623e5189a256b34242bcb29029b93ec Reviewed-on: https://chromium-review.googlesource.com/c/1429384Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#625105}
-
Jon Napper authored
Added a predictor class for the new NN classifier in AssistRanker. This makes it possible to use downloadable unquantized NN classifiers for inferencing. Bug: 907727 Change-Id: Ib1e5647e3792f10757c17968a6b0b9b198a8d620 Reviewed-on: https://chromium-review.googlesource.com/c/1399768 Commit-Queue: Jon Napper <napper@chromium.org> Reviewed-by:
Charles . <charleszhao@chromium.org> Cr-Commit-Position: refs/heads/master@{#625104}
-
Danan S authored
Bug: 923575 Change-Id: I9e11fb01e3f6914c58a3f2204b2c617f6d20adda Reviewed-on: https://chromium-review.googlesource.com/c/1423353Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Commit-Queue: Danan S <danan@chromium.org> Cr-Commit-Position: refs/heads/master@{#625103}
-
Matt Falkenhagen authored
This enables the variations header to be added to the request, and other modifications by the embedder. Basically it looks like any network request should go through throttles. Bug: 923247 Change-Id: I7cb2d3a7edfff866487814884e0b44f4000dbca5 Reviewed-on: https://chromium-review.googlesource.com/c/1424098 Commit-Queue: Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Josh Karlin <jkarlin@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#625102}
-
Hirokazu Honda authored
VEA unittest verifies VEA's encoding content by 1. decode content by FFmepgVideoDecoder 2. compare it with the original VideoFrame and computes SSIM 3. check the SSIM less than or equal to the predetermined threshold, 10.0. VEA unittest turns on this verifitcation by --verify_all_output and one of test case parameters. This verification was always disabled on Chrome OS by setting --verify_all_output false because of https://crbug.com/694131. I think the bug is already fixed. We can re-enable the verification on Chrome OS now by default. TBR=kcwu@chromium.org Bug: 923762 Test: VEA unittest on eve Change-Id: I597346a9ecd114ccc37ebde1ab284b97103a6e4f Reviewed-on: https://chromium-review.googlesource.com/c/1429307Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#625101}
-
Alexandre Courbot authored
posix_memalign() returns an error value when it fails, but that value is not forwarded to the user despite being valuable to understand what the underlying problem of a failed allocation is. Make sure to display the error code. Chrome OS. Bug: 918509 Test: Checked that software video decoding was still working on Change-Id: I508d6cc6332a1a5c29e8f3cece56272969e99dcc Reviewed-on: https://chromium-review.googlesource.com/c/1424108 Commit-Queue: Alexandre Courbot <acourbot@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#625100}
-
James Zern authored
minor encoder speedups and roll up to pick up local fuzzer cherry-pick Bug: 922319 Change-Id: I2c8be4423aab86c406c3d4d2848950178337da3c Reviewed-on: https://chromium-review.googlesource.com/c/1412021Reviewed-by:
Urvang Joshi <urvang@chromium.org> Commit-Queue: James Zern <jzern@google.com> Cr-Commit-Position: refs/heads/master@{#625099}
-
Dominic Farolino authored
This CL gates Priority Hints behind an origin trial. Note, the preload scanner must know about the status of the Priority Hints origin trial in its ExecutionContext, and since it has no access to an EC itself, this CL adds a priority_hints_origin_trial_enabled flag in a few higher-level classes that create the preload scanner, so that the necessary information can be passed in. I2E: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/jpeSdM897Xw R=kinuko@chromium.org, kouhei@chromium.org, yhirano@chromium.org, yoavweiss@chromium.org Bug: 821464 Change-Id: I767cee02cb1797c35d792c1682d5414fa56a0a20 Reviewed-on: https://chromium-review.googlesource.com/c/1426439 Commit-Queue: Dominic Farolino <domfarolino@gmail.com> Reviewed-by:
Yoav Weiss <yoavweiss@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#625098}
-
Matt Falkenhagen authored
This changes the DataSaverForWorkerBrowserTest //chrome test to use the //chrome test data directory. Before it was using both //content and //chrome and therefore failing when a file of the same name existed in both directories. Bug: 901082, 922291 Change-Id: Ibf3982750ba65f1fd9f8b31fc6f5583e08fc4ff2 Reviewed-on: https://chromium-review.googlesource.com/c/1424520 Commit-Queue: Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Josh Karlin <jkarlin@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#625097}
-
Patrick Noland authored
******************************Resource Sizes Diff****************************** Specifics: +66,344 bytes main lib size +496,348 bytes main dex size +804,184 bytes normalized apk size InstallSize: +310,866 bytes APK size +891,594 bytes Estimated installed size (Android Go) +2,316,112 bytes Estimated installed size InstallBreakdown (+2,314,705 bytes): +3,030 bytes unwind_cfi (dev and canary only) size +2,880 bytes Non-compiled Android resources size +66,344 bytes Native code size +648 bytes Package metadata size +2,223,527 bytes Java code size +18,276 bytes Compiled Android resources size Dex: +2,527 entries fields +3,561 entries methods +810 entries types +1,798 entries strings Change-Id: Ibcc5605e04b8ffb0bf7bcedc41c6224401caa043 Reviewed-on: https://chromium-review.googlesource.com/c/1427458Reviewed-by:
Sky Malice <skym@chromium.org> Commit-Queue: Patrick Noland <pnoland@chromium.org> Cr-Commit-Position: refs/heads/master@{#625096}
-
Kyle Horimoto authored
This is in preparation for a future CL which will call EstablishConnection() with different URLs. Note that as part of this CL, I rearranged parameters since pointers should be passed as the last parameter to function calls. Bug: 917855 Change-Id: I074159af43715b8f65c4cb795cee7645abdc1542 Reviewed-on: https://chromium-review.googlesource.com/c/1428600Reviewed-by:
Jeremy Klein <jlklein@chromium.org> Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#625095}
-
Tsuyoshi Horo authored
Before this CL, CreateRedirectInfo() in signed_exchange_loader.cc doesn't set redirect_info.new_referrer correctly. So document.referrer was always empty string after clicking a link of signed exchange. After this CL, CreateRedirectInfo() returns a RedirectInfo with new_referrer, so document.referrer will be set correctly. This CL introduces network::ResourceRequest argument in NavigationLoaderInterceptor::MaybeCreateLoaderForResponse(), PrefetchURLLoader, SignedExchangePrefetchHandler and SignedExchangeLoader. This value will be used to compute a correct RedirectInfo while handling the synthesized redirect for signed exchange. This CL uses "ignoreErrors" flag in generate-test-sxgs.sh while creating invalid signed exchange files. This flags was introduces by this change in webpackage repository. https://github.com/WICG/webpackage/commit/d3352199e0a074ef0ce4390232b861560d061425 Bug: 920905 Change-Id: I52a302d22c375b776874c996638b409cdcba8a9c Reviewed-on: https://chromium-review.googlesource.com/c/1415245Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Kunihiko Sakamoto <ksakamoto@chromium.org> Commit-Queue: Tsuyoshi Horo <horo@chromium.org> Cr-Commit-Position: refs/heads/master@{#625094}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/325778b8884b..24120c2a32c6 git log 325778b8884b..24120c2a32c6 --date=short --no-merges --format='%ad %ae %s' 2019-01-23 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader c3bea8720a83..4806a9be530f (1 commits) Created with: gclient setdep -r src/third_party/skia@24120c2a32c6 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=djsollen@chromium.org Change-Id: Ib05d99182965833b90aa6e23f0661b0c3338dec5 Reviewed-on: https://chromium-review.googlesource.com/c/1429382Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#625093}
-
Qingsi Wang authored
TBR=thestig@chromium.org Bug: 899310, 905422 Change-Id: I5ea07adb3d3241af2f0056299bdd4b5b7b0d479a Reviewed-on: https://chromium-review.googlesource.com/c/1367366 Commit-Queue: Qingsi Wang <qingsi@google.com> Reviewed-by:
Eric Orth <ericorth@chromium.org> Reviewed-by:
Martin Šrámek <msramek@chromium.org> Cr-Commit-Position: refs/heads/master@{#625092}
-
Yuzu Saijo authored
This CL changes the condition of enqueueing image loading microtask so that the task would not be enqueued when V8 context is destroyed. When V8 memory is forcibly purged with OomIntervention v2, document might be active but the V8 context is not there. Since ImageLoader::Task's constructor ensures the existence of script_state, we would not like to create the task from the start. Change-Id: I1bc47f4e23107642f14c1c7b093da6f2f66c7c28 Reviewed-on: https://chromium-review.googlesource.com/c/1426342 Commit-Queue: Yuzu Saijo <yuzus@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#625091}
-
Wez authored
SO_KEEPALIVE was not supported by Fuchsia's netstack, resulting in log- spam. Now that it is supported, we can enable it again. This reverts commit e4613270. Bug: 758706 Change-Id: I187b124d4ae387888ddcab357d4c6f6709e0efbd Reviewed-on: https://chromium-review.googlesource.com/c/1423921Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#625090}
-
sangwoo.ko authored
During event dispatching, tab strip wasn't checking closing tabs. So, if users middle clicks tab multiple times, events fired when it's closing won't be delivered to the tab. This makes it slow to close multiple tabs. Bug: 920902 Change-Id: I4ba7159ee52d9a82655626e504cbdc543c5b40a9 Reviewed-on: https://chromium-review.googlesource.com/c/1414743 Commit-Queue: Sang Woo Ko <sangwoo108@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#625089}
-
Kinuko Yasuda authored
This reverts commit a72c20e4. Reason for revert: broke ProcessMetricsTest.GetChildOpenFdCount on Mac 10 https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.10%20Tests/38668 https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.10%20Tests/38669 Original change's description: > Mac: Record via metrics the number of open FDs and the soft FD limit. > > The histograms already exist on Linux, CrOS, and Android, so this simply > wires up the values for macOS. > > In addition, this enables the FD count column in the Task Manager, since > the data are now readily available. > > Bug: 714614 > Change-Id: I05f8063e8d89d3c6cdc68062bf4e591d3af9559c > Reviewed-on: https://chromium-review.googlesource.com/c/1423339 > Reviewed-by: Ahmed Fakhry <afakhry@chromium.org> > Reviewed-by: Nico Weber <thakis@chromium.org> > Reviewed-by: Mark Mentovai <mark@chromium.org> > Commit-Queue: Robert Sesek <rsesek@chromium.org> > Cr-Commit-Position: refs/heads/master@{#624881} TBR=thakis@chromium.org,afakhry@chromium.org,rsesek@chromium.org,mark@chromium.org Change-Id: Ic5076dc83b850c28059265de99609e55d86a53d4 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 714614 Reviewed-on: https://chromium-review.googlesource.com/c/1429303Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#625088}
-
Findit authored
This reverts commit 41e54be1. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 624994 as the culprit for flakes in the build cycles as shown on: https://findit-for-me.appspot.com/waterfall/flake/flake-culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vNDFlNTRiZTFkOTIzMzUzZjcyNDkwZjE5YTE1ZTczZWIwOTI0OGEzOAw Sample Failed Build: https://ci.chromium.org/buildbot/chromium.mac/Mac10.13%20Tests/9168 Sample Failed Step: unit_tests on (none) GPU on Mac Sample Flaky Test: SearchSuggestServiceTest.RequestsFreezeOnEmptyResponse Original change's description: > [NTP] Cap search suggestion impressions > > The parameters for capping suggestions impressions are provided as part > of the update proto. Read and update the local pref on each fetch. Use > these prefs to determine if the impression cap has been reach or if > fetching is frozen due to an empty response. > > Bug: 904565 > Change-Id: Ib5539a99f18e9da2ac1223ecc7aff65cb909bca8 > Reviewed-on: https://chromium-review.googlesource.com/c/1395188 > Commit-Queue: Kyle Milka <kmilka@chromium.org> > Reviewed-by: Kristi Park <kristipark@chromium.org> > Cr-Commit-Position: refs/heads/master@{#624994} Change-Id: I73c18a94545e84ee6eb753d3a4643cc55ea32080 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 904565, 924415 Reviewed-on: https://chromium-review.googlesource.com/c/1429622 Cr-Commit-Position: refs/heads/master@{#625087}
-
Kinuko Yasuda authored
This reverts commit 0e375fb8. Reason for revert: Suspected that this broke compile on win https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/win-rel/9908 https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/win-rel/9909 Original change's description: > media/gpu/VEA unittest: Verify encoded content on Chrome OS by default > > VEA unittest verifies VEA's encoding content by > 1. decode content by FFmepgVideoDecoder > 2. compare it with the original VideoFrame and computes SSIM > 3. check the SSIM less than or equal to the predetermined threshold, 10.0. > > VEA unittest turns on this verifitcation by --verify_all_output and one of test > case parameters. This verification was always disabled on Chrome OS by setting > --verify_all_output false because of https://crbug.com/694131. I think the bug > is already fixed. We can re-enable the verification on Chrome OS now by default. > > Bug: 923762 > Test: VEA unittest on eve > Change-Id: I57f2b62b42e86cba59bb8de2bdfdf6a595a13e87 > Reviewed-on: https://chromium-review.googlesource.com/c/1424099 > Commit-Queue: Hirokazu Honda <hiroh@chromium.org> > Reviewed-by: David Staessens <dstaessens@chromium.org> > Cr-Commit-Position: refs/heads/master@{#625071} TBR=kcwu@chromium.org,hiroh@chromium.org,dstaessens@chromium.org Change-Id: I2dcd07a9e45ef7608d01990179741458f221ec55 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 923762 Reviewed-on: https://chromium-review.googlesource.com/c/1428627Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#625086}
-
Dan Beam authored
Fix an accidental top border on the first row of Autofill settings section. It was there but not particularly visible in light mode. I originally thought the default separator color was GM2 GG 700 because I started with downloads and theres a special separator color there (between file icon and download details). This change makes Settings and Extensions (details view) look much much better: https://imgur.com/a/xvrYvc8 R=dpapad@chromium.org BUG=883049 Change-Id: I6a50ffb6cc1f35f22f1b240db8a18c32b4692568 Reviewed-on: https://chromium-review.googlesource.com/c/1428561 Commit-Queue: Dan Beam <dbeam@chromium.org> Auto-Submit: Dan Beam <dbeam@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#625085}
-
Steve Anton authored
Bug: webrtc:10159 Change-Id: I73d9521fcf9cc3ad8aab92d1ad809845fc5f136c Reviewed-on: https://chromium-review.googlesource.com/c/1428340 Auto-Submit: Steve Anton <steveanton@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Steve Anton <steveanton@chromium.org> Cr-Commit-Position: refs/heads/master@{#625084}
-
gs://chrome-supersizeEric Stevenson authored
In addition, the official build reports.json format is updated to be more similar to milestone reports. The reports are also now uploaded as world readable. Screenshot of the new form: http://shortn/_oNsm0MU94h Bug: 919213 Change-Id: I9d5b04bce2c541a6011456bbabb9adf7b6fa3e2a Reviewed-on: https://chromium-review.googlesource.com/c/1427040 Auto-Submit: Eric Stevenson <estevenson@chromium.org> Reviewed-by:
agrieve <agrieve@chromium.org> Commit-Queue: agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#625083}
-
Yuki Awano authored
This reverts commit dfa13280. Reason for revert: This will be punted to M74. Original change's description: > Enable ChromeVox developer options by default > > options UI are shown by default. > > Bug: 914203 > Test: Open ChromeVox options page and confirm that ChromeVox developer > Change-Id: I09ebc897cc985523a4c73ce05132b09e755c8cd5 > Reviewed-on: https://chromium-review.googlesource.com/c/1399692 > Reviewed-by: David Tseng <dtseng@chromium.org> > Commit-Queue: Yuki Awano <yawano@chromium.org> > Cr-Commit-Position: refs/heads/master@{#621499} TBR=dtseng@chromium.org,yawano@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 914203 Change-Id: I8e42c9fa36b02767d11ed82457001562a0c7fd52 Reviewed-on: https://chromium-review.googlesource.com/c/1429319Reviewed-by:
Yuki Awano <yawano@chromium.org> Commit-Queue: Yuki Awano <yawano@chromium.org> Cr-Commit-Position: refs/heads/master@{#625082}
-
David Black authored
The PowerManagerClient::Observer::PowerChanged event fires periodically, not only with updates as was previously assumed. This causes the Assistant service to restart LibAssistant too eagerly which has a side effect of closing Assistant UI. Now, we'll only handle the deltas that we're intersted in. PowerManagerClient::Observer::PowerChanged documentation: https://cs.chromium.org/chromium/src/chromeos/dbus/power_manager_client.h?type=cs&q=powermanagerclient::observer&g=0&l=95 Bug: b:123245601 Change-Id: I620ca1d1f03fad82bae88762b84d08e1546381a1 Reviewed-on: https://chromium-review.googlesource.com/c/1428519Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Commit-Queue: David Black <dmblack@google.com> Cr-Commit-Position: refs/heads/master@{#625081}
-
John Williams authored
Change-Id: I25000d6f2dbbdc84c601e83d05d8327455382e5c Reviewed-on: https://chromium-review.googlesource.com/c/1423136 Commit-Queue: John Williams <jrw@chromium.org> Reviewed-by:
mark a. foltz <mfoltz@chromium.org> Cr-Commit-Position: refs/heads/master@{#625080}
-
CJ DiMeglio authored
This CL changes the picture-in-picture button to use aria attributes instead of explicitly creating accessibility nodes. Bug: 836549 Change-Id: I35e8a20f570e8068f85cb2203580325c935dde55 Reviewed-on: https://chromium-review.googlesource.com/c/1391862Reviewed-by:
Tommy Steimel <steimel@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: CJ DiMeglio <lethalantidote@chromium.org> Cr-Commit-Position: refs/heads/master@{#625079}
-
Matt Reynolds authored
The //device/fido/hid unittests defined a MockHidConnection type that conflicts with the identically-named type in //services/device/hid. This CL renames the FIDO mock to MockFidoHidConnection. BUG=None Change-Id: Ief80f6e8fb389c64aa99f1da5eea3739395016cf Reviewed-on: https://chromium-review.googlesource.com/c/1418899Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Matt Reynolds <mattreynolds@chromium.org> Cr-Commit-Position: refs/heads/master@{#625078}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=cmasso@chromium.org Change-Id: I4460ee0662cf3a5793e53f9f3df6aa82651411b2 Reviewed-on: https://chromium-review.googlesource.com/c/1429579Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#625077}
-
Jonathan Metzman authored
Don't build sqlite3_lpm_corpus_gen on Windows. It breaks the clang ToT bot because it uses getpid, among other things, and there isn't any demand for running it on Windows. Change-Id: I9bf982e4a9802f2ad5ccfde604f1648a146e6a6f Bug: 903078 Reviewed-on: https://chromium-review.googlesource.com/c/1427904 Commit-Queue: Jonathan Metzman <metzman@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#625076}
-
Kunihiko Sakamoto authored
Bug: 924020 Change-Id: Ib1d168ddb3c9009c6b4fc4dff2ced6816af1529f Reviewed-on: https://chromium-review.googlesource.com/c/1425850Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Tsuyoshi Horo <horo@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#625075}
-
Khushal authored
Avoid using hardcoded size limits for ensuring sane memory allocations during paint deserializations. Instead make sure we don't allocate more than the remaining bytes to read. R=enne@chromium.org Bug: 924042 Change-Id: Ib4acf3a9d1887b71c7fa23a62f6ff138649f9042 Reviewed-on: https://chromium-review.googlesource.com/c/1427560 Commit-Queue: Khushal <khushalsagar@chromium.org> Commit-Queue: enne <enne@chromium.org> Auto-Submit: Khushal <khushalsagar@chromium.org> Reviewed-by:
enne <enne@chromium.org> Cr-Commit-Position: refs/heads/master@{#625074}
-
Alexandre Courbot authored
CL crrev.com/c/1424683 introduced a bug that caused output buffers to never be made available for decoding when using an image processor. The bug slipped in because it did not manifest when rendering was disabled. Fix this by ensuring that buffers are released for decoding both when rendering is disabled, and when an image processor is present. Bug: 920908 Test: Checked that VDA unittest passed on Hana and Nyan with rendering both enabled and disabled. Test: Checked that H.264 playback on crosvideo.appspot.com was correct on Hana and Nyan. Change-Id: I54f9b06f5df671d400e606545f9c16580688abcc Reviewed-on: https://chromium-review.googlesource.com/c/1428623 Commit-Queue: Alexandre Courbot <acourbot@chromium.org> Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Auto-Submit: Alexandre Courbot <acourbot@chromium.org> Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#625073}
-
Kinuko Yasuda authored
This reverts commit b99afc65. Reason for revert: Suspected that it broke build https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8923573116361840720/+/steps/compile/0/stdout Original change's description: > Tracing: Start the tracing service on-demand > > Instead of each process connecting to the tracing service > on startup, the tracing service is now instead brought > up on demand (when something binds the Coordinator interface) > and will then pass pointers to the AgentRegistry and > PerfettoService to the other services so they can register themselves. > > This is a prerequisite to having the tracing service run as a > sandboxed service (or we would always have a new background process > running): https://chromium-review.googlesource.com/c/chromium/src/+/1412016 > > Requires these prior CLs for service_manager manifest support: > * https://chromium-review.googlesource.com/c/chromium/src/+/1410124 > * https://chromium-review.googlesource.com/c/chromium/src/+/1410384 > > TBR=yusukes@chromium.org (for trivial CrOS change) > > Bug: 914579 > Change-Id: Ia1c92fe2aa75e3411efbd119cb9443e8a78e4c8f > Reviewed-on: https://chromium-review.googlesource.com/c/1377593 > Commit-Queue: oysteine <oysteine@chromium.org> > Reviewed-by: Tom Sepez <tsepez@chromium.org> > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Reviewed-by: Eric Seckler <eseckler@chromium.org> > Reviewed-by: Sami Kyöstilä <skyostil@chromium.org> > Reviewed-by: Ehsan Chiniforooshan <chiniforooshan@chromium.org> > Reviewed-by: Ken Rockot <rockot@google.com> > Cr-Commit-Position: refs/heads/master@{#625059} TBR=yusukes@chromium.org,rockot@google.com,chiniforooshan@chromium.org,haraken@chromium.org,oysteine@chromium.org,skyostil@chromium.org,tsepez@chromium.org,eseckler@chromium.org Change-Id: I581b356d2ef29e49c816eca570e4e05a5c971e65 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 914579 Reviewed-on: https://chromium-review.googlesource.com/c/1428625Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#625072}
-
Hirokazu Honda authored
VEA unittest verifies VEA's encoding content by 1. decode content by FFmepgVideoDecoder 2. compare it with the original VideoFrame and computes SSIM 3. check the SSIM less than or equal to the predetermined threshold, 10.0. VEA unittest turns on this verifitcation by --verify_all_output and one of test case parameters. This verification was always disabled on Chrome OS by setting --verify_all_output false because of https://crbug.com/694131. I think the bug is already fixed. We can re-enable the verification on Chrome OS now by default. Bug: 923762 Test: VEA unittest on eve Change-Id: I57f2b62b42e86cba59bb8de2bdfdf6a595a13e87 Reviewed-on: https://chromium-review.googlesource.com/c/1424099 Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
David Staessens <dstaessens@chromium.org> Cr-Commit-Position: refs/heads/master@{#625071}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 2958c933. With Chromium commits locally applied on WPT: 1c633d48 "Snap the snapped_dest_rect for backgrounds" 1061788d "Reland "Add quota usage details tests for all other storage backends."" bcd3934d "Add a test for ServiceWorker and AppCache interaction with claim()" 33a49f0d "[WebLocks]: Modifying weblocks algos to be O(1)" 8e4e5d72 "Fix preload tests failing on wpt.fyi dashboard" f643497e "[resource-timing] Modify is_secure_context_ based on resource" 20defaa4 "[LayoutNG] ComputeReplacedSize min/max width/height fix" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: Id1f9dec5b942ca8f62fc1331e957c4a0c1bef929 Reviewed-on: https://chromium-review.googlesource.com/c/1428564Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#625070}
-
Hirokazu Honda authored
image_processor_test is a test for ImageProcessor. The tested image processor is platform-dependent and decided on the capability. The initial version of image_processor_test tests one video frame conversion from I420 (Memory) to NV12 (Memory). Bug: 917951 Test: ImageProcessorTest on Linux and Chrome OS Change-Id: Ie81a6728ab073a164daa18411d45093caf872efb Reviewed-on: https://chromium-review.googlesource.com/c/1391664 Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
David Staessens <dstaessens@chromium.org> Cr-Commit-Position: refs/heads/master@{#625069}
-
Kristi Park authored
Consolidate paper button styling to animations.css. Also add dark mode support. Screenshots (Dialog background has been set to dark only for screenshots): Enabled = https://screenshot.googleplex.com/rOW5AuTnunN.png Disabled = https://screenshot.googleplex.com/QJrCHor6bHS.png Active/hover = https://screenshot.googleplex.com/vWLs9D24F39.png Bug: 919961 Change-Id: Iceb2741de72c4cfea67ce5e6bb20662a309b530d Reviewed-on: https://chromium-review.googlesource.com/c/1427246 Commit-Queue: Kristi Park <kristipark@chromium.org> Reviewed-by:
Kyle Milka <kmilka@chromium.org> Cr-Commit-Position: refs/heads/master@{#625068}
-
Vlad Tsyrklevich authored
Currently base::debug::StackTrace collects a stack trace in its constructor; however, this doesn't allow users to control the amount of memory allocated per stack trace. The maximum stack trace length is currently has each StackTrace consuming 2kb of memory on non-Windows platforms. This is far too much for GWP-ASan which currently stores hundreds of StackTraces. Instead, have StackTrace use a publicly exposed function that allows callers to specify the size of the stack trace. Bug: 912286 Change-Id: Ib0ba0ec645df8801568b983fe86ee156259ecb84 Reviewed-on: https://chromium-review.googlesource.com/c/1408218 Commit-Queue: Vlad Tsyrklevich <vtsyrklevich@chromium.org> Reviewed-by:
Albert J. Wong <ajwong@chromium.org> Cr-Commit-Position: refs/heads/master@{#625067}
-