- 23 Aug, 2018 40 commits
-
-
Noel Gordon authored
Stop using navigateWithDirectoryTree in createNewFolder helper (return value unchecked, generally false if checked). All tests navigate the directory tree during test setup by clicking on subtree's expand icon. However, the createFolderNestedDownloads() test needs to do an extra step to navigate into sub-tree 'photos'. Since it is the only test that needs this extra step, navigateWithDirectoryTree can be used to do it, with a post-verify step to check that #file-list updated to the expected visual state (no files shown). Change createNewFolder API: navigateWithDirectoryTree gone so path etc can go. Add a tree |selector| argument so createNewFolder can check if that folders appear in the directory tree. Update the createNewFolder internals: focus the file list, use precise #file-list selectors when checking for [selected] [renaming] row, more checks to confirm that only one file-list row is [selected] [renaming] namely the New Folder entry, and verify the New Folder is "present" in directory tree HTML content. After the new folder is renamed, verify that its name is shown in file list and also in the directory tree. Finally, fully test the file-list selection state at the end of the test (the long way). Bug: 876267 Change-Id: I8693bdc43b95a4c3b510633697fa4b3d85e08051 Reviewed-on: https://chromium-review.googlesource.com/1186008Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#585391}
-
Jiajia Qin authored
This CL implements atomic counter buffer and shader storage buffer for webgl2-compute context. Bug: 859249 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I0f32e20d80f436417a22cc363b1661fae4632c35 Reviewed-on: https://chromium-review.googlesource.com/1174092 Commit-Queue: Jiajia Qin <jiajia.qin@intel.com> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#585390}
-
Devlin Cronin authored
Introduce an ExtensionsBrowserAPIProvider, owned by the ExtensionsBrowserClient, to serve as a browser-side counterpart to ExtensionsAPIProvider. The ExtensionsBrowserAPIProvider is responsible for performing browser-side tasks related to APIs; namely, registering API functions with the ExtensionFunctionRegistry. This will allow us to register different APIs separately, without the client needing to know of (and depend upon) each API. Similar to ExtensionsAPIProvider, create an API Provider for each set of code that generates unique features and APIs: - Core Extension APIs (defined in //extensions) - Chrome Extension APIs (defined in //chrome) - Shell Extension APIs (defined in //extensions/shell) - Cast Extension APIs (defined in //chromecast) When the corresponding ExtensionsBrowserClient type is constructed, it registers the appropriate providers. Bug: 873937 Change-Id: Id29c9e7c2b4b9bd64099e6d244bb0b4338d1d0ea Reviewed-on: https://chromium-review.googlesource.com/1175484Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#585389}
-
depot-tools-chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/b7214602e3f1..0ec9d15571fb git log b7214602e3f1..0ec9d15571fb --date=short --no-merges --format='%ad %ae %s' 2018-08-23 tandrii@chromium.org git cl: use project~number on Gerrit for better routing when setting reviewers 2018-08-22 tandrii@chromium.org git cl: remove more unused func kwargs. Created with: gclient setdep -r src/third_party/depot_tools@0ec9d15571fb The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:876910 TBR=agable@chromium.org Change-Id: I2e16e14ac2f14fcb7737614fe52cb95170d58498 Reviewed-on: https://chromium-review.googlesource.com/1185694Reviewed-by:
depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#585388}
-
Clark DuVall authored
This is a reland of a9ed46b7 ChromeBrowserMainBrowserTest.VariationsServiceStartsRequestOnNetworkChange was flaky in the original change. Added logic in the test to wait for the connection type change. Only diffs from original are in chrome/browser/chrome_browser_main_browsertest.cc Original change's description: > Migrate ResourceRequestAllowedNotifier to NetworkConnectionTracker > > A getter is used for NetworkConnectionTracker because some services that > use ResourceRequestAllowedNotifier are initialized early in browser > startup (e.g. VariationsService), and only perform the initialization > of ResourceRequestAllowedNotifier later on the UI thread. The getter > allows us to run get the connection tracker at that point so we don't get > DCHECKs about being on the UI thread when running > content::GetNetworkConnectionTracker(). > > This also moves the NetworkConnectionTracker in ios/ from BrowserState to > ApplicationContext, which is available everywhere. It also matches non-IOS > usage more closely, since we have it as a global there. > > Bug: 868021 > Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet > Change-Id: I130c6b47feb90f0f7f0776ccc65666414a1ae802 > Reviewed-on: https://chromium-review.googlesource.com/1180360 > Reviewed-by: Eugene But <eugenebut@chromium.org> > Reviewed-by: Robert Sesek <rsesek@chromium.org> > Reviewed-by: John Abd-El-Malek <jam@chromium.org> > Reviewed-by: Robbie McElrath <rmcelrath@chromium.org> > Commit-Queue: Clark DuVall <cduvall@chromium.org> > Cr-Commit-Position: refs/heads/master@{#584849} TBR=eugenebut@chromium.org,rsesek@chromium.org,rmcelrath@chromium.org,jam@chromium.org Bug: 868021 Change-Id: I5941b72474657159f0d4a1e6667fd77a3c475887 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Reviewed-on: https://chromium-review.googlesource.com/1185602Reviewed-by:
Clark DuVall <cduvall@chromium.org> Reviewed-by:
Robbie McElrath <rmcelrath@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#585387}
-
Devlin Cronin authored
Move ManifestHandler registration out of the body of ExtensionsClient::Initialize() and into the ExtensionsAPIProviders by introducing ExtensionsAPIProvider::RegisterManifestHandlers(). Have each provider register their associated ManifestHandlers, and have a common ExtensionsClient initialization step call into them in order to trigger the registration. Bug: 873937 Change-Id: I8c400efd9d91968a8dd28b249483ded31bbc79e0 Reviewed-on: https://chromium-review.googlesource.com/1177190Reviewed-by:
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/33d5394d08f6..9ac87d4472f6 git log 33d5394d08f6..9ac87d4472f6 --date=short --no-merges --format='%ad %ae %s' 2018-08-23 recipe-roller@chromium.org Roll recipe dependencies (trivial). 2018-08-23 recipe-roller@chromium.org Roll recipe dependencies (trivial). 2018-08-23 recipe-roller@chromium.org Roll recipe dependencies (trivial). 2018-08-22 enne@chromium.org Add disable_texture_storage workaround 2018-08-22 enne@chromium.org Add remove_pow_with_constant_exponent workaround 2018-08-22 enne@chromium.org Add rewrite_do_while_loops workaround 2018-08-22 mtklein@google.com also set Wno-implicit-fallthrough for Android Created with: gclient setdep -r src/third_party/skia@9ac87d4472f6 The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium: 521904,chromium:829614,chromium: 477306,chromium:829614,chromium: 644669,chromium:829614 TBR=fmalita@chromium.org Change-Id: I150b8ac88e7c5dfcb6eefc7bfe4bd50c08180f69 Reviewed-on: https://chromium-review.googlesource.com/1185693Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#585385}
-
catapult-chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/c67a80df2679..d95dde6e066f git log c67a80df2679..d95dde6e066f --date=short --no-merges --format='%ad %ae %s' 2018-08-23 simonhatch@chromium.org Dashboard - List out docs for alerts. 2018-08-22 benjhayden@chromium.org Remove SparseDiagnostic.GetMostRecentValuesByNames. 2018-08-22 simonhatch@chromium.org Pinpoint - Include doc link in bug comment. 2018-08-22 benjhayden@chromium.org Set default_expiration: 20h in v2spa.yaml. 2018-08-22 benjhayden@chromium.org Allow passing custom version to deploy_v2spa. Created with: gclient setdep -r src/third_party/catapult@d95dde6e066f The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:863861,chromium:876082,chromium:863861 TBR=sullivan@chromium.org Change-Id: Ib326be155ae9fb40b064de9512abbef02e4a23a7 Reviewed-on: https://chromium-review.googlesource.com/1185691Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#585384}
-
Kunihiko Sakamoto authored
This makes MerkleIntegritySourceStream match the new behavior of draft-thomson-http-mice-03 [1], where the encoding of an empty payload does not have the 8-byte record size. Also, after this patch the final record must not be empty. Empty final records were allowed because http-mice-02 couldn't represent the empty payload otherwise. [1] https://tools.ietf.org/html/draft-thomson-http-mice-03#section-2 Bug: 875721 Change-Id: I2e2003603fb9f3d9baf4cf369cf9487b8990bcf8 Reviewed-on: https://chromium-review.googlesource.com/1183044 Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
David Benjamin <davidben@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#585383}
-
Mohit Hotwani authored
Bug: internal b/104824337 Change-Id: I866cfa171eb11bdd401f3892233b970310fc45ac Reviewed-on: https://chromium-review.googlesource.com/1186116Reviewed-by:
Kenneth MacKay <kmackay@chromium.org> Reviewed-by:
-
Raymes Khoury authored
This test checks that basic behaviors related to permission delegation work correctly in PermissionManager. This includes requesting permission from a child frame, ensuring the origin displayed is correct and revoking access from the parent later and ensuring that is reflected in the child. Bug: 802945 Change-Id: Id2183c0d08d930fbd1664a2ba6102cb3bd56dd7c Reviewed-on: https://chromium-review.googlesource.com/1182716Reviewed-by:
Timothy Loh <timloh@chromium.org> Commit-Queue: Raymes Khoury <raymes@chromium.org> Cr-Commit-Position: refs/heads/master@{#585381}
-
inglorion authored
lld-link can use a cache to speed up ThinLTO builds. Unfortunately, this cache leaks temporary files on Windows, causing storage to fill up. Until this has been addressed, this disables the cache, avoiding the problem. Bug: 871962 Change-Id: I415162233bc8855b3d7e237e80c23cbbc24bcfeb Reviewed-on: https://chromium-review.googlesource.com/1185856Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Bob Haarman <inglorion@chromium.org> Cr-Commit-Position: refs/heads/master@{#585380}
-
Kentaro Hara authored
Bug: 869581 Change-Id: Ibe28c2ed55441c74d9faa845f81801c762559de7 Reviewed-on: https://chromium-review.googlesource.com/1184132 Commit-Queue: Kentaro Hara <haraken@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#585379}
-
Katie D authored
The --enable-experimental-accessibility-features flag must be on in order to see the STS option. This should be removed when a launch bug is ready to go. BUG: 833047 Change-Id: I2a255009c27720834a762334e83d2360e1db2354 Reviewed-on: https://chromium-review.googlesource.com/1180089 Commit-Queue: Katie Dektar <katie@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#585378}
-
Robert Ogden authored
Looks like this crash is happening right when the browser starts in some weird corner case. This CL just exists early if web_contents() is null. Bug: 876835 Change-Id: I6dc7eecbd42becb077d9156a28974264c4c90166 Reviewed-on: https://chromium-review.googlesource.com/1185898Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Commit-Queue: Robert Ogden <robertogden@chromium.org> Cr-Commit-Position: refs/heads/master@{#585377}
-
Charles Zhao authored
This records the number of times a suggested chip at a specific index is launched. (1) The index of each suggestion_chip_view is assigned in suggestion_chip_container_view when the container updates. (2) The index is recorded when the ButtonPressed event is triggered for a search_result_suggestion_chip_view. Change-Id: I124a85997f4104b1cf70a93d0e76a40c8c8c9864 Bug: 874728 Change-Id: I124a85997f4104b1cf70a93d0e76a40c8c8c9864 Reviewed-on: https://chromium-review.googlesource.com/1177087 Commit-Queue: Charles . <charleszhao@chromium.org> Reviewed-by:Ilya Sherman <isherman@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/heads/master@{#585376}
-
Adam Langley authored
GlobalSign R2 signed some subCAs before Google owned it. No Google property should ever have a certificate chain that uses those subCAs so exclude them in pinning. Change-Id: I69df3fbef40e952ec194840731b6257aced813ce Reviewed-on: https://chromium-review.googlesource.com/1186092 Commit-Queue: Adam Langley <agl@chromium.org> Commit-Queue: Ryan Sleevi <rsleevi@chromium.org> Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Cr-Commit-Position: refs/heads/master@{#585375}
-
Taylor Bergquist authored
https://crrev.com/c/1149273 used a new Windows API, GetSystemMetricsForDpi, to better handle multi-monitor high DPI frame sizing scenarios. However this API does not perpetuate a backwards- compatibility behavior we were relying on before, where SM_CXSIZEFRAME would include the non-resize-handle border space, SM_CXPADDEDBORDER, (added in Vista) in addition to the resize handle space. As a result, we weren't accounting for that border space when calculating client area insets. This CL includes that space explicitly. Bug: 873860 Bug: 874884 Bug: 876687 Change-Id: I19a9bde9c684e801cefb5f98162dba64ece295af Reviewed-on: https://chromium-review.googlesource.com/1176824Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Commit-Queue: Taylor Bergquist <tbergquist@chromium.org> Cr-Commit-Position: refs/heads/master@{#585374}
-
Toni Barzic authored
Updates chromeos::DemoSession to use chromeos::DIR_PREINSTALLED_COMPONENTS to determine the preinstalled demo mode resources path. TEST=existing unittests BUG=869455 Change-Id: Idd63ae0893b4fa3966d69bb295fbdb0290456bca Reviewed-on: https://chromium-review.googlesource.com/1180729 Commit-Queue: Toni Baržić <tbarzic@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Cr-Commit-Position: refs/heads/master@{#585373}
-
Istiaque Ahmed authored
DeepCopy returns a bare pointer, use CreateDeepCopy instead which returns an owned pointer. In the same spirit, change Manifest::DeepCopy to CreateDeepCopy and let it return owned pointer value as well. Bug: None Test: None, internal cleanup. Change-Id: I72da757694d511ab0de45da2f42859057cb9f418 Reviewed-on: https://chromium-review.googlesource.com/1142524Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Istiaque Ahmed <lazyboy@chromium.org> Cr-Commit-Position: refs/heads/master@{#585372}
-
Kuo-Hsin Yang authored
**SHERIFFS** this test only CL may cause regression but it's expected. Bug: chromium:862077 Bug: chromium:873081 Change-Id: Ia8c338b6e87fec576f3b5573ecfd1c2d824f2836 Reviewed-on: https://chromium-review.googlesource.com/1184733Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Juan Antonio Navarro Pérez <perezju@chromium.org> Reviewed-by:
Ned Nguyen <nednguyen@google.com> Commit-Queue: Vovo Yang <vovoy@chromium.org> Cr-Commit-Position: refs/heads/master@{#585371}
-
Tien-Ren Chen authored
Sticky descendants need to re-compute paint offset upon scrolled. Beside fixing the under-invalidation, this CL also reduced the strength of the invalidation so instead of full paint invalidation it only needs a paint offset check. BUG=874675 Cq-Include-Trybots: luci.chromium.try:linux-blink-gen-property-trees;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I0e4ab3b667a6f06bfe3c584285dc2e31fa4ea7c2 Reviewed-on: https://chromium-review.googlesource.com/1182668Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Tien-Ren Chen <trchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#585370}
-
Weilun Shi authored
Prevent closing the custom background dialog when clicking outside to stay consistent with the custom link edit dialog. Also fix bug 874820. When dragging mouse cursor within the overlay, now the dialog will not close. Bug: 874820 Change-Id: I4f78da252df73a664a7c31099e7e311a6c7856ed Reviewed-on: https://chromium-review.googlesource.com/1185799Reviewed-by:
Kristi Park <kristipark@chromium.org> Commit-Queue: Weilun Shi <sweilun@chromium.org> Cr-Commit-Position: refs/heads/master@{#585369}
-
Oystein Eftevaag authored
This will use Perfetto instead of TraceLog for all trace-based Telemetry tests running on Mac/Windows/Android. R=nednguyen@google.com Bug: 839084 Cq-Include-Trybots: master.tryserver.chromium.perf:obbs_fyi Change-Id: I570060cd7f53ea0310f67370b4abec132c8a1a01 Reviewed-on: https://chromium-review.googlesource.com/1176119 Commit-Queue: oysteine <oysteine@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Reviewed-by:
-
Marijn Kruisselbrink authored
This adds a method to blink::FileError that more or less does the same as blink::FileError::CreateDOMException(content::FileErrorToWebFileError(code)), just without the extra conversion through WebFileError and blink::FileError::ErrorCode in between. Bug: 872460, 872465 Change-Id: I6b7f94d9a3da2fa730cf78f5a74d5315d34c95c0 Reviewed-on: https://chromium-review.googlesource.com/1185791Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#585367}
-
Mason Freed authored
Previously, BlockPainter's PaintObject method: 1) was rather uncommented, particularly as it related to its correspondence to the W3C "Appendix E" spec for stacking context painting (at https://www.w3.org/TR/CSS21/zindex.html). 2) was a bit convoluted, in the parts that dealt with painting LayoutBlockFlow objects. BlockPainter handled painting most parts of painting both LayoutBlocks and LayoutBlockFlows, except for in two places. In those places, a BlockFlowPainter was constructed and called, and then at one point in BlockFlowPainter::PaintContents, a BlockPainter was constructed and PaintContents called on that. Functional but confusing. With this CL, comments are added to link BlockPainter to Appendix E, and BlockFlowPainter is eliminated. That code is folded back into BlockPainter, inline where it was called. Bug: 873387 Change-Id: Idc041eacbcfadd1df1a610f81a2a98de024b7d49 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Reviewed-on: https://chromium-review.googlesource.com/1175226 Commit-Queue: Mason Freed <masonfreed@chromium.org> Reviewed-by:Philip Rogers <pdr@chromium.org> Reviewed-by:
vmpstr <vmpstr@chromium.org> Cr-Commit-Position: refs/heads/master@{#585366}
-
Yusuf Ozuysal authored
- Change the context being sent to HaTS to only include info on horizontal tab switcher. - Get a max value through HTS experiment and if both max values exist take the minimum of the two between HTS and Modern experiments. BUG=865089 Change-Id: I6523bec32aa2d878aac4bb301f674ccb624ff96e Reviewed-on: https://chromium-review.googlesource.com/1168389 Commit-Queue: Yusuf Ozuysal <yusufo@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#585365}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 0d2fc4e4. With Chromium commits locally applied on WPT: 2160c22c "Modify source path for wpt test of Accept-CH" f4c510e1 "Move XR LayoutTests over to be WPTs" 3152c6f7 "[UserTiming] Correct measure where start is undefined" 7e57f956 "Revert "Move XR LayoutTests over to be WPTs"" Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/23132 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=foolip No-Export: true Change-Id: I8fb88d499bcf46eb536b851ff546afa4913c7ce0 Reviewed-on: https://chromium-review.googlesource.com/1186023 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#585364}
-
Tatsuhisa Yamaguchi authored
The color of active icons should be Grey 200, which is darker than the labels by 1 level. This will affect multiple places including: - tray collapse button - feature pod icons - top shortcut buttons - slider button - menu back arrow icon - ink drop of sign out button - tray popup Bug: 853695 Change-Id: Ifbbfe221db040f2f02d9577a636b7c7dd4f796f0 Reviewed-on: https://chromium-review.googlesource.com/1180787Reviewed-by:
Tetsui Ohkubo <tetsui@chromium.org> Reviewed-by:
Yoshiki Iguchi <yoshiki@chromium.org> Commit-Queue: Tatsuhisa Yamaguchi <yamaguchi@chromium.org> Cr-Commit-Position: refs/heads/master@{#585363}
-
Kyoko Muto authored
This CL makes slotting-manual mode support slot change event which is already supported in auto mode. BUG:869308 Change-Id: I106d1037036e5e34d552cf7ce17eacd8f453fc9c Reviewed-on: https://chromium-review.googlesource.com/1179555Reviewed-by:
Hayato Ito <hayato@chromium.org> Commit-Queue: Kyoko Muto <kymuto@google.com> Cr-Commit-Position: refs/heads/master@{#585362}
-
Chris Blume authored
Previously, ParentLocalSurfaceIdAllocator would default to an invalid LocalSurfaceId. A new LSI had to be explicitly allocated before the normal behavior could use it. With ParentLocalSurfaceIdAllocator now default initializing a valid LSI, the various call sites no longer need to explicitly check for the uninitialized state. Render Widget is one of those call sites. BUG=837030 Change-Id: I330d2c47492f1ac577a928f20a8e8e4e14f91b29 Reviewed-on: https://chromium-review.googlesource.com/1038127 Commit-Queue: Chris Blume <cblume@chromium.org> Reviewed-by:
Fady Samuel <fsamuel@chromium.org> Cr-Commit-Position: refs/heads/master@{#585361}
-
Mustafa Emre Acer authored
This CL adds a "metrics_only" parameter to IdnNavigationSuggestions feature. When set to "true", the parameter will suppress the display of the "Did you mean to go to ..." UI and only record metrics. Bug: 843361,847662 Change-Id: Idb72225ff0fc2f011bd2c1ae5bb0ee7167d687ba Reviewed-on: https://chromium-review.googlesource.com/1182123 Commit-Queue: Mustafa Emre Acer <meacer@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#585360}
-
depot-tools-chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/29361ca11fa3..b7214602e3f1 git log 29361ca11fa3..b7214602e3f1 --date=short --no-merges --format='%ad %ae %s' 2018-08-22 tandrii@chromium.org git cl: remove unused issue kwarg. Created with: gclient setdep -r src/third_party/depot_tools@b7214602e3f1 The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: Ice188b5ef26cee1efa29e1adf1b1f291f3295151 Reviewed-on: https://chromium-review.googlesource.com/1185689Reviewed-by:
-
Yuwei Huang authored
This CL adds support for Android client to resize host to fit client resolution. Bug: 874626 Change-Id: I9c3c8139eab20834e79deb2ce662a8ab1234b09c Reviewed-on: https://chromium-review.googlesource.com/1182187Reviewed-by:
Joe Downing <joedow@chromium.org> Commit-Queue: Yuwei Huang <yuweih@chromium.org> Cr-Commit-Position: refs/heads/master@{#585358}
-
Erik Chen authored
This CL adds a gn arg enable_downstream_media_tests, which downstream consumers of chromium can set to make these builds appear. This prevents building and isolate generation [which fails] in upstream chromium builds that try to build/isolate all targets. Bug: 876915 Change-Id: Ic0f892680e889a5cd5d92b8853800a3c08926a9b Reviewed-on: https://chromium-review.googlesource.com/1186102Reviewed-by:
-
Scott Wu authored
This CL creates the skeleton of common password controller and moves FormActivityObserver related logic into it`. The goal is to move common password autofill logics into components folder so that they can be shared by both Chrome iOS and //ios/web_view. > Moved webState and jsPasswordManager into helper class. > Moved FormActivityObserver logic into helper class. Bug: 865114 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I2dbfdb1cb4f0bdf22bf1d5c37451f46682addcac Reviewed-on: https://chromium-review.googlesource.com/1156528Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
Hiroshi Ichikawa <ichikawa@chromium.org> Reviewed-by:
John Wu <jzw@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Scott Wu <scottwu@chromium.org> Cr-Commit-Position: refs/heads/master@{#585356}
-
Yuly Novikov authored
Bug: 869557, 870840 Change-Id: I3da61f9ee1e632e8aec68ad0d07ebc4ffab4487a Reviewed-on: https://chromium-review.googlesource.com/1185985Reviewed-by:
John Budorick <jbudorick@chromium.org> Reviewed-by:
-
John Rummell authored
There are crashes during destruction where |side_data_size_| == 0 but |side_data_| contains an invalid pointer. Adding a CHECK for this in the destructor to hopefully get better data to help isolate the real problem. BUG=794740 TEST=media_unittests still pass Change-Id: Id1633395c544b66ef632445d475a40e57a8aa1b4 Reviewed-on: https://chromium-review.googlesource.com/1185961 Commit-Queue: John Rummell <jrummell@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#585354}
-
Pedro Amaral authored
This CL fades out the old button completely and then fades in the new button. Bug: 874097 Change-Id: I131c2383d645ead9909ca4f4270c855595a25b60 Reviewed-on: https://chromium-review.googlesource.com/1175207Reviewed-by:
Matthew Jones <mdjones@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Pedro Amaral <amaralp@chromium.org> Cr-Commit-Position: refs/heads/master@{#585353}
-
Tetsui Ohkubo authored
After trial, UX decided to change the color of stacked notification counter. TEST=manual BUG=876469 Change-Id: I8492716588048d74b8bdbea611e580fb35701556 Reviewed-on: https://chromium-review.googlesource.com/1184735Reviewed-by:
-
