GitLab

Record the "bundle_data" target corresponding to a BundleFileRule object
so that the dependencies can be correctly computed when generating the
ninja steps for the "create_bundle" target.

Change the "stamp" step of "bundle_data" target in the generated ninja
to depends on the target dependencies and source files.

Change the "copy_bundle_data" steps of "create_bundle" target in the
generated ninja to depends on the "bundle_data" target that defined
the corresponding source files.

Change the "compile_xcassets" step of "create_bundle" target in the
generated ninja to depends on all the "bundle_data" targets that defined
the corresponding source files.

Change the rule used to determine whether a "bundle_data" source file
is part of an assets catalog (some file where incorrectly omitted causing
them to be incorrectly copied to the final bundle).

All those changes will allow the "copy_bundle_data" and "compile_xcassets"
steps to only depends on the targets that generate them (if any) and will
reduce the number of file copied into the final bundle during incremental
builds.

Fix unit tests with new expectations.

BUG=623501

Review-Url: https://codereview.chromium.org/2105613003
Cr-Commit-Position: refs/heads/master@{#403304}

https://chromium.googlesource.com/chromium/src/+/d0ff92817

BUG=624269
TBR=glebl@chromium.org

Review URL: https://codereview.chromium.org/2119623004 .

Cr-Commit-Position: refs/heads/master@{#403303}

Stop using UMA preference to gate sending HitReport to SB backend, use extended reporting preference instead.

BUG=598889

Review-Url: https://codereview.chromium.org/2104423002
Cr-Commit-Position: refs/heads/master@{#403302}

* Convert NetworkStateListDetailedView to wm common types and add debug name.
* Fix include guards.
* Move files to //ash/common/system/chromeos.
* Fix DEPS.

BUG=619636
TEST=ash_unittests, manual by opening the network (i) info panel and dumping
the window tree with Ctrl-Alt-Shift-W
TBR=derat@chromium.org

Review-Url: https://codereview.chromium.org/2109293002
Cr-Commit-Position: refs/heads/master@{#403301}

This patch updates the code to prevent auto deducing to a raw pointer.

R=jochen, danakj, dcheng
BUG=554600

Review-Url: https://codereview.chromium.org/2107953002
Cr-Commit-Position: refs/heads/master@{#403300}

because is deprecated. Also using |using|.

While I was doing that, I saw that some methods
related to Get_X_By_Y_() had inconsistent names,
signatures and/or locations in the header/implementation
files, hence:

- GetDeviceEntryForMediaStreamDevice() renamed to
  GetDeviceEntryByTypeAndId() and reducing the
  parameters to the used information.

- GetDeviceEntryForController() renamed to
  GetDeviceEntryByController()

- FindDeviceInfoById() renamed to GetDeviceInfoById()

- GetVideoCaptureDeviceFromSessionId() renamed to
  GetVideoCaptureDeviceBySessionId()

- Added GetDeviceEntryBySerialId().

And bundled together in the .h file. Also I shoved
around some methods in the .h file to match the .cc
but I'm planning on another subsequent CL just
aligning both.

BUG=554289
TEST=no new code introduced (this is a refactoring)
so all unittests, content_browsertests and browser_tests
related to video capture (there a loads of them)
passing should be enough verification.

Review-Url: https://codereview.chromium.org/2108293002
Cr-Commit-Position: refs/heads/master@{#403299}

This patch updates the code to prevent auto deducing to a raw pointer.

R=benwells@chromium.org, danakj, dcheng
BUG=554600

Review-Url: https://codereview.chromium.org/2108623005
Cr-Commit-Position: refs/heads/master@{#403298}

This also removes the ability to set options that we are
not pursuing right now.

BUG=622893

Review-Url: https://codereview.chromium.org/2117583002
Cr-Commit-Position: refs/heads/master@{#403297}

The color profile will originate in content::RenderWidgetHostViewMac
on Mac and aura::WindowTreeHost on Aura, and will need to be consumed
in the cc::GLRenderer in a shader and in the
content::GpuSurfacelessBrowserCompositorOutputSurface. Both of
these originating structures have a ui::Compositor.

This follows the same plumbing paths as device scale factor and surface
size.

BUG=622133
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Review-Url: https://codereview.chromium.org/2102203003
Cr-Commit-Position: refs/heads/master@{#403296}

For devices with different names, the chooser just shows their names;
for devices with the same name, the chooser shows their name with
its unique device identifier.

So the chooser will look like:
device_different_name
device_same_name (device_1)
device_same_name (device_2)
device_same_name (device_3)

BUG=544121

Review-Url: https://codereview.chromium.org/2098983002
Cr-Commit-Position: refs/heads/master@{#403295}

BUG=597794,606074
NOTRY=true
TEST=eanbled webgl2 conformance tests
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2113573002
Cr-Commit-Position: refs/heads/master@{#403294}

This adds full closure compilation for the certificate manager page
directory.

BUG=425627
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2101243004
Cr-Commit-Position: refs/heads/master@{#403293}

Moves the following things out of the mojo::internal namespace
and moves their headers to mojo/public/cpp/bindings:

  - InterfaceId
  - Message flags (constants in Message rather than in internal)
  - MessageHeaderValidator
  - PipeControlMessageHandler
  - PipeControlMessageHandlerDelegate
  - PipeControlMessageProxy
  - SyncHandleWatcher

This completes the set of existing helpers necessary to implement
custom bindings endpoints with custom routing logic.

BUG=612500
R=yzshen@chromium.org

Review-Url: https://codereview.chromium.org/2114523002
Cr-Commit-Position: refs/heads/master@{#403292}

This CL both increases maximum backtrace depth (24 -> 48) and reduces
AllocationRegister memory usage (265 -> 42 MiB on 32-bit platforms) at
the expense of performance (~30% hit). See the bug for more details.

BUG=617772

Review-Url: https://codereview.chromium.org/2089253002
Cr-Commit-Position: refs/heads/master@{#403291}

BUG=352807
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
TBR=zmo@chromium.org

Review-Url: https://codereview.chromium.org/2113453005
Cr-Commit-Position: refs/heads/master@{#403290}

R=dpranke@chromium.org, sergeyu@chromium.org
BUG=622415

Review-Url: https://codereview.chromium.org/2111213002
Cr-Commit-Position: refs/heads/master@{#403289}

Currently on iOS SSL interstitials are presented in donwstream's Tab.
This CL allows presenting them from WebClient::AllowCertificateError to be
consistent with other platforms (where interstitials are presented from
ContentBrowserClient::AllowCertificateError).

Implementation of IOSSSLErrorHandler::HandleSSLError is even simpler than
Tab code because the latter used to present Safe Browsing interstitials
which can not be supported by WKWebView.

BUG=602298

Review-Url: https://codereview.chromium.org/2108783005
Cr-Commit-Position: refs/heads/master@{#403288}

BUG=624668
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2110363002
Cr-Commit-Position: refs/heads/master@{#403287}

This CL begins moving MSE init segment received algorithm implementation
to blink level, so that it could be shared across different
implementations (e.g. between Chrome and Opera). The old init segment
algorithm is in MediaSourceState::OnNewConfigs, and for now it needs to
be kept, since it does other important things that must be done on the
Chromium media pipeline level atm (e.g. creating track buffers and
demuxer streams).

BUG=620881

Review-Url: https://codereview.chromium.org/1678523003
Cr-Commit-Position: refs/heads/master@{#403286}

MipmapUtil had error handling where it would return "-1" values to
indicate errors. None of the call sites should trigger this behavior,
so the error checks were converted to DCHECKs.

R=vmpstr
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Review-Url: https://codereview.chromium.org/2105903003
Cr-Commit-Position: refs/heads/master@{#403285}

CFNetworkExecuteProxyAutoConfigurationURL run loop sources are not
thread safe. Therefore, the following source events should be
synchronized:
1. Adding the source to the run loop.
2. Handling the result of proxy resolution.
3. Removing the source from the run loop.

This change does not prevent the parallel resolution of proxies for
multiple URLs but only prevents concurrent execution of the above
mentioned event, which are supposed to be lightweight operations.

BUG=166387

Review-Url: https://codereview.chromium.org/2094373002
Cr-Commit-Position: refs/heads/master@{#403284}

This jar is a dependency for Robolectric 3.0

BUG=522043

Review-Url: https://codereview.chromium.org/2049543002
Cr-Commit-Position: refs/heads/master@{#403283}

Autofill table:
  * Added billing_address_id column to masked_credit_card table.
  * Bumped version to 67.

Sync:
  * Do not overwrite user's preferred billing address for their server
    card when downloading masked credit cards from the server.

Personal data manager:
  * Added an UpdateServerCreditCardBillingAddress() method to support
    changes from settings.

Android autofill settings:
  * Let users change the billing address of their server credit card.
  * Local and server credit card settings have a common parent and
    re-use common UI elements.

BUG=602663

Review-Url: https://codereview.chromium.org/2109643003
Cr-Commit-Position: refs/heads/master@{#403282}

This CL adds closure compilation to the settings menu directory.

BUG=425627
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2111023002
Cr-Commit-Position: refs/heads/master@{#403281}

BUG=619770

Review-Url: https://codereview.chromium.org/2115653002
Cr-Commit-Position: refs/heads/master@{#403280}

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/a9f8ed16a47c..44fb68ed1d6d

$ git log a9f8ed16a..44fb68ed1 --date=short --no-merges --format='%ad %ae %s'

TBR=catapult-sheriff@chromium.org

Review-Url: https://codereview.chromium.org/2109613006
Cr-Commit-Position: refs/heads/master@{#403279}

its value is the string forced.

BUG=624187,b/29833682

Review-Url: https://codereview.chromium.org/2107033002
Cr-Commit-Position: refs/heads/master@{#403278}

Instead of wrapping the InterfaceRequest<>s in a unique_ptr<> and storing
that in a vector, just store the requests directly.

BUG=none

Review-Url: https://codereview.chromium.org/2107383003
Cr-Commit-Position: refs/heads/master@{#403277}

These jars are dependencies for Robolectric 3.0.

BUG=522043

Review-Url: https://codereview.chromium.org/2049563002
Cr-Commit-Position: refs/heads/master@{#403276}

This is more accurate terminology. A color space can be represented
by ICC profile. There isn't really such a thing as a "color profile".

BUG=622133

Review-Url: https://codereview.chromium.org/2106303002
Cr-Commit-Position: refs/heads/master@{#403275}

Download was cancelled when a dangerous download infobar is dismissed.
We missed it in the previous CL.

BUG=618864

Review-Url: https://codereview.chromium.org/2111983002
Cr-Commit-Position: refs/heads/master@{#403274}

After CL: https://codereview.chromium.org/2092103002/ all IME result methods are
being routed to the right RenderWidget. Similarly, when an IME session is closed
on the browser side due to a click or tap, the right widget should be notifed
by receiving an IME confirm composition with empty text. Currently, this IPC is
sent to the tab's RenderWidget regardless of what the active widget is.

This CL will route the IPC to the right widget and adds a unit test for this purpose.

BUG=578168

Review-Url: https://codereview.chromium.org/2116593002
Cr-Commit-Position: refs/heads/master@{#403273}

Refactorization CL preparing for OpenGL rendering on Android. Currently
JniDisplayHandler is owned and managed by the Java display object, which
requires passing pointer of the display handler back and forth and makes the
lifetime management of the display handler not very straightforward. This CL
makes JniClient own JniDisplayHandler and makes JniDisplayHandler control
the lifetime of the Java display object instead of the other way around.

BUG=385924

Review-Url: https://codereview.chromium.org/2100943004
Cr-Commit-Position: refs/heads/master@{#403272}

Callers of GetSystemMetrics occassionally need to get system metrics in the
using the HWND's DPI. An example is calculating the client frame using
SM_CXSIZEFRAME. This will be different depending on the DPI of the display.

BUG=426656

Review-Url: https://codereview.chromium.org/2110313002
Cr-Commit-Position: refs/heads/master@{#403271}

BUG=623927

Review-Url: https://codereview.chromium.org/2026483003
Cr-Commit-Position: refs/heads/master@{#403270}

Native heap profiling captures C/C++ backtraces for allocations, but
requires a special build (and a symbolization step).

BUG=602701

Review-Url: https://codereview.chromium.org/2084973002
Cr-Commit-Position: refs/heads/master@{#403269}

Revert of Remove calls to MessageLoop::current() in content. (patchset #1 id:1 of https://codereview.chromium.org/2105173004/ )

Reason for revert:
Failed Browser tests and webkit tests.

Browser tests failed:
DevToolsSanityTest.AutoAttachToWindowOpen
https://build.chromium.org/p/chromium.mac/builders/Mac10.9%20Tests%20%28dbg%29/builds/26458

webkit tests failed:
inspector/sources/debugger-pause/debugger-pause-on-promise-rejection.html
inspector/sources/debugger/live-edit-no-reveal.html
inspector/sources/debugger-step/debugger-step-out-document-write.html
inspector/sources/debugger-step/debugger-step-over-inlined-scripts.html
inspector/sources/debugger-console/debug-console-command.html
inspector/sources/debugger-frameworks/frameworks-sourcemap.html
inspector-protocol/debugger/debugger-doesnt-step-into-injected-script.html
inspector/sources/debugger-step/debugger-step-over-document-write.html
inspector/sources/debugger-step/debugger-step-out-event-listener.html
inspector/sources/debugger-console/debugger-command-line-api.html
inspector/sources/debugger-step/debugger-step-into-event-listener.html
inspector/sources/debugger-breakpoints/dom-breakpoints.html
inspector/sources/debugger/debugger-return-value.html
inspector/sources/debugger-ui/debugger-inline-values.html
inspector/sources/debugger-ui/reveal-not-skipped.html
inspector-protocol/debugger/stepping-with-blackboxed-ranges.html
inspector/sources/debugger-step/debugger-step-in.html
inspector/sources/debugger-frameworks/frameworks-skip-step-in.html
inspector/sources/debugger-step/debugger-step-into-across-timeouts.html
inspector/sources/debugger-frameworks/frameworks-step-from-framework.html
inspector/sources/debugger-step/debugger-step-into-custom-element-callbacks.html
inspector/sources/debugger-pause/debugger-eval-while-paused-throws.html
inspector/sources/debugger/mutation-observer-suspend-while-paused.html
inspector/sources/debugger-frameworks/frameworks-dom-xhr-event-breakpoints.html
inspector-protocol/debugger/postMessage-on-pause.html
inspector/sources/debugger-frameworks/frameworks-step-into-skips-setTimeout.html
inspector/sources/debugger/live-edit.html
inspector/sources/debugger-frameworks/frameworks-steppings.html
inspector-protocol/debugger/continueToLocation.html
inspector/sources/debugger-pause/debugger-eval-on-call-frame-inside-iframe.html
inspector/sources/debugger-step/debugger-step-into-document-write.html
inspector-protocol/debugger/updateCallFrameScopes.html
inspector/sources/debugger-step/debugger-step-over.html
inspector/sources/debugger-frameworks/frameworks-jquery.html
inspector-protocol/debugger/debugger-setBlackboxPatterns.html
inspector/sources/debugger-step/debugger-step-into-inlined-scripts.html
inspector/sources/debugger-step/debugger-step-over-across-timeouts.html
inspector/sources/debugger-step/debugger-step-through-promises.html
inspector/sources/debugger-step/debugger-step-out-custom-element-callbacks.html
inspector-protocol/debugger/step-over-caught-exception.html

https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.11/builds/6394

Original issue's description:
> Remove calls to MessageLoop::current() in content.
>
> Why?
> The fact that there's a MessageLoop on the thread is an
> unnecessary implementation detail. When browser threads
> are migrated to base/task_scheduler, tasks will no longer
> have access to a MessageLoop.
>
> These changes were generated manually.
>
> BUG=616447
>
> Committed: https://crrev.com/76388ee0f590195676606308a2666dd25ae5b4b7
> Cr-Commit-Position: refs/heads/master@{#403228}

TBR=jochen@chromium.org,fdoray@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=616447

Review-Url: https://codereview.chromium.org/2116643002
Cr-Commit-Position: refs/heads/master@{#403268}

For non-users of Data Saver, show a promotional InfoBar if the following are true:

The user in the DataReductionProxyInfobarPromo field trial.
The user doesn’t have the Data Reduction Proxy enabled.
The user saw the promo in a version >= M51.
The user didn’t opt out of the FRE promo card.
The current version is at least two milestones after the last promo was displayed.
The infobar has never been shown and dismissed before.
The request is HTTP.

BUG=610757

Review-Url: https://codereview.chromium.org/2022313002
Cr-Commit-Position: refs/heads/master@{#403267}

We use PageLoadTiming with gmock in a few places. gmock sometimes passes
objects to functions by value. In these cases, if PageLoadTiming contains
base::Optional members, the code fails to compile on windows due to as
issue with Optional's use of aligned memory.

This changes updates our use of PageLoadTiming with gmock to no longer
use aspects of gmock that pass PageLoadTiming by value.

This factors common code into a new FakePageTimingMetricsIPCSender class,
which provides the functionality we had been using gmock for.

See https://groups.google.com/forum/#!topic/googletestframework/W-Hud3j_c6I
for additional details on why gmock is not compatible with Optional.

BUG=623556

Review-Url: https://codereview.chromium.org/2100653002
Cr-Commit-Position: refs/heads/master@{#403266}

This jar is required to process Roboletric templated code.

BUG=522043

Review-Url: https://codereview.chromium.org/2049503003
Cr-Commit-Position: refs/heads/master@{#403265}