- 26 Aug, 2019 40 commits
-
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/271fe862460b..b705a4e15ba7 Created with: gclient setdep -r src-internal@b705a4e15ba7 The AutoRoll server is located here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None,chromium:None Change-Id: I0437dafd9eb71ed41a10c969193b3c268417bfa1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1771292Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#690320}
-
Henrique Ferreiro authored
Convert the implementation and all users of the blink.mojom.EmbeddedFrameSinkClient and blink.mojom.EmbeddedFrameSinkProvider interfaces. Bug: 955171, 978694 Change-Id: I243ae820f696410f1b23b894823ef8ebb168558a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764155 Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
Emily Stark <estark@chromium.org> Cr-Commit-Position: refs/heads/master@{#690319}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 65f87ce1. With Chromium commits locally applied on WPT: 1194775a "Add ability to block same-origin access via document-access feature policy" 5546163a "Temporarily send `Sec-Fetch-*` headers via non-secure transport." 4afcd1a6 "Started implementing the STAPIT algorithm" d7f933bd "Revert "Started implementing the STAPIT algorithm"" d3b97055 "Update simulateUserActivation to match webxr-test-api spec" 6a3beaa9 "[WPT/referrer-policy] Fix races around history.back()" 2d090a27 "[WPT/referrer-policy] Call getRequestURLs() for each subtest" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: rego@igalia.com: external/wpt/css/css-grid NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: I8cef577c762b534931a225d759b2334b8f3415cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1770483Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#690318}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/src/third_party/freetype2.git/+log/734d60f63cfa..7d1d3b9a0e93 git log 734d60f63cfa..7d1d3b9a0e93 --date=short --no-merges --format='%ad %ae %s' 2019-08-26 wl@gnu.org [type1] Fix `FT_Get_Var_Axis_Flags' (#56804). Created with: gclient setdep -r src/third_party/freetype/src@7d1d3b9a0e93 The AutoRoll server is located here: https://autoroll.skia.org/r/freetype-chromium Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux-blink-rel;luci.chromium.try:mac10.12-blink-rel;luci.chromium.try:mac10.13_retina-blink-rel;luci.chromium.try:win10-blink-rel;luci.chromium.try:win7-blink-rel TBR=bungeman@google.com,drott@google.com,thestig@google.com Bug: None Change-Id: I622f21a277f0a3efcd803e9717fae66096e55513 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1771377Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#690317}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/3c6b2e1613c8..39e2669a3e92 git log 3c6b2e1613c8..39e2669a3e92 --date=short --no-merges --format='%ad %ae %s' 2019-08-26 angle-autoroll@skia-public.iam.gserviceaccount.com Roll ./third_party/spirv-tools/src aef8f92b2bb6..1eb89172a82b (3 commits) Created with: gclient setdep -r src/third_party/angle@39e2669a3e92 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=cwallez@chromium.org Bug: chromium:None Change-Id: I3d8a9b3f7c68e5557dac6ad22487f9efb0affce7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1771291Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#690316}
-
Clemens Arbesser authored
This is a reland of 8ee4ef1c Original change's description: > [Autofill Assistant] Let payment request action collect login details. > > This CL adds a new optional section to the payment request: Login details for <domain>. The intent is to let users choose from a list of login options such as 'guest checkout' and 'username@example.com'. Currently, the list may contain custom options (like 'guest checkout') as well as login details stored in the Chrome password manager. The chosen login option is returned to the server. In the case of Chrome PWM logins, the chosen login details are stored in client memory. > > As a special case, if there is no meaningful choice to make in the login section, the section is not shown and the choice is made implicitly. > > This CL only adds the required changes to query and store the login details in the client. There will be a separate CL to read the login details from client memory and autofill the username/password fields. > > Screenshots of the new feature: > - Collapsed: https://screenshot.googleplex.com/uUrpn6jatko.png > - Expanded: https://screenshot.googleplex.com/RKNxrjLvMcJ.png > > Bug: b/128833341 > Change-Id: I204a471f67a3f8856cead71080dd5184846c2090 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1713559 > Commit-Queue: Clemens Arbesser <arbesser@google.com> > Reviewed-by: Vadym Doroshenko <dvadym@chromium.org> > Reviewed-by: Jordan Demeulenaere <jdemeulenaere@chromium.org> > Reviewed-by: Stephane Zermatten <szermatt@chromium.org> > Cr-Commit-Position: refs/heads/master@{#689488} Bug: 997124 Bug: b/128833341 Change-Id: I3d01c2cc502dfe36325a98223a147e5c1a50e179 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1768519 Commit-Queue: Clemens Arbesser <arbesser@google.com> Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Reviewed-by:
Stephane Zermatten <szermatt@chromium.org> Cr-Commit-Position: refs/heads/master@{#690315}
-
Christian Dullweber authored
Set NetworkIsolationKey for LoadBasicRequest() in browser_test_utils.cc Similar to site_for_cookies, the NetworkIsolationKey is set to the origin of the url that is requested. Bug: 989067 Change-Id: Idf25303d3fecb0079ab74184765d66999649ae64 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764198Reviewed-by:
Yao Xiao <yaoxia@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#690314}
-
Antonio Gomes authored
... instead of stack allocated. This is a precusor CL for making use of ApplyConstraintsRequest directly in user_media_client.cc|h and apply_constraints_processor.cc|h, instead of its Blink-exposed wrapper class, WebApplyConstraintsRequest. This is needed because ApplyConstraintsRequest is GC-ed by OilPan, so being UserMediaClient::Request the class that will own it, it needs to be (Oilpan) heap allocated. In a follow up step [1], it was changed to on-Oilpan-heap allocation. [1] https://crrev.com/c/1768778 BUG=704136 R=guidou@chromium.org, haraken@chromium.org Change-Id: I7b3965d892f99a93d12d65ffee3140f08caafbd1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1768789 Commit-Queue: Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Auto-Submit: Antonio Gomes <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/master@{#690313}
-
Jose Dapena Paz authored
IWYU: std::unordered_map with value type OptimizationGuideNavigationData requires that type declaration Fix compilation in GNU stdc++ due to missing declaration of the full type: ../../chrome/browser/optimization_guide/optimization_guide_web_contents_observer.h:22:7: note: forward declaration of ‘class OptimizationGuideNavigationData’ class OptimizationGuideNavigationData; ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Bug: 957519 Change-Id: I9d792c0f288d6544e10cd419adf4d845535aaea9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1768337Reviewed-by:
rajendrant <rajendrant@chromium.org> Commit-Queue: José Dapena Paz <jose.dapena@lge.com> Cr-Commit-Position: refs/heads/master@{#690312}
-
Fredrik Söderquist authored
Since we return false for 'display: contents' in the relevant LayoutObjectIsNeeded() override, we shouldn't need to check for it again here. Bug: 997176 Change-Id: I589ea2291aa2ef31a6ea68d5e8a882251f587ec4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1768459Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#690311}
-
Henrique Ferreiro authored
Convert the implementation and all users of the blink.mojom.CrashMemoryMetricsReporter interface. Bug: 955171, 978694 Change-Id: Id46e1be52ee85bbc774171badc1a789b26b62edf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761275 Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#690310}
-
Chris Harrelson authored
The feature has been in stable for > 2 years. Change-Id: Ibf9969d1cb85ede86280c89e26a30e579522fe14 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1766456Reviewed-by:
Stefan Zager <szager@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#690309}
-
Koji Ishii authored
r690293 crrev.com/c/1768486 fixed the same DCHECK signature, hence removing from TestExpectations. TBR=eae@chromium.org Bug: 992920 Change-Id: Ib84cd2edfd795e6af6e84a001715ff49d66d0d40 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1771362Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#690308}
-
Vasilii Sukhanov authored
It's flaky on multiple platforms. TBR=engedy@chromium.org Bug: 997410 Change-Id: I3e0cb6afededbdf39d7d225ecb822243d4f6bf14 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1768766Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#690307}
-
Christian Dullweber authored
CookieControls should be configurable to be enabled globally or just in incognito mode. Incognito is enabled by default. Bug: 967668 Change-Id: Iafb995fc8a747ce4f0ceb57519b358c996c99bee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764129 Commit-Queue: Christian Dullweber <dullweber@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Huanzhong Huang <huanzhong@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Cr-Commit-Position: refs/heads/master@{#690306}
-
Gyuyoung Kim authored
This reverts commit 483de1b0. This CL changes hid.mojom-blink.h include with hid.mojom.h to fix the build break on the linux-chromeos-rel bot. Bug: 955171 Change-Id: I7849bc89265caf578e076451d5d853f3a5bc7105 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1767462Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Cr-Commit-Position: refs/heads/master@{#690305}
-
Mathias Carlen authored
This patch reuses an existing mock for the PersonalDataManager and gets rid of the local one. Also, the DirectCallback can just be a mock callback instead. R=arbesser@google.com Bug: 806868 Change-Id: I34c5d06513599e2e07b9b8d65cbbb10faeb810ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1768430Reviewed-by:
Clemens Arbesser <arbesser@google.com> Commit-Queue: Mathias Carlen <mcarlen@chromium.org> Cr-Commit-Position: refs/heads/master@{#690304}
-
Chih-Yu Huang authored
We should gracefully handle unknown pixel format instead of crashing the GPU process. This CL replaces LOG(FATAL) by LOG(ERROR) in v4l2_device.cc. BUG=chromium:997098 TEST=Run video_decode_accelerator_tests and video_encode_accelerator_unittests on kevin Change-Id: Ib378a06ffb201139585d5afbb87d279370af0bae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1767299 Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#690303}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/aef8f92b2bb6..1eb89172a82b git log aef8f92b2bb6..1eb89172a82b --date=short --no-merges --format='%ad %ae %s' 2019-08-23 8729214+jonahryandavis@users.noreply.github.com Add missing files to BUILD.gn (#2809) 2019-08-22 afdx@google.com Extend reducer to remove relaxed precision decorations (#2797) 2019-08-22 stevenperron@google.com Handle Id overflow in private-to-local (#2807) Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@1eb89172a82b The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64 TBR=radial-bots+chrome-roll@google.com,cwallez@chromium.org Bug: None Change-Id: I841c2fbd611193aa9dcdf39f683b07ab0b9ab5bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1771378Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#690302}
-
Jonas Olsson authored
This experiment was stopped a while ago after I mistook a configuration error for a regression. It has since been removed from the testing config. This CL restores it with the updated key. It also removes an entry that was erroneously added earlier. Bug: chromium:941413 Change-Id: I4504fdbaa026bba2bc715d492f59be0dba7efa4d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1768425Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Jonas Olsson <jonasolsson@chromium.org> Cr-Commit-Position: refs/heads/master@{#690301}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/edb35190808c..271fe862460b Created with: gclient setdep -r src-internal@271fe862460b The AutoRoll server is located here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None,chromium:None Change-Id: Ib0065f1ead9fae4bde5844973137587391735001 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1771376Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#690300}
-
Vasilii Sukhanov authored
The test is flaky on multiple platforms. TBR=yigu@chromium.org Bug: 968970 Change-Id: I52258bf986f6a6517fa2545eb528dcc40ae2891e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1769439Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#690299}
-
Miyoung Shin authored
This CL converts ServiceWorkerStreamCallback{Ptr, Request} in content and blink to the new Mojo types, and uses pending_receiver<ServiceWorkerStreamCallback> in service_worker_stream_handle.mojom. Bug: 955171, 978694 Change-Id: I0eb07b02a08965124864022c2e1a9403efa9b0d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1767470 Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#690298}
-
Vasilii Sukhanov authored
https://ci.chromium.org/p/chromium/builders/ci/Mac10.10%20Tests TBR=sophiechang@chromium.org Bug: 997106 Change-Id: I07d9e12a2939ff9084587e555f897cb6716e365c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1768432Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#690297}
-
Rune Lillesveen authored
We used to have a descendant invalidation set for :nth-selectors which was scheduled on the parent node of those elements potentially affected by DOM mutations. The problem was that such sets would invalidate a bunch of descendants of affected siblings in the case where the invalidation set features are common like tag names. E.g.: div:nth-of-type(2n) {} Would have an invalidation set invalidating all div siblings, but also all their div descendants. Instead we make the nth invalidation set a sibling invalidation set. It is still scheduled on the parent node, but pushed as a sibling invalidation set on SiblingData before we start invalidating the children. The new NthSiblingInvalidationSet initially sets the max_direct_adjacent_selectors_ count to the max value to make sure the sibling invalidation reaches all siblings. This fixes a performance issue for salesforce.com. Bug: 992160 Change-Id: Ibe2d28da95286185cdebc7894b029e8741a6216c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1763761Reviewed-by:
Eric Willigers <ericwilligers@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#690296}
-
Eric Willigers authored
We introduce a queue for default installed PWAs, to load their service worker resources after they install. When we have install all pending PWAs, we loop through newly installed PWAs, load their launch URL, and wait for the service worker to be registered (indicating the install event has completed). If an additional PWA must be installed while the service worker has not yet completed registration, we preempt that attempted registration, and install the new PWA without delay. Design doc: https://docs.google.com/document/d/1ljz3WrMA2eT5T633KBV71NOdrPaFNQ-x3flztl7PZR8/edit?usp=sharing Bug: 905898 Change-Id: I6ba282a9759f802cd3011943f1fbe4e4ecfa2c02 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1757716 Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Reviewed-by:
calamity <calamity@chromium.org> Cr-Commit-Position: refs/heads/master@{#690295}
-
Yuki Shiino authored
Implements CodeGeneratorInfo{,Mutable} as immutable and mutable information for bindings generators respectively. Bug: 839389 Change-Id: Ia872b2f5aa5fd2b80a122f006ced06dae0b596c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1768480 Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#690294}
-
Koji Ishii authored
r684910 (crrev.com/c/1742250) changed LayoutNG to include close tags after a forced break. This broke an assumption in |NGInlineNode::ComputeMinMaxSize| that there are no objects after a forced break. This patch fixes the min-content size for the situation by applying the same rule to |NGInlineNode::ComputeMinMaxSize|. The test hits DCHECK failure without the fix because the fast code path computes the different max-content from the slow code path. Bug: 991320 Change-Id: I3e9106fddc1fce5a2a7576fc4f75b77b5d4b8b61 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1768486 Commit-Queue: Emil A Eklund <eae@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#690293}
-
Koji Ishii authored
This patch changes |NGTextFragmentPainter| and |NGTextPainter| to support |NGFragmentItem| in addition to |NGPaintFragment|. A few things, such as document marker or text decorations are not supported yet. Bug: 982194 Change-Id: I714aaa145558f26bf2d592f3a1772fd6e5d903e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1758030Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Commit-Queue: Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#690292}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/d25be188882c..ba57aa2b4a60 git log d25be188882c..ba57aa2b4a60 --date=short --no-merges --format='%ad %ae %s' 2019-08-26 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update Go deps 2019-08-26 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 17f26865c8cc..3c6b2e1613c8 (17 commits) 2019-08-26 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ../src edb7520e..26bef937 (465 commits) Created with: gclient setdep -r src/third_party/skia@ba57aa2b4a60 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=stani@google.com Bug: chromium:None,chromium:None Change-Id: I562cab10879eaa90cc405d56d66d44131660fc74 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1771237Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#690291}
-
Yuki Shiino authored
IdentifierIRMap is a bit long name, and it turned out that idenfiers don't play that important role. IRMap is a clear and short name. Also drops unused features of IRMap. Bug: 839389 Change-Id: I1d325e9dd2e8421f2662357ebdd4c3e579f069f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1768843 Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#690290}
-
Koji Ishii authored
This patch moves ink-overflow data for |NGPhysicalTextFragment| to |NGInkOverflow|, and let |NGPhysicalTextFragment| to have a pointer. This saves memory, in addition to preparing to share code with |NGFragmentItem|. This data was once on the rare-data on |NGPhysicalTextFragment|, but then moved to inside of |NGPhysicalTextFragment| when the rare-data was removed and we assumed ink-overflow for text is more common than we thought. Here's a list of ratios where text runs have ink-overflow: Google home: 17% Google SRP: 38% youtube.com: 3% twitter.com: 43% facebook.com: 28% Because |NGInkOverflow| is 16 bytes (assuming FASTMALLOC has no alloc overheads), the consumed memory is on par at 75% on 32-bit systmes and at 50% on 64-bit systems. Bug: 982194 Change-Id: I657a742126d58b9204d3fb8a9ec919eca36f0577 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1768489Reviewed-by:
Emil A Eklund <eae@chromium.org> Commit-Queue: Emil A Eklund <eae@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#690289}
-
Hiroshige Hayashizaki authored
Previously, getRequestURLs(), PolicyDelivery/Subresouce object creation etc. were done once per test HTML file and reused among multiple subtests. This CL introduces invokeScenario() that does these things and calls invokeScenario() for each subtest, and thus calls getRequestURLs() for each subtest. This removes hacky modifications to `subresource.url` in 4K-referrer-length-related subtests to avoid cache hit. Also this makes subresource URLs unique for srcdoc-related subtests (previously the same image URL was used). Bug: 906850 Change-Id: I894a902338a90526678b70d01857103f46984189 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1723013 Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#690288}
-
Rachel Wong authored
Bug: 959679 Change-Id: Ide0d6afe4181459e5ac0dd8259fcc0dc296823e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1771105Reviewed-by:
Tony Yeoman <tby@chromium.org> Commit-Queue: Rachel Wong <wrong@chromium.org> Cr-Commit-Position: refs/heads/master@{#690287}
-
Koji Ishii authored
This patch impelments copying layout data from |NGFragmentItem| to |LayoutObject|. Unfortunately we could not share the logic with the current code because the current code traverses |NGPhysicalFragment|, not |NGPaintFragment|. The logic is stable for a long time, this patch copies the logic and expects the current code to be gone when the transition is complete. Bug: 982194 Change-Id: Ied1d0da59f19aac75d4a025683934433f35c04b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1757715 Commit-Queue: Emil A Eklund <eae@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#690286}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/d5163953610a..81a5ea6cf04a git log d5163953610a..81a5ea6cf04a --date=short --no-merges --format='%ad %ae %s' 2019-08-26 vapier@chromium.org replace itertools.i{map,zip} with six.moves.{map,zip} Created with: gclient setdep -r src/third_party/chromite@81a5ea6cf04a The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I38f825a23c69a144a85847cb78916717f9def28a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1771236Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#690285}
-
Yuki Shiino authored
Cleans up web_idl.Includes and completes its implementation (by removing unused implementations). Bug: 839389 Change-Id: I44cb8f04d1fdc34c6b7ddbded25f8d55193bda55 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1768597Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#690284}
-
Yuki Shiino authored
Makes make_copy makes a copy with the same structure as the original object has. Like |deepcopy| uses |memo| argument, make_copy uses |memo| argument, too. ExtendedAttribute(s)'s __eq__ are replaced with |equals| class method so that __eq__ works on the object identity. This is necessary to make |memo| above work. Bug: 839389 Change-Id: I5896ef07787dd0086f510ae4102a5f538a9b5c56 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1765098Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#690283}
-
Yuki Shiino authored
Removes web_idl.IdlMember which is practically unused. Bug: 839389 Change-Id: Ie06f7dd2f79aeb02d3fd74633a8fd866517fa58e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1768598Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#690282}
-
Yuki Shiino authored
Super minor clean up without a change on code. Bug: 839389 Change-Id: I6be0c51f65507fadbb416975c3c772668d4d524e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1768842Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#690281}
-