- 04 Feb, 2020 40 commits
-
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/2fca97168bfe..0f6bcd18b2ef git log 2fca97168bfe..0f6bcd18b2ef --date=short --first-parent --format='%ad %ae %s' 2020-02-04 sakal@webrtc.org Hold a reference to AndroidVideoTrackSource while calling onFrameCaptured. 2020-02-04 kwiberg@webrtc.org Define rtc::BufferT::const_iterator 2020-02-04 eshr@google.com Configure QP scaler in adaptation module 2020-02-04 kron@webrtc.org Fix links Created with: gclient setdep -r src/third_party/webrtc@0f6bcd18b2ef If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: Ideb0af8eb9746e726ad569b7836d2815cc6c98ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2037611Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#738288}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/bf3087f65d6a..a2406f9218a3 git log bf3087f65d6a..a2406f9218a3 --date=short --first-parent --format='%ad %ae %s' 2020-02-04 robertphillips@google.com Fix BC1 SW decompression on platforms with RGBA PM color order 2020-02-04 brianosman@google.com Ignore warnings when compiling MSL 2020-02-04 fmalita@chromium.org Potentially-uninitialized Sk3LookAt result 2020-02-04 mtklein@google.com tweak screen math 2020-02-04 robertphillips@google.com Fix SW decompression of BC1 and add a GM to check it (take 2). 2020-02-04 ehmaldonado@google.com Modify PostUploadHooks to remove dependency on cl objects. 2020-02-04 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 49a53d684aff..aa6dd50de0c5 (5 commits) 2020-02-04 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2020-02-04 mtklein@google.com Reland "unorm/unorm -> to_unorm/from_unorm" 2020-02-03 reed@google.com Reland "add skvm for tablecolorfilter" 2020-02-03 mtklein@google.com gather pointers are not necessarily aligned 2020-02-03 mtklein@google.com Revert "add skvm for tablecolorfilter" 2020-02-03 mtklein@google.com Revert "unorm/unorm -> to_unorm/from_unorm" 2020-02-03 mtklein@google.com Revert "impl gather8/gather16 with gather32" 2020-02-03 herb@google.com Arrange atlas image processing by frequency 2020-02-03 jvanverth@google.com Fix timeout for Metal compiler. 2020-02-03 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2020-02-03 robertphillips@google.com Revert "Fix SW decompression of BC1 and add a GM to check it." 2020-02-03 robertphillips@google.com Fix SW decompression of BC1 and add a GM to check it. 2020-02-03 egdaniel@google.com Have GrTextureProducer return views instead of proxies. 2020-02-03 mtklein@google.com unorm/unorm -> to_unorm/from_unorm 2020-02-03 herb@google.com Move the bulk glyph calls up the stack Created with: gclient setdep -r src/third_party/skia@a2406f9218a3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC scroggo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1042324 Tbr: scroggo@google.com Change-Id: I8bd03f4a13c0982d477ff0e06060633c523c6578 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2037423Reviewed-by:
-
chromium-autoroll authored
Also includes a manual modifications to MojoSharedMemory and ProducerEndpoint subclasses to match upstream interface changes. https://android.googlesource.com/platform/external/perfetto.git/+log/349930ee9cd3..30f6fc14e50c git log 349930ee9cd3..30f6fc14e50c --date=short --first-parent --format='%ad %ae %s' 2020-02-04 treehugger-gerrit@google.com Merge "Forward malloc_iterate to dispatch table." 2020-02-04 taylori@google.com Merge "perfetto-ui: Edit track selection with checkboxes" 2020-02-04 treehugger-gerrit@google.com Merge "service: Support producer-provided SMBs service-side" Created with: gclient setdep -r src/third_party/perfetto@30f6fc14e50c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Change-Id: I9890f226c7a59eb236661729d0a347153c5964bd Tbr: perfetto-bugs@google.com Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036008 Commit-Queue: Eric Seckler <eseckler@chromium.org> Reviewed-by:
Eric Seckler <eseckler@chromium.org> Cr-Commit-Position: refs/heads/master@{#738286}
-
Guillaume Jenkins authored
This is the next step into reworking the life cycle of the WindowsSpellChecker global object. - Moved the WindowsSpellChecker object from a static base::NoDestructor in an anonymous namespace to a member of the SpellcheckService class - It was a bug to have a single global instance of WindowsSpellChecker, since it keeps a state based on the profile's preferences. - By moving the ownership to the SpellcheckService, multi-profile spell checking actually works, since now each profile gets its copy. - Because spell check logic is under components/ and SpellcheckService is under browser/, a pointer to WindowsSpellCheck has to be passed around on the components side - Changed the implementation of the WindowsSpellChecker class to use an inner "background helper" class for all background tasks, to ensure sequencing is consistent and life cycle is tied to a background thread - Also shortened the name of the RetrieveSupportedWindowsPreferredLanguages method to "GetSupportedWindowsPreferredLanguages" Bug: 463364, 1035044 Change-Id: I59ab6743f690d70206b630603fe8ab07637db96f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2025949 Commit-Queue: Guillaume Jenkins <gujen@google.com> Reviewed-by:Avi Drissman <avi@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#738285}
-
wutao authored
This cl fixes two issues: 1. When app_list is not active, we should not request focus to assistant_page_view. Otherwise, the active window info will lose so that we cannot get the assistant structure of the active window. 2. The DCHECK of |assistant_tree_| or |assistant_extra_| is not valid because they could be nullptr if there is not such an active window. Bug: b/139363094 Test: manual Change-Id: I3b78688b15047925dc92f613fe9e46b198d864fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2017982 Commit-Queue: Tao Wu <wutao@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#738284}
-
Mike Wittman authored
Provides a native API to query/request module installation and provide interfaces to the native code provided within the module. This API will be used by native code along the lines described in the design doc at https://docs.google.com/document/d/1QB5IzWuVKfoPdPuiyRok2MUEta1FmRLIQkq1wDATA4k. Bug: 1027654 Change-Id: I52fb0a4cfbec06dd603617ed1949fa20fda6ef03 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003299Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Etienne Pierre-Doray <etiennep@chromium.org> Reviewed-by:
Samuel Huang <huangs@chromium.org> Commit-Queue: Mike Wittman <wittman@chromium.org> Cr-Commit-Position: refs/heads/master@{#738283}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/41a7302e9c62..ddee0f34e4cb git log 41a7302e9c62..ddee0f34e4cb --date=short --first-parent --format='%ad %ae %s' 2020-02-04 lfy@google.com android: avoid exporting normal Vulkan APIs Created with: gclient setdep -r src/third_party/swiftshader@ddee0f34e4cb If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: I98a49a34e9c15d8310c964d20e0e38d35c5ea6a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036827Reviewed-by:
-
ssid authored
On renderer processes the action callback is never set. The tracing service checks if a task runner is set and adds a callback for user actions recording when tracing is enabled. This callbcak will record user actions with timestamps in traces. Change-Id: Ic2c5f78a5e62aaf677b9a98a56f185170c570eee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2026191Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
-
Robert Liao authored
BUG=1034666 Change-Id: Ie6628347802d652e02d117a12c65dd9ac0e6e4bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036929 Commit-Queue: Robert Liao <robliao@chromium.org> Auto-Submit: Robert Liao <robliao@chromium.org> Reviewed-by:
Will Harris <wfh@chromium.org> Cr-Commit-Position: refs/heads/master@{#738280}
-
Brandon Walderman authored
Bug: 1048716 A few ChromeDriver tests use the time.time() function to wait for various conditions. We've observed a flakey test failure downstream due to the current time() value being less than the previous time() value. This can happen because time() relies on the system clock which is not guaranteed to be monotonic. Python 3 offers a time.monotonic() function that would suit our needs, but this is not available in Python 2.7. There is a 'monotonic' Python module that polyfills this functionality for Python 2.7. I've updated run_py_tests.py to use monotonic() everywhere time() was used previously. This should improve reliability. Change-Id: I7237daf1124131f824dd389c33f8c28413730c30 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2037349 Commit-Queue: Brandon Walderman <brwalder@microsoft.com> Reviewed-by:
John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#738279}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/43a0a815b814..47b15048a1fa git log 43a0a815b814..47b15048a1fa --date=short --first-parent --format='%ad %ae %s' 2020-02-04 kainino@chromium.org Revert "Use libshaderc_spvc as a source_set, so complete_static_lib applies properly" 2020-02-03 bryan.bernhart@intel.com Vulkan: attempt sub-allocation before direct allocation. 2020-02-03 kainino@chromium.org Use libshaderc_spvc as a source_set, so complete_static_lib applies properly 2020-02-03 rharrison@chromium.org Rolling 4 dependencies Created with: gclient setdep -r src/third_party/dawn@47b15048a1fa If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: chromium:1045811,chromium:1047048,chromium:1047220 Tbr: cwallez@google.com Change-Id: I035c1222c4502693dc2cbdb968ae8d75a5bde261 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036288Reviewed-by:
-
Sergey Ulanov authored
Previously FuchsiaDecryptor was destroying FuchsiaClearStreamDecryptor in the destructor which may run on a thread that's different than the thread on which FuchsiaClearStreamDecryptor was created. Updated FuchsiaDecryptor destructor to delete audio_decryptor_ asynchronously on the right thread. Bug: 1047783 Change-Id: I9c4dc5d7a292078eb632c0c44be6a68cc949b7e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033813 Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
David Dorwin <ddorwin@chromium.org> Auto-Submit: Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#738277}
-
Patrick Monette authored
This CL modifies PerProfileWorkerTaskTracker to also observe events from the DedicatedWorkerService and the SharedWorkerService. Bug: 1041093 Change-Id: I2f8c3e7cebe77ac4235fbee4a1cbb899b9b77b68 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2020403 Commit-Queue: Patrick Monette <pmonette@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#738276}
-
David Benjamin authored
0-RTT inherently involves a race condition: if the server responds with the ServerHello before the client sends the HTTP request (the client may be busy verifying a certificate), the client will send data over 1-RTT keys rather than 0-RTT. To avoid this, wait for both the ClientHello and HTTP request to come in before allowing the test server to respond. This extracts ReadBufferingStreamSocket from SSLClientSocket tests and allows EmbeddedTestServerConnectionListener to wrap the socket. Bug: 1021021 Change-Id: I8199a0b117e0a2718986b2af1e333a8b069fd3a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2029627Reviewed-by:
Steven Valdez <svaldez@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
-
Charlie Hu authored
Bug: 993790 Change-Id: Ic72e0475d6c9ea35d23fcb612d9452fcba1c8835 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032164Reviewed-by:
Ian Clelland <iclelland@chromium.org> Commit-Queue: Charlie Hu <chenleihu@google.com> Cr-Commit-Position: refs/heads/master@{#738274}
-
Michael Thiessen authored
Replaces usages of java.net.URI with GURL. This change is slightly complicated as GURL and URI handle about: URLs differently, in that GURL considers everything after the about: scheme as a path instead of a host/path/etc. This is usually handled in the native code by running FixupUrl on URLs with the about: scheme to convert them into the chrome: scheme (unless they're about:blank or about:srcdoc), and this is how navigation to about:newtab works (by converting it to chrome://newtab). So in order to know if something will resolve to the NTP, we need to first fixup the URL, and then check its host/validity. Bug: 783819 Change-Id: Idf6ad46fa6ef9793a969f3a8ee721c9bb05b97a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2031710 Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Cr-Commit-Position: refs/heads/master@{#738273}
-
Francois Doray authored
With this CL, PageNode::IsLoading() transitions to true when data is received for a top-level navigation to a different document. It transitions to false when the page reaches an "almost idle" state, based on CPU and network quiescence, or after an absolute timeout. This definition of "loading" is considered better to drive policies, as it indicates when the page stops doing work after a navigation, rather than when the page is loading resources (it may still have a lot of Javascript to run to present useful content to the user). Change-Id: I4fc5b277933133229fde7585d6710f63e6b8244d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015820 Commit-Queue: François Doray <fdoray@chromium.org> Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Cr-Commit-Position: refs/heads/master@{#738272}
-
Regan Hsu authored
"moveUp" and "moveDown" keys currently have the incorrect values, IDS_SETTINGS_LANGUAGES_LANGUAGES_ADD, and IDS_SETTINGS_LANGUAGES_LANGUAGES_LIST_ORDERING_INSTRUCTIONS respectively. This CL corrects those values to IDS_SETTINGS_LANGUAGES_LANGUAGES_LIST_MOVE_UP and IDS_SETTINGS_LANGUAGES_LANGUAGES_LIST_MOVE_DOWN respectively. Bug: 1048562 Change-Id: I115cffac1828ac068fee0260653d94b5da2a4ec3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036800Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Regan Hsu <hsuregan@chromium.org> Cr-Commit-Position: refs/heads/master@{#738271}
-
Austin Eng authored
TBR=kbr@chromium.org Bug: 1026588 Change-Id: I6563d489eaa3ea91879e0810f8373b721e1fa75b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036541Reviewed-by:
Austin Eng <enga@chromium.org> Commit-Queue: Austin Eng <enga@chromium.org> Cr-Commit-Position: refs/heads/master@{#738270}
-
Chrome Metrics Logs authored
Updates the expires_after attribute for 182 histograms that show frequent access in the past 90 days. These are the 90% most frequently used histograms over that time that do not already have a date later than or within 60 days of 2020-08-02. Change-Id: I5abbcfcdfe89f4efdd3663b7163084d93a427216 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2037590 Commit-Queue: Chrome Metrics Logs <chrome-metrics-team+robot@google.com> Commit-Queue: Brian White <bcwhite@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#738269}
-
Michael Thiessen authored
Also adds unit tests for the UrlFormatter java wrapper which didn't previously exist. Bug: 783819 Change-Id: Ib98bd5daa64a48bb06d6593185f53f49ad22b3c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036730 Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Chris Palmer <palmer@chromium.org> Cr-Commit-Position: refs/heads/master@{#738268}
-
Sam Bowen authored
Bug: 1044249 Change-Id: I163919382fd8d40a2355a8da71d72db68018e131 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2023864Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Sam Bowen <sgbowen@google.com> Cr-Commit-Position: refs/heads/master@{#738267}
-
Saman Sami authored
Add base::ScopedAllowBaseSyncPrimitivesOutsideBlockingScope to all methods in DrmThreadProxy that block. Fixed: 1047827 Change-Id: I0ff3239d85264244dd6f5a0098ee18daa3c4960e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033633 Commit-Queue: Saman Sami <samans@chromium.org> Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Reviewed-by:
kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#738266}
-
Natalie Chouinard authored
An empty public constructor should be kept for all Fragments, not just those in Settings. This change also allows us to move settings code alongside respective feature code (see bug). Bug: 1047357 Change-Id: I9e776766be4a693622150b58db5e057447118fe2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036872 Commit-Queue: Natalie Chouinard <chouinard@chromium.org> Reviewed-by:
Sam Maier <smaier@chromium.org> Cr-Commit-Position: refs/heads/master@{#738265}
-
David Benjamin authored
https://boringssl.googlesource.com/boringssl/+log/1cc95ac07c17d61bea601832bbdc1f8d13d313db..bc7e2cb92d948de5f437e5eef2b1c3ad6281bb35 Bug: none Change-Id: Iedfd6ebcd581f76c1794b3eddad2d46b701681e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2028292 Auto-Submit: David Benjamin <davidben@chromium.org> Reviewed-by:
-
Lijin Shen authored
The tests are flaky on Android K & L. It shows the ntp is scrolled down on launching the activity, but the reason has not been figured out. Launching activity on blank page can prevent the startpage from being scrolled down. Bug: 1046317, 1046316, 1045729, 1045415 Change-Id: I1d14f15218ad8a1e1ceac9c0a7bbfc1d49008700 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2028212Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Yue Zhang <yuezhanggg@chromium.org> Commit-Queue: Lijin Shen <lazzzis@google.com> Cr-Commit-Position: refs/heads/master@{#738263}
-
Sammie Quon authored
Replaces the old three view setup which was used before we could apply rounded corners directly on layers. Tested manually on LTR and RTL on all 4 orientations. Visually no difference. Ran ui.OverviewDragWindowPerf.drag_to_snap. Not noticeable improvements on caroline, but input latency goes from 95ms to 80ms on krane. Test: added tests Bug: 1047778 Change-Id: Idff6345fb5778d2e898bc51cd76bd7eac3c1741d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033564 Commit-Queue: Sammie Quon <sammiequon@chromium.org> Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Cr-Commit-Position: refs/heads/master@{#738262}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/11cc3e8ebc7e..00a610e6768c git log 11cc3e8ebc7e..00a610e6768c --date=short --first-parent --format='%ad %ae %s' 2020-02-04 tvanderlippe@chromium.org Add console uncaught promises e2etest 2020-02-04 tvanderlippe@chromium.org Add console BigInt e2etest Created with: gclient setdep -r src/third_party/devtools-frontend/src@00a610e6768c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1047671 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I9636eebb47752d04bc4275160b5cbc7a2c7cd20c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2037428Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium d7e04a27. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: binji@chromium.org: external/wpt/wasm drott@chromium.org: external/wpt/css/css-text-decor foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools foolip@chromium.org, robertma@chromium.org, smcgruer@chromium.org: external/wpt/infrastructure kojii@chromium.org: external/wpt/css/css-scoping rego@igalia.com: external/wpt/css/css-grid NOAUTOREVERT=true TBR=foolip No-Export: true Change-Id: I0620a3e84cd0f6a301f9d69a11bd5b0fbb4dbe98 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2037386Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#738260}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/ebf2bec1675c..2e4a40aa1bf4 git log ebf2bec1675c..2e4a40aa1bf4 --date=short --first-parent --format='%ad %ae %s' 2020-02-04 ntfschr@chromium.org Devil: throw if app is not installed Created with: gclient setdep -r src/third_party/catapult@2e4a40aa1bf4 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC rmhasan@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1047845 Tbr: rmhasan@google.com Change-Id: Ic40a666f469a4172508c2b3392eaca10f3bc6aae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2037418Reviewed-by:
-
Kyle Horimoto authored
Change-Id: I83b63ec5e2c94535b6b1a9a67bc0c36cb4fa6de9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2037322 Auto-Submit: Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#738258}
-
Nate Fischer authored
This uses a public URL for the "URL:" field in the README. Apparently this is the URL which is shown by chrome://credits/ for Chrome on all platforms, so it's not helpful to link to "go/ab." This expands the README text to point to the internal guidelines for updating this dependency, which should already be more helpful than pointing at go/ab directly. Bug: 1045626 Test: tools/licenses.py scan | grep 'android_system_sdk' Test: build chrome, navigate to chrome://credits, click "homepage" link Change-Id: Id2e34ffb52dbe8e0f64c3f50ea653f9133a35871 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036969 Commit-Queue: Nate Fischer <ntfschr@chromium.org> Auto-Submit: Nate Fischer <ntfschr@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Cr-Commit-Position: refs/heads/master@{#738257}
-
Raul Tambre authored
Since the file is now written in binary mode, newline translation is no longer a concern and is consistent across platforms. [14/39932] ACTION //chrome/browser/resources/settings:modulize(//build/toolchain/win:win_clang_x64) Traceback (most recent call last): File "../../ui/webui/resources/tools/js_modulizer.py", line 154, in <module> main(sys.argv[1:]) File "../../ui/webui/resources/tools/js_modulizer.py", line 150, in main ProcessFile(os.path.join(in_folder, f), out_folder, namespace_rewrites) File "../../ui/webui/resources/tools/js_modulizer.py", line 128, in ProcessFile f.write(unicode(l, 'utf-8')) NameError: name 'unicode' is not defined Bug: 941669 Change-Id: I7aa0aa834944e4505f9045026e3d32315740140b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033509 Auto-Submit: Raul Tambre <raul@tambre.ee> Reviewed-by:Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Raul Tambre <raul@tambre.ee> Cr-Commit-Position: refs/heads/master@{#738256}
-
Avery Musbach authored
When you drag a window from the shelf and drop into overview, it shall be positioned correctly and stacked correctly. Test: ash_unittests DragWindowFromShelfControllerTest.DropsIntoOverviewAtCorrectPosition Change-Id: I198084bfe644c70de00d6824623106dff1776f63 Fixed: 1047821 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032797Reviewed-by:
-
inglorion authored
This adds linker wrappers that will cause ThinLTO builds to distribute code generation using Goma. This commit only checks in the wrappers; it does not enable them. R=hans,gbiv,rnk,thakis Bug: 877722 Change-Id: I9ed766f3cf094a1591eceb4933e00d005e739c84 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2008005 Commit-Queue: Bob Haarman <inglorion@chromium.org> Reviewed-by:
Hans Wennborg <hans@chromium.org> Reviewed-by:
George Burgess <gbiv@chromium.org> Cr-Commit-Position: refs/heads/master@{#738254}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/3a1145d2eb00..755ff85d1885 Created with: gclient setdep -r src-internal@755ff85d1885 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1048655 Tbr: jbudorick@google.com Change-Id: I43a39e4f8737148bf99d54fb5cf6f4b7502f9213 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2037429Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#738253}
-
Himanshu Jaju authored
Tracks the result of receiving a SharingMessage via WebRTC. Logs the result to UMA. Bug: 1021984 Change-Id: I89a87e249204bd8421ef03165f2ad23c361a0af9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036001Reviewed-by:
Richard Knoll <knollr@chromium.org> Commit-Queue: Himanshu Jaju <himanshujaju@chromium.org> Cr-Commit-Position: refs/heads/master@{#738252}
-
Nicolas Ouellet-Payeur authored
This is a reland of c2b90515 TBR=rhalavati@chromium.org Original change's description: > [Traffic Annotation] Fail on CQ on C++ parsing error > > Previously, CQ would pass if extractor.py failed at parsing the C++ > declaration. With this CL, parsing errors make CQ turn red (to avoid > committing code that will make linux-annotator-rel fail). > > Also, always rerun extractor.py when there's an error to get stderr > contents. Previously, when running with --error-resilient, it wouldn't > re-run the Clang tool. This saved several minutes on CQ, but didn't > report a useful error message. Since extractor.py is _much_ faster, > the tradeoff is different: the error message is more important than > the couple of seconds saved. > > Finally: slightly improve extractor.py's error reporting when it fails > to parse the annotation declaration. This makes it more actionable and > gives better context to the CL author. > > TESTED=traffic_annotation_auditor_unittests, extractor_test.py, > annotation_tokenizer_test.py > > Bug: 1046794 > Change-Id: Id397dcfcced39fbebf72ffcdc6d6549c66c2910f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2028707 > Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org> > Reviewed-by: Ramin Halavati <rhalavati@chromium.org> > Cr-Commit-Position: refs/heads/master@{#737039} Bug: 1046794 Change-Id: Ia7672de311a2ab32bf7d45d7f379e60a96e92d47 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036794 Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org> Reviewed-by:
Nicolas Ouellet-Payeur <nicolaso@chromium.org> Auto-Submit: Nicolas Ouellet-Payeur <nicolaso@chromium.org> Cr-Commit-Position: refs/heads/master@{#738251}
-
Owen Min authored
CloudReporting observers ProfileManager and few KeyedServices. It needs to be turned down before Profile system so that these observers can be removed properly. Adding a browser test to verify the issue which waits until cloud reporting fully launched and shutdown. Bug: 1047619, 1047886 Change-Id: I28620dd0f8265bb10c4139eb24bad24dcaf94ea0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033435Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Commit-Queue: Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#738250}
-
Xing Liu authored
This CL adds a few missing deps for announcement notification system. Currently there is no build failure. Check command: gn check out/Debug //chrome/browser/updates/announcement_notification Refactor that requires large code change needs to be merged after M81. Bug: 1048346 Change-Id: I7f262d646c618841614a35e5f7962becb662c3f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036915Reviewed-by:
Hesen Zhang <hesen@chromium.org> Commit-Queue: Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#738249}
-
