- 14 Oct, 2020 40 commits
-
-
Olivier Robin authored
Equivalent call on desktop https://source.chromium.org/chromium/chromium/src/+/master:chrome/browser/lifetime/browser_shutdown.cc;l=251 Bug: 1129656 Change-Id: I1d3fa02d942190f32400bc3032aa20fe31c4d338 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2421735Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#816952}
-
Xiaocheng Hu authored
The function has too many parameters. This patch refactors the parameters into a struct to ease code reading and maintenance. Bug: 1137633 Change-Id: I0123a0c8e5c98d538d6ac7e652ea0797dbf19b27 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2469360 Commit-Queue: Dominik Röttsches <drott@chromium.org> Auto-Submit: Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by:
Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#816951}
-
Monica Basta authored
Bug: 1121215 Change-Id: Ib3d5fc7ce397c56c19dcfdec8261c5a65ab252a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461236Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
Weilun Shi <sweilun@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Monica Basta <msalama@chromium.org> Cr-Commit-Position: refs/heads/master@{#816950}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/0150a791fcb7..19ee1c94588a 2020-10-14 primiano@google.com Merge "init: mkdir /data/misc/perfetto-configs" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I63b7d6b9c977da66c8cac1248e8a291b95057376 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2470257Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#816949}
-
Luciano Pacheco authored
This is the last batch of dependencies from Files app. Add the entries in the GRD file for files in this CL and for CL:2440331. Bug: 1133198, 1134497, 1023038 Change-Id: I6f8026679f411629d3334f2f85d054245d7afb86 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2470036Reviewed-by:
dpapad <dpapad@chromium.org> Commit-Queue: dpapad <dpapad@chromium.org> Auto-Submit: Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#816948}
-
Alice Wang authored
This CL adds the metric SignedInWithAddedAccount for the web sign-in flow when a user added an account and signed in with the account. Bug: 1136776 Change-Id: Icb79b2a8cd187aa85e82928692575a351946b888 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2464266 Commit-Queue: Alice Wang <aliceywang@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#816947}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/9580f3b4c530..39b5e771cd8e 2020-10-14 syoussefi@chromium.org Vulkan: Fix vector size issue with clearWithCommand 2020-10-14 syoussefi@chromium.org Vulkan: Regression test for content defined of AHB images 2020-10-14 syoussefi@chromium.org Vulkan: Don't break the render pass on scissored clears 2020-10-14 syoussefi@chromium.org Vulkan: Regression test for content defined of external images If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC ynovikov@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: ynovikov@google.com Change-Id: Ibce48308805c6c8b1da1cf2b598b33b9da7407d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2469711Reviewed-by:
-
Olivier Robin authored
This CL switches the polling ShutdownCheck method to with a direct call to g_pingResultEvent->SignalShutdown(); when g_URLLoaderFactory is reset to nullptr. The polling approach does not work because the delayed task is not executed on shutdown. It is also not needed to poll for shutdown event as the only trigger is the reset of g_URLLoaderFactory value. Bug: 1129656 Change-Id: I70adbf30903cbd31dabf572ac5fd3bfc2c01c7a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424307Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Roger Tawa <rogerta@chromium.org> Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#816945}
-
Victor Hugo Vianna Silva authored
The goal of this CL is to make it clearer in future CLs that DataTypeDebugInfoEmitter can be replaced by simpler code, probably a single function. No behavior is changed. Context: Currently, users of the DTDIE call GetMutable*Counters() to increase some members of its [Commit/Update]Counters, then call Emit*CountersUpdate(), which records UMA based on the deltas of some of these members since the last Emit*CountersUpdate() call. For the UpdateCounters, the emit method is always called "right after" altering the counters, i.e. each pair of calls happens inside a single method of ModelTypeWorker. For the CommitCounters those methods are called in different moments of the lifetime of CommitContributionImpl, but at least they are only used in that layer. The implication of the above is that: 1) Any member of [Commit/Update]Counters that's unused in DTDIE can be removed without behavior change. 2) Any call to DTDIE::GetMutable*Counters() that was used to modify members in (1) can also be removed without behavior change. 3) This DTDIE::EmitUpdateCounters() call [1] can be removed, since it's guaranteed to only emit the modifications caused by the GetMutableUpdateCounters() call 2 lines above, which is now removed due to (2). Note that this if check is important [2]. These removals are interesting because they leave only 1 call of each method of DTDIE in the code, making it easier to reason about the UMA recording. As a bonus, the CL inlines the UpdateCounters and CommitCounters structs inside DTDIE, since their files would soon be removed anyway. [1] https://source.chromium.org/chromium/chromium/src/+/189eb2b0b8589ee2decbfc18aae093397f760ba8:components/sync/engine_impl/model_type_worker.cc;l=379 [2] https://source.chromium.org/chromium/chromium/src/+/189eb2b0b8589ee2decbfc18aae093397f760ba8:components/sync/engine_impl/cycle/data_type_debug_info_emitter.cc;l=34 Bug: 1137896 Change-Id: I0f64d2f8d9e81f23e59cc69e3649f1a2ced2371d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2470621 Commit-Queue: Victor Vianna <victorvianna@google.com> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#816944}
-
Mihai Sardarescu authored
The experiment console orders the buckets alphabetically, so all "Profile 1*" comes after "Profile 1" but before "Profile 2". This makes reading the histogram impossible. This CL attempts to re-label the buckets to ensure that the order in more logical "Profile 01", "Profile 02" .. It also relabels "Profile 100" to "Profile 99+" as it actually tracks all profiles above 99. Bug: None Change-Id: I11f9b95231c51bdb604f9f8366499bbec250c4c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2467945Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: Id6aa425dc72617875902282f593d70ea9eaf27df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2469712Reviewed-by:
-
Leszek Swirski authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/7bb48090..cc40f8a7 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I592ec5d9fb4f96e51c8c47b30ba50ebf9784b31b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2468837Reviewed-by:
Leszek Swirski <leszeks@chromium.org> Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/master@{#816941}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/5ae4ed8c588c..be423a5eb0e5 2020-10-14 sigurds@chromium.org Remove legacy accessors after https://crrev.com/c/2467936 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1011811,chromium:1135143 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I399a42c6cb5a0d0f164cad225fe5fabaa6c19d99 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2470026Reviewed-by:
-
Makoto Shimazu authored
The feature has fully shipped. Let's start removing the flag and code around it. Bug: 824858 Change-Id: I29d9e0724d337ad53129e53d898ad2ef6c693c38 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2470277Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Commit-Queue: Makoto Shimazu <shimazu@chromium.org> Cr-Commit-Position: refs/heads/master@{#816939}
-
Lei Zhang authored
Per third_party/README.chromium.template, the "Security Critical" entry should say "yes" if the code is shipped in releases. Given third_party/shell-encryption code generates static initializers, as seen in crrev.com/c/2430846, the code is definitely shipped. Presumably private_membership code is in the same situation. Bug: 1066937 Change-Id: Id5a64d0fba01ace9f21f35d75662face7087d358 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2469838Reviewed-by:
Amr Aboelkher <amraboelkher@google.com> Reviewed-by:
Amr Aboelkher <amraboelkher@chromium.org> Commit-Queue: Amr Aboelkher <amraboelkher@chromium.org> Cr-Commit-Position: refs/heads/master@{#816938}
-
Rushan Suleymanov authored
For bookmarks reupload the server state should be checked before the sync is enabled. After sync is enabled all bookmarks will be reuploaded right away. Bug: 1137866 Change-Id: I555062ee3b2753cd38ccf9500af7284d5b11f64a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2470520Reviewed-by:
Victor Vianna <victorvianna@google.com> Commit-Queue: Rushan Suleymanov <rushans@google.com> Cr-Commit-Position: refs/heads/master@{#816937}
-
Lei Zhang authored
Switch to absl::Uint128Max(), as |absl::kuint128max| is deprecated anyway. This fix has been submitted to the shell-encryption upstream, so pull that into Chromium by rolling shell-encryption from 1c3aa80075 to f94f58852e. Bug: 537099 Change-Id: Ic20b7b56a6cb31afbea5a7082db2435dce97cbd8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2430846Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Amr Aboelkher <amraboelkher@chromium.org> Cr-Commit-Position: refs/heads/master@{#816936}
-
Wez authored
Enable use of the ImportantFileWriterCleaner on all platforms. The cleaner must still be explicitly initialized in each process that wishes to make use of it. On platforms which do not provide a process creation time API the time at which the ImportantFileWriterCleaner is initialized is used instead, to provide the upper-bound when determining stale files. Bug: 1127445 Change-Id: Ie409d13aeef33f8d8deb62ee574726dacd43c9b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2445611 Auto-Submit: Wez <wez@chromium.org> Reviewed-by:
Greg Thompson <grt@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#816935}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1602567235-326c7abc194f22112a72664d7e7a2c66cfd57197.profdata to chrome-win32-master-1602633476-69602bad93ac5850796e454db1a842456d0dd6b1.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I82edf4850652067607c9b7e0ebb98d9e74e1de27 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2469705Reviewed-by:
-
Marc Treib authored
Bug: 951350 Change-Id: I8d3885bce1a39f2c331166daf90cc38508aa0d02 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2470556Reviewed-by:
Rushan Suleymanov <rushans@google.com> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#816933}
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1602633476-bff3708a6ce1ff631b23d1b618c56f8a3baedfe0.profdata to chrome-linux-master-1602654939-1f5462f983274209ab06546353a58e9ab57d2346.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: If44fc4f3bda26cf67592f7bca89740985d78a349 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2470596Reviewed-by:
-
Alex Rudenko authored
This CL makes use for a new single bundle for all overlays. It means that the overlay bundle will be installed once instead of being re-installed when the active tool changes. A new call `setOverlay` is introduced that notifies the bundle about the currently active tool. The changes give the following advantages: - we ship less code by shipping a single bundle (previously, different bundles contained the same modules). - we are one step closer to shipping the overlay page via CDP. - we are able to more easily combine different overlays. This CL depends on the frontend CL: https://crrev.com/c/2460917 Change-Id: I197c1512511d8e43449f02998f71cfd90f3f325f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461111 Commit-Queue: Alex Rudenko <alexrudenko@chromium.org> Reviewed-by:
Peter Marshall <petermarshall@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
Brandon Goddard <brgoddar@microsoft.com> Cr-Commit-Position: refs/heads/master@{#816931}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1602633476-0a6cb13b3824485740d2ed9816cdaa54debab52e.profdata to chrome-mac-master-1602654939-6aaab1e7299ba115ccc1d7beffbea8c42a27a599.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ib11159a977842105389e5a07c5b1d1adf1b58795 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2469710Reviewed-by:
-
Marc Treib authored
This factory method can also be used for the success case, so the new name is more accurate. This CL also introduces a ForUnspecifiedError() method to replace some instances of ForNetError(0). This CL also removes some TODOs that are obsolete or not worth it. Bug: 951350 Change-Id: I8d1cae97975c5ebdb37075bb666f6e3f3c22884e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2467960 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
Jan Krcal <jkrcal@chromium.org> Cr-Commit-Position: refs/heads/master@{#816929}
-
cfredric authored
This will be used to analyze how much entropy leaked by this API can be used for cross-site tracking. Bug: 973801 Change-Id: I08250b252bf183ab82b782c74328b5886ba385ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2445844 Auto-Submit: Chris Fredrickson <cfredric@google.com> Commit-Queue: Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Asanka Herath <asanka@chromium.org> Cr-Commit-Position: refs/heads/master@{#816928}
-
Viktor Semeniuk authored
This change moves password editing from the PasswordManagerPresenter to the SavedPasswordsPresenter so it is accessible for all platforms. Bug: 377410 Change-Id: I2b52f3f1233224329cefdc707a50a4a981220bbb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435105 Commit-Queue: Viktor Semeniuk <vsemeniuk@google.com> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#816927}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/99446001182c..c5d2a2fe5321 2020-10-14 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from df6b7298bb41 to bd0d3f9c4ff8 (15 revisions) 2020-10-14 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from c4100566 to 7cb4c97a (455 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC robertphillips@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: robertphillips@google.com Change-Id: I081c1a7e78045cde8871c216c3107334ab434954 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2470476Reviewed-by:
-
Swapnil Gupta authored
This reverts commit b505ee27. Reason for revert: crbug/1138138 Original change's description: > Lookalikes: Record histogram only once per navigation > > NavigationSuggestion.Event histogram records each lookalike domain in > a redirect chain as a separate entry. This slightly overcounts lookalike > matches. This CL changes the histogram name to > NavigationSuggestion.Event2 and records only one entry per navigation. > > Bug: 1136296 > Change-Id: I5b947d387f3dbc2bef1a95d4171c9ff22526d0f9 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2459430 > Commit-Queue: Mustafa Emre Acer <meacer@chromium.org> > Reviewed-by: Alexei Svitkine <asvitkine@chromium.org> > Reviewed-by: Chris Thompson <cthomp@chromium.org> > Reviewed-by: Joe DeBlasio <jdeblasio@chromium.org> > Cr-Commit-Position: refs/heads/master@{#816816} TBR=meacer@chromium.org,asvitkine@chromium.org,cthomp@chromium.org,jdeblasio@chromium.org Change-Id: I88299421401417b47744966fd23d6736491c27fe No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1136296 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2470063Reviewed-by:
Swapnil Gupta <swapnilgupta@google.com> Commit-Queue: Swapnil Gupta <swapnilgupta@google.com> Cr-Commit-Position: refs/heads/master@{#816925}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/072e187b21bb..5ae4ed8c588c 2020-10-14 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools Chromium DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I69e8838820a5b34b0d60495b37c7fd4a3de9626e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2469709Reviewed-by:
-
Edward Lesmes authored
Generate DIR_METADATA files and remove metadata from OWNERS files for //services/device. R=blundell@chromium.org Bug: 1113033 Change-Id: I8196affb680eb6c7c1bfd07f6ea27db93d13cf42 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2469359 Commit-Queue: Colin Blundell <blundell@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Auto-Submit: Edward Lesmes <ehmaldonado@chromium.org> Cr-Commit-Position: refs/heads/master@{#816923}
-
François Beaufort authored
This CL makes sure the Picture-in-Picture always open in the same display as the originated web contents. This does not apply when the Picture-in-Picture window is already visible. Change-Id: Ie61439927d5a7d02ae7ef0ed3979a316901f9834 Bug: 1135517 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2450197 Commit-Queue: François Beaufort <beaufort.francois@gmail.com> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#816922}
-
Rushan Suleymanov authored
Removed histograms: * Bookmarks.CreateBookmarkIndexTime * Bookmarks.DecodeTime * Bookmarks.DuplicateAndEmptyTitleDetectionTime Bug: 993078 Change-Id: I176bc52a69b24fa2cca65d3de097a2fffb4393ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463576Reviewed-by:
-
Swapnil authored
This reverts commit b3d6fee5. Reason for revert: crbug/1138121 Original change's description: > Reland "Enable fetch send ArrayBuffer more than 128 MB" > > This reverts commit 77bfcdcd. > > Reason for reland: added Linux SlowTests expectations. > > Original change's description: > > Revert "Enable fetch send ArrayBuffer more than 128 MB" > > > > This reverts commit 96c04c00. > > > > Reason for revert: crbug.com/1136750 > > > > Original change's description: > > > Enable fetch send ArrayBuffer more than 128 MB > > > > > > This CL introduces mojo_base.mojom.BigBuffer instead of array<uint> > > > so that fetch can send big ArrayBuffer. > > > > > > Bug: 919361 > > > Change-Id: I45c3c560ca787858453c677cc0c7fbc8c1983063 > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2415810 > > > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > > > Reviewed-by: Yutaka Hirano <yhirano@chromium.org> > > > Commit-Queue: Yoichi Osato <yoichio@chromium.org> > > > Cr-Commit-Position: refs/heads/master@{#815479} > > > > TBR=kinuko@chromium.org,rockot@google.com,yhirano@chromium.org,yoichio@chromium.org > > > > Change-Id: Ie4339d0cf4b709efb961abe569cbe1fa7cb116e3 > > No-Presubmit: true > > No-Tree-Checks: true > > No-Try: true > > Bug: 919361 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462908 > > Reviewed-by: Hajime Hoshi <hajimehoshi@chromium.org> > > Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#815506} > > TBR=kinuko@chromium.org,rockot@google.com,yhirano@chromium.org,hajimehoshi@chromium.org,yoichio@chromium.org > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: 919361,1136750 > Change-Id: I11049160e52a93bd7c757ec75eaa035b029124b4 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462979 > Commit-Queue: Yoichi Osato <yoichio@chromium.org> > Reviewed-by: Yoichi Osato <yoichio@chromium.org> > Cr-Commit-Position: refs/heads/master@{#816800} TBR=yoichio@chromium.org Change-Id: Ifac5bac71f41b8348c8288a5c9da6bd792a2f9a4 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 919361 Bug: 1136750 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2470576Reviewed-by:
-
Noel Gordon authored
DevToolsAgent emits a Runtime.executionContextsCreated "message" when a web page (WebContents) being examined for coverage by DevToolsAgent was created: a V8 instance was created for the web page. At this stage there are no scripts on the page, so we clear script_ and then subsequently: a Debugger.scriptParsed "message" is emitted for all scripts loaded by the web page (we store the details to script_). These emitted DevToolsAgent messages appear in the same order always so write the "message" handling code in message arrival order. The context creation message (executionContextsCreated) is first, and then whatever comes next (scriptParsed, ...). No change in behavior. Minor comment change for precision: change // deduplication => // script de-duplication. Tbr: benreich Bug: 1113941 Change-Id: If2817a9baba6635e358fa53e1f49501e3692b245 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2470283Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#816919}
-
Yunke Zhou authored
Currently we are using href="#" in oobe internal links which actually points to the top of the current page. When ChromeVox is enabled and pressing Search + Space, it focuses on the entire window instead of opening the link. Changed to use action-link so the anchor element works correctly when pressing Search + Space. Bug: 1133745 Change-Id: I103158d9b5774f896d3fbb3829ad5c187657c986 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2467898 Commit-Queue: Yunke Zhou <yunkez@google.com> Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Cr-Commit-Position: refs/heads/master@{#816918}
-
Abhijeet Kandalkar authored
This CL converts WidgetMsg_SetViewportIntersection and FrameHostMsg_UpdateViewportIntersection to mojom. FrameHostMsg_UpdateViewportIntersection sends message from a parent renderer to the browser; it then initiates a WidgetHostMsg_SetViewportIntersection from browser to child renderer. This IPC messages are primarily used by the IntersectionObserver API. Bug: 1071582, 1093954 Change-Id: If1f403c37d150bc3165455df40f115bbf091320b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2230584Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Stefan Zager <szager@chromium.org> Commit-Queue: Abhijeet Kandalkar <abhijeet@igalia.com> Cr-Commit-Position: refs/heads/master@{#816917}
-
Ben Reich authored
Current java code coverage is written into a coverage directory within the out dir on the bots. Changed to devtools_code_coverage to avoid overlap. Test: browser_tests --gtest_filter=*FilesApp* --devtools-code-coverage Bug: 1113941 Change-Id: I4961c0c5dd056e48e81561898e646f2dc3d9095c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2470416Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/095444c21262..0150a791fcb7 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I6d2115d90408c1e3a64783e0a358b4ada2407787 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2470119Reviewed-by:
-
Bartek Nowierski authored
Instead of exposing raw_size_ptr, which is an implementation detail, better to just use getters and setters, accompanied by CanStoreRawSize(). Also, rename getters and setters, so that it's clear what they do. Change-Id: Idcc46a9e303d0582914c6e8ab111c3051e44946c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2467641 Commit-Queue: Bartek Nowierski <bartekn@chromium.org> Reviewed-by:
-
Dominic Mazzoni authored
The generated event gives us everything we need, and this is one fewer specific event that Blink has to worry about. Bug: 699438 Tbr: nasko@chromium.org Change-Id: Ic424a2df9c6f3860dd0b2db720df10df489d73ea AX-Relnotes: N/A Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441980 Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Joanmarie Diggs <jdiggs@igalia.com> Cr-Commit-Position: refs/heads/master@{#816913}
-
