Skip to content

GitLab

T
tangled
Switch branch/tag
  1. 04 Apr, 2018 2 commits
    • Dominick Ng's avatar
      Zero-check the AppBannerInfoBarDelegateAndroid native pointer. · 4c8da33a
      Dominick Ng authored 
      There are a number of crashes which seem to come from the Java-side
AppBannerInfoBarDelegateAndroid#OnInstall method calling the native-side
method after its AppBannerUiDelegate object has been cleared. The crash
manifests as a segmentation fault when accessing a std::unique_ptr
member.

This CL zero-checks the native pointer in the Java-side
AppBannerInfoBarDelegateAndroid prior to calling to native.
https://crrev.com/c/959409 attempted to address the crashes by reordering
the destruction procedure of AppBannerInfoBarDelegateAndroid, but this
did not catch all of the crashes.

BUG=819434

Change-Id: Ibb5dbe322ab705173bba3835702fdd27b0e2adcc
Reviewed-on: https://chromium-review.googlesource.com/991312Reviewed-by: default avatarMatthew Jones <mdjones@chromium.org>
Commit-Queue: Dominick Ng <dominickn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547876}
      4c8da33a
    • Dominick Ng's avatar
      Migrate generic throttle code from ArcNavigationThrottle to AppsNavigationThrottle. · 59497f7b
      Dominick Ng authored 
      This CL moves the generic Chrome OS intent picker navigation throttling
behaviour from ArcNavigationThrottle to AppsNavigationThrottle.
AppsNavigationThrottle::MaybeCreate now returns an instance of
AppsNavigationThrottle, and ArcNavigationThrottle now handles showing
the intent picker UI and querying ARC++ for apps. This CL should have no
functional changes.

Follow-up CLs will migrate the showing the intent picker UI to
AppsNavigationThrottle, and rename ArcNavigationThrottle. The renaming
was not done in this CL for ease of review. Strictly speaking,
ArcNavigationThrottle is still a semantically correct name; the main
reason for renaming is to avoid confusion with subclasses of
content::NavigationThrottle.

BUG=824598

Change-Id: I82c6e48cf7929701ea9f59cf811c4b7de70fd49a
Reviewed-on: https://chromium-review.googlesource.com/974622
Commit-Queue: Dominick Ng <dominickn@chromium.org>
Reviewed-by: default avatarYusuke Sato <yusukes@chromium.org>
Reviewed-by: default avatarDavid Jacobo <djacobo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547875}
      59497f7b
  3. 03 Apr, 2018 38 commits