GitLab

As discussed on dom-dev:
https://groups.google.com/a/chromium.org/d/msg/dom-dev/qfHM4fKckwk/nELu4mvaAwAJ

There was already a hello.html + hello-parent.html in LayoutTests, so
these are kept and already-in-import-map.html was tweaked slightly to
use those instead.

There was also an existing hello.css, which was different, but the
test (import-attribute.html) doesn't depend on it.

Change-Id: Ib97451ff33bae16a75a2c7c703a8bac270910e38
Reviewed-on: https://chromium-review.googlesource.com/1133161Reviewed-by: Hayato Ito <hayato@chromium.org>
Reviewed-by: Takayoshi Kochi <kochi@chromium.org>
Commit-Queue: Philip Jägenstedt <foolip@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575207}

A metric is reported to find how many blacklisted forms
exist in the password store.

R=isherman@chromium.org, jdoerrie@chromium.org, vabr@chromium.org

Bug: 862930
Change-Id: I11f89c78b4d6e9bc0755b1a0b53249f497d1729c
Reviewed-on: https://chromium-review.googlesource.com/1131181
Commit-Queue: Narcis Gemene <gemene@google.com>
Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Vaclav Brozek <vabr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575206}

This CL may cause a small binary size increase, roughly proportional
to how long it's been since our last AFDO profile roll. For larger
increases (around or exceeding 100KB), please file a bug against
gbiv@chromium.org. Additional context: https://crbug.com/805539

The AutoRoll server is located here: https://afdo-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=gbiv@chromium.org

Change-Id: I4c592d64a76c1a16908825be921857c4e714c224
Reviewed-on: https://chromium-review.googlesource.com/1137985
Commit-Queue: afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#575205}

PAATF is currently built directly on top of SigninManager and
ProfileOAuth2TokenService. It instead should be layered on top of
IdentityManager, so that when the latter is converted to be backed by
the Identity Service PAATF automatically also becomes a true part of the
Identity Service client library.

This CL makes that change, after a rather large amount of prepatory work
giving IdentityManager all the necessary API surfaces. The actual change
is straightforward after that prepatory work. The only wrinkle is the
following:
- In the codebase currently clients create PAATF instances via an
  IdentityManager API, necessitating that identity_manager.h include
  primary_account_access_token_fetcher.h for some type definitions in
  that API.
- However, to port PAATF it is necessary for
  primary_account_access_token_fetcher.h to include identity_manager.h
  to be an IdentityManager::Observer.
- Thus, it is necessary *in this CL* to change all clients to construct
  PAATF instances directly rather than via IdentityManager. This is a
  completely straightforward change, but results in this CL touching a
  bunch more files than it otherwise would. The substantive changes in
  this CL are the ones in //services/identity.

TBR=jochen@chromium.org

Bug: 848642
Change-Id: Ic8ecb00864b1c44f848f9daae03e01dd4f06dd05
Reviewed-on: https://chromium-review.googlesource.com/1095098
Commit-Queue: Colin Blundell <blundell@chromium.org>
Reviewed-by: Colin Blundell <blundell@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575204}

"My Files" is on by default after crrev.com/c/1131025. Rename
the "My Files" flag to disable-my-files-navigation so can turn
it off.

Bug: 846587, 846585
Cq-Include-Trybots: luci.chromium.try:closure_compilation
Change-Id: I987230566c383fd8385f65916704cd0e9b32fd27
Reviewed-on: https://chromium-review.googlesource.com/1136456Reviewed-by: Noel Gordon <noel@chromium.org>
Commit-Queue: Noel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575203}

This reverts commit e98df9c6.

Reason for revert: suspect for webkit_layout_tests consistently
failing, e.g.
https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Win7%20Tests%20%281%29/81791

Original change's description:
> Snaps after scrollbar clicking.
> 
> After user clicking on the scrollbar's track or arrows, we should snap
> to the closest snap position of the container. This is done by simply
> moving SnapAfterScrollbarDragging() from
> ScrollableArea::MouseReleasedScrollbar() up to Scrollbar::MouseUp().
> 
> This patch also rewrites the previous
> snaps-after-scrollbar-dragging.html test using the gesture-util.js, and
> adds the new clicking tests to it as well.
> 
> Bug: 860768
> Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
> Change-Id: I75267c3fc0917ecf5c14673a1eb480a047d03824
> Reviewed-on: https://chromium-review.googlesource.com/1127153
> Commit-Queue: Sandra Sun <sunyunjia@chromium.org>
> Reviewed-by: David Bokan <bokan@chromium.org>
> Reviewed-by: Majid Valipour <majidvp@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#575191}

TBR=bokan@chromium.org,majidvp@chromium.org,sunyunjia@chromium.org

Change-Id: Iab3c3c489bda0fc6b150ba0e0a5bde8de9721798
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 860768
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Reviewed-on: https://chromium-review.googlesource.com/1138013Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Commit-Queue: Mikel Astiz <mastiz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575202}

Bug: 846591
Cq-Include-Trybots: luci.chromium.try:closure_compilation
Change-Id: Icbadc037d959c4f61912624835ff3ec8929d4a41
Reviewed-on: https://chromium-review.googlesource.com/1137807
Commit-Queue: Luciano Pacheco <lucmult@chromium.org>
Reviewed-by: Joel Hockey <joelhockey@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575201}

If drivefs needs to restart itself it will inform the browser and unmount,
and the browser will try to mount again after specified time.

BUG=chromium:845390

Change-Id: Idb8e7767ef53469c7c8bc96ff0b0bf8c028a68b0
Reviewed-on: https://chromium-review.googlesource.com/1134712Reviewed-by: Sam McNally <sammc@chromium.org>
Commit-Queue: Sergei Datsenko <dats@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575200}

This change is following: go/filesapp-2018-mocks

Bug: 846587
Cq-Include-Trybots: luci.chromium.try:closure_compilation
Change-Id: I066b3670ef0c06bc2b170ecd8991b6940fdac637
Reviewed-on: https://chromium-review.googlesource.com/1137804Reviewed-by: Joel Hockey <joelhockey@chromium.org>
Commit-Queue: Luciano Pacheco <lucmult@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575199}

This patch retrieves the payload when the notification is clicked.

Bug: b/79493568
Test: manual.
Change-Id: I01d4e1133861f7173f2c8973a3822db517d24f54
Reviewed-on: https://chromium-review.googlesource.com/1133764Reviewed-by: Sam McNally <sammc@chromium.org>
Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Commit-Queue: Tao Wu <wutao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575198}

# This is an automated release commit.
# Do not revert without consulting chrome-pmo@google.com.
NOAUTOREVERT=true
TBR=mmoss@chromium.org

Change-Id: Id8788ce777d922a2c5c11477e130197beecc31a6
Reviewed-on: https://chromium-review.googlesource.com/1137888Reviewed-by: chrome-release-bot@chromium.org <chrome-release-bot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575197}

This follows up:
https://chromium-review.googlesource.com/c/chromium/src/+/1125518/22/content/browser/gpu/gpu_client_impl.cc#70

BUG=857217

Change-Id: I4139661d39744bed3aab9ccdda72fc2976739472
Reviewed-on: https://chromium-review.googlesource.com/1136221
Commit-Queue: Xing Xu <xing.xu@intel.com>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575196}

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/2f38df65f95e..8d3925b16482


git log 2f38df65f95e..8d3925b16482 --date=short --no-merges --format='%ad %ae %s'
2018-07-15 jsca@google.com Add support to gclient for skipping CIPD deps.


Created with:
  gclient setdep -r src/third_party/depot_tools@8d3925b16482

The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



BUG=chromium:860397
TBR=agable@chromium.org

Change-Id: Id37d965f428f69448cd4cd0ed01953f39a94e138
Reviewed-on: https://chromium-review.googlesource.com/1137782Reviewed-by: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#575195}

Introduces SelectionDeserializer that receives an HTML snippet and creates a selection in the AX tree

Will help with automated testing using HTML files that include selection markers.
R=dmazzoni@chromium.org

Change-Id: I7dd23b980b6966c87e09c12bdb27b8ad27c9cc15
Reviewed-on: https://chromium-review.googlesource.com/1106901
Commit-Queue: Nektarios Paisios <nektar@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575194}

This CL adds logic for Chromium to bootstrap a Mojo connection to the
Chrome OS ML service daemon via D-Bus, and a very simple client library
for client code in Chromium to use to access the ML service.

1. Bootstrap
To connect to the daemon, Chromium prepares a Unix socket pair and sends
a Mojo invitation, including a primordial pipe handle, through the
socket. The file descriptor for the other end of the socket pair is
passed to the daemon as the argument of its BootstrapMojoConnection
D-Bus method. The daemon is expected to bind the primordial pipe to an
implementation of the MachineLearningService top-level Mojo interface.

The ML service daemon side of the above interaction is added in
crrev.com/c/1123663.

2. Thin client library
This CL adds chromeos::machine_learning::ServiceConnection which client
code in Chromium can use to access the ML service. This singleton class
automatically performs D-Bus->Mojo bootstrap as necessary, and exposes
a method clients can use to bind a ModelProviderPtr mojo interface and
thereby access the ML service.

This CL also brings the .mojom files specifying the ML service Mojo
interface under public/mojom. Previously we intended to access these via
third_party/cros_system_api, but Chromium will instead maintain its own
copy of these mojoms, which will be manually eventually-consistent with
the Chrome OS copies (under src/platform2/ml). We are switching to this
recommended approach for the reasons discussed in the following doc:
https://docs.google.com/document/d/1rX3xtR6ZioKZaO-4qBFJFqFypSX1p6gAvQ_MuYn64G8
A separate CL will remove the .mojoms under platform/system_api/mojo.

Testing:

How to automatically test that Chromium + the daemon successfully
perform the D-Bus -> Mojo bootstrap is not clear and is under discussion
(comments welcome). It may have to wait until there is a client in
Chromium calling the daemon, which could then have an end-to-end
autotest.

I manually tested this against a Chrome OS ML service built with
crrev.com/c/1123663 by adding some test calls to BootstrapMojoConnection
initiated from chrome_browser_main_chromeos.

Bug: 836091, 836092, 836107
Change-Id: I3dbcaeb7a0af0bc09a56a98e68d9420cc1626d91
Reviewed-on: https://chromium-review.googlesource.com/1123964Reviewed-by: Ben Chan <benchan@chromium.org>
Reviewed-by: Ken Rockot <rockot@chromium.org>
Reviewed-by: Dan Erat <derat@chromium.org>
Commit-Queue: Andrew Moylan <amoylan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575193}

https://skia.googlesource.com/skia.git/+log/612d5214a2ae..fea9e90e2cdb


git log 612d5214a2ae..fea9e90e2cdb --date=short --no-merges --format='%ad %ae %s'
2018-07-16 recipe-roller@chromium.org Roll recipe dependencies (trivial).


Created with:
  gclient setdep -r src/third_party/skia@fea9e90e2cdb

The AutoRoll server is located here: https://autoroll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=bungeman@chromium.org

Change-Id: I9c44a4245aa7a709643a920e787b0e84ef3518f1
Reviewed-on: https://chromium-review.googlesource.com/1137783Reviewed-by: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#575192}

After user clicking on the scrollbar's track or arrows, we should snap
to the closest snap position of the container. This is done by simply
moving SnapAfterScrollbarDragging() from
ScrollableArea::MouseReleasedScrollbar() up to Scrollbar::MouseUp().

This patch also rewrites the previous
snaps-after-scrollbar-dragging.html test using the gesture-util.js, and
adds the new clicking tests to it as well.

Bug: 860768
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I75267c3fc0917ecf5c14673a1eb480a047d03824
Reviewed-on: https://chromium-review.googlesource.com/1127153
Commit-Queue: Sandra Sun <sunyunjia@chromium.org>
Reviewed-by: David Bokan <bokan@chromium.org>
Reviewed-by: Majid Valipour <majidvp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575191}

We need to use the pref in components, move the pref to components/language/
so it can be accessed.

Bug: 729596
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I37cb0b6fd9976ff8fc6d3239e01d4f38fc7b73f4
Reviewed-on: https://chromium-review.googlesource.com/1135198Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Reviewed-by: Ran Ji <ranj@chromium.org>
Commit-Queue: Ran Ji <ranj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575190}

This adds the API to SSLClientSocket but does not yet hook it up
to the rest of the stack.

Bug: 641225
Change-Id: I8694d4e4f92d7e57d32541fcc2b87ed5fb42d075
Reviewed-on: https://chromium-review.googlesource.com/1067639
Commit-Queue: Steven Valdez <svaldez@chromium.org>
Reviewed-by: Steven Valdez <svaldez@chromium.org>
Reviewed-by: David Benjamin <davidben@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575189}

This change fixes the bug from the omnibox side. When the fakebox is
focused, the omnibox will be in an "invisible focus" state. So these
changes prevent the focus state to change if whitespace is inputted or
pasted into the fakebox. The existing behaviour for dragging whitespace
text into the fakebox does not hide the fakebox. That was not changed.

A small change was made to the fakebox cursor, so when the fakebox is
hidden, hovering over that area shows the default cursor instead of the
text cursor.

R=ramyan@chromium.org, treib@chromium.org

Bug: 727302
Cq-Include-Trybots: luci.chromium.try:closure_compilation
Change-Id: Id075e3e52113d5e8e27e2e1bab74926a6b8bc723
Reviewed-on: https://chromium-review.googlesource.com/1127488
Commit-Queue: Justin Donnelly <jdonnelly@chromium.org>
Reviewed-by: Justin Donnelly <jdonnelly@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575188}

Following bot results are included.
7803 7812 7822 7830 7836 7840 7845 7854 7856 7866 7873 7878
7882 7887 7895 7899 7908 7915 7925 7943 7944 7945 7946 7952

TBR=eae@chromium.org, mstensho@chromium.org
NOTRY=true

Bug: 591099
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
Change-Id: Idfc35797d4aad13c9462b4df865e3a2066684868
Reviewed-on: https://chromium-review.googlesource.com/1133359
Commit-Queue: Koji Ishii <kojii@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575187}

https://skia.googlesource.com/skia.git/+log/c053fb8e34db..612d5214a2ae


git log c053fb8e34db..612d5214a2ae --date=short --no-merges --format='%ad %ae %s'
2018-07-15 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update SKP version


Created with:
  gclient setdep -r src/third_party/skia@612d5214a2ae

The AutoRoll server is located here: https://autoroll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=bungeman@chromium.org

Change-Id: I805d85602ae41f31fad8e5009903ea300eb99dc9
Reviewed-on: https://chromium-review.googlesource.com/1137780Reviewed-by: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#575186}

https://chromium.googlesource.com/chromiumos/chromite.git/+log/106662954167..f9b822cd7957


git log 106662954167..f9b822cd7957 --date=short --no-merges --format='%ad %ae %s'
2018-07-15 vapier@chromium.org config_lib: use memoize helpers directly


Created with:
  gclient setdep -r src/third_party/chromite@f9b822cd7957

The AutoRoll server is located here: https://chromite-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=chrome-os-gardeners@chromium.org

Change-Id: I5fdfa690eff147c11634991899237cb47259cd8c
Reviewed-on: https://chromium-review.googlesource.com/1137781Reviewed-by: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#575185}

In the record of the flakiness dashboard there is only one
timeout registered (and no failures).  The one timeout was
a particularly bad run on windows debug, and when it
happened there were a lot of other tests timing out. I
find it likely that there was a slow change in that run.

Bug: 626703
Change-Id: I93f6720b08ecbdbff78d838b84c82ccb38dd4a28
Reviewed-on: https://chromium-review.googlesource.com/1133312Reviewed-by: Robert Flack <flackr@chromium.org>
Commit-Queue: Peter Mayo <petermayo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575184}

This test only times out on Windows Debug.  It runs relatively
quickly and passes on the other bots.  It may not be useful,
but this eliminates noise of incorrect passing, and if it is
(correctly) made to report a failure the expectation can
be updated accurately simultaneously.

Bug: 666993
Change-Id: I24e2da435f964c3fe7de7f91a6949885f713f361
Reviewed-on: https://chromium-review.googlesource.com/1134030
Commit-Queue: Peter Mayo <petermayo@chromium.org>
Reviewed-by: Robert Flack <flackr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575183}

This only times out on debug, and on the rest produces unexpected
passes in the current config.

Bug: 655458
Change-Id: Ib72a21da810fdd5040a288f84479793bc9d92368
Reviewed-on: https://chromium-review.googlesource.com/1134198
Commit-Queue: Peter Mayo <petermayo@chromium.org>
Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575182}

https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=webkit_layout_tests&tests=inspector-protocol/timeline/page-frames.js
shows that page-frames.js is flaky.

Bug: 734762
Change-Id: Ib16216060b2139b8e1d7ef7aec7b3c5a28c9140a
Reviewed-on: https://chromium-review.googlesource.com/1135670Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Peter Mayo <petermayo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575181}

Per https://github.com/w3c/network-error-logging/issues/74, NEL policies
that have include_subdomains set can only be used to report errors
during DNS resolution.  They cannot be used to report on successes, or
on errors in other phases, since once we contact a server, that server
has to explicitly consent to NEL reporting by delivering its own policy.

Bug: 862188
Change-Id: If051f6787344b9385af3e46384370636a6bafc5d
Reviewed-on: https://chromium-review.googlesource.com/1135599
Commit-Queue: Douglas Creager <dcreager@chromium.org>
Reviewed-by: Misha Efimov <mef@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575180}

This CL may cause a small binary size increase, roughly proportional
to how long it's been since our last AFDO profile roll. For larger
increases (around or exceeding 100KB), please file a bug against
gbiv@chromium.org. Additional context: https://crbug.com/805539

The AutoRoll server is located here: https://afdo-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=gbiv@chromium.org

Change-Id: I21368d1bf5a4fae30f55608e2dda23a1db4d8fcb
Reviewed-on: https://chromium-review.googlesource.com/1137914Reviewed-by: afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#575179}

https://skia.googlesource.com/skia.git/+log/0c604ed06b71..c053fb8e34db


git log 0c604ed06b71..c053fb8e34db --date=short --no-merges --format='%ad %ae %s'
2018-07-15 skia-bookmaker@skia-swarming-bots.iam.gserviceaccount.com Update markdown files


Created with:
  gclient setdep -r src/third_party/skia@c053fb8e34db

The AutoRoll server is located here: https://autoroll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=bungeman@chromium.org

Change-Id: I2fb92cd3b00c3da7ecd9548bc094a2a3fbb3f721
Reviewed-on: https://chromium-review.googlesource.com/1137779Reviewed-by: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#575178}

The metrics Scheduling.*.SwapAckWasFast records True if the swap
ack was received within approximately 8 seconds of the swap. Based
on the past few month of data, this metrics always report true,
true -> 100%. In addition, metrics Scheduling.*.SwapToAckLatency2
measures the same data - it reports the exact time that takes for
the swap ack to return after a swap.

Bug: 856860
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I00cf9e545a9a55054fe7dd8af948693625cac08b
Reviewed-on: https://chromium-review.googlesource.com/1134040Reviewed-by: Mark Pearson <mpearson@chromium.org>
Reviewed-by: Fady Samuel <fsamuel@chromium.org>
Commit-Queue: Yi Xu <yiyix@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575177}

BUG=762641
TBR=alemate@chromium.org

Change-Id: Ide4e1d9dd014515b114c3989abbd00ffe9101338
Reviewed-on: https://chromium-review.googlesource.com/1137879
Commit-Queue: ChromeOS Commit Bot <chromeos-commit-bot@chromium.org>
Reviewed-by: ChromeOS Commit Bot <chromeos-commit-bot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575176}

The introduction of SSLConfigServiceMojo finally
provided the cut point in the SSLConfigService
interface that allows it to no longer be refcounted,
and instead fully owned by the URLRequestContextStorage.

TBR=sergeyu@chromium.org

Bug: 56213
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;luci.chromium.try:linux_mojo;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I9d2fa53f93d76b18937fd615ed976ced18241822
Reviewed-on: https://chromium-review.googlesource.com/1129327
Commit-Queue: Ryan Sleevi <rsleevi@chromium.org>
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Reviewed-by: Richard Coles <torne@chromium.org>
Reviewed-by: Martin Šrámek <msramek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575175}

https://skia.googlesource.com/skia.git/+log/6f6fdf91f66d..0c604ed06b71


git log 6f6fdf91f66d..0c604ed06b71 --date=short --no-merges --format='%ad %ae %s'
2018-07-15 fmalita@chromium.org [skottie] Teach skottie_tool to dump frame SKPs


Created with:
  gclient setdep -r src/third_party/skia@0c604ed06b71

The AutoRoll server is located here: https://autoroll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=bungeman@chromium.org

Change-Id: I6aedb294f8c80c9d6ff73a8d3a6f43c963791a62
Reviewed-on: https://chromium-review.googlesource.com/1137778Reviewed-by: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#575174}

This reverts commit 4714a9fc.

Reason for revert: perf regression (crbug.com/863125). I think I've
identified the culprit but reverting to avoid compounding CLs if I'm
wrong. Will reland with fix shortly.

Original change's description:
> [MessageLoop] Refactor ScheduleWork and TaskAnnotator logic out of IncomingTaskQueue
> 
> This was extracted from
> https://chromium-review.googlesource.com/c/chromium/src/+/1088762/17
> in an attempt to simplify it (and is now a precursor to it).
> (MessageLoop::Controller was IncomingTaskQueue::MessageLoopController
> there but after grokking the resulting CL it's simpler under MessageLoop
> as done in this CL)
> 
> This CL splits the logic in IncomingTaskQueue which took care of
> scheduling the MessageLoop into a dedicated class. In that follow-up CL:
> MessageLoopTaskRunner will interact directly with the task Observer and
> take IncomingTaskQueue completely out of the picture (merely a data
> structure holding various task queues at that point).
> 
> IncomingTaskQueue also took care of detaching on MessageLoop shutdown
> which was moved to the new Controller class as well.
> 
> message_loop.cc is the best place for this extracted logic as it all
> pertains precisely to MessageLoop's implementation detail (how
> ScheduleWork should be invoked).
> 
> This CL simplifies locking as well by having a clear separation between
> the two locks instead of two locks in the same class used
> interchangibly. |incoming_queue_lock_| is now strictly for incoming
> tasks. |message_loop_lock_| is now strictly for
> ScheduleWork()/DisconnectFromParent().
> 
> Note: |message_loop_scheduled_| was dropped as it was redundant (always
> equal to |!was_empty|).
> 
> Performance wise, the perf tests show that this change is a noop :
>  * While BasicPostTaskPerfTest became simpler (executed less code) with
>    this CL :
>      The new BasicPostTaskPerfTest w/ MockObserverSimulatingOverhead
>      reintroduces that overhead to show that it's still the same (or
>      slightly in favor of this CL).
>  * And the IntegratedPostTaskPerfTest are the same.
>  * Augmented perf tests to 30 seconds which yields more reliable results.
>    (and ran old ones under 30s mode too when comparing)
>  * Results :
>      https://docs.google.com/spreadsheets/d/100wYvbCI_dJ7gRnQiSsYaTb5OJnbF_muL6LyQWJLXSU/edit
> 
> Bug: 860252
> Change-Id: I22de2409d52414524cc125b0e2fe08e2c516fcbe
> Reviewed-on: https://chromium-review.googlesource.com/1127262
> Commit-Queue: Gabriel Charette <gab@chromium.org>
> Reviewed-by: danakj <danakj@chromium.org>
> Reviewed-by: kylechar <kylechar@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#574048}

TBR=danakj@chromium.org,gab@chromium.org,kylechar@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 860252, 863125
Change-Id: I871a9e87d799b7966558708826d97400162e0e82
Reviewed-on: https://chromium-review.googlesource.com/1137893Reviewed-by: Gabriel Charette <gab@chromium.org>
Commit-Queue: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575173}

# This is an automated release commit.
# Do not revert without consulting chrome-pmo@google.com.
NOAUTOREVERT=true
TBR=mmoss@chromium.org

Change-Id: I6a4b2eb9e258267edca8e97c88e7384568c617c8
Reviewed-on: https://chromium-review.googlesource.com/1137875Reviewed-by: chrome-release-bot@chromium.org <chrome-release-bot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575172}

https://chromium.googlesource.com/chromiumos/chromite.git/+log/27e21b72d0d7..106662954167


git log 27e21b72d0d7..106662954167 --date=short --no-merges --format='%ad %ae %s'
2018-07-15 vapier@chromium.org memoize: split out of cros_build_lib
2018-07-15 dhanyaganesh@chromium.org CQ: Remove subsytem-based logic


Created with:
  gclient setdep -r src/third_party/chromite@106662954167

The AutoRoll server is located here: https://chromite-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=chrome-os-gardeners@chromium.org

Change-Id: I01b27916731982a4252642ae26e2c8e2a84a8638
Reviewed-on: https://chromium-review.googlesource.com/1137777Reviewed-by: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#575171}

So far XFCE was only detected using the DESKTOP_SESSION environment variable,
which is not sufficient on all systems. The variable might contain different
values like lightdm-xsession. This change adds support to detect XFCE using the
XDG_CURRENT_DESKTOP environment variable, like it is done for Gnome, KDE and
other desktop environments.

R=thomasanderson@chromium.org

Bug: 863706
Change-Id: I30f8471a8e8fbea1d25c6b3586c9919d27d83e09
Reviewed-on: https://chromium-review.googlesource.com/1137814Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575170}

Accomplished by "hl" query parameter and client side locale API.

See bug for demo.

Bug: b:111352574
Change-Id: I4cbca266921ecc1009de29d23642e3c4225826da
Reviewed-on: https://chromium-review.googlesource.com/1137452
Commit-Queue: David Black <dmblack@google.com>
Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575169}

Using wpt-import in Chromium 74ff2c23.

Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/21282

Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

Directory owners for changes in this CL:
panicker@chromium.org:
  external/wpt/page-visibility

TBR=raphael.kubo.da.costa@intel.com

No-Export: true
Change-Id: I4072f0d7c562ffbbb106f9ddeacb313ceda71965
Reviewed-on: https://chromium-review.googlesource.com/1137840
Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Reviewed-by: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575168}