- 14 Aug, 2020 40 commits
-
-
Emily Stark authored
In some variants of the simplified domain field trials, we show the full URL on page load and elide to a simplified version of the domain after the user interacts with the page. Originally we considered any user interaction (as received via WebContentsObserver::DidGetUserInteraction) a trigger for elision, but then started ignoring mouse clicks in https://chromium-review.googlesource.com/c/chromium/src/+/2327289, to avoid flashing when the user clicks on links. This proved to be a bit too coarse, since we want to at least elide the URL when the user focuses a form text field. This CL thus elides the URL when WebContentsObserver::OnFocusChangedInPage() reports that an editable node has been focused. Bug: 1104280 Change-Id: Ib0b4a5b19d035c38a2e529c6f526c421f537cff4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2357074Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Commit-Queue: Emily Stark <estark@chromium.org> Cr-Commit-Position: refs/heads/master@{#798261}
-
Guillaume Jenkins authored
The experiment name for the Windows native spell checker integration does not match the name of the Chrome variation field trial configuration entry. This changes the name in the field trial configuration so it matches the Finch experiment name. Bug: 978460 Change-Id: If10344fd9312535b5e8c1917cf6d3c7a6a80fd7f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2356689 Commit-Queue: Guillaume Jenkins <gujen@google.com> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#798260}
-
Robert Flack authored
Updating timelines can enqueue tasks related to ready and finish promises which should run before animation events and updated rendering. Bug: 1116020 Change-Id: Ica1927bb3921eef574abeaca23bb198dda658ccd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354164Reviewed-by:
Kevin Ellis <kevers@chromium.org> Commit-Queue: Robert Flack <flackr@chromium.org> Cr-Commit-Position: refs/heads/master@{#798259}
-
Nate Fischer authored
No change to logic. This disables a flaky test. Tbr: mastiz@chromium.org Bug: 1103515 Test: None Change-Id: I807fb635cf761a75013f5bde622df32909009f18 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2357469Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Commit-Queue: Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#798258}
-
Joshua Pawlicki authored
On Mac, uninstall deletes the app data dir altogether. On Win, uninstall deletes the app's grandparent dir, which contains the program executable, logs, and prefs file. Bug: 1115135 Change-Id: Ife281abeafd265b1cd50f6fcb67212b49eccc5ef Fixed: 1115135 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353192 Commit-Queue: Joshua Pawlicki <waffles@chromium.org> Reviewed-by:
Sorin Jianu <sorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#798257}
-
chromium-autoroll authored
Roll ChromeOS Broadwell AFDO profile from 86-4183.48-1597052523-benchmark-86.0.4231.0-r1 to 86-4183.48-1597052523-benchmark-86.0.4232.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-broadwell-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: Iff5064a06d563d001a6c4a83d6b41eb344f91d83 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2357549Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#798256}
-
James Hawkins authored
R=khorimoto@chromium.org Bug: none Test: none Change-Id: Ie63e7d3235b70b18b7934d4dc9369caead386b5a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2355672 Auto-Submit: James Hawkins <jhawkins@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: James Hawkins <jhawkins@chromium.org> Cr-Commit-Position: refs/heads/master@{#798255}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/66f621ae9064..a2a426bd66bc If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC thestig@google.com,juanmihd@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1107989 Tbr: thestig@google.com,juanmihd@google.com Change-Id: I04209206e09d973fa2425aad56ae9eeaf6351c45 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354502Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#798254}
-
Merissa Tan authored
- Add exo::Gamepad interface. - Add exo::GamepadObserver interface. - Add WaylandGamepadVibratorImpl to handle vibration and cancel vibration requests from the client. - Refactor WaylandGamingSeatDelegate so that WaylandGamepadDelegate handles all gamepad-specific events. - Add Wayland protocol to support gamepad rumble. The zcr_gamepad_vibrator_v2 interface is created when the server calls the vibrator_added event. The client can then trigger/disable vibration events on a gamepad vibrator through the interface. BUG=b:158686809 TEST=Add unit tests in gamepad_unittest. All tests pass in exo_unittests. Change-Id: Ie4b1b3b5f9748f31846c54c97cb4f7c315d09a05 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2313976 Commit-Queue: Merissa Tan <liyingtan@google.com> Auto-Submit: Merissa Tan <liyingtan@google.com> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#798253}
-
Rahul Singh authored
Windows devices Currently, GetCameraRotation() in video_capture_device_utils_win.cc assumes a landscape device. On upcoming Windows devices with naturally portrait displays this leads to the video capture feed being off by 90 degrees counterclockwise. This is because the camera continues to be mounted in a landscape orientation while the display is naturally portrait. This CL adds IsPortraitDevice() in video_capture_device_utils_win.cc which deduces whether we are running on a portrait orientation Windows device. This method is called as part of GetCameraRotation() and helps us correct the video rotation by 90 degrees counterclockwise for portrait orientation devices. Testing: Verified that with this change: 1. Front camera on portrait orientation devices rotates correctly. 2. We preserve existing rotation behavior on landscape orientation devices and when external cameras are attached. Bug: 1061541 Change-Id: I4a7e9552471242c544ee181ab0d0f4685c09f1d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354539Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Rahul Singh <rahsin@microsoft.com> Cr-Commit-Position: refs/heads/master@{#798252}
-
Chris Harrelson authored
The code was added not for this use case, but to ensure that composited bounds were optimized to avoid parts of descendants that were clipped out. This change also unblocks deleting some code and removing one cache slot, which will save memory on PaintLayer. Change-Id: I0ca7592ab3609a784bedd095e0c7fb4315b7527a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353872Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#798251}
-
Juliet Levesque authored
1) Set correct HTTP host, OAuth2 token, and UpdateDevice URLs. 2) Start the local device data manger. 3) Log the HTTP request URL. Bug: b/154863110 Change-Id: I6a2d758f52091f1cbbe290e2a4bed198f1584397 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2350541 Commit-Queue: Juliet Levesque <julietlevesque@google.com> Reviewed-by:
Josh Nohle <nohle@chromium.org> Cr-Commit-Position: refs/heads/master@{#798250}
-
Tim Van Patten authored
The memory_test target fails to build on Windows due to a variety of errors related to MOCK_METHOD(). For example: memory_test.cc(542,3): error: static_assert failed "(size_t) should be enclosed in parentheses." This is generated by the line: MOCK_METHOD(value_type*, allocate, (size_t)); "(size_t)" is clearly enclosed by parentheses (the error message even indicates this), but both clang and MSVC fail to compile correctly on Windows due to these errors. Bug: angleproject:4873 Bug: 1116473 Test: Build on Windows and Linux Change-Id: Ie83e7f2ebcdbd641b9e87ac7de7ef28f19b0bbac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353403Reviewed-by:Jamie Madill <jmadill@chromium.org> Reviewed-by:
Mirko Bonadei <mbonadei@chromium.org> Commit-Queue: Tim Van Patten <timvp@google.com> Cr-Commit-Position: refs/heads/master@{#798249}
-
Lukasz Anforowicz authored
This CL finishes reverting r719801 (started in https://crrev.com/c/2327963) while preserving the test coverage added via MultiOriginSessionRestoreTest. Bug: 1107269 Change-Id: I5172e610b098cb4a09187972498a031f12ee8539 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2336506Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Tobias Sargeant <tobiasjs@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Auto-Submit: Łukasz Anforowicz <lukasza@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#798248}
-
Chris Lu authored
Re-enable EG2Tests that were disabled because content was being hidden behind the toolbar. Bug: 1107989 Change-Id: I123bcab04934051b7475f9debcefc5b8c6a85497 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354727Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Cr-Commit-Position: refs/heads/master@{#798247}
-
Josh Nohle authored
Add a method to the certificate manager that returns all of the local device private certificates of a given visibility, converted to public certificates. This feature was requested in crrev/c/2346325. Bug: 1114765 Change-Id: Ifec56ec08a6072018f35e5e0121ecf9562201faf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2348295 Commit-Queue: Josh Nohle <nohle@chromium.org> Reviewed-by:
Himanshu Jaju <himanshujaju@chromium.org> Cr-Commit-Position: refs/heads/master@{#798246}
-
Chris Hamilton authored
This adds an base::Optional<ExecutionContext> token to ExecutionContext to that all ExecutionContexts that have a well defined parent (in terms of lifetime associations) can be tracked. This will allow worklets to be associated with their parent LocalFrame, and DedicatedWorkers to be associated with their parent context. These information will be used by the performance.measureMemory API implementation. BUG=1085129 Change-Id: I52d4056e50ca3ce9b0090196342bdf1118c21865 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343609 Commit-Queue: Chris Hamilton <chrisha@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#798245}
-
Lei Zhang authored
Various KerberosCredentialsManagerTest test cases are flaky. Bug: 1116500 Change-Id: I31984b06d49d58f2f4994bf1b0053bd97e82ea9c Tbr: emaxx@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2357409Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#798244}
-
Robbie McElrath authored
This reverts commit 0f654bd2. Reason for revert: The CL that caused the flakiness was reverted. Original change's description: > Disable flaky test ErrorPageCallbackTest.testOverrideErrorPage > > org.chromium.weblayer.test.ErrorPageCallbackTest.testOverrideErrorPage > is flaky on Android, > https://analysis.chromium.org/p/chromium/flake-portal/flakes/ > occurrences?key=ag9zfmZpbmRpdC1mb3ItbWVyfAsSBUZsYWtlInFjaHJvbWl1bUB3ZWJs > YXllcl9pbnN0cnVtZW50YXRpb25fdGVzdF9hcGtAb3JnLmNocm9taXVtLndlYmxheWVyLnRl > c3QuRXJyb3JQYWdlQ2FsbGJhY2tUZXN0I3Rlc3RPdmVycmlkZUVycm9yUGFnZQw, > disable it for now until it is fixed. > > TBR=estade@chromium.org > > Bug: 1116277 > Change-Id: Id9eaa577587cb64136cd36364dc7e882f1c34876 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2355399 > Reviewed-by: Lan Wei <lanwei@chromium.org> > Commit-Queue: Lan Wei <lanwei@chromium.org> > Cr-Commit-Position: refs/heads/master@{#798021} TBR=estade@chromium.org,lanwei@chromium.org Change-Id: I53f4ab75620ae834b2969cf6042c201f381e443a No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1116277 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2357595Reviewed-by:
Robbie McElrath <rmcelrath@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> Cr-Commit-Position: refs/heads/master@{#798243}
-
Dylan Cutler authored
HTMLVideoElement.webkitDroppedFrameCount for identifiability study. Bug: 973801 Change-Id: I1d7efabe6e44764a447b9b47adc1bd343aa6e80b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354306Reviewed-by:
David Bokan <bokan@chromium.org> Reviewed-by:
Asanka Herath <asanka@chromium.org> Commit-Queue: Dylan Cutler <dylancutler@google.com> Cr-Commit-Position: refs/heads/master@{#798242}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/c9c4e2e9efac..8b07b9f55a73 2020-08-14 mtklein@google.com Revert "move conditions for JIT into SkVM.h" 2020-08-14 johnstiles@google.com Improve unit tests for switch-case and enum error handling. 2020-08-14 nifong@google.com missed minification bug 2020-08-14 mtklein@google.com byte code instructions can fit in a byte 2020-08-14 mtklein@google.com clean up stray #undef 2020-08-14 egdaniel@google.com Remove ability to add waitOp to GrOpsTask. 2020-08-14 jvanverth@google.com Fix MetalWindowContext::swapBuffers. 2020-08-14 brianosman@google.com Make switch case handling safer 2020-08-14 johnstiles@google.com Enable ClangTidy check modernize-use-nullptr. 2020-08-14 adlai@google.com Remove SK_IMAGE_MAKE_COLOR_TYPE_AND_SPACE_USE_SOURCE_CONTEXT 2020-08-14 herb@google.com benchmark for text vertex fill 2020-08-14 brianosman@google.com Move init code from pipeline stage generator to GrSkSLFP 2020-08-14 mtklein@google.com move conditions for JIT into SkVM.h 2020-08-14 nifong@google.com Check SKP file version, return error string to JS caller 2020-08-14 robertphillips@google.com Require a direct context to precompile a DDL's programs 2020-08-14 johnstiles@google.com Describe the Skia 'onMethodName' pattern. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC fmalita@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: fmalita@google.com Change-Id: I0f46f94b17577a86659c60fd5a3cfc9075532dcd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354504Reviewed-by:
-
Karandeep Bhatia authored
https://chromium-review.googlesource.com/c/chromium/src/+/2354566 plumbed DOMWrapperWorld for all resource requests. Hence we no longer need to look at the current world to see if the main world CSP should be bypassed in CSP checks in fetch context. Instead we can rely on the CSP associated with the plumbed DOMWrapperWorld. This is more accurate as it prevents incorrectly bypassing or not bypassing the CSP when BaseFetchContext::ShouldBypassMainWorldCSP is called asynchronously from the point the request is initiated. BUG=1099975 Change-Id: I6cb782dab25e3b418f5b9be79578b3b7d0e50b06 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2317030Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Dominic Farolino <dom@chromium.org> Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#798240}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll Please CC chonggu@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: chonggu@google.com Change-Id: I8205c0d2bf2c771687689ebf5f7714dd0669dc97 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2356567Reviewed-by:
-
Rouslan Solomakhin authored
This patch adds a C++ payment app object that communicates to Android payment apps. At this time, only Chrome OS has concrete implementation that connects to a Trusted Web Activity in the Android subsystem. Design: https://bit.ly/cross-platform-pay-app-factory Bug: 1061503 Change-Id: Ice5918967493e34cfa5ad4a4ccc25ce2602d204a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2255112 Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
Danyao Wang <danyao@chromium.org> Cr-Commit-Position: refs/heads/master@{#798238}
-
Guillaume Jenkins authored
One of the prefs related to Enterprise reporting for iOS CBCM wasn't being registered, and that caused a crash when CBCM was enabled. This change correctly registers the missing pref to the local state pref registry. Bug: 1066495 Change-Id: I2ccc81ea8f4290cc00238618853b0c03b16de483 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2357133Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Commit-Queue: Guillaume Jenkins <gujen@google.com> Cr-Commit-Position: refs/heads/master@{#798237}
-
Eugene But authored
Chrome for iOS restores 75 navigation items per Tab, which is the maximum supported by slim navigation manager. There is evidence that navigation session uses a lot of memory and this CL adds a metric to understand how many navigation items Chrome actually need. If users rarely go 75 items back, then Chrome could restore fewer items and safe on memory usage. Bug: 1115279 Change-Id: Iab54a577473ace598f7eb171785b2e1eefa92784 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352214 Commit-Queue: Eugene But <eugenebut@chromium.org> Reviewed-by:
Ali Juma <ajuma@chromium.org> Cr-Commit-Position: refs/heads/master@{#798236}
-
Yuki Shiino authored
This is a reland of e1dce34f Original change's description: > bind-gen: Switch to the new IDL interface implementation > > Blink-V8 bindings team has been developing the new improved > Web IDL bindings system, and this patch enables the new > bindings implementation of Web IDL interfaces at build time. > > Note that other IDL definitions (buffer source types, > dictionaries, callback functions, etc.) are not affected and > the old bindings are still used for them. > > The new IDL interface implementation is not 100% compatible > with the old one, and we see the following changes/improvement > that are visible from author script. > > Behavioral changes: > - Cross origin attributes become accessor properties. > - Indexed/named properties' behaviors change. > - Legacy platform objects with indexed properties support > @@iterator property. > - Maplike supports size() operation. > - [NoInterfaceObject] removes 'constructor' property. > - Some of error messages change. > For these changes, new behaviors are better conforming to > Web IDL specification. > > Non-behavioral changes: > - Keep-alive-GC optimization is removed. > > For performance, there is no major difference in speed perf > and -17KB improvement in APK binary size. > > Pinpoint results > https://pinpoint-dot-chromeperf.appspot.com/job/1230bdd8920000 > https://pinpoint-dot-chromeperf.appspot.com/job/14b5b5d0920000 > https://pinpoint-dot-chromeperf.appspot.com/job/12ca6424920000 > https://pinpoint-dot-chromeperf.appspot.com/job/14e3aa48920000 > > Bug: 839389 > Change-Id: I9de8de3cc9e37b4ee46333c9270fe49bbdd69534 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2081633 > Commit-Queue: Yuki Shiino <yukishiino@chromium.org> > Reviewed-by: Kent Tamura <tkent@chromium.org> > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Reviewed-by: Hitoshi Yoshida <peria@chromium.org> > Cr-Commit-Position: refs/heads/master@{#793165} About perf: APK size +7KB https://pinpoint-dot-chromeperf.appspot.com/job/143264c6920000 https://pinpoint-dot-chromeperf.appspot.com/job/174ee7a9920000 https://pinpoint-dot-chromeperf.appspot.com/job/175f8f66920000 Bug: 839389 Change-Id: Ib5a486eba6627d3dcb40efc3a617c90511645b1b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2335713 Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#798235}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/241a4a92fb96..4c3752c7f677 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-win-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I30da7939ceeccf1716a189d8449721ff47ac179f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2356829Reviewed-by:
-
Ben Pastene authored
A small attempt at reducing overall traffic to various pools. Bug: 1116532 Change-Id: I9c36e08a9babfa4a69d62bb246950ae48890e94c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2357412Reviewed-by:
Erik Staab <estaab@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#798233}
-
Lei Zhang authored
The test is crashing in a flaky manner. Bug: 1116543 Change-Id: I9c0d020aa8a936be1ffce98f207a892f2a0516bf Tbr: erikchen@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2357253Reviewed-by:
Erik Chen <erikchen@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#798232}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/292d9a8341d3..69d93258d753 2020-08-14 omerkatz@chromium.org heap: Add epoch based metric for blink gc If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC eseckler@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:986235 Tbr: eseckler@google.com Change-Id: I211fc1cf765e79915ecdb13e1aa9f261a27d5eaf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2356588Reviewed-by:
-
Emily Stark authored
This CL ignores private registries when computing the simplified domain, i.e. registrable domain. For example, "foo.example.com" will be simplified to "example.com", and "foo.blogspot.com" will be simplified to "blogspot.com". (Note that as of https://chromium-review.googlesource.com/c/chromium/src/+/2337761, the simplified domain logic only applies in unusual cases; most of the time, we show the full hostname). The reason for ignoring private registries is that we don't want to create negative incentives for malicious websites to add themselves as private registries to the Public Suffix List. This policy isn't perfect, but we think it best balances the security benefit of eliding malicious subdomains while minimally impacting benign websites that use subdomains. Bug: 1106962 Change-Id: Ifb75a510707c1dcac0825f899625069656838932 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2356936Reviewed-by:
Tommy Li <tommycli@chromium.org> Commit-Queue: Emily Stark <estark@chromium.org> Cr-Commit-Position: refs/heads/master@{#798230}
-
Filip Gorski authored
Prevents exceptions when setting URL in clipboard. Bug: 1115825 Change-Id: If64623659d042f1949f22ad759fbf26aaf55531c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2355012 Commit-Queue: Filip Gorski <fgorski@chromium.org> Commit-Queue: Ted Choc <tedchoc@chromium.org> Auto-Submit: Filip Gorski <fgorski@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#798229}
-
chromium-autoroll authored
Roll ChromeOS Airmont AFDO profile from 86-4183.57-1597053344-benchmark-86.0.4231.0-r1 to 86-4183.57-1597053344-benchmark-86.0.4232.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-airmont-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: I7ec183d4c0ca2c55bdcecd0603a6cd03c22ab694 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2357489Reviewed-by:
-
Lei Zhang authored
FindIt says the test recently started being is flaky. Bug: 1096976 Change-Id: I7c60c47a365533325748818f27bf0fd5e4eaaeb5 Tbr: mahmadi@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2357131Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#798227}
-
Kyle Ju authored
Bug: 1116264 Change-Id: Ie91b0b6298c9ad3d1284157291a0dd90e03ca985 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354302Reviewed-by:
Robert Ma <robertma@chromium.org> Commit-Queue: Kyle Ju <kyleju@chromium.org> Cr-Commit-Position: refs/heads/master@{#798226}
-
K. Moon authored
Adds a "PdfIncrementalLoading" feature to control whether or not the PDF viewer tries to use incremental loading. The default state is enabled, as this feature has shipped already, but we would like to experiment with disabling it to address certain problems related to incremental loading. crrev.com/c/2349429 added a similar control for "partial" loading. The two features are orthogonal: Incremental loading tries to load a PDF before all the bytes have arrived, while partial loading tries to fetch the bytes out of order. (Partial loading currently is not useful without incremental loading, however.) The linearized.pdf file was derived from the equivalent file in third_party/pdfium/testing/resources. For the purposes of this test, the file has been relinearized and decompressed using qpdf. Bug: 1115149 Change-Id: Ib9f9d3d66b9c5d051528a6d49b4662b70d236649 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352217 Commit-Queue: K. Moon <kmoon@chromium.org> Reviewed-by:
Daniel Hosseinian <dhoss@chromium.org> Cr-Commit-Position: refs/heads/master@{#798225}
-
David Van Cleve authored
This change updates net_log_test_util's methods that retrieve strings from NetLogEvent dictionaries to allow fetching a string from a nested dictionary using the base::Value::GetStringPath syntax (for instance, "inner.item" will fetch { "inner": { "item": "value" } }). (This allows writing some slightly more concise test code in the child CL crrev.com/c/2315641.) R=eroman Bug: None Change-Id: Ie8552b9347e9bb147f12e1a57ca98a43b9216f88 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354293 Commit-Queue: David Van Cleve <davidvc@chromium.org> Commit-Queue: Eric Roman <eroman@chromium.org> Reviewed-by:Eric Roman <eroman@chromium.org> Auto-Submit: David Van Cleve <davidvc@chromium.org> Cr-Commit-Position: refs/heads/master@{#798224}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1597405958-c5a8fe7086bb1f6a4ff7abcf1204e717b88da2c5.profdata to chrome-mac-master-1597426673-550b761d47e655299dbb3d5b54525f083ab2d05d.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: Ia56486fb547441131e12c282dfe029a17a20a84c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2357094Reviewed-by:
-
chromium-autoroll authored
Roll ChromeOS Silvermont AFDO profile from 86-4183.57-1597055597-benchmark-86.0.4231.0-r1 to 86-4183.57-1597055597-benchmark-86.0.4232.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-silvermont-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: Iedac652f41c5b9f9b05fad000bd0f29eff0c28a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2357429Reviewed-by:
-
