GitLab

Bug: 808287
TBR: jeremymanson
Change-Id: I252d13864e5749c0e9c15bf2e8b3771d2fdd3683
Reviewed-on: https://chromium-review.googlesource.com/c/1324106Reviewed-by: Scott Graham <scottmg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606137}

This reverts commit 0df82fcd.

Reason for revert: The Builder linux64 trunk keeps failing due to ChromeBrowserMainBrowserTest.VariationsServiceStartsRequestOnNetworkChange browser test.
https://bugs.chromium.org/p/chromium/issues/detail?id=902784

Bug: 902784, 883121

Original change's description:
> Reland: Network Service: Migrate NetworkMetricsProvider to NetworkConnectionTracker
> 
> The "Initial upload" patch of this CL is the same as:
> https://chromium-review.googlesource.com/c/chromium/src/+/1274585
> 
> The above original CL was reverted at:
> https://chromium-review.googlesource.com/c/chromium/src/+/1319614
> 
> The major changes since the "Initial upload" patch set 1:
> Removed some unnecessary include files and removed the "//services/network/public/cpp"
> dep from "components/metrics/BUILD.gn". These include files and dep caused the
> build error Cronet for Android.
> 
> TBR=olivierrobin@chromium.org, michaelbai@chromium.org, jam@chromium.org, fdoray@chromium.org, asvitkine@chromium.org
> 
> Bug: 883121
> Change-Id: Ifcaf40ea1b72ddc3a6a72be16e4d52190740e5a4
> Reviewed-on: https://chromium-review.googlesource.com/c/1320710
> Reviewed-by: Jun Cai <juncai@chromium.org>
> Commit-Queue: Jun Cai <juncai@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#605899}

TBR=michaelbai@chromium.org,jam@chromium.org,fdoray@chromium.org,asvitkine@chromium.org,olivierrobin@chromium.org,juncai@chromium.org

Change-Id: I37832c49552e6d163439d719d5820e1811ccadcb
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 883121
Reviewed-on: https://chromium-review.googlesource.com/c/1324104Reviewed-by: Jun Cai <juncai@chromium.org>
Commit-Queue: Jun Cai <juncai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606136}

Added in the Previews UKM observer which is most previews-generic PLM
observer we have.

See bug for more context.

Bug: 900466
Change-Id: I828728bf561e8253105b3b22a35b9e031b0266dd
Reviewed-on: https://chromium-review.googlesource.com/c/1313851
Commit-Queue: Robert Ogden <robertogden@chromium.org>
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Reviewed-by: Ryan Sturm <ryansturm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606135}

This is a reland of aa69df1c

Includes a fix for flakiness of tests:
 SystemDisplayApiTest.SetDisplay (crbug.com/901586) and
- HeadlessBrowserTest.CreateAndDestroyBrowserContext (crbug.com/901637)

Original change's description:
> Perfetto: Unify TraceEventAgent classes
>
> This unifies the Perfetto and non-Perfetto TraceEventAgent classes, so
> that it's possible to use Perfetto directly even when it's not enabled
> as the default TraceLog backend.
>
> Also moved the Mojo bindings of ProducerHost into a StrongBindingSet of PerfettoService
> so they get cleaned up if the service gets shut down.
>
> Already reviewed as part of https://chromium-review.googlesource.com/c/chromium/src/+/1161541
>
> Change-Id: I3070d69e92778de8e3b5e33957ab4f4694b782af
> Reviewed-on: https://chromium-review.googlesource.com/c/1307998
> Commit-Queue: oysteine <oysteine@chromium.org>
> Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
> Reviewed-by: oysteine <oysteine@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#605060}

Change-Id: Ic0e57577e5f63ece544e48f9bc01ae597cd0b3be
Reviewed-on: https://chromium-review.googlesource.com/c/1321585
Commit-Queue: oysteine <oysteine@chromium.org>
Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606134}

This feature shipped in M70 which is now stable.

BUG=831743

Change-Id: If44134cfa6ff9328164109843adc409a71e3531e
Reviewed-on: https://chromium-review.googlesource.com/c/1323700Reviewed-by: Gary Kacmarcik <garykac@chromium.org>
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606133}

Fixed test instantiation.
Fixed a bug where an empty autofill profile causes the password manager
tests to fail, since password tests do not know how to setup Chrome's
autofill profile.

Bug: 847905
Change-Id: Ic76163b28e97c102ed9c7944685aae115629e067
Reviewed-on: https://chromium-review.googlesource.com/c/1320931Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Commit-Queue: Yiming Zhou <uwyiming@google.com>
Cr-Commit-Position: refs/heads/master@{#606132}

Surprisingly this hadn't been done. So we are missing SSE, SSE2
optimizations which should be available on all platforms, and a
couple SSE4.1 optimizations which are runtime selected.

This condenses all include_dirs, cflags, and defines into a common
opus_private_config for sharing with intrinsic targets.

It looks like AVX support has been started in libopus, so the next
update that pulls in some of that code will need to add a opus_avx
target tagged with a -mavx cflag.

This doesn't seem to add any decoding speedup per media_perftests,
but much of this code is for encoding, so WebRTC and MediaRecorder
should benefit.

BUG=none
TEST=unittests all pass and bots are happy

Change-Id: I0a12460af899c4d94c16e4024c043ff25e896463
Reviewed-on: https://chromium-review.googlesource.com/c/1318807Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
Commit-Queue: Dale Curtis <dalecurtis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606131}

This is useful in single-process-mash to correlate windows.

BUG=756085
TEST=none

Change-Id: I8845b62754ba5c34d352b49491078e69a35719aa
Reviewed-on: https://chromium-review.googlesource.com/c/1323705
Commit-Queue: Scott Violet <sky@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606130}

This change makes it possible to reprioritize socket pool ConnectJobs
to match their corresponding Requests. For TransportConnectJobs that are
reprioritized while undergoing host resolution, the corresponding host
resolver request is also reprioritized to match the connect job.

Bug: 166689
Change-Id: Icaed423c6f363fa15e9e379aa135a3b98330d1a1
Reviewed-on: https://chromium-review.googlesource.com/c/1320210
Commit-Queue: Lily Chen <chlily@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606129}

https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/c06a35b90214..e121da84258f


git log c06a35b90214..e121da84258f --date=short --no-merges --format='%ad %ae %s'
2018-11-07 stevenperron@google.com Start SPRIV-Tools v2018.7
2018-11-07 stevenperron@google.com Finalize SPIRV-Tools v2018.6
2018-11-07 stevenperron@google.com Update CHANGES


Created with:
  gclient setdep -r src/third_party/SPIRV-Tools/src@e121da84258f

The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=dsinclair@chromium.org

Change-Id: I131706f3838a91494ebc18747ed8e8efe894a663
Reviewed-on: https://chromium-review.googlesource.com/c/1323609Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#606128}

Provide the necessary bits in order to make WebSpeech API
work in Android WebView. In particular the Android WebView
specific speech recognition delegate and related code is
added in this CL.

BUG=487255
TEST=https://www.google.com/intl/en/chrome/demos/speech.html

TBR=dmazzoni@chromium.org

Change-Id: I9ed3f03d86955e16df2e026ccdf3a0f155231a9a
Reviewed-on: https://chromium-review.googlesource.com/c/1181573
Commit-Queue: Tim Volodine <timvolodine@chromium.org>
Reviewed-by: Richard Coles <torne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606127}

This reverts commit 0d257042.

Reason for revert: 
When I ran
out/Default/interactive_ui_tests --gtest_filter=PasswordGenerationInteractiveTest.PopupShownAutomaticallyAndPasswordErased --gtest_repeat=10 --gtest_break_on_failure
with the patch in, on my (virtual) Linux machine, I could reproduce the test failure reliably.
When I reverted the patch locally, the test always succeeded.

Original change's description:
> Fix dynamically changed forms in NewPasswordFormManager.
> 
> Sometimes sites change forms after adding them. For example removing/
> adding fields. This CL makes NewPasswordFormManager process this
> situation, by updating |observed_form|, parsing it again and sending
> new data to the renderer.
> 
> Bug: 895411, 831123, 895788
> Change-Id: I296180c5b30f879a3f9bcc7af7cccb98f5fa8eb8
> Reviewed-on: https://chromium-review.googlesource.com/c/1317893
> Commit-Queue: Vadym Doroshenko <dvadym@chromium.org>
> Reviewed-by: Ilya Sherman <isherman@chromium.org>
> Reviewed-by: Vaclav Brozek <vabr@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#606041}

TBR=isherman@chromium.org,vabr@chromium.org,dvadym@chromium.org

Change-Id: I3c1f2e4570bd07b9cba0f0bdbbe65d7dc28300a9
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 895411, 831123, 895788
Reviewed-on: https://chromium-review.googlesource.com/c/1323657Reviewed-by: Vaclav Brozek <vabr@chromium.org>
Commit-Queue: Vaclav Brozek <vabr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606126}

Temporarily until the underlying cause is fixed.

Bug: 902644
Change-Id: I29715b17af02e48a79319f61c1a32617dc872763
Reviewed-on: https://chromium-review.googlesource.com/c/1323797Reviewed-by: danakj <danakj@chromium.org>
Commit-Queue: enne <enne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606125}

TBR=peter@chromium.org

Change-Id: I94aec74b3286c8d09f2e36a97c87aea61df22fbb
Reviewed-on: https://chromium-review.googlesource.com/c/1323451
Commit-Queue: Rayan Kanso <rayankans@chromium.org>
Reviewed-by: Rayan Kanso <rayankans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606124}

These features shipped in M70 which is now stable.

Bug: 731810
Change-Id: I72c55db4ef878112426f125865bfebc7bccd094c
Reviewed-on: https://chromium-review.googlesource.com/c/1323695Reviewed-by: Paul Meyer <paulmeyer@chromium.org>
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606123}

CL is a follow up of blundell's comment in [1].

Basically, it replaces the direct calls to AccountTrackerService::SeedAccountInfo
(and the sibling IdentityTestEnv::SetRefreshTokenForAccount calls),
with an existing IdentityTestEnv equivalent method: MakeAccountAvailable.

[1] https://crrev.com/c/1311093/2/chrome/browser/ui/webui/settings/people_handler_unittest.cc#1039

BUG=890810

Change-Id: I15753453a61e435d59ed3c1a879f89b9cb027dcf
Reviewed-on: https://chromium-review.googlesource.com/c/1324049Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Antonio Gomes <tonikitoo@igalia.com>
Cr-Commit-Position: refs/heads/master@{#606122}

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/4d2d5b4bbe38..421605af68e3


git log 4d2d5b4bbe38..421605af68e3 --date=short --no-merges --format='%ad %ae %s'
2018-11-07 recipe-roller@chromium.org Roll recipe dependencies (trivial).


Created with:
  gclient setdep -r src/third_party/depot_tools@421605af68e3

The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=agable@chromium.org

Change-Id: I91f412273c821f1d12680e2e97f84f25165de086
Reviewed-on: https://chromium-review.googlesource.com/c/1323630Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#606121}

Currently code on the UI thread checks to see if the RDH is available,
then posts a task to it on the IO thread. By the time the IO task is
posted, the RDH could be shut down or even destroyed.

This CL makes some of the UI -> IO hops from RenderViewHost do all
the shutdown checking on the IO thread.

Bug: 901468
Change-Id: I5077e70200b0da2824d1d0c1128d5d0ac614cd66
Reviewed-on: https://chromium-review.googlesource.com/c/1323409Reviewed-by: Matt Menke <mmenke@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Charlie Harrison <csharrison@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606120}

Change-Id: Idba500f31b9d3a0dc435ed8d55e31d05dec61cd6
Reviewed-on: https://chromium-review.googlesource.com/c/1323569Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606119}

Spec:
https://wicg.github.io/background-fetch/#background-fetch-update-ui-event-update-ui

Bug: 901909
Change-Id: Ia319cd03e41e65c5a6a1f5e61cde6f4ae7705a32
Reviewed-on: https://chromium-review.googlesource.com/c/1320330
Commit-Queue: Rayan Kanso <rayankans@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606118}

It is possible that, before performing an action, the ARC++ container crashed.

Ensure that we don't also crash Chrome by dereferencing nullptr.

Bug: 902107
Change-Id: I09de402a41dfead09cee4685bc610a227740f9a5
Reviewed-on: https://chromium-review.googlesource.com/c/1318740
Commit-Queue: David Tseng <dtseng@chromium.org>
Reviewed-by: Yuki Awano <yawano@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606117}

This CL does two major things:
1. Plumb information to //content about whether a navigation is an
   "opener navigation". That is, is the initiator navigating its opener.

2. Armed with the "opener_navigation" bit, we can apply a policy to
   navigations to tell them to disallow downloads for opener navigations.
   This entails changing a boolean "allow_downloads" in
   CommonNavigationParams to an enum, which enumerates out the reason why
   the download was blocked (opener, view source, interstitial, etc).

In navigation logic, we can start logging some metrics to get a sense
for how often opener navigations actually end up being downloads.
Ideally, numbers will be low and we can deprecate this behavior. If
numbers are still high, we can relax this restriction. Two possible
relaxations:
a. Allow navigations resulting in downloads if the initiator is
   same-origin with the opener.

b. Allow navigations resulting in downloads if the initiator has a
   user gesture.

For now, we merely collect some UMA to see how prevalent this case is,
for evidence in a deprecation / intervention.

Bug: 632514
Change-Id: I9231a071ef9362d038c59bbdf3469ce4e227605e
Reviewed-on: https://chromium-review.googlesource.com/c/1316167
Commit-Queue: Charlie Harrison <csharrison@chromium.org>
Reviewed-by: Chris Palmer <palmer@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606116}

This reverts commit 2fc9f6f2.

Reason for revert: Test is still very flaky
https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=content_shell_test_apk&tests=org.chromium.content.browser.TracingControllerAndroidImplTest%23testBufferUsage

Original change's description:
> tracing: Address TracingControllerAndroid test failures.
> 
> Fixes the flakiness of buffer usage / known categories tests by
> resolving an accidental race condition. Also restricts disabling
> the other two tests to <= kitkat devices since those seem to be
> the only ones that show (inexplicable) flakiness.
> 
> TBR=yfriedman@chromium.org
> 
> Bug: 899894
> Change-Id: I0225c1519ea19910492ffb60a242bcc71b2275b4
> Reviewed-on: https://chromium-review.googlesource.com/c/1307433
> Reviewed-by: Eric Seckler <eseckler@chromium.org>
> Commit-Queue: Eric Seckler <eseckler@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#604209}

TBR=yfriedman@chromium.org,skyostil@chromium.org,eseckler@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 899894
Change-Id: Ie47cf56e05861069e1b0a767138b1802f1a2584f
Reviewed-on: https://chromium-review.googlesource.com/c/1323894Reviewed-by: agrieve <agrieve@chromium.org>
Commit-Queue: agrieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606115}

https://pdfium.googlesource.com/pdfium.git/+log/436c9f1a8887..28f76deac908


git log 436c9f1a8887..28f76deac908 --date=short --no-merges --format='%ad %ae %s'
2018-11-07 tsepez@chromium.org Use --no-expose-wasm flag in PDFium tests.


Created with:
  gclient setdep -r src/third_party/pdfium@28f76deac908

The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=dsinclair@chromium.org

Change-Id: If427ca2e93f37f6622935d5cc015b9695840cac9
Reviewed-on: https://chromium-review.googlesource.com/c/1323613Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#606114}

The using namespace construct is disallowed in the code style guide.
It also causes issues (compilation warnings turned into errors)
in jumbo builds since they will be in a "header context" there
which is explicitly blocked by our compiler settings.

This patch also has a bit of a feature creep to remove a number
of unnecessary static_casts that made the code hard to read,
especially with the namespaces.

Change-Id: Icaa4968695a6f033868aac681a9ebe08eee75c3e
Reviewed-on: https://chromium-review.googlesource.com/c/1320131
Commit-Queue: Daniel Bratell <bratell@opera.com>
Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606113}

This aligns Chrome's behavior with the Windows and macOS proxy resolvers (but not Firefox).

Concretely:
 * localhost names (as determined by net::IsLocalhost) now implicitly bypass the proxy
 * link-local IP addresses implicitly bypass the proxy

The implicit rules are handled by ProxyBypassRules, and it is possible to override them when manually configuring proxy settings (but not when using PAC or auto-detect).

This change also adds support for the "<-loopback>" proxy bypass rule, with similar semantics as it has on Windows (removes the implicit bypass rules for localhost and link-local).

The compatibility risk of this change should be low as proxying through localhost was not universally supported. It is however an idiom used in testing (a number of our own tests had such a dependency). Impacted users can use the "<-loopback>" bypass rule as a workaround.

Bug: 413511, 899126, 901896
Change-Id: I263ca21ef9f12d4759a20cb4751dc3261bda6ac0
Reviewed-on: https://chromium-review.googlesource.com/c/1303626
Commit-Queue: Eric Roman <eroman@chromium.org>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606112}

Ensure that the OobeWebViewDialog is the WebContentsDelegate for the
WebContents used in views-based sign-in/OOBE. This fixes
camera access by SAML providers on the sign-in screen, because
the versions of CheckMediaAccessPermission/RequestMediaAccessPermission
forwarding to MediaCaptureDevicesDispatcher are invoked again.

Move focus/keyboard handling from OobeUIDialogDelegate to
OobeWebViewDialog to make changing the delegate unnecessary.

Background:
WebDialogView usually acts as the WebContentsDelegate for the
WebContents it embeds. CL:1178111 introduced the subclasss
OobeWebDialogView which customizes the WebContentsDelegate handling to
allow media requests.
CL:1197785 then exchanged the WebContents' delegate altogether to
implement keyboard/focus handling, orphaning the functions introduced in
CL:1178111. This CL moves the keyboard/focus handling to the
OobeWebDialogView and restores its function as WebContentsDelegate.

Bug: 900323
Test: out/Default/browser_tests --gtest_filter=*SAMLPolicy*Test*TestLoginMedia*
Change-Id: I6c12b8b08efaa71a9f9cbb93d674448cdccbdeaf
Reviewed-on: https://chromium-review.googlesource.com/c/1323075
Commit-Queue: Pavol Marko <pmarko@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Quan Nguyen <qnnguyen@chromium.org>
Reviewed-by: Jacob Dufault <jdufault@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606111}

Initially shipped in M65 this feature flag can be removed.

BUG=650433

Change-Id: I2088238be14ec263e2bb81dc0cb9730438315cb2
Reviewed-on: https://chromium-review.googlesource.com/c/1323891Reviewed-by: Erik Chen <erikchen@chromium.org>
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606110}

When Bluetooth security keys change state from non-pairing mode to
pairing mode, Bluetooth device ID (and corresponding authenticator id)
is changed for security reasons. Currently this is handled by the UI by
removing the authenticator from the UI list and re-adding a
authenticator with an updated id. This is not ideal, as this may cause UI
to flicker. Introduce OnAuthenticatorIdChanged() to
AuthenticatorListObserver so that authenticator id can be changed
without invoking unnecessary UI changes.

Bug: 877344
Change-Id: I9f3328c4b7121864e4e9adfe4567c4e134e3b5a4
Reviewed-on: https://chromium-review.googlesource.com/c/1319673
Commit-Queue: Jun Choi <hongjunchoi@chromium.org>
Reviewed-by: Kim Paulhamus <kpaulhamus@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606109}

Change-Id: I4fa7924db8e6ba4e7642957399e0e47289027e97
Reviewed-on: https://chromium-review.googlesource.com/c/1318390Reviewed-by: Shubhie Panicker <panicker@chromium.org>
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Katie Dillon <kdillon@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606108}

1) I found in tapOnTarget, calling WebViewScrollElementToVisible then
WebViewTapElement is fragile for some reason. Debugging seems to hint
it's a race condition, where sometimes the window is not redrawn
(despite reporting that the new element is on screen), causing an
incorrect hitbox to be reported for the target element and misclicks
to occur.

Adding a 0.1s delay resolved those issues for me, and I will confirm it
is stable on waterfall after landing. It is a little clumsy, but think
it is plenty fine while investigating this further.

2) Not sure why, but target.getAttribute('placeholder') isn't working
for me anymore. After inspecting the HTML source for some target sites,
return target.placeholder; seemed to be a good fix.

Change-Id: Idf0bf0aca31578fc6ef0b18daa869cfba4b0160b
Reviewed-on: https://chromium-review.googlesource.com/c/1320751Reviewed-by: Eric Noyau <noyau@chromium.org>
Reviewed-by: Moe Ahmadi <mahmadi@chromium.org>
Commit-Queue: ericale <ericale@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606107}

Updates automation code to keep up to date with recent
refactoring in chrome tree.

Bug: None
Test: Manual
Change-Id: I56d77ce1a891b155d9374aed9b9690c2782159df
Reviewed-on: https://chromium-review.googlesource.com/c/1315702Reviewed-by: David Tseng <dtseng@chromium.org>
Reviewed-by: Luke Halliwell <halliwell@chromium.org>
Commit-Queue: Randy Rossi <rmrossi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606106}

https://chromium.googlesource.com/chromiumos/chromite.git/+log/c238958c1ca3..d5ee1c6aed6c


git log c238958c1ca3..d5ee1c6aed6c --date=short --no-merges --format='%ad %ae %s'
2018-11-07 metzman@chromium.org cros_fuzz: Create helper script for fuzzer development
2018-11-07 derat@chromium.org portage_util: Set has_test for cros-go and tast-bundle.
2018-11-07 bpastene@chromium.org Roll third_party/gn_helpers forward.
2018-11-07 gwendal@chromium.org cros deploy: Fix --root /usr/local --deep invocation
2018-11-07 saklein@chromium.org run_chroot_version_hooks: cleanup vestigal method
2018-11-07 saklein@chromium.org security_test_image: port to chromite


Created with:
  gclient setdep -r src/third_party/chromite@d5ee1c6aed6c

The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=chrome-os-gardeners@chromium.org

Change-Id: I9d084e9fe6ac8400135bc33691a3d0edf95295fa
Reviewed-on: https://chromium-review.googlesource.com/c/1323612Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#606105}

It is likely a cause of janks on UI thread on Android.
Add a trace event to get metrics about the duration.

BUG=902203

Change-Id: I4c4e9c2a20790264b982007ea7ee88ddfa7b972c
Reviewed-on: https://chromium-review.googlesource.com/c/1319369Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Commit-Queue: ssid <ssid@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606104}

SharedImage backend implementation is careful to restore GL state. The
reason we need to MakeCurrent is to create the texture in the correct
GPU process side share group.

With virtual contexts, we are often current with a different surface. By
skipping the unnecessary MakeCurrent, we avoid stalling GPU main thread
waiting for vblank on Nvidia GPUs (where use_virtualized_gl_contexts is
on by default).

Bug: 894100
Change-Id: Ibaf66ffffbe228d5413a50873e1809d115b86e59
Reviewed-on: https://chromium-review.googlesource.com/c/1320591
Commit-Queue: Jonathan Backer <backer@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606103}

Bug: 841628
Change-Id: I8bc446018bb19d6218c07f397fe96650e0a4ea4a
Reviewed-on: https://chromium-review.googlesource.com/c/1322353Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: agrieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606102}

Add an integration test for a URLLoaderThrottle changing a URL and ensuring that it's requested correctly.

This is tested as part of PolicyTest.ForceGoogleSafeSearch after the fix in r605518, but we should have a test at the content-layer for URLLoaderThrottle's behavior.

Bug: 902775
Change-Id: I9f9f4de201d55389709a4a7336c6bf581bb4bab3
Reviewed-on: https://chromium-review.googlesource.com/c/1323896Reviewed-by: Clark DuVall <cduvall@chromium.org>
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606101}

This CL moves ownership of payments::PaymentsClient and FormDataImporter to
implementations of AutofillClient in order for these objects to live beyond
the lifespan of AutofillManager. AutofillDriver and thus AutofillManager's
lifespan is tied to the renderer frame which gets destroyed with
cross-domain navigations on form submission and therefore creidt card save
isn't offered. With this change these objects' lifespan will be tied to the
tab.

Bug: 892299
Change-Id: I1651e92ba032d04d047221d91bafbdfcc511296a
Reviewed-on: https://chromium-review.googlesource.com/c/1320215
Commit-Queue: Moe Ahmadi <mahmadi@chromium.org>
Reviewed-by: Jared Saul <jsaul@google.com>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: John Wu <jzw@chromium.org>
Reviewed-by: Tao Bai <michaelbai@chromium.org>
Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Reviewed-by: Fabio Tirelo <ftirelo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606100}

Previously we skipped to create non-network factories for subresource loading
from a service worker as a performance optimization. It works on
S13nServiceWorker because extensions are handled by a resource dispatcher host.
However, NetworkService doesn't work well because those requests need to be
routed to extensions before going to the NetworkService. This CL fixes by always
creating non-network factories for subresource loads.

Bug: 901443
Change-Id: Ia932dc11352c14be9f33c9e3448891cf66d699e0
Reviewed-on: https://chromium-review.googlesource.com/c/1322258Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606099}

Rather than having content call blink code to call back into content
in order to set visibility on the compositor, have content code do so
directly.

Historically, this would be an artifact of the compositor being an
optional thing, and being a wrapper around different code for each port
of WebKit.

Now we can remove the method. RenderWidget already does SetVisible() to
true during its creation/init phase when appropriate, so blink doesn't
need to repeat that. Then, we change visibility on response to IPCs
received in content, so it can control the compositor directly.

This gives us more clarity around when the compositor will be visible
or not, and thus more confidence that it will stay non-visible for a
swapped out RenderWidget.

LayoutTests demand the ability to set the page's visibility state
directly from the TestRunner, with more options than just hidden or
visible. So we expose the ability to set that on RenderViewImpl to
the TestRunner, and share that code internally in RenderViewImpl to
unify the two paths again, since they'd diverge otherwise with
moving code up to RenderViewImpl from WebViewImpl.

R=dcheng@chromium.org, piman@chromium.org

Change-Id: I366e0f36923f8a690e4e1562e46e6d94e76f3e61
Bug: 896836, 419087
Reviewed-on: https://chromium-review.googlesource.com/c/1320191
Commit-Queue: danakj <danakj@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606098}