GitLab

TBR=mmoss@chromium.org (chrome/installer/linux)
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Review URL: https://codereview.chromium.org/1324623005

Cr-Commit-Position: refs/heads/master@{#348727}

Patch Set 1 adds regression test, watch it specatularily fail in trybot logs.
Patch Set 2 fixes the issue.

BUG=531570

Review URL: https://codereview.chromium.org/1345453005

Cr-Commit-Position: refs/heads/master@{#348726}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/5f48d99..0657feb

Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.

NOTRY=true
TBR=hayato@chromium.org,dcheng@chromium.org

Review URL: https://codereview.chromium.org/1341793005

Cr-Commit-Position: refs/heads/master@{#348725}

Some consumers of the ProfileDownloader class dispose of it in the
OnProfileDownloadSuccess callback. When the profile image is cached
and the image fetch is synchronous, this caused a use-after-free in
ProfileDownloader::OnAccountUpdated().

BUG=518866

Review URL: https://codereview.chromium.org/1341113002

Cr-Commit-Position: refs/heads/master@{#348724}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/fbb3af7..5f48d99

Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.

NOTRY=true
TBR=hayato@chromium.org,dcheng@chromium.org

Review URL: https://codereview.chromium.org/1336803003

Cr-Commit-Position: refs/heads/master@{#348723}

The initial caching getprop call fails without an exit code when its
output gets truncated. It currently gets reran with large_output=True,
but switching it to do so by default will reduce noise.

see e.g. http://build.chromium.org/p/chromium.linux/builders/Android%20Tests/builds/22248/steps/events_unittests/logs/stdio

BUG=

Review URL: https://codereview.chromium.org/1341103002

Cr-Commit-Position: refs/heads/master@{#348722}

Pass the evdev scancode down from java so that it can be properly
presented to blink. The evdev code is necessary because the
android keycode already has the keyboard mapping applied. If the scancode
is 0 we fall back to mapping the DomCode based on the android keycode.

BUG=227231

Review URL: https://codereview.chromium.org/1310513010

Cr-Commit-Position: refs/heads/master@{#348721}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/1f0dc84..fbb3af7

Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.

NOTRY=true
TBR=hayato@chromium.org,dcheng@chromium.org

Review URL: https://codereview.chromium.org/1341533004

Cr-Commit-Position: refs/heads/master@{#348720}

Previously //build/config/sanitizer:deps unconditionally depended on
//third_party/instrumented_libraries:deps. This dependency is only necessary
//when compiling with a sanitizer, and in standalone other projects like nacl,
//instrumented_libraries doesn't exist.

This patch makes all contents of sanitizer:deps conditional on using a
sanitizer, which matches what the documentation explicitly says.

BUG=

Review URL: https://codereview.chromium.org/1341043005

Cr-Commit-Position: refs/heads/master@{#348719}

BUG=491352

Review URL: https://codereview.chromium.org/1328483005

Cr-Commit-Position: refs/heads/master@{#348718}

net: add fastmail.com and (*.)www.fastmail.com to HSTS preloaded list.
Cr-Commit-Position: refs/heads/master@{#348717}

Pull from upstream:
https://codereview.chromium.org/1339513003

Temporarily revert https://chromium-review.googlesource.com/297480

The change is causing ASAN failures for remoting_unittests:
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel_ng/builds/51862/steps/remoting_unittests%20%28with%20patch%29/logs/VideoDecoderVp9Test.VideoEncodeAndDecode
https://chromium-review.googlesource.com/299511

Revert *everything* (well almost everything)
https://chromium-review.googlesource.com/299701
This should provide a clean revision of upstream libvpx to rearrange DEPS.

R=tomfinegan@chromium.org

Review URL: https://codereview.chromium.org/1334413002

Cr-Commit-Position: refs/heads/master@{#348716}

This CL is just cleaning up the inconsistencies accumulated
w.r.t. of names used in the TraceConfig vs enum names in
the codebase.
Also this simplifies the complex and unnecessary wrapping in
of the level of details argument in the RequestGlobalMemoryDump()
API.

BUG=
TBR=jochen@chromium.org,reed@google.com

Review URL: https://codereview.chromium.org/1337943003

Cr-Commit-Position: refs/heads/master@{#348715}

BUG=429053
TEST=gpu_unittests
R=piman@chromium.org

Review URL: https://codereview.chromium.org/1335243002

Cr-Commit-Position: refs/heads/master@{#348714}

Revert of mandoline: Add back/forward support and UI. (patchset #9 id:160001 of https://codereview.chromium.org/1326443006/ )

Reason for revert:
Broke Win x64 GN:
FAILED: ninja -t msvc -e environment.x64 -- E:\b\build\goma/gomacc.exe "E:\b\depot_tools\win_toolchain\vs2013_files\VC\bin\amd64/cl.exe" /nologo /showIncludes /FC @obj/components/web_view/lib/url_request_cloneable.obj.rsp /c ../../components/web_view/url_request_cloneable.cc /Foobj/components/web_view/lib/url_request_cloneable.obj /Fdobj/components/web_view/lib_cc.pdb
e:\b\build\slave\win_x64_gn\build\src\components\web_view\url_request_cloneable.cc(43) : error C2220: warning treated as error - no 'object' file generated
e:\b\build\slave\win_x64_gn\build\src\components\web_view\url_request_cloneable.cc(43) : warning C4267: 'initializing' : conversion from 'size_t' to 'uint32_t', possible loss of data
ninja: build stopped: subcommand failed.

Original issue's description:
> mandoline: Add back/forward support and UI.
>
> BUG=526268
>
> Committed: https://crrev.com/f72ad72272047f3a1471de9f37e0cba7174ac0b0
> Cr-Commit-Position: refs/heads/master@{#348673}

TBR=msw@chromium.org,sky@chromium.org,ben@chromium.org,erg@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=526268

Review URL: https://codereview.chromium.org/1343773003

Cr-Commit-Position: refs/heads/master@{#348713}

An "adb install" always terminates the app, so when skipping the step,
we should terminate the app to have consistent behaviour.

BUG=

Review URL: https://codereview.chromium.org/1334303003

Cr-Commit-Position: refs/heads/master@{#348712}

WebRTC 9920:9933

Changes: https://chromium.googlesource.com/external/webrtc/trunk/webrtc.git/+log/0938a04..3e25523

Libjingle 9920:9934

Changes: https://chromium.googlesource.com/external/webrtc/trunk/talk.git/+log/df5ede1..90294bd

TBR=pbos@webrtc.org
BUG=

Review URL: https://codereview.chromium.org/1341043003 .

Cr-Commit-Position: refs/heads/master@{#348711}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/dde36c9..1f0dc84

Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.

NOTRY=true
TBR=hayato@chromium.org,dcheng@chromium.org

Review URL: https://codereview.chromium.org/1344643002

Cr-Commit-Position: refs/heads/master@{#348710}

I also removed ROTATE_WINDOW from the list because it doesn't make sense in lock/login screen.

BUG=528396
R=abodenha@chromium.org

Review URL: https://codereview.chromium.org/1328703006

Cr-Commit-Position: refs/heads/master@{#348709}

https://boringssl.googlesource.com/boringssl/+log/ac8302a092e8e232dbabf5a01eff5dd37671b5c8..1d128f369c797b8bae996d5e973fc0b8a099a1b8

BUG=none

Review URL: https://codereview.chromium.org/1338053002

Cr-Commit-Position: refs/heads/master@{#348708}

Don't allow extensions to inject scripts into other extension pages, since this
is a security risk. This was meant to be addressed, but there was an incorrect
early-return. Also add a regression test.

BUG=529682

Review URL: https://codereview.chromium.org/1335083004

Cr-Commit-Position: refs/heads/master@{#348707}

This addresses the bug where range checks are incorrect when
converting from a floating point value to an integral value of
higher precision but lower width. It also reverts a previous
attempted fix that eliminated false negatives but introduced
false positives.

BUG=522989

Review URL: https://codereview.chromium.org/1338553003

Cr-Commit-Position: refs/heads/master@{#348706}

GYP and GN put generated files in different places inside the build
directory. This means that if you do a GYP build and then a GN build
into the same directory, you may get unpredictable results depending
on which generated files are picked up at what times.

In order to avoid this, we modify MB to keep track of whether a
given build directory has build files generated by GYP or GN; if there
is a mismatch (like when we flip a bot from GYP to GN), we clobber the
build directory and start from scratch to be safe.

In addition, the first time we enable MB on a bot, we will not know
what the existing build directory contains; to be safe, we do a clobber
in this situation as well.

R=brettw@chromium.org
BUG=

Review URL: https://codereview.chromium.org/1338123002

Cr-Commit-Position: refs/heads/master@{#348705}

The experiment has been at 100% for a while without incident.

BUG=497518

Review URL: https://codereview.chromium.org/1335213002

Cr-Commit-Position: refs/heads/master@{#348704}

R=brettw@chromium.org, thestig@chromium.org
BUG=432959

Review URL: https://codereview.chromium.org/1338893002

Cr-Commit-Position: refs/heads/master@{#348703}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/d2d3237..dde36c9

Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.

NOTRY=true
TBR=hayato@chromium.org,dcheng@chromium.org

Review URL: https://codereview.chromium.org/1342863003

Cr-Commit-Position: refs/heads/master@{#348702}

BUG=514340

Review URL: https://codereview.chromium.org/1332003002

Cr-Commit-Position: refs/heads/master@{#348701}

Since UmaSessionStats.logRendererCrash is only called if
the activityState is not PAUSED, STOPPED, or DESTROYED, its
redundant boolean is_paused will always be false, thus
this count is the same value as
kStabilityRendererCrashCount, thus making it redundant.

BUG=510327

Review URL: https://codereview.chromium.org/1313503004

Cr-Commit-Position: refs/heads/master@{#348700}

This code is just a skeleton for verification and verification method
is not used for making security decisions or presenting security UI.

The decision to use CertVerifier instead of iOS cert verification API
has not been made yet. But using CertVerifier is easier for
-[WKWebView certificateChain] verification, so this CL uses
CertVerifier.

Original URL: https://codereview.chromium.org/1230033005/

BUG=462427,462425

Review URL: https://codereview.chromium.org/1316063008

Cr-Commit-Position: refs/heads/master@{#348699}

They were being truncated to either 0 or 1. Explicitly handle
ANY_SAMPLES_PASSED, ANY_SAMPLES_PASSED_CONSERVATIVE, and
TRANSFORM_FEEDBACK_PRIMITIVES_WRITTEN BeginQuery targets.

BUG=526748

Review URL: https://codereview.chromium.org/1335393002

Cr-Commit-Position: refs/heads/master@{#348698}

ExifFunctions in image_metadata_extractor.cc loads libexif as
a dll/so, so the target needs to be a shared_library.

This isn't quite right on OS X yet, but it fixes the problem on other
platforms at least.

Review URL: https://codereview.chromium.org/1343453002

Cr-Commit-Position: refs/heads/master@{#348697}

Button opacity for extension actions is set when the container frame changes,
but if the button is also animating, we need to use the final frame to determine
the proper opacity.

BUG=530820

Review URL: https://codereview.chromium.org/1346443002

Cr-Commit-Position: refs/heads/master@{#348696}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/4f9ce20..d2d3237

Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.

NOTRY=true
TBR=hayato@chromium.org,dcheng@chromium.org

Review URL: https://codereview.chromium.org/1341083003

Cr-Commit-Position: refs/heads/master@{#348695}

Implement SimulateMatchingPhase by real calls to PasswordFormManager::FetchMatchingLoginsFromPasswordStore

This allows to unfriend PasswordFormManagerTest from PasswordFormManager.

Also separated test TestNewLogin into two tests TestNewLogin and TestAdditionalLogin, because they tested separate things.

BUG=520831

Review URL: https://codereview.chromium.org/1336193002

Cr-Commit-Position: refs/heads/master@{#348694}

1. Fix the problem that VR desktop take a while to draw.
2. Fix the problem that background of menu bar is black before the desktop is drawn.

BUG=516871

Review URL: https://codereview.chromium.org/1342883002

Cr-Commit-Position: refs/heads/master@{#348693}

R=scottmg@chromium.org
BUG=529769

Review URL: https://codereview.chromium.org/1339133002

Cr-Commit-Position: refs/heads/master@{#348692}

BUG=none
TBR=fukino@chromium.org

Review URL: https://codereview.chromium.org/1341043004

Cr-Commit-Position: refs/heads/master@{#348691}

These new UMA metrics estimate the process-count impact of a policy
wherein extension content and web content never share processes,
even if one contains the other in an iframe.

SiteDetailsBrowserTest: add tests for the new metrics.

WebContentsImpl: Fix a UMA metrics counting error where
<iframe src="about:blank"> was counted as a distinct site.
Now we'll only do that if we see "about:blank" in an
undifferentiated SiteInstance.

BUG=528049

Review URL: https://codereview.chromium.org/1313863006

Cr-Commit-Position: refs/heads/master@{#348690}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/0c3f21f..4f9ce20

Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.

NOTRY=true
TBR=hayato@chromium.org,dcheng@chromium.org

Review URL: https://codereview.chromium.org/1339163002

Cr-Commit-Position: refs/heads/master@{#348689}

This CL ensures that RenderFrameHostManager doesn't create swapped out
RenderViewHosts when swapped out state is disabled. It should be creating
proxy objects instead.

BUG=357747

Review URL: https://codereview.chromium.org/1341003002

Cr-Commit-Position: refs/heads/master@{#348688}