GitLab

Revert of Make profiling lock global rather than per Target (patchset #2 of https://codereview.chromium.org/475803002/)

Reason for revert:
'common' should not be aware of profiler.

Original issue's description:
> Make profiling lock global rather than per Target
> 
> We should pause any actions that could affect performance if any of the targets is being profiled, not only current target.
> 
> BUG=403684
> R=sergeyv@chromium.org
> 
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180336

TBR=sergeyv@chromium.org,apavlov@chromium.org,yurys@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=403684

Review URL: https://codereview.chromium.org/471393002

git-svn-id: svn://svn.chromium.org/blink/trunk@180342 bbb929c8-8fbe-4397-9dbb-9b2b20218538

We show a console message if:
 - An invalid string is set to 'value' IDL attribute.
 - An invalid string is set to 'value' content attribute.
 - 'date' is set to 'type' attribute and existing 'value' content attribute is
   invalid.
 - 'date' is set to 'type' attribute and existing user-specified value is
   invalid.

BUG=397952
TEST=Update expectations of automated tests.

Review URL: https://codereview.chromium.org/461323006

git-svn-id: svn://svn.chromium.org/blink/trunk@180341 bbb929c8-8fbe-4397-9dbb-9b2b20218538

These are crashing on layout tests in the oilpan build. The reason is
that with oilpan these are just raw pointers and are therefore not
default initialized to null.

R=haraken@chromium.org, oilpan-reviews@chromium.org, timloh@chromium.org

Review URL: https://codereview.chromium.org/473163002

git-svn-id: svn://svn.chromium.org/blink/trunk@180340 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Currently there is a bug on V8 APIs on Message objects, and they don't return valid values
when they are called at the first time if V8 has a pending exception.
We need to call twice in order to get valid values.

This is a temporary fix in the Blink side until we fix the V8 side.

BUG=341031

Review URL: https://codereview.chromium.org/478623002

git-svn-id: svn://svn.chromium.org/blink/trunk@180339 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This is probably already true in the code base (we mostly require 2.7
for everything except for some things in ChromiumOS), so this is just
cleanup.

I also fixed a few other nits while touching everything (sorting imports,
fixing shebangs and file permissions).

R=abarth@chromium.org

Review URL: https://codereview.chromium.org/478553002

git-svn-id: svn://svn.chromium.org/blink/trunk@180338 bbb929c8-8fbe-4397-9dbb-9b2b20218538

- WebLocalFrameImpl::initializeWebCoreFrame
- WebLocalFrameImpl::setWebCoreFrame
- WebRemoteFrameImpl::initializeCoreFrame
- WebRemoteFrameImpl::setWebCoreFrame
- WebViewImpl::focusedCoreFrame
- toWebCoreFrame
- updateWebMouseEventFromWebCoreMouseEvent

BUG=none
TEST=none; no behavior changes.

Review URL: https://codereview.chromium.org/474143002

git-svn-id: svn://svn.chromium.org/blink/trunk@180337 bbb929c8-8fbe-4397-9dbb-9b2b20218538

We should pause any actions that could affect performance if any of the targets is being profiled, not only current target.

BUG=403684
R=sergeyv@chromium.org

Review URL: https://codereview.chromium.org/475803002

git-svn-id: svn://svn.chromium.org/blink/trunk@180336 bbb929c8-8fbe-4397-9dbb-9b2b20218538

If a part object has a virtual trace method we need to check the vtable
before calling the trace method. This is necessary because conservative
GCs can see the part object before it has been constructed (if there
is an allocation during the construction of the containing object.)

Added simple regression test that illustrates the issue.

R=erik.corry@gmail.com, zerny@chromium.org

Review URL: https://codereview.chromium.org/455363002

git-svn-id: svn://svn.chromium.org/blink/trunk@180335 bbb929c8-8fbe-4397-9dbb-9b2b20218538

CSS_PARSER_INTEGER is only used as an alias for CSS_NUMBER, and the
enums CSS_PARSER_OPERATOR and CSS_PARSER_IDENTIFIER are both unused.

Review URL: https://codereview.chromium.org/476693002

git-svn-id: svn://svn.chromium.org/blink/trunk@180334 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Just a clean-up of idl_reader.py.

BUG=341031

Review URL: https://codereview.chromium.org/469253004

git-svn-id: svn://svn.chromium.org/blink/trunk@180333 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Add an assertion to make sure NodeRenderingTraversal::parent is not called with a dirty distribution result.

Review URL: https://codereview.chromium.org/448893003

git-svn-id: svn://svn.chromium.org/blink/trunk@180332 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The value minRepetitions is actually used as an upper bound. Looks like
this was a misunderstanding of a review comment in
https://codereview.chromium.org/251643002.

BUG=404023

Review URL: https://codereview.chromium.org/479493002

git-svn-id: svn://svn.chromium.org/blink/trunk@180331 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Currently we have the following two flags:

- m_didCallDispose is used to know whether AudioContext::dispose() is called or not.
- m_isMarkedForDeletion is used to guarantee the following facts:

--- AudioNode should not be re-registered to AudioNode::m_outputs after AudioNode::dispose is called.
--- AudioNode should not get marked as dirty after AudoNode::dispose is called.

We don't need the two flags; just one flag that is set in AudioContext::dispose() is enough.

This CL removes m_didCallDispose and m_isMarkedForDeletion and introduces m_isDisposeCalled. This CL doesn't change any behavior.

BUG=340522

Review URL: https://codereview.chromium.org/460303003

git-svn-id: svn://svn.chromium.org/blink/trunk@180330 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Revert of Add lextab.pyc as an output of the cached_lex_yacc_tables action (patchset #1 of https://codereview.chromium.org/463063003/)

Reason for revert:
This CL added the assumption that Python will write the lextab.pyc file. If that's a wrong assumption, which seems to be the case in some situations, the result is that the cached_lex_yacc_tables target never becomes clean, which in turn means that all IDL files are recompiled on each build.

The problem fixed by this CL was cosmetic only, so is not worth the risk.

Original issue's description:
> Add lextab.pyc as an output of the cached_lex_yacc_tables action
> 
> The primary output is lextab.py, but since it is imported, Python also
> writes lextab.pyc. Listing it too as an output means it won't be left
> around by "ninja -t clean" (and not much else, I think.)
> 
> Prior to the patch
>   https://codereview.chromium.org/425953002/
> the result of not having lextab.pyc listed as an output and running
> "ninja -t clean" was a tree that would build correctly, but that would
> always rerun all the IDL code generation scripts, and thus never become
> "clean".
> 
> BUG=397909
> 
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180142

TBR=haraken@chromium.org,nbarth@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=397909

Review URL: https://codereview.chromium.org/468743003

git-svn-id: svn://svn.chromium.org/blink/trunk@180329 bbb929c8-8fbe-4397-9dbb-9b2b20218538

In the CompositedLayerMapping's doPaintTask function we ASSERT that
we never get here if we paint into our composited ancestor (i.e., we
don't paint ourself). This doesn't make sense for the squashing layer.
Even if the layer that owns the backing happens to paint into its
ancestor, the squashed layers may well paint into the squashing layer.

BUG=394413

Review URL: https://codereview.chromium.org/476583002

git-svn-id: svn://svn.chromium.org/blink/trunk@180328 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The patch https://codereview.chromium.org/415613002 unintentionally
made unprefixed transitions depend on the animations unprefixed
flag as it made us exit out of prefixingVariantForPropertyId when
the flag was off.

BUG=404001

Review URL: https://codereview.chromium.org/478523003

git-svn-id: svn://svn.chromium.org/blink/trunk@180327 bbb929c8-8fbe-4397-9dbb-9b2b20218538

If we fire internalAbort() after handleRequestError(), a new request
initiated by the event handler reusing the same XHR instance will be
aborted.

BUG=402855

Review URL: https://codereview.chromium.org/462053002

git-svn-id: svn://svn.chromium.org/blink/trunk@180326 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The function CSSParserValue::createCSSValue is only actually used by
calc parsing, although we can more easily do the same thing there in
much less code.

BUG=404023

Review URL: https://codereview.chromium.org/470903003

git-svn-id: svn://svn.chromium.org/blink/trunk@180325 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This is patch 1 of 6 in the roll.

TBR=phoglund@chromium.org
NOTRY=1
BUG=404022

Review URL: https://codereview.chromium.org/475313002

git-svn-id: svn://svn.chromium.org/blink/trunk@180324 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The indirection of parseWebkitTransformOrigin only adds complexity.

BUG=404023

Review URL: https://codereview.chromium.org/474873002

git-svn-id: svn://svn.chromium.org/blink/trunk@180323 bbb929c8-8fbe-4397-9dbb-9b2b20218538

When we resolve style for an element with an explicit font size, we build a new
FontDescription but we inherit the text autosizing multiplier from the parent's
RenderStyle (see http://crbug.com/380903).

We need to respect this multiplier when we initialize the computed size in the
FontDescription, or else they are out of sync with each other.  They remain out
of sync even after we layout the element, because TextAutosizer sees that the
element already has the correct multiplier and doesn't touch it.

BUG=403132

Review URL: https://codereview.chromium.org/472893004

git-svn-id: svn://svn.chromium.org/blink/trunk@180322 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch fixes a bug that frame's load event does not fire when
FontLoader::loadPendingFonts does not start any load because all the
pending fonts are already started loading. This happens when a webfont
is used in multiple iframes; only one of them actually starts the load.

After this patch, if a font is used in multiple frames, subsequent
frames do not schedule a load (hence do not block the load event).

BUG=401846
TEST=fast/css/font-face-iframe-onload.html

Review URL: https://codereview.chromium.org/457273002

git-svn-id: svn://svn.chromium.org/blink/trunk@180321 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=402536,352134

Review URL: https://codereview.chromium.org/477593002

git-svn-id: svn://svn.chromium.org/blink/trunk@180319 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Navigation transitions: Hide transition elements by setting opacity: 0 rather than display: none, to not shift other elements around.

Also removed a redundant parameter from Internals::serializeNavigationMarkup.

R=abarth
BUG=370696

Review URL: https://codereview.chromium.org/476553002

git-svn-id: svn://svn.chromium.org/blink/trunk@180318 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This enables ServiceWorkerRegistration interface and updates layout tests
to work with it.

NOTE: ServiceWorker feature is still behind a flag, so this doesn't break
any real web applications.

[Spec] https://slightlyoff.github.io/ServiceWorker/spec/service_worker/index.html#service-worker-registration-obj


BUG=396400
TEST=run_webkit_tests.py --debug http/tests/serviceworker

Review URL: https://codereview.chromium.org/466723002

git-svn-id: svn://svn.chromium.org/blink/trunk@180317 bbb929c8-8fbe-4397-9dbb-9b2b20218538

We need to add "platform" to public/web/DEPS in order to include
platform/text/TextDirection.h in WebTextDirection.h.
This change should have no problems because we already have "core"
dependency, and "core" depends on "platform."

TEST=none; no behavior changes.
BUG=

Review URL: https://codereview.chromium.org/470883002

git-svn-id: svn://svn.chromium.org/blink/trunk@180316 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This reverts commit 51fe8a513278ca949b5848bce3495f69a67072e2.

Reason for revert:
Broke iframe repainting: https://code.google.com/p/chromium/issues/detail?id=403734.

Original issue's description:
> Re-land of: Allow paint invalidation containers to cross frame boundaries.
>
> The previous version had an infinite loop bug in RenderObject when there are two nested frames.
>
> Previously, the *actual* paint invalidation container, meaning the enclosing
> compositing layer / root RenderView, could already have been across a frame boundary. The logic to do this correctly was done via special code in RenderView.
>
> Instead, generalize the existing mechanisms to find a paint invalidation container
> and map rects to repaint container coordinate space to cross frame boundaries.
> This simplifies the code, and also causes paint invalidation rects to always be stored
> in the coordinate space of their graphics layer backing. The latter is important if we want
> to use these rects for determining which parts of a graphics layer need to be painted.
>
> BUG=401156
>
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=179858

TBR=chrishtr@chromium.org
NOTREECHECKS=true
BUG=401156

Review URL: https://codereview.chromium.org/473093002

git-svn-id: svn://svn.chromium.org/blink/trunk@180315 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Adds a category to ct-failure-group and enables ct-failure-stream to filter
to a single category.

Ports the previously broken ct-failure-stream-tests to mocha in order to
add new tests.

NOTRY=true
BUG=400397,399967, 400387

Review URL: https://codereview.chromium.org/455263002

git-svn-id: svn://svn.chromium.org/blink/trunk@180314 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=180305

TBR=eae@chromium.org

Review URL: https://codereview.chromium.org/464403004

git-svn-id: svn://svn.chromium.org/blink/trunk@180313 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Use label="" instead of the textContent

R=ojan@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/469423005

git-svn-id: svn://svn.chromium.org/blink/trunk@180312 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The file handler was getting confused when we would upload a full_results.json
that contained a "results" key that pointed to a trie of tests.

Also fix some file permissions issues that the presubmit check complained about.

R=ojan@chromium.org
BUG=403663
NOTRY=true

Review URL: https://codereview.chromium.org/475503005

git-svn-id: svn://svn.chromium.org/blink/trunk@180310 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This CL fixes a bug that non-composited scrolling div forgets to invalidate
because the div believed all its descandants are composited, when actually
some descendants paints to ancestor backing although composited.

BUG=401047

Review URL: https://codereview.chromium.org/460883002

git-svn-id: svn://svn.chromium.org/blink/trunk@180309 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=403987
TBR=kouhei@chromium.org

Review URL: https://codereview.chromium.org/472193002

git-svn-id: svn://svn.chromium.org/blink/trunk@180308 bbb929c8-8fbe-4397-9dbb-9b2b20218538

R=jamesr@chromium.org
BUG=354261

Review URL: https://codereview.chromium.org/473043002

git-svn-id: svn://svn.chromium.org/blink/trunk@180307 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Remove in-class platform ifdefs from platform/fonts/FontPlatformData.h
as the entire file is wrapped in a OS(MACOSX) macro.

R=leviw@chromium.org, pdr@chromium.org

Review URL: https://codereview.chromium.org/471693002

git-svn-id: svn://svn.chromium.org/blink/trunk@180306 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Implement support for the CSS font-stretch property on platforms using
SkFontMgr. This allows the width/stretch of a given font to be specified
and matches the IE and Firefox implementations.

Currently SkFontMgr is only used on Windows however as other platforms
migrate to SkFontMgr they'll get this support for free.

Entry in Chromium Dashboard:
  http://www.chromestatus.com/admin/features/edit/4598830058176512

Intent to Implement and Ship:
  https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/N24I2zJemvI/ZClPu585uAsJ
  
TEST=fast/text/font-stretch.html
BUG=331119
R=dglazkov@chromium.org

Review URL: https://codereview.chromium.org/476943003

git-svn-id: svn://svn.chromium.org/blink/trunk@180305 bbb929c8-8fbe-4397-9dbb-9b2b20218538

R=abarth
BUG=

Review URL: https://codereview.chromium.org/472943002

git-svn-id: svn://svn.chromium.org/blink/trunk@180303 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Now also timing out on Mac/Debug, and it's consistently timing out,
not flakily.

BUG=356957
TBR=mkwst@chromium.org

Review URL: https://codereview.chromium.org/476843004

git-svn-id: svn://svn.chromium.org/blink/trunk@180301 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Fix some leftovers after the WebCore -> blink namespace changes.

NOTRY=true

Review URL: https://codereview.chromium.org/477743003

git-svn-id: svn://svn.chromium.org/blink/trunk@180300 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Use new match Functor ElementTraversal API in  DOMSiblingTraversalStrategy to
simplify the code a bit.

R=adamk@chromium.org, esprehn@chromium.org

Review URL: https://codereview.chromium.org/475023002

git-svn-id: svn://svn.chromium.org/blink/trunk@180299 bbb929c8-8fbe-4397-9dbb-9b2b20218538