GitLab

QUIC HTTP stream, by centralizing the logic into a single method.

Review-Url: https://codereview.chromium.org/2777333002
Cr-Commit-Position: refs/heads/master@{#460590}

With new fromSurface parameter, this should work on all OSes.

BUG=638281

Review-Url: https://codereview.chromium.org/2773173002
Cr-Commit-Position: refs/heads/master@{#460589}

Review-Url: https://codereview.chromium.org/2782953002
Cr-Commit-Position: refs/heads/master@{#460588}

BUG=706486

Review-Url: https://codereview.chromium.org/2779363002
Cr-Commit-Position: refs/heads/master@{#460587}

Update min engagement_threshold_for_flash to 8, to match the external experiment for HTML5ByDefault.

BUG=706532

Review-Url: https://codereview.chromium.org/2772343008
Cr-Commit-Position: refs/heads/master@{#460586}

The logic was accidentally double-counting the size of a memory region, causing
some memory regions to get skipped.

BUG=706547

Review-Url: https://codereview.chromium.org/2786733004
Cr-Commit-Position: refs/heads/master@{#460585}

Interpret throw(undefined) to mean that an error of any type is
expected.  This is the same as throw().

BUG=706558
TEST=audit.html

Review-Url: https://codereview.chromium.org/2783033002
Cr-Commit-Position: refs/heads/master@{#460584}

ARC++ allows Android app to run on Chrome OS. It is necessary to change
the behavior of Chrome on CrOS on handling apk and dex files. This CL
prevents auto download apk and dex file on CrOS and also disallow auto
open such files.

BUG=694872

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2778283003
Cr-Commit-Position: refs/heads/master@{#460583}

Make network quality estimator (NQE) params a class.

Next CL will move the storing of the params to the Params class
from the NQE class to make it simpler to query the params again and
again. This CL does not make any functional change.

BUG=705691
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester

Review-Url: https://codereview.chromium.org/2775223004
Cr-Commit-Position: refs/heads/master@{#460582}

This allows PlzNavigate to only pause fetching the request if it knows that the page has an onbeforeunload handler, where today it currently always goes to the renderer. This avoids delaying the network requests in the 95% cases that don't onbeforeunload handler on a process hop to the renderer.

BUG=365039,705559
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
R=dcheng@chromium.org, nasko@chromium.org

Review-Url: https://codereview.chromium.org/2783723002 .
Cr-Commit-Position: refs/heads/master@{#460581}

Bug: internal b/36447710
Change-Id: I5db3d8203d7c7369a48bff45cbaf582a673c57b6
Review-Url: https://codereview.chromium.org/2786723002
Cr-Commit-Position: refs/heads/master@{#460580}

BUG=697921

Review-Url: https://codereview.chromium.org/2782303002
Cr-Commit-Position: refs/heads/master@{#460579}

BUG=

Review-Url: https://codereview.chromium.org/2779973005
Cr-Commit-Position: refs/heads/master@{#460578}

Currently CompositorResizeLock doesn't work unless deferred since the
base class tries to use a virtual method from its constructor which
doesn't know about the subclass yet.

This fixes that and makes the following changes in the process:

I noticed that there are no longer any unit tests that depend on
ResizeLock being an interface. So I made CompositorResizeLock the
concrete type.

I noticed that CompositorResizeLock was in located in files named
compositor_resize_lock_aura.{h,cc} but is not named for aura anymore,
and is in fact used in non-aura cases for mac. So I renamed the files,
and moved the aura pieces out to DelegatedFrameHostClientAura.

In order for DelegatedFrameHostClientAura to know when to release
events however, it needs to know when the resize lock ends. So I
introduced CompositorResizeLockClient, which tells when the lock is
over.

Importantly, the above is not the same as the CompositorLock ending.
That can be done by calling CompositorResizeLock::UnlockCompositor,
which does not end the resize lock, but does release the
CompositorLock inside it. So this doesn't inform the client at
that time until the resize lock actually ends. I've tried to make
this more clear with function names and comments.

In order to unit test everything I've pulled CompositorLock out
of compositor.h and removed the friend relationships between
Compositor and CompositorLock. To do so CompositorLock now has 2
interfaces:
- CompositorLockClient which it informs about timeouts. This is
so that CompositorResizeLock knows when its internal
CompositorLock is released by timeout.
- CompositorLockDelegate which performs actual unlocking. This is
the ui::Compositor outside of tests.

Lastly, CompositorResizeLock has a timeout, and CompositorLock has
a timeout. These happen to be the same number tho
CompositorResizeLock allows you to override it. I've combined these
into a single timeout (with the help of CompositorLockClient). And
will allow GetCompositorLock to request a specific timeout. With
that, Compositor no longer needs SetLocksWillTimeOut which has some
action-at-distance properties. This maintains the property that the
first to grab a lock chooses the timeout for all other locks grabbed
during that time, however Mac code which wants no timeouts now
doesn't cause other parts of the system to also get no timeout unless
the mac lock is currently active without a timeout.

R=piman@chromium.org
BUG=704928
NOTRY=true

Review-Url: https://codereview.chromium.org/2773433003
Cr-Commit-Position: refs/heads/master@{#460577}

This new API is similar to IsSupportedVideoConfig and is strictly-typed
unlike the old MediaCodecSupportShlib::IsSupported, which is going to
be deprecated.

Review-Url: https://codereview.chromium.org/2677143003
Cr-Commit-Position: refs/heads/master@{#460576}

Manually converted these tests to use new Audit from old Audit.

BUG=704967
TEST=Analyser/realtimeanalyser-byte-data.html
Analyser/realtimeanalyser-downmix.html
Analyser/realtimeanalyser-fftsize-reset.html
Analyser/realtimeanalyser-float-data.html
Analyser/realtimeanalyser-freq-data.html
Analyser/realtimeanalyser-freq-data-smoothing.html
Analyser/realtimeanalyser-multiple-calls.html
Analyser/realtimeanalyser-zero.html

Review-Url: https://codereview.chromium.org/2777983002
Cr-Commit-Position: refs/heads/master@{#460575}

Before this change, selecting "Close all incognito windows"
while Chrome was showing "You're leaving incognito mode"
warning dialog will cause a crash.

After this change, the crash is avoided.

BUG=705844

Review-Url: https://codereview.chromium.org/2778193003
Cr-Commit-Position: refs/heads/master@{#460574}

https://crbug.com/2697213002 (not guessing UTF8 encoding)
doesn't have to be applied to local file resources. This
CL makes such cases an exception to the policy.

BUG=704800

Review-Url: https://codereview.chromium.org/2784483003
Cr-Commit-Position: refs/heads/master@{#460573}

The id path inside SelectorQuery::findTraverseRootsAndExecute is not actually
reachable for the right most selector since we handle that separately inside
the top level ::execute() call. We also only ever take the fast path when
rootNode.isConnected() (as checked by canUseFastPath) so we can use that too.

By using these two truths inside this code we can simplify what it was doing
and delete a bunch of the code.

BUG=703900

Review-Url: https://codereview.chromium.org/2786763002
Cr-Commit-Position: refs/heads/master@{#460572}

This is caused by racing between mojo and non-mojo code path.
The avater image is updated via SessionController mojo interface
but UserObserver interface is still a direct call and could reach
ash before the mojo message. The CL fixes the issue by replacing
UserObserver interface with SessionController observer.

BUG=704862

Review-Url: https://codereview.chromium.org/2780963002
Cr-Commit-Position: refs/heads/master@{#460571}

https://skia.googlesource.com/skia.git/+log/4a24e10a0b80..291932e8e42e

$ git log 4a24e10a0..291932e8e --date=short --no-merges --format='%ad %ae %s'
2017-03-29 jvanverth Fix is_convex() check for inset polys.
2017-03-29 bsalomon Make analysis optional to GrPipeline::init().
2017-03-28 egdaniel Remove blacklist of Vulkan GPUMemoryTest
2017-03-29 robertphillips More GrSurfaceProxy-clean up
2017-03-29 bungeman Use FontWeight symbols when available on Mac.
2017-03-29 robertphillips Miscellaneous GrSurfaceProxy-related cleanup
2017-03-29 bsalomon Remove GrPipelineOptimizations computation from GrPipeline::init and nest in GrMeshDrawOp.

Created with:
  roll-dep src/third_party/skia


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=stephana@chromium.org

Change-Id: I31fc6a3812796d42b876424a56f6bc60ff95d892
Reviewed-on: https://chromium-review.googlesource.com/462516Reviewed-by: Skia Deps Roller <skia-deps-roller@chromium.org>
Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#460570}

This CL makes Settings specific changes to the 'Network' (was 'Internet
conneciton') section.

See issue for specs and screenshots.

BUG=701945
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2752223003
Cr-Commit-Position: refs/heads/master@{#460569}

BUG=705510
R=baxley@chromium.org

Review-Url: https://codereview.chromium.org/2782023002 .
Cr-Commit-Position: refs/heads/master@{#460568}

This reverts commit 54548ddb.

Reason for revert:
Likely to have caused a significant regression in net_unittests cycle time, which is producing a long pending queue on ios-simulator, which in turn is blocking the entire commit queue.

BUG=706609
TBR=baxley

Review-Url: https://codereview.chromium.org/2779213004 .
Cr-Commit-Position: refs/heads/master@{#460567}

Create a separate sequence number for GLImages created from
CVPixelBufferRefs (previously they had no sequence number, so they
would alias each other).

Make VTVideoDecodeAccelerator be a dump provider. This dumps through
the GLImage interface, and so it will correctly link the
CVPixelBufferRefs that with the command buffer textures.

Fix TextureManager's dump code to not assume that GLImage presence
and texture state BOUND are related (a texture can have a GLImage but
not be BOUND because it can't be textured out of directly).

BUG=704792
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2771923006
Cr-Commit-Position: refs/heads/master@{#460566}

In this patch, remove right stroke for vertical scrollbar, remove
bottom stroke for horizontal scrollbar and flip the scrollbar canvas to
remove left stroke for left vertical scrollbar.

BUG=669673

Review-Url: https://codereview.chromium.org/2763373002
Cr-Commit-Position: refs/heads/master@{#460565}

The extensions/common/extension_utility_messages.h message
file was deleted in http://crrev.com/460280

Its corresponding IPC START entry ExtensionUtilityMsgStart
is not needed either, so we can remove it.

BUG=691410

Review-Url: https://codereview.chromium.org/2785463003
Cr-Commit-Position: refs/heads/master@{#460564}

This code was broken in M52, but nobody has complained, so remove it.

Pause-To-Buffer is a consistent source of surprise, and mistakes leading
to accidental bandwidth consumption. The new download button is a much
better interface (at least in cases where it appears).

Review-Url: https://codereview.chromium.org/2689323002
Cr-Commit-Position: refs/heads/master@{#460563}

Removing TODOs, which are obsolete or which make no sense to act upon
at this point in time.

BUG=685523
R=chili@chromium.org

Review-Url: https://codereview.chromium.org/2782673002
Cr-Commit-Position: refs/heads/master@{#460562}

I had to do a bit of research today to remember the difference between
subtle events like GestureTapDown/GestureShowPress, and
GestureLongPress/GestureLongTap.  Add some comments to clarify the
distinctions for the future.

BUG=

Review-Url: https://codereview.chromium.org/2778853005
Cr-Commit-Position: refs/heads/master@{#460561}

TBR=melandory@chromium.org

BUG=706543

Review-Url: https://codereview.chromium.org/2781083004
Cr-Commit-Position: refs/heads/master@{#460560}

If pending item exists and pending index == -1, then last committed item is
always the last one and forward navigation is not possible anyway.

BUG=661858

Review-Url: https://codereview.chromium.org/2775893003
Cr-Commit-Position: refs/heads/master@{#460559}

Since focus changes are reported late in the Android lifecycle, we can end up in a situation where we send vrdisplayactivate, but no webVR frames are considered focused yet.

This change makes it so that even if no webVR frame is currently focused, we still send displayactivate to the most recently focused frame (which has the added benefit of ensuring only one frame can call requestPresent in response). This is safe because we only fire displayactivate at all if we are sure some frame was listening for displayactivate before the Android VR DON flow paused chrome and unfocused the frame.

In the future we should track focus fully browser-side to more securely solve this issue.

This CL also prevents a possible reconnect loop if the page mistakenly thinks it has focus when it doesn't by detecting repeated connection failures.

BUG=706472

Review-Url: https://codereview.chromium.org/2783993002
Cr-Commit-Position: refs/heads/master@{#460558}

https://chromium.googlesource.com/native_client/src/native_client.git/+log/c84029060e2a..b1766362259d

$ git log c84029060..b17663622 --date=short --no-merges --format='%ad %ae %s'
2017-03-28 sbc Add newlines to NaClLog messages

Created with:
  roll-dep src/native_client

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_dbg_32_ng,linux_nacl_sdk_build
TBR=mseaborn@chromium.org

Review-Url: https://codereview.chromium.org/2785623002
Cr-Commit-Position: refs/heads/master@{#460557}

Revert of Bug Fix: Data Race For WebMediaPlayerMS' Frame Count Variable (patchset #3 id:60001 of https://codereview.chromium.org/2751353003/ )

Reason for revert:
Lock contention, increase chrome_public_test_apk run time a lot.

We might need a finer lock.

Original issue's description:
> Bug Fix: Data Race For WebMediaPlayerMS' Frame Count Variable
>
> On thread sanitizer, we found a data race issue for WebMediaPlayerMS' frame
> count variables |total_frame_count_| and |dropped_frame_count_|. In this CL
> We make those two variables atomic.
>
> BUG=701712
>
> Review-Url: https://codereview.chromium.org/2751353003
> Cr-Commit-Position: refs/heads/master@{#457786}
> Committed: https://chromium.googlesource.com/chromium/src/+/4cb6dcab2e3d9b4f14ff3bd5dc8f3fd3a57e19e5

TBR=dalecurtis@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=701712

Review-Url: https://codereview.chromium.org/2777183009
Cr-Commit-Position: refs/heads/master@{#460556}

We moved mojo_media_host to browser process when CMA backend is
enabled. The gn dependency //media/mojo/services is missing from
//media/gpu.

BUG=None
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2786473003
Cr-Commit-Position: refs/heads/master@{#460555}

BottomSheetTests have a hard dependency on RecyclerView,
which is a class that was added in SDK level 22 (Lollipop
MR 1).
This change disables BottomSheetTests on all API levels
which do not have RecyclerView.

BUG=None

Review-Url: https://codereview.chromium.org/2781093004
Cr-Commit-Position: refs/heads/master@{#460554}

The style now roughly matches the new MD settings page, but without all
of the fancy MD effects.

BUG=none
TEST=Tried setting all ChromeVox options, navigating via Tab and via ChromeVox forward. Also tested in Classic mode (Compat).
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2776293002
Cr-Commit-Position: refs/heads/master@{#460553}

The test is always failing and it's a ref test, so move it to
a common block to make triage easier.

TBR=junov@chromium.org
BUG=627844

Review-Url: https://codereview.chromium.org/2787643002
Cr-Commit-Position: refs/heads/master@{#460552}

TouchAccessibilityBrowserTest.TouchExplorationInCrossSiteIframe sends
a touch event to a cross-origin iframe. When OOPIFs are enabled, this
relies on the browser hit testing path for the event to reach the
correct RenderWidgetHostView. There is currently flakiness because
sometimes the browser process has not received enough compositor frames
for that hit testing to work.

This patch uses SurfaceHitTestReadyNotifier to delay the event until
hit testing will succeed.

BUG=706163

Review-Url: https://codereview.chromium.org/2785793002
Cr-Commit-Position: refs/heads/master@{#460551}