Commits · 4cc7bad91ea05773979249d6b92abe6eb2cebc60 · eriksson monteiro / tangled

11 Dec, 2016 21 commits

Add destructor to ReadingListStoreDelegate · 4cc7bad9

olivierrobin authored Dec 11, 2016

ReadingListStoreDelegate has virtual methods, so it should have a virtual
destructor.

BUG=673169

Review-Url: https://codereview.chromium.org/2565213002
Cr-Commit-Position: refs/heads/master@{#437801}

4cc7bad9

Fix crash when deleting ReadingListStore via ReadingListModelStorage*. · 39493e82

sdefresne authored Dec 11, 2016

ReadingListStore inherits from multiple classes, including from
ReadingListModelStorage that does not define a virtual destructor.

Since ReadingListModelImpl has a scoped_ptr to ReadingListModelStorage,
it calls the base destructor with a pointer that does not correspond
to memory returned by "new" (it points to somewhere inside the memory
block).

The issue can be fixed by defining a virtual destructor on the base
class ReadingListModelStorage (as all class with virtual method should
do). Also mark the class a non-copyable since copying would cause slicing.

BUG=673169

Review-Url: https://codereview.chromium.org/2563303002
Cr-Commit-Position: refs/heads/master@{#437800}

39493e82

Revert of Enable RL by default (patchset #6 id:100001 of... · 0d282c20

sdefresne authored Dec 11, 2016

Revert of Enable RL by default (patchset #6 id:100001 of https://codereview.chromium.org/2562643003/ )

Reason for revert:
Speculative revert as I think this CL broke the downstream autoroller.

It is a bit hard to debug as the autoroller was unable to land some CL as the downstream tree was closed, but the last successful roll would have happened at 39e086ae [1], and the first failing roll is at a229e828 [2].

This CL is the only one having an impact on the iOS build, so I think it is causing the failures:

$ git log --oneline 39e086ae...a229e828
a229e828 Strength-reduce the "scale-factor changed" condition in LayoutSVGRoot
d1693364 Update V8 to version 5.7.202.
7cfbed3d Enable RL by default
314c528d Revert of Improve EAT_STREAM_PARAMETERS for Windows x86 (patchset #10 id:240001 of https://codereview.chromium.org/2559323007/ )

[1]: https://uberchromegw.corp.google.com/i/internal.bling.main/builders/trunk-autoroller/builds/6861
[2]: https://uberchromegw.corp.google.com/i/internal.bling.main/builders/trunk-autoroller/builds/6862

Original issue's description:
> Enable RL by default
>
> BUG=577659
>
> Review-Url: https://codereview.chromium.org/2562643003

TBR=noyau@chromium.org,mardini@chromium.org,olivierrobin@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=577659
NOTRY=true

Review-Url: https://codereview.chromium.org/2564293002
Cr-Commit-Position: refs/heads/master@{#437799}

0d282c20

Establish a list marker's offset before floats have been added to its line · c896e79e

robhogan authored Dec 11, 2016

Computing the offset for a list marker after the rest of the objects on the line
it is on have been laid out means it will avoid floats it ought not to.

Instead, compute the offset when laying out the marker and cache it for use later.

BUG=548616
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2553793003
Cr-Commit-Position: refs/heads/master@{#437798}

c896e79e

Ensure that selected video format is valid when resolving video-capture constraints. · 73ac3ff0
guidou authored Dec 11, 2016
```
BUG=671181

Review-Url: https://codereview.chromium.org/2559223002
Cr-Commit-Position: refs/heads/master@{#437797}
```
73ac3ff0

Enable generation of PkgInfo for all application on iOS. · e144b853

sdefresne authored Dec 11, 2016

BUG=672516

Review-Url: https://codereview.chromium.org/2567483003
Cr-Commit-Position: refs/heads/master@{#437796}

e144b853

exo: Avoid crash at startup when XDG_RUNTIME_DIR is not set. · 45971325

reveman authored Dec 11, 2016

Without this check we'd crash when creating the watcher and
asking for the server file descriptor from a null server instance.

TBR=sky@chromium.org
BUG=
TEST=chrome --enable-wayland-server (without XDG_RUNTIME_DIR set)

Review-Url: https://codereview.chromium.org/2569633002
Cr-Commit-Position: refs/heads/master@{#437795}

45971325

Face Detection: Use DetectedFace in FaceDetector.cpp iso DOMRect · f1f5959f

mcasas authored Dec 11, 2016

FaceDetector.detect() in ToT returns a sequence<DetectedObject>,
but DetectedObject doesn't exist, and it should return DetectedFace
instead according to the Spec. Also, DetectedFace is not used at the
moment (FaceDetector  goes around this issue by returning DOMRects
directly).

This CL sorts that out by returning DetectedFaces directly.

BUG=673075

Review-Url: https://codereview.chromium.org/2564123003
Cr-Commit-Position: refs/heads/master@{#437794}

f1f5959f

exo: Avoid creating GLContext in motion event client unless needed. · 3268c758

reveman authored Dec 11, 2016

Always creating a GL context is currently preventing this client
from being used when GL is not available.

BUG=
TEST=wayland_motion_events (without GL)

Review-Url: https://codereview.chromium.org/2566863002
Cr-Commit-Position: refs/heads/master@{#437793}

3268c758

exo: Fix motion events client dtor order. · f19968ed

reveman authored Dec 11, 2016

Globals need to be destroyed before the wl_display.

BUG=
TEST=wayland_motion_events --use-drm
TBR=dcastagna@chromium.org

Review-Url: https://codereview.chromium.org/2568703002
Cr-Commit-Position: refs/heads/master@{#437792}

f19968ed

Use ios_packed_resources_target to depend on packed resources. · 4032922c

sdefresne authored Dec 11, 2016

Use ios_packed_resources_target as a dependency of //ios/chrome/app
target to select the correct packed resource target.

BUG=653086

Review-Url: https://codereview.chromium.org/2558913005
Cr-Commit-Position: refs/heads/master@{#437791}

4032922c

Remove duplicated user_prefs::TestingPrefServiceSyncable · b2cf8f80

a-v-y authored Dec 11, 2016

In https://codereview.chromium.org/2479113002/ it was discovered that
current codebase has two duplicate TestingPrefServiceSyncable classes.
One in component/sync_preferences and another in
components/pref_registry. The decision from discussion is to delete the
one in components/pref_registry.

BUG=672900

R=gab@chromium.org, vasilii@chromium.org, hashimoto@chromium.org, pkasting@chromium.org, rdevlin.cronin@chromium.org, ben@chromium.org, blundell@chromium.org

TBR=rdevlin.cronin@chromium.org, ben@chromium.org, blundell@chromium.org

Review-Url: https://codereview.chromium.org/2562733003
Cr-Commit-Position: refs/heads/master@{#437790}

b2cf8f80

Roll //third_party/typ to v0.9.9 · d0972641

dpranke authored Dec 11, 2016

This rolls //third_party/typ to v0.9.9 to pick up dglazkov's patch
to allow "foreign arguments" to typ. A foreign argument is one
that the typ arg parser ignores.

This roll includes:

  d77f1a5 bump version to 0.9.9
  69c6119 Merge pull request #7 from dglazkov/foreign-argument
  0a2f193 fix indentation
  c8845b2 Introduce the concept of a foreign argument.

R=dglazkov@chromium.org

Review-Url: https://codereview.chromium.org/2568683002
Cr-Commit-Position: refs/heads/master@{#437789}

d0972641

Roll third_party/icu from dda089a to 73e2473 · 64a8d3b5

jshin authored Dec 11, 2016

http://chromium.googlesource.com/chromium/deps/icu.git/+log/dda089a..73e2473

Two changes are in the range:

1. Timezone update to 2016i
2. Bign Endian support for MIPS

BUG=473288
TBR=mark@chromium.org
TEST=Try the following in d8 or Chrome's JS console:
> (new Date("12/04/2016 12:00Z")).toLocaleString("en", {timeZone:
"Europe/Saratov"})
"12/4/2016, 4:00:00 PM"
> (new Date("12/03/2016 12:00Z")).toLocaleString("en", {timeZone:
"Europe/Saratov"})
"12/3/2016, 3:00:00 PM"

Review-Url: https://codereview.chromium.org/2557743010
Cr-Commit-Position: refs/heads/master@{#437788}

64a8d3b5

Avoid reentrancy in QuicHttpStream::HasSendHeadersComplete. · b2e34cfa

rch authored Dec 11, 2016

BUG=641020

Review-Url: https://codereview.chromium.org/2557403005
Cr-Commit-Position: refs/heads/master@{#437787}

b2e34cfa

Updating trunk VERSION from 2948.0 to 2949.0 · f10b6162
chrome-cron authored Dec 11, 2016
```
Cr-Commit-Position: refs/heads/master@{#437786}
```
f10b6162

[WebAPKs] Compute the default scope from the manifest start URL. · cf064891

pkotwicz authored Dec 10, 2016

This CL changes how the scope is computed if the scope is unspecified in the
Android Manifest.
We used to compute the default scope based on the "URL the WebAPK navigates to
when launched." Deep links can open a WebAPK at an arbirtrary URL.
This CL changes the computation to be based on the Web Manifest start URL.

This change enables cleaning up
ManifestUpgradeDetectorFetcher#onDataAvailable(). We can now create the fetched
WebApkInfo using the current WebAPK's WebApkInfo#uri().

BUG=639536

Review-Url: https://codereview.chromium.org/2548333006
Cr-Commit-Position: refs/heads/master@{#437785}

cf064891

Remove the enable_themes build flag and define. · 9b0866fd

brettw authored Dec 10, 2016

This is always defined on non-mobile platforms and it is not possible to
override in the build. Since //chrome is no longer build on iOS, most uses
can be easily keyed off of the Android defines. For files not compiled on
Android, the conditionals were removed altogether.

This change additionally coalesces some Android blocks in
chrome/browser/BUILD.gn and chrome/browser/ui/BUILD.gn

BUG=671706

Review-Url: https://codereview.chromium.org/2561013002
Cr-Commit-Position: refs/heads/master@{#437784}

9b0866fd

exo: Improve motion event synchronization. · f9ac10db

reveman authored Dec 10, 2016

This improves the synchronization by deferring the client side
wait until commit time.

BUG=
TEST=wayland_motion_events

Review-Url: https://codereview.chromium.org/2563263002
Cr-Commit-Position: refs/heads/master@{#437783}

f9ac10db

exo: Fix handling of pending damage. · b266b259

reveman authored Dec 10, 2016

Pending damage was ignored prior to this change. Full damage should
be used in lost context situations and client provided damage for
normal commit.

BUG=673134
TEST=wayland_motion_events

Review-Url: https://codereview.chromium.org/2565973002
Cr-Commit-Position: refs/heads/master@{#437782}

b266b259

exo: Send damage to compositor when committing new buffer. · 211f7ed0

reveman authored Dec 10, 2016

BUG=
TEST=wayland_motion_events

Review-Url: https://codereview.chromium.org/2569613002
Cr-Commit-Position: refs/heads/master@{#437781}

211f7ed0

10 Dec, 2016 19 commits

Moved exo::SurfaceFactoryOwner to its own file and renamed it to exo::CompositorFrameSink. · d8f4f642

staraz authored Dec 10, 2016

CompositorFrameSink implements cc::mojom::MojoCompositorFrameSink.

CompositorFrameSink is no longer a friend class of exo::Surface.

Added exo::CompositorFrameSinkHolder class that implements cc::mojom::MojoCompositorFrameSinkClient.

BUG=659601
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2493223002
Review-Url: https://codereview.chromium.org/2493223002
Cr-Commit-Position: refs/heads/master@{#437780}

d8f4f642

Handle storyboards in GN. · 39fe426a

lpromero authored Dec 10, 2016

BUG=none
R=sdefresne@chromium.org,rohitrao@chromium.org

Review-Url: https://codereview.chromium.org/2564023002
Cr-Commit-Position: refs/heads/master@{#437779}

39fe426a

[sensors](CrOS/Linux) Rename SensorDeviceManager cc and h files. · fac225ce

maksim.sisov authored Dec 10, 2016

It is a followup patch to https://codereview.chromium.org/2533793002/
In addition to renaming this CL fixes a typo in code where sensor
cache in erased.

BUG=606766

Review-Url: https://codereview.chromium.org/2560263002
Cr-Commit-Position: refs/heads/master@{#437778}

fac225ce

Improve EAT_STREAM_PARAMETERS for Windows x86 · 3c957a58

scottmg authored Dec 10, 2016

Dumps of check_example.exe

Current:

?DoBlinkReleaseAssert@@YAX_N@Z:
  00404EDC: 55                 push        ebp
  00404EDD: 8B EC              mov         ebp,esp
  00404EDF: 80 7D 08 00        cmp         byte ptr [ebp+8],0
  00404EE3: 75 07              jne         00404EEC
  00404EE5: C6 05 00 00 00 00  mov         byte ptr ds:[0],0
            00
  00404EEC: 5D                 pop         ebp
  00404EED: C3                 ret
?DoCheck@@YAX_N@Z:
  00404EEE: 55                 push        ebp
  00404EEF: 8B EC              mov         ebp,esp
  00404EF1: 51                 push        ecx
  00404EF2: 83 65 FC 00        and         dword ptr [ebp-4],0
  00404EF6: 80 7D 08 00        cmp         byte ptr [ebp+8],0
  00404EFA: 75 07              jne         00404F03
  00404EFC: C6 05 00 00 00 00  mov         byte ptr ds:[0],0
            00
  00404F03: 8B E5              mov         esp,ebp
  00404F05: 5D                 pop         ebp
  00404F06: C3                 ret
_main:
  00404F07: 55                 push        ebp
  00404F08: 8B EC              mov         ebp,esp
  00404F0A: 83 7D 08 02        cmp         dword ptr [ebp+8],2
  00404F0E: 53                 push        ebx
  00404F0F: 0F 9F C3           setg        bl
  00404F12: 53                 push        ebx
  00404F13: E8 D6 FF FF FF     call        ?DoCheck@@YAX_N@Z
  00404F18: 53                 push        ebx
  00404F19: E8 BE FF FF FF     call        ?DoBlinkReleaseAssert@@YAX_N@Z
  00404F1E: 59                 pop         ecx
  00404F1F: 59                 pop         ecx
  00404F20: 33 C0              xor         eax,eax
  00404F22: 5B                 pop         ebx
  00404F23: 5D                 pop         ebp
  00404F24: C3                 ret

After this CL:

?DoBlinkReleaseAssert@@YAX_N@Z:
  00404EAC: 55                 push        ebp
  00404EAD: 8B EC              mov         ebp,esp
  00404EAF: 80 7D 08 00        cmp         byte ptr [ebp+8],0
  00404EB3: 75 07              jne         00404EBC
  00404EB5: C6 05 00 00 00 00  mov         byte ptr ds:[0],0
            00
  00404EBC: 5D                 pop         ebp
  00404EBD: C3                 ret
_main:
  00404EBE: 55                 push        ebp
  00404EBF: 8B EC              mov         ebp,esp
  00404EC1: 83 7D 08 02        cmp         dword ptr [ebp+8],2
  00404EC5: 53                 push        ebx
  00404EC6: 0F 9F C3           setg        bl
  00404EC9: 53                 push        ebx
  00404ECA: E8 DD FF FF FF     call        ?DoBlinkReleaseAssert@@YAX_N@Z
  00404ECF: 53                 push        ebx
  00404ED0: E8 D7 FF FF FF     call        ?DoBlinkReleaseAssert@@YAX_N@Z
  00404ED5: 59                 pop         ecx
  00404ED6: 59                 pop         ecx
  00404ED7: 33 C0              xor         eax,eax
  00404ED9: 5B                 pop         ebx
  00404EDA: 5D                 pop         ebp
  00404EDB: C3                 ret

Amusingly, I was confused because I thought I was going crazy when
DoCheck wasn't showing up in the /disasm. But of course, it's because it
got COMDAT'd with the Blink one, as we want. :)

R=primiano@chromium.org
BUG=672699

Review-Url: https://codereview.chromium.org/2559323007
Review-Url: https://codereview.chromium.org/2559323007
Cr-Commit-Position: refs/heads/master@{#437777}

3c957a58

Build services as standalone executables · b8b2bfc8

rockot authored Dec 10, 2016

Cleans up a bunch of service manager details which exist to support
the currently untenable goal of dynamically loading service binaries
in a common host executable.

Changes services to instead build as standalone executables, and
teaches the service manager how to launch them.

BUG=642879

Review-Url: https://codereview.chromium.org/2557213002
Review-Url: https://codereview.chromium.org/2557213002
Cr-Commit-Position: refs/heads/master@{#437776}

b8b2bfc8

Enable PaintChunkerTest on windows debug build · acd32926

wangxianzhu authored Dec 10, 2016

BUG=629946
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2563683003
Cr-Commit-Position: refs/heads/master@{#437775}

acd32926

Add flags entry to enable Chrome OS component updates fature. · 22db7c93

kerrnel authored Dec 10, 2016

This adds an entry to about:flags so that users, and internal testers,
can opt into Chrome OS component updates before we roll them out to all
users.

This was originally landed in https://codereview.chromium.org/2544133002,
but reverted in https://codereview.chromium.org/2567773002
because one of the other flags did not work properly.

BUG=670421

Review-Url: https://codereview.chromium.org/2565043002
Cr-Commit-Position: refs/heads/master@{#437774}

22db7c93

Remove deprecated ExceptionState constructors. · 8ca234a6

dcheng authored Dec 10, 2016

BUG=673090

Review-Url: https://codereview.chromium.org/2566823002
Cr-Commit-Position: refs/heads/master@{#437773}

8ca234a6

[DevTools] Make SourceFrame.setEditable work. · 1baf153a

dgozman authored Dec 10, 2016

There were two bugs in readonly handling.

BUG=673074

Review-Url: https://codereview.chromium.org/2567633003
Cr-Commit-Position: refs/heads/master@{#437772}

1baf153a

gpu: Move ShaderDiskCache into //gpu/ipc/host component. · 4a4522e8

sadrul authored Dec 10, 2016

BUG=643746, 604369
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2555693005
Cr-Commit-Position: refs/heads/master@{#437771}

4a4522e8

Import wpt@3ba5d5327015d8555070c2f2fc794249d58b5b93 · 34f78aa3

blink-w3c-test-autoroller authored Dec 10, 2016

Using update-w3c-deps in Chromium a229e828.

Build: https://build.chromium.org/p/chromium.infra.cron/builders/w3c-test-autoroller/builds/7824

TBR=qyearsley@chromium.org
NOEXPORT=true

Review-Url: https://codereview.chromium.org/2565143003
Cr-Commit-Position: refs/heads/master@{#437770}

34f78aa3

Performance optimizations for base/numerics absolute value and multiply · ba3c4f94

jschuh authored Dec 10, 2016

Removes a number of branches from the calculations. Also now exporting
SafeUnsignedAbs as a public API.

NOTRY=true

Review-Url: https://codereview.chromium.org/2566733002
Cr-Commit-Position: refs/heads/master@{#437769}

ba3c4f94

Remove using "newline" hacks from V8 binding templates · 01537d2e

peria authored Dec 10, 2016

Now we have format_blink_cpp_source_code filter, and continuous
new lines are merged.  So we don't need such hacks to avoid
duplicated empty lines.

BUG=None

Review-Url: https://codereview.chromium.org/2558383003
Cr-Commit-Position: refs/heads/master@{#437768}

01537d2e

Strength-reduce the "scale-factor changed" condition in LayoutSVGRoot · a229e828

fs authored Dec 10, 2016

Spend some cycles examining the difference between the old and new
local-to-border-box transforms, and only signal scale-factor changes
if that part of the transform changed.
This also means that we now detect changes scale that we previously
didn't (like [1].)

[1] paint/invalidation/svg/absolute-sized-content-with-resources.xhtml

BUG=603956,664961

Review-Url: https://codereview.chromium.org/2559123003
Cr-Commit-Position: refs/heads/master@{#437767}

a229e828

Update V8 to version 5.7.202. · d1693364

v8-autoroll authored Dec 10, 2016

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/0a12a619..921d884f

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,littledan@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2564173003
Cr-Commit-Position: refs/heads/master@{#437766}

d1693364

Enable RL by default · 7cfbed3d

olivierrobin authored Dec 10, 2016

BUG=577659

Review-Url: https://codereview.chromium.org/2562643003
Cr-Commit-Position: refs/heads/master@{#437765}

7cfbed3d

Revert of Improve EAT_STREAM_PARAMETERS for Windows x86 (patchset #10... · 314c528d

primiano authored Dec 10, 2016

Revert of Improve EAT_STREAM_PARAMETERS for Windows x86 (patchset #10 id:240001 of https://codereview.chromium.org/2559323007/ )

Reason for revert:
Broke D*LOG on a bunch of bots building non-official builds.
See https://codereview.chromium.org/2559323007/#msg60
and https://codereview.chromium.org/2559323007/#msg61
for more context.

Original issue's description:
> Improve EAT_STREAM_PARAMETERS for Windows x86
>
> Dumps of check_example.exe
>
> Current:
>
> ?DoBlinkReleaseAssert@@YAX_N@Z:
>   00404EDC: 55                 push        ebp
>   00404EDD: 8B EC              mov         ebp,esp
>   00404EDF: 80 7D 08 00        cmp         byte ptr [ebp+8],0
>   00404EE3: 75 07              jne         00404EEC
>   00404EE5: C6 05 00 00 00 00  mov         byte ptr ds:[0],0
>             00
>   00404EEC: 5D                 pop         ebp
>   00404EED: C3                 ret
> ?DoCheck@@YAX_N@Z:
>   00404EEE: 55                 push        ebp
>   00404EEF: 8B EC              mov         ebp,esp
>   00404EF1: 51                 push        ecx
>   00404EF2: 83 65 FC 00        and         dword ptr [ebp-4],0
>   00404EF6: 80 7D 08 00        cmp         byte ptr [ebp+8],0
>   00404EFA: 75 07              jne         00404F03
>   00404EFC: C6 05 00 00 00 00  mov         byte ptr ds:[0],0
>             00
>   00404F03: 8B E5              mov         esp,ebp
>   00404F05: 5D                 pop         ebp
>   00404F06: C3                 ret
> _main:
>   00404F07: 55                 push        ebp
>   00404F08: 8B EC              mov         ebp,esp
>   00404F0A: 83 7D 08 02        cmp         dword ptr [ebp+8],2
>   00404F0E: 53                 push        ebx
>   00404F0F: 0F 9F C3           setg        bl
>   00404F12: 53                 push        ebx
>   00404F13: E8 D6 FF FF FF     call        ?DoCheck@@YAX_N@Z
>   00404F18: 53                 push        ebx
>   00404F19: E8 BE FF FF FF     call        ?DoBlinkReleaseAssert@@YAX_N@Z
>   00404F1E: 59                 pop         ecx
>   00404F1F: 59                 pop         ecx
>   00404F20: 33 C0              xor         eax,eax
>   00404F22: 5B                 pop         ebx
>   00404F23: 5D                 pop         ebp
>   00404F24: C3                 ret
>
>
>
> After this CL:
>
> ?DoBlinkReleaseAssert@@YAX_N@Z:
>   00404EAC: 55                 push        ebp
>   00404EAD: 8B EC              mov         ebp,esp
>   00404EAF: 80 7D 08 00        cmp         byte ptr [ebp+8],0
>   00404EB3: 75 07              jne         00404EBC
>   00404EB5: C6 05 00 00 00 00  mov         byte ptr ds:[0],0
>             00
>   00404EBC: 5D                 pop         ebp
>   00404EBD: C3                 ret
> _main:
>   00404EBE: 55                 push        ebp
>   00404EBF: 8B EC              mov         ebp,esp
>   00404EC1: 83 7D 08 02        cmp         dword ptr [ebp+8],2
>   00404EC5: 53                 push        ebx
>   00404EC6: 0F 9F C3           setg        bl
>   00404EC9: 53                 push        ebx
>   00404ECA: E8 DD FF FF FF     call        ?DoBlinkReleaseAssert@@YAX_N@Z
>   00404ECF: 53                 push        ebx
>   00404ED0: E8 D7 FF FF FF     call        ?DoBlinkReleaseAssert@@YAX_N@Z
>   00404ED5: 59                 pop         ecx
>   00404ED6: 59                 pop         ecx
>   00404ED7: 33 C0              xor         eax,eax
>   00404ED9: 5B                 pop         ebx
>   00404EDA: 5D                 pop         ebp
>   00404EDB: C3                 ret
>
>
> Amusingly, I was confused because I thought I was going crazy when
> DoCheck wasn't showing up in the /disasm. But of course, it's because it
> got COMDAT'd with the Blink one, as we want. :)
>
> R=primiano@chromium.org
> BUG=672699
>
> Review-Url: https://codereview.chromium.org/2559323007

TBR=dcheng@chromium.org,scottmg@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=672699

Review-Url: https://codereview.chromium.org/2569583002
Cr-Commit-Position: refs/heads/master@{#437764}

314c528d

Improve EAT_STREAM_PARAMETERS for Windows x86 · 39e086ae

scottmg authored Dec 10, 2016

Dumps of check_example.exe

Current:

?DoBlinkReleaseAssert@@YAX_N@Z:
  00404EDC: 55                 push        ebp
  00404EDD: 8B EC              mov         ebp,esp
  00404EDF: 80 7D 08 00        cmp         byte ptr [ebp+8],0
  00404EE3: 75 07              jne         00404EEC
  00404EE5: C6 05 00 00 00 00  mov         byte ptr ds:[0],0
            00
  00404EEC: 5D                 pop         ebp
  00404EED: C3                 ret
?DoCheck@@YAX_N@Z:
  00404EEE: 55                 push        ebp
  00404EEF: 8B EC              mov         ebp,esp
  00404EF1: 51                 push        ecx
  00404EF2: 83 65 FC 00        and         dword ptr [ebp-4],0
  00404EF6: 80 7D 08 00        cmp         byte ptr [ebp+8],0
  00404EFA: 75 07              jne         00404F03
  00404EFC: C6 05 00 00 00 00  mov         byte ptr ds:[0],0
            00
  00404F03: 8B E5              mov         esp,ebp
  00404F05: 5D                 pop         ebp
  00404F06: C3                 ret
_main:
  00404F07: 55                 push        ebp
  00404F08: 8B EC              mov         ebp,esp
  00404F0A: 83 7D 08 02        cmp         dword ptr [ebp+8],2
  00404F0E: 53                 push        ebx
  00404F0F: 0F 9F C3           setg        bl
  00404F12: 53                 push        ebx
  00404F13: E8 D6 FF FF FF     call        ?DoCheck@@YAX_N@Z
  00404F18: 53                 push        ebx
  00404F19: E8 BE FF FF FF     call        ?DoBlinkReleaseAssert@@YAX_N@Z
  00404F1E: 59                 pop         ecx
  00404F1F: 59                 pop         ecx
  00404F20: 33 C0              xor         eax,eax
  00404F22: 5B                 pop         ebx
  00404F23: 5D                 pop         ebp
  00404F24: C3                 ret

After this CL:

?DoBlinkReleaseAssert@@YAX_N@Z:
  00404EAC: 55                 push        ebp
  00404EAD: 8B EC              mov         ebp,esp
  00404EAF: 80 7D 08 00        cmp         byte ptr [ebp+8],0
  00404EB3: 75 07              jne         00404EBC
  00404EB5: C6 05 00 00 00 00  mov         byte ptr ds:[0],0
            00
  00404EBC: 5D                 pop         ebp
  00404EBD: C3                 ret
_main:
  00404EBE: 55                 push        ebp
  00404EBF: 8B EC              mov         ebp,esp
  00404EC1: 83 7D 08 02        cmp         dword ptr [ebp+8],2
  00404EC5: 53                 push        ebx
  00404EC6: 0F 9F C3           setg        bl
  00404EC9: 53                 push        ebx
  00404ECA: E8 DD FF FF FF     call        ?DoBlinkReleaseAssert@@YAX_N@Z
  00404ECF: 53                 push        ebx
  00404ED0: E8 D7 FF FF FF     call        ?DoBlinkReleaseAssert@@YAX_N@Z
  00404ED5: 59                 pop         ecx
  00404ED6: 59                 pop         ecx
  00404ED7: 33 C0              xor         eax,eax
  00404ED9: 5B                 pop         ebx
  00404EDA: 5D                 pop         ebp
  00404EDB: C3                 ret

Amusingly, I was confused because I thought I was going crazy when
DoCheck wasn't showing up in the /disasm. But of course, it's because it
got COMDAT'd with the Blink one, as we want. :)

R=primiano@chromium.org
BUG=672699

Review-Url: https://codereview.chromium.org/2559323007
Cr-Commit-Position: refs/heads/master@{#437763}

39e086ae

Automated Commit: Committing new LKGM version 9067.0.0 for chromeos. · 692a335e
chromeos-commit-bot authored Dec 10, 2016
```
Cr-Commit-Position: refs/heads/master@{#437762}
```
692a335e