GitLab

On Android, the ClientSideDetectionOnAndroid
experiment needs to be turned on in order
for the CSDService and CSDHost to be created.
Also updated the CSDModel experiment to
the experiment used on Android.


Bug: 1108080
Change-Id: Ia53cb59331582877b6e0ebf4f08f2c921a732ba0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2411426
Commit-Queue: Bettina Dea <bdea@chromium.org>
Reviewed-by: Daniel Rubery <drubery@chromium.org>
Cr-Commit-Position: refs/heads/master@{#808045}

This CL removed fixed priority from the scheduler in favor of using
PrioritisationType to make priority decisions. This centralizes
priority to ComputePriority/PrioritisationType. Specifically, this CL
has kBestEffort queues use kBestEffort PrioritisationType and adds
kInput PrioritisationType for input queues.

Change-Id: Icaabc29ff6d3d8f5595c64741056899ffa474fff
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2376574
Commit-Queue: Katie Dillon <kdillon@chromium.org>
Reviewed-by: Scott Haseley <shaseley@chromium.org>
Cr-Commit-Position: refs/heads/master@{#808044}

Bug: 1093185
Change-Id: I47bbd1dc115751de7061ed89bf771a042800a273
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2412554
Commit-Queue: Nnamdi Theodore Johnson-kanu <tjohnsonkanu@google.com>
Reviewed-by: Azeem Arshad <azeemarshad@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#808043}

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll
Please CC chonggu@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Tbr: chonggu@google.com
Change-Id: Ic660b895f06755a9f52bc09db2f9d3ec09cb036d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2417129Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#808042}

UMA data suggests that we never draw frames on Mali-400 with <= 512 MB.
This is probably inability to use RGB565 framebuffer.

Disabling SkiaRenderer until this is fixed.

Bug: 1126490
Change-Id: Id9081cb178febc54d612498b8344286bd76643a9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416722
Commit-Queue: Jonathan Backer <backer@chromium.org>
Auto-Submit: Jonathan Backer <backer@chromium.org>
Reviewed-by: Vasiliy Telezhnikov <vasilyt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#808041}

Decoding a bitstream in VA has two steps: one, submitting the parsed
parameters and encoded chunk as VABufferIDs, and two, executing the
decode. This CL transfers managing the lifetime of the VABufferIDs to
VP9VaapiVideoDecoderDelegate, avoiding vaCreateBuffer() calls.

To do that this CL reshuffles a bit the VaapiWrapper calls to be able
to call vaCreateBuffer(), MapAndCopy and Execute, in a piecemeal,
configurable fashion.

This is verified via chrome:tracing and codepen.io/full/RwarYvG that
plays 4 1280x572 VP9 videos at the same time. Tracing is captured for
a few seconds, and basically we avoid calling the vaCreateBuffer(),
which takes ~50us every time, reducing the overall decode time from
~3.740ms to ~3.425ms on my BSW (reks), ~10% reduction. (Also tried on
kohaku and numbers are similar albeit smaller bc the SoC is faster).
Improvements are of course extremely small, the advantages of this CL
are in reducing lock/unlock churn and associated contention. This
benefit grows with the amount of decodes (e.g. Meet grid scenarios).

This CL also removes the unused VaapiWrapper::Execute() method.

Bug: b/166646505
Change-Id: Id44dbb21825328dfb4fc47e1c7807bd725efd196
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404740
Commit-Queue: Miguel Casas <mcasas@chromium.org>
Reviewed-by: Andres Calderon Jaramillo <andrescj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#808040}

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/a787cd5e158b..e2e75b23aa67

2020-09-17 chanli@chromium.org [depot_tools] Roll led to latest

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/depot-tools-chromium-autoroll
Please CC ehmaldonado@google.com,sokcevic@google.com,ajp@google.com,apolito@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: ehmaldonado@google.com,sokcevic@google.com,ajp@google.com,apolito@google.com
Change-Id: I70e3ab14571d3002dbe7ab7212e12bcf1fde6cee
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416962Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#808039}

Bug: 927509
Change-Id: Ifb35e635d8124850ed6819d3e8be76efbbb3ce95
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416522Reviewed-by: Ted Choc <tedchoc@chromium.org>
Commit-Queue: Jochen Eisinger <jochen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#808038}

Strings update according to: http://go/cros-lang-settings-ux-writing
Mock: http://go/cros-lang-settings-ux-slide#slide=11
Figma: http://go/cros-lang-settings-figma
Current view: http://screen/GC6WrWAVYRGGyeh

Note:
- Replace settings-box with cr-row, start with flex as per
https://crrev.com/c/2144429

Bug: 1113439
Change-Id: If185ce874269db8c921ae9136d15f0ad49f4146f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2413767Reviewed-by: Alex Gough <ajgo@chromium.org>
Reviewed-by: Regan Hsu <hsuregan@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Commit-Queue: My Nguyen <myy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#808037}

To prepare for an upcoming change to add Windows handles to
gfx::GpuFenceHandle, it needs to be responsible for lifetime of the
handles it carries instead of leaving it in the hands of IPC code.

This change follows the existing model of gfx::GpuMemoryBufferHandle and
has the gfx::GpuFenceHandle use platform specific RAII classes to manage
OS resources. gfx::GpuFence is simplified to use gfx::GpuFenceHandle
directly.

Change-Id: I4fdb3eb9c06cd7a4e03ba9f37fb7da31e8ef0cb4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404956Reviewed-by: Daniele Castagna <dcastagna@chromium.org>
Reviewed-by: Robert Kroeger <rjkroege@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Sunny Sachanandani <sunnyps@chromium.org>
Reviewed-by: Klaus Weidner <klausw@chromium.org>
Commit-Queue: Rafael Cintron <rafael.cintron@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#808036}

The purpose is to decide if they are unanimously supported on Mac,
so we could bypass checking them in
FeatureInfo::InitializeFloatAndHalfFloatFeatures(), which seems
to cause hangs on a bunch of devices.

The histograms are recorded on other platforms as well to give
us some insights there.

BUG=1127387
TEST=bots
R=kbr@chromium.org

Change-Id: I47025790d531af3f2a1cfb11814cfb39f6229925
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410288
Auto-Submit: Zhenyao Mo <zmo@chromium.org>
Commit-Queue: Jesse Doherty <jwd@chromium.org>
Reviewed-by: Jesse Doherty <jwd@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#808035}

Bug: 1076336
Change-Id: I8ce6073ee3289faf2f716e4a42fd27f5048f297d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2415990
Commit-Queue: Mark Brand <markbrand@google.com>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#808034}

This modifies the fix from crrev.com/c/2363692 to only suppress the
calls that cause the cursor bug instead of the entire "focus loss"
section of RenderWidgetHostViewAura::OnWindowFocused

Bug: 1100902, 1121744
Change-Id: I3846b9381f3fc04442bbd8b00cfcf289d8871e08
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391514Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Reviewed-by: Roger Tawa <rogerta@chromium.org>
Commit-Queue: Dominique Fauteux-Chapleau <domfc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#808033}

Doing this allows us to avoid the below DCHECK encountered when running
the status quo tests. Having variations_features.h allows us to avoid
splitting the variations static_library into two because
variations_features can have its own target in the BUILD file.

...FATAL:feature_list.cc(472)]
Check failed: CheckFeatureIdentity(feature). RestrictGoogleWebVisibility

Bug: 1094303
Change-Id: I9ee3f02d8f3cde7398e759fe54b19cdc9ebb2271
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410554
Commit-Queue: Caitlin Fischer <caitlinfischer@google.com>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#808032}

This should not change deep scanning behaviour with Connectors. The
corresponding enums are kept until crbug.com/1109242 is fixed. Removing
these policies completely is safe since they were marked as future and
they have only been delivered as cloud policies.

Bug: 1103390
Change-Id: If41d87624f2dd7356efcad902ff0b355f1fdec2b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2412693
Commit-Queue: Dominique Fauteux-Chapleau <domfc@chromium.org>
Reviewed-by: Owen Min <zmin@chromium.org>
Reviewed-by: Roger Tawa <rogerta@chromium.org>
Cr-Commit-Position: refs/heads/master@{#808031}

Bug: 865579
Change-Id: I6cad7c4fb4704b83dcd806b8bf7a96cdf5855ee6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416390Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org>
Commit-Queue: Kevin Ellis <kevers@chromium.org>
Cr-Commit-Position: refs/heads/master@{#808030}

R=avi@chromium.org

Bug: 1091083
Change-Id: Ic67fd17de94cbd362cfff0502b081db0830780e0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2403630
Commit-Queue: danakj <danakj@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#808029}

This is useful for the extensions API, where it's helpful to have something like:

    tab_groups::TabGroupId group = tab_groups::TabGroupId::CreateEmpty();
    GetGroupFromId(id, &group);  // Populates group by reference, with an existing value.
    if (!group.is_empty()) {
      // Logic handling the group
    }

Having CreateEmpty() and is_empty() helps make this pattern intentional without accidentally creating empty groups and breaking assumptions in the tabstrip.

Change-Id: Ibb217edfd8ba599023488ea3d1a33277b49d8284
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2415573Reviewed-by: Charlene Yan <cyan@chromium.org>
Commit-Queue: Connie Wan <connily@chromium.org>
Cr-Commit-Position: refs/heads/master@{#808028}

The change enables the Core Location backend for the Geolocation API by
default on macOS.

Bug: 1051591
Change-Id: I24f64e98beede879e0237fc73b3dc884f121d131
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2411302
Commit-Queue: Reilly Grant <reillyg@chromium.org>
Reviewed-by: Ovidio de Jesús Ruiz-Henríquez <odejesush@chromium.org>
Cr-Commit-Position: refs/heads/master@{#808027}

To allow incremental removal of set_sources_assignment_filter feature,
move the global list to a separate .gni file that will need to be used
by all BUILD.gn that depend on a global filter list (until they are
converted).

To reduce the size of the CL, the file is imported from BUILDCONFIG.gn
to call set_sources_assignment_filter (and save the variable with the
old name).

Bug: 1018739
Change-Id: Id6f89127327e13731d7fddb839af72dd242ecce5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416496
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#808026}

Chrome/mac/arm builds with nacl disabled.

Bug: 1117244
Change-Id: I1f44b9452b2d6692684c918ca200b3530a3a8bde
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416742
Commit-Queue: Nico Weber <thakis@chromium.org>
Commit-Queue: Michael Moss <mmoss@chromium.org>
Auto-Submit: Nico Weber <thakis@chromium.org>
Reviewed-by: Michael Moss <mmoss@chromium.org>
Cr-Commit-Position: refs/heads/master@{#808025}

This change implements Mac font enumeration browser-side.

The current implementation is located in blink, cached in FontCache.
This browser-side implementation makes the Mac platform in-line with all
the other platform implementations.

A subsequent changelist removes the blink implementation altogether.

Bug: 1043306
Change-Id: Ic6dff854a74d27ad6d3df9d2ef3eb5217e3e55ff
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410594
Commit-Queue: Olivier Yiptong <oyiptong@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Joshua Bell <jsbell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#808024}

There seem to be multiple failure modes here. Give them one
bug and sort it all out as the issues get fixed.

TBR: ikilpatrick@chromium.org
Bug: 1129522
Change-Id: Ida9b4f6858f305e7d2f3d0f5f1b89c5949e4abd8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416934Reviewed-by: Stephen Chenney <schenney@chromium.org>
Commit-Queue: Stephen Chenney <schenney@chromium.org>
Cr-Commit-Position: refs/heads/master@{#808023}

When a frame has a forced intersection observation, throttling should
be ignored and lifecycle updates should still occur. This did not
happen for forced updates that were under a throttled frame. This
occurs on [1] but was not discovered due to a bug in our DCHECKS [2].

[1] external/wpt/html/browsers/browsing-the-web/navigating-across-documents/abort-document-load.html
[2] https://chromium-review.googlesource.com/c/chromium/src/+/2410526

Change-Id: I25a9127faafc87ab15ac2a8fbb465c43165a2e8e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2412252
Commit-Queue: Philip Rogers <pdr@chromium.org>
Commit-Queue: Stefan Zager <szager@chromium.org>
Reviewed-by: Stefan Zager <szager@chromium.org>
Auto-Submit: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#808022}

Due to innovation in ld64's warning output, some non-interesting
warnings make it past our filters:

warning: /Applications/Xcode-beta.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/libtool:
    archive library: clang_x64_v8_arm64/obj/third_party/perfetto/protos/perfetto/common/libzero.a
    the table of contents is empty (no object file members in the library define global symbols)

Innovate right back.

Also make it clear which of these patterns span several lines.

Bug: none
Change-Id: I8542ab4d82005eaa67fae4a7af398ba1ebf8220f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416830
Commit-Queue: Nico Weber <thakis@chromium.org>
Reviewed-by: Mark Mentovai <mark@chromium.org>
Auto-Submit: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#808021}

Bug: 243833
Change-Id: Ibe12c7396feca063344525f73e1286255fa37f83
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410530Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Emily Stark <estark@chromium.org>
Reviewed-by: Christian Dullweber <dullweber@chromium.org>
Commit-Queue: Yann Dago <ydago@chromium.org>
Cr-Commit-Position: refs/heads/master@{#808020}

This change implements a static requestPermission() method on the
IdleDetector interface and switches the API from requiring the
"notifications" permission to the new "idle-detector" permission.

Bug: 878979
Change-Id: If2162f6a1f770544aeb82f98fcc65a76059b7d13
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359539
Auto-Submit: Reilly Grant <reillyg@chromium.org>
Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org>
Reviewed-by: Ayu Ishii <ayui@chromium.org>
Commit-Queue: Reilly Grant <reillyg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#808019}

Make sure that member variables are either default initialized or const
so they must be initialized in the constructor.

Bug: none
Change-Id: I69d8aa51b035f37e26412604797430dda63c5717
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410524Reviewed-by: weiliangc <weiliangc@chromium.org>
Commit-Queue: kylechar <kylechar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#808018}

Split KeyPermissionsManager,
KeyPermissionsManager::PermissionsForExtension and
KeyPermissionsManagerUserService into a public virtual API and
implementation in *Impl classes.
This will be used in a follow-up CL to test interactions with
KeyPermissionsManager in unit tests.

Note: This CL does not change any behavior.

Bug: 1127506
Change-Id: Iacbbd6e533db0b476b2fb5d6e04e241966c7bafa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2413248Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
Reviewed-by: Edman Anjos <edman@chromium.org>
Reviewed-by: Omar Morsi <omorsi@google.com>
Commit-Queue: Edman Anjos <edman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#808017}

BrowserSwitcher.Decision and BrowserSwitcher.DecisionTime are expiring
soon.

Set the expiry of every histogram in BrowserSwitcher.* to the same
date, so we can update them all at the same time next time.

Bug: 1127946
Change-Id: I0b20c342e1d7413611f826b6619e7ce47a8512d6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414674
Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#808016}

This code is no longer needed and breaks ARM mac.

MacOS added support for the Linux-style socket option
sometime between 2008 and 2010 (see links below) and
Chrome currently only supports macOS versions as far
back as Yosemite which was released in 2014, and
iOS 10 which was released in 2016. So we are safe to
remove this workaround which was added in 2013.

https://opensource.apple.com/source/xnu/xnu-1504.9.37/bsd/netinet/in.h
https://opensource.apple.com/source/xnu/xnu-1699.22.73/bsd/netinet/in.h
https://codereview.chromium.org/99923004/diff/200001/net/udp/udp_socket_libevent.cc

Change-Id: Ib67ec88aa618b977fe1f64a4862edda8c8ffefe1

Bug: 1128459
Change-Id: Ib67ec88aa618b977fe1f64a4862edda8c8ffefe1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2415193
Commit-Queue: Renjie Tang <renjietang@chromium.org>
Reviewed-by: David Schinazi <dschinazi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#808015}

TBR=bling-team@google.com

Change-Id: I6d4c52d17c6b144cb916c1e90564b6a0ef170f43
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416396Reviewed-by: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#808014}

Bug: 1129504
Change-Id: Icb74a2b914c65ba2cfda14409f0d7a7642d132f4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2417049
Auto-Submit: Carlos Knippschild <carlosk@chromium.org>
Reviewed-by: Justin DeWitt <dewittj@chromium.org>
Commit-Queue: Justin DeWitt <dewittj@chromium.org>
Commit-Queue: Carlos Knippschild <carlosk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#808013}

Bug: 1050760
Change-Id: I61a688ce504575f78f43b9071370489714ea3999
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414844Reviewed-by: Garrett Beaty <gbeaty@chromium.org>
Commit-Queue: Rakib Hasan <rmhasan@google.com>
Cr-Commit-Position: refs/heads/master@{#808012}

This CL removes the paint preview when the tab is hidden for any reason
other than the activity being hidden. This should hopefully avoid
possible memory leaks by keeping the preview active for hidden tabs
that didn't finish loading.

Change-Id: Ibbc66d7e9303592be4e933a37490a6ead0bcb6ed
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416770
Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org>
Reviewed-by: Mehran Mahmoudi <mahmoudi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#808011}

LocationBarSteadyStateTestCase/testFocusingOmniboxDismissesEditMenu

Bug: 1129095
Change-Id: I7d9f7676530c3f657cc31e1be7e9b3937718297c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414566
Auto-Submit: Mike Dougherty <michaeldo@chromium.org>
Commit-Queue: Justin Cohen <justincohen@chromium.org>
Reviewed-by: Justin Cohen <justincohen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#808010}

This reverts commit fa06bf45.

Reason for revert: Believe this introduces flakiness and failures on lacros. See https://bugs.chromium.org/p/chromium/issues/detail?id=1129425

Original change's description:
> ozone/wayland: gracefully shutdown the browser on protocol error.
> 
> Wayland may disconnect the client if it hits an unrecoverable
> error. That is, it prints an error message and client cannot
> do anything about that after that except shutting itself down.
> 
> Thus, while watching the display fd, always check for errors. If
> a protocol error is set, trigger |shutdown_cb| and also stop
> watching the fd.
> 
> Bug: 1127278
> Change-Id: Ie324af93d455c0c83f8e75cdecfafe2254da1972
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404931
> Commit-Queue: Maksim Sisov (GMT+3) <msisov@igalia.com>
> Reviewed-by: Robert Kroeger <rjkroege@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#807775}

TBR=rjkroege@chromium.org,msisov@igalia.com

Change-Id: Ie1cfa657b34930ebc6e568c1d422dbfae910197a
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1127278
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416884Reviewed-by: Joshua Pawlicki <waffles@chromium.org>
Commit-Queue: Joshua Pawlicki <waffles@chromium.org>
Cr-Commit-Position: refs/heads/master@{#808009}

This reverts commit ee15e47d.

Reason for revert: Step "vulkan_content_browsertests on Android device Pixel 2" failing (crbug.com/1129552)

Original change's description:
> Add Google Sans to FontUniqueNameLookup browser test
> 
> This will help ensure we have local access to the Google Sans although
> the bots only verify this on Pixel devices, not on OEM devices which
> retrieve Google Sans from GMScore. Currently there is only manual
> verification for the latter.
> 
> Bug: 1115064
> Change-Id: Ie3a2233e1dc972a10aaa4229a6d06ac2220607ec
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404852
> Reviewed-by: Avi Drissman <avi@chromium.org>
> Commit-Queue: Dominik Röttsches <drott@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#807921}

TBR=avi@chromium.org,drott@chromium.org

Change-Id: I1f626d35309e86829577f9e300ca0e4cd1fb3d0d
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1115064
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2417094Reviewed-by: Behdad Bakhshinategh <behdadb@chromium.org>
Commit-Queue: Behdad Bakhshinategh <behdadb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#808008}

When exploring breaking opportunities we were early return, and shaping
to the end, when we detected that current candidate overflow and next
breaking opportunity surpass the item's range end.

However, since we landed in r807457 the new TextBreakIterator's
behavior of  breaking always after the space run, we can get some
opportunities that surpass the item's range_end even if the candidate
doesn't overflow. An example of this could be when trailing spaces are
located in different items.

This patch ensures that even when the candidate doesn't overflow, we
never consider breaking opportunity offsets that surpass the item's
range end; since we are not overflowing, we'll proceed with the shaping
logic considering range_end as maximum of the breaking opportunity
offset.

Bug: 1128571
Change-Id: I704eb8091cdca00713fed15e22749bb633bacc71
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414196
Commit-Queue: Javier Fernandez <jfernandez@igalia.com>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#808007}

Read Later is hidden behind the feature flag kReadLater. This change
sets up the webui for the read later menu with basic functionality
displaying unread/read items which open on click. This menu will appear
in a bubble anchored to a new button in the bookmarks bar. Items can be
added to this menu through selecting 'Add to Read later' from the
omnibox star button.

screenshot: https://screenshot.googleplex.com/394BCbWa9836Y2Y

Bug: 1109316
Change-Id: I9b8ac6ea7c7bac879b8e01e074c68fe33039a915
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2386218
Commit-Queue: Caroline Rising <corising@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: dpapad <dpapad@chromium.org>
Reviewed-by: Alex Gough <ajgo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#808006}