GitLab

Revert of Fix incorrect number of matches and misleading highlighting in "Find on Page" results (https://codereview.chromium.org/422443004/)

Reason for revert:
This broke FindInPageControllerTest.LargePage on multiple bots (e.g. http://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%282%29/builds/30423)

Filed a bug:
https://code.google.com/p/chromium/issues/detail?id=398017

Original issue's description:
> Fix incorrect number of matches and misleading highlighting in "Find on Page" results.
> 
> BUG= 397563
> 
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=179000

TBR=yosin@chromium.org,tkent@chromium.org,iceman@yandex-team.ru
NOTREECHECKS=true
NOTRY=true
BUG= 397563

Review URL: https://codereview.chromium.org/424803002

git-svn-id: svn://svn.chromium.org/blink/trunk@179036 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=267592
R=vsevik

Review URL: https://codereview.chromium.org/413213003

git-svn-id: svn://svn.chromium.org/blink/trunk@179035 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Intent to Deprecate:
https://groups.google.com/a/chromium.org/d/msg/blink-dev/1m47rW4w7dc/MOf_2kgb2wIJw

Review URL: https://codereview.chromium.org/422743002

git-svn-id: svn://svn.chromium.org/blink/trunk@179032 bbb929c8-8fbe-4397-9dbb-9b2b20218538

R=aandrey, pfeldman, vsevik
BUG=394384

Review URL: https://codereview.chromium.org/397303002

git-svn-id: svn://svn.chromium.org/blink/trunk@179031 bbb929c8-8fbe-4397-9dbb-9b2b20218538

HTML says:

 "The IDL attributes naturalWidth and naturalHeight must return the
  intrinsic width and height of the image, in CSS pixels, if the image is
  available, or else 0."

Change HTMLImageElement::natural{Width,Height} to request the intrinsic
size from ImageResource::imageSizeForRenderer by passing IntrinsicSize as
the third parameter. This makes the attributes return more appropriate
values for SVG-images in <img>.

BUG=396955

Review URL: https://codereview.chromium.org/422503002

git-svn-id: svn://svn.chromium.org/blink/trunk@179030 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This replaces the BlendModeType enumeration with the WebBlendMode for
FEBlend::m_mode. The former is moved to SVGFEBlendElement.
This enables FEBlend to use all of the blend modes available in
WebBlendMode, and leave any subset selection to the client of FEBlend
(which is SVGFEBlendElement).
The BlendModeType->string mapping is replaced by compositeOperatorName().

BUG=389594

Review URL: https://codereview.chromium.org/419253002

git-svn-id: svn://svn.chromium.org/blink/trunk@179029 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=340522

Review URL: https://codereview.chromium.org/415043003

git-svn-id: svn://svn.chromium.org/blink/trunk@179021 bbb929c8-8fbe-4397-9dbb-9b2b20218538

service_worker_unregister_and_done was outside of the .then chain, so it
would execute early and the test passes regardless of the assertions.

BUG=395928

Review URL: https://codereview.chromium.org/426563003

git-svn-id: svn://svn.chromium.org/blink/trunk@179020 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This CL introduces |SVGElement::parseAttributeNew|, a new
|SVGElement::parseAttribute| implementation based on property map.

Before this patch, |SVG(.*)Element::parseAttribute| used chained if stmts
to resolve SVGAnimatedProperty. This patch changes it to resolve using
property map.

This is to replace the existing |SVGElement::parseAttribute| implementation,
but as there are many callers, we would like to proceed this incrementally.
a) Introduce |SVGElement::parseAttributeNew|
b) Convert all overrides |SVGElement::parseAttribute| to
   a |parseAttributeNew| call.
c) Replace existing |parseAttribute| with |parseAttributeNew|, and remove all
   overrides simply calling |parseAttributeNew|

This patch is (a). This patch also converts |SVG{Graphics,Rect}Element::parseAttribute| to start with (b).

BUG=397902

Review URL: https://codereview.chromium.org/421863002

git-svn-id: svn://svn.chromium.org/blink/trunk@179019 bbb929c8-8fbe-4397-9dbb-9b2b20218538

We have inconsistent style for multiple-line base class list.

A) 37 instances

class Foo
    : public BaseA
    , public BaseB
    , public BaseC {
    ...

B) 17 instances

class Foo :
    public BaseA,
    public BaseB,
    public BaseC {
    ....

The number of A is larger than the number of B, and A is consistent with the
initialization list style. This CL changes B to A.

BUG=

Review URL: https://codereview.chromium.org/423803002

git-svn-id: svn://svn.chromium.org/blink/trunk@179018 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This CL adds a set of live Resources to MemoryCache to emulate the current
lifetime management precisely in Oilpan.

Resource::m_resourceToRevalidate refers another Resource, and
Resource::m_proxyResource is a back pointer of m_resourceToRevlidate. According
to Resource::canDelete, both of them are strong references.

BUG=393516

Review URL: https://codereview.chromium.org/424633002

git-svn-id: svn://svn.chromium.org/blink/trunk@179016 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=340522

Review URL: https://codereview.chromium.org/323043002

git-svn-id: svn://svn.chromium.org/blink/trunk@179015 bbb929c8-8fbe-4397-9dbb-9b2b20218538

R=apavlov

Review URL: https://codereview.chromium.org/426563004

git-svn-id: svn://svn.chromium.org/blink/trunk@179014 bbb929c8-8fbe-4397-9dbb-9b2b20218538

* selector is not required.

BUG=316092

Review URL: https://codereview.chromium.org/420193004

git-svn-id: svn://svn.chromium.org/blink/trunk@179013 bbb929c8-8fbe-4397-9dbb-9b2b20218538

CSSPresentationModel has been introduced in order to
- manage source mappings,
- store live locations,
- perform the rawLocationToUILocation conversions.

R=pfeldman, vsevik

Review URL: https://codereview.chromium.org/297923002

git-svn-id: svn://svn.chromium.org/blink/trunk@179012 bbb929c8-8fbe-4397-9dbb-9b2b20218538

When SharedWorker script load has failed and the |WebSharedWorkerImpl|
was explicit told to terminate, the |WebSharedWorkerImpl| instance
was never deleted.

This CL fixes the issue by invoking "delete this" when a worker thread
instance does not exist in |stopWorkerThread()|.

TEST=fast/workers/worker-crash-with-invalid-location.html doesn't leak when --enable-leak-detection
BUG=364390

Review URL: https://codereview.chromium.org/424653002

git-svn-id: svn://svn.chromium.org/blink/trunk@179011 bbb929c8-8fbe-4397-9dbb-9b2b20218538

As same as http://crrev.com/407073009 , this CL may increase the size of these classes by +16 or +8 bytes. +8 bytes for |m_wrapperOrTypeInfo| (type of uintptr_t) in ScriptWrappable. Another +8 bytes for vtbl.

BUG=235436

Review URL: https://codereview.chromium.org/412183003

git-svn-id: svn://svn.chromium.org/blink/trunk@179010 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This was probably originally FullscreenController.

Also fix a typo and simplify isActiveFullScreenElement.

Review URL: https://codereview.chromium.org/421693003

git-svn-id: svn://svn.chromium.org/blink/trunk@179009 bbb929c8-8fbe-4397-9dbb-9b2b20218538

- Make sure |this| is kept while offlineRender() by passing PassRefPtr<> to
  bind().

- Make sure |this| is kept until finishing notifyComplete() by
  createCrossThreadTask(), which uses bind() internally.

BUG=395941

Review URL: https://codereview.chromium.org/423783002

git-svn-id: svn://svn.chromium.org/blink/trunk@179008 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Hidden columns are supported by DataGrid now.

BUG=316092

Review URL: https://codereview.chromium.org/422543002

git-svn-id: svn://svn.chromium.org/blink/trunk@179007 bbb929c8-8fbe-4397-9dbb-9b2b20218538

TBR=tkent@chromium.org
BUG=

Review URL: https://codereview.chromium.org/421883002

git-svn-id: svn://svn.chromium.org/blink/trunk@179006 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Found by a prototype of -Wunused-local-typedef for clang.

BUG=none

Review URL: https://codereview.chromium.org/427473002

git-svn-id: svn://svn.chromium.org/blink/trunk@179005 bbb929c8-8fbe-4397-9dbb-9b2b20218538

TBR=hajimehoshi
NOTRY=true
BUG=364390

Review URL: https://codereview.chromium.org/427483002

git-svn-id: svn://svn.chromium.org/blink/trunk@179004 bbb929c8-8fbe-4397-9dbb-9b2b20218538

    
When executing editing commands, endingSelection is valid.
However, if undo some commands, endingSelection might be invalid and
FrameSelection might be updated by the invalid selection.
i.e. the selection might be owned by another document without any frames.
    
BUG=368978
TEST=Source/core/editing/FrameSelectionTest

Review URL: https://codereview.chromium.org/359593002

git-svn-id: svn://svn.chromium.org/blink/trunk@179003 bbb929c8-8fbe-4397-9dbb-9b2b20218538

There is no users of it on either Blink or Chromium. This fixes the
FIXME in WebLeakDetector.h.

BUG=None
TEST=None
R=tkent@chromium.org

Review URL: https://codereview.chromium.org/428473002

git-svn-id: svn://svn.chromium.org/blink/trunk@179002 bbb929c8-8fbe-4397-9dbb-9b2b20218538

ElementAnimation:getAnimationPlayers() crashes when it is called and no
animations have been previously created on the element.

BUG=396376

Review URL: https://codereview.chromium.org/423763002

git-svn-id: svn://svn.chromium.org/blink/trunk@179001 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG= 397563

Review URL: https://codereview.chromium.org/422443004

git-svn-id: svn://svn.chromium.org/blink/trunk@179000 bbb929c8-8fbe-4397-9dbb-9b2b20218538

It makes lock/unlock of AudioSourceProviderClient easier.
This class holds a strong reference to AudioSourceProviderClient. So we
don't need MediaElementAudioSourceNode::m_keepAliveWhileLocking.

BUG=395940

Review URL: https://codereview.chromium.org/416333002

git-svn-id: svn://svn.chromium.org/blink/trunk@178999 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Before this patch, calc values in cubic-bezier functions
weren't being read correctly since they were handled as
simple floats.

R=rob.buis@samsung.com,timloh@chromium.org,alancutter@chromium.org
BUG=388332

Review URL: https://codereview.chromium.org/369313002

git-svn-id: svn://svn.chromium.org/blink/trunk@178998 bbb929c8-8fbe-4397-9dbb-9b2b20218538

- Disallow new/delete operations for HitTestResult.
HitTestResult was used
-- with new/delete operators
-- as part objects of ContextMenuController and MouseEventWithHitTestResult.
-- as stack allocated objects

We'd like to avoid to make such classes in Oilpan.
So, this CL disallows new/delete, and WebHitTestResult owns another
class to hold only required data copied from a HitTestResult.

- Move ContextMenuController to Oilpan heap, and trace HitTestResult member.

- Mark MouseEventWithHitTestResults STACK_ALLOCATED.

- We can't get HitTestResult from a WebHitTestResult. So we need to
introduce new function to WebViewImpl for WebSubstringUtil.mm.

Difference from r176393:
Always calling HitTestResult member functions was bad. Some of them are
expensive. So WebHitTestResultPrivate contains a HitTestResult copy, and
WebHitTestResultPrivate is RefCountedWillBeGarbageCollectedFinalized in order to
trace HitTestResult.

BUG=357163

Review URL: https://codereview.chromium.org/413903004

git-svn-id: svn://svn.chromium.org/blink/trunk@178997 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Before this patch, the document held by ServiceWorker registered by
the LayoutTests were detected as leaks. The service worker is designed to live
longer than registerer document. The service worker implementation,
|WebEmbeddedWorkerImpl| carries a |WebFrame| to hold a resource loader.
The frame has its associating document, and it confused WebLeakDetector.

This patch work arounds the issue by terminating all |WebEmbeddedWorkerImpl|
instances before counting number of documents.

BUG=396493

Review URL: https://codereview.chromium.org/413993002

git-svn-id: svn://svn.chromium.org/blink/trunk@178996 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=397892
TBR=hajimehoshi
NOTRY=true

Review URL: https://codereview.chromium.org/415403003

git-svn-id: svn://svn.chromium.org/blink/trunk@178995 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Chrome does not handle large numbers of layers well and the flakiness
dashboard was creating thousands of them (one for each interpolated
result.) This patch switches to manually calculating the opacity value
and baking it into the css. This is less maintainable but avoids
expensive non-zero opacity layers.

http://hex2rgba.devoth.com is a simple tool I used to calculate the
20% opacity version of the test result colors.

NOTRY=true
TEST=manual. With this patch applied, the flakiness dashboard scrolls smoothly.
BUG=397886

Review URL: https://codereview.chromium.org/421853002

git-svn-id: svn://svn.chromium.org/blink/trunk@178994 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Intent to Ship:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/iWDqDWQ8mhs

BUG=243354
R=eseidel@chromium.org

Review URL: https://codereview.chromium.org/418133011

git-svn-id: svn://svn.chromium.org/blink/trunk@178992 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Minimize RenderObject* casting to RenderText* by providing renderer() methods
on Text and InlineTextBox that return a RenderText. This hides the more generic
renderer() methods in their parent that return a RenderObject.

This is inspired by WebKit r157373 by antti@apple.com:
https://trac.webkit.org/r157373

R=esprehn@chromium.org, pdr@chromium.org

Review URL: https://codereview.chromium.org/414863002

git-svn-id: svn://svn.chromium.org/blink/trunk@178991 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=374343

Review URL: https://codereview.chromium.org/421043002

git-svn-id: svn://svn.chromium.org/blink/trunk@178990 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Use tighter typing in editing to increase code readability. This CL focuses on
Editor and EditorCommand.

R=leviw@chromium.org

Review URL: https://codereview.chromium.org/426433002

git-svn-id: svn://svn.chromium.org/blink/trunk@178988 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Of the 2 callers one doesn't really need the conversion and  the other can get
the same results with a local flag.

BUG=

Review URL: https://codereview.chromium.org/412353003

git-svn-id: svn://svn.chromium.org/blink/trunk@178987 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Use tighter typing in editing to increase code readability. This CL
focuses on CompositeEditCommand.

R=leviw@chromium.org

Review URL: https://codereview.chromium.org/424493003

git-svn-id: svn://svn.chromium.org/blink/trunk@178986 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Use tighter typing in editing/ to increase code readability and avoid
unnecessary type checks. This CL focuses on BreakBlockquoteCommand and
Caret.

R=leviw@chromium.org

Review URL: https://codereview.chromium.org/419313002

git-svn-id: svn://svn.chromium.org/blink/trunk@178985 bbb929c8-8fbe-4397-9dbb-9b2b20218538