GitLab

BUG=706324

Review-Url: https://codereview.chromium.org/2806123002
Cr-Commit-Position: refs/heads/master@{#465729}

In particular, it's a follow up to
https://chromium-review.googlesource.com/472192.

This CL is just to fix the bots. I will follow up with proper
changes to the allocator which will eliminate the need for the
blacklist entry.

BUG=713293

Review-Url: https://codereview.chromium.org/2834513002
Cr-Commit-Position: refs/heads/master@{#465728}

This CL lands part of server change 153489255.

BUG=488484

Review-Url: https://codereview.chromium.org/2829463002
Cr-Commit-Position: refs/heads/master@{#465727}

Revert of [Home] Close the BottomSheet when a URL is loaded on the NTP (patchset #1 id:1 of https://codereview.chromium.org/2829523002/ )

Reason for revert:
Broke Lollipop Tester

junit.framework.AssertionFailedError: Sheet should be at half height expected:<1> but was:<3>
	at org.chromium.chrome.browser.ntp.ChromeHomeNewTabPageTest.validateState(ChromeHomeNewTabPageTest.java:197)
	at org.chromium.chrome.browser.ntp.ChromeHomeNewTabPageTest.createNewTab(ChromeHomeNewTabPageTest.java:168)
	at org.chromium.chrome.browser.ntp.ChromeHomeNewTabPageTest.testCloseNTP_TwoTabs(ChromeHomeNewTabPageTest.java:92)
	at android.test.InstrumentationTestCase.runMethod(InstrumentationTestCase.java:214)
	at android.test.InstrumentationTestCase.runTest(InstrumentationTestCase.java:199)
	at android.test.ActivityInstrumentationTestCase2.runTest(ActivityInstrumentationTestCase2.java:192)
	at org.chromium.chrome.test.ChromeActivityTestCaseBase.runTest(ChromeActivityTestCaseBase.java:758)
	at org.chromium.base.test.BaseTestResult.runParameterized(BaseTestResult.java:161)
	at org.chromium.base.test.BaseTestResult.run(BaseTestResult.java:124)
	at android.test.AndroidTestRunner.runTest(AndroidTestRunner.java:191)
	at android.test.AndroidTestRunner.runTest(AndroidTestRunner.java:176)
	at android.test.InstrumentationTestRunner.onStart(InstrumentationTestRunner.java:555)
	at android.app.Instrumentation$InstrumentationThread.run(Instrumentation.java:1853)

Original issue's description:
> [Home] Close the BottomSheet when a URL is loaded on the NTP
>
> This ensures that a click on the doodle will close the BottomSheet.
>
> BUG=712607
>
> Review-Url: https://codereview.chromium.org/2829523002
> Cr-Commit-Position: refs/heads/master@{#465604}
> Committed: https://chromium.googlesource.com/chromium/src/+/2a80017ed38340c00d1d214a3a2445acf5a9ed05

TBR=mvanouwerkerk@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=712607

Review-Url: https://codereview.chromium.org/2830743003
Cr-Commit-Position: refs/heads/master@{#465726}

File writes happen on a file thread. This CL waits for the file thread to flush
writes to disk.

BUG=712307
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester

Review-Url: https://codereview.chromium.org/2827673002
Cr-Commit-Position: refs/heads/master@{#465725}

BUG=500085

Review-Url: https://codereview.chromium.org/2824033003
Cr-Commit-Position: refs/heads/master@{#465724}

ffe4c1018c1b net: Update Blink source code references
e04194afd91d win: Wrap TerminateProcess() to accept cdecl patches on x86
74fddc3fed2a win: Wrap test::ChildLauncher::Start() in
             ASSERT_NO_FATAL_FAILURE()
f487da4ff2c4 win handler: Move test targets to handler_test.gyp

BUG=crashpad:179

Review-Url: https://codereview.chromium.org/2833533003
Cr-Commit-Position: refs/heads/master@{#465723}

BUG=713260
TBR=sullivan@chromium.org

Review-Url: https://codereview.chromium.org/2834503002
Cr-Commit-Position: refs/heads/master@{#465722}

Flakiness has expanded from just Windows and memory bots to Mac and
Linux as well.

Broadly disabling the test.

BUG=641400
TBR=michaelpg@chromium.org

Review-Url: https://codereview.chromium.org/2828063002
Cr-Commit-Position: refs/heads/master@{#465721}

The proposed fix is to notify the parent views when a child enables layering. The parent in
this case the ScrollView overrides the newly added notification OnChildLayerChanged() and enables
viewport layering. This ensures that the ring gets clipped.

Longer term it seems like the focus ring should really be a property of the view and should not
be instantiated by different controls all over the place.

That for a later patchset.

BUG=665412, 656198
TEST=Covered by test ViewObserverTest.ScrollViewChildAddLayerTest and ViewObserverTest.ChildViewLayerNotificationTest

Review-Url: https://codereview.chromium.org/2813353002
Cr-Commit-Position: refs/heads/master@{#465720}

BUG=713201
TBR=mkolom@yandex-team.ru, creis@chromium.org, sky@chromium.org, dgozman@chromium.org

Review-Url: https://codereview.chromium.org/2829773002
Cr-Commit-Position: refs/heads/master@{#465719}

https://chromium.googlesource.com/angle/angle.git/+log/b36e539..b812669

BUG=

TBR=geofflang@chromium.org

TEST=bots

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2832583002
Cr-Commit-Position: refs/heads/master@{#465718}

Retry request upon receiving a GOAWAY frame with error code NO_ERROR
and with Last-Stream-ID lower than stream id corresponding to request.

BUG=681477

Review-Url: https://codereview.chromium.org/2820163004
Cr-Commit-Position: refs/heads/master@{#465717}

This change finishes support for AX_ACTION_HIT_TEST in AXHostDelegate
so that you can send a hit test request on the root of the whole automation
tree and get a hit test on either views or web content.

Switches Select-to-speak to use this new API.  A follow-up change will
change the way select-to-speak works so that it sends the mouse event
to the extension and the hit test comes from there, but this is a
self-contained change that can land first.

BUG=699617

Review-Url: https://codereview.chromium.org/2813083003
Cr-Commit-Position: refs/heads/master@{#465716}

The three chrome help URL constants incorrectly used OFFICIAL_BUILD
for a feature that should only be in Google-branded builds.

BUG=none
TEST=Build browser with is_official_build=true and target_os=chromeos. Click the help button in the system menu, verify it shows a support.google.com URL instead of the genius app.

Review-Url: https://codereview.chromium.org/2825513002
Cr-Commit-Position: refs/heads/master@{#465715}

BUG=678663,703441

Review-Url: https://codereview.chromium.org/2819273005
Cr-Commit-Position: refs/heads/master@{#465714}

This reverts commit 1e2d5ea4.

BUG=705135

Reason: Bot came back online
Review-Url: https://codereview.chromium.org/2831693002
Cr-Commit-Position: refs/heads/master@{#465713}

BUG=712479

Review-Url: https://codereview.chromium.org/2825493005
Cr-Commit-Position: refs/heads/master@{#465712}

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/121ef2b4a8c6..6939b1db033b

$ git log 121ef2b4a..6939b1db0 --date=short --no-merges --format='%ad %ae %s'
2017-04-19 simonhatch Dashboard - Filter NaN values in /graph_json and /graph_revisions.
2017-04-19 kainino Mac: download numpy and cv2 from Cloud Storage

Created with:
  roll-dep src/third_party/catapult
BUG=711307


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=sullivan@chromium.org

Change-Id: Id2d7bc9cf780f8e0f6d9a78e5118fd5aff8ea955
Reviewed-on: https://chromium-review.googlesource.com/482179
Reviewed-by: <catapult-deps-roller@chromium.org>
Commit-Queue: <catapult-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#465711}

virtual/sharedarraybuffer/fast/css/fontfaceset-check-platform-fonts.html
is flaky on Windows.

BUG=713094
TBR=ksakamoto

Review-Url: https://codereview.chromium.org/2832593002
Cr-Commit-Position: refs/heads/master@{#465710}

Revert of Disable flaky WebNavigationApiTest.CrossProcessHistory. (patchset #1 id:1 of https://codereview.chromium.org/2790383002/ )

Reason for revert:
What I believe was the underlying issue has been reverted, so it should be safe to reenable this test back.

Original issue's description:
> Disable flaky WebNavigationApiTest.CrossProcessHistory.
>
> TBR=nasko@chromium.org
> BUG=708139
>
> Review-Url: https://codereview.chromium.org/2790383002
> Cr-Commit-Position: refs/heads/master@{#461690}
> Committed: https://chromium.googlesource.com/chromium/src/+/656fccff69eae8da012f0f83bcd3fc89214c5258

TBR=maxmorin@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=708139

Review-Url: https://codereview.chromium.org/2830813002
Cr-Commit-Position: refs/heads/master@{#465709}

If item get removed from the content pane, the buttons should always
remain at the bottom.

BUG=712539
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2833533002
Cr-Commit-Position: refs/heads/master@{#465708}

This also renames the JS<->C++ API; C++ does not need to know about pin.

BUG=623344
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2814863002
Cr-Commit-Position: refs/heads/master@{#465707}

Displays a PaymentMethodItem in the credit card form in order to identify
the server card being edited.

http://imgur.com/a/CM38f

BUG=602666

Review-Url: https://codereview.chromium.org/2826593005
Cr-Commit-Position: refs/heads/master@{#465706}

Revert of [Mac] Support for Touch Bar Customization (patchset #8 id:180001 of https://codereview.chromium.org/2814683005/ )

Reason for revert:
Broke the 10.12 build

Original issue's description:
> [Mac] Support for Touch Bar Customization
>
> Implement customization support for the default touch
> bar. Changed the item identifiers to reverse-DNS style format.
>
> BUG=710100
>
> Review-Url: https://codereview.chromium.org/2814683005
> Cr-Commit-Position: refs/heads/master@{#464967}
> Committed: https://chromium.googlesource.com/chromium/src/+/1ad3c00f56fbf19ecba52bdf0591ca7ad1098d3a

TBR=rsesek@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=710100

Review-Url: https://codereview.chromium.org/2831713002
Cr-Commit-Position: refs/heads/master@{#465705}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/e6777487..bde4f053

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2830753002
Cr-Commit-Position: refs/heads/master@{#465704}

BUG=

Review-Url: https://codereview.chromium.org/2825333003
Cr-Commit-Position: refs/heads/master@{#465703}

I only saw this crash once, and can't reproduce, but better safe than sorry.

BUG=712823

Review-Url: https://codereview.chromium.org/2830463002
Cr-Commit-Position: refs/heads/master@{#465702}

BUG=657826,657825
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2778223005
Cr-Commit-Position: refs/heads/master@{#465701}

Adding all sources to a "_all" pseudo module fixes Studio's code analysis
functions (imports, refactoring).

In order to have things build properly in gradle, the "_all" module has
all sources excluded (gradle applies the filters, studio does not).

Also fix "--all" targets to include tests. Make it easier to make sweeping
java refactors in Android Studio.

BUG=620034

Review-Url: https://codereview.chromium.org/2812133003
Cr-Commit-Position: refs/heads/master@{#465700}

The spec calls this CanvasPath. Renaming to sync with spec.

BUG=708195

Review-Url: https://codereview.chromium.org/2826773002
Cr-Commit-Position: refs/heads/master@{#465699}

Before this patch, calling e.updateWith(new Promise((resolve) => {}));
would result in 'shippingoptionchange' and 'shippingaddresschange' never
timing out. This is because the timeout timer was being stopped in
updateWith() call.

The fix is to stop the timeout timer when the resolve() callback is
invoked instead of when updateWith() is called.

After this patch, calling e.updateWith(new Promise((resolve) => {}));
will timeout after 60 seconds.

To test manually:
1) Open https://rsolomakhin.github.io/pr/ko/promise/.
2) Click [Buy].
3) Change the shipping address or option.
Observe: The UI closes and the page shows an error message after 60
         seconds.

The error message has been made more verbose as well: "Timed out waiting
for a response to a 'shippingaddresschange' event".

BUG=711691
TEST=PaymentRequestUpdateEventTest

Review-Url: https://codereview.chromium.org/2823393002
Cr-Commit-Position: refs/heads/master@{#465698}

Before this patch, calling PaymentRequest.abort() would reject the
PaymentRequest.show() promise with a message "DOMException: The user
aborted a request." This is misleading, because it is the merchant
that's initiating the abort.

The fix is to change the message to "The website has aborted the
payment."

BUG=713206

Review-Url: https://codereview.chromium.org/2825333004
Cr-Commit-Position: refs/heads/master@{#465697}

Build: https://build.chromium.org/p/chromium.infra.cron/builders/rebaseline-o-matic/builds/667321

https://chromium.googlesource.com/chromium/src/+/3596d8b9d1ada

BUG=709846
TBR=chrishtr@chromium.org

Review-Url: https://codereview.chromium.org/2831723002 .
Cr-Commit-Position: refs/heads/master@{#465696}

(1) refactor PaswordProtectionRequest to be RefCountedThreadSafe,
(2) use CancelableTaskTracker in PasswordProtectionRequest to make
    sure tasks posted on IO thread can be canceled correctly upon
    destructing PasswordProtectionService,
(3) Add the skeleton of PasswordProtectionFrame struct, which will be
    used to communicate password form information between
    ChromePasswordManagerClient and PasswordProtectionService

BUG=698899

Review-Url: https://codereview.chromium.org/2817533004
Cr-Commit-Position: refs/heads/master@{#465695}

Before this patch, if the merchant website never calls
PaymentResponse.complete(), then the UI shows a generic error dialog to
the user and aborts payment, but nothing indicates to the web developer
that it was a timeout that causes the closing of the web payment UI.

The fix is to add a console error message "Timed out waiting for a
PaymentResponse.complete() call" when the timer expires.

After this patch, the console error message will indicate to the web
developer that it was a timeout that causes the closing of the web
payment UI.

To test manually:
1) Open https://rsolomakhin.github.io/pr/ko/complete/.
2) Click [Buy] on the page.
3) Click [Pay] in the web payment UI.
Observe: Console prints an error message after 60 seconds.

BUG=711027

Review-Url: https://codereview.chromium.org/2827963002
Cr-Commit-Position: refs/heads/master@{#465694}

I really don't know enough about that code anymore to still be doing
owners reviews.

BUG=None

Review-Url: https://codereview.chromium.org/2829753002
Cr-Commit-Position: refs/heads/master@{#465693}

Reland https://codereview.chromium.org/2796533002 with synchronization with
child frame navigation.

When advancing focus into an iframe, allow the frame to focus itself
after deciding which element will be focused. This prevents sending a
focus event to the previous element in that frame only to blur it
immediately. Non-oopifs simply fire a focus event to the new element,
the previously focused element in that frame received a blur event when
another frame was focused.

The test ensures a consistent state when mixing tab and clicking
navigation. In specific cases, focus would early out when the element to
advance to was previously focused, and never cleared when the mouse is
clicked in another frame.

BUG=702330
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2833503002
Cr-Commit-Position: refs/heads/master@{#465692}

BUG=713138

Review-Url: https://codereview.chromium.org/2824413002
Cr-Commit-Position: refs/heads/master@{#465691}

I noticed that NextToken() had a bunch of code doing:

  if (IsASCIIUpper(c)) {
    doStuff(ToLowerCase(c));
  } else if (IsASCIILower(c)) {
    doStuff(c);
  }

Since lowercasing is done by just setting the 0x20 bit, we can fold it into the
range check and always lowercase:

  if (IsASCIIAlpha(c)) {
    doStuff(ToLowerCase(c));
  }

This actually brings the code closer to the tokenization spec which for these
states does not separate between upper- and lower-case inputs.

I tried to measure the performance of this by modifying
PerformanceTests/resources/runner.js to run 1000 iterations and running the
html-parser.html test:

$ tools/perf/run_benchmark run blink_perf.parser \
  --story-filter=html-parser.html \
  --browser-executable=/work/chromium/src/out/release/content_shell

However I could see no change in performance.

Without my change:

avg 379.1670899999993 ms
median 381.46249999999054 ms
stdev 45.56871307699382 ms
min 253.66499999997905 ms
max 1199.0950000000007 ms

With my change:

avg 376.9821549999998 ms
median 381.8125 ms
stdev 42.23547601324007 ms
min 254.27000000000407 ms
max 1127.37 ms

This does remove ~100 lines of code and shave ~1 KB off the object file size
which is always something. And it should be faster, really.

BUG=none

Review-Url: https://codereview.chromium.org/2827653003
Cr-Commit-Position: refs/heads/master@{#465690}