- 22 Oct, 2019 40 commits
-
-
Avery Musbach authored
Change-Id: I32d5c3e30be0ea43aeb75acd8cba35a5566a2119 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872426Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Avery Musbach <amusbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#708422}
-
Peter Boström authored
Replaces OnAnchorBoundsChanged calls, these were not called due to anchor changes. Bug: None Change-Id: I26988ca55b019e0504e54fd0f37af45309b9b25b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1874712 Commit-Queue: Peter Boström <pbos@chromium.org> Commit-Queue: Tommy Steimel <steimel@chromium.org> Auto-Submit: Peter Boström <pbos@chromium.org> Reviewed-by:
Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#708421}
-
Anupam Snigdha authored
This change adds mechanism to control the software input panel on Windows using TSF input panel policy. It triggers the input panel through a policy that is set in TSF status flag based on whether user has interacted with the page or not. It uses the existing TextInput state object to get that information. This is also a step towards removing the TryShow/TryHide API calls which uses a legacy IPC message and also don't work properly on some Windows touch devices such as Surface Book. TryShow/TryHide input pane API calls cannot co-exist with TSF input panel policy as it leads to a race condition in input service that decides when to raise the virtual keyboard which sometimes results in flickering of input panels. Test: ui\base\ime\win\tsf_input_policy_unittest.cc Bug: 1014365 Change-Id: I598a15bd16a90f578fbfc62fd06ef0c5724b243d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1862860Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Yohei Yukawa <yukawa@chromium.org> Commit-Queue: Anupam Snigdha <snianu@microsoft.com> Cr-Commit-Position: refs/heads/master@{#708420}
-
Istiaque Ahmed authored
These are used to monitor extension resource request read stats, hence extend these by one more year. Following three UMAs were change in this CL: ExtensionUrlRequest.Latency .SeekPosition .TotalKbRead Bug: 1016408 Change-Id: I61246cb38003e5cffab20fb9366477c10cd9a01c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1873086Reviewed-by:Ilya Sherman <isherman@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Ilya Sherman <isherman@chromium.org> Commit-Queue: Istiaque Ahmed <lazyboy@chromium.org> Cr-Commit-Position: refs/heads/master@{#708419}
-
Steven Bennetts authored
This also fixes a bug in AutoConnectNotifierTest, which has been "flaky" but failing consistently for quite a while now. For trivial removal of extra include in ash_test_helper.cc: TBR=jamescook@chromium.org Bug: 1015493 Change-Id: I50ed1f11c39c7385888ae4b310d686fbe4f38a63 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864626 Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#708418}
-
Emircan Uysaler authored
Bug: 1016958 Change-Id: I7d918b17cd8b6d6b0b0d8a471087d44e5af11d65 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872487Reviewed-by:
Wez <wez@chromium.org> Commit-Queue: Wez <wez@chromium.org> Commit-Queue: Emircan Uysaler <emircan@chromium.org> Cr-Commit-Position: refs/heads/master@{#708417}
-
Will Harris authored
This reverts commit 76f496a7. Reason for revert: decided to take a different approach https://chromium-review.googlesource.com/c/chromium/src/+/1872475 fixes this in a better way, that doesn't rely on oscrypt behavior. Original change's description: > Tolerate setting same os_crypt key twice in the same process. > > Setting the same key twice is allowed but a different key is still > something that should never happen. > > This permits service such as network process to run in-process > and also fixes --single-process mode. > > BUG=1000799,1016384 > > Change-Id: I9da8221adc763d1188b64589dafedeee866d585f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872155 > Reviewed-by: Christos Froussios <cfroussios@chromium.org> > Commit-Queue: Will Harris <wfh@chromium.org> > Cr-Commit-Position: refs/heads/master@{#707865} TBR=wfh@chromium.org,cfroussios@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1000799, 1016384 Change-Id: I572d066180a2d2438732072c6806e21cddfacdbb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1874612 Commit-Queue: Will Harris <wfh@chromium.org> Reviewed-by:
Will Harris <wfh@chromium.org> Cr-Commit-Position: refs/heads/master@{#708416}
-
Istiaque Ahmed authored
These are histograms that reflect generic health stats of extension content verification. Extend these by one more year. The following seven umas were changed: Extensions.ContentVerification.ComputedHashesInitTime .ComputedHashesReadResult .FetchResult .ReadContentHashTime .VerifiedContentsInitResult .VerifiedContentsInitTime ExtensionContentVerifyJob.TimeSpentUS Bug: 1016402, 1016416, 1016406 Change-Id: Ie610257d34121ff9d660e5f6896ef2752ef6bb7e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872771 Commit-Queue: Istiaque Ahmed <lazyboy@chromium.org> Commit-Queue: Ilya Sherman <isherman@chromium.org> Reviewed-by: -
Hans Wennborg authored
This reverts commit 95f797d6. Reason for revert: It broke some tests in official builds, see bug. Original change's description: > CHECK that CommitNavigation/CommitFailedNavigation IPCs always commit. > > Currently, state synchronization between the browser and the renderer > process is complicated and buggy for cross-process navigations. The > renderer process is responsible for processing the commit IPC and then > reporting success back up to the browser process, which then updates its > state. However, it's unclear if this can lead to races. > > Instead, if it is possible to assume that one CommitNavigation() IPC > from the browser always maps to one committed navigation in the > renderer, the code can be simplified to remove multiphase navigation > commits. This means the browser would be able to mark a provisional > local frame as committed as soon as it sends a commit IPC to the > renderer for that frame. > > Bug: 999255 > Change-Id: I7d58293e6c2ec6ca0d09b614ae5a41340f4afd8e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1775663 > Commit-Queue: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: danakj <danakj@chromium.org> > Reviewed-by: Nasko Oskov <nasko@chromium.org> > Reviewed-by: Camille Lamy <clamy@chromium.org> > Cr-Commit-Position: refs/heads/master@{#705414} TBR=danakj@chromium.org,dcheng@chromium.org,nasko@chromium.org,clamy@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 999255,1014903 Change-Id: I9b5429c66a47e1a180ba2ff82059fe596d7f0b79 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1874575Reviewed-by:
Hans Wennborg <hans@chromium.org> Commit-Queue: Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#708414}
-
Owen Min authored
Rename ChromeBrowserCloudManagementController ::IsMachineLevelUserCloudPolicyEnabled to ChromeBrowserCloudManagementController ::IsEnabled Use a shorter name to avoid repetition. Bug: 1010704 Change-Id: If6808b2687099c09edd20a3161c7144875ba5a7e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865407Reviewed-by:
Daniel Rubery <drubery@chromium.org> Reviewed-by:
Roger Tawa <rogerta@chromium.org> Commit-Queue: Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#708413}
-
Rahul Arakeri authored
This fixes an issue when scroll deltas for arrow clicks, shift+click and autoscrolling was improperly scaled. The fix here is to use the painted_device_scale_factor (when use-zoom-for-dsf is true). As a part of this change, 2 VirtualTestSuites have also been introduced. One of them runs the new tests with DSF=2 on the main thread and the other one on the cc thread. New test had to be added because the scroll offsets when DSF=2 (and use-zoom-for-dsf=true) are different compared to offsets when DSF=1 (and use-zoom-for-dsf=true) both in case of main and cc scrollbars in some cases (eg: shift+click). Bug: 1007875 Change-Id: Ib4fbad3004f0ef503420ada6b701432798ec7265 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1848792 Commit-Queue: Rahul Arakeri <arakeri@microsoft.com> Reviewed-by:
David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#708412}
-
Will Harris authored
BUG=1016384 Change-Id: I1abcc4ccf7e388f81f3ba191700b81bac47c3473 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872475Reviewed-by:
Eric Roman <eroman@chromium.org> Commit-Queue: Will Harris <wfh@chromium.org> Cr-Commit-Position: refs/heads/master@{#708411}
-
Matt Menke authored
Also move all tests of the method as well, and merge the fuzzers of URLRequestDataJob and DataURL::Parser. This is in preparation to remove URLRequestDataJob, which is only used in tests (And those tests are only still around to test URLRequestDataJob::BuildResponse()). This test also adds a couple test cases to DataURL unit tests, since that doesn't really seem worth a seprate CL, but noticed some cases could be covered a bit better as I was moving stuff. Bug: 934009 Change-Id: I4025e77e0bde27a271ed32c0d274b0e24604e842 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869539 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/33678af88db3..05691ddbd2bc git log 33678af88db3..05691ddbd2bc --date=short --no-merges --format='%ad %ae %s' 2019-10-22 mbonadei@webrtc.org Add possibility to skip check_includes presubmit check. Created with: gclient setdep -r src/third_party/webrtc@05691ddbd2bc If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: None Change-Id: I017539003e08a9d51d62465ca5b7566b77a69a1f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1874498Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#708409}
-
arthursonzogni authored
The test was given web_ui capabilities to the URL: "http://privileged". This doesn't correctly reflect the reality. WebUI URL have the "chrome" scheme, not "http". As a side effect, this test is now passing when the back-forward cache is enabled. Only HTTP/HTTPS URL are allowed to enter the back-forward cache. It was previously failing, because the page was loaded with the WebUI capabilities, and the test was expecting the capabilities not to be set when navigating back to it. Since it was the same RenderFrameHost in both case, it was failing. Bug: 511340 Change-Id: Ie371e2e6a894e0074b451ec53168e8500fea4145 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1860032 Commit-Queue: Nasko Oskov <nasko@chromium.org> Auto-Submit: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#708408}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/44d038359f4e..c0e6e7a631e7 git log 44d038359f4e..c0e6e7a631e7 --date=short --no-merges --format='%ad %ae %s' 2019-10-22 thestig@chromium.org Implement pdf_nametree_fuzzer. 2019-10-19 dhoss@chromium.org Replace instances of Optional<>() with pdfium::nullopt 2019-10-19 dhoss@chromium.org Implement WideString::ReverseFind() Created with: gclient setdep -r src/third_party/pdfium@c0e6e7a631e7 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pdfium-autoroll Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=pdfium-deps-rolls@chromium.org Bug: None Change-Id: I739f7056d1874c9562bf2369038a5e0ed3d33a59 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1874497Reviewed-by:
-
Scott Violet authored
Functions that are called by native can be declared as throwing RemoteException. BUG=none TEST=none Change-Id: Ie2d14525ec9dacbda06fff5ac2777d8f05a10c34 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872474Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#708406}
-
Rafael Cintron authored
Now that all of the work on the Chromium and Dawn side to support Windows has been complete, we need to add WebGPU to about:flags on Windows. Bug: 966580 Change-Id: I41d9f892be0d849c5ece1d5569f98344a7a92a1e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1873383Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Commit-Queue: Rafael Cintron <rafael.cintron@microsoft.com> Cr-Commit-Position: refs/heads/master@{#708405}
-
Yuwei Huang authored
Token upgrader does not work on hosts registered with non-robot account and new API server does not handle heartbeat without a robot account, so this CL removes code in remoting_me2me_host.cc that handles non-robot account. Bug: 987383 Change-Id: Ida49880e1f5458472c8b6c983df6c1fe4ef0ab3d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872726Reviewed-by:
Jamie Walch <jamiewalch@chromium.org> Commit-Queue: Yuwei Huang <yuweih@chromium.org> Auto-Submit: Yuwei Huang <yuweih@chromium.org> Cr-Commit-Position: refs/heads/master@{#708404}
-
Klaus Weidner authored
The runtime_manager_->GetImmersiveRuntime() call only returned a VR runtime, ignoring AR runtimes such as ARCore for immersive-ar. However, various code locations were using it in ways that suggest they expect it to be the currently-active runtime. Rename GetImmersiveRuntime to GetImmersiveVrRuntime, add a separate GetImmersiveArRuntime function, and GetCurrentlyPresentingImmersiveRuntime that returns either the VR or AR runtime if active, or nullptr if none is presenting. (This is different from GetImmersiveVrRuntime which returns the VR runtime even when that's not presenting.) Also rename BrowserXRRuntime methods: GetPresentingVRService => GetServiceWithActiveImmersiveSession, ExitVrFromPresentingService => ExitActiveImmersiveSession Change-Id: I241870a69034dccc1a908fe89ced2a90a8751b1f Bug: 1014159 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865043 Commit-Queue: Klaus Weidner <klausw@chromium.org> Reviewed-by:
Alexander Cooper <alcooper@chromium.org> Reviewed-by:
Piotr Bialecki <bialpio@chromium.org> Cr-Commit-Position: refs/heads/master@{#708403}
-
Scott Violet authored
I only added this to the public API as that is the important part. BUG=none TEST=none Change-Id: I2369ea07fcac9e3bb87632f6235f11e37d5283a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1874587 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
-
Jay Harris authored
This is necessary so observers know when to remove themselves, as they might otherwise attempt to remove themselves after the ShortcutManager has been destroyed, resulting in a use after free. Bug: 860581 Change-Id: I93f0d4020efdc5633462c8066b47a0a98922e373 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872083Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Commit-Queue: Jay Harris <harrisjay@chromium.org> Cr-Commit-Position: refs/heads/master@{#708401}
-
Josh Simmons authored
This is unneeded. Bug: 1013380 Test: Built and fetched hints on device. Change-Id: I9f7d3fbfc15d199e14d6c760dfe3d0fb41363ba2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1873344Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Josh Simmons <jds@google.com> Cr-Commit-Position: refs/heads/master@{#708400}
-
Tom Anderson authored
BUG=1016035 R=dalecurtis Change-Id: I3c12fe8c339ab326d910699739e289b5e9aaa343 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872724 Auto-Submit: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#708399}
-
Quinten Yearsley authored
Buildbot is dead; this is meant to be the first of several CLs to clean up related code in blinkpy. Notes about changes here: - --build-name doesn't appear to be used anywhere - step name is usually not webkit_tests in practice - I don't know exactly how --master-name is used now but it's definitely not actually Buildbot master name now. Bug: 1002702 Change-Id: I318d6149b81609c100d5475ea35de0378fd094f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872917 Commit-Queue: Quinten Yearsley <qyearsley@chromium.org> Reviewed-by:
Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#708398}
-
Ted Meyer authored
A floating message box that looks like this: https://files.tedm.io/popup.png Bug: 794255 Change-Id: Icf73a6c1d92f96b61f27329bf02e4391a03209c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1873345 Commit-Queue: Ted Meyer <tmathmeyer@chromium.org> Reviewed-by:
-
Steven Bennetts authored
This is similar to: https://chromium-review.googlesource.com/c/chromium/src/+/1836178 Except for Service properties instead of Device properties. The problem was found in: https://chromium-review.googlesource.com/c/chromium/src/+/1864626 Ths probably only affects tests, but in theory there could be an edge case on devices as well. Bug: 1015493 Change-Id: I93987961596b3fba7cb8c7c4f7fde5c0b44ea738 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1873381Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/dd075112b8d6..6e9cdb62e782 git log dd075112b8d6..6e9cdb62e782 --date=short --no-merges --format='%ad %ae %s' 2019-10-22 xiyuan@google.com chrome_util: Ensures to-be-copied dirs end with '/' 2019-10-22 dburger@chromium.org Don't run unit tests for grunt-kernelnext-paladin. Created with: gclient setdep -r src/third_party/chromite@6e9cdb62e782 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I3adac69a081f1cb1a37b7c6f67cdd87aa4374d48 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1874494Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/443f286e0cca..bef344f7017f git log 443f286e0cca..bef344f7017f --date=short --no-merges --format='%ad %ae %s' 2019-10-22 perezju@chromium.org [Telemetry] Fix TODO in story_runner_unittest.py Created with: gclient setdep -r src/third_party/catapult@bef344f7017f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC rmhasan@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=rmhasan@google.com Bug: chromium:1008852 Change-Id: I7b50e6af116558a4dacfa187d75aace8e6d716a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1874496Reviewed-by:
-
Alex Newcomer authored
Noticed this laying around. Change-Id: Ie609d1fbb2c2a73e64f063ed3b094c287e64c446 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872793Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/heads/master@{#708393}
-
Alex Newcomer authored
Just noticed this laying around, might aswell remove it. Change-Id: I24f7df5c675902484bc9143f231820f3b9304311 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872792Reviewed-by:
-
Luke Halliwell authored
Fixed: 1016414 Change-Id: Iaf0b71ed1bdae5f8e10391c2338f91bfac8f78b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872766 Auto-Submit: Luke Halliwell <halliwell@chromium.org> Reviewed-by:
-
Toni Barzic authored
Fixes the test when hotseat is enabled - the issue was that the app list layout changes when the first test window is created (because the shelf height changes), and the expected apps grid bounds were calculated before a test window existed. BUG=1016822 Change-Id: I88881ac6b5ecf0a5b3bd02c222632d5faaf72517 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1873988Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Commit-Queue: Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#708390}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/78150fbefe75..8e8e4f75129b Created with: gclient setdep -r src-internal@8e8e4f75129b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: Id140d6a5ec5a6195d1a48a733222f9ea8601373f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1874495Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#708389}
-
Ryan Sturm authored
Currently, we are blocked on Load Event, but we should move to x seconds after commit instead. Bug: 1016553 Change-Id: Ic1ec95fd543e0b50a4541a7d860b1ce40baae2d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872423 Commit-Queue: Ryan Sturm <ryansturm@chromium.org> Reviewed-by:
Robert Ogden <robertogden@chromium.org> Cr-Commit-Position: refs/heads/master@{#708388}
-
Chris Mumford authored
This change switches from using testing::CreateFunctor when calling testing::Invoke() to a C++ lambda. This improves test readibility and makes easier an upcoming changes to gmock_mutant.h (switch away from base::Bind()). Bug: 1007833, 806952 Change-Id: I1473a6041e0aedbc0b6f8eb212ebb918742bc7c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872815Reviewed-by:
Dan Sanders <sandersd@chromium.org> Commit-Queue: Chris Mumford <cmumford@google.com> Cr-Commit-Position: refs/heads/master@{#708387}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/9122bec28506..be1fa7d8cddf git log 9122bec28506..be1fa7d8cddf --date=short --no-merges --format='%ad %ae %s' 2019-10-22 tobine@google.com Vulkan: Enable VK_EXT_line_rasterization Created with: gclient setdep -r src/third_party/angle@be1fa7d8cddf If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jonahr@google.com Bug: None Change-Id: I73828185c6dcb1b631689ed0a954e06f526189fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1874493Reviewed-by:
-
Nick Harper authored
Change-Id: Ia154142e6a5014965da9220d5cc90367b811740c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1873990 Commit-Queue: Nick Harper <nharper@chromium.org> Auto-Submit: Nick Harper <nharper@chromium.org> Reviewed-by:
Renjie Tang <renjietang@chromium.org> Cr-Commit-Position: refs/heads/master@{#708385}
-
siyua authored
It was missed in the original CL Bug: 964127 Change-Id: I836cd53f502c354f38cf074866a54d13d7e13419 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869540Reviewed-by:
Peter Boström <pbos@chromium.org> Commit-Queue: Siyu An <siyua@chromium.org> Cr-Commit-Position: refs/heads/master@{#708384}
-
Tom Anderson authored
Shared memory segments created with shmget(..., 0600) only allows rooted processes to attach to the segment. In situations where X11 is running rootless, like with unetbootin, additional permissions are required for the segment. This CL changes the permissions to 0606 to fix this issue. This fixes WPT failures to unblock then from upgrading Chrome to M79. BUG=1014629 R=rjkroege CC=smcgruer Change-Id: Ib28ebd06e6bcc58d7d84cf5c195101ac255f2a8a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872948 Auto-Submit: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#708383}
-
