GitLab

These tests are failing since the MS 2008 - 2010 switch.  Turning them off to make the tree green until someone takes the bug and figures out how to fix it.

BUG=132133
TEST=gpu win release bots
TBR=nduca
Review URL: https://chromiumcodereview.appspot.com/10540111

TBR=zmo@google.com
Review URL: https://chromiumcodereview.appspot.com/10704161

TBR=jbates@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10695160

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146210 0039d316-1c4b-4281-b951-d872f2087c98

Revert 146192 - Revert 146164 - Always query for the latest RenderViewHost from WebContents before sending the NOtBlacklistedMessage, since RenderViewHost can be changed if users navigate to a different site. We have seen crashes (highly possibly) because of this (http://code.google.com/p/chromium/issues/detail?id=134191)


BUG=134191
TEST=PasswordFormManagerTest

Review URL: https://chromiumcodereview.appspot.com/10704147

TBR=zysxqn@google.com
Review URL: https://chromiumcodereview.appspot.com/10696177

TBR=michaeln@google.com
Review URL: https://chromiumcodereview.appspot.com/10701145

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146206 0039d316-1c4b-4281-b951-d872f2087c98

The Inner class was being leaked because it was marked DeleteOnUIThread, but the last reference is released after the UI message loop goes away. So I removed that trait.

BUG=133449
TEST=no

Review URL: https://chromiumcodereview.appspot.com/10695130

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146205 0039d316-1c4b-4281-b951-d872f2087c98

Now UpdateCacheWithSubDirectoryType() is trivial enough (it used to be bigger)
to be gone.

BUG=136625
TEST=out/Release/unit_tests --gtest_filter=GData*

Review URL: https://chromiumcodereview.appspot.com/10692171

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146203 0039d316-1c4b-4281-b951-d872f2087c98

BUG=127222
TEST=manual test.


Review URL: https://chromiumcodereview.appspot.com/10444049

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146202 0039d316-1c4b-4281-b951-d872f2087c98

Modify ppapi/generators/idl_parser.py to
0: not require a file-level comment (but generate the same parse tree structure),
1: actually support ext_attrs (modifiers) for dictionaries, and
2: support [ext_attr=(symbols|values)].

Modify json_schema_compiler to
0: use "base::Value" and any_helper.ANY_CLASS instead of Value and Any in order to support ArrayBuffers named |value| or |any|,
1: actually test that namespaces and dictionaries are sorted correctly,
2: fix HGenerator._FieldDependencyOrder(),
3: support [inline_doc] on dictionaries and enums,
4: support descriptions on enums,
5: support documentation_permissions_required,
6: support [legalValues=(values...)].

Review URL: https://chromiumcodereview.appspot.com/10639020

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146201 0039d316-1c4b-4281-b951-d872f2087c98

If an account with hosts registered is accessed on a machine on which those hosts are cached, then the host list should not display the "no hosts" icon while the host list is being refreshed. This CL fixes a bug related to the asynchronous nature of getting the local host id for the purpose of filtering it from the host list, which caused the cached host list never to be displayed.

Note that if the account has hosts registered, but is accessed from a computer with no cache, then the "no hosts" icon will still flash briefly (although it will generally be hidden behind the infographic).

BUG=135288
TEST=Manual

Review URL: https://chromiumcodereview.appspot.com/10736020

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146200 0039d316-1c4b-4281-b951-d872f2087c98

When this is enabled for windows, we stop getting crash reports.
See https://code.google.com/p/chromium/issues/detail?id=135480

BUG=135480
TEST=


Review URL: https://chromiumcodereview.appspot.com/10736039

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146199 0039d316-1c4b-4281-b951-d872f2087c98

BUG=99330
TEST=Under opaque theme, resize window really small. The minimum width shouldn't cause tabstrip elements to be cutoff.

Review URL: https://chromiumcodereview.appspot.com/8172010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146197 0039d316-1c4b-4281-b951-d872f2087c98

BUG=134017, 117261
TEST=


Review URL: https://chromiumcodereview.appspot.com/10626007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146196 0039d316-1c4b-4281-b951-d872f2087c98

It is still possible to focus these buttons using tab, so this does not regress accessibility.

BUG=136872
TEST=none

Review URL: https://chromiumcodereview.appspot.com/10694139

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146195 0039d316-1c4b-4281-b951-d872f2087c98

BUG=134917
TEST=nothing yet.
TBR=dhollowa

Review URL: https://chromiumcodereview.appspot.com/10703148

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146194 0039d316-1c4b-4281-b951-d872f2087c98

TEST=added
BUG=132616


Review URL: https://chromiumcodereview.appspot.com/10759006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146193 0039d316-1c4b-4281-b951-d872f2087c98

Revert 146164 - Always query for the latest RenderViewHost from WebContents before sending the NOtBlacklistedMessage, since RenderViewHost can be changed if users navigate to a different site. We have seen crashes (highly possibly) because of this (http://code.google.com/p/chromium/issues/detail?id=134191)


BUG=134191
TEST=PasswordFormManagerTest

Review URL: https://chromiumcodereview.appspot.com/10704147

TBR=zysxqn@google.com
Review URL: https://chromiumcodereview.appspot.com/10696177

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146192 0039d316-1c4b-4281-b951-d872f2087c98

Previously this function takes a DocumentEntry* pointer obtained from UploadFileInfo.
This implicitly requires caller to keep the DocumentEntry object (or the UploadFileInfo
struct) alive until the call is complete.

Changing this argument to a scoped pointer makes ownership transfer explicit.

BUG=none
TEST=unit_tests (GData*), lumpy

Review URL: https://chromiumcodereview.appspot.com/10735059

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146190 0039d316-1c4b-4281-b951-d872f2087c98

These result in compiler warnings with -Wsequence-point

BUG=136625
TEST=out/Release/unit_tests --gtest_filter=GData*

Review URL: https://chromiumcodereview.appspot.com/10702154

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146189 0039d316-1c4b-4281-b951-d872f2087c98

Details in bug.

TBR=kkania@chromium.org
BUG=136875
TEST=

Review URL: https://chromiumcodereview.appspot.com/10704162

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146188 0039d316-1c4b-4281-b951-d872f2087c98

TBR=dyu@chromium.org
BUG=136875
TEST=

Review URL: https://chromiumcodereview.appspot.com/10702153

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146187 0039d316-1c4b-4281-b951-d872f2087c98

BUG=126093
TEST=Unit test, manual testing.


Review URL: https://chromiumcodereview.appspot.com/10636019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146186 0039d316-1c4b-4281-b951-d872f2087c98

These should belong to CacheEntry as non-static member functions.

BUG=136625
TEST=out/Release/unit_tests --gtest_filter=GData*

Review URL: https://chromiumcodereview.appspot.com/10692154

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146183 0039d316-1c4b-4281-b951-d872f2087c98

Remove browser::FindTabbedBrowser call in bookmark_utils.cc. All callers, with the exception of metro-specific code, already have a navigator. By moving the browser::FindTabbedBrowser call there, it's clear that in that spot we need to use the metro-specific context.

BUG=129187
Review URL: https://chromiumcodereview.appspot.com/10692164

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146182 0039d316-1c4b-4281-b951-d872f2087c98

BUG=NONE
TEST=asan bots are now happy

Review URL: https://chromiumcodereview.appspot.com/10736021

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146181 0039d316-1c4b-4281-b951-d872f2087c98

The underlying issue is that the GR expects individual touch events (one touch per event) while javascript expects composite events (containing information on each touch point in a single event.)

BUG=130205
TEST=


Review URL: https://chromiumcodereview.appspot.com/10702096

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146180 0039d316-1c4b-4281-b951-d872f2087c98

Change GDataCache::UpdateCacheWithSubDirectoryType() and
GDataCacheMetadata::UpdateCache() to take CacheEntry.

This is in preparation for removing IsCache/SetCache/ClearCache*
functions from GDataCache.

BUG=136625
TEST=out/Release/unit_tests --gtest_filter=GData*

Review URL: https://chromiumcodereview.appspot.com/10735049

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146179 0039d316-1c4b-4281-b951-d872f2087c98

The transaction-abort test was flaky in Chromium, fixed by WK90412/r122291. The others were
disabled to allow landing WK89379/r121492 which renamed the tests.

BUG=83226
TEST=browser_tests --gtest_filter='IndexedDBLayoutTest.TransactionTests'


Review URL: https://chromiumcodereview.appspot.com/10736036

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146178 0039d316-1c4b-4281-b951-d872f2087c98

BUG=123998
R=asanka@chromium.org


Review URL: https://chromiumcodereview.appspot.com/10689093

TBR=rdsmith@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10702151

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146177 0039d316-1c4b-4281-b951-d872f2087c98

tiny framework, a few tests of adding key-value pairs, and the mechanism to run
it all and report results.  This won't yet run on the bots.

If this looks good, I'll start adding tests to cover more of the API.

BUG=none
TEST=self


Review URL: https://chromiumcodereview.appspot.com/10575043

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146173 0039d316-1c4b-4281-b951-d872f2087c98

If the path of chromium source is a symbolic link,
os.getcwd() returns the real path but __file__ will include
the symbolic link. It causes gyp failures due to the inconsistency.

BUG=
TEST=


Review URL: https://chromiumcodereview.appspot.com/10692086

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146172 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=None


Review URL: https://chromiumcodereview.appspot.com/10752006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146170 0039d316-1c4b-4281-b951-d872f2087c98

Mihai, might need help landing this. Getting presubmit errors even after a recent sync and a proper build.

Meggin

Review URL: https://chromiumcodereview.appspot.com/10775002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146169 0039d316-1c4b-4281-b951-d872f2087c98

BUG=125875
TEST=manual


Review URL: https://chromiumcodereview.appspot.com/10758015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146167 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=git cl presubmit

Review URL: https://chromiumcodereview.appspot.com/10704150

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146166 0039d316-1c4b-4281-b951-d872f2087c98

BUG=136430
Review URL: https://chromiumcodereview.appspot.com/10736019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146165 0039d316-1c4b-4281-b951-d872f2087c98

Always query for the latest RenderViewHost from WebContents before sending the NOtBlacklistedMessage, since RenderViewHost can be changed if users navigate to a different site. We have seen crashes (highly possibly) because of this (http://code.google.com/p/chromium/issues/detail?id=134191)


BUG=134191
TEST=PasswordFormManagerTest

Review URL: https://chromiumcodereview.appspot.com/10704147

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146164 0039d316-1c4b-4281-b951-d872f2087c98

For context see this thread:
  https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II

TBR=thakis,pkasting,jam

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98

BUG=123998
R=asanka@chromium.org


Review URL: https://chromiumcodereview.appspot.com/10689093

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146162 0039d316-1c4b-4281-b951-d872f2087c98

Update smoke test accordingly.

R=cmp@chromium.org
BUG=
TEST=


Review URL: https://chromiumcodereview.appspot.com/10748009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146159 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none
TBR=sky@chromium.org

Review URL: https://chromiumcodereview.appspot.com/10683005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146157 0039d316-1c4b-4281-b951-d872f2087c98

they pass on beta/stable builds even if the features are restricted to
dev/trunk.

BUG=136629
TEST=no

Review URL: https://chromiumcodereview.appspot.com/10704149

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146156 0039d316-1c4b-4281-b951-d872f2087c98

BUG=136603
TEST=Verify bubble arrow is drawn correctly when arrow location is BOTTOM_LEFT and RIGHT_TOP.


Review URL: https://chromiumcodereview.appspot.com/10689145

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146155 0039d316-1c4b-4281-b951-d872f2087c98