- 06 Nov, 2019 40 commits
-
-
Peter Wen authored
Ran: rm -rf third_party/android_deps/libs/[!O]* tools/android/roll/android_deps/fetch_all.py --update-all According to: https://chromium.googlesource.com/chromium/src/+/HEAD/tools/android/roll/android_deps/README.md Bug: None Change-Id: I7db268ee7871ec77f3ba5c123abbc0eff107c835 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1901907 Commit-Queue: Peter Wen <wnwen@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Auto-Submit: Peter Wen <wnwen@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#713126}
-
Avery Musbach authored
Bug: None Change-Id: Ie13e6aaf370f9428566f8cb3ed7e926776c4d21a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1897006Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Avery Musbach <amusbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#713125}
-
Steven Bennetts authored
This adds support to DataPack to load gzipped .pak.gz files into memory, instead of using mmap to map memory to an uncompressed pak file. The advantage is that .pak files compress by as much as 70% on disk. The disadvantage is that mmapped memory (which is initially resident) can be trivially swapped out when not in use (since it is already backed by a file), whereas allocated memory uses regular swap storage. For Chrome OS this is likely to be a worthwhile tradeoff. Testing shows that fairly minimal use of the Chrome OS UI swaps in most of the file after it is swapped out. See the issue for details. Note: This CL does not implelent compression of .pak files, that will be handled in a follow-up CL. This also removes the unused |test_file_exists| parameter from ResourceBundle::GetLocaleFilePath (it was always set to true). Bug: 1017864 Change-Id: I16eaaf8d294199d8310ec06fedc79dabfb0d27a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1882759 Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#713124}
-
Jazz Xu authored
Bug: 1021681 Change-Id: I2f0b5096a083a9257f075fa46856d6a10951a520 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900326Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: Jazz Xu <jazzhsu@chromium.org> Cr-Commit-Position: refs/heads/master@{#713123}
-
Takumi Fujimoto authored
Use it on the IO thread to be consistent with the DIAL MRP. Change-Id: I51cd4e1bd5129347014e6ddb7d464539a9f682c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900649Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Takumi Fujimoto <takumif@chromium.org> Cr-Commit-Position: refs/heads/master@{#713122}
-
Mohamed Heikal authored
Final android-binary-size trybot message is now simpler and links to doc containing all the needed information about the checks that run and how to get the trybot to pass for your CL. Change-Id: Id4dfd7af7510b89837f74ed5bdd94d737d37ae5d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900304 Commit-Queue: Mohamed Heikal <mheikal@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#713121}
-
Tom Anderson authored
See [1] and [2] for why this is necessary. There are some containerized setups where the X11 socket is shared between host and guest, but /dev/shm is not, meaning usage of the MIT-SHM extension won't work. Rather than libxext providing an environment variable of its own so that all apps could use a uniform interface, toolkits have been adding their own ways of disabling the extension for this use case. QT has QT_X11_NO_MITSHM, the JRE has J2D_USE_MITSHM, and GTK uses a command line flag --no-xshm. This CL adds checks for all of those. [1] https://bugs.chromium.org/p/chromium/issues/detail?id=991633#c11 [2] https://bugs.chromium.org/p/chromium/issues/detail?id=991633#c13 BUG=991633 R=rjkroege TBR=kbr Change-Id: I44792069098eef4617726e831f63e4d9a857530d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900264Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#713120}
-
Ahmed Fakhry authored
The callbacks should be called with a single bool argument. Using the automatically generated Create() functions made them be called with an array of bools instead, which is not what we expect. BUG=1016994 TEST=Run the Tast test and expect it to be able to unmarshall a bool from the callback. Change-Id: I1d89de8ffcd5d78e24a9114a68f1cebb0ad6db4a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900689Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#713119}
-
Eugene But authored
Bug: 1021649 TBR: gambard@chromium.org Change-Id: Ibc83ca64743553249033cbb58e814eb3f6c8d289 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899597Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#713118}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/30a71af28d43..8f73369ec458 Created with: gclient setdep -r src-internal@8f73369ec458 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None,chromium:None,chromium:984162,chromium:1004848,chromium:None Change-Id: I806ad79049a059c849d5df9ddf55791351ed5552 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1901534Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#713117}
-
Jose Dapena Paz authored
Rename NativeScrollBehavior getter to GetNativeScrollBehavior to avoid GCC compilation error: ../../third_party/blink/renderer/core/page/scrolling/scroll_state_callback.h:31:3: error: declaration of ‘blink::NativeScrollBehavior blink::ScrollStateCallback::NativeScrollBehavior() const’ [-fpermissive] } ^ ../../third_party/blink/renderer/core/page/scrolling/scroll_state_callback.h:15:12: error: changes meaning of ‘NativeScrollBehavior’ from ‘enum class blink::NativeScrollBehavior’ [-fpermissive] Bug: 819294 Change-Id: Idb0fa5649c78171dce179a075222847053268324 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900998Reviewed-by:
David Bokan <bokan@chromium.org> Commit-Queue: José Dapena Paz <jose.dapena@lge.com> Cr-Commit-Position: refs/heads/master@{#713116}
-
Avery Musbach authored
Bug: None Change-Id: Icdfff98425d943e78cf4df857cc43f8a49ea7ec1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1901431 Commit-Queue: Avery Musbach <amusbach@chromium.org> Reviewed-by:
Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#713115}
-
Eugene But authored
Bug: 1022029 TBR: kkhorimoto@chromium.org Change-Id: Ibe6c59f0d6df2e90ed84e95f50a63cb906f72290 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899596Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#713114}
-
Wei-Yin Chen (陳威尹) authored
Bug: None Change-Id: I68029a3f67c1744921c23d50b043be4d126823d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900846Reviewed-by:
Yue Zhang <yuezhanggg@chromium.org> Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#713113}
-
Stefan Zager authored
This is a pure refactor; upcoming patches will add more fields to the new struct, but making it a struct now will reduce the complexity of those changes. The blink/public stuff was moved from common/frame to platform/ to avoid spurious conversions between gfx::Rect and WebRect. TBR=jln@chromium.org Change-Id: I39ff38a0b7a60b33a839e84477ade99f3e8ca56d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1896052 Commit-Queue: Stefan Zager <szager@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Reviewed-by:
vmpstr <vmpstr@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#713112}
-
Xiaoqian Dai authored
Bug: 997885 Change-Id: I8d4c918b51ff5a2bad566471ca9edb34e680a890 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900279Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Xiaoqian Dai <xdai@chromium.org> Cr-Commit-Position: refs/heads/master@{#713111}
-
Nikita Podguzov authored
Bug: 1021488 Change-Id: Ie44dd08048ad75222602d4dbbfbc0a7807d17bf3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865339 Commit-Queue: Nikita Podguzov <nikitapodguzov@chromium.org> Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#713110}
-
Joshua Pawlicki authored
TBR=rsorokin@chromium.org Bug: 1022034 Change-Id: Ib2f40436fc21b7268e341ee1273fd2b5b523ccbd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900547Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Commit-Queue: Joshua Pawlicki <waffles@chromium.org> Cr-Commit-Position: refs/heads/master@{#713109}
-
dpapad authored
This is in preparation of turning on such PRESUBMIT checks for src/components. Bug: 1019312 Change-Id: Iefc41c84b6bba151e8eb6961871fa9cbf596e44e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900250 Auto-Submit: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Eric Noyau <noyau@chromium.org> Reviewed-by:
Ben Greenstein <bengr@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#713108}
-
Wenyu Fu authored
Add feature flag to control the exposure level of new feature during development. Bug: 978197 Change-Id: Ie9651ed8d981d6138409cafa30508d849d7b93b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900305 Commit-Queue: Wenyu Fu <wenyufu@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#713107}
-
Wei-Yin Chen (陳威尹) authored
Bug: None Change-Id: Ifb4fd6b42d2835bc219a310188fe931890c66c6c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900387Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#713106}
-
Joshua Pawlicki authored
TBR=johntlee@chromium.org Bug: 1022008 Change-Id: Ie96a0a460ee38032568e978e7583711fcaa6d827 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1901589Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Reviewed-by:
John Lee <johntlee@chromium.org> Commit-Queue: Joshua Pawlicki <waffles@chromium.org> Cr-Commit-Position: refs/heads/master@{#713105}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/a2b221404710..0efc01d54063 git log a2b221404710..0efc01d54063 --date=short --no-merges --format='%ad %ae %s' 2019-11-06 robertphillips@google.com Revert "Fully delineate GL usage w/ skia_use_gl" 2019-11-06 mtklein@google.com guard all SkVMBlitter debug features together 2019-11-06 nifong@google.com find min and max, separared by comma. not minmax. 2019-11-06 nigeltao@google.com Inline SkWuffsCodec::readFrames 2019-11-06 rosasco@google.com Fully delineate GL usage w/ skia_use_gl 2019-11-06 borenet@google.com [infra] Remove Calmbench and ParentRevision bots Created with: gclient setdep -r src/third_party/skia@0efc01d54063 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC ethannicholas@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=ethannicholas@google.com Bug: None Change-Id: Ic2dddf0b928a46aa16c6df9c04906f29f7bc9a07 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1901527Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#713104}
-
Wei-Yin Chen (陳威尹) authored
On low-end devices, the OverviewListLayout is used instead. Bug: 1018179 Change-Id: I6da4899ae5426853a2ff9ee1d423d48802e5ce81 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900808Reviewed-by:
Yue Zhang <yuezhanggg@chromium.org> Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#713103}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/bd826152ddda..2f2049af23f4 git log bd826152ddda..2f2049af23f4 --date=short --no-merges --format='%ad %ae %s' 2019-11-06 danilchap@webrtc.org Add blocking call in BandwidthStatsTest destructor Created with: gclient setdep -r src/third_party/webrtc@2f2049af23f4 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: None Change-Id: I38457a7f3fad59d4628f470721e57d63ae77f49b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900844Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#713102}
-
siyua authored
verification completes. Reason is when verification completes, the VerifyPendingDialogViewImpl::Hide is called which will reset the controller and close the dialog. So VerifyPendingDialogViewImpl::Close will be invoked then VerifyPendingDialogViewImpl::Cancel. In this case, the controller is already reset when cancel is called, which will crash. Bug: 991037 Change-Id: I55e832ae51f4c265c9f166d274b178712cdfffec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900191Reviewed-by:
Jared Saul <jsaul@google.com> Reviewed-by:
Manas Verma <manasverma@google.com> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Siyu An <siyua@chromium.org> Cr-Commit-Position: refs/heads/master@{#713101}
-
Dana Fried authored
Fixes potential hard crash when arbitrary View subclass calls InvalidateLayout() during OnBoundsChanged(), etc. (We saw this in at least one example in the wild.) Change-Id: I639fcaf0198fa899989b36a6264d1caa74ef8404 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900253 Commit-Queue: Caroline Rising <corising@chromium.org> Reviewed-by:
Caroline Rising <corising@chromium.org> Auto-Submit: Dana Fried <dfried@chromium.org> Cr-Commit-Position: refs/heads/master@{#713100}
-
Darwin Huang authored
This will help avoid some duplicate Focus/etc checks, and allow for easier extensibility, namely to add PermissionDescriptor modifiers like allowWithoutGesture or allowWithoutSanitization. No functional changes here though... it's just a refactoring change. Bug: 897289 Change-Id: I3abf09cf0d0304f57fd77aee8940a93c6770e67b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1896296Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Auto-Submit: Darwin Huang <huangdarwin@chromium.org> Cr-Commit-Position: refs/heads/master@{#713099}
-
Changwan Ryu authored
cancel(false) can still return true even when task has started. Adding test cases that can show this behavior. Bug: 1021775 Change-Id: Ie64304e1d17b50eea3546f390f594360dcd5ff60 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900654Reviewed-by:
Alex Clarke <alexclarke@chromium.org> Reviewed-by:
Sam Maier <smaier@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Commit-Queue: Changwan Ryu <changwan@chromium.org> Cr-Commit-Position: refs/heads/master@{#713098}
-
Yang Guo authored
https://chromium.googlesource.com/devtools/devtools-frontend/+log/879d97b05d..ab8035da9c TBR=tvanderlippe@chromium.org Change-Id: I66f1bb973bc42c516fd595af0b9edbab091318f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1901567Reviewed-by:
Yang Guo <yangguo@chromium.org> Commit-Queue: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#713097}
-
Natalie Chouinard authored
Move feature-specific methods from PrefServiceBridge to a new AboutSettingsBridge. Move all about settings classes to a subpackage (to be modularized later). This change also replaces the AboutVersionStrings object created over JNI with a simpler pair of String getters. Bug: 1016957 Change-Id: I1a9972c2aac51f3bb78036cabf01805ebca9e6bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1896037 Commit-Queue: Natalie Chouinard <chouinard@chromium.org> Reviewed-by:
Sophie Chang <sophiechang@chromium.org> Reviewed-by:
Peter Wen <wnwen@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Reviewed-by:
Sky Malice <skym@chromium.org> Cr-Commit-Position: refs/heads/master@{#713096}
-
James Cook authored
When the SplitSettingsSync flag is set the Chrome OS "People" section row for sync settings takes the user to a new settings page for OS sync controls. For now only kOsPreferences and kPrinters are supported. The WebUI for this follows the pattern of browser sync controls: https://cs.chromium.org/chromium/src/chrome/browser/resources/settings/people_page/sync_controls.html The JS handler follows the pattern of people_handler.cc: https://cs.chromium.org/chromium/src/chrome/browser/ui/webui/settings/people_handler.cc Screenshots: http://screen/ijEUzJrqrLE http://screen/faFhPmRgegL Future CLs will add support for more data types and for passphrase encryption. Bug: 1013466 Test: added to unit_tests and browser_tests Change-Id: Id33b9eb8ebb653d6b2d7fc103dc3154cfdaa1ca7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894763 Commit-Queue: James Cook <jamescook@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#713095}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/617e15e8dc97..c1c6fa243e83 git log 617e15e8dc97..c1c6fa243e83 --date=short --no-merges --format='%ad %ae %s' 2019-11-06 primiano@google.com Merge "protozero: simplify packed field and allow heap growth" Created with: gclient setdep -r src/third_party/perfetto@c1c6fa243e83 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=perfetto-bugs@google.com Bug: None Change-Id: I72385ddcd6ef2610a4eadb8c3b257117d989d5e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1901528Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#713094}
-
Connie Wan authored
See bug for the iterations with UX, including screenshots. I tried to get rid of as many magic numbers as I could, but a few remain because they're just tweaked until things look right visually. Bug: 1005333 Change-Id: I479668d5a2c8a5e018b17be23496092792a24ac3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1898615Reviewed-by:
Collin Baker <collinbaker@chromium.org> Reviewed-by:
Taylor Bergquist <tbergquist@chromium.org> Reviewed-by:
Charlene Yan <cyan@chromium.org> Commit-Queue: Connie Wan <connily@chromium.org> Cr-Commit-Position: refs/heads/master@{#713093}
-
Vladimir Levin authored
This patch moves the intrinsic-size tests into wpt/css/css-intrinsic-size R=chrishtr@chromium.org, tabatkins@chromium.org Bug: 991096 Change-Id: Id7c9cb7faf5ba693f192574add876ddcc58be817 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899313Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: vmpstr <vmpstr@chromium.org> Cr-Commit-Position: refs/heads/master@{#713092}
-
Eric Roman authored
Bug: 1021236 Change-Id: I884be77589493a3b7c605a1d9370facf82a1715c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1898708 Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Auto-Submit: Eric Roman <eroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#713091}
-
Eric Stevenson authored
Right now the Java side lives in webview_instrumentation_test_apk while the C++ side lives in webview_instrumentation_apk. This CL moves the native method to a new Java class that lives in webview_instrumentation_apk so that both the Java and C++ sides live in the same APK. This is necessary for the proxy natives conversion. Bug: 997199 Change-Id: Ia039cfcde5d18de80479c30086f67eedb531aca1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899196Reviewed-by:
Richard Coles <torne@chromium.org> Commit-Queue: Eric Stevenson <estevenson@chromium.org> Cr-Commit-Position: refs/heads/master@{#713090}
-
Alexander Dunaev authored
The event source based on FD watcher had wrong priority, which resulted in that GDK and GTK events stuck forever, and GTK dialogs won't show up. This CL fixes the priority of the FD watcher source to be higher than the one for the main work source, and also enables the GTK file selection dialog in Ozone builds. The implementation currently requires use_glib=true. There are other things (e.g., dialog modality) that will be fixed in subsequent CLs. R=kylechar@chromium.org, thomasanderson@chromium.org Bug: 1008755 Change-Id: I673cff846ea6d03db25190481fe391b4c6e76650 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1892954Reviewed-by:
kylechar <kylechar@chromium.org> Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Alexander Dunaev <adunaev@igalia.com> Cr-Commit-Position: refs/heads/master@{#713089}
-
Ana Salazar authored
Fixed: 987624 Change-Id: Iad31aec55800442bbafb18896fb6d6e40dc5c747 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869993Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Commit-Queue: Ana Salazar <anasalazar@chromium.org> Cr-Commit-Position: refs/heads/master@{#713088}
-
Wenyu Fu authored
When the accessibility mode is on, or a hardware keyboard is attached to the device, it will disable the scroll to load functionality on History activity, and a footer contains MoreProgressButton (browser/ui/widget/MoreProgressButton) will be added and bounded with HistoryAdapter#loadMoreItems. Unit test for HistoryAdapter and HistoryActivity is also included. Bug: 1001286 Change-Id: I15d68624228215898db73bbd0898367b5900f555 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1891570 Commit-Queue: Wenyu Fu <wenyufu@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#713087}
-