- 07 Jan, 2017 20 commits
-
-
liaoyuke authored
Previously, our generated Xcode project has the issue that Xcode couldn't find our xctests. And to fix it, one must find the list of xctest files under each of the application targets and then associate them with the corresponding xctest target. This CL associates xctest files with xctest targets and because our compilation is done via ninja, it also adds '-help' as per file compiler flags to each xctest file reference to prevent Xcode from trying to compile the xctest files. BUG=614818 Review-Url: https://codereview.chromium.org/2616773003 Cr-Commit-Position: refs/heads/master@{#442120}
-
yusukes authored
This is safer than manually specifying min versions. BUG=649782 TEST=git try, manually tested files.app, context menu, and link click Review-Url: https://codereview.chromium.org/2614173002 Cr-Commit-Position: refs/heads/master@{#442119}
-
chrome://md-settings/signOutmahmadi authored
BUG=678548 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2614883004 Cr-Commit-Position: refs/heads/master@{#442118}
-
bajones authored
In the case that the backing VR service is not available the call will now resolve to an empty array. BUG=678283 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation Review-Url: https://codereview.chromium.org/2614873002 Cr-Commit-Position: refs/heads/master@{#442117}
-
mbrunson authored
With the change in the Mojo binding system, the existing test fixture is overly complex. A layer of indirection can be removed now that Mojo connections can be created with arbitrary JavaScript classes. This patch removes the TestAdapter class from bluetooth internals browser test and directly binds the TestAdapterProxy directly to an Adapter interface. BUG=651282 Review-Url: https://codereview.chromium.org/2620583002 Cr-Commit-Position: refs/heads/master@{#442116}
-
rbyers authored
The new UseCounter histograms are now working well and the data we're getting looks solid. It's time to make them official as the primary histograms to track. BUG=676837 Review-Url: https://codereview.chromium.org/2614213002 Cr-Commit-Position: refs/heads/master@{#442115}
-
ben authored
- Eliminates client lib's ConnectParams struct as this is no longer needed. - Converts call sites. - In Service Manager, RegisterService just calls Connect() with some empty values. The codepath is mostly the same. Note that when the ClientProcessConnection is passed now OnGotResolvedName returns early prior to completing the connection, as RegisterService is not a "connect" action, just a "start" one. R=rockot@chromium.org,tsepez@chromium.org Review-Url: https://codereview.chromium.org/2610173003 Cr-Commit-Position: refs/heads/master@{#442114}
-
nya authored
BUG=chromium:671511 TEST=trybot Review-Url: https://codereview.chromium.org/2616023006 Cr-Commit-Position: refs/heads/master@{#442113}
-
catapult-deps-roller authored
https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/fa6d5ce49e34..4a7b232d00cc $ git log fa6d5ce49..4a7b232d0 --date=short --no-merges --format='%ad %ae %s' 2017-01-06 benjhayden Update UserModelBuilder to an ES6 class. 2017-01-06 benjhayden Modernize UserExpectationVerifier. Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=catapult-sheriff@chromium.org Review-Url: https://codereview.chromium.org/2618943003 Cr-Commit-Position: refs/heads/master@{#442112}
-
binji authored
This is the Blink-side change to match the V8 change here: https://codereview.chromium.org/2570433005. BUG=676063 Review-Url: https://codereview.chromium.org/2615803002 Cr-Commit-Position: refs/heads/master@{#442111}
-
avayvod authored
Pause video-only players when they go to background and continue playback when they go into foreground and hasn't been paused explicitly in the mean time. Behind the experiment for optimizing background video playback. BUG=671381 TEST=Manual Review-Url: https://codereview.chromium.org/2567833002 Cr-Commit-Position: refs/heads/master@{#442110}
-
fdoray authored
BUG=664996 Review-Url: https://codereview.chromium.org/2568793003 Cr-Commit-Position: refs/heads/master@{#442109}
-
cco3 authored
Given that we can't inspect the status of our Nearby subscription, we have to resubscribe on every startup. That means that there is no point in caching nearby URLs when we will have to repopulate those through the new subscription anyway. Additionally, our current practice is sending noise to listeners (onFound at startup, onLost at cache deletion, onFound at resubscription). This change just removes that cache. BUG=667754 Review-Url: https://codereview.chromium.org/2606933003 Cr-Commit-Position: refs/heads/master@{#442108}
-
xjz authored
BUG=678339 Review-Url: https://codereview.chromium.org/2620433002 Cr-Commit-Position: refs/heads/master@{#442107}
-
liaoyuke authored
On iPads, when many tabs are open, additional tabs opened in the background (through the context menu) will collapse together and remain hidden. Users will have to manually scroll through to see newly opened ones. This CL fixes the issue by enabling the scenario that every time a new tab is inserted, we auto scroll the tab strip view to make it immediately visible. BUG=228419 Review-Url: https://codereview.chromium.org/2611003002 Cr-Commit-Position: refs/heads/master@{#442106}
-
reillyg authored
This patch changes the rules for WebUSB so that a top level frame can request access to any USB device, while embedded frames must have an origin matching the allowed origins structure read from the device. Integration tests for WebUSB are added which exercise this. BUG=492204 Review-Url: https://codereview.chromium.org/2611773004 Cr-Commit-Position: refs/heads/master@{#442105}
-
jrummell authored
Improve the testing on MojoCdm by adding a MockCdm. This allows for testing that: - resolving the promise works - rejecting the promise works - closing the connection before a call works - closing the connection while executing the call works. BUG=671362 TEST=new tests pass Review-Url: https://codereview.chromium.org/2592913002 Cr-Commit-Position: refs/heads/master@{#442104}
-
pfeldman authored
Review-Url: https://codereview.chromium.org/2611843010 Cr-Commit-Position: refs/heads/master@{#442103}
-
sczs authored
BUG=674493 Review-Url: https://codereview.chromium.org/2596753002 Cr-Commit-Position: refs/heads/master@{#442102}
-
skia-deps-roller authored
https://skia.googlesource.com/skia.git/+log/83f532e9b5b8..f8a64b03216d $ git log 83f532e9b..f8a64b032 --date=short --no-merges --format='%ad %ae %s' 2017-01-06 mtklein try harder to exclude SkXbyak.cpp from Google3 build 2017-01-06 mtklein zero fBuf in new SkXbyakBench 2017-01-06 bsalomon Make all GrXPFactory instances statics. Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel TBR=csmartdalton@google.com Review-Url: https://codereview.chromium.org/2614233003 Cr-Commit-Position: refs/heads/master@{#442101}
-
- 06 Jan, 2017 20 commits
-
-
mek authored
Hopefully these tests are indeed just sometimes extra slow (at least a 6x slowdown). If not I'll have to do more digging to see why they sometimes timeout. BUG=678498 BUG=678496 Review-Url: https://codereview.chromium.org/2610923011 Cr-Commit-Position: refs/heads/master@{#442100}
-
ynovikov authored
Per discussion in the bug BUG=678382 TBR=kbr@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2620563002 Cr-Commit-Position: refs/heads/master@{#442099}
-
mattreynolds authored
Add support for "Query Suggest" in the Physical Web omnibox provider. Previously, the omnibox would only display Physical Web omnibox suggestions when the user had not yet entered any text in the omnibox ("Zero Suggest"). With this CL, Physical Web suggestions may be displayed if the URL and page title match all the terms in the omnibox query string. BUG=630769 Review-Url: https://codereview.chromium.org/2591053002 Cr-Commit-Position: refs/heads/master@{#442098}
-
sky authored
The resize handlers are now necessary as aura-mus dispatches events using the same path as aura non-mus. Without this change the MoveEventHandler installed on the window in the mash side doesn't get events and resize fails. BUG=none TEST=none R=msw@chromium.org Review-Url: https://codereview.chromium.org/2618113002 Cr-Commit-Position: refs/heads/master@{#442097}
-
avi authored
BUG=639089 Review-Url: https://codereview.chromium.org/2614753004 Cr-Commit-Position: refs/heads/master@{#442096}
-
hongchan authored
This CL adds the new assertion to audit; it checks if an array has values other than the expected value. This is useful when checking the non-zero array. BUG=678695 TEST= LayoutTests/webaudio/unit-tests/audit.html LayoutTests/webaudio/unit-tests/audit-failures.html Review-Url: https://codereview.chromium.org/2618053002 Cr-Commit-Position: refs/heads/master@{#442095}
-
wangxianzhu authored
We save previousPaintOffset for all objects and it's the same as the paint offset saved in paint properties if any. Now save only one copy. Also fix a spv2 paint invalidation bug about paint offset change: previously we checked paint offset change too late. Now check it at the beginning of PaintInvalidator::invalidatePaintIfNeeded() and convert it into a full paint invalidation reason. In this way, we no longer need to pass old and new paint offsets in the context. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Review-Url: https://codereview.chromium.org/2614093002 Cr-Commit-Position: refs/heads/master@{#442094}
-
eugenebut authored
Copy strings before passing them to scoped_nsobjects. BUG=679032 Review-Url: https://codereview.chromium.org/2612423003 Cr-Commit-Position: refs/heads/master@{#442093}
-
sczs authored
Cells will now be a single accessibility item: https://drive.google.com/open?id=0B51hlF9bHYPwNE9CZTg1dDVyYkk VoiceOver will read the name of the App and then the switch state or "Double tap to install" string. BUG=590064, 341403 Review-Url: https://codereview.chromium.org/2607763002 Cr-Commit-Position: refs/heads/master@{#442092}
-
chrome://crasheswez authored
Originally chrome://crashes only displayed uploaded crashes, and only displayed the time at which the crash report was uploaded. On systems using Crashpad we also have access to the crash capture-time which is useful in identifying crash reports which occurred while offline, for example, such that the capture and upload times would differ considerably. This patch was originally drafted by phistuck@gmail.com and jiameng@chromium.org. BUG=664430,674249 Review-Url: https://codereview.chromium.org/2612993003 Cr-Commit-Position: refs/heads/master@{#442091}
-
rnephew authored
BUG=676493 Review-Url: https://codereview.chromium.org/2611203003 Cr-Commit-Position: refs/heads/master@{#442090}
-
mbjorge authored
BUG=678341 Review-Url: https://codereview.chromium.org/2618083002 Cr-Commit-Position: refs/heads/master@{#442089}
-
lukasza authored
After automatic rename by rewrite_to_chrome_style clang tool, the |rtl|, |ltr| and |inherit| constant identifiers in CanvasRenderingContext2D.cpp would become |kRtl|, |kLtr|, |kInherit| and would unfortunately conflict with identifiers defined elsewhere (e.g. with |kRtl| and |kLtr| enum values from TextDirection enum defined in TextDirection.h). This CL preemptively prevents the problem above, by adding a 'DirectionString' suffix to the 3 affected identifiers in CanvasRenderingContext2D.cpp BUG=641004 Review-Url: https://codereview.chromium.org/2611723004 Cr-Commit-Position: refs/heads/master@{#442088}
-
jianli authored
BUG=none Review-Url: https://codereview.chromium.org/2617903004 Cr-Commit-Position: refs/heads/master@{#442087}
-
ltian authored
Current items (Open in new tab, Open in incognito tab, Copy link address, Copy link text) shown in the context menu for mailto tag link do not make sense. Update the items shown in the context menu when long pressing a mailto link. The items include: 1. Send message: same behavior as clicking the link which will navigate to default mail app to send an email with parsed info from url. 2. Add to contacts: - If no email address in the mailto, hid the menu item - If more than one email addresses is present, select the first one for adding to the contacts 3. Copy: copy all the email addresses (everything between mailto: and ?) BUG=389056 Review-Url: https://codereview.chromium.org/2605283002 Cr-Commit-Position: refs/heads/master@{#442086}
-
rnephew authored
A test trace is a trace that shows which tests are running and for how long. Review-Url: https://codereview.chromium.org/2617233002 Cr-Commit-Position: refs/heads/master@{#442085}
-
esprehn authored
base::vsnprintf already handles the windows difference so we don't need the platform ifdefs. We can also optimistically format into the buffer and if it fits avoid formatting twice. Review-Url: https://codereview.chromium.org/2620453002 Cr-Commit-Position: refs/heads/master@{#442084}
-
skia-deps-roller authored
https://skia.googlesource.com/skia.git/+log/f55ea6a1deb2..83f532e9b5b8 $ git log f55ea6a1d..83f532e9b --date=short --no-merges --format='%ad %ae %s' 2017-01-06 mtklein Add a real SkXbyak bench, implement enough to run it. 2017-01-06 mtklein exclude src/opts/SkXbyak.cpp from g3 build 2017-01-06 kjlubick Add in Path fuzzer 2017-01-06 djsollen Add support for 64-bit devices when using gdb on Android 2017-01-06 bsalomon Purge clip masks when they are no longer findable. 2017-01-04 fmalita Avoid SkFixed overflow in decal bitmap procs 2017-01-06 bsalomon Remove arithmetic mode GrXP code. 2017-01-06 bsalomon Add support for tagging GrUniqueKeys with a debug string 2017-01-06 mtklein SkXbyak basics BUG=676459,675444 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel TBR=csmartdalton@google.com Review-Url: https://codereview.chromium.org/2617043004 Cr-Commit-Position: refs/heads/master@{#442083}
-
rdevlin.cronin authored
We expose API enums on objects with in the API; this is mostly useful because our enum style is pretty wildly inconsistent (hacker_style, camelCase, and SCREAMING_STYLE are all used). This allows authors to use the enum directly by using chrome.foo.BarEnum.SOMETHING. Add support for this in native bindings. BUG=653596 Review-Url: https://codereview.chromium.org/2615773002 Cr-Commit-Position: refs/heads/master@{#442082}
-
mcasas authored
WebmMuxer sets WebM's DefaultDuration to the expected delta between frames (derived from the frame rate), but that messes up (some) players due to frames arriving at a different rate. This is a legimimate case if, e.g. the encoded data stream is paused. This CL essentially avoids setting this parameter so that players can just look at each encoded frame timestamp instead. [1] http://www.webmproject.org/docs/container/#track BUG=606000 Review-Url: https://codereview.chromium.org/2617143003 Cr-Commit-Position: refs/heads/master@{#442081}
-