- 07 Nov, 2013 28 commits
-
-
fmeawad@chromium.org authored
This is different from https://code.google.com/p/chromium/codesearch#chromium/src/base/process/process_metrics_mac.cc&l=216 as it gets the per-thread CPU time while process metrics gets all-thread CPU usage. BUG=280744 Review URL: https://codereview.chromium.org/56973012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233450 0039d316-1c4b-4281-b951-d872f2087c98
-
komatsu@chromium.org authored
UpdateTextInputType should be called before SyncSelectionIfRequired. UpdateTextInputType may send TextInputTypeChanged to notify the focus was changed, and SyncSelectionIfRequired may send SelectionChanged to notify the selection was changed. Focus change should be notified before selection change. BUG=310562 Review URL: https://codereview.chromium.org/33323003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233449 0039d316-1c4b-4281-b951-d872f2087c98
-
chrome-admin@google.com authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233447 0039d316-1c4b-4281-b951-d872f2087c98
-
satorux@chromium.org authored
These archive files were supported for internal test tools, but it should be ready to drop support for them now. BUG=271300 TEST=none R=mtomasz@chromium.org Review URL: https://codereview.chromium.org/59713006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233446 0039d316-1c4b-4281-b951-d872f2087c98
-
kinaba@chromium.org authored
BUG=298789 R=satorux@chromium.org, yoshiki@chromium.org Review URL: https://codereview.chromium.org/59083013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233445 0039d316-1c4b-4281-b951-d872f2087c98
-
dalecurtis@google.com authored
8f24a14 Only trim leading whitespace for #line directives. 440b476 Update OSX x64 config files. BUG=315789 TEST=mac_x64_rel passes NOTRY=true R=ihf@chromium.org Review URL: https://codereview.chromium.org/62963002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233444 0039d316-1c4b-4281-b951-d872f2087c98
-
mlamouri@chromium.org authored
around directly use window_ and GetWidget() would simply return window_. BUG=None Review URL: https://codereview.chromium.org/58883002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233443 0039d316-1c4b-4281-b951-d872f2087c98
-
Hokein.Wu@gmail.com authored
The "implemented_in" key format like this: [implemented_in="path/to/implemented_file"] namespace Foo {...}; BUG=313579 TEST=pass idl_schema_test Review URL: https://codereview.chromium.org/56543003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233442 0039d316-1c4b-4281-b951-d872f2087c98
-
plundblad@chromium.org authored
BUG=314181 R=dmazzoni@chromium.org Review URL: https://codereview.chromium.org/56533004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233441 0039d316-1c4b-4281-b951-d872f2087c98
-
yiyaoliu@chromium.org authored
Renamed the method and variable name in derived class so that the method in based class will not be overridden. BUG=270888 Review URL: https://codereview.chromium.org/51113006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233440 0039d316-1c4b-4281-b951-d872f2087c98
-
alecflett@chromium.org authored
This patch introduces use of WebServiceWorkerError as a means to propagate an error from the browser to the renderer, and further reflect this error via WebCallbacks into Blink BUG=285976 R=jam@chromium.org, michaeln@chromium.org, tsepez@chromium.org TBR=abarth Review URL: https://codereview.chromium.org/26442004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233438 0039d316-1c4b-4281-b951-d872f2087c98
-
scottmg@chromium.org authored
This was triggered by the change to restart in desktop mode when running with the software compositor. But in general, it's possible for a channel error to happen before SetTargetSurface which sets the host_. Since the CHECK isn't accomplishing too much, just remove it. R=cpu@chromium.org, sky@chromium.org BUG=315057 Review URL: https://codereview.chromium.org/62853002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233437 0039d316-1c4b-4281-b951-d872f2087c98
-
craigdh@chromium.org authored
BUG=297210 TEST=included NOTRY=True Review URL: https://codereview.chromium.org/58623002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233436 0039d316-1c4b-4281-b951-d872f2087c98
-
koz@chromium.org authored
BUG=297671 Review URL: https://codereview.chromium.org/55633002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233435 0039d316-1c4b-4281-b951-d872f2087c98
-
vasilii@chromium.org authored
BUG=267510 Review URL: https://codereview.chromium.org/54273004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233434 0039d316-1c4b-4281-b951-d872f2087c98
-
calamity@chromium.org authored
This CL fixes an issue with the profile icon not showing up if the user has pinned the default chrome shortcut to the taskbar. Using the runtime badging on top of the taskbar icon's badge causes the badge to look slightly darker around the edges at runtime. BUG=313800 Review URL: https://codereview.chromium.org/54053008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233433 0039d316-1c4b-4281-b951-d872f2087c98
-
dmazzoni@chromium.org authored
BUG=314801 Review URL: https://codereview.chromium.org/58513003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233432 0039d316-1c4b-4281-b951-d872f2087c98
-
spang@chromium.org authored
The touchscreen crashes because of BTN_TOUCH events that hit NOTREACHED. The touchpad crashes for similar reasons. We don't have touchpad support here at all, so ignore these devices. NOTRY=true Review URL: https://codereview.chromium.org/58473003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233431 0039d316-1c4b-4281-b951-d872f2087c98
-
estade@chromium.org authored
BUG=314842 R=dbeam@chromium.org Review URL: https://codereview.chromium.org/58683002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233430 0039d316-1c4b-4281-b951-d872f2087c98
-
dmazzoni@chromium.org authored
BUG=309121 NOTRY=true Review URL: https://codereview.chromium.org/57833004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233429 0039d316-1c4b-4281-b951-d872f2087c98
-
szym@chromium.org authored
Verify that after parsing 1xx response with ReadResponseHeaders, HttpResponseInfo contains the parsed headers and the response buffer contains the response that follows. Review URL: https://codereview.chromium.org/45823003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233428 0039d316-1c4b-4281-b951-d872f2087c98
-
kalman@chromium.org authored
rather than last, so that they can be parallelised and have the most effect. Implement a few of the more trivial Cron methods, including moving most FeaturesBundle methods to return Futures. BUG=305280 R=jyasskin@chromium.org NOTRY=true Review URL: https://codereview.chromium.org/63203002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233427 0039d316-1c4b-4281-b951-d872f2087c98
-
kalman@chromium.org authored
safe_browsing_service.cc. Hopefully this will fix the "pure virtual method called" errors seen in various ExtensionService tests that use safe browsing; both those reverted as part of bug 233290, and the ones that are still live. BUG=233290 R=jyasskin@chromium.org TBR=shess@chromium.org Review URL: https://codereview.chromium.org/60833007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233426 0039d316-1c4b-4281-b951-d872f2087c98
-
sky@chromium.org authored
Ifdefs weren't quite right. BUG=315195 TEST=run chrome (aura) in metro mode, touch the tabstrip and move tabs around, make sure tabs enter stacked mode. R=ben@chromium.org Review URL: https://codereview.chromium.org/60353003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233425 0039d316-1c4b-4281-b951-d872f2087c98
-
rogerta@chromium.org authored
Move mergesession from SigninManager to reconcilor. Implement ListAccounts. Start implementing reconcile action, but still a noop for now. This CL depends on https://codereview.chromium.org/57103002/ Alan: here is an implementation of the ListAccounts. I also added lots of DVLOG() to the code. Let me know if you'd rather I took those out and put in a separate CL. Hui: please review. This CL adds more functionality to the reconcilor but its still not complete. However, it enables AC behind the flag for merge session so you don't need to do that manually. BUG=305249 Review URL: https://codereview.chromium.org/57363003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233424 0039d316-1c4b-4281-b951-d872f2087c98
-
dmazzoni@chromium.org authored
BUG=314799 NOTRY=true Review URL: https://codereview.chromium.org/55293006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233423 0039d316-1c4b-4281-b951-d872f2087c98
-
mlamouri@chromium.org authored
In order to avoid an ugly flash of white pixels when a new app window is shown, this patch defers showing a window until a non-empty backing store update has completed. The feature is behind the "enable-apps-show-on-first-paint" flag. BUG=225843, 254152 Review URL: https://codereview.chromium.org/55293003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233422 0039d316-1c4b-4281-b951-d872f2087c98
-
haven@chromium.org authored
BUG=308191 Review URL: https://codereview.chromium.org/27563002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233421 0039d316-1c4b-4281-b951-d872f2087c98
-
- 06 Nov, 2013 12 commits
-
-
shadi@chromium.org authored
BUG=307107 Review URL: https://codereview.chromium.org/54053007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233420 0039d316-1c4b-4281-b951-d872f2087c98
-
tmdiep@chromium.org authored
Added EphemeralAppThrottle, which will launch ephemeral apps for links to Chrome Web Store detail pages instead of opening the page in the browser. This will only occur if the enable-ephemeral-apps switch is enabled. For experimental purposes only. The extension will currently be installed in Chrome. BUG=312460 Review URL: https://codereview.chromium.org/51943003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233419 0039d316-1c4b-4281-b951-d872f2087c98
-
hans@chromium.org authored
BUG=313468, 313823 Review URL: https://codereview.chromium.org/49983003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233418 0039d316-1c4b-4281-b951-d872f2087c98
-
ernstm@chromium.org authored
R=nduca@chromium.org BUG=264308 Review URL: https://codereview.chromium.org/29423005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233417 0039d316-1c4b-4281-b951-d872f2087c98
-
dgrogan@chromium.org authored
> x11: Move XInput2 availability information out of the message pump. > > BUG=302696 > R=darin@chromium.org, derat@chromium.org > > Review URL: https://codereview.chromium.org/52823002 TBR=sadrul@chromium.org Review URL: https://codereview.chromium.org/63443002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233416 0039d316-1c4b-4281-b951-d872f2087c98
-
sadrul@chromium.org authored
BUG=302696 R=darin@chromium.org, derat@chromium.org Review URL: https://codereview.chromium.org/52823002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233414 0039d316-1c4b-4281-b951-d872f2087c98
-
kalman@chromium.org authored
BUG=293678 R=jyasskin@chromium.org Review URL: https://codereview.chromium.org/61393002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233413 0039d316-1c4b-4281-b951-d872f2087c98
-
tfarina@chromium.org authored
We don't need to call BookmarkModelFactory::GetProfile(...) again as we already have a data member |model_| for which we have already called BookmarkModelFactory::GetProfile(). BUG=None TEST=In Bookmarks Bar, right click a folder that is not the "Other bookmarks", make sure that folder has only one children, for that folder the menu should not close when deleting the child node. Now do the same for the "Other bookmarks" folder, it should close if it has only one children. No regressions observed. R=sky@chromium.org Review URL: https://codereview.chromium.org/60253004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233412 0039d316-1c4b-4281-b951-d872f2087c98
-
earthdok@chromium.org authored
BUG=315046 TBR=kalman@chromium.org Review URL: https://codereview.chromium.org/59743002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233411 0039d316-1c4b-4281-b951-d872f2087c98
-
davemoore@chromium.org authored
- Move Params class to anonymous namespace - Roll private class definitions into declarations - Remove unnecessary namespace references BUG=None TEST=None R=darin@chromium.org, darin Review URL: https://codereview.chromium.org/61833005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233410 0039d316-1c4b-4281-b951-d872f2087c98
-
joi@chromium.org authored
NOTRY=true BUG=291271 Review URL: https://codereview.chromium.org/59113003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233409 0039d316-1c4b-4281-b951-d872f2087c98
-
tfarina@chromium.org authored
BUG=239107 TEST=everything still builds R=jamesr@chromium.org TBR=darin Review URL: https://codereview.chromium.org/54583005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233408 0039d316-1c4b-4281-b951-d872f2087c98
-