- 04 Dec, 2019 40 commits
-
-
Johannes Henkel authored
- Make DomainHandler a pure interface, push browser() to the other classes as browser_ where needed. - Keep the Disable() methods for consistency (they're always no-ops), and call them from the HeadlessDevToolsSession destructor. - Remove HeadlessDevToolsSession::dispatcher() access, it's not used. - Use a vector as opposed to a map, name is never used, so it can go from DomainHandler as well. - Put dispatcher_ directly as a field, no unique_ptr needed. Change-Id: Ia60410138db5aaf0bb78376a8331288312dbd623 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1938038 Commit-Queue: Johannes Henkel <johannes@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#721330}
-
Sergey Ulanov authored
Added chromium.cast.ApplicationContext interface that is now used in cast_runner to request media_session_id from the agent. The ID is then passed the corresponding WebEngine frame. Bug: b/142420944 Change-Id: I837349fbcdc95c4233d477b051ed3800f1a513d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1925436 Commit-Queue: Wez <wez@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Auto-Submit: Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#721329}
-
David Tseng authored
This reverts commit a275a907. Reason for revert: <INSERT REASONING HERE> >>> if_pattern '^ *if \\(.*[;)] *$' >>> re.search(if_pattern, "if (()") <_sre.SRE_Match object at 0x7f1e5e994420> The presubmit flags any if statement of the form if ((condition) ...) { } Unfortunately, this means the presubmit is quite noisy, so sorry to have to revert. Also, nice to have would be a line number with the error. Original change's description: > Add presubmit check to accessibility component extensions > > Adds a presubmit check to enforce that all conditionals have brackets. > Due to `git cl format` not matching the Chromium style guide for JS > (see crbug/987439), it was decided to always use braces for the > accessibility component extensions (see http://shortn/_rNxAMDRHqE). > > This change also creates a new directory, accessibility/common, as a > first step towards sharing substantial code between the accessibility > component extensions. > > Bug: 706981 > Change-Id: I3f5134419957e4143e43a6e3f64fd11b59d1ed96 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900300 > Commit-Queue: Anastasia Helfinstein <anastasi@google.com> > Reviewed-by: David Tseng <dtseng@chromium.org> > Cr-Commit-Position: refs/heads/master@{#720936} TBR=dtseng@chromium.org,anastasi@google.com Change-Id: I96ff8388796a2f38f408fb3e47f647998a4c6342 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 706981 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949701Reviewed-by:
David Tseng <dtseng@chromium.org> Commit-Queue: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#721328}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/c694627157f2..eba195f1eaa6 git log c694627157f2..eba195f1eaa6 --date=short --first-parent --format='%ad %ae %s' 2019-12-03 herb@google.com Make GrTextBlob initial position const 2019-12-03 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-12-03 reed@google.com remove legacy SkPath enum guards 2019-12-03 herb@google.com Start cleanup of GrTextBlob 2019-12-03 fmalita@chromium.org [skottie] Deferred image frame resolution 2019-12-03 brianosman@google.com Particles: Do a cleanup/standardization pass on the API 2019-12-03 herb@google.com Replace some std::tie with auto [] 2019-12-03 michaelludwig@google.com Reorg helper functions in prep for function pointer caching Created with: gclient setdep -r src/third_party/skia@eba195f1eaa6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC bsalomon@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: bsalomon@google.com Change-Id: Id3e3340747dd7bf1a6dabcba71590cf6fb40cc16 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1948957Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#721327}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/981da03f24d0..9777ab3619c7 git log 981da03f24d0..9777ab3619c7 --date=short --first-parent --format='%ad %ae %s' 2019-12-04 ehmaldonado@google.com depot_tools: Add tests for detect_host_arch. Created with: gclient setdep -r src/third_party/depot_tools@9777ab3619c7 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: agable@chromium.org Change-Id: I759ec1305fea55d16fe7d0995194fd869c6ddc7b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1948713Reviewed-by:
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/3d7ad5ed37c1..38f725fb445a git log 3d7ad5ed37c1..38f725fb445a --date=short --first-parent --format='%ad %ae %s' 2019-12-04 tsepez@chromium.org Cover some more nullptr-safe paths in fpdfview.h public functions. 2019-12-04 tsepez@chromium.org Prevent fatal error in CFX_V8::PutObjectProperty() 2019-12-04 tsepez@chromium.org Take buffers from the partition in flatemodule.cpp 2019-12-03 tsepez@chromium.org Exercise more CJX_List methods from JavaScript. 2019-12-03 tsepez@chromium.org Use buffers from the partition in CPDFSDK_FormFillEnvironment 2019-12-03 tsepez@chromium.org Add unit test for FPDFImageObj_LoadJpegFile{Inline}() APIs 2019-12-03 tsepez@chromium.org Take buffers from partition in faxmodule.cpp Created with: gclient setdep -r src/third_party/pdfium@38f725fb445a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pdfium-autoroll Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: pdfium-deps-rolls@chromium.org Change-Id: Iac324c2485c5f9dda95380e06f3379a1e6606115 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1948956Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/56f46565e9ed..847717f1926b Created with: gclient setdep -r src-internal@847717f1926b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: I5cb3a76299713a974544f90b0daaa30e27463f2d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1948955Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#721324}
-
Ryan Hansberry authored
Tweak the tense of string to be more accurate. Bug: b:144537525 Change-Id: I3ec66c97b0c2df802f9b457ef39d7665a491ba33 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949763 Commit-Queue: Ryan Hansberry <hansberry@chromium.org> Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Auto-Submit: Ryan Hansberry <hansberry@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#721323}
-
Gang Wu authored
Duet won't show in landscape mode, so IPH for duet show not show up in landscape mode as well. Here is related clank cl. https://chrome-internal-review.googlesource.com/c/clank/internal/apps/+/2256299 Bug: 966792 Change-Id: I4ed882dfefa289ddfcaf3ec2204c4ac6f41043c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1947383 Commit-Queue: Gang Wu <gangwu@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#721322}
-
Akihiro Ota authored
This change makes several panel improvements including: 1. Improving the contrast ratio of the iSearch placeholder text. 2. Keeping the menus open if a menu is clicked. Previously, clicking on a menu would exit the ChromeVox menus entirely. 3. Toggles the triangle icon next to the ChromeVox menus button to communicate what will happen upon the next press (will the menus open or will they close). Bug: 793337 Change-Id: I0a6d785b6a3750d0c25d7b9bb8dbc359ee9bbc37 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1947812 Commit-Queue: Akihiro Ota <akihiroota@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#721321}
-
Lei Zhang authored
Just add base::RefCountedMemory::data(), which simplify calls front(). Show it works using RefCountedMemoryUnitTest. Real users will be added later, sometimes without even realizing it. Change-Id: Ibead4926ae3d1351dd4eae8fb82ecf3d1fb20922 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1948947Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#721320}
-
Zhenyao Mo authored
Do it in an atomic way rather than cleanly releasing resources, etc. The latter has been the source of many hangs and crashes. It's not worth the efforts. When browser process exits, I believe we already shuts down GPU process atomically. After this change, the only clean exit for GPU process is the unsandboxed GPU process that is to collect extra GPU information. It needs to shut down cleanly to make sure the info collected has been received by browser process. BUG=896565,1018233,1027137 TEST=manual R=kbr@chromium.org,sunnyps@chromium.org Change-Id: I082a06945d261db0fb9a4549859adf1e057212ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949671 Commit-Queue: Zhenyao Mo <zmo@chromium.org> Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#721319}
-
Chris Harrelson authored
scrollTopMax is not a standardized web feature. The actual functionality was passing as of: https://chromium.googlesource.com/chromium/src/+/6a9dd6d26726f346345cf1970c2bc3af3ec1afbd Bug: 997502 Change-Id: Ic120d09d0e6a9652c195afe0ac7cacece917dd47 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949556Reviewed-by:
Nick Burris <nburris@chromium.org> Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#721318}
-
Vitaly Buka authored
CSSPropertyUpdateValue.html of linux-perf/blink_perf.css was 10% slower with -ftrivial-auto-var-init=pattern. Before: https://pinpoint-dot-chromeperf.appspot.com/job/111c9107220000 After: https://pinpoint-dot-chromeperf.appspot.com/job/10bd9a00a20000 The benchmark is still 4% slower, but it's something outside of this file. I am looking into that and will fix in followup patches. Bug: 977230 Change-Id: I458be4a2e43d8b641881555b477f5752af627179 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1948586Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Vitaly Buka <vitalybuka@chromium.org> Cr-Commit-Position: refs/heads/master@{#721317}
-
Robert Liao authored
Sample Histogram Recording Histogram: WebUITabStrip.TabActivation recorded 8 samples, mean = 15.4 (flags = 0x41) 0 ... 14 ------------------------------------------------------------------------O (7 = 87.5%) {0.0%} 17 ----------O (1 = 12.5%) {87.5%} 20 ... BUG=1016031 Change-Id: I07a59e7f2928e5eb6031afeced7c83ac494b020b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1930251 Commit-Queue: Robert Liao <robliao@chromium.org> Reviewed-by:John Lee <johntlee@chromium.org> Reviewed-by:
Nik Bhagat <nikunjb@chromium.org> Auto-Submit: Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#721316}
-
Sammie Quon authored
It previously used a mask, which worked until recently see [1] for more details. But using a clip rect w/ rounded corners is more efficient anyways, so use that. The mask was also being used for the border, but that still works because that layer has no backdground effects, and this probably needs to get merged to M79. [1] https://bugs.chromium.org/p/chromium/issues/detail?id=1030432 Test: manual Bug: 1023009 Change-Id: I1e910ea280701989298871f31dfdff37c09ad1c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949293 Commit-Queue: Sammie Quon <sammiequon@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#721315}
-
Julie Jeongeun Kim authored
This CL cleans up old Mojo types for RendererPreferenceWatcher using PendingReceiver. It also updates struct EmbeddedWorkerStartParams from embedded_worker.mojom. Bug: 955171 Change-Id: I3f402e970925f62a980d4372ab3c0512331a44e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1948388Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Julie Kim <jkim@igalia.com> Cr-Commit-Position: refs/heads/master@{#721314}
-
Alex Danilo authored
The background progress center has a callback that removes references to error panels. Wire this up to any feedback panel items that host a 'dismiss' button. Bug: 990919 Change-Id: Ic9175bae19688637545f424044c2d2f7aeb584eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1943777Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Alex Danilo <adanilo@chromium.org> Cr-Commit-Position: refs/heads/master@{#721313}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/0a9b289bcbd1..10bac4e42d06 git log 0a9b289bcbd1..10bac4e42d06 --date=short --first-parent --format='%ad %ae %s' 2019-12-04 perezju@chromium.org [Telemetry] Re-enable ActionRunnerMeasureMemoryTest's Created with: gclient setdep -r src/third_party/catapult@10bac4e42d06 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC sadrul@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: sadrul@google.com Change-Id: I4b7dfd0b4cc6512191ae2233cdbecafa2ccd426b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1948953Reviewed-by:
-
smut authored
Bug: 1026669 Change-Id: I36cc5655bb87e4c73a96ad88307ae5047729ca77 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949665Reviewed-by:
-
Julie Jeongeun Kim authored
This CL converts ipc::mojom::GenericInterface to new Mojo types with PendingAssociatedReceiver instead of GenericInterfaceAssociatedRequest. It also updates GetAssociatedInterface() with pending_associated_receiver from ipc/ipc.mojom. Bug: 955171 Change-Id: I92ebbb25e51b1bbf5fba0417413d66455d277744 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1948385Reviewed-by:
Sam McNally <sammc@chromium.org> Reviewed-by:
-
Julie Jeongeun Kim authored
This CL removes status_area_widget_test_api.test-mojom and related mojo code since ash lives in the browser process, not a separate process and it is the remains of previous efforts to run ash in a separate process. It moves TapSelectToSpeakTray from StatusAreaWidgetTestApi to SystemTrayTestApi and removes StatusAreaWidgetTestApi. Bug: 955171 Change-Id: I1f4ffeda30102de64a988708963c6515b5d0d52c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1933681Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Julie Kim <jkim@igalia.com> Cr-Commit-Position: refs/heads/master@{#721309}
-
Julie Jeongeun Kim authored
This CL cleans up comments about mojo::StrongBinding* since it's old Mojo type and replaced with mojo::SelfOwnedReceiver, mojo::UniqueReceiverSet, or mojo::Receiver. NOTRY=true Bug: 955171 Change-Id: I49094d8054ca56d48740ce27efb4f2695b4c4d52 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1941447 Commit-Queue: Julie Kim <jkim@igalia.com> Reviewed-by:
Matt Reynolds <mattreynolds@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
-
Julie Jeongeun Kim authored
This CL cleans up old Mojo types for WorkerContentSettingsProxy using PendingRemote. It also updates struct EmbeddedWorkerStartParams from embedded_worker.mojom. Bug: 955171 Change-Id: I4cea85ea58050c83e216a12b977747ed24c905c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1948387Reviewed-by:
-
Jarryd Goodman authored
This change fixes the comment to reference the correct variable name. Change-Id: I01d580306e1b10caf10e14f57c6efd927be53638 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1948958 Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#721306}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/fc2dd45054bf..a5045ac36d17 git log fc2dd45054bf..a5045ac36d17 --date=short --first-parent --format='%ad %ae %s' 2019-12-03 syoussefi@chromium.org glslang.l: refactor extension checks 2019-12-03 syoussefi@chromium.org Automatically call flex/bison if necessary 2019-12-03 syoussefi@chromium.org Vulkan: Fix WaW same-layout image transitions 2019-12-03 jmadill@chromium.org Revert "Add new test runner harness." 2019-12-03 geofflang@chromium.org D3D9: Log the exact error code generated by D3D9 device creation. 2019-12-03 geofflang@chromium.org Skip flaky BlendMinMaxTest.RGBA16F/ES2_Metal. Created with: gclient setdep -r src/third_party/angle@a5045ac36d17 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC geofflang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1029091,chromium:1030192 Tbr: geofflang@google.com Change-Id: Iac0bf0c85816b099675c835b087d28778d1a652e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949168Reviewed-by:
-
Carlos Caballero authored
Remove WebContentsMainFrameObserver and use a new RenderFrameHost::IsDOMContentLoaded() method instead to determine if a frame has loaded the DOM content. Bug: 1011819 Change-Id: I816999b12e2f811db5b760b290f32134b5937576 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940152Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Camille Lamy <clamy@chromium.org> Commit-Queue: Carlos Caballero <carlscab@google.com> Cr-Commit-Position: refs/heads/master@{#721304}
-
Julie Jeongeun Kim authored
This CL cleans up old Mojo types for service_manager::mojom::InterfaceProvider using PendingReceiver, Receiver, and PendingRemote. It also updates struct DocumentScopedInterfaceBundle from document_scoped_interface_bundle.mojom and struct ServiceWorkerProviderInfoForStartWorker from service_worker_provider.mojom Bug: 955171 Change-Id: I57459c96295dabf5137054daa30ec47ebd950361 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1948580Reviewed-by:
Luke Halliwell (slow) <halliwell@chromium.org> Reviewed-by:
-
Tibor Goldschwendt authored
It's no longer needed after downstream update. TBR=trivial Change-Id: I3982fb71edd8b41c78e92e177ce1c7dc5a1015f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904548 Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#721302}
-
Miyoung Shin authored
This change converts QuotaDispatcherHost mojom interface client in blink to use BrowserInterfaceBroker. Bug: 936482 Change-Id: Ib4879ab100af2aaf69ee763cf2767fdd50ec2f3a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1824731Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Reviewed-by:
-
Jia authored
We are implementing a local search service using approximate string matching for query search. Currently the approximate string matching algorithm is implemented as FuzzyTokenizedStringMatch under chrome/browser/ui/app_list/search/search_utils/ and we will need to migrate this function to a location that can be used by the local search service (under chrome/services/). This cl moves FuzzyTokenizedStringMatch, TokenizedString and all other related string matching functions to //chrome/common/string_matching so that they can be shared by current clients and also future local search service. Design doc for local search service: go/cros-search-service Bug: 1018613 Change-Id: If5648bf3046d52dd92ab5479dd94916552a99786 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1939128Reviewed-by:
Thanh Nguyen <thanhdng@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
-
Noel Gordon authored
cr.ui.Tree has a default row style handler that applies inline style to rows to indent them (depth * 20px) using CSS padding-inline-start. files-ng requires (depth * 22px) of indent. Add a custom cr.ui.Tree row style handler for the files-ng case. Apply the indent style to the .tree-row > .file-row element. Also style its minWidth to be 12px after the row .item-icon to account for the rounded CSS border style of .tree-row > .file-row [1]. Per the current row design: 6px padding + 20px more-icon + 2px gap then 20px item-icon + then the 12px I mentioned: totals 60px. [1] if the directory tree is narrowed, the .file-row's round border can be drawn over the .item-icon (or over any element to its left depending on the tree width) if the .file-row has no minWidth style. Bug: 992819 Change-Id: I9ec261846ccb7a7e09d907dfbf23b089279f3110 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1946057Reviewed-by:
Alex Danilo <adanilo@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#721299}
-
Darwin Huang authored
Bug: 1021016, 1026862, 1028615, 1028772 Change-Id: I4408b981271ccc3d21e8fa06db1fd8b69e32e386 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949483Reviewed-by:
Chris Mumford <cmumford@google.com> Commit-Queue: Darwin Huang <huangdarwin@chromium.org> Cr-Commit-Position: refs/heads/master@{#721298}
-
Jinsuk Kim authored
Now that the build is updated to the latest SDK, Q-only methods/fields accessed through reflection can be written without them. Change-Id: I96f35a25b5f026db06c77838ebee2a312fe0d439 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1948007 Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#721297}
-
Balazs Engedy authored
Update GetChromeUrlApiId() to use {WINDOWS|LINUX|OSX|ANDROID}_PLATFORM as |platform_type|, based on the current platform, instead of CHROME_PLATFORM being hard-coded. This change also necessitates relaxing the check in V4GetHashProtocolManager::ParseMetadata to expect permission-related metadata to be present for each of the above, now platform-specific, versions of the API_ABUSE list. Bug: 1028642 Change-Id: I88f917f04368470b77eca647972883d859fdcbc9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1945823 Commit-Queue: Balazs Engedy <engedy@chromium.org> Reviewed-by:Varun Khaneja <vakh@chromium.org> Cr-Commit-Position: refs/heads/master@{#721296}
-
Aaron Tagliaboschi authored
Bug: 1017166 Change-Id: I627c576a322c5e701fad105659b213c415e32a40 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940207Reviewed-by:
Yoav Weiss <yoavweiss@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Aaron Tagliaboschi <aarontag@chromium.org> Cr-Commit-Position: refs/heads/master@{#721295}
-
Sean Kau authored
https://chromium.googlesource.com/chromiumos/platform2/system_api.git/+log/ac7755fac459..4bab6cb11c26 $ git log ac7755fac..4bab6cb11 --date=short --no-merges --format='%ad %ae %s' 2019-11-27 skau system_api: Register org.chromium.PrintersService Created with: roll-dep src/third_party/cros_system_api Bug: b:143242799 Change-Id: Ie7ced8e7e97219e3d86657a74870a2957bf9fbf6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949029Reviewed-by:
-
Ahmed Fakhry authored
When the device is physically used as a tablet (e.g. detached or flipped), the keyboard shortcut to rotate the display should behave as a request to lock the user orientation to the next rotation of the internal display. App windows are allowed to lock the rotation to a particular orientation in tablet UI mode on the internal display only. In this case, the shortcut should switch between the allowed rotations if any, or do nothing. For example: - If a window locks the rotation to kPortrait, the shortcut should switch the user rotation lock between kPortriatPrimary and kPortraitSecondary. - If a window locks the rotation to kPortraitSecondary, then the shortcut should do nothing. BUG=925087, 1026398 TEST=Manually, Added a new test. Change-Id: I34bf76a336ef81de4f1f5269843a3dd8c5efcd4a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1892054 Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#721293}
-
Caleb Rouleau authored
This helps to create balanced shard maps. Specifically for weblayer bot, this will help us add startup.mobile without unbalancing the shard maps. Bug: 1026327 Change-Id: I8f5ebceba13cc6f7de8450389ecf59410425e1c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949239 Commit-Queue: Caleb Rouleau <crouleau@chromium.org> Reviewed-by:
John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#721292}
-
Vitaly Buka authored
Callback should set result if it returned true. Detected with "init_stack_vars = true". Bug: 1030261 Change-Id: I9088a0ab498c44f9a765bf89361c91298d9458e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949643Reviewed-by:
Albert J. Wong <ajwong@chromium.org> Commit-Queue: Vitaly Buka <vitalybuka@chromium.org> Cr-Commit-Position: refs/heads/master@{#721291}
-
