GitLab

BUG=None
TEST=ninja -C out/Debug gn_unittests
TBR=brettw@chromium.org

Review URL: https://codereview.chromium.org/583453003

Cr-Commit-Position: refs/heads/master@{#295853}

BUG=397754
R=mattm@chromium.org

Review URL: https://codereview.chromium.org/578103002

Cr-Commit-Position: refs/heads/master@{#295852}

This CL lays the ground work for implementing in process native messaging.

It extracts a common interface |NativeMessagingChannel| outs of
native_messaging_channel.h and renames the existing implementation
to pipe_messaging_channel.

This CL is best reviewed by diffing against patch set 1.

Review URL: https://codereview.chromium.org/558403002

Cr-Commit-Position: refs/heads/master@{#295851}

BUG=388885

Review URL: https://codereview.chromium.org/590593002

Cr-Commit-Position: refs/heads/master@{#295850}

When the InfoBarContainer is first attached to the window,
View.initialAwakenScrollBars() is called on it. Even though the scrollbars
aren't visible, this schedules a delayed runnable to fade out the scrollbars
1.2 seconds later. This delayed runnable (View$ScrollabilityCache) then calls
View.invalidate() repeatedly as it fades out the (already invisible) scrollbar,
which pauses scroll updates and touch event handling for 10 to 15 frames.

This CL disables the scrollbars on the InfoBarContainer, except in the rare
case that the container is actually scrollable (i.e. when infobars take up the
entire screen). In that case, page jank doesn't matter since the user can't
even see the webpage!

BUG=407149
NOTRY=true

Review URL: https://codereview.chromium.org/588843002

Cr-Commit-Position: refs/heads/master@{#295849}

All DataReductionProxy.BypassedBytes.* UMA that don't have an explicit triggering
request UMA need to count the triggering request bytes.

BUG=413771

Review URL: https://codereview.chromium.org/566943004

Cr-Commit-Position: refs/heads/master@{#295848}

This patch was generated by running the rewrite_scoped_refptr clang tool
on a Mac build.

BUG=110610

Review URL: https://codereview.chromium.org/590493002

Cr-Commit-Position: refs/heads/master@{#295847}

SubstitutionPatterm -> SubstitutionPattern
SubstutitionWriter -> SubstitutionWriter

BUG=None
TEST=ninja -C out/Debug gn_unittests - compare the output before and
after this change.
TBR=brettw@chromium.org

Review URL: https://codereview.chromium.org/590683002

Cr-Commit-Position: refs/heads/master@{#295846}

BUG=415792
TBR=thestig@chromium.org

Review URL: https://codereview.chromium.org/586133002

Cr-Commit-Position: refs/heads/master@{#295845}

This used to return RWX, but regressed as of
314a240e.

BUG=none
R=sbc@chromium.org
R=bradnelson@chromium.org

Review URL: https://codereview.chromium.org/587933003

Cr-Commit-Position: refs/heads/master@{#295844}

BUG=386033,365418

Review URL: https://codereview.chromium.org/589523003

Cr-Commit-Position: refs/heads/master@{#295843}

It was being done as a one-off in app_shell and replicated in Chrome.
Moved it to RegisterCommonManifestHandlers() where it belongs.

BUG=none
TEST=extensions_unittests, unit_tests

Review URL: https://codereview.chromium.org/586873003

Cr-Commit-Position: refs/heads/master@{#295842}

This mostly just adds the missing dependency identified by the checker.

In some cases I looked at the target and added public_deps that I thought were appropriate given the nature of the target.

This renames the generated mojo action names to be foo__generator instead of foo_generator since it is not clear from the current name that it is an internally-generated target and I kept trying to use it. The double-underscore matches the Android generated targets.

In a few cases I changed ordering (sources come before deps in GN style) but I didn't want to make the changes difficult to diff so didn't do it for most cases.

Reland of https://codereview.chromium.org/581273003/
TBR=darin

Review URL: https://codereview.chromium.org/591763002

Cr-Commit-Position: refs/heads/master@{#295841}

BUG=415697

Review URL: https://codereview.chromium.org/589693002

Cr-Commit-Position: refs/heads/master@{#295840}

If an extension is detected to be corrupt, introduce an
option to repair it, if it is from the webstore.

Also reposition the "Reload" link (for reload terminated
extensions) to be next to the trash can, rather than above
it.

Screenshots: http://imgur.com/35tL9Xz,CslEoW5

BUG=410896

Review URL: https://codereview.chromium.org/557953005

Cr-Commit-Position: refs/heads/master@{#295839}

Writable operations are completed and pretty stable, so it's time to let
developers know about them and start using them!

TEST=Confirmed on a testing doc server.
BUG=248427

Review URL: https://codereview.chromium.org/583893002

Cr-Commit-Position: refs/heads/master@{#295838}

This patch was generated by running the rewrite_scoped_refptr clang tool
on a Mac build.

BUG=110610

Review URL: https://codereview.chromium.org/584103002

Cr-Commit-Position: refs/heads/master@{#295837}

For these functions the default no-op behavior is fine, so remove the calls
to NOTIMPLEMENTED to reduce log spam.

BUG=none
TEST=none
TBR=yoz@chromium.org for changing a comment in extensions/

Review URL: https://codereview.chromium.org/587913002

Cr-Commit-Position: refs/heads/master@{#295836}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/45725db..d49226c

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=stephana@google.com

Review URL: https://codereview.chromium.org/583413002

Cr-Commit-Position: refs/heads/master@{#295835}

R=michaelpg@chromium.org
BUG=416133

Review URL: https://codereview.chromium.org/583193007

Cr-Commit-Position: refs/heads/master@{#295834}

BUG=415683

Review URL: https://codereview.chromium.org/582833003

Cr-Commit-Position: refs/heads/master@{#295833}

BUG=415852

Review URL: https://codereview.chromium.org/586063003

Cr-Commit-Position: refs/heads/master@{#295832}

BUG=388885

Review URL: https://codereview.chromium.org/586903003

Cr-Commit-Position: refs/heads/master@{#295831}

Two lists ftw!

R=maruel@chromium.org
BUG=416120

Review URL: https://codereview.chromium.org/589703002

Cr-Commit-Position: refs/heads/master@{#295830}

BUG=352293

Review URL: https://codereview.chromium.org/583233003

Cr-Commit-Position: refs/heads/master@{#295829}

Review URL: https://codereview.chromium.org/572603005

Cr-Commit-Position: refs/heads/master@{#295828}

BUG=

Review URL: https://codereview.chromium.org/584543003

Cr-Commit-Position: refs/heads/master@{#295827}

When --allow-sandbox-debugging is used, we set-up a new signal
handler in the Zygote (inherited by all renderers) that performs a
chroot().

This allows testing of sandbox violation crash report with official
binaries shipping to users.

BUG=415842
R=mdempsky@chromium.org

Review URL: https://codereview.chromium.org/585123003

Cr-Commit-Position: refs/heads/master@{#295826}

For clients that are part of the finch trial, change the proxy bypass
logic to not trigger a proxy bypass when a response with a non-4xx
response code is expected to have the data reduction proxy header, but
the data reduction proxy via header is missing.

BUG=413035

Review URL: https://codereview.chromium.org/583363002

Cr-Commit-Position: refs/heads/master@{#295825}

is not handled. Added a histogram to track how often this happens.

R=rch@chromium.org,rjshade@chromium.org,  asvitkine@chromium.org

Review URL: https://codereview.chromium.org/583063002

Cr-Commit-Position: refs/heads/master@{#295824}

Introduce "Preferred" accelerators, which may be processed by fullscreen, but will otherwise be processed first.

BUG=398905
TEST=covered by unit tests

Review URL: https://codereview.chromium.org/582143004

Cr-Commit-Position: refs/heads/master@{#295823}

This will be needed to move the "paused message queue" into the
ChannelEndpoint, since transferring messages from the
LocalMessagePipeEndpoint needs to happen "atomically" with its
conversion to a ProxyMessagePipeEndpoint. (Before the MessagePipe lock
is released, the ProxyMessagePipeEndpoint needs to have a place to queue
messages, and any already-queued messages must be at the front of that
queue.)

R=darin@chromium.org

Review URL: https://codereview.chromium.org/585093002

Cr-Commit-Position: refs/heads/master@{#295822}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/686c9e7..5f95dbe

TBR=caseq@chromium.org,pdr@chromium.org,wjmaclean@chromium.org

Review URL: https://codereview.chromium.org/588773002

Cr-Commit-Position: refs/heads/master@{#295821}

BUG=388885

Review URL: https://codereview.chromium.org/585103002

Cr-Commit-Position: refs/heads/master@{#295820}

BUG=316383

Review URL: https://codereview.chromium.org/566643002

Cr-Commit-Position: refs/heads/master@{#295819}

Review URL: https://codereview.chromium.org/590613002

Cr-Commit-Position: refs/heads/master@{#295818}

BUG=

Review URL: https://codereview.chromium.org/581853002

Cr-Commit-Position: refs/heads/master@{#295817}

new api on ApplicationManager.

BUG=

Review URL: https://codereview.chromium.org/568173003

Cr-Commit-Position: refs/heads/master@{#295816}

Revert of Enable incremental linking for static_library too (patchset #2 id:20001 of https://codereview.chromium.org/502993005/)

Reason for revert:
Does not appear to work well for waterfall workload, see number of instances of "performing full link" in http://build.chromium.org/p/chromium.win/builders/Win%20Builder/builds/2780/steps/compile/logs/stdio

Might still be worth investigating if it's worthwhile on trybots where less things might change per-job? But doesn't seem that likely.

Original issue's description:
> Enable incremental linking for static_library too
>
> Timings on z620:
>
> Without:
>
> GYP_DEFINES=component=static_library chromium_win_pch=0 incremental_chrome_dll=0
>
> touch content\app\main.cc (causes chrome.dll, chrome_child.dll, and unit_tests.exe to relink)
> tim ninja -C out\Release unit_tests
> [19/19] LINK_EMBED unit_tests.exe
>
> real: 4m46.828s
>
> With:
>
> GYP_DEFINES=component=static_library branding=Chrome chromium_win_pch=0 incremental_chrome_dll=1
>
> touch content\app\content_main.cc && tim ninja -C out\Release unit_tests
> ninja: Entering directory `out\Release'
> [19/19] LINK_EMBED unit_tests.exe
>
> real: 0m43.625s
>
> This is basically best case, and the actual performance on bots will differ based on
> their config and the number of files that change from run-to-run, but it seems worth
> enabling to see what happens, at least.
>
> R=jam@chromium.org
> BUG=404809,402270
>
> Committed: https://crrev.com/6922bc1d4b0a2f4604598082a877d3add6d86d1c
> Cr-Commit-Position: refs/heads/master@{#295786}

TBR=jam@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=404809,402270

Review URL: https://codereview.chromium.org/591723003

Cr-Commit-Position: refs/heads/master@{#295815}

BUG=388885

Review URL: https://codereview.chromium.org/587833003

Cr-Commit-Position: refs/heads/master@{#295814}