GitLab

This patch moves |{next,previous}PositionOf()| for |VisiblePosition| to
"VisibleUnits.cpp" form "VisiblePosition.cpp" to make "VisiblePosition.cpp"
to simpler for improving code health and ease of templatizing |VisiblePosition|
class to introduce composed tree version.

This patch is a preparation of making selection to handle granularity for web
component, http://crrev.com/1277863002

BUG=513568
TEST=n/a; no behavior changes

Review URL: https://codereview.chromium.org/1307023005

git-svn-id: svn://svn.chromium.org/blink/trunk@201500 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Mandoline uses WebFrameWidgetImpl for an iframe, and it could
be in a separate process from the main frame. And touch events
are dispatched to iframe directly, so this CL add gesture support 
for WebFrameWidgetImpl.


BUG=522592

Review URL: https://codereview.chromium.org/1313763004

git-svn-id: svn://svn.chromium.org/blink/trunk@201499 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=518999,526594

Review URL: https://codereview.chromium.org/1322753003

git-svn-id: svn://svn.chromium.org/blink/trunk@201498 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Back in the mists of time, BlobBuilder called UTF8Encoding().encode()
when appending strings, which looks correct. But then mean old
https://crbug.com/117128 came along pointing out that encode() was
actually NFC normalizing strings even when not wanted, so
https://crrev.com/19845004 cleverly renamed the function to
normalizeAndEncode() so future callers would not fall into this trap.
A few existing places such as XHR were eventually changed to just call
encode() (https://crrev.com/22875053) but no-one noticed BlobBuilder
was getting it wrong prior to this bug report.

Change the BlobData::appendText() method to just call encode(), and
add a test case for the Blob constructor.

The new behavior matches FF and IE.

BUG=427183
R=kinuko@chromium.org

Review URL: https://codereview.chromium.org/1305393006

git-svn-id: svn://svn.chromium.org/blink/trunk@201497 bbb929c8-8fbe-4397-9dbb-9b2b20218538

For consistency with the timeline and profiles panel, network should have
the same shortcut for toggling recording.

BUG=

Review URL: https://codereview.chromium.org/1310073007

git-svn-id: svn://svn.chromium.org/blink/trunk@201496 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Fix handling of emojiFonts in getFontBasedOnUnicodeBlock, the emojiFonts
field was incorrectly not marked as static and thus would only be set on
the very first invocation of the method.

TEST=fast/text/emoji-font-fallback-win.html
BUG=516580
R=wkorman@chromium.org

Review URL: https://codereview.chromium.org/1312903004

git-svn-id: svn://svn.chromium.org/blink/trunk@201495 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Previously we paint outlines and focus rings in very different paths.
- Focus rings are painted in the way that we collect all rects first
  then combine the rects into a enclosing path, then paint the path.
- Outlines are painted by each box, line box, continuations, causing
  difficulties when handling the joints. We have issues of broken
  joints, unconnected segments, missing segments, etc.

With this CL:
- We paint outlines and focus rings in the same way: collect rects first
  paint the path. This resolves the original issues of broken joints and
  unconnected segments, etc.;
- Don't need to propagate outline style to continuations because the
  outline owner paints the whole outline. This enables us to paint a
  whole connected outline enclosing the continuations.

BUG=506669

Review URL: https://codereview.chromium.org/1224933002

git-svn-id: svn://svn.chromium.org/blink/trunk@201494 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Update the comment for WebInputEvent.timeStampSeconds to reflect 
what Chrome actually delivers.

BUG=none

Review URL: https://codereview.chromium.org/1320193002

git-svn-id: svn://svn.chromium.org/blink/trunk@201493 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Currently it's only exposed to the HTTP family, but now that Chrome
extensions support service workers they need to support the fetch API.
This patch adds registerURLSchemeAsSupportingFetchAPI to the Blink API,
queried by the fetch API code as shouldTreatURLSchemeAsSupportingFetchAPI.

BUG=466876
R=yhirano@chromium.org, dcheng@chromium.org, pdr@chromium.org

Review URL: https://codereview.chromium.org/1313733006

git-svn-id: svn://svn.chromium.org/blink/trunk@201492 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=526315

Review URL: https://codereview.chromium.org/1313863003

git-svn-id: svn://svn.chromium.org/blink/trunk@201491 bbb929c8-8fbe-4397-9dbb-9b2b20218538

[Line Layout API] Add hasOverflowModel, logicalVisualOverflowRectForPropagation, and logicalLayoutOverflowRectForPropagation to API

This CL updates all callers (all in InlineFlowBox).

BUG=499321

Review URL: https://codereview.chromium.org/1323803002

git-svn-id: svn://svn.chromium.org/blink/trunk@201490 bbb929c8-8fbe-4397-9dbb-9b2b20218538

We're currently recording an optional clip in the image drawing.  Since we have a specialized
recorder/display item for clips (and to simplify the implementation of the image recorder),
we can apply the clip independent of the image recording.

R=chrishtr@chromium.org,vmpstr@chromium.org

Review URL: https://codereview.chromium.org/1322613004

git-svn-id: svn://svn.chromium.org/blink/trunk@201489 bbb929c8-8fbe-4397-9dbb-9b2b20218538

TBR=haraken@chromium.org
NOTRY=true
BUG=521730,410145,521764,526752,440452

Review URL: https://codereview.chromium.org/1319083006

git-svn-id: svn://svn.chromium.org/blink/trunk@201488 bbb929c8-8fbe-4397-9dbb-9b2b20218538

WebViewHelper::initializeAndLoad() doesn't take ownership of the optional
frame client parameter.  All other subclasses of TestWebFrameClient are
constructed on the stack too.

Fixes leaks like
Direct leak of 16 byte(s) in 1 object(s) allocated from:
    #0 0x5b2ea0 in operator new(unsigned long) /b/build/slave/ClangToTLinuxASan/build/src/third_party/llvm/compiler-rt/lib/asan/asan_new_delete.cc:62
    #    #1 0x1799216 in blink::WebPluginContainerTest_Copy_Test::TestBody() third_party/WebKit/Source/web/tests/WebPluginContainerTest.cpp:242:99
    #

BUG=523910,245126,494827

Review URL: https://codereview.chromium.org/1308663004

git-svn-id: svn://svn.chromium.org/blink/trunk@201487 bbb929c8-8fbe-4397-9dbb-9b2b20218538

When trying to find the size of a flexible grid item the algorithm must
perform several steps, which are described in the following section of
the spec:

https://drafts.csswg.org/css-grid/#algo-find-fr-size

When the flex factor sum is less than 1, we should use 1 instead so we
can apply each factor to the total available size to fill.

BUG=520477

Review URL: https://codereview.chromium.org/1321573005

git-svn-id: svn://svn.chromium.org/blink/trunk@201486 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=473220

Review URL: https://codereview.chromium.org/1301993003

git-svn-id: svn://svn.chromium.org/blink/trunk@201484 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This ensures that we always get correct slow scroll regions 
even when full layout is skipped in favor of faster OverflowRecalc.

TEST=scrollingcoordinator/non-fast-scrollable-transform-changed.html
BUG=417345

Review URL: https://codereview.chromium.org/1256043007

git-svn-id: svn://svn.chromium.org/blink/trunk@201483 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://heycam.github.io/webidl/#es-invoking-callback-functions
By default, "the callback this value" should be "undefined".

In strict mode,
- before: this value was window (global object).
- after: this value is undefined

In non-strict mode,
undefined (or null) this value is converted to the global object.
This conversion is done in V8.  So user script observes no change.

See http://www.ecma-international.org/ecma-262/5.1/#sec-10.4.3

Note: This CL changes the callback this value from the window object of the receiver to the global object of the running script.
Example) Suppose running the following script in a child window.
    function f() { console.log(this); }
    top.requestAnimationFrame(f);
before: this === top
after: this === window (child window)

BUG=332663

Review URL: https://codereview.chromium.org/1301423004

git-svn-id: svn://svn.chromium.org/blink/trunk@201482 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Upon executing a javascript: URL in an empty document, we take care to
notify that the load has started. Should the result of executing the
script code be no result and navigation, balance the progress notifications
by signalling completion also.

R=haraken
BUG=495495

Review URL: https://codereview.chromium.org/1158973004

git-svn-id: svn://svn.chromium.org/blink/trunk@201481 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Added STATIC_ONLY, STACK_ALLOCATED, DISALLOW_ALLOCATION, or ALLOW_ONLY_INLINE_ALLOCATION
instead of WTF_MAKE_FAST_ALLOCATED(_WILL_BE_REMOVED) if possible.

BUG=523249

Review URL: https://codereview.chromium.org/1321723004

git-svn-id: svn://svn.chromium.org/blink/trunk@201480 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch moves member function |rootEditableElement()| out from
|VisiblePosition| class as global funciton |rootEditableElementOf()| to simplify
|VisiblePosition| for introducing composed tree version of |VisiblePosition|.

This patch is a preparation of making selection to handle granularity for web
component, http://crrev.com/1277863002

BUG=513568
TEST=n/a; no behavior changes

Review URL: https://codereview.chromium.org/1312213008

git-svn-id: svn://svn.chromium.org/blink/trunk@201479 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Added STATIC_ONLY, STACK_ALLOCATED, DISALLOW_ALLOCATION, or ALLOW_ONLY_INLINE_ALLOCATION
instead of WTF_MAKE_FAST_ALLOCATED(_WILL_BE_REMOVED) if possible.

BUG=523249

Review URL: https://codereview.chromium.org/1323493004

git-svn-id: svn://svn.chromium.org/blink/trunk@201478 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch introduces |visiblePositionOf()| for |Position| and
|PositionInComposedTree| as preparation of templatizing |VisiblePosition| to
make |VisiblePosition| not to use |PositionInComposedTree| for introducing
composed tree version of |VisiblePosition|.

This patch is a preparation of making selection to handle granularity for web
component, http://crrev.com/1277863002

BUG=513568
TEST=n/a; No behavior changes

Review URL: https://codereview.chromium.org/1314433011

git-svn-id: svn://svn.chromium.org/blink/trunk@201477 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch gets rid of static function |localCaretRectOf()| by expanding it
into call sites with |localCaretRectOfPosition()| to simplify
"VisiblePosition.cpp" for improving code health.

This patch is a preparation of making selection to handle granularity for web
component, http://crrev.com/1277863002

BUG=513568
TEST=n/a; no behavior changes

Review URL: https://codereview.chromium.org/1321183002

git-svn-id: svn://svn.chromium.org/blink/trunk@201476 bbb929c8-8fbe-4397-9dbb-9b2b20218538

- Specify action= attributes to avoid recursive loading of
  form-submission-cancelable.html.
- Sequentially submit two forms.
- The FAIL line in the updated expectation file is intentional.

BUG=353066,196640

Review URL: https://codereview.chromium.org/1323573005

git-svn-id: svn://svn.chromium.org/blink/trunk@201475 bbb929c8-8fbe-4397-9dbb-9b2b20218538

When we serialize style data for an OPTION, we had a bug that the OPTION style
was compared to the SELECT style even though the OPTION is in an OPTGROUP.  We
should compare with the OPTGROUP style.

BUG=526077

Review URL: https://codereview.chromium.org/1325623002

git-svn-id: svn://svn.chromium.org/blink/trunk@201474 bbb929c8-8fbe-4397-9dbb-9b2b20218538

R=haraken
BUG=

Review URL: https://codereview.chromium.org/1321173002

git-svn-id: svn://svn.chromium.org/blink/trunk@201473 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This change makes the CSSParserMode parameter required for
MutableStylePropertySet::create() instead of defaulting to HTMLQuirksMode.
This makes it clearer where quirky parsing is present in the code.

There are no behavioural changes in this patch.

Review URL: https://codereview.chromium.org/1320013005

git-svn-id: svn://svn.chromium.org/blink/trunk@201472 bbb929c8-8fbe-4397-9dbb-9b2b20218538

imported csswg-test@52d89987f858517eb30d67a09c6cc73a28ab50aa
imported web-platform-tests@cef67e0624545b66aeca774af90d899bf3c6bd4d

* New/modified tests that fail:
  - 1 in html/rendering
  - 1 in css-writing-modes-3

* Tests fixed in upstream and passes (partially):
  - html/dom/documents/dom-tree-accessors/document.forms.html

* Tests showing flaky crashes:
  - 2 in html/semantics/embedded-content

BUG=490511, 492664

Review URL: https://codereview.chromium.org/1319333002

git-svn-id: svn://svn.chromium.org/blink/trunk@201471 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This CL just enables the test, not fixes any issue.

We'll fix the issues step by step.  Since some of
Location's attributes are cross-origin accessible,
we can't fix all the issues right away.


BUG=491006

Review URL: https://codereview.chromium.org/1303403007

git-svn-id: svn://svn.chromium.org/blink/trunk@201470 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Changed Pair to be a CSSValue called CSSValuePair (consistent naming
with CSSValueList), and removed all references to Pair from
CSSPrimitiveValue.

BUG=523893

Review URL: https://codereview.chromium.org/1317523002

git-svn-id: svn://svn.chromium.org/blink/trunk@201469 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=526608

Review URL: https://codereview.chromium.org/1306083008

git-svn-id: svn://svn.chromium.org/blink/trunk@201468 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch moves |honorEditingBoundaryAtOr{Before,After}()| out from
|VisiblePosition| class to simplify |VisiblePosition| for introducing
composed tree version of |VisiblePosition|.

This patch is a preparation of making selection to handle granularity for web
component, http://crrev.com/1277863002

BUG=513568
TEST=n/a; no behavior changes

Review URL: https://codereview.chromium.org/1313963003

git-svn-id: svn://svn.chromium.org/blink/trunk@201467 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch moves |makeRange()| with |VisiblePosition| to "EditingUtilities.cpp"
from "VisiblePosition.cpp" to simplify "VisiblePosition.cpp" for improving code
health, since it doesn't depend of implementation of |VisiblePosition| class.

BUG=n/a
TEST=n/a; no behavior changes

Review URL: https://codereview.chromium.org/1320313002

git-svn-id: svn://svn.chromium.org/blink/trunk@201466 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Adds frame tags in order to correlate creations with their causes.

BUG=475370

Review URL: https://codereview.chromium.org/1322493004

git-svn-id: svn://svn.chromium.org/blink/trunk@201465 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=523249

Review URL: https://codereview.chromium.org/1321453012

git-svn-id: svn://svn.chromium.org/blink/trunk@201464 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch moves member functions |skipTo{Start,End}OfEditingBoundary()| out
from |VisiblePosition| to simplify |VisiblePosition| for improving code health
since they are use in global functions |{previous,next}PositionOf()|.

BUG=513568
TEST=n/a; no behavior chagnes

Review URL: https://codereview.chromium.org/1309513007

git-svn-id: svn://svn.chromium.org/blink/trunk@201462 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Blink failed to check whether the left-most matched selector ends up
in Document TreeScope.
The check was only enabled for querySelector*() is called on
a regular element, not on document.

This issue can be exposed by passing "::shadow" or "/deep/"
which pierces shadow boundary and the selector can
incorrectly match inside shadow.

BUG=511486
TEST=fast/dom/shadow/querySelector-with-shadow-all-and-shadow-deep.html

Review URL: https://codereview.chromium.org/1245933002

git-svn-id: svn://svn.chromium.org/blink/trunk@201461 bbb929c8-8fbe-4397-9dbb-9b2b20218538

EditingTestBase::setShadowContent

It is hard to understand setShadowContent puts content to a 'host' ID element.
Let's call explicitly.

BUG=
TEST=<no behavior changes>

Review URL: https://codereview.chromium.org/1304363008

git-svn-id: svn://svn.chromium.org/blink/trunk@201460 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Cleaned up CSSPrimitiveValue::getString() to only return the string
value if the unit type is a string (attribute, URL, String or custom
ident). Also cleaned up callsites and added asserts to better document
the expected behavior.

BUG=523893

Review URL: https://codereview.chromium.org/1307673003

git-svn-id: svn://svn.chromium.org/blink/trunk@201459 bbb929c8-8fbe-4397-9dbb-9b2b20218538