- 03 Mar, 2020 40 commits
-
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/964aa91580b6..4036cb1f0b6e git log 964aa91580b6..4036cb1f0b6e --date=short --first-parent --format='%ad %ae %s' 2020-03-03 borenet@google.com [recipes] Re-disable SKPs on iOS and images on GPU in nanobench 2020-03-03 robertphillips@google.com Switch member destructor order in SkDeferredDisplayList 2020-03-03 senorblanco@chromium.org Dawn backend: update to onBindBuffer() changes. 2020-03-03 mtklein@google.com have each program own LLVMContext 2020-03-03 mtklein@google.com Program::LLVMState Created with: gclient setdep -r src/third_party/skia@4036cb1f0b6e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC herb@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: herb@google.com Change-Id: I5e1c77b4bb9db09bc9050dee68583dbd7b9d8004 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2082328Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#746535}
-
David Benjamin authored
https://boringssl.googlesource.com/boringssl/+log/6432bb46ab44731567ec923e6c8fc182f13d0070..1e859054c31ec7b974e998373e85fadea56d93ad The following commits have update notes: 1e859054c Revise QUIC encryption secret APIs. Bug: none Change-Id: Ie8b96b49e7b6b7347f6276fd3171f0ca701ed878 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2085153 Auto-Submit: David Benjamin <davidben@chromium.org> Reviewed-by:
Nick Harper <nharper@chromium.org> Commit-Queue: Nick Harper <nharper@chromium.org> Cr-Commit-Position: refs/heads/master@{#746534}
-
Ben Mason authored
TBR=govind@chromium.org Change-Id: I4317d1955e2bb61438393968dca7ce5b9ff4922a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2085393Reviewed-by:
Ben Mason <benmason@chromium.org> Reviewed-by:
Krishna Govind <govind@chromium.org> Commit-Queue: Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/heads/master@{#746533}
-
Anastasia Helfinstein authored
This CL takes another step towards encapsulating action behavior in the node classes. Bug: None Change-Id: If709c22606016930ce715168d50a7a2f7176788c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2076443 Commit-Queue: Anastasia Helfinstein <anastasi@google.com> Reviewed-by:
David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#746532}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/5e1ea251895c..ccefde95b3bb git log 5e1ea251895c..ccefde95b3bb --date=short --first-parent --format='%ad %ae %s' 2020-03-03 natim@webrtc.org VoIP interfaces API enhancement (continuation of 169000) Created with: gclient setdep -r src/third_party/webrtc@ccefde95b3bb If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: Ia660619f4db25239346f1eefb20229e56661361a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2082330Reviewed-by:
-
Mike Reed authored
Bug: skia:9984 Change-Id: Ib6e455522db9c73e9bba95ec28a96e4f6a92c8d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2085119Reviewed-by:
Florin Malita <fmalita@chromium.org> Reviewed-by:
Mike Reed <reed@google.com> Commit-Queue: Mike Reed <reed@google.com> Cr-Commit-Position: refs/heads/master@{#746530}
-
Paulo Warren authored
This CL begins the work of adding the ability to pass a SurfaceHandle to the SharedImageInterface. In some circumstances, we previously got around this by first creating a gpuMemoryBuffer, and using the CreateSharedImage that uses the gpuMemoryBuffer. This is problematic because the BufferQueue needed to keep track of the gpu memory buffer, instead of the gpu process doing it for us. This CL modifies four interfaces: SharedImageInterface, SharedImageFactory, SharedImageBackingFactory, and ImageFactory. They have all been modified to accept and pass through a SurfaceHandle. This allows us to remove the |buffer| from BufferQueue::AllocatedSurface, as well as the |gpu_memory_buffer_manager_| from BufferQueue. This is a mechanical change that is not intended to change behavior. I followed these rules when modifying the interfaces: 1. Any previous call to CreateSharedImage or CreateAnonymousImage was passed a SurfaceHandle if applicable, gpu::kNullSurfaceHandle if not. 2. The implementations of SharedImageBackingFactory were modified to accept a SurfaceHandle. Only SharedImageBackingFactoryGLTexture passes the SurfaceHandle to ImageFactory::CreateAnonymousBuffer BUG=958670 TEST=autoninja -C out/Default components/viz:viz_unittests Change-Id: I5f1263a6421761c8a2805d4ab087c35f848cfe17 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2070820 Commit-Queue: Paulo Warren <pwarren@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#746529}
-
Rakib M. Hasan authored
This CL follows up on crrev.com/c/2070672. It adds necessary changes to the Chromium repo in order to create Android Weblayer CI and Try bots. It also configures the bots to run the WPT test suite. Bug: 1050760 Change-Id: I395f6ad6edd9939c49dd4ee3c511173be60aecde Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2071063 Commit-Queue: Rakib Hasan <rmhasan@google.com> Reviewed-by:
Luke Z <lpz@chromium.org> Reviewed-by:
Aaron Gable <agable@chromium.org> Reviewed-by:
Andrew Luo <aluo@chromium.org> Cr-Commit-Position: refs/heads/master@{#746528}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/a3b6fd06f9d7..67cabcd71f8a git log a3b6fd06f9d7..67cabcd71f8a --date=short --first-parent --format='%ad %ae %s' 2020-03-03 ehmaldonado@google.com gclient: Remove syntax validation flags. Created with: gclient setdep -r src/third_party/depot_tools@67cabcd71f8a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: agable@chromium.org Change-Id: I8023ed269bbcd80037a037b9e63d811fa0c0808b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2082326Reviewed-by:
-
Hailey Wang authored
A trace is uploaded via "slow reports" when a long first input delay is detected (for opted-in clients). This trace event will make it easier to identify the location of the long delay when analyzing the trace. Bug: 1055890 Change-Id: I479406c3c78accbc4c06ccaeab14f699bf8ccdf4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078775Reviewed-by:
François Doray <fdoray@chromium.org> Reviewed-by:
Nate Chapin <japhet@chromium.org> Commit-Queue: Hailey Wang <haileywang@google.com> Cr-Commit-Position: refs/heads/master@{#746526}
-
Andrew Luo authored
Bug: 1021665, 765833 Change-Id: Ie3ff57c7f78cf451f4ee72e9d73c044ca39f2ebc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080577 Auto-Submit: Andrew Luo <aluo@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#746525}
-
Kelvin Jiang authored
This CL adds documentation which states that the quota for getMatchedRules calls does not apply if the call is associated with a user gesture. Bug: 1044702 Change-Id: I2a2ed5deacc674ba86aef744094b3c1935c4ab91 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2085591 Commit-Queue: Kelvin Jiang <kelvinjiang@chromium.org> Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Auto-Submit: Kelvin Jiang <kelvinjiang@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#746524}
-
zhaoyangli authored
Please refer to the bugs below for why this change is needed. The similar util issue within "ios/chrome/test/earl_grey" was fixed in crrev/c/2006260. Bug: 1036578, 1057752 Change-Id: I917fe2aedf0cd82e3597a751744064c189b0f64c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2082899Reviewed-by:
edchin <edchin@chromium.org> Commit-Queue: Zhaoyang Li <zhaoyangli@chromium.org> Cr-Commit-Position: refs/heads/master@{#746523}
-
zhaoyangli authored
This change is fixing an internal test suite which isn't running because bundle image isn't found. It also enables other test suites add bundle library they need in the future. Bug: 1057694 Change-Id: I125ceaece80a852506b9ae9414bf9b3d084d5bf4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2081241 Commit-Queue: Zhaoyang Li <zhaoyangli@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#746522}
-
Vladimir Levin authored
This patch renames the property and updates the valid values per spec: https://wicg.github.io/display-locking/ Note that it also adds hidden-matchable behind a separate flag, since it's not a part of the initial spec, but is a proposed enhancement: https://github.com/WICG/display-locking/issues/110#issuecomment-588309247 Note that this retains the activation signal while the beforematch event is being implemented. R=chrishtr@chromium.org TBR=cbiesinger@chromium.org, bmcquade@chromium.org Change-Id: I6f4f4aeb2e7d743786d09bda71027f994c94792d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078839 Commit-Queue: vmpstr <vmpstr@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#746521}
-
Xing Liu authored
This reverts commit 91ac1e45. Reason for revert: Breaks downstream test IntentHandlerWithInternalUrlsTest. It still calls static version of the function. https://logs.chromium.org/logs/chrome/buildbucket/cr-buildbucket.appspot.com/8886822837374455840/+/steps/compile/0/stdout Original change's description: > Android: Speculative crash fix for DelayedScreenLockIntentHandler > > Stack is: > Caused by: android.util.AndroidRuntimeException: Calling startActivity() from outside of an Activity context requires the FLAG_ACTIVITY_NEW_TASK flag. Is this really what you want? > at android.app.ContextImpl.startActivity (ContextImpl.java: 952) > at android.content.ContextWrapper.startActivity (ContextWrapper.java: 405) > at org.chromium.chrome.browser.ChromeApplication.startActivity (ChromeApplication.java: 206) > at org.chromium.chrome.browser.ChromeApplication.startActivity (ChromeApplication.java: 199) > at org.chromium.chrome.browser.DelayedScreenLockIntentHandler.onReceive (DelayedScreenLockIntentHandler.java: 40) > at android.app.LoadedApk$ReceiverDispatcher$Args.lambda$getRunnable$0$LoadedApk$ReceiverDispatcher$Args (LoadedApk.java: 1550) > ... > > From history on DelayedScreenLockIntentHandler, repro steps involve > launching a page via NFC while locked. > > This restriction is listed as a new one in Android P: > https://developer.android.com/about/versions/pie/android-9.0-changes-all#fant-required > > Bug: 1034440 > Change-Id: Ibe13fb99a34d36a15e266d9369393dd6060a1e93 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1972135 > Commit-Queue: Andrew Grieve <agrieve@chromium.org> > Reviewed-by: Ted Choc <tedchoc@chromium.org> > Cr-Commit-Position: refs/heads/master@{#746442} TBR=tedchoc@chromium.org,agrieve@chromium.org Change-Id: Ie8a5c401509df389f4a9cefe9b66b54df2cdad2d No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1034440 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2085699Reviewed-by:
Xing Liu <xingliu@chromium.org> Commit-Queue: Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#746520}
-
Alex Cooper authored
This broke in crrev.com/c/2003869, the fix here is to switch to using the cached rather than passed in content offset when in VR. showAndroidControls assumes that the top content offset should be the same as the controls height, but the controls are hidden in VR. Fixed: 1055619 Change-Id: Ife34937ddb06baa0be254b7265181e165781144b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079516 Commit-Queue: Alexander Cooper <alcooper@chromium.org> Auto-Submit: Alexander Cooper <alcooper@chromium.org> Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#746519}
-
behdad authored
Representative perf tests have been running on chromium.gpu as experimental. This change removes the experimental tag: Stats of recent runs on chromium.gpu: 14 flakes in the last 920 runs (1.5% flake rate) Bug: chromium:1000837 Change-Id: Ie6f6d85733f8b63d5cd69636976c1eab93f38250 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2081190Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Behdad Bakhshinategh <behdadb@chromium.org> Cr-Commit-Position: refs/heads/master@{#746518}
-
ckitagawa authored
The callbacks passed to PaintPreviewClient were getting run on an arbitrary thread via PostTask. This is a problem as they should be run on the calling thread such that WeakPtrs bound to them are valid. Fix - Make the callbacks run on the same thread that called capture. - Explicitly run CapturePaintPreviewInternal on the UI thread. Follow-up - Make a dedicated SequencedTaskRunner for executing captures. Bug: 1058079 Change-Id: I1dfa969de613112b4bd1650051e394094dffda5e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083567 Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org> Reviewed-by:
Mehran Mahmoudi <mahmoudi@chromium.org> Cr-Commit-Position: refs/heads/master@{#746517}
-
Rodney Ding authored
- Add parser/serialization for dictionary type. - SH dictionary is implemented as a custom class containing a std::vector - Add test cases from https://github.com/httpwg/structured-header-tests/blob/master/dictionary.json - Follows Draft 15 of Structured Headers for HTTP - https://tools.ietf.org/id/draft-ietf-httpbis-header-structure-15.html - Replace OWS with SP when skipping whitespace in headers Bug: 993790 Change-Id: If9ae207a7c79e3be70fe0f340adbb51fb3383753 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033583 Commit-Queue: Rodney Ding <rodneyding@google.com> Reviewed-by:
Ian Clelland <iclelland@chromium.org> Reviewed-by:
Asanka Herath <asanka@chromium.org> Cr-Commit-Position: refs/heads/master@{#746516}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/abc7a30a06c7..126720bd2e57 git log abc7a30a06c7..126720bd2e57 --date=short --first-parent --format='%ad %ae %s' 2020-03-03 jrprice@google.com Use LINK_FLAGS for -BSymbolic in CMake build Created with: gclient setdep -r src/third_party/swiftshader@126720bd2e57 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: Ibdada5aab49cc795e2c9649128096c17513c6f99 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2085024Reviewed-by:
-
Mugdha Lakhani authored
This componentizes both Java and C++ implementation of SecurityStateModel. The dependency on security_state_tab_helper is resolved by adding a SecurityStateModelDelegate interface. Bug: 1052375 Change-Id: Ie6754d27c2c8e6edb1e06ab9b43b840131bee7b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2072740 Commit-Queue: Mugdha Lakhani <nator@chromium.org> Reviewed-by:
Carlos IL <carlosil@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Christopher Thompson <cthomp@chromium.org> Cr-Commit-Position: refs/heads/master@{#746514}
-
Kurt Horimoto authored
This modality can be used in tests rather than choosing an arbitrary modality for the test, reducing the coupling between overlay functionality and specific implementations for the web content area or infobars. This CL adds support for contained and presented overlay UI to test overlay UI code. A follow-up CL will add tests to OverlayPresentationContextImpl that leverages these classes. Change-Id: I648f95a6af1fc78c007fb8d96a7c6ca295928bae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2068254 Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Mike Dougherty <michaeldo@chromium.org> Auto-Submit: Kurt Horimoto <kkhorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#746513}
-
Jeffrey Cohen authored
Bug: 1058073 Change-Id: I97e4c8c135ace3135df3b0cf4880e37c08939460 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2085159 Commit-Queue: Jeffrey Cohen <jeffreycohen@chromium.org> Auto-Submit: Jeffrey Cohen <jeffreycohen@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#746512}
-
Koji Ishii authored
When r728175 <crrev.com/c/1963597> supported traversing items, it failed to add the size of child inline boxes. The size of an inline box is different from the union of its descendants when it has padding. Bug: 982194 Change-Id: Id2e35cf4136cc0342f509c676f7a678ffcbece80 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079775Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#746511}
-
Liquan (Max) Gu authored
Before Change: buildExtra and its dependencies live in AndroidPaymentApp. After Change: buildExtra and its dependencies live in WebPaymentIntentHelper. Change: 1. create WebPaymentIntentHelper 2. move AndroidPaymentApp#buildExtra() and its dependencies into WebPaymentIntentHelper. Bug: 1057488 Change-Id: I79e873d28a7bcbe119ac2966590d2892ecf76f40 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2082479 Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Reviewed-by:
Liquan (Max) Gu <maxlg@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#746510}
-
Charlie Hu authored
This CL short circuit the initialization of |report_only_feature_policy| in SecurityContext to avoid unnecessary memory allocation. Change-Id: Ieb7816600da97997203487dbbaf84034882aac61 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2081189 Commit-Queue: Charlie Hu <chenleihu@google.com> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#746509}
-
Lukasz Anforowicz authored
This CL logs Rappor samples that hopefully will aid in proactively identifying extensions that might be impacted by the changes behind the CorbAllowlistAlsoAppliesToOorCors feature. Bug: 920638 Change-Id: I40dec28c99673b8096170e1f1fce92c417ca0c16 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2076425Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#746508}
-
Kyle Horimoto authored
The DCHECK() verified that we only bound the UserActionRecorder once during the lifetime of the OsSettingsUi class. However, I had not realized that refreshing the settings page reuses the same underlying OsSettingsUi object, so the BindInterface() function is actually expected to be called once per load of the page (regardless of initial load or refresh). Fixed: 1055001 Change-Id: I4d22ec27a5279483d795de18c4f591f83984bf2c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2085532 Auto-Submit: Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#746507}
-
Darwin Huang authored
Retrieving an ExecutionContext from the LocalFrame passed from NavigatorClipboard ensures that the correct ExecutionContext for the current clipboard operation is always used. In cross-frame circumstances, ScriptState's ExecutionContext would be that of the parent frame, but LocalFrame's ExecutionContext would be that of the child frame. This was mentioned in [1], and initially introduced in [2]. This should ensure that the incorrect (parent frame's) PermissionManager isn't requested when determining whether a permission has been granted, or when asking for permission. This CL does not fix the potential for a null dereference if the ExecutionContext is detached, as both the ExecutionContext::From and GetExecutionContext will result in a null dereference in this case. [1]: https://crrev.com/c/2016200/19/third_party/blink/renderer/modules/clipboard/clipboard_promise.cc#91 [2]: https://crrev.com/c/804973 Bug: 1002794 Change-Id: I340224959fb98d3112464f4955c6d88e537f6199 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2057006 Commit-Queue: Darwin Huang <huangdarwin@chromium.org> Reviewed-by:
-
Allen Bauer authored
Renamed to avoid all the fun-and-games of overload resolution with template functions. Part of the overall effort to eliminate the need for and eventual removal of set_owned_by_client(). Bug: 1044687 Change-Id: I4f728af6e17b3c6c804db7eda58f0fb6d426d5f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2068878 Commit-Queue: Allen Bauer <kylixrd@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#746505}
-
David Schinazi authored
This will simplify the QUIC merge rotation. Change-Id: I3517f7c2e896d5b44625647fade04484e89a286b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2084053 Auto-Submit: David Schinazi <dschinazi@chromium.org> Commit-Queue: Nick Harper <nharper@chromium.org> Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium 6559a5a6. With Chromium commits locally applied on WPT: d5cd6b98 "SharedWorker: Assign unique names to SharedWorkers to avoid unintentional matching" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools NOAUTOREVERT=true TBR=smcgruer No-Export: true Change-Id: Ic3c6f9dfef42818b62e8ff711c5f46cfbfe7d736 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2085231Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#746503}
-
Christopher Cameron authored
The general plan here is to make ExtensionAppShimHandler not know about extensions, but be able to interact with either apps or extensions via its ExtensionAppShimHandler::Delegate interface. To this end, start changing the interface to take app ids instead of extensions::Extensions. Most of this is mechanical, but a few aren't quite: * The Delegate::GetWindows method can't return an extensions type anymore, so inline its usage into new ShowAppWindows and CloseAppWindows methods (which, internally, will be able to). * Remove RequestUserAttentionForWindow, and have the caller (which is extensions-based app code) make the appropriate calls. Update tests to behave reasonably. Bug: 1057195 Change-Id: Ife8f37b608a9a601eafd38da44c2ad50b99f41c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080487Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Reviewed-by:
ccameron <ccameron@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#746502}
-
ckitagawa authored
The previous implementation of DirectoryKey used a const string making it largely incompatible with <algorithm> which I intend to make use of in a few places. To fix this it should be made into a class that can be copied and swapped, but with only a constant accessor. Bug: 1058093 Change-Id: Ib3aff42e248910bd78b9a00c98777fd670999d37 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2084724Reviewed-by:
-
Ken Rockot authored
Picks some low-hanging fruit that the compiler is not able to optimize away: reduces repetition of local context object construction in message decoding logic, and eliminates some unnecessary inlined move operations. Bug: 1058101 Change-Id: Ibedb0eb2c506b3a70c5c60d848633e420845f5cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083738 Commit-Queue: Ken Rockot <rockot@google.com> Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#746500}
-
Ben Pastene authored
A gclient hook would populate the contents of this dir. You could then re-use these files in any arbitrary normal GN build flow. (No Simple Chrome shell needed.) Bug: 937821 Change-Id: I30a78d491088351756017a77fe160de39296b7d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2052205Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#746499}
-
Allen Bauer authored
Change-Id: Ie90cf1411b722da6d9c387480bcb38b2e7b44630 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083845 Commit-Queue: Allen Bauer <kylixrd@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#746498}
-
Ken MacKay authored
The focus type is used to determine which streams volume limits are applied to. For backwards compatibility, if the focus type is not specified, it defaults to the content type. Bug: internal b/150225634 Change-Id: Ib9b9c985176786bd759ba5629000b057be3abb6b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080583Reviewed-by:
Yuchen Liu <yucliu@chromium.org> Commit-Queue: Kenneth MacKay <kmackay@chromium.org> Cr-Commit-Position: refs/heads/master@{#746497}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/8ff2fc8fcdb1..b9b24d1b0b80 git log 8ff2fc8fcdb1..b9b24d1b0b80 --date=short --first-parent --format='%ad %ae %s' 2020-03-03 skyostil@google.com TrackEvent: Avoid leaking legacy symbols to the global namespace Created with: gclient setdep -r src/third_party/perfetto@b9b24d1b0b80 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:148779455 Tbr: perfetto-bugs@google.com Change-Id: I1d554d91d08c0578530cbc407654e46af7687f34 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2085027Reviewed-by:
-
