- 30 Mar, 2020 35 commits
-
-
Andrey Kosyakov authored
Bug: 1059577, 1064852 Change-Id: I2994be49f53aa8fc52fbd7cee543fa65521670f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2121434 Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#754408}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/3aee4845b503..2af68a4c4d57 git log 3aee4845b503..2af68a4c4d57 --date=short --first-parent --format='%ad %ae %s' 2020-03-30 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 3ca41df3d3ba..1c29477aa06e (9 commits) Created with: gclient setdep -r src/third_party/skia@2af68a4c4d57 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC michaelludwig@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: michaelludwig@google.com Change-Id: I443560aa87a3e1bfd8ed6c495ce43bdfcbbd9381 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2126375Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#754407}
-
Raul Tambre authored
itervalues() has been removed in Python 3. Use values() which is functionally same on both Python 2 and 3 in this case. Traceback (most recent call last): File "../../third_party/blink/renderer/build/scripts/make_origin_trials.py", line 128, in <module> json5_generator.Maker(OriginTrialsWriter).main() File "C:\Google\chromium\src\third_party\blink\renderer\build\scripts\json5_generator.py", line 337, in main writer = self._writer_class(args.files, args.output_dir) File "../../third_party/blink/renderer/build/scripts/make_origin_trials.py", line 52, in __init__ for features in self._trial_to_features_map.itervalues()) AttributeError: 'dict' object has no attribute 'itervalues' Bug: 941669 Change-Id: I474ae78b34dae62089dbcbd7f77d3358bf854733 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2125729 Auto-Submit: Raul Tambre <raul@tambre.ee> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Reviewed-by:Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#754406}
-
Raul Tambre authored
func_name has been removed in Python 3. __name__ does the same thing and exists in both Python 2 and 3. Traceback (most recent call last): File "../../third_party/blink/renderer/build/scripts/core/css/parser/make_atrule_names.py", line 11, in <module> class AtRuleNamesWriter(json5_generator.Writer): File "../../third_party/blink/renderer/build/scripts/core/css/parser/make_atrule_names.py", line 53, in AtRuleNamesWriter def generate_implementation(self): File "C:\Google\chromium\src\third_party\blink\renderer\build\scripts\gperf.py", line 74, in wrapper generator_internal.func_name = generator.func_name AttributeError: 'function' object has no attribute 'func_name' Bug: 941669 Change-Id: I8eac2f3e67c235bb0cad5520c71916aa5f6fd13a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2124613 Auto-Submit: Raul Tambre <raul@tambre.ee> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Reviewed-by: -
Julian Watson authored
This will make it easier to move crostini_registry_service into guest_os. Bug: 1049453 Change-Id: I9cb25c03689dec04883eb83500fe610d88c377aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2114315 Commit-Queue: Julian Watson <juwa@google.com> Reviewed-by:
Timothy Loh <timloh@chromium.org> Reviewed-by:
Nancy Wang <nancylingwang@chromium.org> Auto-Submit: Julian Watson <juwa@google.com> Cr-Commit-Position: refs/heads/master@{#754404}
-
Minoru Chikamune authored
No behavior change. This CL reduces potential risks of use-after-free bugs. Bug: 1049056 Change-Id: I6bdb732edbc909a096cffbe12ec7e379104d9236 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2109670 Commit-Queue: Minoru Chikamune <chikamune@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Cr-Commit-Position: refs/heads/master@{#754403}
-
Raul Tambre authored
Initial conversion performed using "2to3 -f print .". Imports added and duplicate parentheses removed manually. There are no functional changes. Bug: 941669 Change-Id: I32f540c49bfdf183a1514755ea140592b502e58c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2124612 Auto-Submit: Raul Tambre <raul@tambre.ee> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
-
Alan Cutter authored
This CL fixes the context menus of web apps while the DesktopPWAsTabStrip flag is enabled to no longer have two radio buttons checked. Before: https://bugs.chromium.org/p/chromium/issues/attachment?aid=439506&signed_aid=5Uz5Wc8hNehCVzvIOIGVDQ==&inline=1 After: https://bugs.chromium.org/p/chromium/issues/attachment?aid=439505&signed_aid=S6xeaj0fgJdJwF5VO5qdZA==&inline=1 Bug: 1065757 Change-Id: I067bec39520817a6d3f492d836fd1f433e44acc9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2126335 Auto-Submit: Alan Cutter <alancutter@chromium.org> Reviewed-by:
-
Raul Tambre authored
Python 2 seems to implicitly create a list in some cases. Python 3 doesn't do that. Surround with brackets to make this explicit, so it works on both. File "../../third_party/blink/renderer/bindings/scripts/generate_global_constructors.py", line 123 for name in 'RuntimeEnabled', 'ContextEnabled', 'SecureContext' ^ SyntaxError: invalid syntax Bug: 941669 Change-Id: I1043faf33eab77fc220072b2e575182b4a015ecd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2124755 Auto-Submit: Raul Tambre <raul@tambre.ee> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Reviewed-by: -
Julie Jeongeun Kim authored
This CL migrates this test out of third_party/blink/web_tests/css3/flexbox and into the WPT-specific directory, adding links to the relevant specs and a test assertion describing its purpose and adds 10x10-green.png. Bug: 1063749 Change-Id: I46e877a6aa10126fd86b05c29756786c2293433f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2123499 Commit-Queue: Julie Kim <jkim@igalia.com> Reviewed-by:
Robert Ma <robertma@chromium.org> Reviewed-by:
David Grogan <dgrogan@chromium.org> Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#754399}
-
Austin Tankiang authored
The button does nothing, so remove it to prevent confusion. Also make sure that the progress panel treats format and sync panels as progress panels to use when calculating the summary panel's progress. Bug: 1065274 Change-Id: If91d64837de635c94caeb1143329ab42c3608f21 Tests: browser_tests --gtest_filter="FileManagerJsTest.FilesDisplayPanel" Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2123574Reviewed-by:
Alex Danilo <adanilo@chromium.org> Commit-Queue: Austin Tankiang <austinct@chromium.org> Cr-Commit-Position: refs/heads/master@{#754398}
-
Bartek Nowierski authored
Change-Id: I563a9b3633245196de4e608ca3374e1888fb2045 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2123505Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
-
Timothy Loh authored
Currently we log a PluginVm.SetupResult histogram which breaks down failure cases into which stage of the installation failed. As we have a more granular enum value, this CL makes us log that instead. We also take the opportunity to simplify the installer observer to only have a single callback for installation failed, as the failure reason enum is sufficient. Bug: 1063748 Change-Id: I0ec8171275a21f6c139a9a5a2baf77111ce16c29 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2123497 Commit-Queue: Timothy Loh <timloh@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Julian Watson <juwa@google.com> Cr-Commit-Position: refs/heads/master@{#754396}
-
Shik Chen authored
Bug: 982201,b:148045035 Test: Call getUserMedia() with resizeMode = "crop-and-scale", check the camera stream is cropped properly. Change-Id: Ib5c8ff0f97cb6ee9b6883fd55dc53faa4e248c00 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2041712Reviewed-by:
Dan Sanders <sandersd@chromium.org> Commit-Queue: Shik Chen <shik@chromium.org> Cr-Commit-Position: refs/heads/master@{#754395}
-
Alan Cutter authored
This CL updates a DCHECK for kDesktopPWAsTabStrip being enabled to only occur if we're updating an app to use the experimental tabbed mode. Previously it was possible to hit this DCHECK when the experiment is disabled and the user is setting the window mode to something other than tabbed mode. Bug: 897314 Change-Id: Ie1bc99cf9967d45c4f9f3048ff8bf88025ed34d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2126334 Auto-Submit: Alan Cutter <alancutter@chromium.org> Reviewed-by:
Eric Willigers <ericwilligers@chromium.org> Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#754394}
-
Julie Jeongeun Kim authored
This CL migrates this test out of third_party/blink/web_tests/css3/flexbox and into the WPT-specific directory, adding links to the relevant specs and a test assertion describing its purpose. Bug: 1063749 Change-Id: I9e3ce8c44ad2ca7852aeae25e99d4ebbf6c959f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2124130 Commit-Queue: Julie Kim <jkim@igalia.com> Reviewed-by:
-
Raul Tambre authored
Python 3 has removed all of these. The unprefixed version are functionally almost the same in Python 2. Had to add iter() in 4 places due to use of next(). Renamed DatabaseBody.itervalues() to values() for consistency. Python 3 has also other changes pertaining to these functions, e.g. returning iterators instead of lists. Issues with those will be fixed in follow-up CLs on a case-by-case basis. Bug: 941669 Change-Id: I73212365c3583629e5e94865cf2aaf45e3006b7f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2124384 Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Reviewed-by:
-
Raul Tambre authored
iterkeys() and iteritems() have been removed in Python 3. Use keys() and items() which are functionally the same and work on both. Bug: 941669 Change-Id: I4dc35a291ce169d0ebd2bd8786ad9642c2f85aee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2124610 Auto-Submit: Raul Tambre <raul@tambre.ee> Commit-Queue: John Chen <johnchen@chromium.org> Reviewed-by:
John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#754391}
-
Kent Tamura authored
crrev.com/745230 was incomplete. It didn't handle a case where <optgroup> is removed with <select>'s all other children. Bug: 1065125 Change-Id: Id2c06d5f9988b21de28d9b0540189233f960c8c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2126331Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#754390}
-
Aaron Leventhal authored
- Do not use Element.IsFocusable() which is unsafe, because it can cause a document lifecycle change. This was found via trybots testing for dangerous lifecycle changes in crrev.com/c/2113076 - Minimize expensive walking of ancestors for activedescendant checks - Unify two methods for determining focusability - Generally make the code much clearer and easier to read Bug: None Change-Id: I1759e8b8fe3fd37cb5013aa67fd7cf9d3c355848 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2113678 Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#754389}
-
Andrew Moylan authored
These already expired as intended, they should be marked obsolete. Bug: 1046642 Change-Id: Ia2c64e2f31638bc5af6ec17a49637812e29080cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2119291Reviewed-by:
Tony Yeoman <tby@chromium.org> Commit-Queue: Andrew Moylan <amoylan@chromium.org> Cr-Commit-Position: refs/heads/master@{#754388}
-
Yuki Shiino authored
Supports cross origin properties in the new bindings generator, which is not yet shipped. No prod change. Bug: 839389 Change-Id: Ib63addf0a423a2b3f6c169ecb0548cc6303ccd16 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2121862Reviewed-by:
-
Hitoshi Yoshida authored
We did not have V8SetReturnValue for new IDL dictionaries that does not take a creation context as an input parameter. If we tried to call it, another function was called in its overload resolution. This CL fixes it. Bug: 839389 Change-Id: I75c0c96bb3839c166824f2c490cb916dbd345a99 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2124133Reviewed-by:
-
Wanming Lin authored
This CL renames "wake-lock" to "screen-wake-lock" in policy-controlled feature specific for screen wake lock, and leaves system wake lock's policy control as allowed by default because its associated feature policy is not defined yet. Spec changes at: https://github.com/w3c/wake-lock/pull/255 Bug: 1064685 Change-Id: I7701a532a7688d708a75aedafc8713d671da6e2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2119886Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=abdulsyed@chromium.org Change-Id: Ibfcf0505d070414266f2ce25b5f1dd59e88d9bbe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2125460Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#754384}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/5869c046c196..bdca68298023 Created with: gclient setdep -r src-internal@bdca68298023 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: Iafef3a5d18d157712e64b98e43a06a0a146e4c9d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2126370Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#754383}
-
Timothy Loh authored
This CL adds a step to the start of the Plugin VM installation to check available disk space. If below a minimum value (currently 16GB) we fail and show an error. Otherwise if bellow a recommended value (currently 32GB), we give the user the option of cancelling or continuing. Bug: 1055187 Change-Id: I2c55609df31db132b2a8f04c7ed69a21c24d0df2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2123569Reviewed-by:
-
Avi Drissman authored
https://crrev.com/c/2092553 changed the tab color IDs. Update the theme pack version so that existing themes display correctly. BUG=1065612 Change-Id: I7ec4c3349537879cabf8a0fccb50810caa572c2e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2125456 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#754381}
-
Raul Tambre authored
The make_names.h.tmpl was sorting `entries`, which is a list of dictionaries. Python 3 doesn't support sorting dictionaries, so this resulted in an error. I believe trying to sort the dictionaries is actually a bug, as dictionary sorting behaviour is unexpected in Python 2 and is the reason it was removed in Python 3. This manifests here as the symbols not being sorted alphabetically. I've added proper sorting by symbol names into make_names.py and removed sorting in the template. This fixes the incorrect sorting and it not working in Python 3. Traceback (most recent call last): File "../../third_party/blink/renderer/build/scripts/make_names.py", line 117, in <module> json5_generator.Maker(MakeNamesWriter).main() File "C:\Google\chromium\src\third_party\blink\renderer\build\scripts\json5_generator.py", line 339, in main writer.write_files(args.output_dir) File "C:\Google\chromium\src\third_party\blink\renderer\build\scripts\json5_generator.py", line 304, in write_files self._write_file_if_changed(output_dir, generator(), file_name) File "C:\Google\chromium\src\third_party\blink\renderer\build\scripts\template_expander.py", line 69, in generator_internal return apply_template( File "C:\Google\chromium\src\third_party\blink\renderer\build\scripts\template_expander.py", line 62, in apply_template return template.render(params) File "C:\Google\chromium\src\third_party\jinja2\asyncsupport.py", line 76, in render return original_render(self, *args, **kwargs) File "C:\Google\chromium\src\third_party\jinja2\environment.py", line 1008, in render return self.environment.handle_exception(exc_info, True) File "C:\Google\chromium\src\third_party\jinja2\environment.py", line 780, in handle_exception reraise(exc_type, exc_value, tb) File "C:\Google\chromium\src\third_party\jinja2\_compat.py", line 37, in reraise raise value.with_traceback(tb) File "C:\Google\chromium\src\third_party\blink\renderer\build\scripts\templates\make_names.h.tmpl", line 22, in <module> {% for entry in entries|sort %} File "C:\Google\chromium\src\third_party\jinja2\filters.py", line 278, in do_sort return sorted(value, key=key_func, reverse=reverse) TypeError: '<' not supported between instances of 'dict' and 'dict' Bug: 941669 Change-Id: Id06471635469858a37f6c0d1b3e7abd0f640469e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2125848 Auto-Submit: Raul Tambre <raul@tambre.ee> Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#754380}
-
garzonou authored
This CL triggered a Presubmit Warning: Found Nullability annotations. Prefer DCHECKs in ios code to check for nullness But since this public header is designed to be exported to code outside Chromium so the presubmit warning should be ignored I believe. Change-Id: Ie5f0d5af75e53d92be6841cf80fc4fefb72d7ccd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2115854 Auto-Submit: Jiajun Ou <garzonou@google.com> Reviewed-by:
Hiroshi Ichikawa <ichikawa@chromium.org> Commit-Queue: Jiajun Ou <garzonou@google.com> Cr-Commit-Position: refs/heads/master@{#754379}
-
Johann Koenig authored
This reverts commit 0b8fa0e5. Reason for revert: Causing failures on Win7: https://ci.chromium.org/p/chromium/builders/ci/Win7%20%2832%29%20Tests 2020-03-28 11:06 AM (JST) 80527764 FAILURE 58352 1 Test Suite(s) failed. browser_tests failed because of: MediaFeedsWebUIBrowserTest.All Original change's description: > Reland "Reland "[Media Feeds] Add feed items to WebUI"" > > This is a reland of 25e37730 > > The fix is to loosen the assertion on the time fields > which have a different format on win7. > > Original change's description: > > Reland "[Media Feeds] Add feed items to WebUI" > > > > This is a reland of 0bbf0f94 > > > > Original change's description: > > > [Media Feeds] Add feed items to WebUI > > > > > > This adds the feed items to the WebUI. You > > > can select a feed to show the content. > > > > > > BUG=1058187 > > > > > > Change-Id: I5051f77b68cb3da6710a547d50109cb95a7b890f > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2118758 > > > Commit-Queue: Becca Hughes <beccahughes@chromium.org> > > > Reviewed-by: Tommy Steimel <steimel@chromium.org> > > > Cr-Commit-Position: refs/heads/master@{#753441} > > > > Bug: 1058187 > > Change-Id: I7ec8a25ba03d192341e6d02eccfba991b4156504 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2121450 > > Reviewed-by: Tommy Steimel <steimel@chromium.org> > > Commit-Queue: Becca Hughes <beccahughes@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#753712} > > Bug: 1058187 > Change-Id: I69f0f6dbe336d7a46b2c3d2e4e251256d37390d5 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2124630 > Reviewed-by: Tommy Steimel <steimel@chromium.org> > Commit-Queue: Becca Hughes <beccahughes@chromium.org> > Cr-Commit-Position: refs/heads/master@{#754202} TBR=beccahughes@chromium.org,steimel@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1058187 Change-Id: I48de21fbe3659c80de0c76aebc69f4f818fa24f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2126327Reviewed-by:
Johann Koenig <johannkoenig@google.com> Commit-Queue: Johann Koenig <johannkoenig@google.com> Cr-Commit-Position: refs/heads/master@{#754378}
-
Raul Tambre authored
Pickled data is binary, so we need to open it as binary when loading it. This fixes loading on Python 3. Traceback (most recent call last): File "../../third_party/blink/renderer/bindings/scripts/generate_global_constructors.py", line 214, in <module> sys.exit(main()) File "../../third_party/blink/renderer/bindings/scripts/generate_global_constructors.py", line 190, in main read_pickle_file(options.global_objects_file)) File "C:\Google\chromium\src\third_party\blink\renderer\bindings\scripts\utilities.py", line 328, in read_pickle_file return pickle.load(pickle_file) TypeError: file must have 'read', 'readinto' and 'readline' attributes Bug: 941669 Change-Id: I471be513650f7d6aada4ef1dbb8d08f6223091ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2124498 Auto-Submit: Raul Tambre <raul@tambre.ee> Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#754377}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/04f3ecdadc72..5869c046c196 Created with: gclient setdep -r src-internal@5869c046c196 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: I0b25c41b464ce3b4b224b18361b60bc5c97c644c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2126165Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: Idb54574dfc66df9cdb9e80a27490af2c1c45e514 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2126166Reviewed-by:
-
Johann Koenig authored
This reverts commit 4e3c8ff8. Reason for revert: ChromeOS bot failures Bug: chromium:1065746 Original change's description: > Remove the blocking apis in SpeechMonitor > > - convert all callers to use the async api > - some misc cleanup in SpokenFeedbackBrowserTest > > Run these against debug and release; use both 5 and 10 parallel jobs which should load the tests enough to catch flakes. > > Test: browser_tests against all relevant suites (SelectToSpeak*, Spoken*, and *.EnableChromeVox). > Change-Id: I1b425b8640433b7608d84aa67f1cf5900ce26638 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2124701 > Reviewed-by: Nancy Wang <nancylingwang@chromium.org> > Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> > Commit-Queue: David Tseng <dtseng@chromium.org> > Cr-Commit-Position: refs/heads/master@{#754319} TBR=dmazzoni@chromium.org,dtseng@chromium.org,nancylingwang@chromium.org,nancylingwang@google.com # Not skipping CQ checks because original CL landed > 1 day ago. Change-Id: I121b1d503547f3fc54597527ecbdb95ee65b9511 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2126328Reviewed-by:
-
- 29 Mar, 2020 5 commits
-
-
Jia authored
This cl changes type of max results to uint32 and removes max latency (to be supported later). It only changes the sync functions as the async versions will be deleted in the next cl. Bug: 1018613,1063505 Change-Id: Ie186f7bc02ded01d297d1d001b25d2a622466e58 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2121675Reviewed-by:
Colin Blundell <blundell@chromium.org> Commit-Queue: Jia Meng <jiameng@chromium.org> Cr-Commit-Position: refs/heads/master@{#754373}
-
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-eve-compile-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-kevin-compile-chrome BUG=762641 TBR=chrome-os-gardeners@google.com Change-Id: Ibe9f8a5fc60b8ab738edd3aacfe3c0868f421253 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2126251Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#754372}
-
tby authored
This CL takes the XML configuration for projects, and uses it to change hashing behaviour for events. The main changes are as follows. - Some minor renaming in the codegen: key_name_hash is now key_name. I realized having "hash" in the name was ambiguous: it could refer to either the hash of the key's name (correct) or the name hash of the key (dangerous!) - The kEventNameHashes list has been renamed kKeyNames, and now includes all and only name hashes referring to keys used for hashing. - KeyData now no longer works with 'events', it works with 'key_names', which refer to either an event or project name hash. - StructuredMetricsProvider now looks up an event's key_name, rather than event_name_hash, and uses that for hashing. - SMP also now computes the user event ID on OnRecord and saves it with the hashed data, rather than on ProvideCurrentSessionData. I don't know why this wasn't already the case! This CL minimally modifies the existing unit tests, and a follow-up will add extra tests covering more edge cases of projects. Bug: 1016655 Change-Id: I83c5add6c281b48201ebdb94f60aaaad88ce39b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2115859Reviewed-by:
Charles . <charleszhao@chromium.org> Commit-Queue: Tony Yeoman <tby@chromium.org> Cr-Commit-Position: refs/heads/master@{#754371}
-
My Nguyen authored
Adding chrome flags so it's easier for UX and QA people to test the feature. Bug: 1065308 Change-Id: If3a7ef76fe157019efedcf87fbfa5d87b2d3fade Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2124128Reviewed-by:
Darren Shen <shend@chromium.org> Commit-Queue: My Nguyen <myy@chromium.org> Cr-Commit-Position: refs/heads/master@{#754370}
-
chromium-autoroll authored
Roll airmont AFDO profile from 83-4085.6-1584959535-benchmark-83.0.4094.0-r1 to 83-4085.6-1584959535-benchmark-83.0.4097.3-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-airmont-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: I08cd2d854b42d44ff35c9a6873764aa42ea4ca44 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2126164Reviewed-by:
-
