- 11 Dec, 2020 40 commits
-
-
Pilar Molina Lopez authored
Add log warning messages when lacros-chrome didn't launch because: - The session is not yet active (for instance when using "Browse as a Guest") - The current user is not allowed - Lacros is not supported or allowed Bug: None Change-Id: I06a60daace575a32b46662be36c5ae824a4ea744 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2583622 Commit-Queue: Pilar Molina Lopez <pmolinalopez@google.com> Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Cr-Commit-Position: refs/heads/master@{#836175}
-
Mark Schillaci authored
This CL is the seventh part of an effort to port the existing Desktop feature to Android. This feature enables a user to send an image to Google to process to generate a descriptive alt text if a website does not provide one. Design Doc: go/2020-q1-android-image-descriptions Slide Deck: go/clank-imageDescriptions Launch Bug: 1057168 Original Desktop Design Doc for reference: go/chrome-a11y-annotations-design This is a conservative approach, we use a separate set of profile Prefs for this feature rather than syncing with the Desktop Prefs. This can be updated in time as needed. ---------- This CL adds the following: - Syncs Regular and Incognito behavior as per new reqs - Corrects unit tests for above - Adds an AXMode observer to watch for screen readers being enabled ---------- AX-Relnotes: Android accessibility image descriptions behavior in incognito tabs will now match the regular tabs behavior for that profile. Bug: 1057169 Change-Id: I27b6cb1c3da4cae441a6519815f7835049827452 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2585587Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Mark Schillaci <mschillaci@google.com> Commit-Queue: Mark Schillaci <mschillaci@google.com> Cr-Commit-Position: refs/heads/master@{#836174}
-
Azeem Arshad authored
This CL adds sharesheet shouldShowAction logic that hides nearbyshare sharesheet when the feature is disabled by policy. Fixed: 1156857 Change-Id: I61532c71aa67e2d1ab55f0b39d6cd36d7268ad8d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586084Reviewed-by:
James Vecore <vecore@google.com> Commit-Queue: Azeem Arshad <azeemarshad@chromium.org> Cr-Commit-Position: refs/heads/master@{#836173}
-
Koji Ishii authored
The code to call |NGBoxFragmentPainter| was removed in r832702 <crrev.com/c/2567145> and <crrev.com/c/2586636>. Bug: 1154531 Change-Id: I5f09a206dc15464bda98f577e0a26f3132039f6f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586450Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#836172}
-
Wez authored
|controller_binding_| may be unbound during WebComponent teardown, causing a FIDL write error to be logged, if: - The component was started without a ComponentController request. - The ComponentController was previously Detach()ed and closed. - The WebComponent is tearing down because the ComponentController channel was closed by the client. The OnTerminated event is now dispatched only if |controller_binding_| is still bound. Bug: 1157638 Change-Id: Idd15e6cb07a98a27a56d3b5a9f8c1c611b04c816 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2584849 Auto-Submit: Wez <wez@chromium.org> Commit-Queue: David Dorwin <ddorwin@chromium.org> Reviewed-by:
David Dorwin <ddorwin@chromium.org> Cr-Commit-Position: refs/heads/master@{#836171}
-
W. James MacLean authored
The function VisualViewport::MainFrame() is often used in if-statements to test for the existence of a *local* mainframe. But since we could also have a remote mainframe, or no mainframe at all, the name is ambiguous. This CL renames the function to make it clear what condition is actually being tested. This CL is a cleanup-refactor prior to landing a fix for the associated issue. Bug: 1150977 Change-Id: Id1542e46516288b15306be6ba75ff1805206ddc7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2585634Reviewed-by:
David Bokan <bokan@chromium.org> Commit-Queue: James MacLean <wjmaclean@chromium.org> Cr-Commit-Position: refs/heads/master@{#836170}
-
Bruce Dawson authored
The comment added in crrev.com/c/2407065 was copied from another line without updating the function name, which makes it quite confusing. I was looking at the code to see whether the technique from crrev.com/c/2580440 would be applicable (it's not clear that it would be an improvement in this case) but it did help me find this mistake. Change-Id: If97941def14ec0d7d0d1ea191bf5e407243dddfb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586774 Auto-Submit: Bruce Dawson <brucedawson@chromium.org> Commit-Queue: Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#836169}
-
Gavin Williams authored
Create metric to track the scan job success rate of scans initiated from the Scan app. This metric will not include canceled scans. Bug: 1059779 Change-Id: I5487f643169fcffdfb7c50b074daed19bcd14d5e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2583211Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Jesse Schettler <jschettler@chromium.org> Commit-Queue: Gavin Williams <gavinwill@chromium.org> Cr-Commit-Position: refs/heads/master@{#836168}
-
Mohamed Heikal authored
Replace remote view's id with View.NO_ID before they are added to chrome's view hierarchy. This is to prevent the resources from clashing with chrome's resource ids. Store the old id in a tag to be returned to the application on clicks. Bug: 1061872 Change-Id: I69c6c01c2d9fc6be6dc72f10c56a22f32506eb19 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2584903 Commit-Queue: Mohamed Heikal <mheikal@chromium.org> Auto-Submit: Mohamed Heikal <mheikal@chromium.org> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Cr-Commit-Position: refs/heads/master@{#836167}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1607655596-75336cc70b08765a793f0c1f5daab74c560f984f.profdata to chrome-win32-master-1607666365-8ac3b41b3fd6b7cdefcffd3f36f49fc644306c58.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I83f78b7a5d6b29d5463a8c2f7f8da2dc1f03af0a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586884Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#836166}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/f2d81b7d4073..fd5c6c03c06f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I2551d3d5180c29be876687e51e1bfd6f6a71f0bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587095Reviewed-by:
-
Peter McNeeley authored
In the situation of there being damage above an overlay we currently do not remove the damage of the underlay. A good example of where this occurs is the timeline controls on top of a youtube video. So instead of doing the smallest amount of damage (say for the seconds counter) we damage the entire video display region. There are other contexts for which the overlay damage region is not removed but in the end these all come down to the difficulty of subtracting damage from the incoming root damage. In this change we move from subtracting overlay damage to excluding it via the |SurfaceDamageList|. This results in much more accurate final damage and thus improve power usage. This change also dramatically reduces the complexity of previously error prone overlay damage subtraction computations. Finally, this change moves us closer to our goal of doing damage extraction on a per quad level in surface aggregator. See this document for more information: https://docs.google.com/document/d/ 1yDnz1DKcSwfMZwmeRR_RRS3QznpzqLnsMeeYIk-ORfA/edit?usp=sharing Change-Id: Ia5901546bd3982b8054b5ae9d0f397c22d7e5228 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2558918Reviewed-by:
Maggie Chen <magchen@chromium.org> Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Commit-Queue: Peter McNeeley <petermcneeley@chromium.org> Cr-Commit-Position: refs/heads/master@{#836164}
-
Nektarios Paisios authored
In the accessibility codebase, the kDocument role is used both for HTML elements with an ARIA role of "document", as well as for the root node in Chromium's PDF viewer. The above is confusing and leads to subtle bugs because: 1. Different native APIs might want to expose the root of a PDF document differently from the root of the web area, e.g. Chrome's Automation API. 2. In fact, on most supported platforms, The PDF root is never exposed with the same role as the root of the web area. For example on Linux ATK, the root of the web area has the ATK_ROLE_DOCUMENT_WEB whilst the root of the PDF document has the ATK_ROLE_DOCUMENT_FRAME. 3. The PDF plugin could be embedded in an iframe on any website. PDFs are not always displayed as standalone documents. 4. This is future proof. Say in case we would need to add a predicate for navigating just to the top of the PDF, instead of to the top of the whole webpage. This patch fixes this by adding the new kPdfRoot role In addition, the kWebArea role is no longer used and could be removed simplifying all the places in the code where we had to check for either kRootWebArea or kWebArea roles. Also took the opportunity to go through the whole codebase and ensure that the kRootWebArea role was used appropriately. AX-Relnotes: n/a. R=dmazzoni@chromium.org, aleventhal@chromium.org Change-Id: Ib8d1621b0003c51f9df48d19de357965d663cb1c Bug: 1049261 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2556452Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Reviewed-by:
-
Brian Salomon authored
Will remove this guard and rebaseline affected web tests once Skia fix rolls into Chrome. Bug: 1156804 Change-Id: I03bd00d5241a17231260061c9b72072fd565fbb8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2585837 Auto-Submit: Brian Salomon <bsalomon@google.com> Commit-Queue: Florin Malita <fmalita@chromium.org> Reviewed-by:
Florin Malita <fmalita@chromium.org> Cr-Commit-Position: refs/heads/master@{#836162}
-
Ella Ge authored
Tbr: sandromaggi@google.com No-try: true Bug: 1157506 Change-Id: If8d5fc402fcf8f8ba390ab0a9be7c4960fd50ef8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2585810Reviewed-by:
Ella Ge <eirage@chromium.org> Commit-Queue: Ella Ge <eirage@chromium.org> Cr-Commit-Position: refs/heads/master@{#836161}
-
Joe Mason authored
An upcoming patch will add another helper class to web_memory.h, which will overload web_memory_aggregator.cc if it's added there. So, move the implementation of all the web_memory.h helper classes (currently just WebMemoryMeasurer) to web_memory_impl.* This also splits the unit tests into web_memory_aggregator_unittest.cc and web_memory_impl_unittest.cc, moving shared code into v8_memory_test_helpers.*. R=siggi Bug: 1085129 Change-Id: Idd03b15440f78441d224a7ea08967faf404215ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586144Reviewed-by:
François Doray <fdoray@chromium.org> Commit-Queue: Joe Mason <joenotcharles@chromium.org> Cr-Commit-Position: refs/heads/master@{#836160}
-
Ella Ge authored
Tbr: yuezhanggg@chromium.org No-try: true Bug: 1157518 Change-Id: I4538feaa30f325565140df47b0c43aad2114cb00 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2585639Reviewed-by:
-
Minggang Wang authored
As part of the OnionSoup project, this patch moves class InterProcessTimeTicksConverter into blink and its unit test also. This is needed when the functionalities of ResourceDispatcher are merged into blink and the ResourceDispatcher itself gets removed finally. Meanwhile, this patch removes the deprecated uses of To/FromInternalValue() in the unit test. Bug: 1110032, 634507 Change-Id: I5eaff52ee9f5791aed0f92f0c9b5441dc2dc861a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2583845 Commit-Queue: Minggang Wang <minggang.wang@intel.com> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#836158}
-
Ella Ge authored
Tbr: shengfa@google.com No-try: true Bug: 1157533 Change-Id: I21d98df4d1062a133c895452c1632120001e5446 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587234Reviewed-by:
-
Yaron Friedman authored
BUG=783819 Change-Id: I5b58fc169a17caf2098e16450ac5a8002efd4c81 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2582545 Commit-Queue: Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Reviewed-by:
Donn Denman <donnd@chromium.org> Cr-Commit-Position: refs/heads/master@{#836156}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/5a9d7eaa74ad..fd5c6c03c06f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-win-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I175697a3b99cbd45a21f45af645a8b57d2fece37 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587096Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/d8969b3b6ba6..d1910cef3a77 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC eirage@google.com,sreejakshetty@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: eirage@google.com,sreejakshetty@google.com Change-Id: Ifdf84dbfc1acc35580cecdf4beb0950ee9401fcd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586946Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#836154}
-
Bin Wu authored
https://quiche.googlesource.com/quiche.git/+log/a9b70f03e7a9..fc51e436c68c $ git log a9b70f03e..fc51e436c --date=short --no-merges --format='%ad %ae %s' 2020-12-11 bnc Remove unused SpdyFrameType::EXTENSION. 2020-12-11 vasilvv Delete QuicheStrCat(). 2020-12-10 ianswett Add a QUIC protocol flag to enable or disable defer_send_in_response_to_packets in GFE and uStreamer. 2020-12-09 vasilvv Replace QuicStrAppend() with absl::StrAppend(). Created with: roll-dep src/net/third_party/quiche/src src/third_party/quic_trace/src R=bnc@chromium.org, dschinazi@chromium.org Change-Id: I71681c7a63c5c4f8afa8d015671dda0dc6320018 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587076 Commit-Queue: Bin Wu <wub@chromium.org> Commit-Queue: Bence Béky <bnc@chromium.org> Auto-Submit: Bin Wu <wub@chromium.org> Reviewed-by:
Bence Béky <bnc@chromium.org> Cr-Commit-Position: refs/heads/master@{#836153}
-
Leonard Grey authored
to OnceCallback. The deleted declarations in DevToolsAndroidBridge were left over from a refactor in r426186 Bug: 1152274 Change-Id: I5f9b9663fc417baa650f563877441b0b459051b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2582732 Commit-Queue: Leonard Grey <lgrey@chromium.org> Reviewed-by:
Yang Guo <yangguo@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#836152}
-
Matt Menke authored
CrossOriginOpenerPolicyReporter calls into NetworkContext's reporting API. Reporting information can be used to track users across sites, so needs to be keyed on NetworkIsolationKey. This CL adds a NetworkIsolationKey to its constructor, and plumbs the right NetworkIsolationKey through. Bug: 1143453 Change-Id: Ia47d486a548c56f8c41d7e56c0d032668e8b5802 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2580480Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#836151}
-
Xianzhu Wang authored
We have a special background invalidation flag: BackgroundNeedsFullPaintInvalidation(). When the flag is set, we'll invalidate both the non-scrolling background and the scrolling background. However, when the flag is not set while we are invalidating the whole subtree, previously we missed invalidating the scrolling background. Scroll controls are similar. Bug: 1155413 Change-Id: Id6c5ba4be127cce33d295379b9b444d7271385df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2585741Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#836150}
-
Weblayer Skew Tests Version Updates authored
This CL will add skew tests for version 88.0.4324.43. R=hypan@google.com Bug: 1041619 Change-Id: I3fbd52da8c0fced9936253439195ced7c4377e7d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586567 Auto-Submit: Rakib Hasan <rmhasan@google.com> Commit-Queue: John Chen <johnchen@chromium.org> Reviewed-by:
John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#836149}
-
Ella Ge authored
Tbr: wenyufu@chromium.org No-try: true Bug: 1157611 Change-Id: I97d2766ae91c3e11c8b150e5b61ec418e429f2a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586241Reviewed-by:
-
chromium-internal-autoroll authored
Release_Notes: http://go/help_app-x20/relnotes/Main/help_app_nightly_202012110600_RC00.html https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/help_app/app/+/uy5XHEDp0PRtsgJbbd4msEw8daRlxeojctOjsJikhv8C If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/help-app-chromium-autoroll Please CC help-app@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: b/346691017 Tbr: help-app@grotations.appspotmail.com Change-Id: I4e4a7c9d96d6a955bbe871bc5881fda994692372 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586948Reviewed-by:
-
Mark Yacoub authored
If a scheduling a page flip fails due to SWAP_NAK_RECREATE_BUFFERS, allocate new images for the subsequent flips. BUG: 979736 TEST: reallocate buffers after a modeset with RBC modifier enabled Change-Id: I54ed184ecba36a280f315fa30aa667ac42b32d09 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2581693 Commit-Queue: Mark Yacoub <markyacoub@google.com> Reviewed-by:
Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#836146}
-
Christoffer Jansson authored
Change-Id: Idb272f9406080f1c1fac2c70d7538400ea115311 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2569815 Commit-Queue: John Chen <johnchen@chromium.org> Reviewed-by:
Edward Lesmes <ehmaldonado@chromium.org> Reviewed-by:
Mirko Bonadei <mbonadei@chromium.org> Auto-Submit: Christoffer Jansson <jansson@chromium.org> Cr-Commit-Position: refs/heads/master@{#836145}
-
Koji Ishii authored
Bug: 1154531 Change-Id: Ic58533a391700aea8bb8d5aba9d88b5db1386510 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2584427 Auto-Submit: Koji Ishii <kojii@chromium.org> Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
-
Scott Violet authored
This updates a number of call sites to use inclusive terms. BUG=1105161 TEST=none, rename only Change-Id: I366e5087bb5b0b98ceffe055224f01ea5a3fecaf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2585226Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Daniel Rubery <drubery@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#836143}
-
Koji Ishii authored
Bug: 1154531 Change-Id: I2bf795a14dbedccbb066456ec4ab756808a6ecd1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586636 Auto-Submit: Koji Ishii <kojii@chromium.org> Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
-
Ella Ge authored
Tbr: tvanderlippe@chromium.org No-try: true Bug: 1157854 Change-Id: Iab79585fd084cb86abf422a18dc915f653ed387d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2585807Reviewed-by:
-
Ella Ge authored
failing on mac10.14 Tbr: joalmei@microsoft.com No-try: true Bug: 1157857 Change-Id: I1a1b57d45d67c10d4170831fcae3bc8ce19a20f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2585638Reviewed-by:
-
Olesia Marukhno authored
Temporary hide chip when user starts typing in the omnibox and re-show it after user exits the edit mode. Bug: 1153197 Change-Id: Ibb5cce6e384b6fe6e0a52a4fda838ca26cab208f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2574277 Commit-Queue: Olesia Marukhno <olesiamarukhno@google.com> Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#836139}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/549a44bb4574..54c26addfe46 2020-12-11 sigurds@chromium.org Report non-HTTP errors in Developer Resources View 2020-12-11 petermarshall@chromium.org Larger line-height for tabbed pane headers If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1069378,chromium:1106182,chromium:1156789 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I226030657b26b6dd1067b094eb41d7a5c6311a03 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587093Reviewed-by:
-
Peng Huang authored
With NVidia GPU, the Xserver crashing and vkCreateSwapchainKHR() returning errors happen at same time. Not sure if Xserver crashes cause the vkCreateSwapchainKHR() call fail, or Chrome crashes after vkCreateSwapchainKHR() returning errors cause Xserver crash. So with this change, Chrome GPU process will not crash when vkCreateSwapchainKHR() return errors. Instead chrome GPU process will handle the error, and consider it as context lost, and then try to tear down everything, and then restart the GPU process. Bug: 1149673 Change-Id: I9f5e5ca5aaf3f17107e1f9de31fa7837e6489d23 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587073 Commit-Queue: Peng Huang <penghuang@chromium.org> Reviewed-by:
Vasiliy Telezhnikov <vasilyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#836137}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1607666365-c1cc1d25065c901589c113e3c731cdd417d0631b.profdata to chrome-win64-master-1607677133-25f70964da7400c139fdb96077d2bf8b05dd84bf.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ic3d466709a9ae64f3fa7999e43011e991948c4d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586663Reviewed-by:
-
