GitLab

Bug: 1153264
Change-Id: I82cb51a3f03ba9e8c7ad0f1e156f1f4ede680393
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2565713Reviewed-by: Rebekah Potter <rbpotter@chromium.org>
Commit-Queue: John Lee <johntlee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#832103}

The maximum size allow for canvas initialization is 2147483647 (2^31-1).
When such a canvas is created, it requires 2^62 * (byte per pixel)
memory, or more than 1 terabyte of memory, to be allocate. It's not
reasonable to update canvas memory usage based on this number. In this
cl, I added a upper limit for the canvas size for memory usage
calculation only.

Bug: 1150554

Change-Id: I326a86fb804212b7f41f0f1cad153de35861b399
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2562825Reviewed-by: Fernando Serboncini <fserb@chromium.org>
Commit-Queue: Yi Xu <yiyix@chromium.org>
Cr-Commit-Position: refs/heads/master@{#832102}

//components/f... also removed duplicated metadata from OWNERS files

Bug: 1113033
Change-Id: I058eb222183a54f03a78c2215e9b261f598937e7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2566453Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Norman Rosas <normando@google.com>
Cr-Commit-Position: refs/heads/master@{#832101}

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll
Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com
Change-Id: Ib6ae23e3f1f302ea46213f0b713a1a1e59993ad8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2566431Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#832100}

NSDisableScreenUpdates() is deprecated starting in 10.11.

Bug: 1153883
Change-Id: I0a807292e5faa868d873fa7f3167a1a1e9e8d2f7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2565661Reviewed-by: ccameron <ccameron@chromium.org>
Commit-Queue: Robert Sesek <rsesek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#832099}

This has been replaced with a tab in the Help App.

Bug: b/171516802
Change-Id: I4ec4ec23a33238ae389c666e0a25c872fcf437c5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2558080
Commit-Queue: Rachel Carpenter <carpenterr@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Nancy Wang <nancylingwang@chromium.org>
Reviewed-by: Alan Cutter <alancutter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#832098}

Fix alwaysUv AuthenticatorImpl tests. The test for MakeCredential was
verifying that even if the RP discourages UV, we created a credential
with UV. But since by default the virtual authenticator does not support
U2F, that's what we would do even if we did not respect the alwaysUv
flag at all. This patch makes alwaysUv test virtual authenticators
support U2F to make sure we're actually respecting the flag.

I also fixed up the virtual authenticator behaviour when attempting to
use U2F with the alwaysUv flag on to what the spec says.

Fixed: 1149712
Change-Id: Ic92ee6d67d328fb6c746157463dc8ed17ef7b1db
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2564003
Commit-Queue: Martin Kreichgauer <martinkr@google.com>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Reviewed-by: Martin Kreichgauer <martinkr@google.com>
Auto-Submit: Nina Satragno <nsatragno@chromium.org>
Cr-Commit-Position: refs/heads/master@{#832097}

Bug: 1152592
Change-Id: I009feade446113d8beb213f50a1f2755488ba68c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2559584
Commit-Queue: Carlos Knippschild <carlosk@chromium.org>
Reviewed-by: Dan H <harringtond@chromium.org>
Cr-Commit-Position: refs/heads/master@{#832096}

This CL updates PendingAppManager to return an InstallResult struct
instead of just an InstallResultCode. This struct contains an additional
bool to indicate whether the app installation uninstalled and replaced
an old app.

This is in preparation to add a
WebApp.Preinstalled.UninstallAndReplaceCount UMA histogram:
https://chromium-review.googlesource.com/c/chromium/src/+/2561999

There are three refactors and no behavioural changes in this CL:
 - PendingAppManager::InstallResult struct added to replace
   InstallResultCode.
 - PendingAppInstallTask::Result removed in favour of passing
   base::Optional<AppId> app_id, PendingAppManager::InstallResult result
   params.
 - WebAppUiManager::UninstallAndReplaceIfExists() now returns a bool
   indicating whether it did anything.

Bug: 809304, 1058265
Change-Id: I4d46052be13f86122215d3ef93eddcadc5f2fa2f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2563148Reviewed-by: Azeem Arshad <azeemarshad@chromium.org>
Reviewed-by: Glen Robertson <glenrob@chromium.org>
Commit-Queue: Alan Cutter <alancutter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#832095}

When there is no favicon in real tab grid card, we should also get rid
of the favicon in the animation card to make the animation consistent.

Bug: 1153923
Change-Id: I8886d0b9f3c58063a0d9c13b86b556114b33a7d5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2565636Reviewed-by: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
Commit-Queue: Yue Zhang <yuezhanggg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#832094}

Otherwise, enabling both feature flags PartitionAllocPCScan and
PartitionAllocPCScanBrowserOnly fails.

Bug: 11297512
Change-Id: I9a9fb0f9a59a05d6dfc1ed46180cf772300b865d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2565439
Commit-Queue: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Auto-Submit: Anton Bikineev <bikineev@chromium.org>
Cr-Commit-Position: refs/heads/master@{#832093}

Follow-up on code review:
https://chromium-review.googlesource.com/c/chromium/src/+/2553082

Bug: none
Change-Id: I4ebf6d7aff430d53c15dfc52df3d9de9d82b33f8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2566512Reviewed-by: Erik Chen <erikchen@chromium.org>
Commit-Queue: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#832092}

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/f819411f2a3c..1af7968d686d

2020-11-30 siggi@chromium.org Reduce git cl split oversplitting.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/depot-tools-chromium-autoroll
Please CC ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com
Change-Id: I2e2e011da4e69dea5c8e34f9885a56a2670077e4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2566651Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#832091}

The old progress center isn't in use any more. This CL removes the code
supporting it.

Remove the UI test that was testing the old progress center.

Change test transferFromDownloadsToDownloads() to check the new feedback
panel.

Bug: 1027012
Change-Id: Ifab607ecbeff9456181c5a3f9f3ed4b41c63b8c0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2563528
Auto-Submit: Luciano Pacheco <lucmult@chromium.org>
Reviewed-by: Alex Danilo <adanilo@chromium.org>
Commit-Queue: Alex Danilo <adanilo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#832090}

Find and replace wrongly the first time.
Actual phrasing is in http://go/cros-input-methods-naming

Bug: None
Change-Id: I0b6ad6865ebf3b43f1924486482a2494b07048bf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2565225Reviewed-by: Darren Shen <shend@chromium.org>
Commit-Queue: My Nguyen <myy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#832089}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/779fa622..f1e2bbd8

Please follow these instructions for assigning/CC'ing issues:
https://v8.dev/docs/triage-issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: I8d4e31a7eb399b05b7b33efcf94454853bbb288a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2564531Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#832088}

This patch adds the virtual methods to the uninstallation path, and adds
corresponding tests for those in the unittests file.

R=phillis@chromium.org

Change-Id: I316145e6030d16ff3a28bf7fecb3d2cdbac940d4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2545864
Commit-Queue: Daniel Murphy <dmurph@chromium.org>
Reviewed-by: Phillis Tang <phillis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#832087}

This is a reland of 32cf67c4

Reason for overlay-popup-ad browsertest failure on Mac 10.15: in the
original patch the popup ad was given a fixed 300x300 size. This is
sufficiently large relative to the window area on regular tryjob bots;
however, the window area on the Mac 10.15 bot is bigger, so the ad will
be skipped as it's too small compared to the window's dimension.

This patch fixed the problem by specifying a size relative to the
window's dimension, i.e. 0.5 * window_width X 0.5 * window_height.

Original change's description:
> Sticky and Overlay-popup ads recorded in ads intervention manager
>
> This change propagates signals for sticky ad and overlay-popup ad
> detection from the renderer to the ads intervention manager through
> the subresource filter component.
>
> As the ads intervention manager is running in dry run mode and
> does not block ads, this allows us to record intervention behavior
> when triggered by one of these two interventions. Understanding
> the intervention behavior is a precursor to the ads intervention
> manager intervening to actively intervening on sites with better
> ads standard violations.
>
> Add base::Feature flags to allow disabling the frequency capping from
> either web_tests and browsertests. Move relevant tests into a virtual
> test suite that has the flag disabled.
>
> Bug: 1099741
> Change-Id: Id0c922adfbb7cd71f641c6e9586eed9c311feb18
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2525769
> Commit-Queue: Yao Xiao <yaoxia@chromium.org>
> Reviewed-by: Eric Robinson <ericrobinson@chromium.org>
> Reviewed-by: Daniel Cheng <dcheng@chromium.org>
> Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
> Reviewed-by: Stefan Zager <szager@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#829547}

Bug: 1099741
Change-Id: I6fed9cb2e4ad223a05e150b67811141b72124202
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2553977
Commit-Queue: Yao Xiao <yaoxia@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Stefan Zager <szager@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Eric Robinson <ericrobinson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#832086}

The functions VideoCaptureDeviceMac::ReceiveFrame and then
VideoCaptureDeviceClient::OnIncomingCapturedData accept a data pointer,
but not stride information. These functions assume that all video frame
data provided is tightly packed. This is not a valid assumption.

When processing a CVPixelBuffer, retrieve the layout of the buffer, and
compute the layout of a tightly-packed version of the buffer. If they
do not match up, copy the CVPixelBuffer to a tightly-packed temporary
buffer and use that.

         naturally and are okay with the fix,
         Manually forced testing of NV12 frames

Testing: Logi 4k pro capture at 360x249 and BRIO 4K 240p hits this
Bug: 1151936
Change-Id: I1ce74629717316ae9387881d70dfb43186e3e906
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2566094Reviewed-by: Markus Handell <handellm@google.com>
Commit-Queue: ccameron <ccameron@chromium.org>
Cr-Commit-Position: refs/heads/master@{#832085}

This enforces the invariant that CertVerifyResult::verified_cert should
always be non-null for the case when a MojoCertVerifier is disconnected,
and also adds a check to CertAndCTVerifier to only perform CT
verification if the underlying CertVerifier succeeded. This fixes a
crash where the CT verification step would assume there was a cert in
the CertVerifyResult, but MojoCertVerifier had been disconnected and
reset the CertVerifyResult in its disconnect handler.

Bug: 1153484
Change-Id: I6039ea4e28715a5c6d5e9a2878c538ddf4d5aa8f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2565537Reviewed-by: Ryan Sleevi <rsleevi@chromium.org>
Commit-Queue: Chris Thompson <cthomp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#832084}

This is to ensure that "command" is displayed at the top
of the summary html. Find the context from
https://chromium-review.googlesource.com/c/chromium/src/+/2561625/7#message-af6e8ef9b88c4031353ca71fd5f90a5861a57d69

R=robertma@chromium.org
CC=chanli@chromium.org,nodir@chromium.org

Change-Id: I0d8df947b56a83b69db88241e2ea1b5acab46b72
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2565397Reviewed-by: Robert Ma <robertma@chromium.org>
Commit-Queue: Scott Lee <ddoman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#832083}

This patch changes |TypingCommand::DeleteKeyPressed()| to handle
anonymous placeholder instead of |ComputeAdjustedSelection()| to limit
scope of special handling for improving code health.

* Anonymous placeholder is a <br> in anonymous block having only it.
* Placeholder is represented by <div><br></div>.

Example of special handling:
<div contenteditable><img style="display:block"><br></div>

Before this patch, |ComputeAdjustedSelection()| returns range selection:
After:<img>, Before:<br> even if both positions specify equivalent
position <div>@1. After this patch |ComputeAdjustedSelection()| returns
caret selection Before:<br>.

Note: |TypingCommand::DeleteKeyPressed()| basically does extend
selection backward in character then applies |DeleteSelectionCommand|.

Bug: 1143292
Change-Id: I33879d0fa8598b5c26b41ecbdaf134029b240cf4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2564140
Commit-Queue: Koji Ishii <kojii@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Auto-Submit: Yoshifumi Inoue <yosin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#832082}

Add the HttpsLatency routine to the ServiceConnection.

BUG=chromium:956783
TEST=1) chromeos_unittests --gtest_filter=CrosHealthdServiceConnectionTest.*
2) unit_tests --gtest_filter=DeviceCommandRunRoutineJobTest*
3) Applied HttpsLatency changes and successfully ran the
HttpsLatency routine on a DUT (verified using cros-health-tool diag
--action=run_routine --routine=https_latency).

Change-Id: I7324a6ba08587a382c4fe04893f5426a13d98a56
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485138
Commit-Queue: Kartik Hegde <khegde@chromium.org>
Auto-Submit: Kartik Hegde <khegde@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#832081}

This patch improves logging of the status resturned by debugd call when
a new printer is installed. Now, the returned status is always logged to
PRINTER_LOG.

BUG=b:172226448
TEST=tested on atlas - setup a new printer

Change-Id: Id6cd07ca96ddbbd294fab8f73d742087979c9666
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2555464
Commit-Queue: Piotr Pawliczek <pawliczek@chromium.org>
Auto-Submit: Piotr Pawliczek <pawliczek@chromium.org>
Reviewed-by: Sean Kau <skau@chromium.org>
Cr-Commit-Position: refs/heads/master@{#832080}

As SHELL tests are going to be always enabled on some bots, it needs to
use base test_runner.

This CL is adding the support of using base test_runner for SHELL.

BUG=chromium:1151230

Change-Id: I4d059d7bc30878013e5058349af8743b2fa0aec5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2560207Reviewed-by: Dirk Pranke <dpranke@google.com>
Reviewed-by: François Doray <fdoray@chromium.org>
Reviewed-by: Amr Aboelkher <amraboelkher@chromium.org>
Commit-Queue: Dirk Pranke <dpranke@google.com>
Cr-Commit-Position: refs/heads/master@{#832079}

For offscreen canvases without a placeholder canvas, the
CanvasRenderingContextHost is of type OffscreenCanvas, not
HTMLCanvasElement. This change sets the xr compatible flag to false for
these canvases to avoid the security issue of casting incompatible types

A follow up change will add support and tests for OffscreenCanvas.

Bug: 1149204
Change-Id: Id8d31126b4ba2af50d02390141afdd4e4046394f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2545580Reviewed-by: Brandon Jones <bajones@chromium.org>
Commit-Queue: Patrick To <patrto@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#832078}

Before: http://screen/7bzBJpDMwKszF8A
After: http://screen/5cuRajTAcs39EjF

Bug: 1070190
Change-Id: If955cd3d0540d58e3351ece9d138907ddc1f9809
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2562740
Auto-Submit: Yann Dago <ydago@chromium.org>
Commit-Queue: Esmael Elmoslimany <aee@chromium.org>
Reviewed-by: Esmael Elmoslimany <aee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#832077}

Add local modifications to remove one unused method, and reimplement
another using a non-deprecated API.

Bug: 1153883
Change-Id: Iad59c5e798e440aa256e81f9f4ee79cfa05310e5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2566154Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Robert Sesek <rsesek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#832076}

Fixed: 1153729, 1152024, 1142491, 1140098
TEST: None
Change-Id: Ie4765a7a7c66a71c234925edbca8b95e78c66b48
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2566011Reviewed-by: Brian White <bcwhite@chromium.org>
Commit-Queue: Ahmed Fakhry <afakhry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#832075}

The bug is caused by missing a call of triggerUrlFocusAnimation() when
the Instant Start is enabled. In this CL, we cache the pending request,
and call the function when native is ready.

Bug: 1152306
Change-Id: I8621a1bd6ebdb859683e6bfef3e0d88576fa502c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2562745Reviewed-by: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
Reviewed-by: Matthew Jones <mdjones@chromium.org>
Commit-Queue: Xi Han <hanxi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#832074}

I think this isn't used.

Change-Id: Icf334d0b5729f7b370a0878e718501f160466674
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2545962
Auto-Submit: David Lei <dlei@google.com>
Commit-Queue: Scott Violet <sky@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#832073}

Bug: 1145230
Change-Id: I4cbcff5d544802cca74675136eabc34aa541854f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2566373
Auto-Submit: Garrett Beaty <gbeaty@chromium.org>
Reviewed-by: Erik Staab <estaab@chromium.org>
Commit-Queue: Erik Staab <estaab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#832072}

IsCompleted is backwards. For a more consistent api, the function is
renamed IsActive and logic is flipped.
Following up on rename in v8
https://chromium-review.googlesource.com/c/v8/v8/+/2510969
The intend is to make the distinction between IsActive and IsValid obvious.

Change-Id: I196c889138bf244ff96568fc6f1e11b5aa4acd47
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2514480Reviewed-by: Omer Katz <omerkatz@chromium.org>
Reviewed-by: Ross McIlroy <rmcilroy@chromium.org>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org>
Cr-Commit-Position: refs/heads/master@{#832071}

Use an observer on current app state to determine what should be showing
in the preview pane.

Add more testing for preview page logic.

Bug: 1059779
Change-Id: Iccd4c924e292f41a662bc472125f78eb82861095
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2564899Reviewed-by: Jesse Schettler <jschettler@chromium.org>
Commit-Queue: Gavin Williams <gavinwill@chromium.org>
Cr-Commit-Position: refs/heads/master@{#832070}

crrev.com/c/2442229 added some temporary histogramming to FetchManager to identify why failing Trust Tokens operations were failing. Now that
we've found the cause (crbug.com/1128174; internal due to internal repro instructions, sorry), we can remove this instrumentation and clear up a hundred lines or so in fetch_manager.cc. We're keeping
Net.TrustTokens.NetErrorForTrustTokenOperation, which we added at close to the same time, around to use a health indicator.

Change-Id: Ib7178d30a03b1aaa529aafdd4c9f36cfc84e1dbc
Fixed: 1133944
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2561778
Commit-Queue: David Van Cleve <davidvc@chromium.org>
Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Reviewed-by: Charlie Harrison <csharrison@chromium.org>
Cr-Commit-Position: refs/heads/master@{#832069}

TBR=bling-team@google.com

Change-Id: I422d9d8833c0657a2ed4043d01fd9dd28f0df504
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2566030Reviewed-by: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#832068}

This rolls to the most recent version of the Text Fragments Polyfill
lib, which includes context-based matches (i.e., prefix/suffix params)
to improve robustness of URL generation.

Bug: 1153973
Change-Id: I6e8786655ee4b6662846365595a466a2c7523edc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2566050Reviewed-by: sebsg <sebsg@chromium.org>
Commit-Queue: Tommy Martino <tmartino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#832067}

Fix use-after-move (potential) bugs found by the
"bugprone-use-after-move" clang-tidy check.

Bug: 1122844
Change-Id: I7bde24a2f8e6d12603b92020da1b5410d3cf8457
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2555066
Commit-Queue: Nicholas Verne <nverne@chromium.org>
Auto-Submit: Maksim Ivanov <emaxx@chromium.org>
Reviewed-by: Nicholas Verne <nverne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#832066}

Parametrize the minimum PIN length on the "Set a new PIN" security keys
settings dialog. Previously, it was hard-coded to four, which did not
match the error handling message.

TBR'ing cpu@ for grdp file changes.

Tbr: cpu@chromium.org
Fixed: 1152604
Change-Id: I0e47224f6874722b6abc0618f3a572d40fafcb8f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2562972
Commit-Queue: Nina Satragno <nsatragno@chromium.org>
Reviewed-by: Theodore Olsauskas-Warren <sauski@google.com>
Reviewed-by: dpapad <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#832065}

Following the launch to ChromeOS, Tab Search intends to launch to the
remaining desktop platforms Linux, Mac and Windows.

This CL updates the fieldtrial testing config accordingly.

Bug: None
Change-Id: If15721273439669515d5ea673c0ce261e0ea4894
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2565652Reviewed-by: Mark Pearson <mpearson@chromium.org>
Commit-Queue: Thomas Lukaszewicz <tluk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#832064}