GitLab

global.cpp was removed in crrev.com/c/984113 because it uses
`pragma hdrstop`. This CL removes that directive when building Chromium.

Bug: 750327
Change-Id: I8d6af052bc6c9a9c10a6b824fd499b548c7714a6
Reviewed-on: https://chromium-review.googlesource.com/1037917Reviewed-by: Nathan Parker <nparker@chromium.org>
Commit-Queue: Varun Khaneja <vakh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555435}

Fixes the crash.

Original change's description:
> Media Controls: remove window event listener and listen to event on popup.
>
> This is moving the logic to hide the popups to the popup element class.
> It will hide when the popup no longer has focus, when the window is
> resized or scrolled. It slightly improves memory usage by only creating
> the event listener object on demand.
>
> Bug: 833461
> Change-Id: I979f0882108fcd89fdf84b2612437209b080eb95
> Reviewed-on: https://chromium-review.googlesource.com/1023345
> Reviewed-by: Becca Hughes <beccahughes@chromium.org>
> Commit-Queue: Mounir Lamouri <mlamouri@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#555083}

TBR=mlamouri@chromium.org

Change-Id: Id5fa81b6370dcb49d6ae7b0c958e07a4e0c23a4a
Reviewed-on: https://chromium-review.googlesource.com/1039587
Commit-Queue: Mounir Lamouri <mlamouri@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555434}

Bug: 760498
Change-Id: I937c5a123bbd4d3d5844f9e2916fd0a7dcfd1e81
Reviewed-on: https://chromium-review.googlesource.com/1039590Reviewed-by: Ned Nguyen <nednguyen@google.com>
Commit-Queue: Egor Pasko <pasko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555433}

Enabling tests for Android Chromium build bot on Waterfall.
The following tests from ChromeDriverTest class are enabled:

  testTouchDoubleTapElement,
  testTouchLongPressElement,
  testTouchSingleTapElement,

These tests were failing for older Chrome browsers running on Android devices
and in the most recent builds tests are passing, so we are enabling these tests.

Bug: chromedriver:2388
Change-Id: I270cca8631f97ad7820b1f416578ccc8656562f1
Reviewed-on: https://chromium-review.googlesource.com/1022510
Commit-Queue: Artur Khachatryan <khachatryan@chromium.org>
Reviewed-by: John Chen <johnchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555432}

This crash is caused because it refers the control buttons view which
may be null. This CL adds a null-check.

Also this refactors related code with IsCloseButtonFocused and
RequestFocusOnCloseButton. These methods do same thing among child classes
so that no need to be virtaul.

Bug: 836523
Test: none
Change-Id: I2f10d77b0772cc3bca51048473352daed5317589
Reviewed-on: https://chromium-review.googlesource.com/1037064Reviewed-by: Evan Stade <estade@chromium.org>
Commit-Queue: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555431}

Bug: 837647
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I9c07ca3bfe5df595b9973b6ab0b18d3e629cd6eb
Reviewed-on: https://chromium-review.googlesource.com/1035208
Commit-Queue: Biao She <bshe@chromium.org>
Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Reviewed-by: Klaus Weidner <klausw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555430}

Change-Id: I193440a6de9252e239d91a1028e02be141d5f32b
Reviewed-on: https://chromium-review.googlesource.com/1038690
Commit-Queue: Pavel Feldman <pfeldman@chromium.org>
Reviewed-by: Eric Seckler <eseckler@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Reviewed-by: Alex Clarke <alexclarke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555429}

The button actions container logic was recently refactored so that
the padding is now baked inside the extension icon view bounds:
https://chromium-review.googlesource.com/c/chromium/src/+/961722

This caused the extension icons to be chopped because it conflicts
with the existing code that sets the vertical padding and height in
the browser action container. This causes icon to have an incorrect
y offset.

This CL fixes the issue by removing the browser action container's
padding logic, since that is now done by the extension icon view.

Bug: 825157
Change-Id: I43a4ca55fba1af0aba9ead7279a74819ba04f0d9
Reviewed-on: https://chromium-review.googlesource.com/1037764Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Sarah Chan <spqchan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555428}

changes:
This CL makes ArcAppContextMenu showing Android app shortcuts in app
list context menu.
TODO list:
- Add ArcLauncherContextMenu integration for shelf item.
- Add LaunchAppShortcut support.
- Add UMA for measuring query & decode time.
- Add context menu metrics.
- UI adjustments when specs come.

video demo: go/appshortcuts-demo-1

Bug: 803291
Test: device test with android side change
Change-Id: I30f06d609eebc91c8d493af5bdb64360cdde002a
Reviewed-on: https://chromium-review.googlesource.com/1029412
Commit-Queue: Qiang Xu <warx@google.com>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Yusuke Sato <yusukes@chromium.org>
Reviewed-by: Yury Khmel <khmel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555427}

Bug: 781655
Change-Id: Ic009ba42a61d3e419d6e4ac449bc6656fdf37321
Reviewed-on: https://chromium-review.googlesource.com/1015785Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Adithya Srinivasan <adithyas@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555426}

Bug: 829323
Change-Id: I65a6b2631f10a72e2fcb3b4ebe420237a54590d2
Reviewed-on: https://chromium-review.googlesource.com/1039806Reviewed-by: Peter Conn <peconn@chromium.org>
Commit-Queue: Bernhard Bauer <bauerb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555425}

Bug: 834781
Change-Id: I6b21d7313c22e02e0454b36f2977ec11c1f8cfe0
Reviewed-on: https://chromium-review.googlesource.com/1038149
Commit-Queue: Max Moroz <mmoroz@chromium.org>
Reviewed-by: Jonathan Metzman <metzman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555424}

Design doc: https://docs.google.com/document/d/1zk6WSUb063I_07ct1EP8krOsDKXai1v4nJchvpQeAio/

TBR=avi@chromium.org

Bug: 826257
Change-Id: If883c9380a79cad8922ef3a21f2daa4cc73778a6
Reviewed-on: https://chromium-review.googlesource.com/1021516
Commit-Queue: Rayan Kanso <rayankans@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555423}

gfx::Transform is the ultimate type we want to use for cc, so avoid the
intermediate conversions thru WebLayer APIs.

R=jbroman@chromium.org, pdr@chromium.org

Bug: 838693, 738465
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I4774a4ccc8d5cab11712433a6f0933f1dd3719a9
Reviewed-on: https://chromium-review.googlesource.com/1038604
Commit-Queue: danakj <danakj@chromium.org>
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555422}

Currently we return a bool in TouchActionFilter::FilterGestureEvent, this
CL change the return value to an enum. This is aimed to improve readability,
and to prepare for later changes of unblocking a gesture event when it
hits main thread touch action region.

This CL contains mechanical changes only, there is no behavior change
introduced.

Bug: 772130
Change-Id: I72b3c5e1047c22923db2e1dcf58f684ab07aa343
Reviewed-on: https://chromium-review.googlesource.com/1039246Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
Commit-Queue: Xida Chen <xidachen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555421}

This way code can call content::BindInterfaceInGpuProcess() and have
it correctly wire up DiscardableSharedMemoryManager.

BUG=837689
TEST=none

Change-Id: I93b1b5fb07bb0b1f0f38ebed03ca8d47c15d1b0d
Reviewed-on: https://chromium-review.googlesource.com/1033961Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555420}

Some page load timeout tests are currently flaky on Mac. Adding some
debugging output to help diagnose this issue.

Bug: chromedriver:2407
Change-Id: Ic16074e77e2b100ea3f9d104bf9eef4599f78b6b
Reviewed-on: https://chromium-review.googlesource.com/1036592Reviewed-by: Jonathon Kereliuk <kereliuk@chromium.org>
Commit-Queue: John Chen <johnchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555419}

At the moment, the isolate is allocated and initialized in a single
step. This has the downside that the platform cannot register the
isolate before the isolate gets initialized, and therefore the platform
is not available for the isolate during initialization. With this CL we
register the uninitialized isolate on the platform and initialize the
isolate after that.

This change is needed to allow the creation of task runners already
during the initialization of the isolate.

The related V8 CL: https://crrev.com/c/1014044

R=yangguo@chromium.org

Change-Id: I7a18d1e91f53d728b40a68152e3a3dcb84cf34bb
Reviewed-on: https://chromium-review.googlesource.com/1015020Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Commit-Queue: Andreas Haas <ahaas@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555418}

This change adds some checks to the keyboard lock API to ensure it was
called from within a supported context, otherwise it now rejects the
promise.

BUG=680809

Change-Id: I3d127422c640d16e43c22adb14755b65eb2cdc6a
Reviewed-on: https://chromium-review.googlesource.com/1038888Reviewed-by: Gary Kacmarcik <garykac@chromium.org>
Commit-Queue: Joe Downing <joedow@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555417}

There are two instances where PictureInPictureWindowController
is torn down:
1. Tab is closed (controller is tied to the tab's WebContents). In this
case, the player is also deleted, so there are no behavioral concerns.
2. A video on a different tab enters Picture-in-Picture mode. In this
case, the player from the earlier PiP'd tab may still be playing in that
tab, meaning there may be two(+) videos playing.

This change would pause the initial video, as the user has indicated
they want to PiP a new video.

This behavior will be up for further discussion with UX.

BUG: 823172
Change-Id: I3e1a58f496f5814a4a8aae40df3de23cd0ee6702
Reviewed-on: https://chromium-review.googlesource.com/1038303Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Commit-Queue: apacible <apacible@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555416}

Currently, the PictureInPictureWindowController is reset and torn down
whenever a new video goes into Picture-in-Picture mode. This is less
than ideal since the PictureInPictureWindowController is attached and
scoped to the lifetime of a WebContents via WebContentsUserData.

Rather, we should allow the natural teardown of the controller when
the initiator tabs is destroyed.

BUG: 823172
Change-Id: I7e13b8bf45899fd4ff4b3dbd34781d04ab15dc1d
Reviewed-on: https://chromium-review.googlesource.com/1034194
Commit-Queue: apacible <apacible@chromium.org>
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555415}

Removes the mNeedsReload flag in Tab.java which was just a thin
and partial wrapper around the navigation controller's needs_reload
mechanism. This duplication caused at least one race
condition (crbug.com/828400) and will also complicate future
LifecycleManager work.

All of the checking in Tab.java of mNeedsReload was duplicated by the
navigation controller's needs_reload flag, as used in
NavigationControllerImpl::LoadIfNecessary.

Bug: 829381
Change-Id: Id17c9d9f89088c718ae4a927ea5b8dbe95126e68
Reviewed-on: https://chromium-review.googlesource.com/1006958Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Reviewed-by: Camille Lamy <clamy@chromium.org>
Reviewed-by: François Doray <fdoray@chromium.org>
Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Commit-Queue: Matthew Cary <mattcary@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555414}

Updated spec for system top bar doesn't have this separator.

Bug: 838649
Test: Manual
Change-Id: I3ef1b914e2ac830978311bf5a446a8a4888232bd
Reviewed-on: https://chromium-review.googlesource.com/1039946Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: David Reveman <reveman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555413}

Only test was removed in https://github.com/w3c/web-platform-tests/pull/9967.

No-Try: true
Change-Id: I9cb46906d621d25261476f5de414622f694d4173
Reviewed-on: https://chromium-review.googlesource.com/1039191Reviewed-by: Gary Kacmarcik <garykac@chromium.org>
Commit-Queue: Gary Kacmarcik <garykac@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555412}

Also update base::Bind to base::BindRepeating.

Background: I tried using the template form of Start() on a base::MockTimer and
was confused because it wasn't working.  This was because Timer::Start() was
getting called instead of MockTimer::Start.

BUG=None
R=thestig

Change-Id: I15341804f364c9d5fd1f590c5e6d02db1728614c
Reviewed-on: https://chromium-review.googlesource.com/1038815Reviewed-by: Taiju Tsuiki <tzik@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555411}

https://chromium.googlesource.com/chromiumos/chromite.git/+log/dd3fcf9f3eb0..5d4cebe797eb

$ git log dd3fcf9f3..5d4cebe79 --date=short --no-merges --format='%ad %ae %s'
2018-05-01 levarum Restore copying cheets_x86_userdebug artifacts

Created with:
  roll-dep src/third_party/chromite


The AutoRoll server is located here: https://chromite-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=chrome-os-gardeners@chromium.org

Change-Id: I9aff48d163a37863611212199a05387b30d734d9
Reviewed-on: https://chromium-review.googlesource.com/1039765
Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#555410}

This CL removes the State member of QueueingTimeEstimator since it is no
longer needed. This is the first step in the plan to report EQT by TTI.

https://docs.google.com/document/d/19D0f5VGFNmqJDcl5_AqkYOm1iUX24adPloCRO58aiH4/

Bug: 832680, 830882
Change-Id: I571c75a15b51be1f8bff5b105257d6bb0d1092fc
Reviewed-on: https://chromium-review.googlesource.com/1035162Reviewed-by: Alexander Timin <altimin@chromium.org>
Commit-Queue: Nicolás Peña Moreno <npm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555409}

Following bot results are included.
5114 5118 5123 5127 5129 5134 5138 5139 5141

1 lines were removed and 2 lines were deflaked by consecutive
results since 5080.

TBR=eae@chromium.org, mstensho@chromium.org
NOTRY=true

Bug: 591099
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng
Change-Id: I75e4c437e4485caad44eea69eded7d37cfb0341d
Reviewed-on: https://chromium-review.googlesource.com/1036868
Commit-Queue: Koji Ishii <kojii@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555408}

The class NavigationPostDataHandle doesn't exist anymore. It is not
clear to me if it has ever existed.

Bug: None.
Change-Id: I98d95f02b6e3b03f9f31b6ceeac2e472846dd524
Reviewed-on: https://chromium-review.googlesource.com/1039487Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555407}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/99550832..1e3401a0

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org

Change-Id: I1e712b9888c34c7e32309bb50cf15e149a389f8c
Reviewed-on: https://chromium-review.googlesource.com/1038918Reviewed-by: v8 autoroll <v8-autoroll@chromium.org>
Commit-Queue: v8 autoroll <v8-autoroll@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555406}

The test class now works with frame requests when the network service is disabled.

Bug: 776589
Change-Id: Iec439f88db2e2daddec350251dc19309a1c2bd5c
Reviewed-on: https://chromium-review.googlesource.com/1038651
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Matthew Cary <mattcary@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555405}

The histogram is used in NavigationURLLoaderNetworkService as:
Navigation.URLLoaderNetworkService.OnCompleteHadSSLInfo

But it is declared in histograms.xml as:
Navigation.URLLoaderNetworkService.OnCompleteHasSSLInfo

The names don't match ("Had" vs "Has"). This CL fixes it.

Bug: 783265
Change-Id: I33ea9ae1ba92aaa20dab4b80f3e731b4229f3efa
Reviewed-on: https://chromium-review.googlesource.com/1039200Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555404}

Make PageSchedulerImplTest.DeleteThrottledQueue_InTask faster by
reducing the number of tasks it runs.

The number got large when we started running tasks after frame detach.

R=alexclarke@chromium.org

Change-Id: Idf64f179dfafd9edccdff1c69624b5cc9b4694f6
Reviewed-on: https://chromium-review.googlesource.com/1039447Reviewed-by: Alex Clarke <alexclarke@chromium.org>
Commit-Queue: Alexander Timin <altimin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555403}

Flaky.

https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=chrome_public_test_apk&tests=testTapInputFieldShowsKeyboardAccessory

Bug: 838922
TBR: fhorschig@chromium.org,bauerb@chromium.org
Change-Id: I9b55187a8d528a149221075f03186bbaa2b8e789
Reviewed-on: https://chromium-review.googlesource.com/1039826Reviewed-by: Matthew Cary <mattcary@chromium.org>
Commit-Queue: Matthew Cary <mattcary@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555402}

The test class now works with frame requests when the network service is disabled.

Bug: 776589
Change-Id: Ieae2c903860e5263aa73fc3f3521de9f53b0eb4d
Reviewed-on: https://chromium-review.googlesource.com/1038621Reviewed-by: Doug Turner <dougt@chromium.org>
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555401}

Instead of disabling throttling for the whole renderer process when
audio is enabled, disable it only for the current Page.

This will allow to use audio signal when making decisions about loading
throttling and throttling dedicated workers.

R=alexclarke@chromium.org

Change-Id: I78ee861da3e46d12c597294ff8c054bc61b9be6a
Reviewed-on: https://chromium-review.googlesource.com/1039426Reviewed-by: Alex Clarke <alexclarke@chromium.org>
Commit-Queue: Alexander Timin <altimin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555400}

https://pdfium.googlesource.com/pdfium.git/+log/c9cd2874278e..5f3e4f1605a5

$ git log c9cd28742..5f3e4f160 --date=short --no-merges --format='%ad %ae %s'
2018-05-02 tsepez Add CPDF_Document::Extension::GetPageCount()

Created with:
  roll-dep src/third_party/pdfium


The AutoRoll server is located here: https://pdfium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=dsinclair@chromium.org

Change-Id: Iec590ce4046816dfc40bada2204b111b5fa6d937
Reviewed-on: https://chromium-review.googlesource.com/1039626
Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#555399}

This CL removes a TODO that was left in the code when the to do was done.
(That being to separate OmniboxMatchCellView to its own file).

There are no logic changes in this CL.

Bug: None
Change-Id: Idc85e8dfad6a0b15e5458ac09ca92f070aaa923d
Reviewed-on: https://chromium-review.googlesource.com/1038662Reviewed-by: Justin Donnelly <jdonnelly@chromium.org>
Commit-Queue: Justin Donnelly <jdonnelly@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555398}

For mustash (out-of-process ash, see //ash/README.md) code in the
browser process cannot call directly into ash.

Pin the kiosk app window by setting a window property instead of
calling into ash code.

Test:
* Add logging to ArcKioskAppLauncher and deploy to Chromebook
* Enterprise enroll Chromebook to test domain
* Move Chromebook to ARC++ test organizational unit
* Sign in and allow policy to force-push app
* Sign out, observe app auto-launch
* Hit escape, see toast saying app is pinned fullscreen
* Observe logs in /var/log/ui/ui.LATEST

Bug: 756056
Change-Id: I8ac35030bf8b44429096a14ec9a6ad71617e85d8
Reviewed-on: https://chromium-review.googlesource.com/1037775Reviewed-by: Sergey Poromov <poromov@chromium.org>
Commit-Queue: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555397}

This enforces a stricter patch read in a few ways:
- Raw Deltas of 0 are forbidden. These are unused values which have no
  meaning and should not appear.
- Extra Data length must be equal to the size of the patch element
  minus the total length of equivalences.
- Element match headers must have regions of nonzero length.

This change also annotates a number of "unsafe" values read from the
patch that could be sources of error later if unchecked. It also adds
caveats about under what conditions emitted values are considered to
be safe/unsafe.

Bug: 837096
Change-Id: I1b7614d92b85c0a1546d8dccb7d371d28b2a4cd3
Reviewed-on: https://chromium-review.googlesource.com/1037186
Commit-Queue: Calder Kitagawa <ckitagawa@google.com>
Reviewed-by: Samuel Huang <huangs@chromium.org>
Reviewed-by: Greg Thompson <grt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555396}