- 20 Apr, 2019 37 commits
-
-
François Beaufort authored
This CL makes sure Picture-in-Picture window is always visible on all workspaces by calling SetVisibleOnAllWorkspaces when it is shown. Bug: 954470 Change-Id: If1f60781dd79cb8fb884cb41f3fe596e77fd9438 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1575598 Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#652736}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/34a4af2494cc..e057820e36f5 git log 34a4af2494cc..e057820e36f5 --date=short --no-merges --format='%ad %ae %s' 2019-04-20 evanhernandez@chromium.org chromite: Remove TreeIsOpen and dependencies. 2019-04-20 dgagnon@google.com Update gen_luci_scheduler with R75 branch 2019-04-20 chrome-bot@chromium.org Update config settings by config-updater. Created with: gclient setdep -r src/third_party/chromite@e057820e36f5 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@chromium.org Change-Id: Iff3fbb3dfd0bdce6dd21233059bd7af94904ff8b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574613Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#652735}
-
Sunny Sachanandani authored
Map usage STAGING texture along with copy to usage DEFAULT texture to workaround crashes when mapping usage DYNAMIC textures. Restrict workaround to Intel driver versions < 24 based on crash data. Also add a few trace events for swap buffers, texture upload, blit, etc. Bug: 890227 Change-Id: I1cc9bae3fc0ddf6303375c99054113a9a995806c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1576016Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org> Cr-Commit-Position: refs/heads/master@{#652734}
-
Maggie Chen authored
The current way to handle the overlay swap chain creation failure might cause a complet black browser window, which is a very bad user experience. If we disable overlay when the creation fails, the video playback will be able to continue through GL composition if there is no other issue. Bug: 954661 Change-Id: I5f1355f9ff46d7c9a88a1ff0ccad4ed229710eb5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1576034Reviewed-by:
-
rajendrant authored
Bug: 952435 Change-Id: I9568cc51d467feba3f20b82b60cd465d5bf3d09d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574655Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: rajendrant <rajendrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#652732}
-
Johannes Henkel authored
New Rev = 4c2d2efe9aacf50d4242290097a2e74c14229276 This brings in the Status::ToASCIIString method. Change-Id: I01e5618f03cb4105b1f7144cdc6ee8ce6f80b23b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1576230Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#652731}
-
chromium-autoroll authored
The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: Icb709a41f6552b5ba6114fe0d2d825d4ee7bdcf9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574612Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/80140adf0944..b01f0f1dba2a Created with: gclient setdep -r src-internal@b01f0f1dba2a The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=fdoray@chromium.org,bsep@chromium.org,keishi@chromium.org,chanli@chromium.org Change-Id: I7b5af9c8e435db8ff3086c5f6ff0b5bfcbee3a8f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574611Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#652729}
-
Bruce Dawson authored
It is possible to accidentally call the Windows GetVersion() function when base::win::GetVersion() is intended. The code would compile due to implicit conversions from enum to int. This allowed buggy code to be checked in. Using enum class makes this error impossible. This change switches enum Version to enum class Version, which includes changing every usage of the Version enum. For services\service_manager TBR=wfh@chromium.org For the rest TBR=jochen@chromium.org Bug: 946677 Change-Id: I4b446370499e5e6a24446d18b541e2b4948405e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1541594Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Bruce Dawson <brucedawson@chromium.org> Cr-Commit-Position: refs/heads/master@{#652728}
-
Evan Stade authored
Ash will continue talking to the power manager daemon via DBus, while providing a mojo service that Chrome can connect to for its power manager needs. The mojo interface is only used by client code that explicitly opts in, and only when a specific feature flag is passed. This CL partially implements the Mojo interface as it's used by BrightnessMonitor, which is to say, it implements very little. Change-Id: Id0b286a690d1833b1090960cf31edfbe66124b24 Bug: 644348 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1531466 Commit-Queue: Evan Stade <estade@chromium.org> Reviewed-by:
Dan Erat <derat@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#652727}
-
Kenneth Russell authored
conformance/programs/program-test.html conformance/uniforms/uniform-default-values.html These tests are passing on the upgraded Mesa driver. Bug: 928530 Bug: 927466 Change-Id: Ib2ab2bf1ac30b777931dbc9344f2e3b20c608f9c Tbr: piman@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574649Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#652726}
-
Siddhartha S authored
Writing to consumer client data pipe in main thread can cause us to wait for the pipe to be ready on main thread. The main thread need to run other work like giving out SMBs to processes. It can also cause deadlock if the consumer client is also waiting for SMB. So, move the writer to background task runner. BUG=953837 Change-Id: I5cad2c45af8b4c7f0a69372e1c2633896c7e518e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1573162 Commit-Queue: ssid <ssid@chromium.org> Reviewed-by:
oysteine <oysteine@chromium.org> Cr-Commit-Position: refs/heads/master@{#652725}
-
Nasko Oskov authored
This check was initially added in r629679 and then reverted in r633938 due to unexpected renderer process terminations. Some bugs were discovered and fixed in the meantime, so this is an attempt to add the check back. The CL includes crash keys to capture more information about the state when the process is terminated to aid debugging. The instrumentation will be removed separately if all goes smoothly. Bug: 918565, 931895 Change-Id: I4de255731ee8251714132fdbea56777da4e4b440 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1549318 Commit-Queue: Nasko Oskov <nasko@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#652724}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/5cc5a8e61949..d8ce95982c94 git log 5cc5a8e61949..d8ce95982c94 --date=short --no-merges --format='%ad %ae %s' 2019-04-19 benjhayden@chromium.org Migrate alerts-table to es6 module Created with: gclient setdep -r src/third_party/catapult@d8ce95982c94 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:950011 TBR=charliea@chromium.org Change-Id: I378e1838dd38f166a8b72840fc3b02f033c946d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1575291Reviewed-by:
-
Yuwei Huang authored
We will introduce a new heartbeat sender that connects to the new directory server. This CL renames the old HeartbeatSender to XmppHeartbeatSender to prevent confusion. Bug: 954695 Change-Id: Ie29caedb55de0db2dd3d2e8801971c9ea015b164 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574653 Commit-Queue: Yuwei Huang <yuweih@chromium.org> Commit-Queue: Joe Downing <joedow@chromium.org> Reviewed-by:
Joe Downing <joedow@chromium.org> Cr-Commit-Position: refs/heads/master@{#652722}
-
Michael Thiessen authored
No functionality changes intended here, this should just be a no-op refactor. This refactor is to make it easier to land followup changes for spatial navigation here: https://chromium-review.googlesource.com/c/chromium/src/+/1562714/ Bug: 938534 Change-Id: Ia3c2b993db9e2055f7c42f209c3806dd08c34daf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1567081 Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#652721}
-
Martin Kreichgauer authored
There is a specialization in SetPinRequestHandler, but nothing ever calls ProvidePIN on the base class. Bug: 870892 Change-Id: I86564915b1ae2a1d0fe7996a5e23ec8e5d10ad39 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574643 Auto-Submit: Martin Kreichgauer <martinkr@google.com> Commit-Queue: Adam Langley <agl@chromium.org> Reviewed-by:
Adam Langley <agl@chromium.org> Cr-Commit-Position: refs/heads/master@{#652720}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/0ab4b3dfabf6..34a4af2494cc git log 0ab4b3dfabf6..34a4af2494cc --date=short --no-merges --format='%ad %ae %s' 2019-04-20 derat@chromium.org chromeos_config: Run Tast tests on VM PFQ builders. Created with: gclient setdep -r src/third_party/chromite@34a4af2494cc The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@chromium.org Change-Id: Ifae5ebe7da41fe53a0197fa56d80d2cfcb6eb798 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1575960Reviewed-by:
-
Harry Cutts authored
The copies in `EventConverterEvdevImplTest` and `InputInjectorEvdevTest` were exact duplicates, and I'm working on a CL that also needs it. Also renamed it to `FakeCursorDelegateEvdev`, since it doesn't log calls to its methods and so isn't really a mock. No behaviour changes should be caused by this CL. Bug: none Test: run `EventConverterEvdevImplTest` and `InputInjectorEvdevTest`. Change-Id: Iad54935e675bb2b253dcf6aa5c2bb0d9d9cae1be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559207Reviewed-by:
Michael Spang <spang@chromium.org> Commit-Queue: Harry Cutts <hcutts@chromium.org> Cr-Commit-Position: refs/heads/master@{#652718}
-
Vidal Diazleal authored
Tab titles in the devtools are not localizable, this PR makes the title function to actually use l10n tagged templates and fixes the following comment on the code: third_party\blink\renderer\devtools\front_end\Runtime.js // FIXME: should be Common.UIString() but runtime is not l10n aware yet. Change-Id: I4a651e2f1b4ef0e0e6d07b54d52e44c17aeda057 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1554648 Commit-Queue: Vidal Diazleal <vidorteg@microsoft.com> Reviewed-by:
Joel Einbinder <einbinder@chromium.org> Cr-Commit-Position: refs/heads/master@{#652717}
-
Hwanseung Lee authored
Use enum class instead of enum at MenuController enum class is more type safety. Bug: 940736 Change-Id: I9302a3d7cc5c4d4c8ffdfdbf758141ad34a417b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1569370Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Hwanseung Lee <hs1217.lee@samsung.com> Cr-Commit-Position: refs/heads/master@{#652716}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/990de7c7fcb5..80140adf0944 Created with: gclient setdep -r src-internal@80140adf0944 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=fdoray@chromium.org,bsep@chromium.org,keishi@chromium.org,chanli@chromium.org Change-Id: Icaf2cdb67c9fde554d39c84c8ae9524cb4e0cd5b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1576009Reviewed-by:
-
Dan Beam authored
Note: though I'm adding a new module, the additions to npm_exclude.txt shrink npm_modules.tar.gz by 200KB+ (4436810 -> 4216240). Bug: 954683 Change-Id: Ibbab9a954c4aa45f10fa5a3c3a1f3e694747d1ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1552415 Commit-Queue: Dan Beam <dbeam@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#652714}
-
John Rummell authored
If the per-device provisioning permission request happens multiple times within a 15 minute window, use the same response as the user choose before if the origin matches. This avoids problems where the user is prompted multiple times for the same site. BUG=950200 TEST=tested manually Change-Id: I8fcb73ebeed5e7ab60b38ab6b7213889f991bbb5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559491Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Commit-Queue: John Rummell <jrummell@chromium.org> Cr-Commit-Position: refs/heads/master@{#652713}
-
Peter Kasting authored
* Shorten code * Use helpers for repeated code * Fix case where we checked one child's classname, then cast a different child * Use base::size() * Use std::make_unique() * Use base::nullopt * Use View::Views * constexpr kConstant * Make GridLayoutTest.FixedSize consistent about loop nesting order * Make ViewTest.ChildViewZOrderChanged consistent about checking children, then layers Bug: none Change-Id: I871af00669e629176aa8fd2cc4cac2736629b3f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1575166 Auto-Submit: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#652712}
-
Tom Anderson authored
Real failures: chrome/browser/notifications/scheduler/impression_history_tracker.cc <= should be <. This could cause std::sort() to not work. False positives: chrome/browser/ui/cocoa/applescript/apple_event_util_unittest.mm chrome/utility/safe_browsing/mac/dmg_analyzer.cc components/viz/service/display/skia_renderer.cc: storage/browser/fileapi/obfuscated_file_util_memory_delegate.cc Taking the address of the first element of an empty vector. This would cause problems if we actually tried to dereference the pointer, but in all cases it is paired with a length variable that's 0. services/device/hid/hid_connection_impl.cc Taking the address of one-past the last element of a vector. This would cause problems if we actually tried to dereference the pointer, but it's just used as an end iterator. BUG=923166 TBR=sky Change-Id: I19a9ef1910fb5e26925cd957d7f0edaaaa4d8c1a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1575727 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Auto-Submit: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#652711}
-
Tim Song authored
The top notification may be clipped even though there is sufficient space to render the message center taller. BUG=954395 Change-Id: I5aade1b772d80640a2094bcb42365a75f75db837 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574956 Commit-Queue: Tim Song <tengs@chromium.org> Reviewed-by:
Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/heads/master@{#652710}
-
Eric Karl authored
Ensures that Android WebView works with SurfaceSynchronization enabled. For WebView, SurfaceSynchronization is nearly a no-op, as only one surface is ever in use. This change only does two real things: - Ensures that WebView uses RenderFrameMetadata rather than CompositorFrameMetadata where appropriate. - Ensures that SurfaceIds are correctly sent to the renderer for WebView, allowing for rendering to occur. Also removes previous disabling of WebView in tests. Bug: 881469 Change-Id: If01ebc3be54eb90ca3aa196a464de693ad69bed5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1570136Reviewed-by:
Stefan Zager <szager@chromium.org> Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Reviewed-by:
Saman Sami <samans@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Eric Karl <ericrk@chromium.org> Cr-Commit-Position: refs/heads/master@{#652709}
-
Hiroshige Hayashizaki authored
This CL adds the following methods that are used in upgrade-insecure-requests processing to FetchClientSettingsObject, and use them in FrameLoader::UpgradeInsecureRequest(): - GetInsecureRequestsPolicy() - GetUpgradeInsecureNavigationsSet() - GetMixedAutoUpgradeOptOut() Before this CL, upgrade-insecure-requests works based on ExecutionContext's SecurityContext, and thus uses the insideSettings' CSP list during off-the-main-thread worker script fetch. After this CL, upgrade-insecure-requests works via FetchClientSettingsObject and thus uses the outside settings object's CSP list correctly in off-the-main-thread worker script fetch. This CL doesn't cause behavior changes in dedicated workers because dedicated workers inherits the parent's CSP list. This CL probably affect behaviors in off-the-main-thread fetch for shared and service workers, but these are not covered by tests. Anyway OTMT for shared and service workers is still under development and will be tested and fixed in the future. Bug: 878274 Change-Id: I412845c9c7a866d22b97c501936d640fab99b71f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1570669 Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
Carlos IL <carlosil@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#652708}
-
David Benjamin authored
Bug: none Change-Id: I9c4a35aa6797230840f3436cbf66f35904dbf5cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1576010 Commit-Queue: Matt Mueller <mattm@chromium.org> Reviewed-by:
Matt Mueller <mattm@chromium.org> Auto-Submit: David Benjamin <davidben@chromium.org> Cr-Commit-Position: refs/heads/master@{#652707}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/f777fd10f59a..5cc5a8e61949 git log f777fd10f59a..5cc5a8e61949 --date=short --no-merges --format='%ad %ae %s' 2019-04-19 benjhayden@chromium.org Migrate scalar-span to es6 module 2019-04-19 benjhayden@chromium.org Migrate raised-button to es6 module. Created with: gclient setdep -r src/third_party/catapult@5cc5a8e61949 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:950011,chromium:950011 TBR=charliea@chromium.org Change-Id: Idee0eb527cd3f1e3af0a5dd12fce64fafd0b3d30 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1576139Reviewed-by:
-
Bret Sepulveda authored
Attempting to deflake Windows 10 bot. The test virtual/bidi-caret-affinity/editing/selection/modify_move/move-by-word-visually-crash-test-2.html is passing on some platforms and crashing on others. This patch adds Pass to the test's expectation. TBR=xiaochengh@chromium.org Bug: 894651, 954586 Change-Id: Ic0b0068269016cbd3de611f2059cf5364ff918e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1576159Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Commit-Queue: Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#652705}
-
Marcin Wiącek authored
Before: file contains many similar methods and variable definitions. After: there are created tables for integer and boolean values indexed by @IntDef, which are handled by two methods. It makes code and APK shorter. Change-Id: I549b288f53a7644601179b1477e8a05d2e9b2de7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1565311 Commit-Queue: Marcin Wiącek <marcin@mwiacek.com> Reviewed-by:
Donn Denman <donnd@chromium.org> Cr-Commit-Position: refs/heads/master@{#652704}
-
Wez authored
Exiting the Runner when it is not hosting any components saves memory but increases the time taken to launch new components, since the web.Context must be re-created from scratch each time. Fuchsia's Components v2 APIs will allow the system to teardown Runners to save resources when required, but for now just run until the system kills the Runner process/job. Bug: 952560 Change-Id: I5fdd220fbb1e0587d584f14a5447948e1d1d99bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1566766 Commit-Queue: Wez <wez@chromium.org> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#652703}
-
Harry Cutts authored
This was messing up the formatting on the rest of the line. Change-Id: I37263e8c7d2917b8b3bf620209282bfb576eb022 Bug: none Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1576014 Auto-Submit: Harry Cutts <hcutts@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Harry Cutts <hcutts@chromium.org> Cr-Commit-Position: refs/heads/master@{#652702}
-
Kevin Marshall authored
Allows the Agent to provide the Runner with the touch support policy for Cast applications. Bug: 953796 Change-Id: I3bd383e3df196c8217e5a0eb7da37fee6f6d83f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572246Reviewed-by:
Wez <wez@chromium.org> Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#652701}
-
Chris Lu authored
When calling CallJavaScriptFunction, the timeout being creating is expecting a value in seconds, but the constant is in milliseconds. Bug: 919685 Change-Id: Iae35a9fdbccaabf1c2c53ec650b75042bfb0cf87 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1575998Reviewed-by:
Chris Lu <thegreenfrog@chromium.org> Reviewed-by:
Mike Dougherty <michaeldo@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Cr-Commit-Position: refs/heads/master@{#652700}
-
- 19 Apr, 2019 3 commits
-
-
Bret Sepulveda authored
The test virtual/nobinary-for-devtools/http/tests/devtools/elements/highlight/highlight-display-locked.js does not exist, which is causing lint for the TestExpectations file to fail. This patch deletes that line. TBR=rakina@chromium.org Bug: 934458 Change-Id: I40ed3ddb425e462d89b0bf2647cc1c54dd928118 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1576219Reviewed-by:
-
Regan Hsu authored
This CL removes code Autofill section from OS-settings entirely, since it is not used by the OS. Bug: 950007 Change-Id: Ia59926a8861b329c5ab678e296bd91a6fda8a0ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574295Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
-
Reilly Grant authored
This change finishes wiring up the CONTENT_SETTINGS_TYPES_SERIAL_GUARD permission which can be used to entirely block the chooser UI shown by navigator.serial.requestPort(). As with the USB guard permission this needs special casing in the page info and site settings UIs because it can't be set to "allow," only "ask" or "block." Bug: 908836 Change-Id: I085c9e60e8a3cd6fa85ca0b18a58f359ef35e7f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1538681Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Commit-Queue: Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#652697}
-
