GitLab

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/4a60e311..89d5d57b

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org

Change-Id: I442adcb63453fef7daadc124855d22dc40661fa2
Reviewed-on: https://chromium-review.googlesource.com/936672Reviewed-by: v8 autoroll <v8-autoroll@chromium.org>
Commit-Queue: v8 autoroll <v8-autoroll@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539109}

Write out explicitly that these policies are intended to match the user
policy values, and that if they don't match, a chrome process restart
will be performed on user session start, leading to a delay.

BUG=800117
TEST=none

Change-Id: Ic458ac006d8ffe80460d3f021d0a8fb99837b63f
Reviewed-on: https://chromium-review.googlesource.com/926129Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org>
Commit-Queue: Pavol Marko <pmarko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539108}

https://skia.googlesource.com/skia.git/+log/a58cd1ba9fe8..904b08cf1fc0

$ git log a58cd1ba9..904b08cf1 --date=short --no-merges --format='%ad %ae %s'
2018-02-26 angle-skia-autoroll Roll skia/third_party/externals/angle2/ 81aa15f10..3582c0e2c (1 commit)

Created with:
  roll-dep src/third_party/skia


The AutoRoll server is located here: https://autoroll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
TBR=benjaminwagner@chromium.org

Change-Id: Ib92ecf5c43835ac872913e7eb67c14b0a98b4d27
Reviewed-on: https://chromium-review.googlesource.com/937062
Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#539107}

This CLs makes sure fullscreen videos don't enter automatically
Picture-in-Picture if the disablePictureInPicture attribute is set on
the video element.

Test page: https://beaufortfrancois.github.io/sandbox/media/disable-pip.html

Bug: 806249
Change-Id: I3621ef58c8f1778d54865eca6cc30a736994d493
Reviewed-on: https://chromium-review.googlesource.com/918421
Commit-Queue: François Beaufort <beaufort.francois@gmail.com>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539106}

This CL is just relanding https://chromium-review.googlesource.com/c/chromium/src/+/597482,
after confirming that there are no statistical significant regressions
in the real world by Finch experiments (crbug.com/755489).

Note that this might still cause Telemetry regressions reported at
crbug.com/753071 before, but this is expected.

A document is leaked because AutofillAgent hold a lastly used element
even after navigation happens, and the document of the element remains
until a new (input) element is focused. This CL fixes this issue by
resetting the element in AutofillAgent when navigation happens.

Bug: 734427, 755489
Change-Id: Ie3ee7f202abf56e22102e3d7f68cf2778f85ca87
Reviewed-on: https://chromium-review.googlesource.com/908371
Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org>
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539105}

Right now the file used to pass command line parameters to test-
processes is not removed after the test finished. In cases where tests
are run in repeat mode those flag files just keep accumulating until
the system runs out of space in it's $TMPDIR.

To solve this, the patch makes sure the path to the file containing the
flags is stored in UnitTestProcessLifetimeObserver and removed once
the OnCompleted method is called.

Bug: 814687
Change-Id: Ifb0ba6dba860d9297fbc2c939e0cc10f620907fa
Reviewed-on: https://chromium-review.googlesource.com/931341
Commit-Queue: Nico Weber <thakis@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539104}

When building the code with clang the compilation fails due to the
following error:
  "invalid use of a cast in a inline asm context requiring an l-value:
   remove the cast or build with -fheinous-gnu-extensions"

Doing the cast outside of __asm__ block fixes the problem.

R=jar@chromium.org

Bug: 794147
Change-Id: I49bcdbd3d4177cbdafa37ffc2d12983db1fe7621
Reviewed-on: https://chromium-review.googlesource.com/822411Reviewed-by: Will Harris <wfh@chromium.org>
Commit-Queue: Hugo Holgersson <hugoh@vewd.com>
Cr-Commit-Position: refs/heads/master@{#539103}

Bug: 782287
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I534f2b892efe8d2af08bbea6ee724c38509a55c9
Reviewed-on: https://chromium-review.googlesource.com/926581Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539102}

When only a single Tab is left after deleting tabs from a Window in
TabRestoreService, the Window should be converted to a Tab.

Fix another case where tabstrip_index was used incorrectly as it might
not be valid.

Bug: 407074
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I86f49969ea83a0771634be554541aab92334a967
Reviewed-on: https://chromium-review.googlesource.com/931706Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Christian Dullweber <dullweber@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539101}

https://chromium.googlesource.com/angle/angle.git/+log/81aa15f10682..3582c0e2c3c1

$ git log 81aa15f10..3582c0e2c --date=short --no-merges --format='%ad %ae %s'
2018-02-22 oetuaho Add a test for redefining an unavailable built-in

Created with:
  roll-dep src/third_party/angle


The AutoRoll server is located here: https://angle-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
TBR=geofflang@chromium.org

Change-Id: Ic4ac0d13123092c525e0a56f34e1f890512f8a19
Reviewed-on: https://chromium-review.googlesource.com/936436Reviewed-by: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#539100}

Using wpt-import in Chromium 8d963dab.

Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/12960

Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

TBR=danyao

No-Export: true
Change-Id: I37166a58ef4e1372355858bb8f15a213bac5470e
Reviewed-on: https://chromium-review.googlesource.com/937082
Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Reviewed-by: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539099}

Move FindEventTargetFrom() out of |Editor| to make class simpler for
improving code health.

BUG=672405
Signed-off-by: Zhuoyu Qian <zhuoyu.qian@samsung.com>
Change-Id: Ib8ed084702ffbb58eb438eb83d59ed0c43f71233
Reviewed-on: https://chromium-review.googlesource.com/933684Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Reviewed-by: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539098}

BUG=812293

Change-Id: I1375ecbdef13ea43ac350cdae6e550267166fadc
Reviewed-on: https://chromium-review.googlesource.com/934204Reviewed-by: Mike West <mkwst@chromium.org>
Commit-Queue: Jochen Eisinger <jochen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539097}

The latest spec changed DOMString type of Document.origin with USVString.
 - https://dom.spec.whatwg.org/#document

This CL applies USVString type into the Document.origin in order to meet the change.

Bug: 790860
Change-Id: Ibd1fafa28a6e999f7d3085aa7bb4cca0f92d8b2b
Reviewed-on: https://chromium-review.googlesource.com/928005
Commit-Queue: Gyuyoung Kim <gyuyoung.kim@lge.com>
Reviewed-by: Hayato Ito <hayato@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539096}

SchedulerWorker can touch SchedulerWorkerPoolImpl
through SchedulerWorker::delegate_->outer_.

This could cause use-after-free in tests (not a problem in prod because
we never join workers nor destroy the scheduler/pools) because
SchedulerWorkerPoolImpl no longer accounts for a SchedulerWorker
after invoking SchedulerWorker::Cleanup and hence will not join it
in JoinForTesting() before it is itself destroyed.

Before this CL: a SchedulerWorker could access SchedulerWorkerPoolImpl
after Cleanup() and hence potentially use after free if the pool is
destroyed before the detached thread completes execution.

This CL reinforces JoinForTesting() to wait for all workers that
ever had a reference to |this| (i.e. its |workers_| + any recently
reclaimed workers).

Added TaskSchedulerWorkerPoolTest.RacyCleanup as regression test although
it passes in most scenarios without the fix because this race is hard to
exercise...

And added a DCHECK on start that the requested pool size isn't greater than
kMaxNumberOfWorkers (as I tried to add 1000 worker in my new test and had to
debug why it hung until I rediscovered this intentional behavior).

Bug: 810464
Change-Id: Ibaefb5446d462c325e4ddfd34a54ad3c448c1417
Reviewed-on: https://chromium-review.googlesource.com/931547
Commit-Queue: Gabriel Charette <gab@chromium.org>
Reviewed-by: François Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539095}

Applies the same fix as https://crrev.com/c/924104 to
IntersectionObserver, too.

Unfortunately, I cannot reproduce the crash for IntersectionObserver,
and I'm not sure if this fix is actually effective or not.  However,
seeing the same fix worked (at least partially) for ResizeObserver,
I'd like to apply the same fix to IntersectionObserver, too.

Bug: 815058
Change-Id: I0e89cd56ab4915457178b38623daadc0be20c927
Reviewed-on: https://chromium-review.googlesource.com/934483
Commit-Queue: Yuki Shiino <yukishiino@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Hitoshi Yoshida <peria@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539094}

We used OriginalStyleForLayoutObject which doesn't update animations or
stacking context. Hopefully a better fix for 813348.

Bug: 813348, 813439, 813836
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I93584261a935c4813f618a9291d384a5b1203ec7
Reviewed-on: https://chromium-review.googlesource.com/924705Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Commit-Queue: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539093}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/6198dc41..4a60e311

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org

Change-Id: I08c0d9e6075b924bca01a3fa37ac7f3a4f6716a6
Reviewed-on: https://chromium-review.googlesource.com/937081Reviewed-by: v8 autoroll <v8-autoroll@chromium.org>
Commit-Queue: v8 autoroll <v8-autoroll@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539092}

Some application (e.g. Hangouts) closes the camera explicitly on system
suspend. As the Chrome OS VCD also closes the camera on system suspend
without going through the full destruction of the VideoCaptureDevice,
this results in StopAndDeAllocate being called back-to-back. The second
call to StopAndDeAllocate should simply return if the device context is
already destroyed.

BUG=b:73436939
TEST=unit tests
TEST=Verify that Hangouts call works correctly on Soraka when system
     suspends

Change-Id: Id6127b751ccc5bc71538d622bc0905bf03951e0d
Reviewed-on: https://chromium-review.googlesource.com/930605Reviewed-by: Wu-Cheng Li <wuchengli@chromium.org>
Commit-Queue: Ricky Liang <jcliang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539091}

Editor::PasteAsPlainText() is only called by
PasteAsPlainTextWithPasteboard() in EditorCommand.cpp. Move it to make
|Editor| class simpler for improving code health.

Bug: 672405
Signed-off-by: Zhuoyu Qian <zhuoyu.qian@samsung.com>
Change-Id: I02b43f067cea711e4b5e454fc8b28d5e4c33a7f0
Reviewed-on: https://chromium-review.googlesource.com/933665Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539090}

This patch introduces cors::PreflightController that will handle
URLLoader interfaces to make CORS-preflight request and response for
CORS-preflight enabled request from CORSURLLoader in the near future.

This will also own a unified CORS-preflight cache.

The first patch implements a function that takes an original
ResourceRequest and creates a ResourceRequest for a CORS-preflight
request.

Bug: 803766
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: Iad50a2d297e445bacca8c3fdb364b942d237b5aa
Reviewed-on: https://chromium-review.googlesource.com/923907
Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org>
Reviewed-by: Takeshi Yoshino <tyoshino@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539089}

This patch introduces |getSelectionInFlatTree()| in |window.internals| and
utilize it into |selection_test()| to write tests for selection in shadow DOM
tree, e.g. selection in INPUT[1].

The return value of |getSelectionInFlatTree()| is |StaticSelection|, which is
introduced by this patch.

Changes in "assert_selection.js" and "assert_selection.html" shows how to use
|getSelectionInFlatTree()| and |StaticSelection|.

Expectation of "fast/dom/shadow/selection-in-nested-shadow.html" is updated to
show actual selection position instead of adjusted to document scope selection,
e.g. selection in shadow root is adjusted to selection before shadow host in
document scope.

[1] http://crrev.com/c/930841 Sanitize computed start and end positions

Change-Id: Ib871c77dd16834459297b68b6664a93d6dce57c7
Reviewed-on: https://chromium-review.googlesource.com/934062Reviewed-by: Kent Tamura <tkent@chromium.org>
Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org>
Commit-Queue: Yoshifumi Inoue <yosin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539088}

Web IDL has no definition of bool/int.
We should use boolean and long instead.


Bug: 816352
Change-Id: Icf55c6adda4898e0490b51a46e2755dd432f4552
Reviewed-on: https://chromium-review.googlesource.com/936347Reviewed-by: Yuki Shiino <yukishiino@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Kenichi Ishibashi <bashi@chromium.org>
Commit-Queue: Hitoshi Yoshida <peria@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539087}

This CL replaces a legacy Closure in OpenFileCallback with OnceClosure
as a preparation of the full migration of fileapi to OnceCallback.
As it's in a function signature, it had blocked the incremental
migration.

Change-Id: I53471c0a178687fcb9ab97365e0421a124fc3575
Reviewed-on: https://chromium-review.googlesource.com/933883Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Reviewed-by: Naoki Fukino <fukino@chromium.org>
Commit-Queue: Taiju Tsuiki <tzik@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539086}

This CL exposes a new internal setting that determines whether
Picture-in-Picture is enabled and if the user has disabled
Picture-in-Picture for Chrome using the system's per-application
settings. This setting is used in document.pictureInPictureEnabled and
video.requestPictureInPicture().

Test page: https://beaufortfrancois.github.io/sandbox/media/picture-in-picture-enabled
Screenshots: https://i.imgur.com/nLL3l0U.png
Recording: https://drive.google.com/file/d/1DgIH8XPPGr7giPvaFQ8bvDd_WM-1lzSj/view

Bug: 806249
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation;master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I6a4a8ca69c8b53a4bce3d8375c16725b3e545d52
Reviewed-on: https://chromium-review.googlesource.com/922081Reviewed-by: Maria Khomenko <mariakhomenko@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Reviewed-by: Nasko Oskov <nasko@chromium.org>
Commit-Queue: François Beaufort <beaufort.francois@gmail.com>
Cr-Commit-Position: refs/heads/master@{#539085}

MatchesPattern can be called from multiple threads on single process
mode, and this caused crash on ASAN-built Chromium. This CL fixes this
issue by making MatchesPattern thread-safe.

Bug: 812182
Change-Id: Ibbb3df96264e28fffd0b8e0581f36c6294e02036
Reviewed-on: https://chromium-review.googlesource.com/921302
Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org>
Reviewed-by: Evan Stade <estade@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539084}

This reverts commit 588d8a94.

Reason for revert: Some CTS/GTS tests has failed due to the CL.

Original change's description:
> v4l2: Remove GLImage from OutputRecord
> 
> When GLImages were introduced to v4l2 in crrev.com/c/517883 to replace
> EGLImages, a scoped ref to a GLImage was added to OutputRecord in place of
> the EGLImage.
> 
> This was not necessary since when we bind the GLImage in GLES2 cmd decoder,
> the decoder increases the ref count and keeps the GLImage alive.
> 
> Additionally, copying the scoped_refptr<GLImage> in a different
> thread than it was created, when we associate GLImage to OutputRecords,
> causes a DCHECK to go off.
> 
> This CL removes GLImage scoped_refptr from
> V4L2SliceVideoDecodeAccelerator::OutputRecord.
> 
> 
> Test: Youtube video on scarlet. Tried to close and open new tabs with videos.
> Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
> Change-Id: Idd2625996b177be35b7a67eab3d9ac8b3f8206d7
> Reviewed-on: https://chromium-review.googlesource.com/911841
> Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
> Reviewed-by: Miguel Casas <mcasas@chromium.org>
> Commit-Queue: Daniele Castagna <dcastagna@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#536139}

TBR=dalecurtis@chromium.org,mcasas@chromium.org,dcastagna@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Change-Id: Iafc4e43b6d99de251d18c45ec1efcb901d8a2e79
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Reviewed-on: https://chromium-review.googlesource.com/936882Reviewed-by: Pawel Osciak <posciak@chromium.org>
Commit-Queue: Hirokazu Honda <hiroh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539083}

QuicChromiumClientSession::CreateOutgoingDynamicStream() implementation
is replaced with NOTREACHED, and moved to a new function for testing
purposes only.

Bug: 656607
Change-Id: Idfcf2f96de59fd57d61395c142f6e60dec677e26
Reviewed-on: https://chromium-review.googlesource.com/934285Reviewed-by: Ryan Hamilton <rch@chromium.org>
Commit-Queue: Ramin Halavati <rhalavati@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539082}

Editor::DeleteWithDirection() is only called in EditorCommand.cpp. Move
it to make |Editor| class simpler for improving code health.

BUG=672405
Signed-off-by: Zhuoyu Qian <zhuoyu.qian@samsung.com>
Change-Id: I54d47bf44f6baa73bac2c54f767331f56f500352
Reviewed-on: https://chromium-review.googlesource.com/934382
Commit-Queue: Yoshifumi Inoue <yosin@chromium.org>
Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539081}

Change-Id: I12afb94b6e5b920e08b3d5bf6a0a5897e54af41c
Bug: 815367
Reviewed-on: https://chromium-review.googlesource.com/935838Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Paul Irish <paulirish@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539080}

Before, when we got a navigation for an in-scope URL we would cancel the
navigation, and start a new navigation in a new app window. This
resulted in the new app window losing its 'window.opener' and the
window that initiated the navigation losing its reference to the new
window.

Now, for initial navigations, we move the WebContents to a new app
window and continue the navigation as usual. This results in new
windows with `window.opener` keeping their openers.

Bug: 804881
Change-Id: Id0a32824cf7f9d57a9e32239e2e11ce952e91487
Reviewed-on: https://chromium-review.googlesource.com/923902
Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Reviewed-by: Matt Giuca <mgiuca@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539079}

Editor::TidyUpHTMLStructure() is moved to EditingCommandsUtilities in
crrev.com/c/908388 miss removing the declaration in Editor.h, remove it.

Bug: 672405
Signed-off-by: Zhuoyu Qian <zhuoyu.qian@samsung.com>
Change-Id: I6c5276ba93d0e45e0cdd82b42b9d1aebbdb6a1c0
Reviewed-on: https://chromium-review.googlesource.com/933666
Commit-Queue: Yoshifumi Inoue <yosin@chromium.org>
Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539078}

Editor::PasteAsFragment() is called by PasteWithPasteboard() in
EditorCommand.cpp. Move it to make |Editor| class simpler for improving
code health.

BUG=672405
Signed-off-by: Zhuoyu Qian <zhuoyu.qian@samsung.com>
Change-Id: Ia6c2d5f4ecb936e9fade8437fb8db1ebae508ded
Reviewed-on: https://chromium-review.googlesource.com/933683
Commit-Queue: Yoshifumi Inoue <yosin@chromium.org>
Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539077}

According the mock (http://shortn/_WV9xAY7nir), the text "Placeholder"
in the text field and the paper airplane icon in the notification reply
should be transparent white. After inputting text, they should be opaque
white.

However, they were transparent black. After inputting text, they were
opaque black.

This CL fixes the color of them.

BUG=815134
TEST=manual

Change-Id: I68d5ef9373c1cc537e05aa6785c724a55b95b137
Reviewed-on: https://chromium-review.googlesource.com/934482Reviewed-by: Yoshiki Iguchi <yoshiki@chromium.org>
Reviewed-by: Tetsui Ohkubo <tetsui@chromium.org>
Commit-Queue: Megumi Hattori <megumihattori@google.com>
Cr-Commit-Position: refs/heads/master@{#539076}

They caused parsing errors because strings produced by them were not
escaped.

This CL fixes 27 failures in WPT.

Bug: 351767
Change-Id: I6ac10572cf63b0e8cdc6cd357631257a6a470be6
Reviewed-on: https://chromium-review.googlesource.com/936983Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Commit-Queue: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539075}

This CL adds extension actions to the Hosted App window frame and menu
by:
- decoupling the BrowserActionsContainer from ToolbarView via a Delegate
- adding a BrowserActionsContainer to the HostedAppButtonContainer with
  a custom ToolbarActionsBar which only displays only the popped out action

Bug: 762401
Change-Id: I24c607d3111bc48e75e26c880cbd91d59d69b7e6
Reviewed-on: https://chromium-review.googlesource.com/897383
Commit-Queue: calamity <calamity@chromium.org>
Reviewed-by: Trent Apted <tapted@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539074}

This CL replaces all usage of legacy base::Bind and base::Callback in
//storage/browser/quota.

Change-Id: I03916561d22dd888bf5356a66bc74683af9a3799
Reviewed-on: https://chromium-review.googlesource.com/930103
Commit-Queue: Taiju Tsuiki <tzik@chromium.org>
Reviewed-by: Martin Šrámek <msramek@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539073}

Following bot results are included.
3923 3927 3933 3934 3942 3937

5 lines were removed and 17 lines were deflaked by consecutive results
since 3881.

TBR=eae@chromium.org
NOTRY=true

Bug: 591099
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng
Change-Id: Id240d57e9809ce44e6298dadb63e86b9edad9114
Reviewed-on: https://chromium-review.googlesource.com/934463
Commit-Queue: Koji Ishii <kojii@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539072}

This is part of efforts to replace base::ThreadTaskRunnerHandle::Get()
and SequencedTaskRunnerHandle::Get() with other appropriate task runners
in the renderer.

Bug: 780785, 786332
Change-Id: Ic9801a4896dd4d9a70f9b9fa4f5b26dc474db224
Reviewed-on: https://chromium-review.googlesource.com/930524Reviewed-by: Alexander Timin <altimin@chromium.org>
Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539071}

R=rockot@chromium.org

Change-Id: I37bb122815288605e5df28ba9090eff02de8c864
Reviewed-on: https://chromium-review.googlesource.com/887023Reviewed-by: Ken Rockot <rockot@chromium.org>
Commit-Queue: Ken Rockot <rockot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539070}