GitLab

BUG=444049

Review URL: https://codereview.chromium.org/1060933003

Cr-Commit-Position: refs/heads/master@{#327118}

Adds an interface to ViewsDelegate to get a TaskRunner for a thread that
can be used for initialization tasks (implemented using the FILE thread),
and passes that TaskRunner to the ATK accessibility initialization code,
which currently does I/O on the main thread, causing a perf issue.

This change just adds the plumbing to get the TaskRunner there.
This will be followed up by this change that actually moves the initialization
to the other thread: https://codereview.chromium.org/1028553003/

BUG=468112

Review URL: https://codereview.chromium.org/1089003003

Cr-Commit-Position: refs/heads/master@{#327117}

Revert of Limit form-less Autofilling to pages that look like checkout pages. (patchset #7 id:120001 of https://codereview.chromium.org/1081803003/)

Reason for revert:
Caused compile error on Win x64 GN bot

Original issue's description:
> Limit form-less Autofilling to pages that look like checkout pages.
>
> This should hopefully stem the tide of false positives on non-checkout pages, while preserving desired behavior on Best Buy and Apple checkout.
>
> Fixing FormStructureBrowserTests: I went back and added <form>s that were present in the source pages but not in the local copies. I also added the original <title> tags, except for ones that did /not/ include any of the checkout keywords. For these, I added the checkout keywords to the title, so that the test still had some value (instead of passing trivially because the title was "Google Calendar" and not something like "Payment information").
>
> BUG=471090,477466
>
> Committed: https://crrev.com/aa3219ce27ef5471c19670fe5145b136925cbc89
> Cr-Commit-Position: refs/heads/master@{#327108}

TBR=thestig@chromium.org,brettw@chromium.org,estade@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=471090,477466

Review URL: https://codereview.chromium.org/1106313002

Cr-Commit-Position: refs/heads/master@{#327116}

Revert of Switch to STA mode for audio thread and WASAPI I/O streams. (patchset #9 id:200001 of https://codereview.chromium.org/1097553003/)

Reason for revert:
Does not seem to have helped anything, crashes are still present and UMA metrics are unchanged. If anything it may have caused issues like: http://crbug.com/480476 and http://crbug.com/481581

Original issue's description:
> Switch to STA mode for audio thread and WASAPI I/O streams.
>
> Using COM marshalling to share necessary worker thread pointers
> with the render and capture threads.
>
> BUG=422522
> TEST=all unit tests pass, audio input and output work.
>
> Committed: https://crrev.com/43f3b0d25752d924390a4d6fc868d6e9469edc4f
> Cr-Commit-Position: refs/heads/master@{#326360}

TBR=tommi@chromium.org,henrika@chromium.org,mcasas@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=422522

Review URL: https://codereview.chromium.org/1111503003

Cr-Commit-Position: refs/heads/master@{#327115}

- Use webview.addContentScripts to to inject js;
- Enable crendential passing tests;
- Make the test listen for authFlowChange event only when needed
  because it is fired on every auth page load now to correctly
  propagate the auth domain change;

BUG=467068

Review URL: https://codereview.chromium.org/1066573003

Cr-Commit-Position: refs/heads/master@{#327114}

It might be possible that animator is destroyed when desstruct CallbackAnimationObserver.
Use a scoped_refptr to make sure it wont happen.

BUG=478016

Review URL: https://codereview.chromium.org/1094863005

Cr-Commit-Position: refs/heads/master@{#327113}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/6554837..1e14c28

TBR=tkent@chromium.org,pdr@chromium.org

Review URL: https://codereview.chromium.org/1108063003

Cr-Commit-Position: refs/heads/master@{#327112}

The new implementation is activated when USE_GCD=1 at build time.

BUG=471928

Review URL: https://codereview.chromium.org/1094133003

Cr-Commit-Position: refs/heads/master@{#327111}

Add trace event inside each read notification for evdev.

BUG=none
TEST=chrome://tracing in link_freon

Review URL: https://codereview.chromium.org/1110693003

Cr-Commit-Position: refs/heads/master@{#327110}

Implemented CRUContextMenuController as a bridge backed up by
UIActionSheet on iOS7 and UIAlertController on iOS8.

BUG=410299,437781
TEST=
Context menu works on iPhone/iPad with iOS7/iOS8 for:
- web links and images
- bookmarks
- recently visited items on NTP

Review URL: https://codereview.chromium.org/1103743002

Cr-Commit-Position: refs/heads/master@{#327109}

This should hopefully stem the tide of false positives on non-checkout pages, while preserving desired behavior on Best Buy and Apple checkout.

Fixing FormStructureBrowserTests: I went back and added <form>s that were present in the source pages but not in the local copies. I also added the original <title> tags, except for ones that did /not/ include any of the checkout keywords. For these, I added the checkout keywords to the title, so that the test still had some value (instead of passing trivially because the title was "Google Calendar" and not something like "Payment information").

BUG=471090,477466

Review URL: https://codereview.chromium.org/1081803003

Cr-Commit-Position: refs/heads/master@{#327108}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/f0c000d..385e26e

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=humper@google.com

Review URL: https://codereview.chromium.org/1109923002

Cr-Commit-Position: refs/heads/master@{#327107}

Also makes the radio buttons accessible and makes it possible to click anywhere on the color tiles to select the corresponding radio button.

BUG=none

Review URL: https://codereview.chromium.org/1102033005

Cr-Commit-Position: refs/heads/master@{#327106}

Due to a misunderstanding on my part, the initial implementation represented the "waiting" state, which is used while waiting for a network response in a Chrome tab. Most throbbers should use the "normal"/"spinning" state. This ports the CSS animations in MD_spinner_blue.svg to skia commands, and uses it in the card unmasking dialog.

After some investigation, I've realized that very few places in Chrome actually use the Throbber class. Tabs, for example, draw directly onto a canvas. So the next step will be to refactor this functionality into a ThrobberPainter class so tabs can use it. The reason I am not already doing this is I want to verify with the designers that this version looks good before I work on bringing it to more of Chrome.

BUG=259556, 473342

Review URL: https://codereview.chromium.org/1098853005

Cr-Commit-Position: refs/heads/master@{#327105}

The original CL had non-determinism in the unit test.

> Delete session cookies immediately after loading the cookie DB.
>
> Previously, the session cookies were deleted after all cookies were loaded into
> memory. This allows for a race condition where new session cookies are inserted
> into the database while the cookies are being loaded into memory, which causes
> the new session cookies to also be deleted.
>
> BUG=
>
> Committed: https://crrev.com/ca924dcfb4f3c6b89e0c40898e42aec349b6b843
> Cr-Commit-Position: refs/heads/master@{#326672}

BUG=

Review URL: https://codereview.chromium.org/1103003002

Cr-Commit-Position: refs/heads/master@{#327104}

Revert of Move ScopedFileDescriptor to dbus/file_descriptor.h (patchset #1 id:1 of https://codereview.chromium.org/1090243003/)

Reason for revert:
Breaks shared_library build with broken exports:

./../dbus/dbus_export.h:20:65: error: ignoring attributes applied to class type 'scoped_ptr<dbus::FileDescriptor, dbus::FileDescriptor::Deleter>' outside of definition [-Werror=attributes]
 #define CHROME_DBUS_EXPORT __attribute__((visibility("default")))
                                                                 ^
../../dbus/file_descriptor.h:81:57: note: in expansion of macro 'CHROME_DBUS_EXPORT'
     scoped_ptr<FileDescriptor, FileDescriptor::Deleter> CHROME_DBUS_EXPORT;

Original issue's description:
> Move ScopedFileDescriptor to dbus/file_descriptor.h
>
> ScopedFileDescriptor was initially introduced to facilitate the
> management of a 'lifeline' FD used when asking permission_broker to
> open a port in the device's firewall on CrOS.  It's actually a scoped
> wrapper around DBus::FileDescriptor, not a platform file descriptor. I
> would like to use it to facilitate some other similar functionality in
> which I create a pipe and pass one end over DBus, so it seems like a
> good idea to move ScopedFileDescriptor into the dbus library directly.
>
> BUG=chromium:481340
> TEST=FirewallHole unit tests still pass
> STATUS=Fixed
> R=keybuk, reillyg, stevenjb
>
> Committed: https://crrev.com/b44fbaabbe9f91e63ad8aa164609a6b31e0de57e
> Cr-Commit-Position: refs/heads/master@{#327089}

TBR=keybuk@chromium.org,reillyg@chromium.org,stevenjb@chromium.org,cmasone@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=chromium:481340

Review URL: https://codereview.chromium.org/1108893003

Cr-Commit-Position: refs/heads/master@{#327103}

Revert of Suppress data races in SkEventTracer (patchset #1 id:1 of https://codereview.chromium.org/1081863003/)

Reason for revert:
I think this is fixed.

Original issue's description:
> Suppress data races in SkEventTracer
>
> BUG=437044
> TBR=mtklein@chromium.org
>
> Committed: https://crrev.com/f0a9e71e6ad0b13397d45afeeeba7c0ced15b570
> Cr-Commit-Position: refs/heads/master@{#326024}

TBR=mtklein@chromium.org,glider@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=437044

Review URL: https://codereview.chromium.org/1111433002

Cr-Commit-Position: refs/heads/master@{#327102}

It's redundant with the bit in GetSSLInfo and state already maintained by the
SSLClientSocket implementations.

BUG=477847

Review URL: https://codereview.chromium.org/1103173004

Cr-Commit-Position: refs/heads/master@{#327101}

This reverts commit 735aa03b AKA refs/heads/master@{#326404}
Reverting because it caused a bug which is currently the top crasher on canary.

Original description: Ensure we properly set PageTransition for iframes.
 We currently don't set subframe navigations as manual when it isn't the first
 navigation of the iframe. Also, we don't propagate the state correctly in the
 case of a cross-process transition.

 Original Review URL: https://codereview.chromium.org/1002953004

 Original Cr-Commit-Position: refs/heads/master@{#326404}

TBR=creis@chromium.org, japhet@chromium.org
BUG=464014,480839

Review URL: https://codereview.chromium.org/1108863002

Cr-Commit-Position: refs/heads/master@{#327100}

R=spang
BUG=444048

Review URL: https://codereview.chromium.org/1110693002

Cr-Commit-Position: refs/heads/master@{#327099}

The official build returned a different board name with pattern "swanky*".

BUG=467643

Review URL: https://codereview.chromium.org/1110673002

Cr-Commit-Position: refs/heads/master@{#327098}

BUG=475940
TBR=hubbe@chromium.org, simonhatch@chromium.org

Review URL: https://codereview.chromium.org/1110663002

Cr-Commit-Position: refs/heads/master@{#327097}

In WebUIUserScriptLoader, if it is incognito mode, we need to get the
OffTheRecordContext and pass it to URLfetchers to load user scripts.
Currently, UserScriptLoader can only refer to regular profiles.
To fix this, we pass in a flag to show whether it is incognito mode
when adding scripts. We are able to choose the correct profile pointer
by using this flag.

BUG=461052

Review URL: https://codereview.chromium.org/1062963006

Cr-Commit-Position: refs/heads/master@{#327096}

Change the developerPrivate API to uniformly use base-64 data urls for icons,
rather than relying on the custom url handler.

BUG=461039

Review URL: https://codereview.chromium.org/1092953004

Cr-Commit-Position: refs/heads/master@{#327095}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/d3c652f0..df4cf97d

Please follow these instructions for assigning/CC'ing issues:
https://code.google.com/p/v8-wiki/wiki/TriagingIssues

TBR=hablich@chromium.org,machenbach@chromium.org,yangguo@chromium.org,vogelheim@chromium.org

Review URL: https://codereview.chromium.org/1106223002

Cr-Commit-Position: refs/heads/master@{#327094}

Revert of cc: Remove tile sharing from tilings. (patchset #20 id:380001 of https://codereview.chromium.org/1051993002/)

Reason for revert:
Several failures happened as a result.

Original issue's description:
> cc: Remove tile sharing from tilings.
>
> This patch removes sharing tiles from tilings. Previously, tiles
> that were not invalidated were shared between the pending and
> the active trees. With this patch, tiles that are exist on the
> active tree and are not invalidated are not created on the pending
> tree, resulting in fewer overall tiles. This improves performance
> of updating and managing tiles.
>
> Also, this patch opens up opportunities for a lot of code clean
> up that can otherwise be confusing when two trees are involved.
>
> R=danakj, enne
>
> Committed: https://crrev.com/0061b75e810f088900a0a8fbdd29ba5595c73016
> Cr-Commit-Position: refs/heads/master@{#326804}

TBR=enne@chromium.org,danakj@chromium.org,timford35@gmail.com
BUG=481421, 481509, 481480

Review URL: https://codereview.chromium.org/1108773003

Cr-Commit-Position: refs/heads/master@{#327093}

Revert of [Android] Stop hiding the RWHV layer subtree when hiding the widget (patchset #12 id:330001 of https://codereview.chromium.org/1001573003/)

Reason for revert:
Speculative fix for blank display after cold startup.

Original issue's description:
> Reland "[Android] Preserve the front buffer when the activity is paused"
>
> This change was reverted in r322170 due to WebView breakage. The
> ApplicationStatus dependency has been made optional, allowing
> WebView to opt-out of its use.
>
> Original description: ----------------------------
>
> Currently, when an activity is stopped, we explicitly hide the
> foreground Tab. This is problematic, as current hiding semantics
> might clear the visual front buffer before the window is hidden.
> This in turn causes an unpleasant flickering during activity
> transitions, e.g., when backgrounding Chrome or locking the screen.
>
> Wire Activity onPause/onResume notifications to WindowAndroidObservers,
> allowing the foreground tab to preserve its front buffer while hiding
> its web content. If the tab is explicitly hidden, or the root window
> is lost, the front buffer will be cleared as usual.
>
> BUG=462752,434401
>
> Committed: https://crrev.com/7954daf991a2adda234dc2e886b2d1ddf0049221
> Cr-Commit-Position: refs/heads/master@{#322228}

TBR=sievers@chromium.org,dtrainor@chromium.org,tedchoc@chromium.org,piman@chromium.org,boliu@chromium.org,torne@chromium.org
BUG=481450,481115,434401

Review URL: https://codereview.chromium.org/1109863003

Cr-Commit-Position: refs/heads/master@{#327092}

GCD App already uses gcdPrivate.createSession.

BUG=461504

Review URL: https://codereview.chromium.org/1103603002

Cr-Commit-Position: refs/heads/master@{#327091}

This change centers the distiller results page. This will only
affect the desktop version and is purely for developer sanity
as desktop distiller is not officially supported.

BUG=

Review URL: https://codereview.chromium.org/1109853002

Cr-Commit-Position: refs/heads/master@{#327090}

ScopedFileDescriptor was initially introduced to facilitate the
management of a 'lifeline' FD used when asking permission_broker to
open a port in the device's firewall on CrOS.  It's actually a scoped
wrapper around DBus::FileDescriptor, not a platform file descriptor. I
would like to use it to facilitate some other similar functionality in
which I create a pipe and pass one end over DBus, so it seems like a
good idea to move ScopedFileDescriptor into the dbus library directly.

BUG=chromium:481340
TEST=FirewallHole unit tests still pass
STATUS=Fixed
R=keybuk, reillyg, stevenjb

Review URL: https://codereview.chromium.org/1090243003

Cr-Commit-Position: refs/heads/master@{#327089}

Ash.NumberOfVisibleWindowsInPrimaryDisplay was incorrectly being recorded at the
login and lock screen.

TEST=UserMetricsRecorderTest.VerifyIsUserInActiveDesktopEnvironmentValues
TEST=UserMetricsRecorderTest.VerifyStatsRecordedWhenUserNotInActiveDesktopEnvironment
TEST=UserMetricsRecorderTest.VerifyStatsRecordedWhenUserInActiveDesktopEnvironment
TEST=UserMetricsRecorderTest.VerifyStatsRecordedByRecordPeriodicMetrics

BUG=477538

Review URL: https://codereview.chromium.org/1093483002

Cr-Commit-Position: refs/heads/master@{#327088}

Summary of changes available at:
https://chromium.googlesource.com/chromium/src/third_party/freetype2/+log/495a23fce9cd..1dd5f5f4a90

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

This updates from Precise FreeType 2.4.8-1ubuntu2.1 to 2.4.8-1ubuntu2.2.

BUG=454426

Review URL: https://codereview.chromium.org/1108843002

Cr-Commit-Position: refs/heads/master@{#327087}

BUG=481533

Review URL: https://codereview.chromium.org/1108843003

Cr-Commit-Position: refs/heads/master@{#327086}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/6393c06..f0c000d

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=humper@google.com

Review URL: https://codereview.chromium.org/1102363003

Cr-Commit-Position: refs/heads/master@{#327085}

Recent changes to page scale initialization and defaults mean we ended
up with page scale = 0.25 (previously 1) on ATV.

BUG=internal b/20418423

Review URL: https://codereview.chromium.org/1075043004

Cr-Commit-Position: refs/heads/master@{#327084}

In linux_based_platform_backend a print message for debugging information
snuck its way in. This gets rid of that.

BUG=

Review URL: https://codereview.chromium.org/1110543004

Cr-Commit-Position: refs/heads/master@{#327083}

This avoids creation of an extra file thread in BasicURLRequestContext
and fixes linked bug

BUG=475213

Review URL: https://codereview.chromium.org/1082803004

Cr-Commit-Position: refs/heads/master@{#327082}

Also updates a few related files that had become stale relative to
downstream.

BUG=464810

Review URL: https://codereview.chromium.org/1107083002

Cr-Commit-Position: refs/heads/master@{#327081}

This fixes the regression in http://crbug.com/480381 where 'activate'
event is not fired for menu items under a grouping div rather than
being direct children of a Menu. Also fixes js error when hovering
such menu items.

BUG=480381

Review URL: https://codereview.chromium.org/1095303004

Cr-Commit-Position: refs/heads/master@{#327080}

Moves all logic for deciding the availability of the upgrade menu item into the visibility check. Also extends a test to prevent future regressions.

BUG=475971

Review URL: https://codereview.chromium.org/1061663003

Cr-Commit-Position: refs/heads/master@{#327079}